[edk2-devel] [edk2-redfish-client][PATCH V2] RedfishClientPkg: Add ETag PCD and revise Redfish ETag functions

From: Abner Chang Add PCD to disable ETag capability for the case Redfish service doesn't support ETag. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Mike Maslenkin --- RedfishClientPkg/RedfishClientPkg.dec | 2 + .../RedfishFeatureUtilityLib.inf

Re: [edk2-devel] [edk2-redfish-client][PATCH 4/4] RedfishClientPkg/Features: introduce boot option

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Thursday, January 4, 2024 1:10 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-redfish-client][PATCH 4/4]

Re: [edk2-devel] [edk2-redfish-client][PATCH 3/4] RedfishClientPkg/Features: introduce boot option collection

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Thursday, January 4, 2024 1:10 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-redfish-client][PATCH 3/4]

Re: [edk2-devel] [edk2-redfish-client][PATCH 2/4] RedfishClientPkg/ConverterLib: fix GCC build error

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Thursday, January 4, 2024 1:09 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-redfish-client][PATCH 2/4]

Re: [edk2-devel] [edk2-redfish-client][PATCH 1/4] RedfishClientPkg: add ETag to Redfish resource check function

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Thursday, January 4, 2024 1:09 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-redfish-client][PATCH 1/4] RedfishClientPkg:

[edk2-devel] [edk2][PATCH V2 2/2] DynamicTablesPkg/SsdtSerialPortFixupLib: Add Interrupt node for SPIs only

Add interrupt node to the AML description of the serial-port only if the IRQ ID from the Configuration Manager is a valid SPI (shared processor interrupt) or an extended SPI. So, for DBG2 UART ports where interrupt is not mandatory, adding of an interrupt node in the AML description using Serial

[edk2-devel] [edk2][PATCH V2 1/2] ArmPkg/ArmGicArchLib: Add macros for SPI and extended SPI ranges

Taking reference from Table 2-1 of the Arm Generic Interrupt Controller Architecture Specification, Issue H, January 2022, add macros for the SPI and extended SPI ranges with the purpose of reusability on including the ArmPkg. Signed-off-by: Himanshu Sharma ---

[edk2-devel] [edk2][PATCH V2 0/2] Update handling of interrupt node for SSDT Serial Port Fixup Library

Currently in the Dynamic Tables Framework, the interrupt node for the AML description of the serial-ports is populated using the template and so is mandatorily added even if the serial-port is enumerated as a DBG2 port in the platform's configuration manager where the interrupt is not mandatory.

[edk2-devel] [edk2-redfish-client][PATCH 4/4] RedfishClientPkg/Features: introduce boot option

- Introduce Redfish boot option driver and library. This is to support Redfish resource at: /redfish/v1/Systems/SYSTEM_ID/BootOptions - Make ETag parameter as optional parameter in CreatePayloadToPatchResource function. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick

[edk2-devel] [edk2-redfish-client][PATCH 3/4] RedfishClientPkg/Features: introduce boot option collection

Introduce Redfish boot option collection driver and library. This is to support Redfish resource at: /redfish/v1/Systems/SYSTEM_ID/BootOptions Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishClientComponents.dsc.inc | 4 +-

[edk2-devel] [edk2-redfish-client][PATCH 2/4] RedfishClientPkg/ConverterLib: fix GCC build error

Address below GCC build error: variable 'CsParentJson' set but not used [-Werror=unused-but-set-variable] Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../BootOption.V1_0_4/BootOption.V1_0_4.c | 1005 - .../BootOptionCollection.c

[edk2-devel] [edk2-redfish-client][PATCH 1/4] RedfishClientPkg: add ETag to Redfish resource check function

Add ETag parameter to RedfishCheckResourceCommon(). When the ETag from Redfish resource is not changed, feature driver can skip the check function. This helps to improve the feature driver performance. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez ---

[edk2-devel] [edk2-redfish-client][PATCH 0/4] Introduce Redfish boot option drivers

Introduction Redfish boot option collection and boot option drivers to support Redfish resource at /redfish/v1/Systems/SYSTEM_ID/BootOptions. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Nickle Wang (4): RedfishClientPkg: add ETag to Redfish resource

Re: [edk2-devel] [edk2-redfish-client][PATCH v2 00/10] RedfishClientPkg: introduce Redfish HTTP cache library

[AMD Official Use Only - General] For this patch set, Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Thursday, January 4, 2024 10:31 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-redfish-client][PATCH

Re: [edk2-devel] [edk2-redfish-client][PATCH 01/10] RedfishClientPkg: introduce Redfish HTTP cache library

kyy ; Nick Ramirez > Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH 01/10] RedfishClientPkg: > introduce Redfish HTTP cache library > > External email: Use caution opening links or attachments > > > [AMD Official Use Only - General] > > Hi Nickle, > I have no

[edk2-devel] [edk2-redfish-client][PATCH v2 10/10] RedfishClientPkg/RedfishFeatureUtilityLib: use HTTP cache lib

Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishFeatureUtilityLib.inf | 3 +- .../Library/RedfishFeatureUtilityLib.h| 21 +- .../RedfishFeatureUtilityInternal.h

[edk2-devel] [edk2-redfish-client][PATCH v2 09/10] RedfishClientPkg/RedfishVersionLib: use HTTP cache lib

Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishVersionLib/RedfishVersionLib.inf | 3 ++ .../Include/Library/RedfishVersionLib.h | 5 +--

[edk2-devel] [edk2-redfish-client][PATCH v2 08/10] RedfishClientPkg/EdkIIRedfishResourceConfigLib: use HTTP cache lib

Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../EdkIIRedfishResourceConfigLib.inf | 2 ++ .../EdkIIRedfishResourceConfigLib.c | 6 -- 2 files

[edk2-devel] [edk2-redfish-client][PATCH v2 07/10] RedfishClientPkg/Bios: use HTTP cache lib

Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../Features/Bios/v1_0_9/Dxe/BiosDxe.inf | 3 +- .../Features/Bios/v1_0_9/Dxe/BiosDxe.c| 82 --- 2 files changed, 38

[edk2-devel] [edk2-redfish-client][PATCH v2 06/10] RedfishClientPkg/Memory: use HTTP cache lib

Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../Features/Memory/V1_7_1/Dxe/MemoryDxe.inf | 3 +- .../Features/Memory/V1_7_1/Dxe/MemoryDxe.c| 70 +++ 2 files changed, 57

[edk2-devel] [edk2-redfish-client][PATCH v2 05/10] RedfishClientPkg/MemoryCollectionDxe: use HTTP cache lib

Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../MemoryCollectionDxe.inf | 2 ++ .../MemoryCollectionDxe/MemoryCollectionDxe.c | 26 +-- 2 files changed, 15

[edk2-devel] [edk2-redfish-client][PATCH v2 04/10] RedfishClientPkg/ComputerSystem: use HTTP cache lib

Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../v1_5_0/Dxe/ComputerSystemDxe.inf | 3 +- .../v1_5_0/Dxe/ComputerSystemDxe.c| 70 +++ 2 files changed, 57

[edk2-devel] [edk2-redfish-client][PATCH v2 03/10] RedfishClientPkg/ComputerSystemCollectionDxe: use HTTP cache lib

Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../ComputerSystemCollectionDxe.inf | 2 ++ .../ComputerSystemCollectionDxe.c | 26 +-- 2 files changed, 15

[edk2-devel] [edk2-redfish-client][PATCH v2 02/10] RedfishClientPkg: use HTTP cache lib

Add RedfishHttpCacheLib header file for feature driver to use RedfishHttpCacheLib. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- RedfishClientPkg/Include/RedfishCollectionCommon.h | 4 +++- RedfishClientPkg/Include/RedfishResourceCommon.h | 3 ++- 2

[edk2-devel] [edk2-redfish-client][PATCH v2 00/10] RedfishClientPkg: introduce Redfish HTTP cache library

v2: Replace "BMC" with "Redfish service" in this patch series. v1: Introduce RedfishHttpCacheLib to improve HTTP GET performance in Redfish feature drivers. Feature drivers often query same Redfish resource multiple times for different purpose. Add HTTP cache mechanism to improve the

[edk2-devel] [edk2-redfish-client][PATCH v2 01/10] RedfishClientPkg: introduce Redfish HTTP cache library

Introduce RedfishHttpCacheLib to improve HTTP GET performance in Redfish feature drivers. Feature drivers often query same Redfish resource multiple times for different purpose. Add HTTP cache mechanism to improve the performance. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy

Re: [edk2-devel] [edk2-platforms: PATCH v4] Marvell/Armada80x0Db: Fix build

On Sun, 31 Dec 2023 at 12:07, Marcin Wojtas wrote: > > Commit ec5de71d83 ("Silicon/Marvell: Restructure package") > broke Armada80x0Db build by unintentional removal of > device tree component. Restore it. > > Signed-off-by: Marcin Wojtas Applied, thanks. > --- >

Re: [edk2-devel] [edk2-redfish-client][PATCH 00/10] RedfishClientPkg: introduce Redfish HTTP cache library

[AMD Official Use Only - General] Besides the comment given to patch 1/10, for all others Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Wednesday, January 3, 2024 8:02 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez >

Re: [edk2-devel] [edk2-redfish-client][PATCH 01/10] RedfishClientPkg: introduce Redfish HTTP cache library

[AMD Official Use Only - General] Hi Nickle, I have no problem with this feature as we have been using this for a while. Per discussion off line, HttpCacheLibrary would be replaced with protocol version later. I would just give my RB to this patch as this patch is sent for cleaning up the

[edk2-devel] [edk2-redfish-client][PATCH 00/10] RedfishClientPkg: introduce Redfish HTTP cache library

Introduce RedfishHttpCacheLib to improve HTTP GET performance in Redfish feature drivers. Feature drivers often query same Redfish resource multiple times for different purpose. Add HTTP cache mechanism to improve the performance. An enhanced Redfish HTTP driver is under development and it will

[edk2-devel] [edk2-redfish-client][PATCH 10/10] RedfishClientPkg/RedfishFeatureUtilityLib: use HTTP cache lib

Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishFeatureUtilityLib.inf | 3 +- .../Library/RedfishFeatureUtilityLib.h| 21 +- .../RedfishFeatureUtilityInternal.h

[edk2-devel] [edk2-redfish-client][PATCH 09/10] RedfishClientPkg/RedfishVersionLib: use HTTP cache lib

Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishVersionLib/RedfishVersionLib.inf | 3 ++ .../RedfishVersionLib/RedfishVersionLib.c | 30 ++- 2 files changed, 25

[edk2-devel] [edk2-redfish-client][PATCH 08/10] RedfishClientPkg/EdkIIRedfishResourceConfigLib: use HTTP cache lib

Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../EdkIIRedfishResourceConfigLib.inf | 2 ++ .../EdkIIRedfishResourceConfigLib.c | 6 -- 2 files

[edk2-devel] [edk2-redfish-client][PATCH 07/10] RedfishClientPkg/Bios: use HTTP cache lib

Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../Features/Bios/v1_0_9/Dxe/BiosDxe.inf | 3 +- .../Features/Bios/v1_0_9/Dxe/BiosDxe.c| 80 --- 2 files changed, 37

[edk2-devel] [edk2-redfish-client][PATCH 06/10] RedfishClientPkg/Memory: use HTTP cache lib

Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../Features/Memory/V1_7_1/Dxe/MemoryDxe.inf | 3 +- .../Features/Memory/V1_7_1/Dxe/MemoryDxe.c| 70 +++ 2 files changed, 57

[edk2-devel] [edk2-redfish-client][PATCH 05/10] RedfishClientPkg/MemoryCollectionDxe: use HTTP cache lib

Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../MemoryCollectionDxe.inf | 2 ++ .../MemoryCollectionDxe/MemoryCollectionDxe.c | 24 +-- 2 files changed, 14

[edk2-devel] [edk2-redfish-client][PATCH 04/10] RedfishClientPkg/ComputerSystem: use HTTP cache lib

Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../v1_5_0/Dxe/ComputerSystemDxe.inf | 3 +- .../v1_5_0/Dxe/ComputerSystemDxe.c| 70 +++ 2 files changed, 57

[edk2-devel] [edk2-redfish-client][PATCH 03/10] RedfishClientPkg/ComputerSystemCollectionDxe: use HTTP cache lib

Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../ComputerSystemCollectionDxe.inf | 2 ++ .../ComputerSystemCollectionDxe.c | 24 +-- 2 files changed, 14

[edk2-devel] [edk2-redfish-client][PATCH 02/10] RedfishClientPkg: use HTTP cache lib

Add RedfishHttpCacheLib header file for feature driver to use RedfishHttpCacheLib. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- RedfishClientPkg/Include/RedfishCollectionCommon.h | 4 +++- RedfishClientPkg/Include/RedfishResourceCommon.h | 3 ++- 2

[edk2-devel] [edk2-redfish-client][PATCH 01/10] RedfishClientPkg: introduce Redfish HTTP cache library

Introduce RedfishHttpCacheLib to improve HTTP GET performance in Redfish feature drivers. Feature drivers often query same Redfish resource multiple times for different purpose. Add HTTP cache mechanism to improve the performance. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy

[edk2-devel] [edk2-redfish-client][PATCH 00/10] RedfishClientPkg: introduce Redfish HTTP cache library

Introduce RedfishHttpCacheLib to improve HTTP GET performance in Redfish feature drivers. Feature drivers often query same Redfish resource multiple times for different purpose. Add HTTP cache mechanism to improve the performance. An enhanced Redfish HTTP driver is under development and it will

Re: [edk2-devel] [edk2-redfish-client][PATCH v2 0/3] change method for provisioning + minor fixes

[AMD Official Use Only - General] Hi Mike, is https://bugzilla.tianocore.org/show_bug.cgi?id=4625 BZ ticket for this patch set? Abner > -Original Message- > From: Mike Maslenkin > Sent: Tuesday, December 19, 2023 9:00 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ;

[edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: Add ETag PCD and revise Redfish ETag functions

From: Abner Chang Add PCD to disable ETag capability for the case Redfish service doesn't support ETag. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Mike Maslenkin --- RedfishClientPkg/RedfishClientPkg.dec | 2 + .../RedfishFeatureUtilityLib.inf

Re: [edk2-devel] [edk2-platforms: PATCH v4] Marvell/Armada80x0Db: Fix build

śr., 3 sty 2024 o 00:39 Marcin Wojtas napisał(a): > > Hi Narinder, > > wt., 2 sty 2024 o 21:57 Narinder Dhillon napisał(a): > > > > Marcin, > > I don't see this folder in code, how is it generated ? > > It's simply exisitng there: > Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc in

Re: [edk2-devel] [edk2-platforms: PATCH v4] Marvell/Armada80x0Db: Fix build

Hi Narinder, wt., 2 sty 2024 o 21:57 Narinder Dhillon napisał(a): > > Marcin, > I don't see this folder in code, how is it generated ? It's simply exisitng there: Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc in edk2-platforms, nothing is generated. Here's part of the patch, that introduced

[edk2-devel] [edk2-platforms: PATCH v4] Marvell/Armada80x0Db: Fix build

Commit ec5de71d83 ("Silicon/Marvell: Restructure package") broke Armada80x0Db build by unintentional removal of device tree component. Restore it. Signed-off-by: Marcin Wojtas --- Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [edk2-devel] [edk2-platforms: PATCH v4] Marvell/Armada80x0Db: Fix build

Sorry, that was my mistake. > -Original Message- > From: Marcin Wojtas > Sent: Tuesday, January 2, 2024 3:46 PM > To: Narinder Dhillon > Cc: devel@edk2.groups.io; quic_llind...@quicinc.com; > ardb+tianoc...@kernel.org; m...@semihalf.com > Subject: Re: [EXT] [edk2-platforms: PATCH v4]

Re: [edk2-devel] [edk2-platforms: PATCH v4] Marvell/Armada80x0Db: Fix build

Marcin, I don't see this folder in code, how is it generated ? Thanks Narinder > -Original Message- > From: Marcin Wojtas > Sent: Sunday, December 31, 2023 3:07 AM > To: devel@edk2.groups.io > Cc: quic_llind...@quicinc.com; ardb+tianoc...@kernel.org; > m...@semihalf.com; Narinder Dhillon

[edk2-devel][edk2-platforms][PATCH v4] MinPlatformPkg: Support SecFspWrapperPlatformSecLib in X64

https://bugzilla.tianocore.org/show_bug.cgi?id=4623 1.Added PeiCoreEntry.nasm, SecEntry.nasm and Stack.nasm for X64. 2.Made changes in common files to support both IA32 and X64. 3.Added the PCDs below for FSP-T UPD revisions and reset vector in FSP. - PcdFspWrapperBfvforResetVectorInFsp -

Re: [edk2-devel][edk2-platforms][PATCH v3] MinPlatformPkg: Support SecFspWrapperPlatformSecLib in X64

, Liming Subject: RE: [edk2-devel][edk2-platforms][PATCH v3] MinPlatformPkg: Support SecFspWrapperPlatformSecLib in X64 Hi Ted, I see good improvements on V3. Thanks! Few comments/feedback: 1. Minor feedback - The module name choice SecFspWrapperPlatformSecLibFspO.inf is assuming FSP owning

Re: [edk2-devel][edk2-platforms][PATCH v3] MinPlatformPkg: Support SecFspWrapperPlatformSecLib in X64

-Original Message- From: Kuo, Ted Sent: Friday, December 22, 2023 2:14 AM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Desimone, Nathaniel L ; Dong, Eric ; S, Ashraf Ali ; Duggapu, Chinni B ; Gao, Liming Subject: [edk2-devel][edk2-platforms][PATCH v3] MinPlatformPkg

Re: [edk2-devel] [edk2-redfish-client][PATCH v3 0/3] change method for provisioning + minor fixes

I merged this patch series. Thanks, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Saturday, December 23, 2023 6:41 AM > To: devel@edk2.groups.io > Cc: abner.ch...@amd.com; Nickle Wang ; > ig...@ami.com; Mike Maslenkin > Subject: [edk2-redfish-client][PATCH v3 0/3] change

[edk2-devel] [edk2-redfish-client][PATCH v3 3/3] RedfishClientPkg: fix access to unitialized variable.

It is possible that at the time of accessing to AsciiLocation pointer the memory is not allocated. Also gcc version 4.8.5 20150623 (Red Hat 4.8.5-44) emits a warning for this case: RedfishFeatureUtilityLib.c:1889:37: error: 'AsciiLocation' may be used uninitialized in this function

[edk2-devel] [edk2-redfish-client][PATCH v3 2/3] RedfishClientPkg: fix typo in EfiRestJsonStructureProtocolIsReady

Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin Reviewed-by: Nickle Wang Reviewed-by: Abner Chang --- RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c

[edk2-devel] [edk2-redfish-client][PATCH v3 0/3] change method for provisioning + minor fixes

This patch set contains minor fixes. I have not added any copyrights as I have nothing to claim in this set. diff from v2: added Abner's RB tag diff from v1: original patch 4/4 with change related to BIOS resources provisioning removed. PR:

[edk2-devel] [edk2-redfish-client][PATCH v3 1/3] RedfishClientPkg: add check for NULL pointer to avoid ASSERT

Initially RedfishPlatformConfigGetConfigureLang could return success even if ConfigureLangList is empty. After fixing this condition, RedfishPlatformConfigGetConfigureLang returns an error, but this doesn't help to avoid ASSERT because the error path is the same as for non-empty list. Cc: Igor

[edk2-devel][edk2-platforms][PATCH v3] MinPlatformPkg: Support SecFspWrapperPlatformSecLib in X64

https://bugzilla.tianocore.org/show_bug.cgi?id=4623 1.Added PeiCoreEntry.nasm, SecEntry.nasm and Stack.nasm for X64. 2.Made changes in common file to support both IA32 and X64. 3.Added the PCDs below for FSP-T UPD revisions and reset vector in FSP. - PcdFspWrapperBfvforResetVectorInFsp -

Re: [edk2-devel][edk2-platforms][PATCH v2] MinPlatformPkg: Support SecFspWrapperPlatformSecLib in X64

, Ashraf Ali ; Duggapu, Chinni B ; Gao, Liming Subject: [edk2-devel][edk2-platforms][PATCH v2] MinPlatformPkg: Support SecFspWrapperPlatformSecLib in X64 https://bugzilla.tianocore.org/show_bug.cgi?id=4623 1.Added PeiCoreEntry.nasm, SecEntry.nasm and Stack.nasm for X64. 2.Made changes in common file

Re: [edk2-devel][edk2-platforms][PATCH v1] MinPlatformPkg: Support SecFspWrapperPlatformSecLib in X64

, Chasel ; Dong, Eric ; S, Ashraf Ali ; Duggapu, Chinni B ; Gao, Liming Subject: RE: [edk2-devel][edk2-platforms][PATCH v1] MinPlatformPkg: Support SecFspWrapperPlatformSecLib in X64 Hi Ted, Looking at this code, the X64 version will only work if PcdFspWrapperResetVectorInFsp == TRUE. Moreover

[edk2-devel][edk2-platforms][PATCH v2] MinPlatformPkg: Support SecFspWrapperPlatformSecLib in X64

https://bugzilla.tianocore.org/show_bug.cgi?id=4623 1.Added PeiCoreEntry.nasm, SecEntry.nasm and Stack.nasm for X64. 2.Made changes in common file to support both IA32 and X64. 3.Added the PCDs below for FSP-T UPD revisions and reset vector in FSP. - PcdFspWrapperBfvforResetVectorInFsp -

[edk2-devel] [edk2-platforms PATCH v2 7/8] Silicon/Marvell: Driver to dump board configuration

From: Narinder Dhillon This patch adds an EDK2 shell command to dump board configuration device tree. Signed-off-by: Narinder Dhillon --- .../Drivers/Fdt/FdtPlatformDxe/FdtPlatform.c | 361 ++ .../Drivers/Fdt/FdtPlatformDxe/FdtPlatform.h | 102 +

[edk2-devel] [edk2-platforms PATCH v2 8/8] Silicon/Marvell: Odyssey project description files

From: Narinder Dhillon This patch adds Odyssey SoC project description file, flash description file, and PCD's. Signed-off-by: Narinder Dhillon --- Platform/Marvell/OdysseyPkg/OdysseyPkg.dsc| 216 ++ Platform/Marvell/OdysseyPkg/OdysseyPkg.fdf| 304 ++

[edk2-devel] [edk2-platforms PATCH v2 6/8] Silicon/Marvell: Device tree driver

From: Narinder Dhillon This patch adds a device tree driver that is used to read board configuration information from a device tree. Signed-off-by: Narinder Dhillon --- .../Drivers/Fdt/FdtClientDxe/FdtClientDxe.c | 382 ++ .../Drivers/Fdt/FdtClientDxe/FdtClientDxe.inf | 43

[edk2-devel] [edk2-platforms PATCH v2 4/8] Silicon/Marvell: Odyssey watchdog driver

From: Narinder Dhillon This patch adds watchdog driver for Odyssey SoC. Signed-off-by: Narinder Dhillon --- .../Drivers/Wdt/GtiWatchdogDxe/GtiWatchdog.c | 408 ++ .../Wdt/GtiWatchdogDxe/GtiWatchdogDxe.inf | 45 ++ 2 files changed, 453 insertions(+) create mode 100644

[edk2-devel] [edk2-platforms PATCH v2 5/8] Silicon/Marvell: RTC driver

From: Narinder Dhillon Marvell Odyssey SoC does not have RTC on chip. This patch provides a dummy RTC driver to generate architectural protocol and help boot Odyssey SoC. Signed-off-by: Narinder Dhillon --- .../Marvell/Drivers/Null/RtcNull/RtcNullDxe.c | 280 ++

[edk2-devel] [edk2-platforms PATCH v2 1/8] Silicon/Marvell: New Marvell Odyssey processor

From: Narinder Dhillon This patch creates ArmPlatformPkg for Odyssey SoC by overriding some of the files in original ArmPlatformPkg. Differences from standard ArmPlatformPkg are marked with "--- MRVL Override" comment. Signed-off-by: Narinder Dhillon --- .../PrePi/AArch64/ModuleEntryPoint.S

[edk2-devel] [edk2-platforms PATCH v2 2/8] Silicon/Marvell: Odyssey ArmPlatformLib

From: Narinder Dhillon This patch adds ArmPlatformLib for Marvell Odyssey SoC. Signed-off-by: Narinder Dhillon --- .../AArch64/ArmPlatformHelper.S | 86 .../Library/ArmPlatformLib/ArmPlatformLib.c | 79 +++ .../Library/ArmPlatformLib/ArmPlatformLib.inf |

[edk2-devel] [edk2-platforms PATCH v2 3/8] Silicon/Marvell: Odyssey SmcLib

From: Narinder Dhillon This patch provides SMC call needed by Odyssey to determine available memory size. Signed-off-by: Narinder Dhillon --- Silicon/Marvell/Library/SmcLib/SmcLib.c | 24 +++ Silicon/Marvell/Library/SmcLib/SmcLib.inf | 29 +++

[edk2-devel] [edk2-platforms PATCH v2 0/8] Silicon/Marvell/OdysseyPkg:

From: Narinder Dhillon New Marvell Odyssey SoC This patchset contains only the very basic elements needed to boot to EDK2 UiApp on Marvell Odyssey SoC - ARM BL31 firmware component copies EDK2 image into memory, so it is always executing from memory - There is a SMC library to get system

Re: [edk2-devel][edk2-platforms][PATCH v1] MinPlatformPkg: Support SecFspWrapperPlatformSecLib in X64

Ali ; Duggapu, Chinni B > ; Gao, Liming > Subject: [edk2-devel][edk2-platforms][PATCH v1] MinPlatformPkg: Support > SecFspWrapperPlatformSecLib in X64 > > https://bugzilla.tianocore.org/show_bug.cgi?id=4623 > 1.Added PeiCoreEntry.nasm, SecEntry.nasm and Stack.nasm for X64. >

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: Add debug messages

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Tuesday, December 19, 2023 12:33 PM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy ; > Mike Maslenkin > Subject: [edk2-redfish-client][PATCH] RedfishClientPkg: Add

[edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: Add debug messages

From: Abner Chang Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Mike Maslenkin --- .../ComputerSystemCollectionDxe.c | 3 ++- .../EdkIIRedfishResourceConfigLib.c| 7 ++- .../Library/RedfishVersionLib/RedfishVersionLib.c

Re: [edk2-devel] [edk2-redfish-client][PATCH v2 3/3] RedfishClientPkg: fix access to unitialized variable.

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Mike Maslenkin > Sent: Tuesday, December 19, 2023 9:00 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nick...@nvidia.com; > ig...@ami.com; Mike Maslenkin > Subject: [edk2-redfish-client][PATCH

Re: [edk2-devel] [edk2-redfish-client][PATCH v2 1/3] RedfishClientPkg: add check for NULL pointer to avoid ASSERT

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Mike Maslenkin > Sent: Tuesday, December 19, 2023 9:00 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nick...@nvidia.com; > ig...@ami.com; Mike Maslenkin > Subject: [edk2-redfish-client][PATCH

Re: [edk2-devel] [edk2-redfish-client][PATCH v2 2/3] RedfishClientPkg: fix typo in EfiRestJsonStructureProtocolIsReady

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Mike Maslenkin > Sent: Tuesday, December 19, 2023 9:00 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nick...@nvidia.com; > ig...@ami.com; Mike Maslenkin > Subject: [edk2-redfish-client][PATCH

Re: [edk2-devel] [edk2-redfish-client][PATCH v2 0/3] change method for provisioning + minor fixes

[AMD Official Use Only - General] Yes, Copyright (c) 2023, Contributor is good for you now. Abner > -Original Message- > From: Mike Maslenkin > Sent: Tuesday, December 19, 2023 10:40 AM > To: Chang, Abner > Cc: devel@edk2.groups.io; nick...@nvidia.com; ig...@ami.com > Subject:

Re: [edk2-devel] [edk2-redfish-client][PATCH v2 0/3] change method for provisioning + minor fixes

Hi Abner, Ok. I've already done it. But copyright change mentioned is for another patchset to edk2's RedfishPkg. Whereas you mentioned FIRST - LAST, would you like me to add copyrights for these changes? I guess LAST is not required for the new added code. I didn't add any copyrights previously,

Re: [edk2-devel] [edk2-redfish-client][PATCH v2 0/3] change method for provisioning + minor fixes

[AMD Official Use Only - General] Hi Mike, According the conversation I had with Rebecca, please update your copyright that follow below format on the later patches you send; as you use the individual contributor copyright. Copyright (c) FIRST - LAST, Contributor Thanks Abner >

[edk2-devel] [edk2-redfish-client][PATCH v2 3/3] RedfishClientPkg: fix access to unitialized variable.

It is possible that at the time of accessing to AsciiLocation pointer the memory is not allocated. Also gcc version 4.8.5 20150623 (Red Hat 4.8.5-44) emits a warning for this case: RedfishFeatureUtilityLib.c:1889:37: error: 'AsciiLocation' may be used uninitialized in this function

[edk2-devel] [edk2-redfish-client][PATCH v2 2/3] RedfishClientPkg: fix typo in EfiRestJsonStructureProtocolIsReady

Cc: Abner Chang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin Reviewed-by: Nickle Wang --- RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c

[edk2-devel] [edk2-redfish-client][PATCH v2 0/3] change method for provisioning + minor fixes

This patch set contains minor fixes. diff from v1: original patch 4/4 with change related to BIOS resources provisioning removed. PR: https://github.com/tianocore/edk2-redfish-client/pull/64 Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nickle Wang Signed-off-by: Mike Maslenkin

[edk2-devel] [edk2-redfish-client][PATCH v2 1/3] RedfishClientPkg: add check for NULL pointer to avoid ASSERT

Initially RedfishPlatformConfigGetConfigureLang could return success even if ConfigureLangList is empty. After fixing this condition, RedfishPlatformConfigGetConfigureLang returns an error, but this doesn't help to avoid ASSERT because the error path is the same as for non-empty list. Cc: Abner

Re: [edk2-devel] [edk2-platforms][PATCH V1 5/5] Platform/ARM/N1Sdp: Enable FaultTolerantWrite Dxe driver for N1Sdp

Hi Sahil, As such these changes look good to me. But, we would need to revisit this based on my response for Patch 3/5. Regards, Sami Mujawar On 16/11/2023 11:45 am, sahil wrote: Signed-off-by: sahil --- Platform/ARM/N1Sdp/N1SdpPlatform.dsc | 5 +

Re: [edk2-devel] [edk2-platforms][PATCH V1 4/5] Platform/ARM/N1Sdp: Persistent storage for N1Sdp

Hi Sahil, Please see my response for Patch 3/5. Regards, Sami Mujawar On 16/11/2023 11:45 am, sahil wrote: Enable persistent storage on QSPI flash device. Signed-off-by: sahil --- Platform/ARM/N1Sdp/N1SdpPlatform.dsc | 20 ++-- Platform/ARM/N1Sdp/N1SdpPlatform.fdf | 4

Re: [edk2-devel] [edk2-platforms][PATCH V1 3/5] Platform/ARM/N1Sdp: NOR flash Dxe Driver for N1Sdp

Hi Sahil, Where can I find the documentation for Cadence QSPI? Can you add a link to the relevant file headers, please? Also, this patch is duplicating a lot of the code in edk2-platforms\Platform\ARM\Drivers\NorFlashDxe and I have already spotted some new bugs in this patch. Have you

Re: [edk2-devel] [edk2-platforms][PATCH V1 2/5] Silicon/ARM/NeoverseN1Soc: NOR flash library for N1Sdp

Hi Sahil, Please find my feedback marked inline as [SAMI]. With those fixed, Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 16/11/2023 11:45 am, sahil wrote: Add NOR flash library, this library provides APIs for getting the list of NOR flash devices on the platform. Signed-off-by:

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/5] Silicon/ARM/NeoverseN1Soc: Enable SCP QSPI flash region

Hi Sahil, Please see my response inline marked [SAMI]. Regards, Sami Mujawar On 16/11/2023 11:45 am, sahil via groups.io wrote: Enable SCP QSPI flash region access by adding it in the PlatformLibMem Signed-off-by: sahil --- Silicon/ARM/NeoverseN1Soc/Include/NeoverseN1Soc.h |

Re: [edk2-devel][edk2-platforms][PATCH v1] MinPlatformPkg: Support SecFspWrapperPlatformSecLib in X64

Subject: [edk2-devel][edk2-platforms][PATCH v1] MinPlatformPkg: Support SecFspWrapperPlatformSecLib in X64 https://bugzilla.tianocore.org/show_bug.cgi?id=4623 1.Added PeiCoreEntry.nasm, SecEntry.nasm and Stack.nasm for X64. 2.Made changes in common file to support both IA32 and X64. 3.Added the PCDs

Re: [edk2-devel] [edk2-redfish-client][PATCH 4/4] RedfishClientPkg: use POST method while provisioning new property.

.groups.io; mike.maslen...@gmail.com Cc: Nickle Wang ; Chang, Abner ; ig...@ami.com Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH 4/4] RedfishClientPkg: use POST method while provisioning new property. Caution: This message originated from an External Source. Use proper caution when opening

[edk2-devel][edk2-platforms][PATCH v1] MinPlatformPkg: Support SecFspWrapperPlatformSecLib in X64

https://bugzilla.tianocore.org/show_bug.cgi?id=4623 1.Added PeiCoreEntry.nasm, SecEntry.nasm and Stack.nasm for X64. 2.Made changes in common file to support both IA32 and X64. 3.Added the PCDs below for FSP-T UPD revsions and X64 feature. - PcdFspWrapperResetVectorInFsp -

Re: [edk2-devel] [edk2-redfish-client][PATCH 4/4] RedfishClientPkg: use POST method while provisioning new property.

> On 18. 12. 2023., at 03:33, Mike Maslenkin via groups.io > wrote: > > > Hi Nickle, > >> On 15. 12. 2023., at 04:53, Nickle Wang > > wrote: >> >> Hi Mike, >> >> Per Redfish specification 7.9 POST(create) >> >> "The POST request is submitted to the resource

Re: [edk2-devel] [edk2-redfish-client][PATCH 4/4] RedfishClientPkg: use POST method while provisioning new property.

Hi Nickle, > On 15. 12. 2023., at 04:53, Nickle Wang wrote: > > Hi Mike, > > Per Redfish specification 7.9 POST(create) > > "The POST request is submitted to the resource collection to which the new > resource will belong." > > If this is not a collection resource, we cannot use POST

Re: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python VfrCompiler implementation

ups.io; Chen, Christine > Cc: Gao, Liming ; Rebecca Cran > ; Zimmer, Vincent ; Kinney, > Michael D ; Leif Lindholm > ; Andrew Fish ; Feng, Bob C > ; Yang, Yuting2 ; Hartung, > Stephen > Subject: Re: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python > VfrCompiler imp

Re: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python VfrCompiler implementation

On Thu, Dec 7, 2023 at 9:08 AM Yuwei Chen wrote: > > Hi Liming, > > > > Is this feature been tested and reviewed these two weeks?  Two questions: 1) What testing strategy do you have to test for regressions in such a huge rewrite? 2) What's the point in shipping this to upstream if you're not

Re: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python VfrCompiler implementation

groups.io Sent: Monday, December 11, 2023 5:34 PM To: Chen, Christine ; devel@edk2.groups.io; 'Rebecca Cran' ; Zimmer, Vincent ; Kinney, Michael D ; 'Leif Lindholm' ; 'Andrew Fish' Cc: Feng, Bob C ; Yang, Yuting2 ; Hartung, Stephen Subject: 回复: [edk2-devel] [edk2-stable202311][PATCH] BaseTools

Re: [edk2-devel] [edk2-redfish-client][PATCH 4/4] RedfishClientPkg: use POST method while provisioning new property.

Hi Mike, Per Redfish specification 7.9 POST(create) "The POST request is submitted to the resource collection to which the new resource will belong." If this is not a collection resource, we cannot use POST method. And /redfish/v1/Systems/SYS_ID/Bios is not a collection resource. The allowed

Re: [edk2-devel] [edk2-redfish-client][PATCH 3/4] RedfishClientPkg: fix access to unitialized variable.

Thanks for catching this issue. Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Friday, December 15, 2023 8:04 AM > To: devel@edk2.groups.io > Cc: abner.ch...@amd.com; Nickle Wang ; > ig...@ami.com; Mike Maslenkin > Subject:

Re: [edk2-devel] [edk2-redfish-client][PATCH 2/4] RedfishClientPkg: fix typo in EfiRestJsonStructureProtocolIsReady

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Friday, December 15, 2023 8:04 AM > To: devel@edk2.groups.io > Cc: abner.ch...@amd.com; Nickle Wang ; > ig...@ami.com; Mike Maslenkin > Subject: [edk2-redfish-client][PATCH 2/4]

Re: [edk2-devel] [edk2-redfish-client][PATCH 1/4] RedfishClientPkg: add check for NULL pointer to avoid ASSERT

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Friday, December 15, 2023 8:04 AM > To: devel@edk2.groups.io > Cc: abner.ch...@amd.com; Nickle Wang ; > ig...@ami.com; Mike Maslenkin > Subject: [edk2-redfish-client][PATCH 1/4]

[edk2-devel] [edk2-redfish-client][PATCH 2/4] RedfishClientPkg: fix typo in EfiRestJsonStructureProtocolIsReady

Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nickle Wang Signed-off-by: Mike Maslenkin --- RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c

<    2   3   4   5   6   7   8   9   10   11   >