It is possible that at the time of accessing to AsciiLocation pointer
the memory is not allocated.
Also gcc version 4.8.5 20150623 (Red Hat 4.8.5-44) emits a warning for
this case:
RedfishFeatureUtilityLib.c:1889:37: error: 'AsciiLocation' may be used
uninitialized in this function
If EdkIIRedfishResourceConfigCheck fails according to the logic and
comment: new resources should be provisioned, so the POST method must be
used. Fourth parameter of EdkIIRedfishResourceConfigProvisioning is
BOOLEAN HttpPostMode, so we pass TRUE here.
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc:
Initially RedfishPlatformConfigGetConfigureLang could return success
even if ConfigureLangList is empty. After fixing this condition,
RedfishPlatformConfigGetConfigureLang returns an error, but this doesn't
help to avoid ASSERT because the error path is the same as for non-empty
list.
Cc: Abner
This patch set contains minor fixes and the one major change related
to BIOS resources provisioning.
PR: https://github.com/tianocore/edk2-redfish-client/pull/64
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nickle Wang
Signed-off-by: Mike Maslenkin
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links:
On Thu, Dec 14, 2023 at 11:41 AM Pranav Madhu wrote:
>
> The Neoverse RD-V2 FVP platform includes 16 CPUs and each CPU has 64KB
> of L1 instruction/data cache, 2MB of L2 cache and 32MB of system level
> cache. Extend the SMBIOS support for RD-V2 platform with this
> configuration.
>
>
On Thu, Dec 14, 2023 at 11:41 AM Pranav Madhu wrote:
>
> Add the RD-V2 platform identification values including the part
> number and configuration number. This information will be used in
> populating the SMBIOS tables.
>
> Signed-off-by: Pranav Madhu
> ---
>
The Neoverse RD-V2 FVP platform includes 16 CPUs and each CPU has 64KB
of L1 instruction/data cache, 2MB of L2 cache and 32MB of system level
cache. Extend the SMBIOS support for RD-V2 platform with this
configuration.
Signed-off-by: Pranav Madhu
---
Add the RD-V2 platform identification values including the part
number and configuration number. This information will be used in
populating the SMBIOS tables.
Signed-off-by: Pranav Madhu
---
Platform/ARM/SgiPkg/Include/SgiPlatform.h | 5 +
Changes since V1:
- Rebase the patches on top of latest master branch
SMBIOS provides basic hardware and firmware configuration information
through table-driven data structure. This patch series adds SMBIOS
support for Arm's RD-V2 platforms.
The first patch in this series defines platform-id
Hi Himanshu,
Thank you for this patch.
I have a minor suggestion marked inline as [SAMI].
Otherwise this patch looks good to me.
With that fixed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 06/12/2023 10:11 am, Himanshu Sharma wrote:
Taking reference from Table 2-1 of the Arm
Hi Himanshu,
Thank you for this patch.
Please see my feedback marked inline as [SAMI].
Regards,
Sami Mujawar
On 06/12/2023 10:11 am, Himanshu Sharma wrote:
Add interrupt node to the AML description of the serial-port only if the
IRQ ID from the Configuration Manager is a valid SPI (shared
Hi Sahil,
Thank you for this patch.
I think this patch can be split into 3 or 4 patches. Can you look into
that, please?
I also have other feedback marked inline as [SAMI].
Regards,
Sami Mujawar
On 23/08/2023 12:03 pm, sahil wrote:
NT_FW_CONFIG DTB contains platform information passed by
Hi Sahil!
On 16/11/2023 11:45, sahil via groups.io wrote:
Add NOR flash DXE driver, this brings up NV storage on
QSPI's flash device using FVB protocol.
Signed-off-by: sahil
---
Platform/ARM/N1Sdp/N1SdpPlatform.dec |5 +-
, Christine ; Gao, Liming
; 'Rebecca Cran' ; Zimmer, Vincent
; Kinney, Michael D ;
'Leif Lindholm' ; 'Andrew Fish'
抄送: Feng, Bob C ; Yang, Yuting2 ;
Hartung, Stephen
主题: RE: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python VfrCompiler
implementation
Hi Liming,
Is this feature been
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Jayaprakash, N
> Sent: Saturday, December 9, 2023 9:43 AM
> To: devel@edk2.groups.io
> Cc: Jayaprakash, N ; Rebecca Cran
> ; Kinney, Michael D
> Subject: [edk2-libc Patch 1/1] ek2-libc: writeio function in
> edk2module.c not
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4619
This commit fixes the issue reported in the BZ4619.
The order of passing the parameters to IoWrite* functions
called within writeio function in edk2module.c has been corrected
Also verified the changes by writing reset command to 0xCF9 port
This commit fixes the issue reported in BZ4619.
The writeio() function in edk2module.c in
edk2-libc/AppPkg/Applications/Python/Python-3.6.8/PyMod-3.6.8/Modules
which uses IoWrite* functions was passing the parameters in incorrect
order. This has been fixed.
Jayaprakash N (1):
ek2-libc: writeio
Hi Narinder,
czw., 30 lis 2023 o 16:14 Narinder Dhillon napisał(a):
>
> From: Narinder Dhillon
>
> This patch adds support for Marvell Odyssey processor.
>
> It contains only the very basic elements needed to boot to EDK2 UiApp.
> - ARM BL31 firmware component copies EDK2 image into memory, so
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of sahil via
> groups.io
> Sent: Thursday, November 16, 2023 11:46 AM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Leif Lindholm
> ; Sami Mujawar ;
> Sahil Kaushal
> Subject: [edk2-devel] [e
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of sahil via
> groups.io
> Sent: Thursday, November 16, 2023 11:46 AM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Leif Lindholm
> ; Sami Mujawar ;
> Sahil Kaushal
> Subject: [edk2-devel] [e
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of sahil via
> groups.io
> Sent: Thursday, November 16, 2023 11:46 AM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Leif Lindholm
> ; Sami Mujawar ;
> Sahil Kaushal
> Subject: [edk2-devel] [e
Hi Sahil,
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of sahil via
> groups.io
> Sent: Thursday, November 16, 2023 11:46 AM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Leif Lindholm
> ; Sami Mujawar ;
> Sahil Kaushal
> Subject: [edk2-de
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of sahil via
> groups.io
> Sent: Thursday, November 16, 2023 11:46 AM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Leif Lindholm
> ; Sami Mujawar ;
> Sahil Kaushal
> Subject: [edk2-devel] [e
Hi Sahil,
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of sahil via
> groups.io
> Sent: Wednesday, August 23, 2023 12:03 PM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Leif Lindholm
> ; Sami Mujawar ; Sahil
>
> Subject: [edk2-devel] [e
Fish'
Cc: Feng, Bob C ; Yang, Yuting2 ;
devel@edk2.groups.io; Hartung, Stephen
Subject: Re: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python
VfrCompiler implementation
Hi Liming,
I know your point. Would you like to start reviewing it and give us more
feedbacks? We really hope
[AMD Official Use Only - General]
Ah sorry, I missed that one.
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Thursday, December 7, 2023 7:46 AM
> To: Chang, Abner ; devel@edk2.groups.io
> Cc: Igor Kulchytskyy ; Nick Ramirez
> Subject: RE:
Hi Abner,
> If we use PCD here, then we have to also update CreateEventEx in the
> RedfishFeatureCoreEntryPoint. Create the event using
> REDFISH_FEATURE_CORE_TPL.
Yes, I also modify RedfishFeatureCoreEntryPoint in below together.
> }
>
> /**
> @@ -670,7 +682,7 @@
[AMD Official Use Only - General]
Hi Nickle, one comment below.
> -Original Message-
> From: Nickle Wang
> Sent: Wednesday, December 6, 2023 4:57 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
> ; Nick Ramirez
> Subject: [edk2-redfish-client][PATCH]
>
Tested on N1SDP and Morello.
Tested-by: Himanshu Sharma
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112120): https://edk2.groups.io/g/devel/message/112120
Mute This Topic: https://groups.io/mt/103010241/21656
Group Owner:
Add interrupt node to the AML description of the serial-port only if the
IRQ ID from the Configuration Manager is a valid SPI (shared processor
interrupt) or an extended SPI. So, for DBG2 UART ports where interrupt
is not mandatory, adding of an interrupt node in the AML description
using Serial
Taking reference from Table 2-1 of the Arm Generic Interrupt Controller
Architecture Specification, Issue H, January 2022, add macros for the
SPI and extended SPI ranges with the purpose of reusability on including
the ArmPkg.
Signed-off-by: Himanshu Sharma
---
Currently in the Dynamic Tables Framework, the interrupt node for the
AML description of the serial-ports is populated using the template
and so is mandatorily added even if the serial-port is enumerated as
a DBG2 port in the platform's configuration manager where the
interrupt is not mandatory.
RedfishFeatureDriverStartup is callback function at TPL_CALLBACK
level. In this function, Redfish events are signaled. However,
Redfish events are created in TPL_CALLBACK level too. As the result,
Redfish events cannot be invoked in desired sequence. Decrease the
TPL to TPL_APPLICATION level
Reviewed-by: Igor Kulchytskyy
Regards,
Igor
-Original Message-
From: Nickle Wang
Sent: Monday, December 4, 2023 4:41 AM
To: devel@edk2.groups.io
Cc: Abner Chang ; Igor Kulchytskyy ; Nick
Ramirez
Subject: [EXTERNAL] [edk2-redfish-client][PATCH v2]
Hi Igor,
Sorry for my delay response. Having three checks in
ValidateRedfishStringArrayValues is complicate to me so I took some time to
verify it on my system.
> Maybe their functionality can be combined in ValidateRedfishStringArrayValues?
> Some additional an out parameter from that
Add function ValidateRedfishStringArrayValues to validate Redfish
request for string array type. There is case that user request
invalid string array and feature driver can not find corresponding
HII option.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
---
; Kubacki, Michael
Subject: [edk2-devel] [edk2-platforms][PATCH v1] Vlv2TbltDevicePkg: Fix DxeCore
Build Failures
Commit 7284c44 in edk2 introduces an incompatibility that causes any project
that uses DxeMain.inf to fail to build. This is due to the addition of
ImagePropertiesRecordLib
, Michael
Subject: [edk2-devel] [edk2-platforms][PATCH v1] QuarkPlatformPkg: Fix DxeCore
Build Failures
Commit 7284c44 in edk2 introduces an incompatibility that causes any project
that uses DxeMain.inf to fail to build. This is due to the addition of
ImagePropertiesRecordLib, and a new added
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Thursday, November 30, 2023 4:18 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Ni, Ray ;
> Chaganty, Rangasai V ; Gao, Liming
> ; Kinney, Michael D ;
> Kelly Steele ; Taylor Beebe
> ; Kubacki,
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Thursday, November 30, 2023 4:18 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Ni, Ray ;
> Chaganty, Rangasai V ; Gao, Liming
> ; Kinney, Michael D ;
> Sun, Zailiang ; Qian, Yi ;
> Taylor Beebe
Reviewed-by: Michael Kubacki
On 11/30/2023 7:18 PM, Nate DeSimone wrote:
Commit 7284c44 in edk2 introduces an incompatibility that causes any
project that uses DxeMain.inf to fail to build. This is due to the
addition of ImagePropertiesRecordLib, and a new added dependency on
that library in
Reviewed-by: Michael Kubacki
On 11/30/2023 7:18 PM, Nate DeSimone wrote:
Commit 7284c44 in edk2 introduces an incompatibility that causes any
project that uses DxeMain.inf to fail to build. This is due to the
addition of ImagePropertiesRecordLib, and a new added dependency on
that library in
Hey Taylor,
I think I gotten everything in Platform/Intel, it should also fix
QemuOpenBoardPkg and AmdMinBoardPkg. I saw that Levi also fixed ARM\VExpressPkg
in https://edk2.groups.io/g/devel/message/111905. Everything else I'm not sure.
Thanks for being proactive on fixing it!
Best Regards,
: [edk2-devel] [edk2-platforms][PATCH v1] Intel-MinPlatform: Fix DxeCore
Build Failures
Commit 7284c44 in edk2 introduces an incompatibility that causes any project
that uses DxeMain.inf to fail to build. This is due to the addition of
ImagePropertiesRecordLib, and a new added dependency
Hey Nate,
I'm about to send out a series to add the library across the repo --
just having some smtp authentication issues :D
Are you updating all the packages or just a subset?
-Taylor
On 11/30/2023 4:18 PM, Nate DeSimone wrote:
Commit 7284c44 in edk2 introduces an incompatibility that
Commit 7284c44 in edk2 introduces an incompatibility that causes any
project that uses DxeMain.inf to fail to build. This is due to the
addition of ImagePropertiesRecordLib, and a new added dependency on
that library in DxeMain. Platforms will not have this LibraryClass
defined in their DSC yet
Commit 7284c44 in edk2 introduces an incompatibility that causes any
project that uses DxeMain.inf to fail to build. This is due to the
addition of ImagePropertiesRecordLib, and a new added dependency on
that library in DxeMain. Platforms will not have this LibraryClass
defined in their DSC yet
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Thursday, November 30, 2023 4:06 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Ni, Ray ;
> Chaganty,
> Rangasai V ; Gao, Liming
> ; Kinney, Michael D ;
> Taylor Beebe ; Kubacki,
Commit 7284c44 in edk2 introduces an incompatibility that causes any
project that uses DxeMain.inf to fail to build. This is due to the
addition of ImagePropertiesRecordLib, and a new added dependency on
that library in DxeMain. Platforms will not have this LibraryClass
defined in their DSC yet
This set contains a fix of misleading texts, format specifier
and refines interaction with user about system reset.
Here is link to PR:
https://github.com/tianocore/edk2-redfish-client/pull/62
Signed-off-by: Mike Maslenkin
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Forwarding this discussion as it unfortunately missed the mailing list.
Regards,
Sami Mujawar
On 29/11/2023 12:33 pm, Yeo Reum Yun wrote:
Thanks Pierre :)
+add Taylor Beebe
@Taylor Beebe
Hi Taylor! Thanks for your recent patch related to ImagePropertiesRecordLib!
But, after applying your
Hi Levi,
Apparently, you have not posted the patch to the edk2 mailing list.
Can you post a v2 series with the line ending issue fixed to the mailing list,
please?
Regards,
Sami Mujawar
On 30/11/2023, 10:30, "Sami Mujawar" mailto:sami.muja...@arm.com>> wrote:
Hi Thomas,
Before I go ahead
Reviewed-by: Abdul Lateef Attar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111888): https://edk2.groups.io/g/devel/message/111888
Mute This Topic: https://groups.io/mt/102868346/21656
Group Owner: devel+ow...@edk2.groups.io
Reviewed-by: Abner Chang
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111878): https://edk2.groups.io/g/devel/message/111878
Mute This Topic: https://groups.io/mt/102868346/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
Pushed as 4e34823
-Original Message-
From: Li, Yi1
Sent: Monday, November 27, 2023 9:09 PM
To: devel@edk2.groups.io
Cc: Li, Yi1 ; Chiu, Chasel ; Desimone,
Nathaniel L ; Gao, Liming
; Dong, Eric
Subject: [edk2-platforms][PATCH] MinPlatformPkg: should build Performance
driver only
Reviewed-by: Nate DeSimone
-Original Message-
From: Li, Yi1
Sent: Monday, November 27, 2023 9:09 PM
To: devel@edk2.groups.io
Cc: Li, Yi1 ; Chiu, Chasel ; Desimone,
Nathaniel L ; Gao, Liming
; Dong, Eric
Subject: [edk2-platforms][PATCH] MinPlatformPkg: should build Performance
Pushed as 967557e
-Original Message-
From: devel@edk2.groups.io On Behalf Of Nate DeSimone
Sent: Wednesday, November 29, 2023 4:40 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Gao, Liming
Subject: [edk2-devel] [edk2-platforms][PATCH v1] IpmiFeaturePkg: Fix Build
Add missing
Reviewed-by: Sai Chaganty
-Original Message-
From: Desimone, Nathaniel L
Sent: Wednesday, November 29, 2023 4:40 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Gao, Liming
Subject: [edk2-platforms][PATCH v1] IpmiFeaturePkg: Fix Build
Add missing MemoryAllocationLib
Add missing MemoryAllocationLib dependency
Cc: Sai Chaganty
Cc: Liming Gao
Signed-off-by: Nate DeSimone
---
.../IpmiFeaturePkg/GenericElog/Smm/GenericElog.inf | 1 +
1 file changed, 1 insertion(+)
diff --git
Pushed as be6742a
-Original Message-
From: devel@edk2.groups.io On Behalf Of Nate DeSimone
Sent: Monday, November 27, 2023 5:04 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Gao, Liming
; Dong, Eric
Subject: [edk2-devel] [edk2-platforms][PATCH v1] MinPlatformPkg: Add
edk2-platforms
Pushed as d02c09d
-Original Message-
From: devel@edk2.groups.io On Behalf Of Nate DeSimone
Sent: Monday, November 27, 2023 5:04 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Gao, Liming
; Dong, Eric
Subject: [edk2-devel] [edk2-platforms][PATCH v1] MinPlatformPkg: Update PatchFv
Tools
Pushed as 0114e8b
-Original Message-
From: devel@edk2.groups.io On Behalf Of Nate DeSimone
Sent: Monday, November 27, 2023 5:04 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel
Subject: [edk2-devel] [edk2-platforms][PATCH v1]
PurleyOpenBoardPkg/BoardMtOlympus: Fix Build
Updates Microcode
Pushed as 4009d4c
-Original Message-
From: devel@edk2.groups.io On Behalf Of Nate DeSimone
Sent: Monday, November 27, 2023 5:04 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel
Subject: [edk2-devel] [edk2-platforms][PATCH v1] PurleyOpenBoardPkg: Fix Build
Adds SmmLockBox driver which
Subject: [edk2-devel][edk2-non-osi][Silicon/AMD/VanGogh][PATCH]
Silicon/AMD/VanGogh: Update VanGogh firmware binaries
From: Eric Xing
Update firmware binaries for VanGogh B0 processors to UCC3B16.3824
Cc: Duke Zhai
Cc: Abdul Lateef Attar
Cc: Abner Chang
Signed-off-by: Eric Xing
Pushed as 7528798
-Original Message-
From: devel@edk2.groups.io On Behalf Of Nate DeSimone
Sent: Friday, November 17, 2023 10:36 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel
Subject: [edk2-devel] [edk2-platforms][PATCH v1] WhitleyOpenBoardPkg: Replace
Python Interpreter Name
Removes
Pushed as 073fbeb
-Original Message-
From: devel@edk2.groups.io On Behalf Of Nate DeSimone
Sent: Friday, November 17, 2023 10:36 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Gao, Liming
; Dong, Eric
Subject: [edk2-devel] [edk2-platforms][PATCH v1] MinPlatformPkg: Remove usage
Pushed as 15e9fae
-Original Message-
From: devel@edk2.groups.io On Behalf Of Nate DeSimone
Sent: Friday, November 17, 2023 10:36 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel
Subject: [edk2-devel] [edk2-platforms][PATCH v1] PurleyOpenBoardPkg: Replace
Python Interpreter Name
Removes
: devel@edk2.groups.io
> Cc: Kinney, Michael D
> Subject: [edk2-devel][edk2-staging] DeviceSimPkg branch creation
>
> Hello,
>
> I would like to announce DeviceSimPkg branch creation in edk2-staging
> repository.
> Branch will be used to develop DeviceSimPkg, a package
[AMD Official Use Only - General]
Thanks Nickle, I just created BZ #4608 to track this TODO item.
For this patch,
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Tuesday, November 28, 2023 2:44 PM
> To: Chang, Abner ; devel@edk2.groups.io
> Cc: Igor
Hi Abner,
Thanks for your review. Please find my comment below.
> This may spend some time on network to get the whole resource from URI if the
> resource size is big, but we just need the information of ETAG header. We can
> think of using HEAD HTTP method.
> However, this seems fine for now as
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Thursday, November 23, 2023 10:34 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
> ; Nick Ramirez
> Subject: [edk2-redfish-client][PATCH 6/6]
>
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Thursday, November 23, 2023 10:34 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
> ; Nick Ramirez
> Subject: [edk2-redfish-client][PATCH 5/6]
Should build FirmwarePerformancePei only when perf enabled.
Avoiding unconditional compilation of performance PEI drivers can
save 2KB(LZMA compressed) in PostMem FV, small but important.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Eric Dong
Signed-off-by: Yi Li
---
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Thursday, November 23, 2023 10:34 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
> ; Nick Ramirez
> Subject: [edk2-redfish-client][PATCH 4/6]
[AMD Official Use Only - General]
> -Original Message-
> From: Nickle Wang
> Sent: Thursday, November 23, 2023 10:34 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
> ; Nick Ramirez
> Subject: [edk2-redfish-client][PATCH 3/6] RedfishClientPkg: feature driver
>
> -Original Message-
> From: Pedro Falcato
> Sent: Monday, November 27, 2023 3:14 PM
> To: devel@edk2.groups.io; Chiu, Chasel
> Cc: Laszlo Ersek ; Chaganty, Rangasai V
> ; Desimone, Nathaniel L
>
> Subject: Re: [edk2-devel] [edk2-platforms PATCH 1/2] Whitl
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Monday, November 27, 2023 5:04 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel
> Subject: [edk2-platforms][PATCH v1] PurleyOpenBoardPkg/BoardMtOlympus: Fix
> Build
>
> Updates
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Monday, November 27, 2023 5:04 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel
> Subject: [edk2-platforms][PATCH v1] PurleyOpenBoardPkg: Fix Build
>
> Adds SmmLockBox driver which
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Monday, November 27, 2023 5:04 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Gao, Liming
> ; Dong, Eric
> Subject: [edk2-platforms][PATCH v1] MinPlatformPkg: Update PatchFv Tools
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Monday, November 27, 2023 5:04 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Gao, Liming
> ; Dong, Eric
> Subject: [edk2-platforms][PATCH v1] MinPlatformPkg: Add edk2-
>
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Friday, November 17, 2023 10:36 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel
> Subject: [edk2-platforms][PATCH v1] PurleyOpenBoardPkg: Replace Python
> Interpreter Name
>
>
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Friday, November 17, 2023 10:36 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel
> Subject: [edk2-platforms][PATCH v1] WhitleyOpenBoardPkg: Replace Python
> Interpreter Name
>
>
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Thursday, November 23, 2023 10:34 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
> ; Nick Ramirez
> Subject: [edk2-redfish-client][PATCH 2/6]
>
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Friday, November 17, 2023 10:36 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Gao, Liming
> ; Dong, Eric
> Subject: [edk2-platforms][PATCH v1] MinPlatformPkg: Remove usage of
>
[AMD Official Use Only - General]
Hi Nickle,
The code change generally looks fine. However, we can improve the debug code
enablement in the source file. I had created a BZ ticket (Bug #4606 ) for this
enhancement and assigned it to myself.
For this change,
Reviewed-by: Abner Chang
>
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Thursday, November 23, 2023 10:13 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
> ; Nick Ramirez
> Subject: [edk2-redfish-client][PATCH]
>
[AMD Official Use Only - General]
Looks good. Please go ahead to merge it.
Reviewed-by:
> -Original Message-
> From: Nickle Wang
> Sent: Tuesday, November 28, 2023 9:16 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
> ; Nick Ramirez
> Subject:
-Fix incorrect URI issue. There is missing "/" while
StartUpFeatureDriver() recursively calls itself.
-Fix typo.
-Update function name to follow the naming style.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
---
.../RedfishFeatureCoreDxe.h
Updates Microcode and Silicon FV sizes so
they can accomodate the newest content.
Cc: Chasel Chiu
Signed-off-by: Nate DeSimone
---
.../BoardMtOlympus/OpenBoardPkg.fdf | 25 +++
1 file changed, 14 insertions(+), 11 deletions(-)
diff --git
Cc: Chasel Chiu
Cc: Liming Gao
Cc: Eric Dong
Signed-off-by: Nate DeSimone
---
Platform/Intel/build.cfg | 5 +++--
Platform/Intel/build_bios.py | 11 +++
2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/Platform/Intel/build.cfg b/Platform/Intel/build.cfg
index
PatchFv tools now run on Python 3.x
Cc: Chasel Chiu
Cc: Liming Gao
Cc: Eric Dong
Signed-off-by: Nate DeSimone
---
.../MinPlatformPkg/Tools/PatchFv/PatchBfv.py | 35
.../Tools/PatchFv/PatchBinFv.py | 69
.../Tools/PatchFv/RebaseBinFv.py |
Adds SmmLockBox driver which is needed to
build with the newest version of MinPlatformPkg
Cc: Chasel Chiu
Signed-off-by: Nate DeSimone
---
.../Intel/PurleyOpenBoardPkg/BoardMtOlympus/OpenBoardPkg.dsc | 3 ++-
.../Intel/PurleyOpenBoardPkg/BoardTiogaPass/OpenBoardPkg.dsc | 3 ++-
2 files
On Tue, Nov 21, 2023 at 2:17 AM Chiu, Chasel wrote:
>
>
> Hi Laszlo,
>
> I think you have to clone all the required repos.
> edk2 repository
> git clone https://github.com/tianocore/edk2.git
>
> edk2-platforms repository
> git clone https://github.com/tianocore/edk2-platforms.git
>
> edk2-non-osi
t; To: devel@edk2.groups.io; Chiu, Chasel
> Cc: Chaganty, Rangasai V ; Desimone, Nathaniel
> L
> Subject: Re: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg:
> remove references
>
> Hi Chasel,
>
> On 11/21/23 03:17, Chiu, Chasel wrote:
> >
> >
Reviewed-by : Jayaprakash Nevara
-Original Message-
From: R, Vishal
Sent: Friday, November 24, 2023 4:41 PM
To: devel@edk2.groups.io
Cc: R, Vishal ; Rebecca Cran ; Kinney,
Michael D ; Jayaprakash, N
Subject: [edk2-libc Patch 1/1] edk2-libc/StdLib: Fixed typo issues in multiple
files
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4579
This commit fixes the various typo issues found in documentation strings
in multiple files issue reported via the BZ4579
These changes are documentation updates only and does not affect the
functionality of the code
Cc: Rebecca Cran
Cc:
This commit fixes the various typo issues found in documentation strings
in multiple files issue reported via the BZ4579
These changes are documentation updates only and does not affect the
functionality of the code
Vishal R (1):
edk2-libc/StdLib: Fixed typo issues in multiple files
Add string NULL check in attribute comparison function and prevent
NULL string assertion. This is not supposed to happen in normal
condition so add error output for debugging purpose.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
---
EdkIIRedfishResourceSetConfigureLang() uses cached handler to
locate protocol. However, if EdkIIRedfishResourceSetConfigureLang()
is called at non-collection driver, the cached handler is NULL because
cached handler is initialized by collection driver. Since
EdkIIRedfishResourceSetConfigureLang()
When attribute is empty string, converter library creates NULL
attribute value in C structure instead of empty string.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
---
RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c | 4
1 file changed, 4
701 - 800 of 12072 matches
Mail list logo
