Hi Joe,
Please submit a Bugzilla (https://bugzilla.tianocore.org/) and add the BZ link
to the commit message.
This patch looks good to me.
Thanks,
Bob
-Original Message-
From: Joe Richey [mailto:joeric...@google.com]
Sent: Saturday, May 11, 2019 12:24 PM
To: devel@edk2.groups.io
Cc:
None of the .c/.h in Arm/ are used any more => remove them.
Also merge the CC flags for MSFT ARM and ARM64, since these are the
only archs we support for this package.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Signed-off-by: Pete Batard
---
ArmPkg/Library/CompilerIntrinsicsLib/Arm/Llvm_int_lib.h
The new sources are a copy of the RVCT version.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Signed-off-by: Pete Batard
---
ArmPkg/Library/CompilerIntrinsicsLib/Arm/uread.S | 54
ArmPkg/Library/CompilerIntrinsicsLib/Arm/uwrite.S | 53
On 05/10/19 02:01, Kinney, Michael D wrote:
> Laszlo,
>
> 1) We also use OpenSSL command line tool to locally sign
>capsules and recovery images for local testing. So both
>tool dependency and source dependency apply to the OpenSSL
>content.
I haven't used the tools yet that you
On 05/10/19 21:45, Rodriguez, Christian wrote:
> Hashing is not changing file format requirements as Basetools has no
> requirement on this even though the spec does have file requirements. That's
> why the initial patch was a workaround of sorts because it is allowed by
> Basetools to have
Hi Christian,
ModuleMakefile.GetFileDependency() gets the header file recursively for each
source file under Inf [Sources] section. You can check if this function can
resolve the problem.
Thanks,
Bob
-Original Message-
From: Rodriguez, Christian
Sent: Saturday, May 11, 2019 3:45 AM
From: Xiaoyu Lu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089
Update OpenSSL submodule to OpenSSL_1_1_1b
OpenSSL_1_1_1b(50eaac9f3337667259de725451f201e784599687)
Run process_files.pl script to regenerate OpensslLib[Crypto].inf
and opensslconf.h
Remove -DNO_SYSLOG from
(1) CryptoPkg/OpensslLib: Modify process_files.pl for upgrading OpenSSL
OpenSSL only support seeding NONE for UEFI(rand_unix.c line 93).
So add --with-rand-seed=none to process_files.pl.
(2) CryptoPkg/OpensslLib: Exclude unnecessary files in process_files.pl
When running process_files.py
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089
When running process_files.py to configure OpenSSL, we can exclude
some unnecessary files. This can reduce porting time, compiling
time and library size.
Upstream OpenSSL commit 71a5516dcc8a which was as part of
OpenSSL_1_1_1b, Add the
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089
Disable warning for building OpenSSL_1_1_1b
add /wd4132 /wd4700 /wd4310 for Visual Studio in OpensslLib[Crypto].inf
add -Wno-error=unused-but-set-variable for GCC in OpensslLib[Crypto].inf
Although this option is set in some build
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089
OpenSSL configure mechanism use --with-rand-seed=xxx option to configure
random number generation.
OpenSSL_1_1_0j(74f2d9c1ec5f5510e1d3da5a9f03c28df0977762)
we use default --with-rand-seed=os option to for building it.
But
From: Xiaoyu Lu
Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1089
OpenSSL internally redefines the size of HMAC_CTX at
crypto/hmac/hmac_lcl.h(OpenSSL commit e0810e35).
Ref: https://github.com/openssl/openssl/pull/4338
We should not use it directly and should remove relevant
We could have reused memmove.asm for ARM, but we would still need to add
an implemention for ARM64, so we use the same source for both archs.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Signed-off-by: Pete Batard
---
ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf | 2 ++
The new source is a port of the RVCT version.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Signed-off-by: Pete Batard
---
ArmPkg/Library/CompilerIntrinsicsLib/Arm/lasr.S| 30
ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf | 1 +
2 files changed,
Eric:
Now, edk2-platform devel-MinPlatform branch has merged into edk2-platform
master branch.
For this change, I propose to add new GenericBoardPkg in Platform\Intel
directory for the common board features.
Thanks
Liming
> -Original Message-
> From: devel@edk2.groups.io
https://bugzilla.tianocore.org/show_bug.cgi?id=1801
Add a PCD for skipping password prompt.
Previous change only support if storage device is in locked device.
This change is added to support the case that security status of the
storage device is unlocked.
Signed-off-by: Maggie Chu
Cc: Eric Dong
Yes there could be a performance hit. It might be better to make it a script.
But this is only going to happen when the hash feature is enabled, not ever
build. Also we can minimize the performance hit by saving the data from
ModuleMakefile.GetFileDependency() to memory and reuse it later in
Agree, this is not a feature but code that may be reused to support multiple
features.
We do need a new location to hold such reusable code. Liming, would you like to
send the RFC to request this new package?
Thanks,
Michael
> -Original Message-
> From: Gao, Liming
> Sent: Monday, May
I think a warning would be reasonable.
I only mention the spec because it requires all headers to be in the sources
section of the inf, but it's not enforced strictly by BaseTools. Though the
hashing feature relies on this requirement. It not a big deal, I just wanted to
make sure false
Since the branch is already moved to edk2-platforms/master, I immediately made
the update to redirect patch submissions to the master branch. This change is no
longer needed.
Thanks,
Michael
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>
On 05/13/19 20:53, Christian Rodriguez wrote:
> I think a warning would be reasonable.
>
> I only mention the spec because it requires all headers to be in the sources
> section of the inf,
That could be required by the edk2 INF spec, yes. It's totally
irrelevant for the UEFI spec however.
Oh sorry about that, I misspoke. I meant to say Edk2 INF spec.
Thanks,
Christian
>-Original Message-
>From: Laszlo Ersek [mailto:ler...@redhat.com]
>Sent: Monday, May 13, 2019 1:20 PM
>To: devel@edk2.groups.io; Rodriguez, Christian
>; fel...@ami.com
>Cc: Feng, Bob C ; Gao, Liming
>; Zhu,
On 05/13/19 20:20, Kinney, Michael D wrote:
> Laszlo,
>
> On Windows build systems, we have to install OpenSSL command line
> utilities. For all host systems, the OpenSSL command line
> utilities need to be in the system path. My point is that this
> is similar to other dependencies like iASL
Laszlo,
On Windows build systems, we have to install OpenSSL command line
utilities. For all host systems, the OpenSSL command line
utilities need to be in the system path. My point is that this
is similar to other dependencies like iASL and NASM.
For the patch discussion, I did not mean to
So the direction put forward by my team is that we should raise an error
instead of a warning because a false positive successful build would be
detrimental to a continuous integration environment. And it would also enforce
the Spec requirements.
The point they are making is that a warning
Reviewed-by: Michael Kubacki
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Liming Gao
> Sent: Monday, May 13, 2019 7:09 AM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [edk2-platforms][ 2/3] Merge Maintainers.txt in
> Platform\Intel
Reviewed-by: Michael Kubacki
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Liming Gao
> Sent: Monday, May 13, 2019 7:09 AM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [edk2-platforms][ 1/3] Update
> Platform/Intel/Readme.md to
Pavan,
On 05/10/19 10:02, Pavan Kumar Aravapalli wrote:
> Hi Team,
>
>
> I am looking for pointers in enabling UEFI boot loader to the existing
> (KVM)VM template. I am trying to enable it for CentOS 6.5(64-bit) no GUI
> 64-bit (KVM) template.
* I'm sorry, this really belongs on a CentOS
On 05/13/19 15:25, Xiaoyu lu wrote:
> (1) CryptoPkg/OpensslLib: Modify process_files.pl for upgrading OpenSSL
> OpenSSL only support seeding NONE for UEFI(rand_unix.c line 93).
> So add --with-rand-seed=none to process_files.pl.
>
> (2) CryptoPkg/OpensslLib: Exclude unnecessary files in
Signed-off-by: Liming Gao
---
Platform/Intel/Readme.md | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/Platform/Intel/Readme.md b/Platform/Intel/Readme.md
index fbf735173f..1da5d0ad29 100644
--- a/Platform/Intel/Readme.md
+++ b/Platform/Intel/Readme.md
@@ -8,7
Signed-off-by: Liming Gao
---
Maintainers.txt| 41 +
Platform/Intel/Maintainers.txt | 60 --
Silicon/Intel/Maintainers.txt | 58
3 files changed, 41 insertions(+), 118
After devel-MinPlatform branch is merged into master branch, Intel platforms
information and maintainers are also added.
Liming Gao (3):
Update Platform/Intel/Readme.md to specify master instead of
devel-MinPlatform branch
Merge Maintainers.txt in Platform\Intel and Silicon\Intel to root
Signed-off-by: Liming Gao
---
Readme.md | 11 +++
1 file changed, 11 insertions(+)
diff --git a/Readme.md b/Readme.md
index 95c0c14522..0d1b6f3ed6 100644
--- a/Readme.md
+++ b/Readme.md
@@ -223,6 +223,17 @@ they will be documented with the platform.
## Socionext
*
https://bugzilla.tianocore.org/show_bug.cgi?id=1799
Add PcdPciSegmentCount PCD in MinPlatformPkg.dec and set default to 1, then
base on PciHostBridge related PCDs to Initialize RootBridges.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marc Chen
Cc: Michael Kubacki
Gentle Reminder.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#40512): https://edk2.groups.io/g/devel/message/40512
Mute This Topic: https://groups.io/mt/31577294/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
Hi Star,
I'am so interested in DMA protection in UEFI. It's a really good
design!
But I have a question about the implemention of DisableDmar() in
IntelSiliconPkg\feature\vtd\intelvtddxe\VtdReg.c
Is it a typing error in the code segment below?
//
// Disable
subscribe edk2-devel
?
?
CONFIDENTIAL NOTE:
This email contains confidential or legally privileged information and is for
the sole use of its intended recipient. Any unauthorized review, use, copying
or forwarding of this email or the
Reviewed-by : Chao Zhang
-Original Message-
From: Gao, Zhichao
Sent: Monday, May 13, 2019 10:55 AM
To: devel@edk2.groups.io
Cc: Zhang, Chao B ; Yao, Jiewen ;
Wang, Jian J ; Zeng, Star ; Gao,
Liming
Subject: [PATCH] SecurityPkg/AuthSeriableLib: Always delete variable in certdb
REF:
https://bugzilla.tianocore.org/show_bug.cgi?id=1799
Add PcdPciSegmentCount PCD in MinPlatformPkg.dec and set default to 1, then
base on PciHostBridge related PCDs to Initialize RootBridges.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marc Chen
Cc: Michael Kubacki
On 05/10/19 04:48, Sean via Groups.Io wrote:
> 1. Agree on the name but not sure whats better. i don't think it
> should be edk2-tools because the idea of this is to be a library of
> support code but not the tools themselves. This limits dependencies
> and keeps the library free of business
Hi Leif,
On 2019.05.13 16:56, Leif Lindholm wrote:
Hi Pete,
On Mon, May 13, 2019 at 09:54:12AM +0100, Pete Batard wrote:
This patch series cleans up and updates the CompilerIntrinsicsLib for ArmPkg.
The first patch removes sources that are no longer used and cleans up the .inf.
The second
Signed-off-by: Liming Gao
---
ReadMe.md | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ReadMe.md b/ReadMe.md
index fbf735173f..f2dcee2e29 100644
--- a/ReadMe.md
+++ b/ReadMe.md
@@ -1,3 +1,5 @@
+# This branch has been migrated into master. Now, it is read only!
+
# **EDK II Minimum
On 05/10/19 10:51, Xiaoyu lu wrote:
> Hi, Laszlo:
>
> Thank you for your time.
>
> I try the method you mentioned.
>
>> (1) Therefore, the right thing to do here is to add "no-store" to the above
>> list, in my opinion. Can you try that, please?
>>
>> And, this change should be a standalone
Dandan:
UefiTianoDecompress() API function header doesn't describe the parameter
Version and the assert condition when Version is not 1 or 2. Please update the
function comments in header file and C source file.
With this change, Reviewed-by: Liming Gao
Thanks
Liming
> -Original
On 05/10/19 12:26, Wang, Jian J wrote:
> Hi Laszlo,
>
> rand_* is needed by openssl itself. BaseCryptLib also provide RandomSeed()
> and RandomBytes() interface to wrap openssl rand functionality. We can't
> just drop them. From platform independent perspective, using performance
> counter is the
Hi Pete,
On Mon, May 13, 2019 at 09:54:12AM +0100, Pete Batard wrote:
> This patch series cleans up and updates the CompilerIntrinsicsLib for ArmPkg.
>
> The first patch removes sources that are no longer used and cleans up the
> .inf.
> The second patch adds memcmp and memmove for MSFT, as I
https://bugzilla.tianocore.org/show_bug.cgi?id=1799
1. Add PcdPciSegmentCount PCD in MinPlatformPkg.dec and set default to 1
2. Base on PciHostBridge related PCDs to Initialize RootBridges.
Signed-off-by: Marc Chen
Cc: Michael Kubacki
Cc: Sai Chaganty
---
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800
The below 3 Smbios drivers have dependency on IntelFramework[Module]Pkg:
* MemorySubClassDxe
* ProcessorSubClassDxe
* SmbiosMiscDxe
Their dependency is on the header file:
IntelFrameworkPkg/Include/FrameworkDxe.h
for definition
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800
There is no module in the platform that will use
gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile. This commit will
drop the consume of this PCD.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Michael D Kinney
Signed-off-by: Hao A Wu
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800
After the drop of the consume of GenericBdsLib, there is no module that
will use gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile. This
commit will drop the consume of this PCD.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Michael D
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800
This commit will update the DSC file to consume the LzmaDecompressLib in
MdeModulePkg, instead of using the one in IntelFrameworkModulePkg.
Please note that, the 2 LzmaDecompressLib are identical. Thus, there is no
functional impact for
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800
This commit will update the DSC.INC file to consume the
ReportStatusCodeLib (DXE phase instance) in MdeModulePkg, instead of using
the one in IntelFrameworkModulePkg.
Please note that, the 2 ReportStatusCodeLib are almost identical. Thus,
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800
There is no module in the platform that will use
gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile. This commit will
drop the consume of this PCD.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Michael D Kinney
Signed-off-by: Hao A Wu
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800
This commit will update the DSC file to consume the LzmaDecompressLib in
MdeModulePkg, instead of using the one in IntelFrameworkModulePkg.
Please note that, the 2 LzmaDecompressLib are identical. Thus, there is no
functional impact for
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800
This commit will update the DSC file to consume the LzmaDecompressLib in
MdeModulePkg, instead of using the one in IntelFrameworkModulePkg.
Please note that, the 2 LzmaDecompressLib are identical. Thus, there is no
functional impact for
Reviewed-by: Kelly Steele
> -Original Message-
> From: Kinney, Michael D
> Sent: May 09, 2019 20:46
> To: devel@edk2.groups.io
> Cc: Sun, Zailiang ; Qian, Yi ;
> Steele, Kelly ; Ni, Ray ; Kubacki,
> Michael A ; Leif Lindholm
> ; Ard Biesheuvel
> Subject: [Patch 2/2] edk2: Update
This patch is for edk2-platform. Please add edk2-platform in the patch title,
like [edk2-platforms][Patch].
When you generate the patch, you can use the command git format-patch -1
--subject-prefix="edk2-platform"
Thanks
Liming
>-Original Message-
>From: devel@edk2.groups.io
Hisilicon platforms have already switched to the BDS driver in
MdeModulePkg by commit 5845a5cde9d6bd51d77067b2594654005887a434.
Thus, the Hisilicon PlatformBdsLib is no longer needed. This commit will
remove this library instance implementation.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Michael
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800
This commit will update the DSC.INC file to consume the LzmaDecompressLib
in MdeModulePkg, instead of using the one in IntelFrameworkModulePkg.
Please note that, the 2 LzmaDecompressLib are identical. Thus, there is no
functional impact for
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800
This commit will update the DSC file to consume the LzmaDecompressLib in
MdeModulePkg, instead of using the one in IntelFrameworkModulePkg.
Please note that, the 2 LzmaDecompressLib are identical. Thus, there is no
functional impact for
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800
This commit adopts a similar approach to edk2 commit
a6d594c5fabd8da2273d2794826ec086cf9c3c04.
Currently, Hisilicon platforms use modules from under
"IntelFrameworkModulePkg/Universal/StatusCode/", which produce
EFI_PEI_PROGRESS_CODE_PPI
This series will drop the IntelFramework[Module]Pkg dependency for
platforms within the edk2-platforms repo. This is the 1st part series,
which will handle platforms only with explicit dependency on the framework
packages.
The affected platforms include:
* Platform/AMD/OverdriveBoard
*
Sorry to mention, this series is also available at:
https://github.com/hwu25/edk2-platforms/tree/drop_intelframework_part1_v1
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Wu,
> Hao A
> Sent: Tuesday, May 14, 2019 10:08
Please ignore this patch.
It was sent by mistake.
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Wu,
> Hao A
> Sent: Tuesday, May 14, 2019 10:08 AM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A; Ard Biesheuvel; Leif
Please ignore this patch.
It was sent by mistake.
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Wu,
> Hao A
> Sent: Tuesday, May 14, 2019 10:08 AM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A; Ard Biesheuvel; Leif
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800
This commit will update the DSC file to consume the ReportStatusCodeLib
(DXE phase and Runtime instances) in MdeModulePkg, instead of using the
one in IntelFrameworkModulePkg.
Please note that, the DXE and Runtime ReportStatusCodeLib
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800
This commit will update the DSC file to consume the ReportStatusCodeLib
(DXE phase and Runtime instances) in MdeModulePkg, instead of using the
one in IntelFrameworkModulePkg.
Please note that, the DXE and Runtime ReportStatusCodeLib
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800
This commit will update the DSC file to consume the ReportStatusCodeLib
(DXE phase and Runtime instances) in MdeModulePkg, instead of using the
one in IntelFrameworkModulePkg.
Please note that, the DXE and Runtime ReportStatusCodeLib
RFC Edk2-ToolEnv creation
Create a new tianocore owned repository to host python code to support an
extensible, pluggable, rich environment. This environment has command line
interfaces to support building a product, building CI, running tests, and
downloading dependencies. This environment
Laszlo,
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Tuesday, May 14, 2019 12:46 AM
> To: devel@edk2.groups.io; Wang, Jian J
> Cc: Zeng, Star ; Dong, Eric ; Ni,
> Ray
> Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg
On 2019-05-13 20:55, Sean via Groups.Io wrote:
>
> RFC Edk2-ToolEnv creation
>
>
>
> Create a new tianocore owned repository to host python code to support
> an extensible, pluggable, rich environment. This environment has
> command line interfaces to support building a product, building CI,
>
I entered a new BZ https://bugzilla.tianocore.org/show_bug.cgi?id=1804 to track
the [Sources] section check function.
Agree that "minimize the performance hit by saving the data from
ModuleMakefile.GetFileDependency() to memory and reuse it later in GenMake to
save on IO and search."
Thanks,
Sure. I will send RFC for new Package.
>-Original Message-
>From: Kubacki, Michael A
>Sent: Tuesday, May 14, 2019 2:53 AM
>To: Gao, Liming ; devel@edk2.groups.io; Dong, Eric
>
>Cc: Ni, Ray ; Desimone, Nathaniel L
>
>Subject: RE: [edk2-devel] [Patch] [edk2-platforms]
Michael:
I know you are aware of this change. This patch is to let people know this
branch is read only so that there is no more commit in devel-MinPlatform branch.
Thanks
Liming
>-Original Message-
>From: Kubacki, Michael A
>Sent: Tuesday, May 14, 2019 3:00 AM
>To:
Hi Laszlo:
I'm sorry I missed this email, and also sorry for I didn't understand
your points.
I focus on what the current code has, so what to add. I should pay more
attention to why I need to change it. Your approach is better. Better to make
review easier.
About
75 matches
Mail list logo
