Re: [edk2-devel] [Patch 4/5] UefiCpuPkg/CpuMpPei: Produce EDKII_PEI_MP_SERVICES2_PPI.

2019-07-21 Thread Dong, Eric
Ray, Agree, will remove this parameter in next version change. Thanks, Eric > -Original Message- > From: Ni, Ray > Sent: Friday, July 19, 2019 4:03 PM > To: devel@edk2.groups.io; Dong, Eric > Cc: Laszlo Ersek ; Kumar, Chandana C > ; Zeng, Star > Subject: RE: [edk2-devel] [Patch 4/5]

Re: [edk2-devel] [Patch] BaseTools: Fixed the mis-using strip() function issue.

2019-07-21 Thread Liming Gao
Bob: > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Bob Feng > Sent: Sunday, July 21, 2019 11:55 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Feng, Bob C > Subject: [edk2-devel] [Patch] BaseTools: Fixed the mis-using strip() function >

Re: [edk2-devel] [Patch 0/9] Enable multiple process AutoGen

2019-07-21 Thread Laszlo Ersek
Hi Bob, On 07/18/19 08:14, Bob Feng wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 > > In order to improve the build performance, we implemented > multiple-processes AutoGen. This change will reduce 20% time > for AutoGen phase. > > The design document can be got from: >

Re: [edk2-devel] [Patch 0/9] Enable multiple process AutoGen

2019-07-21 Thread Steven Shi
> This is the problem: the checksum does not match the one from > (3c). And, the binary from (3f) is in fact mis-built, it > crashes immediately when launched on QEMU/KVM, with "emulation > failure". It looks an incremental build error. This multi-process build

Re: [edk2-devel] [PATCH v1 1/6] ShellPkg: acpiview: Allow passing buffer length to DumpGasStruct()

2019-07-21 Thread Gao, Zhichao
> -Original Message- > From: Krzysztof Koch [mailto:krzysztof.k...@arm.com] > Sent: Friday, July 19, 2019 6:41 PM > To: Gao, Zhichao ; devel@edk2.groups.io > Cc: nd > Subject: RE: [PATCH v1 1/6] ShellPkg: acpiview: Allow passing buffer length to > DumpGasStruct() > > Hi Zhichao, > >

[edk2-devel] [PATCH] OvmfPkg: enable multiprocessor builds when using build.sh

2019-07-21 Thread rebecca
When building both BaseTools and OvmfPkg, enable multiprocessor builds, using up to the number of cores available in the system. This can drastically reduce build times. For example, on a modern ThreadRipper system the time required to build decreases from 3 minutes to 1 minute. Signed-off-by:

Re: [edk2-devel] [PATCH] OvmfPkg: enable multiprocessor builds when using build.sh

2019-07-21 Thread rebecca
On 2019-07-21 18:58, rebe...@bsdio.com wrote: > When building both BaseTools and OvmfPkg, enable multiprocessor builds, > using up to the number of cores available in the system. This can > drastically reduce build times. > For example, on a modern ThreadRipper system the > time required to build

Re: [edk2-devel] [Patch 1/1 V2] BaseTools: Create ".cache" folder when initialize Build object

2019-07-21 Thread Bob Feng
Pushed @ 5f89bcc4604ea9e439039d873e34a8c06b47c707 -Original Message- From: Kinney, Michael D Sent: Friday, July 19, 2019 1:11 PM To: Feng, Bob C ; devel@edk2.groups.io; Kinney, Michael D Cc: Gao, Liming Subject: RE: [Patch 1/1 V2] BaseTools: Create ".cache" folder when initialize

Re: [edk2-devel] [PATCH v7 0/4] Implement SM3 measured boot

2019-07-21 Thread Wang, Jian J
Laszlo, Thanks for pushing the patches. Our internal CI has problem these days and I haven't got a complete report. It blocked me to do it. Regards, Jian > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Laszlo Ersek > Sent: Friday, July 19,

Re: [edk2-devel] [PATCH V2 4/4] MdeModulePkg/CapsuleRuntimeDxe: Implement RuntimeServicesSupported

2019-07-21 Thread Gao, Zhichao
Hi Mike, I agree to remove the GetVariable. But why for ExitBootServices? If we remove that, the services would be disabled at both boot phase and runtime phase. Thanks, Zhichao > -Original Message- > From: Kinney, Michael D > Sent: Saturday, July 20, 2019 12:09 AM > To:

Re: [edk2-devel] [PATCH V2 0/4] Add a pcd PcdBootManagerInBootOrder to control whether BootManager is in BootOrder

2019-07-21 Thread Gao, Zhichao
Hi Laszlo, > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Laszlo Ersek > Sent: Friday, July 19, 2019 10:15 PM > To: Gao, Zhichao ; devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Wang, Jian J ; Wu, Hao A > ; Ni, Ray ; Zeng,

Re: [edk2-devel] [PATCH V2 4/4] MdeModulePkg/CapsuleRuntimeDxe: Implement RuntimeServicesSupported

2019-07-21 Thread Michael D Kinney
The UefiRuntimeLib has an EfiAtRuntime() service. Pease use that instead. The CapsuleRuntimeDxe module is already using the UefiRuntimeLib library. The patch below adds a 2nd ExitBootServices event and global that is not needed. Thanks, Mike > -Original Message- > From: Gao, Zhichao

Re: [edk2-devel] [Patch] BaseTools: Fixed the mis-using strip() function issue.

2019-07-21 Thread Liming Gao
Ok. Make sense. Reviewed-by: Liming Gao > -Original Message- > From: Feng, Bob C > Sent: Monday, July 22, 2019 8:48 AM > To: Gao, Liming ; devel@edk2.groups.io > Subject: RE: [edk2-devel] [Patch] BaseTools: Fixed the mis-using strip() > function issue. > > Liming, > > CmdSign[3:]

Re: [edk2-devel] [Patch] BaseTools: Fixed the mis-using strip() function issue.

2019-07-21 Thread Bob Feng
Thanks. Pushed. SHA-1: bb824f685d760f560bb3c3fb14af394ab3b3544f Thanks, Bob -Original Message- From: Gao, Liming Sent: Monday, July 22, 2019 11:43 AM To: Feng, Bob C ; devel@edk2.groups.io Subject: RE: [edk2-devel] [Patch] BaseTools: Fixed the mis-using strip() function issue. Ok.

Re: [edk2-devel] [edk2-platforms Patch V2 5/5] Vlv2Tbl2DevicePkg: Convert BAT/sh Build scripts to Python

2019-07-21 Thread Gary Lin
On Thu, Jul 18, 2019 at 11:02:47PM -0700, Michael D Kinney wrote: > Convert Build_IFWI and bld_vlv BAT/sh scripts to OS > independent python script PeBuild.py. This script > generates the BiosId file. Standard EDK II build > commands are used to build FW images and capsules. > > * Sample

[edk2-devel] [PATCH 4/5] MdeModulePkg: Add SecuritAuditLib to dec file

2019-07-21 Thread Gao, Zhichao
From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2006 Add the lib instance to LibraryClasses for components that consume it. Add the lib instance to Components for build only. Cc: Jian J Wang Cc: Hao A Wu Cc: Ray Ni Cc: Star Zeng Cc: Liming gao Cc: Sean Brogan Cc:

[edk2-devel] [PATCH 5/5] MdeModulePkg/PiSmmIpl: Use SecurityLockAuditLib for debug

2019-07-21 Thread Gao, Zhichao
From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2006 Use SecurityLockAuditLib in PiSmmIpl to output debug message while lock the SMRAM. Cc: Jian J Wang Cc: Hao A Wu Cc: Ray Ni Cc: Star Zeng Cc: Liming gao Cc: Sean Brogan Cc: Michael Turner Cc: Bret Barkelew

[edk2-devel] [PATCH 1/5] MdeModulePkg: Add header file for SecurityLockAuditLib

2019-07-21 Thread Gao, Zhichao
From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2006 Add header file for SecurityLockAuditLib and add its file path to dec file. Cc: Jian J Wang Cc: Hao A Wu Cc: Ray Ni Cc: Star Zeng Cc: Liming gao Cc: Sean Brogan Cc: Michael Turner Cc: Bret Barkelew

[edk2-devel] [PATCH 3/5] MdeModulePkg/SecurityLockAuditLibNull: Add null version lib

2019-07-21 Thread Gao, Zhichao
From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2006 Add a null version library instance of SecurityLockAuditLib. It provides the new API SecurityLockReportEvent without any function. Cc: Jian J Wang Cc: Hao A Wu Cc: Ray Ni Cc: Star Zeng Cc: Liming gao Cc: Sean

[edk2-devel] [PATCH 2/5] MdeModulePkg/SecurityLockAuditDebugLib: Add lib instance

2019-07-21 Thread Gao, Zhichao
From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2006 Add the instance of SecurityLockAuditLib. This instance has one interface SecurityLockReportEvent to log hardware and software security locks info. Cc: Jian J Wang Cc: Hao A Wu Cc: Ray Ni Cc: Star Zeng Cc: Liming

[edk2-devel] [PATCH 0/5] Add new lib SecurityLockAuditLib to log message for security event

2019-07-21 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2006 For clearly see where security events occur in the platform. Add SecurityLockAuditLib to provide a consistant debug log message format that can be easily parsed in a post processing step. Cc: Jian J Wang Cc: Hao A Wu Cc: Ray Ni Cc: Star

Re: [edk2-devel] [PATCH 3/4] CryptoPkg/BaseCryptLib: list module-internal header files in INF [Sources]

2019-07-21 Thread Wang, Jian J
Reviewed-by: Jian J Wang > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Saturday, July 20, 2019 12:43 AM > To: edk2-devel-groups-io > Cc: Wang, Jian J ; Ye, Ting > Subject: [PATCH 3/4] CryptoPkg/BaseCryptLib: list module-internal header > files in INF

Re: [edk2-devel] [Patch] BaseTools: Fixed the mis-using strip() function issue.

2019-07-21 Thread Bob Feng
Liming, CmdSign[3:] means to get the CmdSign sub string from the 4th character to it end. The former code can make sure CmdSign starts with "/Fo", CmdSign[3:] is just to remove "/Fo". The issue in this case is that the CmdSign is like "/FoF://abc//cde", and CmdSign.lstrip("/Fo") removes