[edk2-devel] [Patch 3/3] BaseTools:Remove the unnecessary operation of renaming a file.

2019-09-10 Thread Bob Feng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2183 This patch is going to remove rename call to reduce unnecessary io operation so that saving build time. Cc: Liming Gao Cc: Bob Feng Signed-off-by: Zhiju.Fan --- BaseTools/Source/Python/Common/Misc.py | 23 +++ 1

[edk2-devel] [Patch 2/3] BaseTools: remove unnecessary calls of os.exist

2019-09-10 Thread Bob Feng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2101 This patch is going to remove unnecessary calls of os.exist() Cc: Liming Gao Signed-off-by: Bob Feng --- .../Source/Python/AutoGen/AutoGenWorker.py| 7 +- BaseTools/Source/Python/AutoGen/GenC.py | 97 ++-

[edk2-devel] [Patch 1/3] BaseTools: Improve GetDependencyList function

2019-09-10 Thread Bob Feng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2102 GetDependencyList get the header file via re.findall in the whole header file. This patch is to pre-process the header file and to feed the shorter string to re.findall. This patch is to improve GetDependencyList() efficiency Cc: Liming

Re: [edk2-devel] [edk2-platforms][PATCH V2 5/6] PurleySktPkg: Clean up duplicated SmramMemoryReserve.h files

2019-09-10 Thread Bu, Daocheng
Reviewed-by: Daocheng Bu Thanks, Amos UEFI FW, IAFW or System Firmware is more generic & accurate it's not BIOS anymore! -Original Message- From: Oram, Isaac W Sent: Wednesday, September 11, 2019 10:44 AM To: Chen, Marc W ; devel@edk2.groups.io Cc: Gillispie, Thad ; Bu, Daocheng

Re: [edk2-devel] Polling Interval in MNP

2019-09-10 Thread Rabeda, Maciej
Hi Ramesh, I cannot see the 10ms comparison you have mentioned in MnpCheckPacketTimeout(). Quick code analysis suggests that received packets enqueued in the specific MNP instance queue have timeout value assigned to them. See MnpQueueRcvdPacket() line: RxDataWrap->TimeoutTick =

[edk2-devel] reg: Polling Interval in MNP

2019-09-10 Thread Ramesh R.
Hi all: In the Network Package, MNPDxe Driver has the timeout check in MnpCheckPacketTimeout() for the interval of 10 ms. This interval is OK when we have the On board / Add on network controllers. In the cases of Network devices exposed via Inband (Virtual USB exposing network interfaces)

Re: [edk2-devel] Increase robustness of nmake BaseTools build for space also used by make

2019-09-10 Thread Liming Gao
Reviewed-by: Liming Gao From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Burt Silverman Sent: Sunday, September 8, 2019 6:10 AM To: devel@edk2.groups.io Subject: [edk2-devel] Increase robustness of nmake BaseTools build for space also used by make Author: Burt Silverman

Re: [edk2-devel] [PATCH edk2-CCSS 0/3] Coding Standards: add rule for documenting spurious variable assignments

2019-09-10 Thread Leif Lindholm
On Mon, Sep 09, 2019 at 02:35:15PM +0200, Laszlo Ersek wrote: > On 09/06/19 14:26, Leif Lindholm wrote: > > On Thu, Sep 05, 2019 at 08:38:17PM +0200, Laszlo Ersek wrote: > >> Repo: https://github.com/lersek/edk2-CCodingStandardsSpecification.git > >> Branch: spurious_assign_bz_607 > >> > >>

Re: [edk2-devel] [PATCH edk2-CCSS 0/3] Coding Standards: add rule for documenting spurious variable assignments

2019-09-10 Thread Ryszard Knop
On Tue, 2019-09-10 at 16:33 +0100, Leif Lindholm wrote: > On Mon, Sep 09, 2019 at 02:35:15PM +0200, Laszlo Ersek wrote: > > On 09/06/19 14:26, Leif Lindholm wrote: > > > On Thu, Sep 05, 2019 at 08:38:17PM +0200, Laszlo Ersek wrote: > > > > Repo: > > > >

Re: [edk2-devel] [edk2-platforms][PATCH V4] AdvancedFeaturePkg/S3Advanced Add S3 Advanced PEIM driver

2019-09-10 Thread Kubacki, Michael A
* Please keep the directory as just S3 so the path is AdvancedFeaturePkg/S3/S3AdvancedPei.inf. * The module could optionally be renamed to just S3Pei.inf to simplify the name * Please add new PEIM into edk2-platforms\Platform\Intel\AdvancedFeaturePkg\AdvancedFeaturePkg.dsc for build test. *

[edk2-devel] [edk2-platforms] [PATCH v1 0/1] DisplayLink GOP driver USB msg initialisation

2019-09-10 Thread Andy Hayes
Corrected initialisation of one of data structures used to transmit USB control messages. Mistake had no practical effects but fixing to be on safe side. https://github.com/andy-hayes/edk2-platforms Cc: Leif Lindholm Cc: Ard Biesheuvel Andy Hayes (1): Drivers/DisplayLink/DisplayLinkPkg

[edk2-devel] [PATCH v1 1/1] Drivers/DisplayLink/DisplayLinkPkg DisplayLinkGop

2019-09-10 Thread Andy Hayes
Corrected initialisation of one of data structures used to transmit USB control messages. Mistake had no practical effects but fixing to be on safe side. Cc: Leif Lindholm Cc: Ard Biesheuvel Signed-off-by: Andy Hayes --- Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbTransfer.c | 2 +-

[edk2-devel] [Patch 0/3] Clean BaseTools code for build performance

2019-09-10 Thread Bob Feng
REF: 1 https://bugzilla.tianocore.org/show_bug.cgi?id=2102 2 https://bugzilla.tianocore.org/show_bug.cgi?id=2101 3 https://bugzilla.tianocore.org/show_bug.cgi?id=2183 By profiling build Ovmf with cProfile: 1. re.findall time reduced: after patch: 0.017 {method 'findall' of '_sre.SRE_Pattern'

Re: [edk2-devel] [edk2-test] [PATCH v2 1/1] uefi-sct/SctPkg: SNP Statistics may be unsupported

2019-09-10 Thread Eric Jin
Pushed at 269f8a35e44f2093625b3671f372f68e2983c49d -Original Message- From: devel@edk2.groups.io On Behalf Of Eric Jin Sent: Tuesday, September 10, 2019 9:16 AM To: Heinrich Schuchardt ; EDK II Development Cc: Supreeth Venkatesh ; Stephano Cetola Subject: Re: [edk2-devel] [edk2-test]

Re: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: fix typo 'supproted'

2019-09-10 Thread Eric Jin
Pushed at 07a9c88ea515260a3715c2bc9be850033efa5387 -Original Message- From: devel@edk2.groups.io On Behalf Of Eric Jin Sent: Friday, September 6, 2019 1:51 PM To: Heinrich Schuchardt ; EDK II Development Cc: Supreeth Venkatesh ; Stephano Cetola Subject: Re: [edk2-devel] [edk2-test]

Re: [edk2-devel] [edk2-platforms: PATCH] KabylakeOpenBoardPkg: Missed 64KB Temporary RAM in Dispatch mode.

2019-09-10 Thread Kubacki, Michael A
Reviewed-by: Michael Kubacki > -Original Message- > From: Chiu, Chasel > Sent: Friday, September 6, 2019 12:01 AM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Desimone, Nathaniel > L ; Gao, Liming > Subject: [edk2-platforms: PATCH] KabylakeOpenBoardPkg: Missed 64KB > Temporary

Re: [edk2-devel] [PATCH 1/2] MinPlatformPkg/AcpiTables: Initialize variables before used

2019-09-10 Thread Nate DeSimone
Hi Shenglei, Please send a second patch series with the copyrights updated. Thanks, Nate -Original Message- From: Zhang, Shenglei Sent: Monday, September 2, 2019 5:30 AM To: devel@edk2.groups.io Cc: Kubacki, Michael A ; Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming Subject:

Re: [edk2-devel] [PATCH] MinPlatformPkg/TestPointCheckLib: Add check for pointers

2019-09-10 Thread Nate DeSimone
Hi Shenglei, Please send a second patch series with the copyrights updated. Thanks, Nate -Original Message- From: Zhang, Shenglei Sent: Monday, September 2, 2019 5:35 AM To: devel@edk2.groups.io Cc: Kubacki, Michael A ; Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming Subject:

[edk2-devel] [edk2-platforms][PATCH V5] AdvancedFeaturePkg/S3: Add S3 PEIM driver

2019-09-10 Thread Marc W Chen
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2154 Implement a S3 PEIM driver for supporting S3 feature. So far this driver only install EFI_PEI_MM_ACCESS_PPI for S3 resume case. Cc: Michael Kubacki Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Marc Chen ---

Re: [edk2-devel] [edk2-rfc] [edk2-devel] UEFI Variable SMI Reduction

2019-09-10 Thread Yao, Jiewen
Nate I believe this SMI reduction work only handle GetVariable. VarCheckLib only handles SetVariable. VarCheckLib does not handle GetVaraible. Thank you Yao Jiewen From: Desimone, Nathaniel L Sent: Wednesday, September 11, 2019 10:43 AM To: devel@edk2.groups.io; Yao, Jiewen ; Johnson, Michael

[edk2-devel] Cancelled Event: TianoCore Design / Bug Triage - EMEA - Wednesday, 11 September 2019 #cal-cancelled

2019-09-10 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCEL CALSCALE:GREGORIAN BEGIN:VEVENT STATUS:CANCELLED UID:calendar.15...@groups.io DTSTAMP:20190911T001150Z ORGANIZER;CN=Stephano Cetola:mailto:stephano.cet...@linux.intel.com

Re: [edk2-devel] Cancelled Event: TianoCore Design / Bug Triage - EMEA - Wednesday, 11 September 2019 #cal-cancelled

2019-09-10 Thread Stephano Cetola
> On Sep 10, 2019, at 5:11 PM, devel@edk2.groups.io Calendar > wrote: > > Cancelled: TianoCore Design / Bug Triage - EMEA > > This event has been cancelled. No topics for this week. Also, “Need Info” reminders went out. I’ve tried to automate these as much as possible, while keeping

[edk2-devel] [Patch] UefiCpuPkg/CpuDxe: clean up PAGE_TABLE_LIB_PAGING_CONTEXT usage.

2019-09-10 Thread Dong, Eric
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1039 Current implementation not checks system mode before using PAGE_TABLE_LIB_PAGING_CONTEXT.ContextData.X64 or PAGE_TABLE_LIB_PAGING_CONTEXT.ContextData.Ia32. This patch check the mode before using the correct one. Cc: Ray Ni Cc: Laszlo

Re: [edk2-devel] [edk2-platforms] [PATCH 1/3] AdvancedFeaturePkg: Fix GCC build

2019-09-10 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Agyeman, Prince Sent: Monday, September 9, 2019 4:15 PM To: devel@edk2.groups.io Cc: Wei, David Y ; Gao, Liming ; Sinha, Ankit ; Agyeman, Prince ; Kubacki, Michael A ; Desimone, Nathaniel L Subject: [edk2-platforms] [PATCH 1/3]

Re: [edk2-devel] [edk2-platforms] [PATCH 3/3] SimicsIch10Pkg: Fix GCC build issues

2019-09-10 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Agyeman, Prince Sent: Monday, September 9, 2019 4:15 PM To: devel@edk2.groups.io Cc: Wei, David Y ; Gao, Liming ; Sinha, Ankit ; Agyeman, Prince ; Kubacki, Michael A ; Desimone, Nathaniel L Subject: [edk2-platforms] [PATCH 3/3]

Re: [edk2-devel] [edk2-platforms][PATCH V2 5/6] PurleySktPkg: Clean up duplicated SmramMemoryReserve.h files

2019-09-10 Thread Oram, Isaac W
Reviewed-by: Isaac Oram -Original Message- From: Chen, Marc W Sent: Monday, September 2, 2019 8:36 AM To: devel@edk2.groups.io Cc: Gillispie, Thad ; Bu, Daocheng ; Oram, Isaac W ; Desimone, Nathaniel L Subject: [edk2-platforms][PATCH V2 5/6] PurleySktPkg: Clean up duplicated

Re: [edk2-devel] [edk2-rfc] [edk2-devel] UEFI Variable SMI Reduction

2019-09-10 Thread Nate DeSimone
Hi All, There is a security issue with regard to the way VarCheckLib works. There are plenty of usages of VarCheckLib that are intended to prevent ring0 from reading a variable after ReadyToBoot() is called. If we assume a malicious operating system, then having a ring0 buffered version of the

Re: [edk2-devel] [edk2-platforms: PATCH] KabylakeOpenBoardPkg: Missed 64KB Temporary RAM in Dispatch mode.

2019-09-10 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Chiu, Chasel Sent: Friday, September 6, 2019 12:01 AM To: devel@edk2.groups.io Cc: Kubacki, Michael A ; Desimone, Nathaniel L ; Gao, Liming Subject: [edk2-platforms: PATCH] KabylakeOpenBoardPkg: Missed 64KB Temporary RAM in Dispatch

Re: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: setting key toggle state may be unsupported

2019-09-10 Thread Eric Jin
Hi Heinrich, It is reasonable to accept the EFI_UNSUPPORTED. I agree. The patch had better adjust the StandardLib->RecordMessage to StandardLib->RecordAssertion, and the AssertionType is EFI_TEST_ASSERTION_WARNING. It gives SCT user a chance to notice this(not silence it) to judge the issue is

Re: [edk2-devel] [edk2-platforms] [PATCH 2/3] SimicsOpenBoardPkg: Fix GCC build issues

2019-09-10 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Agyeman, Prince Sent: Monday, September 9, 2019 4:15 PM To: devel@edk2.groups.io Cc: Wei, David Y ; Gao, Liming ; Sinha, Ankit ; Agyeman, Prince ; Kubacki, Michael A ; Desimone, Nathaniel L Subject: [edk2-platforms] [PATCH 2/3]

Re: [edk2-devel] [edk2-platforms][PATCH V5] AdvancedFeaturePkg/S3: Add S3 PEIM driver

2019-09-10 Thread Kubacki, Michael A
Reviewed-by: Michael Kubacki > -Original Message- > From: devel@edk2.groups.io On Behalf Of Marc W > Chen > Sent: Tuesday, September 10, 2019 7:27 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chaganty, Rangasai V > ; Gao, Liming ; Chen, > Marc W > Subject: [edk2-devel]

Re: [edk2-devel] [edk2-platforms][PATCH V5] AdvancedFeaturePkg/S3: Add S3 PEIM driver

2019-09-10 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Chen, Marc W Sent: Tuesday, September 10, 2019 7:27 PM To: devel@edk2.groups.io Cc: Kubacki, Michael A ; Chaganty, Rangasai V ; Gao, Liming ; Chen, Marc W Subject: [edk2-platforms][PATCH V5] AdvancedFeaturePkg/S3: Add S3 PEIM driver

Re: [edk2-devel] [Patch 0/3 V2]Enable --genfds-multi-thread to default build

2019-09-10 Thread Liming Gao
Bob: I have no other comments for this patch set. Reviewed-by: Liming Gao Thanks Liming > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Bob Feng > Sent: Friday, September 6, 2019 9:23 PM > To: devel@edk2.groups.io > Subject: [edk2-devel]

Re: [edk2-devel] [PATCH] q35: lpc: allow to lock down 128K RAM at default SMBASE address

2019-09-10 Thread Igor Mammedov
On Mon, 9 Sep 2019 21:15:44 +0200 Laszlo Ersek wrote: > Hi Igor, > > On 09/05/19 17:49, Igor Mammedov wrote: > > lpc already has SMI negotiation feature, extend it by adding > > optin ICH9_LPC_SMI_F_LOCKED_SMBASE_BIT to supported features. > > > > Writing this bit into

Re: [edk2-devel] [Patch 1/3] BaseTools: Fixed the build fail on Linux with --genfds-multi-thread

2019-09-10 Thread Liming Gao
OK. I understand this case. > -Original Message- > From: Feng, Bob C > Sent: Monday, September 9, 2019 4:00 PM > To: Gao, Liming ; devel@edk2.groups.io > Subject: RE: [edk2-devel] [Patch 1/3] BaseTools: Fixed the build fail on > Linux with --genfds-multi-thread > > For the case that

[edk2-devel] Upcoming Event: TianoCore Design / Bug Triage - EMEA - Wed, 09/11/2019 8:00am-9:00am #cal-reminder

2019-09-10 Thread devel@edk2.groups.io Calendar
*Reminder:* TianoCore Design / Bug Triage - EMEA *When:* Wednesday, 11 September 2019, 8:00am to 9:00am, (GMT-07:00) America/Los Angeles *Where:* https://zoom.us/j/695893389 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=503241 ) *Organizer:* Stephano Cetola

Re: [edk2-devel] [edk2-platforms: PATCH 0/2] Armada 7k8k SPI flash driver improvements

2019-09-10 Thread Marcin Wojtas
pon., 9 wrz 2019 o 17:52 Patryk Duda napisał(a): > > Hi, > > This patchset contains progress bar implementation for MvSpiFlash driver and > small fix in calculating number of sectors to write. > > Progress bar implementation was mostly borrowed from TFTP module. > During implementation it turned

Re: [edk2-devel] [edk2-platforms: PATCH] Marvell/Drivers: MvPhyDxe: Fill MdioIndex field in PhyDev

2019-09-10 Thread Marcin Wojtas
pon., 9 wrz 2019 o 17:53 Patryk Duda napisał(a): > > This patch fixes missing MdioIndex copying during initialization. > This bug appeared as inability to communicate with PHY connected > to MDIO other than first. > > Signed-off-by: Patryk Duda > --- >

Re: [edk2-devel] [PATCH v3 1/1] MdePkg: Add STATIC_ASSERT macro

2019-09-10 Thread Philippe Mathieu-Daudé
On 8/17/19 1:28 AM, Vitaly Cheptsov via Groups.Io wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2048 > > Provide a macro for compile time assertions. > Equivalent to C11 static_assert macro from assert.h. > > Signed-off-by: Vitaly Cheptsov > --- > MdePkg/Include/Base.h | 14

Re: [edk2-devel] [edk2-platforms] [PATCH 0/3] Fix SimicsOpenBoardPkg GCC Build

2019-09-10 Thread Philippe Mathieu-Daudé
Hi Prince, On 9/10/19 1:15 AM, Agyeman, Prince wrote: > This patch series fix gcc build issues seen > in SimicsOpenBoardPkg. > Patches were tested on GCC 5 > > Prince Agyeman (3): > AdvancedFeaturePkg: Fix GCC build > SimicsOpenBoardPkg: Fix GCC build issues > SimicsIch10Pkg: Fix GCC build

[edk2-devel] [edk2-core] [PATCH v2 1/1] MdeModulePkg: Make retval in UninstallMultipleProtocol follow Spec

2019-09-10 Thread Heinrich Schuchardt
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1869 The UEFI spec requires that if any error occurs in UninstallMultipleProtocolInterfaces(), EFI_INVALID_PARAMETER is returned and not the return code of UninstallProtocolInterface(). Signed-off-by: Heinrich Schuchardt --- v2 Adjust