Re: [edk2-devel] [PATCH v3] ArmVirtPkg: increase FD/FV size for NOOPT builds

2019-09-13 Thread Laszlo Ersek
On 09/12/19 18:58, Ard Biesheuvel wrote: > After upgrading the CI system we use for building the ArmVirtPkg > targets, we started seeing failures due to the NOOPT build running > out of space when using the CLANG38 toolchain definition combined > with clang 7. > > We really don't want to increase

Re: [edk2-devel] [Patch V2] UefiCpuPkg/CpuExceptionHandlerLib: Fix #AC split lock

2019-09-13 Thread Laszlo Ersek
On 09/09/19 20:40, John E Lofgren wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2150 > > V2 changes: > Add xchg 16 bit instructions to handle sgdt and sidt base > 63:48 bits and 47:32 bits. > Add comment to explain why xchg 64bit isnt being used > > Fix #AC split lock's caused by

[edk2-devel] [PATCH] SimicsOpenBoardPkg: Always set the boot priority by default

2019-09-13 Thread David Wei
When running networks of multiple machines, Simics assigns different disk IDs to each disk created. this change the boot priority and can't boot from SATA HDD directly. Clear boot priority in NVRAM can fix this issue. Cc: Hao Wu Cc: Liming Gao Cc: Ankit Sinha Cc: Agyeman Prince Cc: Kubacki

Re: [edk2-devel] [PATCH 1/1] ArmPlatformPkg: Add missing header files in INF file

2019-09-13 Thread Leif Lindholm
On Sat, Aug 31, 2019 at 03:07:29PM +0100, Pete Batard wrote: > The header files are used but missing in INF, which causes > warning message when building them. > > Signed-off-by: Pete Batard Thanks for the cleanup. Reviewed-by: Leif Lindholm Pushed as 9b5a1c789d39. > --- >

Re: [edk2-devel] [edk2-platforms PATCH 1/1] Platform/RPi3: Add missing header files in INF file

2019-09-13 Thread Leif Lindholm
On Sat, Aug 31, 2019 at 03:08:50PM +0100, Pete Batard wrote: > The header files are used but missing in INF, which causes > warning message when building them. > > Signed-off-by: Pete Batard Reviewed-by: Leif Lindholm Pushed as e60b57484b8a. Thanks! > --- >

Re: [edk2-devel] [PATCH v3] ArmVirtPkg: increase FD/FV size for NOOPT builds

2019-09-13 Thread Ard Biesheuvel
On Fri, 13 Sep 2019 at 13:44, Laszlo Ersek wrote: > > On 09/12/19 18:58, Ard Biesheuvel wrote: > > After upgrading the CI system we use for building the ArmVirtPkg > > targets, we started seeing failures due to the NOOPT build running > > out of space when using the CLANG38 toolchain definition

[edk2-devel] [PATCH 11/11] OvmfPkg/XenBusDxe: Fix XenStoreWaitForEvent use during EBS

2019-09-13 Thread Anthony PERARD
XenStoreWaitForEvent is going to be called when the ExitBootServices is signaled, but both CreateEvent and WaitForEvent can't be used. CreateEvent allocate some memory and WaitForEvent can only be used when TPL is TPL_APPLICATION. When ExitBootServices has been called, simply return immediately

[edk2-devel] [PATCH 01/11] OvmfPkg/XenBusDxe: Fix missing \n in DEBUG messages

2019-09-13 Thread Anthony PERARD
Fix missing \n in DEBUG messages in XenBusDxe and use DEBUG_*. Signed-off-by: Anthony PERARD --- OvmfPkg/XenBusDxe/EventChannel.c | 3 ++- OvmfPkg/XenBusDxe/XenStore.c | 6 +++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/OvmfPkg/XenBusDxe/EventChannel.c

[edk2-devel] [PATCH 09/11] OvmfPkg/XenBusDxe: Fix NotifyExitBoot to avoid Memory Allocation Services

2019-09-13 Thread Anthony PERARD
This patch fix the EVT_SIGNAL_EXIT_BOOT_SERVICES handler to avoid using the Memory Allocation Services. This comes with a new interface named RegisterExitCallback so that PV drivers can disconnect from the backend before XenBusDxe is teared down. Instead of using Disconnect() to tear down the

[edk2-devel] [PATCH 10/11] OvmfPkg/XenPvBlkDxe: Use XenBusIo->RegisterExitCallback

2019-09-13 Thread Anthony PERARD
In order to be able to reset the backend before handing it to the next operating system, it should be reset properly. This patch register a callback function to be called by XenBusDxe during the ExitBootServices event. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2190 Signed-off-by:

[edk2-devel] [PATCH 03/11] OvmfPkg/XenBusDxe: Rework watch events reception

2019-09-13 Thread Anthony PERARD
This patch rework the reception of xenstore watch event to avoid allocation. Instead of queuing watch events, we simply mark a XENSTORE_WATCH as "triggered". We don't need to know how many time we received the event, only that it happened. That avoid to allocate a XENSTORE_MESSAGE for every watch

[edk2-devel] [PATCH 06/11] OvmfPkg/XenBusDxe: Rework XenStoreProcessMessage to avoid allocating memory

2019-09-13 Thread Anthony PERARD
This patch rework XenStoreProcessMessage in order to avoid memory allocation when a reply is expected. Instead of allocating a buffer for this reply, we are going to copy to a buffer passed by the caller. For messages that aren't fully received, they will be stored in a buffer that have been

[edk2-devel] [PATCH 08/11] OvmfPkg/XenBus: Change XENBUS_PROTOCOL to not return allocated memory

2019-09-13 Thread Anthony PERARD
XsRead and XsBackendRead of the XENBUS_PROTOCOL return allocated memory but this isn't allowed during the ExitBootServices call. We need XsRead and XsBackendRead to disconnect from the device so XENBUS_PROTOCOL is changed to use a buffer supplied by a child driver. Ref:

[edk2-devel] [PATCH 00/11] OvmfPkg/XenBusDxe: Fix ExitBootServices handler to avoid allocation

2019-09-13 Thread Anthony PERARD
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2190 Patch series available in this git branch: https://xenbits.xen.org/git-http/people/aperard/ovmf.git br.xenbusdxe-fix-exitbootservices-v1 Hi, This patch series works toward removing usage of Memory Allocation Services in XenBusDxe when

[edk2-devel] [PATCH 07/11] OvmfPkg/XenBusDxe: Use on stack buffer in internal functions

2019-09-13 Thread Anthony PERARD
We will use a buffer on the stack instead of allocating memory for internal functions that are expecting a reply from xenstore. The external interface XENBUS_PROTOCOL isn't changed yet, so allocation are made for XsRead and XsBackendRead. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2190

[edk2-devel] [PATCH 02/11] OvmfPkg/XenBusDxe: Have XenStoreFindWatch take a pointer

2019-09-13 Thread Anthony PERARD
Rework XenStoreFindWatch() to be able to search for a registered watch with a pointer instead of a string. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2190 Signed-off-by: Anthony PERARD --- OvmfPkg/XenBusDxe/XenStore.c | 20 +++- 1 file changed, 11 insertions(+), 9

Re: [edk2-devel] Polling Interval in MNP

2019-09-13 Thread Siyuan, Fu
Hi, Siva The 10ms interval was chosen just by experience. This background polling intends to pick up the coming request (e.g. ARP request) when there is no active polling from upper layer. The ARP time out is 1 second, so using 10ms background polling make the network stack able to receive ARP

[edk2-devel] [PATCH] StandaloneMmPkg: make package .DSC file build again

2019-09-13 Thread Ard Biesheuvel
The StandaloneMmPkg .DSC file went out of sync with the changes applied to the package when I enabled this code on the Synquacer platform in edk2-platforms. So apply the necessary changes to make this package build in isolation. Signed-off-by: Ard Biesheuvel ---

[edk2-devel] [PATCH] SimicsOpenBoardPkg: Change to gEfiSmmSmramMemoryGuid to fix build error

2019-09-13 Thread David Wei
MinPlatform PKG now use gEfiSmmSmramMemoryGuid instead of gEfiSmmPeiSmramMemoryReserveGuid to build memory HOB. SimicsOpenBoardPkg need to update for it accordingly. Cc: Hao Wu Cc: Liming Gao Cc: Ankit Sinha Cc: Agyeman Prince Cc: Kubacki Michael A Cc: Nate DeSimone Cc: Michael D Kinney

Re: [edk2-devel] [PATCH] StandaloneMmPkg: make package .DSC file build again

2019-09-13 Thread Yao, Jiewen
Reviewed-by: Jiewen Yao > -Original Message- > From: Ard Biesheuvel > Sent: Saturday, September 14, 2019 3:05 AM > To: devel@edk2.groups.io > Cc: ler...@redhat.com; achin.gu...@arm.com; Yao, Jiewen > ; Ard Biesheuvel > Subject: [PATCH] StandaloneMmPkg: make package .DSC file build

Re: [edk2-devel] [RFC] EDK II Continuous Integration Phase 1

2019-09-13 Thread Sean via Groups.Io
These tests require using the "edk2-pytool" stuff but are easy to integrate with the github PR or CI flow.  Example of it running the code compliance tests is here: https://dev.azure.com/tianocore/edk2-ci-play/_build?definitionId=13&_a=summary A test run takes about 3 minutes. The past week

[edk2-devel] [edk2-platforms][PATCH V1 1/1] Platform/Intel/Readme.md: Content update

2019-09-13 Thread Kubacki, Michael A
This change makes the following updates: 1. Add SimicsOpenBoardPkg details. 2. Update Python instructions to Python 3.x and mention Python 2.x deprecation. 3. Add Linux build environment set up instructions. 4. Update supported compiler and tool versions to newer versions tested.

Re: [edk2-devel] [Patch V2] UefiCpuPkg/CpuExceptionHandlerLib: Fix #AC split lock

2019-09-13 Thread John E Lofgren
Hi Laszlo, 2. Yes, I can change commit message/comments to separate split lock and #AC. 3. Yes it’s a close platform that is enabling #AC which hits double fault because split lock inside CpuExceptionHandlerLib. Code: I was wondering same thing, why are they using locking mechanism. I wasn’t