> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Thomas
> Abraham via groups.io
> Sent: 15 April 2020 10:05
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; l...@nuviainc.com; Aditya
> Angadi
> Subject: Re: [edk2-devel] [edk2-platforms][PATCH v4 0/9]Platform/Arm/Sgi:
>
Eric,
It's natural to use the volatile registers value derived from BSP in
ApInitReconfig path.
So I still prefer to use the code I suggested in the review comment to the v1
patch.
We can remove the below line that specially for ApInitReconfig path in
MpInitLbInitialize().
>
> New logic changes code flow when CpuMpData->InitFlag == ApInitReconfig.
> In original flow, the code does RestoreVolatileRegisters and CpuFlushTlb, but
> new code only does CpuFlushTlb.
> Is CpuFlushTlb not needs if wake up through Init-Sipi-Sipi? I prefer to not
> change this code flow.
In
> -Original Message-
> From: Dong, Eric
> Sent: Wednesday, April 22, 2020 5:01 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Laszlo
> Ersek ; Kumar, Chandana C
>
> Subject: [PATCH v2 2/2] UefiCpuPkg/MpInitLib: Avoid ApInitReconfig in PEI.
>
> From: "Dong, Eric"
>
>
Hi Pankaj,
When importing these patches, I get a number of git warnings:
0001-Silicon-NXP-Add-I2c-lib.patch
Applying: Silicon/NXP: Add I2c lib
.git/rebase-apply/patch:733: new blank line at EOF.
+
.git/rebase-apply/patch:770: new blank line at EOF.
+
.git/rebase-apply/patch:881: new blank line at
Hi Nate,
On Tue, Apr 21, 2020 at 20:37:39 +, Nate DeSimone wrote:
> This patch series has gotten very old and the review comments were
> minor and cosmetic. Since this is a good new feature, I have made
> the cosmetic fixes and pushed the patch series as
> 765cbda6~..5a60c2de.
Could you make
On Tue, Apr 21, 2020 at 03:54:26PM +0200, Laszlo Ersek wrote:
> (2) Please write a patch for the following:
>
> - move the PlatformDebugLibIoPortDetect() function definition to a
> separate file called "DebugIoPortQemu.c",
On this new file, should I copy the copyright lines from DebugLib.c or
A little off topic thing: isn't the default resolution supposed to be
1024x768? This is the Microsoft regulation which all my physical devices
seem to follow:
https://docs.microsoft.com/en-us/windows-hardware/test/hlk/testref/6afc8979-df62-4d86-8f6a-99f05bbdc7f3
And when the user provides an
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Monday, April 20, 2020 5:41 AM
> To: Gary Lin ; devel@edk2.groups.io; Duran, Leo
>
> Cc: Eric Dong ; Ray Ni
> Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Skip reading
> PlatformId on AMD
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2678
This patch fixes a file permission issue introduced by accident.
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Signed-off-by: Leo Duran
---
UefiCpuPkg/Library/MpInitLib/MpLib.h | 0
1 file changed, 0 insertions(+), 0 deletions(-)
mode
Abner:
> -Original Message-
> From: Chang, Abner (HPS SW/FW Technologist)
> Sent: Tuesday, April 21, 2020 9:05 AM
> To: devel@edk2.groups.io; Gao, Liming
> Subject: RE: [edk2-devel] [PATCH v1 0/9] MdePkg changes for RISC-V edk2 port
>
>
>
> > -Original Message-
> > From:
Reviewed-by: Liming Gao
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chang, Abner
> (HPS SW/FW Technologist)
> Sent: Tuesday, April 21, 2020 3:53 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner (HPS SW/FW Technologist) ; Chen,
> Gilbert ; Leif Lindholm
> ; Kinney,
It is better that pay more attention to code style, for example
Replace
NewTable = AllocatePool( NewSize );
With space
NewTable = AllocatePool (NewSize);
Refer https://github.com/tianocore/tianocore.github.io/wiki/Code-Style-C for
simple principle and
Reviewed-by: Zhiguang Liu
-Original Message-
From: devel@edk2.groups.io On Behalf Of Abner Chang
Sent: Tuesday, April 21, 2020 3:53 PM
To: devel@edk2.groups.io
Cc: abner.ch...@hpe.com; Gilbert Chen ; Leif Lindholm
; Kinney, Michael D ;
Gao, Liming
Subject: [edk2-devel] [PATCH v2 8/9]
Reviewed-by: Zhiguang Liu
-Original Message-
From: devel@edk2.groups.io On Behalf Of Abner Chang
Sent: Tuesday, April 21, 2020 3:53 PM
To: devel@edk2.groups.io
Cc: abner.ch...@hpe.com; Gilbert Chen ; Leif Lindholm
; Kinney, Michael D ;
Gao, Liming
Subject: [edk2-devel] [PATCH v2 5/9]
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Dong, Eric
> Sent: Wednesday, April 22, 2020 4:23 PM
> To: Ni, Ray ; devel@edk2.groups.io
> Cc: Laszlo Ersek ; Kumar, Chandana C
>
> Subject: Re: [edk2-devel] [PATCH 1/2] UefiCpuPkg/MpInitLib:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2683
This patch fixes an assertion because AP can't find the CpuMpData.
When AP is waken up through Init-Sipi-Sipi, AP's IDT should
be restored to pre-allocated buffer so AP can get the CpuMpData
through the IDT base address.
Current code
From: "Dong, Eric"
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2683
In PEI phase, AP already been waked up through ApInitConfig,
so it can directly wake up it through change wakup buffer
instead of use ApInitReconfig flag. It can save some time.
Change code to only use ApInitReconfig
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2683
This patch fixes an assertion because AP can't find the CpuMpData.
When AP is waken up through Init-Sipi-Sipi, AP's IDT should
be restored to pre-allocated buffer so AP can get the CpuMpData
through the IDT base address.
Current code
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2683
This patch serial used to fix an ASSERT issue. Because AP can't find
the CpuMpData through IDT, it raised the ASSERT.
V2:
1. Enhance code comments.
2. Enhance code to remove CpuMpData->ApLoopMode == ApInHltLoop check.
Cc: Ray Ni
Cc:
Hi Oleksiy,
There are tabs and Trailing whitespace in this patch set, which is not
consistent with edk2 coding type.
Please run ECC tool to check your code.
https://github.com/tianocore/tianocore.github.io/wiki/ECC-tool
Thanks
Zhiguang
-Original Message-
From: devel@edk2.groups.io On
Hi Oleksiy,
The definition of EFI_JSON_CONFIG_DATA_ITEM doesn't totally follow the spec.
It is as below in spec without commenting ConfigData.
typedef struct {
UINT32 ConfigDataLength;
UINT8 ConfigData[ConfigDataLength];
} EFI_JSON_CONFIG_DATA_ITEM;
Can you explain why?
Thanks
Zhiguang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2683
This patch fixes an assertion because AP can't find the CpuMpData.
When AP is waken up through Init-Sipi-Sipi, AP's IDT should
be restored to pre-allocated buffer so AP can get the CpuMpData
through the IDT base address.
Current code
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2683
This patch serial used to fix an ASSERT issue. Because AP can't find
the CpuMpData through IDT, it raised the ASSERT.
V2:
1. Enhance code comments.
2. Enhance code to remove CpuMpData->ApLoopMode == ApInHltLoop check.
Cc: Ray Ni
Cc:
> -Original Message-
> From: Ni, Ray
> Sent: Wednesday, April 22, 2020 3:54 PM
> To: Dong, Eric ; devel@edk2.groups.io
> Cc: Laszlo Ersek ; Kumar, Chandana C
>
> Subject: RE: [PATCH 1/2] UefiCpuPkg/MpInitLib: Restore IDT context for APs.
>
> Please check my comments in below.
>
> >
Reviewed-by: Ray Ni
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Wu, Hao
> A
> Sent: Wednesday, April 22, 2020 2:56 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Dong, Eric ; Ni,
> Ray ; Laszlo Ersek
> Subject: [edk2-devel] [PATCH v1] UefiCpuPkg/MpInitLib: Add
Reviewed-by: Ray Ni with a bit comments update:
"Current been used wake up buffer is allocated in PEI phase and no long valid
at this time."
->
"Wakeup buffer allocated in PEI phase is no longer valid in DXE."
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Dong,
>
Please check my comments in below.
> -Original Message-
> From: Dong, Eric
> Sent: Wednesday, April 22, 2020 9:35 AM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Laszlo Ersek ; Kumar,
> Chandana C
> Subject: [PATCH 1/2] UefiCpuPkg/MpInitLib: Restore IDT context for APs.
>
> REF:
Shenglei:
Please submit BZ to describe it. The license should be BSD-2-Clause-Patent.
Thanks
Liming
> -Original Message-
> From: Zhang, Shenglei
> Sent: Wednesday, April 22, 2020 2:57 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
> Subject: [PATCH]
For files to be added to the tree, this feature will check
whether it has BSD license.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
BaseTools/Scripts/PatchCheck.py | 52 -
1 file changed, 51 insertions(+), 1 deletion(-)
diff --git
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2632
Both PEI and DXE instances of the MpInitLib are using PcdLib APIs, but
none of them list the dependency of the PcdLib in INF & header files.
This commit will explicitly add such dependency in .H and .INF files.
Test done:
Library level
Sure, I will do it next time. Thanks for the advice.
> -Original Message-
> From: Liu, Zhiguang [mailto:zhiguang@intel.com]
> Sent: Tuesday, April 21, 2020 4:52 PM
> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
>
> Cc: Chen, Gilbert ; Schaefer, Daniel (DualStudy)
101 - 132 of 132 matches
Mail list logo
