Hi Zhichao,
Thank you very much, I am just trying to make sure things don't slip through
the cracks.
Cheers,
Tom
From: Gao, Zhichao
Sent: 29 May 2020 01:31
To: Tomas Pilar ; devel@edk2.groups.io; Ni, Ray
Cc: nd
Subject: RE: AcpiView Patches
Sorry, Pilar. I am busy at other things. Plan to
Fixed the timeout error in SiI3132SoftResetCommand() function.
The timeout "SiI3132AtaPassThru() Err:Timeout" occurs when using "WD SSD
WDS100T2B0A 1TB", but doesn't occur when using "Intel SSD 530 Series 240GB".
Compared with the linux kernel driver, and found it has the status check during
> On Fri, May 29, 2020 at 05:21:24 +, Pankaj Bansal (OSS) wrote:
> > > > ---
> > >
> a/Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf
> > > > +++
> > >
> b/Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf
> > > > @@ -19,9 +19,12 @@
> > > >
On Fri, May 29, 2020 at 05:21:24 +, Pankaj Bansal (OSS) wrote:
> > > ---
> > a/Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf
> > > +++
> > b/Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf
> > > @@ -19,9 +19,12 @@
> > >ArmPkg/ArmPkg.dec
> > >
On 05/29/20 05:06, Kinney, Michael D wrote:
> Hi Liming,
>
> There is a documentation only change to Readme files for the
> UnitTestFranmeworkPkg.
>
> https://edk2.groups.io/g/devel/message/60378
>
> Any objections to adding this update to the stable tag?
No objection from me.
Thanks
Laszlo
On 05/29/20 05:00, Gao, Liming wrote:
> Stewards and all:
> Leif requests two patches to catch this stable tag. They fix BZ
> https://bugzilla.tianocore.org/show_bug.cgi?id=2723. I see the point that the
> linux distribution default GCC version may be 10 or above. Without this fix,
> those
Hi Bob,
Thanks for the review.
Here is the original description of the issue.
There has been a build failure from SCT, related to
https://edk2.groups.io/g/devel/message/60407?p=,,,20,0,0,0::relevance,,gEfiFormBrowserExProtocolGuid,20,2,0,74529350.
(
Hi Tiger,
I believe you are assuming that IsaBusDxe and SioDxe do the same thing, that is
not the case. These two drivers are actually very different they do very
different things.
Consider a 15 year old PC. Most PC’s from that era had an ICH (the older
terminology for PCH) with both parallel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606
EccCheck.py is a tool to report Ecc issues for commits, which will
be run on open ci.
But note not each kind of issue could be reported out.
It can only handle the issues, whose line number in CSV report
accurately map with their code in
This is a sample for users to add exceptions and ignored files for
their own use.
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Shenglei Zhang
---
MdeModulePkg/MdeModulePkg.ci.yaml | 8
1 file changed, 8 insertions(+)
diff --git a/MdeModulePkg/MdeModulePkg.ci.yaml
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606
As planed we will enable Ecc check for edk2 on open ci. And they are
ready now, but these are V1 series. So I expect that contributors in
edk2 community can try using this script when reviewing. And I hope
receiving feedback and comments if
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606
Add a pipeline to run the ECC checks on Azure Pipelines agents
for edk2 open ci.
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
.azurepipelines/Windows-EccCheck.yml | 38
antlr4-python3-runtime is a lib to support Ecc run with Py3.x.
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
pip-requirements.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/pip-requirements.txt b/pip-requirements.txt
index
From: "Fan, Zhiju"
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2676
Because Ecc relies on the antlr extension package,
When the antlr version is updated, we need to change the code in it.
Currently, if you use the latest version antlr4.8, Ecc will fail
We will update the version to
On Fri, May 29, 2020 at 12:25:43 +, Pankaj Bansal (OSS) wrote:
> > > I intentionally kept these in this order. because Soc depends on Chassis
> > > for any
> > include files
> > > Chassis depends on NxpQoriqLs.dec for any include files.
> >
> > OK, I see the logic behind that, but as it has
The description of [Packages] sections stated that
"Packages must be listed in the order that may be required for specifying
include path statements for a compiler. For example, the
MdePkg/MdePkg.dec file must be listed before the
MdeModulePkg/MdeModulePkg.dec file."
Drop it.
Signed-off-by:
On Fri, May 29, 2020 at 14:43:43 +0200, Daniel Schaefer wrote:
> Hi Leif,
>
> thanks for this super careful review!
> Comments and one question inline.
>
> - Daniel
>
> On 5/20/20 8:27 PM, Leif Lindholm wrote:
> > On Fri, May 15, 2020 at 15:39:37 +0200, Daniel Schaefer wrote:
> > > Library
Ard:
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Ard Biesheuvel
> Sent: Friday, May 29, 2020 1:47 PM
> To: devel@edk2.groups.io; Gao, Liming ;
> ler...@redhat.com; Leif Lindholm
> Cc: phi...@redhat.com; mli...@suse.cz
> Subject: Re: [edk2-devel] [PATCH]
Hi Leif,
thanks for this super careful review!
Comments and one question inline.
- Daniel
On 5/20/20 8:27 PM, Leif Lindholm wrote:
On Fri, May 15, 2020 at 15:39:37 +0200, Daniel Schaefer wrote:
Library provides interfaces to invoke SBI extensions.
Signed-off-by: Daniel Schaefer
Cc: Abner
> -Original Message-
> From: Leif Lindholm [mailto:l...@nuviainc.com]
> Sent: Thursday, May 28, 2020 7:55 PM
> To: Chang, Abner (HPS SW/FW Technologist)
> Cc: Schaefer, Daniel (DualStudy) ;
> devel@edk2.groups.io; Chen, Gilbert ; Kinney,
> Michael D ; bret.barke...@microsoft.com;
>
On 5/29/20 4:29 PM, Gao, Liming wrote:
Ard:
-Original Message-
From: devel@edk2.groups.io On Behalf Of Ard Biesheuvel
Sent: Friday, May 29, 2020 1:47 PM
To: devel@edk2.groups.io; Gao, Liming ; ler...@redhat.com; Leif
Lindholm
Cc: phi...@redhat.com; mli...@suse.cz
Subject: Re:
+ Ray and Hao who are the MdeModulePkg/Bus/ maintainers
-Original Message-
From: Philippe Mathieu-Daudé
Sent: Thursday, May 28, 2020 1:28 AM
To: devel@edk2.groups.io; tiger...@zhaoxin.com; Agyeman, Prince
Subject: Re: [edk2-devel] IsaBus driver's usage
+Agyeman Prince
On 5/28/20
Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: Bret Barkelew
> Sent: Friday, May 29, 2020 10:34 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ;
> Bret Barkelew
> Subject: [PATCH v2 1/1] UnitTestFrameworkPkg: Add info
> to readme about working with UnitTests
>
Cc: Michael D Kinney
Cc: Bret Barkelew
Signed-off-by: Bret Barkelew
---
Notes:
v2:
- Update the SpellCheck YAML to incude GitHub handles in the dictionary
.pytool/Readme.md | 125 +++-
UnitTestFrameworkPkg/ReadMe.md|
Library provides interfaces to invoke SBI ecalls.
Signed-off-by: Daniel Schaefer
Cc: Leif Lindholm
Cc: Gilbert Chen
Cc: Abner Chang
Cc: Michael D Kinney
---
Silicon/RISC-V/ProcessorPkg/Library/RiscVEdk2SbiLib/RiscVEdk2SbiLib.inf | 28 +
EDK2 RISC-V OpenSBI library which pull in external source files under
RISC-V/ProcessorPkg/Library/RiscVOpensbiLib/opensbi to the build process.
Signed-off-by: Abner Chang
Co-authored-by: Daniel Schaefer
Co-authored-by: Gilbert Chen
Reviewed-by: Leif Lindholm
Cc: Leif Lindholm
Cc: Gilbert
Hi Leif,
here's the new patchset addressing your latest comments.
The only thing that's not included is a deduplication of the SMBIOS code.
I expect that will require quite some thinking - I'm not yet sure how to do it.
I sent an answer to your reviews of the last comments, saying what I
Add submodule opensbi under
Silicon/RISC-V/ProcessorPkg/Library/RiscVOpensbLlib.
The current supported opensbi version for RISC-V edk2 port is tags/v0.6.
Signed-off-by: Daniel Schaefer
Reviewed-by: Leif Lindholm
Cc: Leif Lindholm
Cc: Abner Chang
Cc: Gilbert Chen
Cc: Michael D Kinney
---
The AMD Seattle based platforms have been kept up to date in recent
years, even though the hardware is obsolete and was never available
that widely in the first place.
However, one aspect that has sadly been left behind is the support for
the builtin network controllers. These are only wired up
29 matches
Mail list logo
