Re: [edk2-devel] A problem to build KabyLake

2020-08-12 Thread Canh Kha
Hi Nate, In this webpage https://github.com/intel/FSP/wiki The link to coreboot.git is broken http://review.coreboot.org/coreboot.git How can I integrate Amberlake FSP with coreboot? Is there a guide? Thanks, Canh On Wed, Jul 22, 2020 at 11:11 PM Canh Kha wrote: > Thank you, Nate. > Canh > >

[edk2-devel] [PATCH EDK2 v1 0/1] Enhanced verification of Offset(CVE-2019-14562)

2020-08-12 Thread wenyi,xie via groups.io
Main Changes: 1.check offset inbetween VirtualAddress and VirtualAddress + Size. 2.Using SafeintLib to do offset addition with result check. Code can also be found in github: https://github.com/leadsama/edk2.git branch: bug-2215-v1 Wenyi Xie (1): SecurityPkg/DxeImageVerificationLib:Enhanced

[edk2-devel] [PATCH EDK2 v1 1/1] SecurityPkg/DxeImageVerificationLib:Enhanced verification of Offset(CVE-2019-14562)

2020-08-12 Thread wenyi,xie via groups.io
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2215 There is an integer overflow vulnerability in DxeImageVerificationHandler function when parsing the PE files attribute certificate table. In cases where WinCertificate->dwLength is sufficiently large, it's possible to overflow Offset back to

Re: [edk2-devel] [PATCH] Add a stub CONTRIBUTING.md pointing to the wiki

2020-08-12 Thread Laszlo Ersek
On 08/12/20 00:51, Cole Robinson wrote: > On 8/11/20 5:55 PM, Laszlo Ersek wrote: >> On 08/11/20 20:09, Cole Robinson wrote: >>> Googling for 'edk2 pull request' did not find this wiki page: >>> >>> https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process >>> >>> Add it to

Re: [edk2-devel] [PATCH v5 0/5] Use RngLib instead of TimerLib for OpensslLib

2020-08-12 Thread Laszlo Ersek
On 08/12/20 09:54, Ard Biesheuvel wrote: > On 8/12/20 4:21 AM, matthewfcarl...@gmail.com wrote: >> From: Matthew Carlson >> >> Hello all, >> >> This patch contains a fix for Bugzilla 1871. > > Thanks Matthew. This looks a lot better. > > Given that it was me who reported 1871 in the first

Re: [edk2-devel] [PATCH v5 4/5] ArmVirtPkg: Add RngLib based on TimerLib for CryptoPkg

2020-08-12 Thread Laszlo Ersek
Hi Matthew, On 08/12/20 04:21, matthewfcarl...@gmail.com wrote: > From: Matthew Carlson > > Updates the DSC for the ArmVirtPkg platform to add a RngLib that uses the > TimerLib. This is due to a later change that adds TimerLib as a dependency > for OpenSSL. The TimerLib based RngLib mimics the

Re: [edk2-devel] [PATCH v4 3/5] OvmfPkg: Add RngLib based on TimerLib for Crypto

2020-08-12 Thread Laszlo Ersek
(+Rebecca) On 08/12/20 04:27, macarl via [] wrote: > Thank you for the helpful comments Lazlo! > > I sent out an updated series (v5) that fixes the things you mentioned. I > added more description, so hopefully that helps. > > Sorry I didn't notice BhyvePkg, I thought you couldn't have

Re: [edk2-devel] [PATCH v5 3/5] OvmfPkg: Add RngLib based on TimerLib for Crypto

2020-08-12 Thread Laszlo Ersek
On 08/12/20 04:21, matthewfcarl...@gmail.com wrote: > From: Matthew Carlson > > Updates the DSC's for Ovmf based platforms to add a RngLib that uses the > TimerLib. This is due to a later change that adds TimerLib as a dependency > for OpenSSL. The TimerLib based RngLib mimics the behavior of

Re: [edk2-devel] [PATCH V2 0/3] MdeModulePkg/PartitionDxe: Make the parition driver match the spec

2020-08-12 Thread Laszlo Ersek
On 08/12/20 08:26, Gary Lin wrote: > On Wed, Aug 12, 2020 at 09:21:21AM +0800, Zhichao Gao wrote: >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2823 >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2843 >> >> Refer to the UEFI spec 2.8, Section 13.3.2: >> A block device should be

回覆: [edk2-devel] Propose on enabling TLSv1.3

2020-08-12 Thread Huang, Matthew (HPS SW)
Hi Zhiguang: Please refer to the attached ‘tlsv13.patch’ based on tianocore/edk2@be01087e07. As I mentioned, ‘process_files.pl’ is processed with ActivePerl 5.28 Build (64-bit) and MSYS2 MinGW 64-bit, log is attached as ‘process_openssl.txt’. The problems are still the same, current

Re: [edk2-devel] [PATCH V2 2/3] MdeModulePkg/PartitionDxe: Revert changes for the special MBR

2020-08-12 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io On Behalf Of Gao, > Zhichao > Sent: Wednesday, August 12, 2020 9:21 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A > ; Ni, Ray ; Gary Lin > ; Andrew Fish > Subject: [edk2-devel] [PATCH V2 2/3] MdeModulePkg/PartitionDxe:

Re: [edk2-devel] [PATCH V2 2/3] MdeModulePkg/PartitionDxe: Revert changes for the special MBR

2020-08-12 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io On Behalf Of Gao, > Zhichao > Sent: Wednesday, August 12, 2020 9:21 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A > ; Ni, Ray ; Gary Lin > ; Andrew Fish > Subject: [edk2-devel] [PATCH V2 2/3] MdeModulePkg/PartitionDxe:

Re: [edk2-devel] [PATCH v5 0/5] Use RngLib instead of TimerLib for OpensslLib

2020-08-12 Thread Ard Biesheuvel
On 8/12/20 4:21 AM, matthewfcarl...@gmail.com wrote: From: Matthew Carlson Hello all, This patch contains a fix for Bugzilla 1871. Thanks Matthew. This looks a lot better. Given that it was me who reported 1871 in the first place, could you resend this series and put me on cc on all of

[edk2-devel] [Patch] BaseTools: Move CreateAsBuiltInf into AutoGenWorker for parallel

2020-08-12 Thread Bob Feng
AsBuiltInf can be created during AutoGen phase. Move CreateAsBuiltInf into AutoGenWorker to make this step run in parallel. Signed-off-by: Bob Feng Cc: Liming Gao Cc: Yuwei Chen --- BaseTools/Source/Python/AutoGen/AutoGenWorker.py | 2 +- BaseTools/Source/Python/build/build.py | 4

[edk2-devel] [PATCH v1 1/1] IntelSiliconPkg/ShadowMicrocodePei: Add PCD for shadowing all microcode.

2020-08-12 Thread Aaron Li
This patch is to add a PCD PcdShadowAllMicrocode to support shadowing all microcode patch to memory. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2891 Signed-off-by: Aaron Li Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Siyuan Fu ---

[edk2-devel] [edk2-wiki][PATCH v3] Update the Boot Guard TOCTOU wiki page.

2020-08-12 Thread Guomin Jiang
The Boot Guard TOCTOU have been migrated into edk2/master. Update the document to meet the change. Signed-off-by: Guomin Jiang Cc: Jian J Wang Cc: Liming Gao --- Boot-Guard-TOCTOU-Vulnerability-Mitigation.md | 30 +++ 1 file changed, 10 insertions(+), 20 deletions(-) diff

Re: [edk2-devel] [PATCH V2 0/3] MdeModulePkg/PartitionDxe: Make the parition driver match the spec

2020-08-12 Thread Gary Lin
On Wed, Aug 12, 2020 at 09:21:21AM +0800, Zhichao Gao wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2823 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2843 > > Refer to the UEFI spec 2.8, Section 13.3.2: > A block device should be scanned as below order: > 1. GPT > 2. ISO

Re: [edk2-devel] [PATCH 1/1] CryptoPkg/Library: Remove the redundant build option

2020-08-12 Thread Guomin Jiang
Pushed in commit be01087e07809d20aa2db27b37029c324c824407. Thanks Guomin > -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo > Ersek > Sent: Friday, July 17, 2020 5:39 PM > To: Abner Chang ; devel@edk2.groups.io > Cc: Wang, Jian J ; Lu, XiaoyuX > > Subject: Re:

Re: [edk2-devel] [PATCH V2 3/3] MdeModulePkg/PartitionDxe: Fix the incorrect LBA size in child hander

2020-08-12 Thread Wu, Hao A
> -Original Message- > From: Gao, Zhichao > Sent: Wednesday, August 12, 2020 9:21 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A > ; Ni, Ray ; Gary Lin > ; Andrew Fish > Subject: [PATCH V2 3/3] MdeModulePkg/PartitionDxe: Fix the incorrect LBA > size in child hander > >

Re: [edk2-devel] [PATCH V2 1/3] MdeModulePkg/PartitionDxe: Put the UDF check ahead of MBR

2020-08-12 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io On Behalf Of Gao, > Zhichao > Sent: Wednesday, August 12, 2020 9:21 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A > ; Ni, Ray ; Gary Lin > ; Andrew Fish > Subject: [edk2-devel] [PATCH V2 1/3] MdeModulePkg/PartitionDxe: Put

Re: [edk2-devel] [PATCH v1 1/1] FmpDevicePkg/FmpDxe: Fix Clang build error

2020-08-12 Thread Guomin Jiang
Reviewed-by: Guomin Jiang Thanks Guomin > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Wednesday, August 12, 2020 8:24 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Kinney, Michael D > ; Jiang, Guomin ; > Xu, Wei6 > Subject: [edk2-devel]

Re: [edk2-devel] [PATCH] MdeModulePkg/UsbBusDxe: some USB PenDisk fails enumeration.

2020-08-12 Thread Guomin Jiang
Hi Libo, I review the USB Spec 2.0 and have some confusion when check the spec as below: From the USB 2.0 spec: Section 5.5.3 Control Transfer Packet Size Constraints ... In order to determine the maximum packet size for the Default Control Pipe, the USB System Software reads the device

Re: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: fix variable services conformance test

2020-08-12 Thread Heinrich Schuchardt
On 8/4/20 1:13 PM, Samer El-Haj-Mahmoud wrote: > Reviewed-by: Samer El-Haj-Mahmoud Dear Edhaya, could you, please, consider these patches https://edk2.groups.io/g/devel/message/63354 https://edk2.groups.io/g/devel/message/52599 for review and merging. Best regards Heinrich

Re: [edk2-devel] [PATCH EDK2 v1 1/1] SecurityPkg/DxeImageVerificationLib:Enhanced verification of Offset(CVE-2019-14562)

2020-08-12 Thread Laszlo Ersek
On 08/12/20 09:04, wenyi,xie via groups.io wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2215 > > There is an integer overflow vulnerability in DxeImageVerificationHandler > function when parsing the PE files attribute certificate table. In cases > where WinCertificate->dwLength is

Re: [edk2-devel] [PATCH edk2-platforms 3/3] Silicon/NXP: Add Support for git commit info print

2020-08-12 Thread Leif Lindholm
Hi Pankaj, Apologies for slow response - having a bit of a heatwave and no AC... On Sat, Aug 08, 2020 at 02:39:32 +, Pankaj Bansal (OSS) wrote: > > I will note here that you are adding identical content to two > > different ChassisLib implementations. > > > > This is a strong indicator that

Re: [edk2-devel] [PATCH edk2-test 1/1] SctPkg: fix page alignment calculations

2020-08-12 Thread G Edhaya Chandran
Upstreamed by Commit-ID: 93f402cfacc25a4fd422172e879024210c2ddc5b -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#64070): https://edk2.groups.io/g/devel/message/64070 Mute This Topic: https://groups.io/mt/75299798/21656 Group Owner:

[edk2-devel] UefiPayloadPkg: Slimboot assign PCIe resource above 4GB. but not supported in UEFIPayload

2020-08-12 Thread Andrey V
Hi I've encountered a problem after using the patch from SBL (slimboot) https://github.com/slimbootloader/slimbootloader/pull/809 The SBL supports resource allocation above the 4GB, but it fails on ASSERT [PciHostBridgeDxe]

Re: [edk2-devel] [PATCH v14 00/46] SEV-ES guest support

2020-08-12 Thread Liming Gao
Tom: -Original Message- From: devel@edk2.groups.io On Behalf Of Lendacky, Thomas Sent: 2020年8月12日 0:18 To: Laszlo Ersek ; Gao, Liming ; devel@edk2.groups.io Cc: Brijesh Singh ; Ard Biesheuvel ; Dong, Eric ; Justen, Jordan L ; Kinney, Michael D ; Ni, Ray ; Andrew Fish ; Anthony Perard

Re: [edk2-devel] [PATCH v14 00/46] SEV-ES guest support

2020-08-12 Thread Liming Gao
Tom: I understand your point. Now, I run this script on Windows OS. I don't try it on Linux agent. You can upload new patch set to your fork branch. I will verify it and let your know the result. And, I plan to merge ECC checker this week. So, more patches can be verified. Thanks Liming

Re: [edk2-devel] [Patch] BaseTools: Move CreateAsBuiltInf into AutoGenWorker for parallel

2020-08-12 Thread Liming Gao
I like this idea. Is there any build performance improvement? > -Original Message- > From: Feng, Bob C > Sent: Wednesday, August 12, 2020 2:09 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Chen, Christine > Subject: [Patch] BaseTools: Move CreateAsBuiltInf into AutoGenWorker for >

Re: [edk2-devel] [PATCH v14 00/46] SEV-ES guest support

2020-08-12 Thread Lendacky, Thomas
Hi Liming, So I'm not sure what the next step is then... Since the ECC checker isn't merged yet, are you saying that I should submit the series again with the changes and that you won't be running the stand-alone tool again? Or will you run the tool again and submit more issues to resolve if the

[edk2-devel] [PATCH v1 21/30] DynamicTablesPkg: AML Codegen

2020-08-12 Thread Sami Mujawar
From: Pierre Gondois AML Codegen is a Dynamic AML technique that facilitates generation of small segments of AML code. The AML code generated using AML Codegen is represented as nodes in the AML Tree. Some examples where AML Codegen can be used are: - AML Codegen APIs can be used to generate a

[edk2-devel] [PATCH v1 28/30] DynamicTablesPkg: SSDT Serial Port generator

2020-08-12 Thread Sami Mujawar
From: Pierre Gondois Most platforms have several serial ports. These serial ports are described to an operating system using definition block tables. The SSDT Serial Port Table Generator uses the Configuration Manager protocol to obtain information for the Serial Ports on the platform. The

[edk2-devel] [PATCH v1 16/30] DynamicTablesPkg: AML Parser

2020-08-12 Thread Sami Mujawar
From: Pierre Gondois Both ASL and AML are declarative language. The ASL code is compiled to AML bytecode. The AML bytecode is processed by the ACPI AML interpreter that runs as part of an OS. AML has a complex encoding making dynamic generation of Definition Block tables difficult. Dynamic AML

[edk2-devel] [PATCH v1 22/30] DynamicTablesPkg: AML Resource Data Codegen

2020-08-12 Thread Sami Mujawar
From: Pierre Gondois AML Codegen is a Dynamic AML technique that facilitates generation of small segments of AML code. The AML code generated using AML Codegen is represented as nodes in the AML Tree. AML Resource Data Codegen implements interfaces required for generating Resource Data elements

[edk2-devel] [PATCH v1 25/30] DynamicTablesPkg: Dynamic AML: Add AmlLib library

2020-08-12 Thread Sami Mujawar
From: Pierre Gondois ACPI Definition blocks are implemented using AML which has a complex grammar making run-time generation of definition blocks difficult. Dynamic AML is a feature of Dynamic Tables framework that provides a solution for dynamic generation of ACPI Definition block tables.

[edk2-devel] [PATCH V1] MdePkg/Include/Guid/Cper.h: CXL Protocol Error

2020-08-12 Thread Javeed, Ashraf
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2884 Added new approved ECR for the CXL Protocol Error Section. Signed-off-by: Ashraf Javeed Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu -- --- MdePkg/Include/Guid/Cper.h | 75

[edk2-devel] [PATCH v1 23/30] DynamicTablesPkg: AML Core interface

2020-08-12 Thread Sami Mujawar
From: Pierre Gondois AML Core interface APIs are internal APIs of the AmlLib library. These APIs can be used to: - Create/Delete/Clone an AML tree/node - Get/update Fixed and Variable arguments - Serialize an AML tree. Signed-off-by: Pierre Gondois Signed-off-by: Sami Mujawar ---

[edk2-devel] [PATCH v1 14/30] DynamicTablesPkg: AML debug logging

2020-08-12 Thread Sami Mujawar
From: Pierre Gondois The AML debug print functions enable logging of the operations on the AML tree and the data output. The debug logging functionality is enabled for debug builds when the DEBUG_INFO or DEBUG_VERBOSE mask is enabled in the PCD gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel

[edk2-devel] [PATCH v1 30/30] DynamicTablesPkg: Add SSDT Serial port for DBG2

2020-08-12 Thread Sami Mujawar
From: Pierre Gondois The SSDT Serial port fixup library provides interfaces to generate a SSDT Serial port table based on the serial port information. Update the DBG2 Generator to use the SSDT serial port fixup library to build a serial port definition block for the DBG2 serial port and install

[edk2-devel] [PATCH v1 18/30] DynamicTablesPkg: AML resource data parser

2020-08-12 Thread Sami Mujawar
From: Pierre Gondois Resource data are defined in the ACPI 6.3 specification, s6.4 "Resource Data Types for ACPI". They can be created using the ASL ResourceTemplate () statement, cf s19.3.3 "ASL Resource Templates". Resource data can be of the small or large type and are defined by their

[edk2-devel] [PATCH v1 26/30] DynamicTablesPkg: Add AsciiFromHex helper function

2020-08-12 Thread Sami Mujawar
AsciiFromHex is a function converts a hex number to an ASCII character. This function is used across multiple generators, so add it to the TableHelperLib. Signed-off-by: Pierre Gondois Signed-off-by: Sami Mujawar --- DynamicTablesPkg/Include/Library/TableHelperLib.h| 15 +-

[edk2-devel] [PATCH v1 17/30] DynamicTablesPkg: AML resource data helper

2020-08-12 Thread Sami Mujawar
From: Pierre Gondois Resource data are defined in the ACPI 6.3 specification, s6.4 "Resource Data Types for ACPI". They can be created using the ASL ResourceTemplate () statement, cf s19.3.3 "ASL Resource Templates". Resource data can be of the small or large type and are defined by their

[edk2-devel] [PATCH v1 11/30] DynamicTablesPkg: AML and ASL string helper

2020-08-12 Thread Sami Mujawar
From: Pierre Gondois Dynamic AML requires encoding/decoding and conversion of AML and ASL strings. A collection of helper functions have been provided for internal use in the AmlLib Library. Signed-off-by: Pierre Gondois Signed-off-by: Sami Mujawar ---

[edk2-devel] [PATCH v1 15/30] DynamicTablesPkg: AML ACPI Namespace interface

2020-08-12 Thread Sami Mujawar
From: Pierre Gondois AML is a declarative language that is processed by the ACPI AML interpreter. The ACPI AML interpreter will compile the set of declarations into the ACPI Namespace at definition block load time. The hardware information described in AML is effectively mapped in the ACPI

[edk2-devel] [PATCH v1 27/30] DynamicTablesPkg: SSDT Serial Port Fixup library

2020-08-12 Thread Sami Mujawar
From: Pierre Gondois According to Arm Server Base Boot Requirements, Platform Design Document version 1.2 revision D, September 2, 2019, section '4.2.1.8 SPCR'; The SPCR console device must be included in the DSDT. Additionally, it is often desirable to describe the serial ports available on a

[edk2-devel] [PATCH v1 29/30] DynamicTablesPkg: Add SSDT Serial port for SPCR

2020-08-12 Thread Sami Mujawar
From: Pierre Gondois According to Arm Server Base Boot Requirements, Platform Design Document version 1.2 revision D, September 2, 2019, section '4.2.1.8 SPCR'; the SPCR console device must be included in the DSDT. The SSDT Serial port fixup library provides interfaces to generate a SSDT Serial

[edk2-devel] [PATCH v1 20/30] DynamicTablesPkg: AML Field list parser

2020-08-12 Thread Sami Mujawar
From: Pierre Gondois The AML language allows defining field lists in a Definition Block. Although Dynamic AML does not provide interfaces to modify Field Lists; an AML template code may contain Field lists and the AML parser must be capable of parsing and representing the Field lists in the AML

[edk2-devel] [PATCH v1 24/30] DynamicTablesPkg: AmlLib APIs

2020-08-12 Thread Sami Mujawar
From: Pierre Gondois AmlLib library implements an AML parser, AML tree interface, serialiser, code generator and other interfaces to generate Definition Block tables. The AmlLib APIs are a collection of interfaces that enable parsing, iterating, modifying, adding, and serialising AML data to

[edk2-devel] [PATCH v1 19/30] DynamicTablesPkg: AML Method parser

2020-08-12 Thread Sami Mujawar
From: Pierre Gondois The AML language allows a Definition Block to implement methods that an Operating System can invoke at runtime. Although Dynamic AML does not provide interfaces to modify AML methods; an AML template code may contain methods and/or method invocations. Method definitions

[edk2-devel] [PATCH v1 01/30] DynamicTablesPkg: Introduction to Dynamic AML

2020-08-12 Thread Sami Mujawar
ACPI Definition block (e.g. DSDT or SSDT) tables are implemented using ACPI source language (ASL) and compiled to ACPI Machine language (AML). The AML bytecode runs in the OS ACPI Interpreter. AML has a complex grammar which makes generation of ACPI Definition block tables difficult. Dynamic

[edk2-devel] [PATCH v1 10/30] DynamicTablesPkg: AML utility interfaces

2020-08-12 Thread Sami Mujawar
From: Pierre Gondois The AML utility interfaces are a collection of helper functions that assist in computing the checksum, size and to propagate the node information as a result of addition or update of AML nodes. Signed-off-by: Pierre Gondois Signed-off-by: Sami Mujawar ---

[edk2-devel] [PATCH v1 08/30] DynamicTablesPkg: AML tree iterator

2020-08-12 Thread Sami Mujawar
From: Pierre Gondois The AML tree iterator provides interfaces to traverse the nodes in the AML tree. The iterator can traverse the AML tree nodes in the following order: - Linear progression: Iterate following the AML byte stream order (depth first). - Branch

[edk2-devel] [PATCH v1 00/30] Add Dynamic AML generation support

2020-08-12 Thread Sami Mujawar
ACPI tables are categorised as Data tables (e.g. MADT, GTDT, etc.) or Definition Block tables (DSDT or SSDT). The Dynamic Tables Framework already supports generation of Data tables. Definition Block tables are written in ACPI Source Language (ASL) and compiled to ACPI Machine Language (AML). This

[edk2-devel] [PATCH v1 03/30] DynamicTablesPkg: AML grammar definition

2020-08-12 Thread Sami Mujawar
From: Pierre Gondois ASL is a source language for defining ACPI objects including writing ACPI control methods. An ASL file is compiled using an ASL compiler tool to generate ACPI Machine Language (AML). This AML bytecode is processed by the ACPI AML interpreter that runs as part of an Operating

[edk2-devel] [PATCH v1 07/30] DynamicTablesPkg: AML tree traversal

2020-08-12 Thread Sami Mujawar
From: Pierre Gondois The AML tree traversal provides interfaces to traverse the nodes in the AML tree. It provides interfaces to traverse the AML tree in the following order: - Traverse sibling nodes. (Node)/-i # Child of fixed argument b \/ |-

[edk2-devel] [PATCH v1 09/30] DynamicTablesPkg: AML tree/node cloning

2020-08-12 Thread Sami Mujawar
From: Pierre Gondois It is often desirable to clone an AML branch/tree or an AML node. An example of could be to clone an AML template before fixup so that the original AML template remains unmodified. Another example would be replicating a device branch in the AML tree and fixing up the device

[edk2-devel] [PATCH v1 06/30] DynamicTablesPkg: AML tree enumerator

2020-08-12 Thread Sami Mujawar
From: Pierre Gondois The AML tree enumerator interface allows enumeration of the nodes in the AML tree. The enumerator interface can be useful to search, serialise, print etc. the nodes in the AML tree. Signed-off-by: Pierre Gondois Signed-off-by: Sami Mujawar ---

[edk2-devel] [PATCH v1 05/30] DynamicTablesPkg: AML tree interface

2020-08-12 Thread Sami Mujawar
From: Pierre Gondois The AML tree is composite and has the following node types: - Root node. - Object node. - Data node. These nodes are part of the Fixed Arguments or the Variable arguments list in the AML tree. The AML tree interface provides functions to manage the fixed and the

[edk2-devel] [PATCH v1 02/30] DynamicTablesPkg: AmlLib definitions

2020-08-12 Thread Sami Mujawar
From: Pierre Gondois Dynamic AML is a solution to generate Definition Block tables at runtime. Dynamic AML provides the following techniques for generating AML tables. - AML Fixup - AML Codegen - AML Fixup + Codegen AML fixup involves patching small sections of a template AML code at

[edk2-devel] [PATCH v1 13/30] DynamicTablesPkg: AML serialise interface

2020-08-12 Thread Sami Mujawar
From: Pierre Gondois AML Fixup and AML Codegen facilitate dynamic generation of Definition Block tables. The AML byte stream that is generated is represented in an AML tree. Once the AML table generation is completed, the AML tree needs to be serialised for installing as an ACPI table. The AML

[edk2-devel] [PATCH v1 12/30] DynamicTablesPkg: AML stream interface

2020-08-12 Thread Sami Mujawar
Dynamic AML involves parsing/packing of AML opcode and data into AML byte streams. The AML stream interface provides safe buffer management as well as supports forward and reverse streams. It provides functions to create, read, write, clone and compare AML streams. Co-authored-by: Pierre Gondois

[edk2-devel] [PATCH v1 04/30] DynamicTablesPkg: AML node definitions

2020-08-12 Thread Sami Mujawar
From: Pierre Gondois AML has a complex grammar, and this makes runtime modifications on an AML byte stream difficult. A solution is to parse the AML bytecode and represent it in a tree data structure, henceforth called the AML tree. The AML tree is composite in the sense it has the following

Re: [edk2-devel] [PATCH v14 00/46] SEV-ES guest support

2020-08-12 Thread Lendacky, Thomas
Hi Liming, Thank you, the updated series can be found here: https://github.com/AMDESE/ovmf/tree/sev-es-v23 Thanks, Tom On 8/12/20 10:28 AM, Gao, Liming wrote: > Tom: > I understand your point. Now, I run this script on Windows OS. I don't try > it on Linux agent. You can upload new patch

Re: [edk2-devel] acpiview error handling patches

2020-08-12 Thread Sami Mujawar
Hi Zhichao, Thanks. I have logged this in Bugzilla "Bug 2893 - Acpiview: Standardise error log output format" (https://bugzilla.tianocore.org/show_bug.cgi?id=2893). Regards, Sami Mujawar -Original Message- From: Gao, Zhichao Sent: 12 August 2020 01:41 AM To: Sami Mujawar ;

Re: [edk2-devel] [edk2-platform][PATCH v1 7/7] Platforms/RaspberryPi: SMBIOS minor cleanup

2020-08-12 Thread Pete Batard
From what I could see, Andrei already sent a R-b for 1-6, thus: On 2020.07.20 19:16, Samer El-Haj-Mahmoud wrote: Minor code cleanup: - Update file header to list SBBR required/recommended tables - Rename DataSmbiosHande to DataSmbiosHandle - Remove SMBIOS_HANDLE_PI_RESERVED from Type 11

Re: [edk2-devel] [PATCH v14 00/46] SEV-ES guest support

2020-08-12 Thread Liming Gao
Tom: I run the standalone ECC checker. sev-es-v23 version pass ECC checker. There is no ecc issue any more. Thanks Liming > -Original Message- > From: devel@edk2.groups.io On Behalf Of Lendacky, > Thomas > Sent: Wednesday, August 12, 2020 11:49 PM > To: Gao, Liming ;

Re: [edk2-devel] [PATCH] Add a stub CONTRIBUTING.md pointing to the wiki

2020-08-12 Thread Cole
On 8/12/20 5:37 AM, Laszlo Ersek wrote: > On 08/12/20 00:51, Cole Robinson wrote: >> On 8/11/20 5:55 PM, Laszlo Ersek wrote: >>> On 08/11/20 20:09, Cole Robinson wrote: Googling for 'edk2 pull request' did not find this wiki page:

Re: [edk2-devel] [PATCH v14 00/46] SEV-ES guest support

2020-08-12 Thread Lendacky, Thomas
Thank you Liming, I'll send out v15 within the next day or so. Thanks, Tom On 8/12/20 11:50 AM, Gao, Liming wrote: > Tom: > I run the standalone ECC checker. sev-es-v23 version pass ECC checker. > There is no ecc issue any more. > > Thanks > Liming >> -Original Message- >> From:

Re: [edk2-devel] [PATCH V2 3/3] MdeModulePkg/PartitionDxe: Fix the incorrect LBA size in child hander

2020-08-12 Thread Gao, Zhichao
For additional info, I have test patch #3 without #1 and #2, and revert "MdeModulePkg/PartitionDxe: Skip the MBR that add for CD-ROM". The CD's FAT can be observed with MBR path and I can load the EFI application successfully. But the behavior is different as I mention in patch #1 commit

Re: [edk2-devel] [PATCH V1] MdePkg/Include/Guid/Cper.h: CXL Protocol Error

2020-08-12 Thread Michael D Kinney
This code is a work in progress that implements a UEFI specification that is not finished and is not ready for publication. > -Original Message- > From: Javeed, Ashraf > Sent: Wednesday, August 12, 2020 8:33 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Liu,

Re: [edk2-devel] [PATCH] MdeModulePkg/UsbBusDxe: some USB PenDisk fails enumeration.

2020-08-12 Thread Feng Libo
Hello, Mr. Jiang, Most USB PenDisk work fine with the original enumeration sequence. A few can't. In Microsoft Post, they explained the cause : In the early days of USB some USB devices would become confused by a second request for the Device Descriptor if they did not return the complete

Re: [edk2-devel] [Patch] BaseTools: Move CreateAsBuiltInf into AutoGenWorker for parallel

2020-08-12 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: devel@edk2.groups.io On Behalf Of Bob > Feng > Sent: Tuesday, August 11, 2020 11:09 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Chen, Christine > > Subject: [edk2-devel] [Patch] BaseTools: Move CreateAsBuiltInf into >

Re: [edk2-devel] [PATCH 1/2] BaseTools: fix ucs-2 lookup on python 3.9

2020-08-12 Thread Yuwei Chen
Reviewed-by: Yuwei Chen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Cole > Sent: Wednesday, August 12, 2020 1:28 AM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > ; Cole Robinson > Subject: [edk2-devel] [PATCH 1/2] BaseTools: fix ucs-2 lookup on python

Re: [edk2-devel] [PATCH 2/2] BaseTools: Work around array.array.tostring() removal in python 3.9

2020-08-12 Thread Yuwei Chen
Reviewed-by: Yuwei Chen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Cole > Sent: Wednesday, August 12, 2020 1:28 AM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > ; Cole Robinson > Subject: [edk2-devel] [PATCH 2/2] BaseTools: Work around >

[edk2-devel] [PATCH 0/1] CryptoPkg/BaseCryptLib: Add EVP (Envelope) Digest interface

2020-08-12 Thread Zurcher, Christopher J
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2545 Low-level interfaces to message digest (hash) functions have been deprecated in OpenSSL 3. In order to upgrade to OpenSSL 3, all direct calls to low-level functions (such as SHA256_Init() in CryptSha256.c) will need to be replaced by EVP

[edk2-devel] [PATCH 1/1] CryptoPkg/BaseCryptLib: Add EVP (Envelope) Digest interface

2020-08-12 Thread Zurcher, Christopher J
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2545 The EVP interface should be used in place of discrete digest function calls. Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Signed-off-by: Christopher J Zurcher --- CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf| 1 +

Re: [edk2-devel] [PATCH v5 4/5] ArmVirtPkg: Add RngLib based on TimerLib for CryptoPkg

2020-08-12 Thread Matthew Carlson via groups.io
You are correct, I'll fix it in v6 -- - Matthew Carlson -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#64122): https://edk2.groups.io/g/devel/message/64122 Mute This Topic: https://groups.io/mt/76140306/21656 Group Owner:

Re: [edk2-devel] [PATCH v5 3/5] OvmfPkg: Add RngLib based on TimerLib for Crypto

2020-08-12 Thread Matthew Carlson via groups.io
I'll fix this for v6. Good spot. -- - Matthew Carlson -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#64121): https://edk2.groups.io/g/devel/message/64121 Mute This Topic: https://groups.io/mt/76140305/21656 Group Owner:

Re: [edk2-devel] [PATCH v5 0/5] Use RngLib instead of TimerLib for OpensslLib

2020-08-12 Thread Matthew Carlson via groups.io
Will do. -- - Matthew Carlson -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#64123): https://edk2.groups.io/g/devel/message/64123 Mute This Topic: https://groups.io/mt/76140302/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

[edk2-devel] [PATCH v6 1/5] MdePkg: TimerRngLib: Added RngLib that uses TimerLib

2020-08-12 Thread Matthew Carlson
From: Matthew Carlson Added a new RngLib that provides random numbers from the TimerLib using the performance counter. This is meant to be used for OpenSSL to replicate past behavior. This should not be used in production as a real source of entropy. Ref:

[edk2-devel] [PATCH v6 4/5] ArmVirtPkg: Add RngLib based on TimerLib for CryptoPkg

2020-08-12 Thread Matthew Carlson
From: Matthew Carlson Updates the DSC for the ArmVirtPkg platform to add a RngLib that uses the TimerLib. This is due to a later change that adds TimerLib as a dependency for OpenSSL. The TimerLib based RngLib mimics the behavior of OpenSSL previously and it is recommended to switch to a better

[edk2-devel] [PATCH v6 3/5] OvmfPkg: Add RngLib based on TimerLib for Crypto

2020-08-12 Thread Matthew Carlson
From: Matthew Carlson Updates the DSC's for Ovmf based platforms to add a RngLib that uses the TimerLib. This is due to a later change that adds TimerLib as a dependency for OpenSSL. The TimerLib based RngLib mimics the behavior of OpenSSL previously and it is recommended to switch to a better

[edk2-devel] [PATCH v6 0/5] Use RngLib instead of TimerLib for OpensslLib

2020-08-12 Thread Matthew Carlson
From: Matthew Carlson Hello all, This patch contains a fix for Bugzilla 1871. There's been a good bit of community discussion around the topic, so below follows a general overview of the discussion and what this patch does. Back in Devel message#40590

[edk2-devel] [PATCH v6 2/5] MdePkg: BaseRngLibDxe: Add RngLib that uses RngDxe

2020-08-12 Thread Matthew Carlson
From: Matthew Carlson This adds a RngLib that uses the RngProtocol to provide randomness. This means that the RngLib is meant to be used with DXE_DRIVERS. Ref: https://github.com/tianocore/edk2/pull/845 Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1871 Cc: Ard Biesheuvel Cc: Michael D

[edk2-devel] [PATCH v6 5/5] CryptoPkg: OpensslLib: Use RngLib to generate entropy in rand_pool

2020-08-12 Thread Matthew Carlson
From: Matthew Carlson Ref: https://github.com/tianocore/edk2/pull/845 Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1871 Changes OpenSSL to no longer depend on TimerLib and instead use RngLib. This allows platforms to decide for themsevles what sort of entropy source they provide to

Re: [edk2-devel] [PATCH] Add a stub CONTRIBUTING.md pointing to the wiki

2020-08-12 Thread Laszlo Ersek
On 08/12/20 18:00, Cole Robinson wrote: > On 8/12/20 5:37 AM, Laszlo Ersek wrote: >> On 08/12/20 00:51, Cole Robinson wrote: >>> On 8/11/20 5:55 PM, Laszlo Ersek wrote: On 08/11/20 20:09, Cole Robinson wrote: > Googling for 'edk2 pull request' did not find this wiki page: > >

Re: [EXTERNAL] [edk2-devel] [PATCH v4] UefiCpuPkg/MtrrLib/UnitTest: Add host based unit test

2020-08-12 Thread Laszlo Ersek
On 08/12/20 16:22, Ni, Ray wrote: > Sorry I somehow pushed the > https://github.com/niruiyu/edk2/commit/a1ca847e0a4f7f679d8c28c31d55c84f304d7a87 > together with this patch to upstream master. (That's probably commit 65904cdbb33c ("UefiCpuPkg/MtrrLibUnitTest: Change to use static array for CI

Re: [edk2-devel] UefiPayloadPkg: Slimboot assign PCIe resource above 4GB. but not supported in UEFIPayload

2020-08-12 Thread Laszlo Ersek
CC'ing Maurice, Guo, Benjamin Thanks Laszlo On 08/12/20 16:22, Andrey V wrote: > Hi > > I've encountered a problem after using the patch from SBL (slimboot) > https://github.com/slimbootloader/slimbootloader/pull/809 > The SBL supports resource allocation above the 4GB, but it fails on ASSERT