[edk2-devel] [PATCH v2 0/1] Fix CET shadow stack token busy bit clear issue

If CET shadows stack feature enabled in SMM and stack switch is enabled. When code execute from SMM handler to SMM exception, CPU will check SMM exception shadow stack token busy bit if it is cleared or not. If it is set, it will trigger #DF exception. If it is not set, CPU will set the busy bit

[edk2-devel] [PATCH v2 1/1] UefiCpuPkg/CpuExceptionHandlerLib: Clear CET shadow stack token busy bit

If CET shadows stack feature enabled in SMM and stack switch is enabled. When code execute from SMM handler to SMM exception, CPU will check SMM exception shadow stack token busy bit if it is cleared or not. If it is set, it will trigger #DF exception. If it is not set, CPU will set the busy bit

Re: [edk2-devel] [PATCH v2 1/1] UefiCpuPkg/CpuExceptionHandlerLib: Clear CET shadow stack token busy bit

Would you please add comment on why we need reserve and program the 8 bytes here? Something like: // // The highest address on the stack (0xFF8) is a save-previous-ssp token pointing to a location that is 40 bytes away - 0xFD0. // The supervisor shadow stack token is just above it at address

Re: [edk2-devel] ARM ltd. platform maintainership

Hi Sami, On Thu, Feb 4, 2021 at 5:19 PM Sami Mujawar wrote: > I can take up the maintenance for these packages. > > Please let me know if you want me to send a patch to update the maintainership. That would be much appreciated, thank you. While I'm obviously always happy to be cc:d on patches,

Re: [edk2-devel] reg: iPxe Boot in NetworkPkg

On 05/02/2021 08:28, Sivaraman Nainar wrote: Hello Maciej: I met an issue when tried to do the PXE boot with keeping the ipxe.efi as boot file. When iPXE.efi is set as boot file once it downloaded it again starts, it does the download and start of iPXE continuously and at some point it

Re: [edk2-devel] [PATCH 2/2] UefiCpuPkg/CpuExceptionHandlerLib: Clear CET shadow stack token busy bit

Hi Jiewen, Eric, Ray, Rahul, Ersek, I have updated the patch v2. And all comments are fixed. Since open CI is using NASM 2.14.02, it has not supported CET instructions yet. I would like to use DB xx xx xx xx to replace the assembly instruction before NASM 2.15.01 is used by open CI. Could you

Re: [edk2-devel] How can I receive EAP packets?

You may check the Ip4Dxe as example. > 在 2021年2月5日，15:16，梁宇飞 写道： > > Do you have any examples or documentation of using MNP? > > Best regards > Yufei liang > -邮件原件- > 发件人: 梁宇飞 [mailto:yufei.li...@jumple.com] > 发送时间: 2021年2月5日 8:48 > 收件人: 'Fu, Siyuan'; 'Laszlo Ersek';

[edk2-devel] reg: iPxe Boot in NetworkPkg

Hello Maciej: I met an issue when tried to do the PXE boot with keeping the ipxe.efi as boot file. When iPXE.efi is set as boot file once it downloaded it again starts, it does the download and start of iPXE continuously and at some point it asserts in MNP Driver. When it trying to access

Re: [edk2-devel] [Bug 3187] FaultTolerantWriteDxe defect will cause NVRAM not recovered after number of WorkSpaceRefresh().

After checking Bugzilla 3187, NVRAM already corrupted in this case. Sorry that I didn’t aware. From: devel@edk2.groups.io On Behalf Of Keysound Chang via groups.io Sent: Friday, February 5, 2021 11:03 AM To: devel@edk2.groups.io; marlboro.chu...@dell.com; gaoliming Subject: Re: [edk2-devel]

Re: [edk2-devel] [PATCH v1 01/27] ArmPkg: Fix Ecc error 8001 in Chipset

Hi Pierre, On Thu, Jan 21, 2021 at 01:51 AM, PierreGondois wrote: > > -#ifndef __ARM_CORTEX_A5x_H__ > -#define __ARM_CORTEX_A5x_H__ > +#ifndef ARM_CORTEX_A5X_H__ > +#define ARM_CORTEX_A5X_H__ There should be a single trailing underscore for #include guards. See

Re: [edk2-devel] [PATCH v1 02/27] ArmPkg: Fix Ecc error 8001 in SemihostLib

Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71358): https://edk2.groups.io/g/devel/message/71358 Mute This Topic: https://groups.io/mt/8372/21656 Group

Re: [edk2-devel] [PATCH v1 03/27] ArmPkg: Fix Ecc error 8001 in Chipset

On Thu, Jan 21, 2021 at 01:51 AM, PierreGondois wrote: > > diff --git a/ArmPkg/Include/Chipset/ArmCortexA5x.h > b/ArmPkg/Include/Chipset/ArmCortexA5x.h > index 2661ed8c0182..2cce9f7e2bbb 100644 > --- a/ArmPkg/Include/Chipset/ArmCortexA5x.h > +++ b/ArmPkg/Include/Chipset/ArmCortexA5x.h > @@ -1,6

Re: [edk2-devel] [PATCH v1 04/27] ArmPkg: Fix Ecc error 8001 in ArmArchTimerLib

Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71360): https://edk2.groups.io/g/devel/message/71360 Mute This Topic:

Re: [edk2-devel] [PATCH v2 1/3] MdePkg/Nasm.inc: add macros for C types used in structure definition

On 02/05/21 08:58, Ni, Ray wrote: > Signed-off-by: Ray Ni > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > --- > MdePkg/Include/Ia32/Nasm.inc | 38 > MdePkg/Include/X64/Nasm.inc | 38 > 2 files changed, 76

Re: [edk2-devel] EDK2

[AMD Official Use Only - Internal Distribution Only] 0x9d is one of those pesky "smart quotes" many applications love to use. These are the double quote or single quote characters that slant left and right instead of the straight up and down like the ASCII versions. They can be very hard to

Re: [edk2-devel] [PATCH v2 3/3] UefiCpuPkg/MpInitLib: Use XADD to avoid lock acquire/release

On 02/05/21 08:58, Ni, Ray wrote: > When AP firstly wakes up, MpFuncs.nasm contains below logic to assign > an unique ApIndex to each AP according to who comes first: > ---NASM--- > movedi, esi > addedi, MP_CPU_EXCHANGE_INFO_FIELD (Lock) > moveax, NotVacantFlag

Re: [edk2-devel] [PATCH v6 7/9] OvmfPkg/CpuHotplugSmm: add CpuEject()

Hi Ankur, I figure it's prudent for me to follow up here too: On 02/04/21 03:49, Ankur Arora wrote: > On 2021-02-03 12:58 p.m., Laszlo Ersek wrote: >> On 02/03/21 07:45, Ankur Arora wrote: >>> On 2021-02-02 6:15 a.m., Laszlo Ersek wrote: On 02/02/21 15:00, Laszlo Ersek wrote: > ...

Re: [edk2-devel] [PATCH v1 05/27] ArmPkg: Fix Ecc error 9005 in CpuDxe

Hi Pierre, This patch looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71361): https://edk2.groups.io/g/devel/message/71361 Mute This Topic:

Re: [edk2-devel] [PATCH v2 2/3] UefiCpuPkg/MpInitLib: Use NASM struc to avoid hardcode offset

On 02/05/21 08:58, Ni, Ray wrote: > In Windows environment, "dumpbin /disasm" is used to verify the > disassembly before and after using NASM struc doesn't change. > > Signed-off-by: Ray Ni > Cc: Eric Dong > Cc: Laszlo Ersek > Cc: Rahul Kumar > --- >

Re: [edk2-devel] [PATCH 2/2] UefiCpuPkg/CpuExceptionHandlerLib: Clear CET shadow stack token busy bit

On 02/05/21 10:35, Sheng, W wrote: > Hi Jiewen, Eric, Ray, Rahul, Ersek, > I have updated the patch v2. And all comments are fixed. > Since open CI is using NASM 2.14.02, it has not supported CET instructions > yet. > I would like to use DB xx xx xx xx to replace the assembly instruction before

Re: [edk2-devel] EDK2

One I know the file path, I usually use a Notepad++ feature: Search-> Find Chars In Range-> Non ASCII Mike From: Kirkendall, Garrett Sent: Friday, February 5, 2021 7:11 AM To: devel@edk2.groups.io; Feng, Bob C ; Kinney, Michael D ; Andrew Fish Cc: Pham, Tony Q Subject: RE:

Re: [edk2-devel] [PATCH v2 0/3] Use XADD to avoid lock acquire/release

Hi Ray, I really like the cleanup to remove hard coded offsets, but I think that change should be its own patch series. Can we make the functional change to use XADD as its own patch series before the change to remove hard coded offsets and use struct? Then have a 2nd patch series that is a

Re: [edk2-devel] [Patch V3 40/40] Maintainers.txt: Add TigerlakeSiliconPkg maintainers

The series has been pushed as d55602c~..ee33d4f Thanks Again Heng! > -Original Message- > From: Luo, Heng > Sent: Thursday, February 4, 2021 11:41 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L > Subject: [Patch V3 40/40] Maintainers.txt: Add

Re: [edk2-devel] [PATCH v2 0/3] Use XADD to avoid lock acquire/release

Mike, The clean up doesn’t cause any final instruction change and I have verified that. The reason I put the fix in last because the Lock field is not needed with the fix but removing the Lock requires to adjust all the hard code offsets. What potential issue do you see? Thanks, Ray thanks,

Re: [edk2-devel] [PATCH] UefiPayloadPkg/PlatformBootManager: Connect console after EndOfDxe

Trusted console is required for TCG Physical Presence and only trusted console could be connected before EndOfDxe. Since TCG Physical Presence is not enabled yet in the UefiPayloadPkg, I think it is ok to have this change. Reviewed-by: Guo Dong > -Original Message- > From: Patrick

Re: [edk2-devel] EDK2

> On Feb 4, 2021, at 7:30 PM, Kinney, Michael D > wrote: > > Hi Andrew, > > If the character is part of the code (not a comment), the ignoring the codec > error could silently produce the incorrect FW behavior. > > I prefer a failure with a correct

Re: [edk2-devel] TianoCore Community Meeting Minutes - 2/4

Hi Bret, Please share the proposed adjustments. If we can use a well supported tool that allows us to remove the C parser from ECC, then I think that would be a big improvement. Mike From: devel@edk2.groups.io On Behalf Of Bret Barkelew via groups.io Sent: Friday, February 5, 2021 1:26 PM

Re: [edk2-devel] TianoCore Community Meeting Minutes - 2/4

Hi Mike, I'm planning to put up a branch that we can use as a reference for a conversation around uncrustify in the next couple of weeks. Thanks, Michael On 2/5/2021 2:44 PM, Michael D Kinney wrote: Hi Bret, Please share the proposed adjustments.If we can use a well supported tool that

Re: [edk2-devel] TianoCore Community Meeting Minutes - 2/4

@Desimone, Nathaniel L, I’m interested in mentorship for the GSC project. Would like to talk offline about potential projects and past experience. RE: ECC, we’re internally evaluating ‘uncrustify’ as an option to 1) check for formatting violations and 2)

Re: [edk2-devel] [PATCH] Maintainers.txt: Update Maintainers and reviewers for UefiPayloadPkg

Reviewed-by: Maurice Ma Regards Maurice > -Original Message- > From: Guo Dong > Sent: Sunday, January 24, 2021 9:59 > To: devel@edk2.groups.io > Cc: Ma, Maurice ; You, Benjamin > ; philipp.deppenwi...@9elements.com; Kinney, > Michael D > Subject: [edk2-devel] [PATCH] Maintainers.txt:

Re: [edk2-devel] [Patch V3 40/40] Maintainers.txt: Add TigerlakeSiliconPkg maintainers

Thanks Heng for all the hard work! And thank you Nate for pushing the series. -Original Message- From: Desimone, Nathaniel L Sent: Friday, February 05, 2021 10:37 AM To: Luo, Heng ; devel@edk2.groups.io Cc: Chaganty, Rangasai V Subject: RE: [Patch V3 40/40] Maintainers.txt: Add

Re: [edk2-devel] [PATCH v2 2/2] Maintainers.txt: Change Jordan Justen to a reviewer for OvmfPkg

On Thu, 4 Feb 2021 at 20:49, Jordan Justen wrote: > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Signed-off-by: Jordan Justen Acked-by: Ard Biesheuvel > --- > Maintainers.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Maintainers.txt b/Maintainers.txt > index

Re: [edk2-devel] [PATCH v2 0/3] Use XADD to avoid lock acquire/release

My comment is only to make the history of changes easier to understand by separating the functional and non-functional changes. Mike From: Ni, Ray Sent: Friday, February 5, 2021 10:38 AM To: Kinney, Michael D ; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH v2 0/3] Use XADD to avoid

Re: [edk2-devel] EDK2

I found a couple of extensions for Visual Studio Code that will highlight bad characters. "Highlight Dodgy Characters" seems to do the trick. Sorry about that AMD Official Use Only thing. The wonders of modern email apps! Garrett Kirkendall SMTS Firmware Engineer 7171 Southwest Parkway,

Re: [edk2-devel] [PATCH v2 0/3] Use XADD to avoid lock acquire/release

I see. Will send a V3. From: Kinney, Michael D Sent: Saturday, February 6, 2021 3:54 AM To: Ni, Ray ; devel@edk2.groups.io; Kinney, Michael D Subject: RE: [edk2-devel] [PATCH v2 0/3] Use XADD to avoid lock acquire/release My comment is only to make the history of changes easier to understand

Re: [edk2-devel] [Bug 3187] FaultTolerantWriteDxe defect will cause NVRAM not recovered after number of WorkSpaceRefresh().

HI Keysound and all, Sorry for not giving the statement well. This is my first post so I was not aware of the message not complete on bugzilla. Current issue is observed with below condition. * Assume NVStorage = 0x5E000 and WorkSpace = 0x2000. The total working space is 0x6. *

[edk2-devel] [edk2-platforms][PATCH v1 2/3] MinPlatformPkg/MinPlatformPkg.dsc: Add basic MM_STANDALONE libraries

From: Michael Kubacki Adds a fundamental set of library instances that are needed to build MM_STANDALONE modules. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Michael Kubacki --- Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc | 7 +++ 1 file changed,

[edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add SpiFvbServiceStandaloneMm

From: Michael Kubacki Adds a new component called SpiFvbServiceStandaloneMm that serves as a Standalone MM compatible SPI FVB service driver. Note that a MM_STANDALONE version of SpiFlashCommonLib is being prepared to be sent but for the time being the module can be added to the MinPlatformPkg

[edk2-devel] [edk2-platforms][PATCH v1 3/3] MinPlatformPkg/SpiFvbService: Add Standalone MM support

From: Michael Kubacki Adds support for MM_STANDALONE. Retains the directory path to the SMM INF instance for backward compatibility with existing platforms. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Michael Kubacki ---

[edk2-devel] [edk2-platforms][PATCH v1 1/3] MinPlatformPkg/SpiFlashCommonLibNull: Make MODULE_TYPE BASE

From: Michael Kubacki This NULL library can be used to link against a MODULE_TYPE other than BASE and that would be useful as it is a NULL class instance. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Michael Kubacki ---

Re: [edk2-devel] [PATCH v1 0/1] Introduce DxeMmUnblockMemoryLib Interface

Hi Hao, My plan was to follow up with the driver changes regarding Tcg2Smm and VariableSmmRuntimeDxe once this interface is officially checked in. But if it is preferred to submit the patch for Tcg2Smm and VariableSmmRuntimeDxe to make better sense on how this interface will be consumed, I can