[edk2-devel] [edk2-platforms][PATCH V1 0/6] Platform/Sgi: Add initial support for RD-N2-Cfg1 platform

2021-05-19 Thread Pranav Madhu
RD-N2-Cfg1 platform is a variant of the RD-N2 platform. The platform is based on 8xMP1 Neoverse N2 CPUs, CMN-700 interconnect 3x3 mesh, multiple AXI expansion ports for I/O Coherent PCIe, Ethernet, offload and Arm Cortex-M7 for System Control Processor (SCP) and Manageability Control Processor

[edk2-devel] [edk2-platforms][PATCH V1 3/6] Platform/Sgi: Low Power Idle states for RD-N2-Cfg1

2021-05-19 Thread Pranav Madhu
RD-N2-Cfg1 platform supports 2 LPI states, LPI1 (Standby WFI) and LPI3 (Power-down) and the cluster supports LPI2 (Power-down) state. The LPI implementation also supports combined power state for core and cluster. Signed-off-by: Pranav Madhu --- Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1/Dsdt.asl

[edk2-devel] [edk2-platforms][PATCH V1 2/6] Platform/Sgi: ACPI PPTT table for RD-N2-Cfg1 platform

2021-05-19 Thread Pranav Madhu
The RD-N2-Cfg1 platform includes eight single-thread CPUS. Each of the CPUs include 64KB L1 Data cache, 64KB L1 Instruction cache and 1MB L2 cache. The platform also includes a system level cache of 8MB. Add PPTT table for RD-N2-Cfg1 platform with this information. Signed-off-by: Pranav Madhu

[edk2-devel] [edk2-platforms][PATCH V1 1/6] Platform/Sgi: Add initial support for RD-N2-Cfg1 platform

2021-05-19 Thread Pranav Madhu
From: Aditya Angadi Arm's RD-N2-Cfg1 platform is a variant of the RD-N2 platform. Compared to RD-N2 platform, RD-N2-Cfg1 has a reduced core count of eight Neoverse N2 CPUs and a smaller interconnect mesh. As part of the initial platform support for RD-N2-Cfg1 platform, add the corresponding ACPI

[edk2-devel] [edk2-platforms][PATCH V1 4/6] Platform/Sgi: ACPI CPPC support for RD-N2-Cfg1

2021-05-19 Thread Pranav Madhu
Enable ACPI CPPC mechanism for RD-N2-Cfg1 as defined by the ACPI specification. The implementation uses AMU registers accessible as Fixed-feature Hardware (FFixedHW) for monitoring the performance. Non-secure SCMI fastchannels are used to communicate with SCP to set the desired performance.

[edk2-devel] [edk2-platforms][PATCH V1 5/6] Platform/Sgi: Define RD-N2-Cfg1 platform id values

2021-05-19 Thread Pranav Madhu
Add the RD-N2-Cfg1 platform identification values including the part number and configuration number. This information will be used in populating the SMBIOS tables. Signed-off-by: Pranav Madhu --- Platform/ARM/SgiPkg/Include/SgiPlatform.h | 7 ++-

[edk2-devel] [edk2-platforms][PATCH V1 6/6] Platform/Sgi: Extend SMBIOS support for RD-N2-Cfg1

2021-05-19 Thread Pranav Madhu
Extend the SMBIOS support for RD-N2-Cfg1 platform. RD-N2-Cfg1 platform is a derivative of the RD-N2 platform and so most of the table values for RD-N2 platform is reused. Signed-off-by: Pranav Madhu --- Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type1SystemInformation.c| 7 +--

Re: [edk2-devel] [edk2-platforms][PATCH v2 01/35] CometlakeOpenBoardPkg: Remove redundant IntelSiliconPkg.dec entry

2021-05-19 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Wednesday, May 19, 2021 11:59 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Chaganty, Rangasai V > ; Kethi Reddy, Deepika > ; Esakkithevar, Kathappan > > Subject:

Re: [edk2-devel] [edk2-platforms][PATCH v2 20/35] CometlakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib

2021-05-19 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Wednesday, May 19, 2021 12:00 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Chaganty, Rangasai V > ; Kethi Reddy, Deepika > ; Esakkithevar, Kathappan > >

Re: [edk2-devel] [edk2-platforms][PATCH v2 33/35] KabylakeSiliconPkg: Remove PCH SPI PPI and Protocol from package

2021-05-19 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Wednesday, May 19, 2021 12:00 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Chaganty, Rangasai V > > Subject: [edk2-platforms][PATCH v2 33/35] KabylakeSiliconPkg: Remove PCH SPI > PPI and

Re: [edk2-devel] [edk2-platforms][PATCH v2 31/35] KabylakeOpenBoardPkg/PeiSerialPortLibSpiFlash: Add IntelSiliconPkg.dec

2021-05-19 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Wednesday, May 19, 2021 12:00 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > Subject: [edk2-platforms][PATCH v2 31/35] >

Re: [edk2-devel] [edk2-platforms][PATCH v2 30/35] MinPlatformPkg: Remove SpiFlashCommonLibNull

2021-05-19 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Wednesday, May 19, 2021 12:00 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Liming Gao ; > Dong, Eric > Subject: [edk2-platforms][PATCH v2 30/35] MinPlatformPkg:

Re: [edk2-devel] [edk2-platforms][PATCH v2 21/35] KabylakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib

2021-05-19 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Wednesday, May 19, 2021 12:00 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Jeremy Soller > Subject: [edk2-devel] [edk2-platforms][PATCH v2

Re: [edk2-devel] [edk2-platforms][PATCH v2 25/35] MinPlatformPkg: Remove SpiFvbService modules

2021-05-19 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Wednesday, May 19, 2021 12:00 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Liming Gao ; > Dong, Eric > Subject: [edk2-platforms][PATCH v2 25/35] MinPlatformPkg:

Re: [edk2-devel] [edk2-platforms][PATCH v2 03/35] CometlakeOpenBoardPkg/PeiPolicyUpdateLib: Add missing GUID to INF

2021-05-19 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Wednesday, May 19, 2021 11:59 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Chaganty, Rangasai V > ; Kethi Reddy, Deepika > ; Esakkithevar, Kathappan > > Subject:

Re: [edk2-devel] A plea for help

2021-05-19 Thread Bret Barkelew via groups.io
Have you tried the latest Python 3.x? - Bret From: Fowler, Eric (Mondo International, LLC) via groups.io Sent: Wednesday, May 19, 2021 12:41 AM To: devel@edk2.groups.io Subject: [EXTERNAL] [edk2-devel] A plea for help

Re: [edk2-devel] [edk2-platforms][PATCH v2 24/35] WhiskeylakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib

2021-05-19 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Wednesday, May 19, 2021 12:00 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > Subject: [edk2-platforms][PATCH v2 24/35] WhiskeylakeOpenBoardPkg: Update >

回复: [edk2-devel] [PATCH] BaseTools: Add -ffat-lto-objects option in GCC5 tool chain

2021-05-19 Thread gaoliming
Laszlo: Here is the discussion https://edk2.groups.io/g/devel/message/75299. Now, some uninitialized warning can't be detected on GCC5 tool chain, but can be detected on GCC49 tool chain. Edk2 CI only covers GCC5 tool chain. So, the merged code may impact GCC49 build. I add this option

Re: 回复: [edk2-devel] GSoC 2021 Qemu OpenBoardPkg Project

2021-05-19 Thread Daniel Schaefer
Hi, that sounds like a great project! I'm currently trying to create an equivalent of OvmfPkg for the RISCV64 generic QEMU virt machine. I don't like how much of my DSC and FDF file has modules that pretty much all platforms should have. MinPlatform would help reduce that, right? Is

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg: Cast UINT32 to UINT8 conversion in ReportCpuHobLib

2021-05-19 Thread Ni, Ray
Reviewed-by: Ray Ni Since it's a pure a build failure fix, I will merge it now. > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Wednesday, May 19, 2021 12:16 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Chaganty, Rangasai V > ; Chuang, SofiaX > Subject:

Re: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpu: Remove hardcode 48 address size limitation

2021-05-19 Thread Ni, Ray
> > My only point was that separate concerns should be implemented in > separate patches, or at least (if they are really difficult, or > overkill, to isolate) that they should be documented. > > Please try to think with your reviewers' mindsets in mind, when > preparing a patch (commit message

[edk2-devel] [PATCH 1/1] Update Home.md with the latest stable tag

2021-05-19 Thread Rebecca Cran
Update the home page to list the correct latest stable tag of edk2-stable202102. Signed-off-by: Rebecca Cran --- Home.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Home.md b/Home.md index cf165b06194b..9d067ffe97f9 100644 --- a/Home.md +++ b/Home.md @@ -1,6 +1,6 @@

Re: [edk2-devel] [PATCH v2 4/5] ArmVirtPkg: Introduce Cloud Hypervisor to edk2 family

2021-05-19 Thread Laszlo Ersek
On 05/17/21 08:50, Jianyong Wu wrote: > Cloud Hypervisor is kvm based VMM and is implemented in rust. Just like > other VMMs it need UEFI support to let ACPI work. That's why > Cloud Hypervisor is introduced here. > > Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc: (1) Empty CC? > Signed-off-by:

Re: [edk2-devel] [PATCH v2] IntelFsp2WrapperPkg: Remove microcode related PCDs

2021-05-19 Thread Jason Lou
Hi Chasel & Star, So far, the PCD usage has been removed from all of these platforms: 1. Server platforms("ServerGen2") 2. Client platforms("ClientMaster") 3. Edk2-platform opensource Thanks Jason Lou -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group.

Re: [edk2-devel] [PATCH v2 5/5] Maintainers: update Maintainers file as new files/folders created

2021-05-19 Thread Laszlo Ersek
Hi Sami, On 05/18/21 22:26, Sami Mujawar wrote: > Hi Jianyon, > > Thank you for including this patch in the series. There is a patch on > the mailing list to add me as a reviewer for ArmVirtPkg at package level. > Therefore, this patch would no longer be needed. Apologies for not > communicating

[edk2-devel] [PATCH v4 4/5] StandaloneMmPkg: fix pointer/int casts against 32bit architectures

2021-05-19 Thread Etienne Carriere
Use intermediate (UINTN) cast when casting int from/to pointer. This is needed as UINT64 values cast from/to 32bit pointer for 32bit architectures. Signed-off-by: Etienne Carriere Acked-by: Jiewen Yao Reviewed-by: Sami Mujawar --- Changes since v3: - Remove Cc tags and apply review tags. No

[edk2-devel] [PATCH v4 5/5] StandaloneMmPkg: build for 32bit arm machines

2021-05-19 Thread Etienne Carriere
This change allows to build StandaloneMmPkg components for 32bit Arm StandaloneMm firmware. This change mainly moves AArch64/ source files to Arm/ side directory for several components: StandaloneMmCpu, StandaloneMmCoreEntryPoint and StandaloneMmMemLib. The source file is built for both 32b and

[edk2-devel] [PATCH v4 1/5] ArmPkg/IndustryStandard: 32b/64b agnostic FF-A, Mm SVC and Std SMC IDs

2021-05-19 Thread Etienne Carriere
Defines ARM_SVC_ID_FFA_* and ARM_SVC_ID_SP_* identifiers for 32bit function IDs as per SMCCC specification. Defines also generic ARM SVC identifier macros to wrap 32bit or 64bit identifiers upon target built architecture. Signed-off-by: Etienne Carriere Reviewed-by: Sami Mujawar --- Changes

[edk2-devel] [PATCH v4 2/5] ArmPkg: prepare 32bit ARM build of StandaloneMmPkg

2021-05-19 Thread Etienne Carriere
Changes in ArmPkg to prepare building StandaloneMm firmware for 32bit Arm architectures. Adds MmCommunicationDxe driver and ArmMmuPeiLib and ArmmmuStandaloneMmLib libraries to the list of the standard components build for ArmPkg on when ARM architectures. Changes path of source file

[edk2-devel] [PATCH v4 3/5] GenFv: Arm: support images entered in Thumb mode

2021-05-19 Thread Etienne Carriere
Change GenFv for Arm architecture to generate a specific jump instruction as image entry instruction, when the target entry label is assembled with Thumb instruction set. This is possible since SecCoreEntryAddress value fetched from the PE32 has its LSBit set when the entry instruction executes in

Re: [edk2-devel] [PATCH] BaseTools: Add -ffat-lto-objects option in GCC5 tool chain

2021-05-19 Thread Laszlo Ersek
Hi Liming, On 05/19/21 04:27, gaoliming wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3403 > > This option can trig the uninitialized warning when lto is enabled. > The image size data is also collected for OVMF. There is no impact. > > Cc: Sergei Dmitrouk > Cc: Bob Feng > Cc:

Re: [edk2-devel] [PATCH v2 1/5] ArmVirtPkg: Library: Memory initialization for Cloud Hypervisor

2021-05-19 Thread Laszlo Ersek
On 05/17/21 08:50, Jianyong Wu wrote: > Cloud Hypervisor is kvm based VMM implemented in rust. > > This library populates the system memory map for the > Cloud Hypervisor virtual platform. > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Signed-off-by: Jianyong Wu > --- >

Re: [edk2-devel] [PATCH v3 5/5] StandaloneMmPkg: build for 32bit arm machines

2021-05-19 Thread Etienne Carriere
Hello Sami, Thanks for the catch. I missed that. My comment below. On Tue, 18 May 2021 at 13:07, Sami Mujawar wrote: > > Hi Etienne, > > Please find my response inline marked [SAMI]. > > Regards, > > Sami Mujawar > > On 17/05/2021 08:40 AM, Etienne Carriere wrote: > > This change allows to

Re: [edk2-devel] [PATCH v2 3/5] ArmVirtPkg: enable ACPI for cloud hypervisor

2021-05-19 Thread Laszlo Ersek
On 05/17/21 08:50, Jianyong Wu wrote: > The current implementation of PlatformHasAcpiDt is not a common > library and is on behalf of qemu. So give a specific version for > Cloud Hypervisor here. > > There is no device like Fw-cfg in qemu in Cloud Hypervisor, so a specific > Acpi handler is

Re: [edk2-devel] [PATCH v2] UefiCpuPkg/MpInitLib: Allocate a separate SEV-ES AP reset stack area

2021-05-19 Thread Laszlo Ersek
On 05/17/21 17:03, Lendacky, Thomas wrote: > On 5/16/21 11:22 PM, Laszlo Ersek wrote: >> But now, with SEV-ES enabled, we'll have a separate, discontiguous area >> -- and neither BackupAndPrepareWakeupBuffer(), nor its counterpart >> RestoreWakeupBuffer() take that into account. >> >> Therefore I

Re: [edk2-devel] [PATCH v2 1/5] ArmVirtPkg: Library: Memory initialization for Cloud Hypervisor

2021-05-19 Thread Laszlo Ersek
Sorry, just noticed: On 05/19/21 08:07, Laszlo Ersek wrote: > On 05/17/21 08:50, Jianyong Wu wrote: >> Cloud Hypervisor is kvm based VMM implemented in rust. >> >> This library populates the system memory map for the >> Cloud Hypervisor virtual platform. >> >> Cc: Laszlo Ersek >> Cc: Ard

Re: [edk2-devel] [PATCH v2 2/5] MdeMoudlePkg: introduce new PCD for Acpi/rsdp

2021-05-19 Thread Laszlo Ersek
On 05/17/21 08:50, Jianyong Wu wrote: > As there is lack of a machnism in Cloud Hypervisor to pass the base > address of Rsdp in Acpi, so a PCD varialbe is introduced here to > feed it. > > Cc: Hao A Wu > Cc: Jian J Wang > Signed-off-by: Jianyong Wu > --- > MdeModulePkg/MdeModulePkg.dec | 7

Re: [edk2-devel] [PATCH v2 5/5] Maintainers: update Maintainers file as new files/folders created

2021-05-19 Thread Laszlo Ersek
On 05/17/21 08:50, Jianyong Wu wrote: > Create new entry for Cloud Hypervisor and assign reviewer to Sami > Mujawar. > > Cc: Sami Mujawar > Signed-off-by: Jianyong Wu > --- > Maintainers.txt | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/Maintainers.txt b/Maintainers.txt >

[edk2-devel] A plea for help

2021-05-19 Thread Fowler, Eric (Mondo International, LLC) via groups.io
build.py... : error C0DE: Unknown fatal error when processing [c:\edk2020\district-defend\edk2\MdeModulePkg\Universal\Console\GraphicsConsoleDxe\GraphicsConsoleDxe.inf] (Please send email to devel@edk2.groups.io for help, attaching following call stack trace!) (Python 3.9.5 on win32) Traceback

Re: [edk2-devel] [PATCH v4 5/5] StandaloneMmPkg: build for 32bit arm machines

2021-05-19 Thread Sami Mujawar
Hi Etienn, This patch looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 19/05/2021 08:14 AM, Etienne Carriere wrote: This change allows to build StandaloneMmPkg components for 32bit Arm StandaloneMm firmware. This change mainly moves AArch64/ source files to Arm/ side

Re: [edk2-devel] [edk2-platforms][PATCH V3 00/11] Add SMBIOS tables for Arm's Reference Design platforms

2021-05-19 Thread Thomas Abraham
On 5/18/21 10:03 PM, Pranav Madhu via groups.io wrote: > Changes since V2: > - Addressed comments from Sami > - Picked up Sami's reviewed-by tags. > > Changes since V1: > - Rebase the patches on top of latest master branch > > SMBIOS provides basic hardware and firmware configuration information >

Re: [edk2-devel] [edk2-platforms][PATCH V1 0/6] Platform/Sgi: Add initial support for RD-N2-Cfg1 platform

2021-05-19 Thread Thomas Abraham
On 5/19/21 1:52 PM, Pranav Madhu via groups.io wrote: > RD-N2-Cfg1 platform is a variant of the RD-N2 platform. The platform > is based on 8xMP1 Neoverse N2 CPUs, CMN-700 interconnect 3x3 mesh, > multiple AXI expansion ports for I/O Coherent PCIe, Ethernet, offload > and Arm Cortex-M7 for System

[edk2-devel] [PATCH] Platform/ARM/Morello: Correct the private resources in PPTT

2021-05-19 Thread chandni cherukuri
As per ACPI specification, only the head of the list needs to be listed as a resources by a processore node, as cache node itself contains a link to the next level of cache. Signed-off-by: Chandni Cherukuri ---

Re: [edk2-devel] A plea for help

2021-05-19 Thread Hernandez Miramontes, Jose Miguel
So, the problem is here. File "C:\EDK2020\district-defend\edk2\BaseTools\Source\Python\Common\Misc.py", line 1638, in __init__ if ByteArray.tostring() != b'PE\0\0': see: https://docs.python.org/3/whatsnew/3.9.html array.array: tostring() and fromstring() methods have been removed. They were

[edk2-devel] [PATCH v1 1/1] EmbeddedPkg/libfdt: Add strmp and strncpy to libfdt_env.h

2021-05-19 Thread Daniel Schaefer
OpenSBI has started using those in v0.9. See: https://github.com/riscv/opensbi/blob/v0.9/lib/utils/fdt/fdt_domain.c Cc: Abner Chang Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Daniel Schaefer Cc: Anup Patel Signed-off-by: Daniel Schaefer --- EmbeddedPkg/Include/libfdt_env.h | 8 1

Re: [edk2-devel] [PATCH v1 1/1] EmbeddedPkg/libfdt: Add strmp and strncpy to libfdt_env.h

2021-05-19 Thread Abner Chang
Reviewed-by: Abner Chang > -Original Message- > From: Schaefer, Daniel > Sent: Wednesday, May 19, 2021 10:58 PM > To: devel@edk2.groups.io > Cc: Chang, Abner (HPS SW/FW Technologist) ; Leif > Lindholm ; Ard Biesheuvel ; > Anup Patel > Subject: [PATCH v1 1/1] EmbeddedPkg/libfdt: Add

Re: [edk2-devel] A plea for help

2021-05-19 Thread Bret Barkelew via groups.io
Yup, I was tired. Read the Python version all wrong. - Bret From: Hernandez Miramontes, Jose Miguel Sent: Wednesday, May 19, 2021 7:15:30 AM To: devel@edk2.groups.io ; Bret Barkelew ; fowler_e...@ne.bah.com Subject: [EXTERNAL] RE: [edk2-devel] A plea for help

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: build: Set ReturnCode on POSTBUILD fail

2021-05-19 Thread Kirkendall, Garrett
Any traction on this patch? Thank you Liming Gao for your quick response. GARRETT KIRKENDALL SMTS Firmware Engineer 7171 Southwest Parkway, Austin, TX 78735 USA AMD   facebook  |  amd.com > -Original Message- > From: gaoliming > Sent: Sunday, May 16, 2021 3:10 AM > To: Kirkendall,

Re: [edk2-devel] GSoC 2021 Qemu OpenBoardPkg Project

2021-05-19 Thread Oram, Isaac W
There is a variety of good basics for edk2 development starting at https://www.tianocore.org/. There is getting started and training things for basics. Getting started and how to contribute are key I think. They should have answers for your questions on development environment and such.

Re: 回复: [edk2-devel] GSoC 2021 Qemu OpenBoardPkg Project

2021-05-19 Thread Michael Kubacki
Thanks Liming. Hi Kaaira, Welcome! You can contact me at mikub...@linux.microsoft.com. You will sometimes see my email as michael.kuba...@microsoft.com and that is fine to use for communication though I tend to not use it on the mailing list due to way the mail server manipulates plaintext

[edk2-devel] [PATCH v3 01/13] MdePkg/Register/Amd: expand the SEV MSR to include the SNP definition

2021-05-19 Thread Brijesh Singh
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 Define the SEV-SNP MSR bits. Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc: Jordan Justen Cc: Ard Biesheuvel Cc: Laszlo Ersek Cc: Erdem Aktas Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Reviewed-by:

[edk2-devel] [PATCH v3 00/13] Add GHCBv2 macro and helpers

2021-05-19 Thread Brijesh Singh
This series is taken from the SNP RFC. This series defines the GHCBv2 macros and NAE events. Additionally, it also introduces a helper to clear the page encryption mask from the Mmio region. The series is based on the commit: 15ee7b76891a CryptoPkg/BaseCryptLib: Fix possible uninitialized use

[edk2-devel] [PATCH v3 02/13] MdePkg/Register/Amd: realign macros with more space for future expansion

2021-05-19 Thread Brijesh Singh
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 Version 2 of the GHCB spec introduces several new SNP-specific NAEs. Unfortunately, the names for those NAEs break the alignment. Add some white spaces so that the SNP support patches do not break the alignment. Cc: James Bottomley Cc: Min

[edk2-devel] [PATCH v3 05/13] MdePkg/Register/Amd: define GHCB macro for the Page State Change

2021-05-19 Thread Brijesh Singh
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 The Page State Change NAE exit will be used by the SEV-SNP guest to request a page state change using the GHCB protocol. See the GHCB spec section 4.1.6 and 2.3.1 for more detail on the structure definitions. Cc: James Bottomley Cc: Min Xu

[edk2-devel] [PATCH v3 03/13] MdePkg/Register/Amd: define GHCB macros for hypervisor feature detection

2021-05-19 Thread Brijesh Singh
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 Version 2 of GHCB introduces advertisement of features that are supported by the hypervisor. See the GHCB spec section 2.2 for an additional details. Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc: Jordan Justen Cc:

[edk2-devel] [PATCH v3 07/13] MdePkg/BaseLib: add support for PVALIDATE instruction

2021-05-19 Thread Brijesh Singh
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 The PVALIDATE instruction validates or rescinds validation of a guest page RMP entry. Upon completion, a return code is stored in EAX, rFLAGS bits OF, ZF, AF, PF and SF are set based on this return code. If the instruction completed

[edk2-devel] [PATCH v3 08/13] MdePkg/BaseLib: add support for RMPADJUST instruction

2021-05-19 Thread Brijesh Singh
From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 The RMPADJUST instruction will be used by the SEV-SNP guest to modify the RMP permissions for a guest page. See AMD APM volume 3 for further details. Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky

[edk2-devel] [PATCH v3 06/13] MdePkg/Register/Amd: define GHCB macros for SNP AP creation

2021-05-19 Thread Brijesh Singh
From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=33275 Version 2 of GHCB introduces NAE for creating AP when SEV-SNP is enabled in the guest VM. See the GHCB specification, Table 5 "List of Supported Non-Automatic Events" and sections 4.1.9 and 4.3.2, for further details.

[edk2-devel] [PATCH v3 11/13] OvmfPkg/QemuFlashFvbServicesRuntimeDxe: use Mmio helper to clear enc mask

2021-05-19 Thread Brijesh Singh
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 Use the MemEncryptSevClearMmioPageEncMask() to clear memory encryption mask for the Mmio address range. Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc: Jordan Justen Cc: Ard Biesheuvel Cc: Laszlo Ersek Cc: Erdem

[edk2-devel] [PATCH v3 09/13] OvmfPkg/BaseMemEncryptSevLib: introduce MemEncryptSevClearMmioPageEncMask()

2021-05-19 Thread Brijesh Singh
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 The MemEncryptSevClearMmioPageEncMask() helper can be used for clearing the memory encryption mask for the Mmio region. The MemEncryptSevClearMmioPageEncMask() is a simplified version of MemEncryptSevClearPageEncMask() -- it does not flush

[edk2-devel] [PATCH v3 12/13] OvmfPkg/TpmMmioSevDecryptPei: use MemEncryptSevClearMmioPageEncMask()

2021-05-19 Thread Brijesh Singh
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 Use the MemEncryptSevClearMmioPageEncMask() to clear memory encryption mask for the Mmio address range. Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc: Jordan Justen Cc: Ard Biesheuvel Cc: Laszlo Ersek Cc: Erdem

[edk2-devel] [PATCH v3 13/13] OvmfPkg/BaseMemEncryptSevLib: remove Flush parameter

2021-05-19 Thread Brijesh Singh
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 The Flush parameter is used to provide a hint whether the specified range is Mmio address. Now that we have a dedicated helper to clear the memory encryption mask for the Mmio address range, its safe to remove the Flush parameter from

[edk2-devel] [PATCH v3 10/13] OvmfPkg/AmdSevDxe: use MemEncryptSevClearMmioPageEncMask() to clear EncMask

2021-05-19 Thread Brijesh Singh
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 Use the MemEncryptSevClearMmioPageEncMask() to clear memory encryption mask for the Mmio and NonExistent address range. Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc: Jordan Justen Cc: Ard Biesheuvel Cc: Laszlo

[edk2-devel] [PATCH v3 04/13] MdePkg/Register/Amd: define GHCB macro for Register GPA structure

2021-05-19 Thread Brijesh Singh
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 An SEV-SNP guest is required to perform the GHCB GPA registration. See the GHCB specification for further details. Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc: Jordan Justen Cc: Ard Biesheuvel Cc: Laszlo Ersek

Re: 回复: [edk2-devel] GSoC 2021 Qemu OpenBoardPkg Project

2021-05-19 Thread Michael Kubacki
I also wanted to add that I will be setting up weekly video calls including Ray that we can use to supplement mailing list communication. I suggest the primary communication mechanism be the mailing list and we use those calls for clarification, detailed project planning, and topics not

Re: [edk2-devel] MinPlatform Board port (GSoC 2021)

2021-05-19 Thread Benjamin Doron
Hi all, My GSoC project proposal to work on a MinPlatform board port has been accepted, mentored by Nate DeSimone and Isaac Oram. Hopefully it will be an educational and enjoyable experience for me and a productive summer overall. Nate and I have already discussed the project briefly on here,

Re: [edk2-devel] MinPlatform Board port (GSoC 2021)

2021-05-19 Thread Oram, Isaac W
Benjamin, There was some discussion of FSP and MinPlatform resources on the mailing list today. I would check those out to augment your exploration. Especially note the MinPlatform porting training links. I would also make sure that you have the board information you need. Whatever

回复: [edk2-devel] A plea for help

2021-05-19 Thread gaoliming
This issue has been fixed in edk2 trunk. Can you try the latest edk2? Thanks Liming 发件人: devel@edk2.groups.io 代表 Bret Barkelew via groups.io 发送时间: 2021年5月20日 0:33 收件人: Hernandez Miramontes, Jose Miguel ; devel@edk2.groups.io; fowler_e...@ne.bah.com 主题: Re: [edk2-devel] A plea for help