Re: [edk2-devel] [PATCH v7] IntelFsp2WrapperPkg : FSPM/S UPD data address based on Build Type

Curious: It does not work to have one function implementation like below? UINTN EFIAPI GetFspmUpdDataAddress ( VOID ) { if (PcdGet64 (PcdFspmUpdDataAddress) != 0) { return (UINTN) PcdGet64 (PcdFspmUpdDataAddress64); } else { return (UINTN) PcdGet32 (PcdFspmUpdDataAddress); } }

Re: [edk2-devel] [PATCH V7 1/1] OvmfPkg: Enable TDX in ResetVector

Hi, > Thanks for reminder. I have updated the patch-set as you mentioned. > But I am waiting for a conclusion of the Metadata, a unified metadata > or two separate metadata. I still don't see the point in having two different tables for the same purpose. take care, Gerd

Re: [edk2-devel] RFC: Add BaseLib/QuickSort in MdePkg

In fact, my concern is that making BaseLib's APIs depend on PeiService & Boot Services is not good. For a instance, AP functions by MP service are not allowed to invoke any PeriServices and Boot Services. And exception handlers cannot invoke those services either. Jeff

Re: [edk2-devel] [edk2-discuss] a question about X509 flag

Hey Wenyi, Sorry, I cannot help with the time one, but "partial chain" is how virtually any other crypto-solution works out-of-the-box. Basically there is a disagreement about what defines a root certificate, and while some think it is the OpenSSL default of requiring a self-signed

Re: [edk2-devel] [PATCH V7 1/1] OvmfPkg: Enable TDX in ResetVector

Comment below: > -Original Message- > From: devel@edk2.groups.io On Behalf Of Gerd > Hoffmann > Sent: Monday, September 27, 2021 4:05 PM > To: Yao, Jiewen > Cc: devel@edk2.groups.io; Xu, Min M ; Brijesh Singh > ; Ard Biesheuvel ; > Justen, Jordan L ; Erdem Aktas > ; James Bottomley ;

Re: [edk2-devel] [PATCH v7] IntelFsp2WrapperPkg : FSPM/S UPD data address based on Build Type

If someone sets the PCD PcdFspmUpdDataAddress64 accidentally, it is better to be caught by some way but ignored. BTW, if the function GetFspmUpdDataAddress() is a internal function in the module, no EFIAPI is needed in the declaration. And, @Chiu, Chasel, is PcdFspmUpdDataAddress supposed to

Re: [edk2-devel] [PATCH v7] IntelFsp2WrapperPkg : FSPM/S UPD data address based on Build Type

Typo "ignored" to "not ignored". -Original Message- From: devel@edk2.groups.io On Behalf Of Zeng, Star Sent: 2021年9月27日 18:36 To: S, Ashraf Ali ; Chiu, Chasel ; devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Kuo, Ted ; Duggapu, Chinni B ; Chaganty, Rangasai V ; Solanki, Digant H ;

Re: [edk2-devel] [PATCH V8 3/3] OvmfPkg: Enable TDX in ResetVector

Hi, > +_Bfv: > + DD TDX_BFV_RAW_DATA_OFFSET > + DD TDX_BFV_RAW_DATA_SIZE > + DQ TDX_BFV_MEMORY_BASE > + DQ TDX_BFV_MEMORY_SIZE > + DD TDX_METADATA_SECTION_TYPE_BFV > + DD TDX_METADATA_ATTRIBUTES_EXTENDMR Size is still added twice, doesn't make sense given that they are either equal or

Re: [edk2-devel] [PATCH] UserAuthFeaturePkg/UserAuthenticationDxeSmm: The SMI to handle the user authentication should be unregister before booting to OS

Hi Hao, Some minor comments below. Please check inline. Thanks, Dandan > -Original Message- > From: Shi, Hao > Sent: Thursday, September 23, 2021 12:02 PM > To: devel@edk2.groups.io > Cc: Shi, Hao ; Bi, Dandan > Subject: [PATCH] UserAuthFeaturePkg/UserAuthenticationDxeSmm: The >

[edk2-devel] [PATCH V3] MdeModulePkg/BootManagerMenuApp: Limit string drawing within one line

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3590 Limit the draw box always within the screen's column and row. Limit the string drawing within one line. For the incompleted string the last 3 characters in one line would be replaced with "...". Cc: Jian J Wang Cc: Liming Gao Cc: Ray Ni

Re: [edk2-devel] [PATCH v1 06/10] DynamicTablesPkg: Add Configuration Manager Object parser

Hi Joey, Thanks for the review, I answered inline: On 9/24/21 9:56 AM, Joey Gouly wrote: > Hi, > > This looks good to me! > > [...] > >> + >> +/** A parser for EArmObjFixedFeatureFlags. >> +*/ >> +STATIC CONST CM_OBJ_PARSER CmArmFixedFeatureFlagsParser[] = { >> + {"Flags", 4, "0x%x", NULL} >>

Re: [edk2-devel] RFC: Add BaseLib/QuickSort in MdePkg

On 27/09/2021 10:50, fanjianf...@byosoft.com.cn wrote: For former caller, they could still keep as is to call the old API in MdeModulePkg. I think Ray's design is compatible change for existing code. Only when the existing code wants to remove the dependency on MdeModuelPkg, they could migrate

Re: [edk2-devel] [PATCH v7] IntelFsp2WrapperPkg : FSPM/S UPD data address based on Build Type

Hi., @Zeng, Star Creating a single function is doable, but the problem with that is If someone set the PCD PcdFspmUpdDataAddress64 accidentally which should be applicable only in X64. Since the PCD has some junk value, it will return the false data in IA32 case. Which will break everything

Re: [edk2-devel] RFC: Add BaseLib/QuickSort in MdePkg

On 27/09/2021 02:45, fanjianf...@byosoft.com.cn wrote: Making baselib implementation depend on MemoryAllocationLib (indirectly on Pei Service and gBS), it may prevent this base API using at some seneraio. i don't think it's better. That is why I asked about a split-API scenario, one of which

Re: [edk2-devel] RFC: Add BaseLib/QuickSort in MdePkg

For former caller, they could still keep as is to call the old API in MdeModulePkg. I think Ray's design is compatible change for existing code. Only when the existing code wants to remove the dependency on MdeModuelPkg, they could migrate to the new API in baselib. I agree with one split-API

[edk2-devel] [PATCH 1/1] SecurityPkg: Fix SecureBootDefaultKeysDxe failed to start

The dbt and dbx keys are optional, the driver entry should return EFI_SUCCESS to start if they are not found in the firmware flash. This patch is to fix it and update the description of retval as well. Cc: Jiewen Yao Cc: Jian J Wang Cc: Grzegorz Bernacki Signed-off-by: Nhi Pham ---

Re: [edk2-devel] [PATCH V7 1/1] OvmfPkg: Enable TDX in ResetVector

Hi, > > Possible alternative approach: Define an extension > > (EFI_FIRMWARE_VOLUME_EXT_HEADER) for the load address and use that > > instead of defining something new. > > [Jiewen] I would say it is terrible idea to use EFI_FIRMWARE_VOLUME_HEADER. > > [ ... details snipped ... ] Ok, lets

[edk2-devel] [PATCH 9/9] ArmVirtPkg/VirtioFdtDxe: Relocate VirtioFdtDxe to OvmfPkg/Fdt

Relocate VirtioFdtDxe to OvmfPkg/Fdt, this driver is leverage by both ARM and RISC-V archs. Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Daniel Schaefer Cc: Sunil V L ---

[edk2-devel] [PATCH 0/9] Migrate ArmVirtPkg modules to OvmfPkg

This pacthes set is to migrate some modules from ArmVirtPkg to under OvmfPkg for the upcoming RiscVVirtPkg that can leverage those modules without the dependency with Arm*Pkg. The modules moved from ArmVirtPkg to OvmfPkg are, - FdtClientDxe - PciPcdProducerLib - HighMemDxe - QemuFwCfgLib -

[edk2-devel] [PATCH 7/9] MdePkg: Add PcdPciMmio32(64)Translation PCDs

PcdPciMmio32Translation and PcdPciMmio64Translation PCDs are added to MdePkg as the common PCDs for ARM and RSIC-V archs. The one under ArmPkg is removed in the next patch. Signed-off-by: Abner Chang Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Ard Biesheuvel Cc: Leif Lindholm

[edk2-devel] [PATCH 5/9] ArmVirtPkg/HighMemDxe: Relocate HighMemDxe to OvmfPkg

Relocate HighMemDxe to OvmfPkg/Fdt, this library is leverage by both ARM and RISC-V archs. Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Daniel Schaefer Cc: Sunil V L ---

[edk2-devel] [edk2-platforms PATCH] SpcrFeaturePkg: Close event in callback routine.

Adds CloseEvent in callbackroutine OutOfBandACPITableConstruction(), To avoid multiple installation of SPCR table. Signed-off-by: Abdul Lateef Attar --- .../OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[edk2-devel] [PATCH 6/9] ArmVirtPkg/QemuFwCfgLib: Relocate QemuFwCfgLib to OvmfPkg

Relocate QemuFwCfgLib to OvmfPkg/Library/QemuFwCfgLib and rename it to QemuFwCfgLibMMIO, this library is leverage by both ARM and RISC-V archs. Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Daniel

[edk2-devel] [PATCH 4/9] ArmVirtPkg/FdtPciPcdProducerLib: Relocate PciPcdProducerLib to OvmfPkg

Relocate PciPcdProducerLib to OvmfPkg/Fdt, this library is leverage by both ARM and RISC-V archs. Add OvmfPkg/Fdt maintainers in Maintainers.txt Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Daniel

[edk2-devel] [PATCH 2/9] MdePkg: Add PcdPciIoTranslation PCD

This PCD is moved from ArmPkg that is used to set the base address of PCI MMIO window that provides I/O access. We relocate this PCD because this PCD is common to ARM and RSIC-V arch. Signed-off-by: Abner Chang Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Ard Biesheuvel Cc: Leif

[edk2-devel] [PATCH 8/9] ArmVirtPkg/FdtPciHostBridgeLib: Relocate FdtPciHostBridgeLib to OvmfPkg/Fdt

Relocate FdtPciHostBridgeLib to OvmfPkg/Fdt, this library is leverage by both ARM and RISC-V archs. Also use PcdPciMmio32Translation and PcdPciMmio64Translation PCDs provided by MdePkg instead of ArmPkg. Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Cc:

[edk2-devel] [PATCH 1/9] ArmVirtPkg/FdtClintDxe: Move FdtClientDxe to EmbeddedPkg

This is one of the series patches to restructure the location of modules under ArmVirtPkg for RiscVVirtPkg. RiscVVirtPkg leverage FDT Client protocol to parse FDT nodes. Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Cc: Gerd Hoffmann Cc: Daniel Schaefer

[edk2-devel] [PATCH 3/9] ArmPkg: Use PcdPciIoTranslation PCD from MdePkg

PcdPciIoTranslation PCD is relocated to MdePkg and leveraged by both ARM and RISC-V arch. This patch removes the one from ArmPkg and address the corresponding changes required for other modules under ArmVirtPkg. Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar

Re: [edk2-devel] [edk2-discuss] a question about X509 flag

On 2021/9/27 17:21, Marvin Häuser wrote: > Hey Wenyi, > > Sorry, I cannot help with the time one, but "partial chain" is how virtually > any other crypto-solution works out-of-the-box. Basically there is a > disagreement about what defines a root certificate, and while some think it > is

Re: [edk2-devel] [PATCH V7 1/1] OvmfPkg: Enable TDX in ResetVector

Hi, > > struct { > > uint64_t load_address; > > uint32_t file_offset; > > uint32_t section_size; > > uint32_t section_type; > > uint32_t section_flags; > > }; > > [Jiewen] This data structure does not work in a special use case - A > TD may want to have a fixed memory size.

Re: [edk2-devel] [edk2-platforms][PATCH v3 1/5] Platform/ARM: Add DMC-620 ECC error handling driver

Hi Omkar, Thank you for this patch. Please find my feedback marked inline as [SAMI]. Regards, Sami Mujawar On 24/08/2021 07:00 AM, Omkar Anand Kulkarni wrote: DMC-620 memory controller improves system reliability by generating interrupts on detecting ECC errors on the data. Add a initial

Re: [edk2-devel] [PATCH 1/9] ArmVirtPkg/FdtClintDxe: Move FdtClientDxe to EmbeddedPkg

On Mon, 27 Sept 2021 at 17:01, Abner Chang wrote: > > This is one of the series patches to restructure the location of modules under > ArmVirtPkg for RiscVVirtPkg. RiscVVirtPkg leverage FDT Client protocol to > parse FDT nodes. > > Signed-off-by: Abner Chang > Cc: Ard Biesheuvel > Cc: Leif

Re: [edk2-devel] [PATCH V7 1/1] OvmfPkg: Enable TDX in ResetVector

For size field, please refer to PE/COFF specification https://docs.microsoft.com/en-us/windows/win32/debug/pe-format The "Section Table (Section Headers)" defines two fields: === VirtualSize - The total size of the section when loaded into memory. If this value is greater

Re: [edk2-devel] [PATCH V8 3/3] OvmfPkg: Enable TDX in ResetVector

Hi, > > Can you move the metadata changes to a separate patch please? > Yes, the metadata changes will be in a separate patch in the next version. Can you also add a comment block documenting the format? Not only those parts which are used for TDVF, but everything? The description in

Re: [edk2-devel] [PATCH V3] MdeModulePkg/BootManagerMenuApp: Limit string drawing within one line

Hi Liming/Ray, I have updated the commit message and the BZ comments. Do you agree to merge the code? Thanks, Zhichao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Gao, > Zhichao > Sent: Monday, September 27, 2021 3:10 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J

回复: [edk2-devel] [PATCH V3] MdeModulePkg/BootManagerMenuApp: Limit string drawing within one line

I am ok for this change. Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Gao, Zhichao > 发送时间: 2021年9月28日 13:18 > 收件人: devel@edk2.groups.io; Gao, Zhichao > 抄送: Wang, Jian J ; Liming Gao > ; Ni, Ray > 主题: Re: [edk2-devel] [PATCH V3] MdeModulePkg/BootManagerMenuApp: >

回复: [edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 09/28/2021 #cal-reminder

Few new issues are submitted this week. I will cancel the meeting. 3654 EDK2 Code unassig...@tianocore.org UNCO Openssl native instructions for 32-bit Fri 17:32

回复: [edk2-devel] [PATCH V2 0/2] Add ProcessorUpgradeSocketLGA4677 from SMBIOS 3.5.0

Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Zeng, Star > 发送时间: 2021年9月28日 10:36 > 收件人: devel@edk2.groups.io > 抄送: Star Zeng > 主题: [edk2-devel] [PATCH V2 0/2] Add ProcessorUpgradeSocketLGA4677 > from SMBIOS 3.5.0 > > V2: Split patches for packages. > > Star Zeng

[edk2-devel] Cancelled Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, September 28, 2021 #cal-cancelled

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCELLED REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z

Re: [edk2-devel] RFC: Add BaseLib/QuickSort in MdePkg

Marvin, I agree with your concerns, in a certain level. But I didn't treat it as a very big problem of having caller pass the BufferOneElement "intelligently". I am ok to use your option 1), making BufferOneElement mandatory. Caller should always supply the buffer that's sufficient to hold one

Re: [edk2-devel] [PATCH] MdePkg,ShellPkg: Add ProcessorUpgradeSocketLGA4677 from SMBIOS 3.5.0

+ Maintainers and Reviewers -Original Message- From: devel@edk2.groups.io On Behalf Of Zeng, Star Sent: 2021年9月28日 10:04 To: devel@edk2.groups.io Cc: Zeng, Star Subject: [edk2-devel] [PATCH] MdePkg,ShellPkg: Add ProcessorUpgradeSocketLGA4677 from SMBIOS 3.5.0 This patch adds

Re: [edk2-devel] [`edk2-devel][PATCH] UefiPayloadPkg: Build a HOB from bootloader ACPI table

I prefer we still let caller to provide the HOB pointer. This also eliminates a global variable "mAcpiBoardInfo". You could change the BuildHobFromAcpi() to return the HOB pointer. So that the pointer can be directly passed to ParseMemoryInfo(). Thanks, Ray > -Original Message- > From:

[edk2-devel] [PATCH] UserAuthFeaturePkg/UserAuthenticationDxeSmm: The SMI to handle the user authentication should be unregister before booting to OS

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3648 Register SmmExitBootServices and SmmLegacyBoot callback function to unregister this handler. Signed-off-by: Hao Shi Cc: Dandan Bi Cc: Liming Gao --- .../UserAuthenticationSmm.c | 39 +--

[edk2-devel] [PATCH V2 0/2] Add ProcessorUpgradeSocketLGA4677 from SMBIOS 3.5.0

V2: Split patches for packages. Star Zeng (2): MdePkg: Add ProcessorUpgradeSocketLGA4677 from SMBIOS 3.5.0 ShellPkg: Support ProcessorUpgradeSocketLGA4677 from SMBIOS 3.5.0 MdePkg/Include/IndustryStandard/SmBios.h | 7 +-- .../SmbiosView/QueryTable.c|

[edk2-devel] [PATCH V2 1/2] MdePkg: Add ProcessorUpgradeSocketLGA4677 from SMBIOS 3.5.0

This patch adds ProcessorUpgradeSocketLGA4677 definition into Smbios.h from SMBIOS 3.5.0. It also adds ProcessorUpgradeSocketLGA4189 and ProcessorUpgradeSocketLGA1200 definitions into from SMBIOS 3.4.0. Signed-off-by: Star Zeng --- MdePkg/Include/IndustryStandard/SmBios.h | 7 +-- 1 file

[edk2-devel] [PATCH V2 2/2] ShellPkg: Support ProcessorUpgradeSocketLGA4677 from SMBIOS 3.5.0

This patch adds entry into QueryTable.c for ProcessorUpgradeSocketLGA4677 from SMBIOS 3.5.0. It also adds entries into QueryTable.c for ProcessorUpgradeSocketLGA4189 and ProcessorUpgradeSocketLGA1200 from SMBIOS 3.4.0. Signed-off-by: Star Zeng --- .../SmbiosView/QueryTable.c

Re: [edk2-devel] [PATCH 1/9] ArmVirtPkg/FdtClintDxe: Move FdtClientDxe to EmbeddedPkg

> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Ard Biesheuvel > Sent: Tuesday, September 28, 2021 4:27 AM > To: Chang, Abner (HPS SW/FW Technologist) > Cc: edk2-devel-groups-io ; Ard Biesheuvel > ; Leif Lindholm ; Sami > Mujawar ; Gerd

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 09/28/2021 #cal-reminder

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z

[edk2-devel] [PATCH] MdePkg,ShellPkg: Add ProcessorUpgradeSocketLGA4677 from SMBIOS 3.5.0

This patch adds ProcessorUpgradeSocketLGA4677 definition into Smbios.h from SMBIOS 3.5.0 and entry into QueryTable.c. It also adds ProcessorUpgradeSocketLGA4189 and ProcessorUpgradeSocketLGA1200 into from SMBIOS 3.4.0 and entries into QueryTable.c. Signed-off-by: Star Zeng ---

Re: [edk2-devel] [PATCH] MdePkg,ShellPkg: Add ProcessorUpgradeSocketLGA4677 from SMBIOS 3.5.0

Star, It might be better to split the patch to two patches. one is to change MdePkg adding the definitions. The other is to change ShellPkg consuming the definitions. > -Original Message- > From: Zeng, Star > Sent: Tuesday, September 28, 2021 10:11 AM > To: devel@edk2.groups.io; Zeng,

Re: [edk2-devel] [PATCH V8 3/3] OvmfPkg: Enable TDX in ResetVector

On September 27, 2021 4:43 PM, Gerd Hoffmann wrote: > Hi, > > > +_Bfv: > > + DD TDX_BFV_RAW_DATA_OFFSET > > + DD TDX_BFV_RAW_DATA_SIZE > > + DQ TDX_BFV_MEMORY_BASE > > + DQ TDX_BFV_MEMORY_SIZE > > + DD TDX_METADATA_SECTION_TYPE_BFV > > + DD TDX_METADATA_ATTRIBUTES_EXTENDMR > > Size is

Re: [edk2-devel] [PATCH] MdePkg,ShellPkg: Add ProcessorUpgradeSocketLGA4677 from SMBIOS 3.5.0

Good comment. Saw 0db89a661f38b10012ff4f62e1853bfc48efd462 does so for both MdePkg and ShellPkg, but that is different for fixing typo which must change both MdePkg and ShellPkg in same patch. Please check V2. Thanks, Star -Original Message- From: Ni, Ray Sent: 2021年9月28日 10:12 To: