My understanding is that you were referring to the document on my fork
being difficult to access and you shared a link to your CI results that
does not have the message pointing to the wiki page yet.
This is all correct. The wiki content has moved from my fork to the
official wiki page and
Hi Liming,
I just add ```-D DEBUG_FILE_PATH=gEfiCallerBaseName``` to BuildOptions
Thanks
Guomin
> -Original Message-
> From: gaoliming
> Sent: Sunday, April 17, 2022 11:21 AM
> To: Jiang, Guomin ; devel@edk2.groups.io
> Cc: Kinney, Michael D ; Liu, Zhiguang
>
> Subject: 回复:
On Wed, 20 Apr 2022 at 09:30, Gerd Hoffmann wrote:
>
> On Tue, Apr 19, 2022 at 11:54:38PM +0200, Ard Biesheuvel wrote:
> > On Tue, 19 Apr 2022 at 09:35, Oliver Steffen wrote:
> > >
> > > PR: https://github.com/tianocore/edk2/pull/2711
> > >
> > > Update CI, run all Linux (aka Ubuntu-GCC5) based
On 20.04.2022 11:16, Ard Biesheuvel wrote:
On Wed, 20 Apr 2022 at 09:30, Gerd Hoffmann wrote:
On Tue, Apr 19, 2022 at 11:54:38PM +0200, Ard Biesheuvel wrote:
> On Tue, 19 Apr 2022 at 09:35, Oliver Steffen wrote:
> >
> > PR: https://github.com/tianocore/edk2/pull/2711
> >
> > Update CI, run
On Wed, 2022-04-20 at 10:16 +0200, Gerd Hoffmann wrote:
> Hi,
>
> > > Yes for validation (aka sanity-checking the fields, etc).
> > > But for measurement I don't see why the ordering matters.
> > > Whenever you do that before or after consuming the TdHob
> > > should not make a difference.
> >
Reviewed-by: Ankit Sinha
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael
> Kubacki
> Sent: Monday, April 18, 2022 6:27 PM
> To: devel@edk2.groups.io
> Cc: Michael Kubacki ; Desimone, Nathaniel
> L ; Sinha, Ankit
> Subject: [edk2-devel] [PATCH v1 1/1]
On Wed, Apr 20, 2022 at 09:46:13AM +, Yao, Jiewen wrote:
> Gerd
> I cannot agree your statement on ordering.
>
> Smart attacker can forge the good measurement based upon the severity of
> vulnerability.
>
> One famous example in 2011:
>
Hi
As Liming's mail below, PlatformStandaloneMm.fdf, DeveloperBoxMm.fdf and
PlatformStandaloneMmRpmb.fdf consume
VariableStandaloneMm module.
I send the patch that made VariableStandaloneMm driver use
SmmWaitForAllProcessor function and depend on SmmCpuRendezvousLib. In
MdeModulePkg, it will
Hi,
> > So, no matter what the order is, you'll figure the system got
> > compromised after the fact, when checking the hashes later, and in
> > turn take actions like refusing to hand out secrets to the
> > compromised system.
>
> Not if the code falsifies the measurement both in the log and
On Mon, 18 Apr 2022 at 10:14, Pranav Madhu wrote:
>
> Remove system level cache (SLC) entry from ACPI PPTT table. SLC on the
> Neoverse reference design platforms is the memory side cache and so it
> is removed from PPTT table.
>
Could you elaborate? Why does the former justify/imply the latter?
On Tue, 12 Apr 2022 at 18:30, wrote:
>
> From: Michael Kubacki
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
>
> The UEFI variable drivers such as VariableRuntimeDxe, VariableSmm,
> VariableStandaloneMm, etc. (and their dependent protocol/library
> stack), typically acquire UEFI
On Wed, 13 Apr 2022 at 10:13, Gerd Hoffmann wrote:
>
> On Tue, Apr 12, 2022 at 10:51:34PM +0800, Yu Pu wrote:
> > There are two libraries: MdePkg/CpuLib and UefiCpuPkg/UefiCpuLib and
> > UefiCpuPkg/UefiCpuLib will be merged to MdePkg/CpuLib. To avoid build
> > failure, add CpuLib dependency to
Gerd
I cannot agree your statement on ordering.
Smart attacker can forge the good measurement based upon the severity of
vulnerability.
One famous example in 2011:
https://invisiblethingslab.com/resources/2011/Attacking_Intel_TXT_via_SINIT_hijacking.pdf
Because the attack happens before PCR18
Hi Micheal,
Do you know if anyone has modified the Azure CI today? I did a CI test today,
and many modules reported errors, but yesterday, only two modules reported
errors, I don't know what happened. Please refer following two links:
Today:
Hi Ard,
Please find my response inline.
> -Original Message-
> From: Ard Biesheuvel
> Sent: Wednesday, April 20, 2022 1:05 PM
> To: Pranav Madhu
> Cc: edk2-devel-groups-io ; Ard Biesheuvel
> ; Sami Mujawar
> Subject: Re: [edk2-platforms][PATCH V1 1/1] Platform/Sgi: Remove SLC entry
>
PR: https://github.com/tianocore/edk2/pull/2795
Explicity disable the stack protection with
-fno-stack-protection for builds using GCC on
AARCH64.
The gcc on Ubuntu enables -fstack-protector-strong
by default starting with Ubuntu 21.10.
GenFw fails if stack protection is enabled.
v2: Set
Explicity disable the stack protection with
-fno-stack-protection for builds using GCC on
AARCH64.
The gcc on Ubuntu enables -fstack-protector-strong
by default starting with Ubuntu 21.10.
GenFw fails if stack protection is enabled.
Signed-off-by: Oliver Steffen
---
Hi,
> > Yes for validation (aka sanity-checking the fields, etc).
> > But for measurement I don't see why the ordering matters.
> > Whenever you do that before or after consuming the TdHob
> > should not make a difference.
>
> [Jiewen] I disagree. The order matters from security perspective.
>
On Wed, 13 Apr 2022 at 10:14, Gerd Hoffmann wrote:
>
> On Tue, Apr 12, 2022 at 10:51:39PM +0800, Yu Pu wrote:
> > Because UefiCpuPkg/UefiCpuLib is merged to MdePkg/CpuLib, remove the
> > dependency of UefiCpuLib.
> >
> > Cc: Ard Biesheuvel
> > Cc: Jiewen Yao
> > Cc: Jordan Justen
> > Cc: Gerd
On Mon, 18 Apr 2022 at 13:54, Pranav Madhu wrote:
>
> Changes since V1:
> - Rebased on top of latest master branch.
> - Rebased on top of patch to remove SLC cache entries from PPTT (link
> for the same in edk2.groups.io is provided below)
>
> Arm infrastructure reference design platforms uses
On 20.04.2022 07:36, gaoliming wrote:
GCC Stack Protector options come from GCC4.9.3. But, there is GCC48 in
tools_def. I am not sure whether GCC48 is still used.
A valid point.
GCC 4.8 accepts -fno-stack-protector.
For IA32 and X64 this option is set in GCC48_$ARCH_CC_FLAGS.
Setting it for
On Thu, 7 Apr 2022 at 12:52, Sunny Wang wrote:
>
> Sorry for the delay and thanks for fixing the issues, Marcin.
>
> The patch series look good to me. Also, we have tested the patches on a
> CN9130 based system, and it works fine. The patches fix the SCT failures
> below, and UEFI network
Hi Micheal,
Sorry for late reply, I'm busy with other things, focusing on modifying our
code, refer to the detailed error log file.
I am learning how to get the detailed log from this link:
Merged - https://github.com/tianocore/edk2/pull/2805
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Yao, Jiewen
> Sent: Wednesday, April 20, 2022 3:01 PM
> To: Gerd Hoffmann ; devel@edk2.groups.io
> Cc: Lu, Xiaoyu1 ; Oliver Steffen ;
> Pawel Polawski ; Jiang, Guomin
> ;
On Wed, 6 Apr 2022 at 22:02, Marcin Wojtas wrote:
>
> Hi,
>
> pon., 14 mar 2022 o 18:17 Sunny Wang napisał(a):
> >
> > Looks good. Thanks much, Marcin.
> >
> > This will be helpful as http://wiki.macchiatobin.net/tiki-index.php has
> > been not accessible for quite a while.
> >
> > Reviewed-by:
> -Original Message-
> From: Gerd Hoffmann
> Sent: Tuesday, April 19, 2022 9:15 PM
> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
>
> Cc: Leif Lindholm ; Ard Biesheuvel
> ; Jordan Justen ;
> Jian J Wang ; Ray Ni ; Hao A Wu
> ; Jiewen Yao ; Liming Gao
> ; Pawel
On Tue, Apr 19, 2022 at 11:54:38PM +0200, Ard Biesheuvel wrote:
> On Tue, 19 Apr 2022 at 09:35, Oliver Steffen wrote:
> >
> > PR: https://github.com/tianocore/edk2/pull/2711
> >
> > Update CI, run all Linux (aka Ubuntu-GCC5) based jobs in a custom
> > Fedora 35 container.
>
> Why?
>
> > The
Hi Ard,
Thanks for your time in reviewing this patch series. Please find my response
inline.
> -Original Message-
> From: Ard Biesheuvel
> Sent: Wednesday, April 20, 2022 1:11 PM
> To: Pranav Madhu
> Cc: edk2-devel-groups-io ; Ard Biesheuvel
> ; Sami Mujawar
> Subject: Re:
Here's a PR with this change that has an additional temp commit to
trigger builds:
https://github.com/tianocore/edk2/pull/2806
Ignore the patch check failure, that is related to the temp commit.
Regards,
Michael
On 4/19/2022 9:43 PM, Michael Kubacki wrote:
From: Michael Kubacki
The NOOPT
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This change is made to
allow the new variable driver to build that has a dependency on
this library class and
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This change is made to
allow the new variable driver to build that has a dependency on
this library class and
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This change is made to
allow the new variable driver to build that has a dependency on
this library class and
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This change is made to
allow the new variable driver to build that has a dependency on
this library class and
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This change is made to
allow the new variable driver to build that has a dependency on
this library class and
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This change is made to
allow the new variable driver to build that has a dependency on
this library class and
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This change is made to
allow the new variable driver to build that has a dependency on
this library class and
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This change is made to
allow the new variable driver to build that has a dependency on
this library class and
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This change is made to
allow the new variable driver to build that has a dependency on
this library class and
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This change is made to
allow the new variable driver to build that has a dependency on
this library class and
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This change is made to
allow the new variable driver to build that has a dependency on
this library class and
If I understand this patch correctly, it is exactly duplicating the
SmmCpuRendezvousLib library class/interface in ModeModulePkg because
code there cannot depend on the library class/interface definition
currently in UefiCpuPkg:
REF： https://bugzilla.tianocore.org/show_bug.cgi?id=3854
In UefiCpuPkg, there are a new Protocol with the new service
SmmWaitForAllProcessor(), which can be used by SMI handler
to optionally wait for other APs to complete SMM rendezvous in
relaxed AP mode.
This patch use the new service to let
Chang:
PR shows the patch coding style issue. Please fix them.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 gaoliming
> 发送时间: 2022年4月20日 7:50
> 收件人: devel@edk2.groups.io; zhichao@intel.com; 'Ke, Bo-ChangX'
>
> 抄送: 'Liu, Zhiguang' ; 'Bi, Dandan'
> ; 'Zeng, Star' ;
Guomin:
gEfiCallerBaseName is the module base name, not source file name. It can
verify the build reproduce, but it can't provide the same functionality to
_FILE_.
Thanks
Liming
> -邮件原件-
> 发件人: Jiang, Guomin
> 发送时间: 2022年4月20日 16:58
> 收件人: Gao, Liming ; devel@edk2.groups.io
> 抄送:
Reviewed-by: Abner Chang
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael
> Kubacki
> Sent: Thursday, April 21, 2022 4:44 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner (HPS SW/FW Technologist) ;
> Gilbert Chen ; Schaefer, Daniel (ROM Janitor)
>
> Subject:
The Root-of-Trust for Measurement (RTM) for TDX is TDX-Module. The TDX-Module
will enforce the MRTD calculation for the TDVF code.
Then TDVF can then act as Chain-of-Trust for Measurement (CTM) to setup RTMR
and continue the rest.
It is described in [TDX-Module] Chapter 11, [TDVF] Chapter 8.
Hi EmulatorPkg maintainers,
This is the only package in the series that has not given a review yet.
Can you please help review it?
Thanks,
Michael
On 4/12/2022 12:29 PM, Michael Kubacki wrote:
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds an instance
Reviewed-by: Jiewen Yao
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of yi1 li
> Sent: Tuesday, April 19, 2022 10:38 PM
> To: devel@edk2.groups.io
> Cc: Li, Yi1 ; Yao, Jiewen ; Wang, Jian
> J
> Subject: [edk2-devel] [PATCH 1/1] CryptoPkg: Declare PcdEcEnabled in Library
Thanks for the follow up.
Merged - https://github.com/tianocore/edk2/pull/2809
> -Original Message-
> From: Xu, Min M
> Sent: Thursday, April 21, 2022 8:45 AM
> To: devel@edk2.groups.io
> Cc: Xu, Min M ; Brijesh Singh ;
> Aktas, Erdem ; James Bottomley
> ; Yao, Jiewen ; Tom Lendacky
>
I am not the reviewer for the changes under EmulatorPkg other than Redfish
stuff. However, I have no problem with the entire patch set, so does the change
under for EmulatorPkg.
Reviewed-by: Abner Chang
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael
> Kubacki
Oliver:
The change is good to me. I also include ARM maintainer Ard to review this
change.
Reviewed-by: Liming Gao
Thanks
Liming
> -邮件原件-
> 发件人: Oliver Steffen
> 发送时间: 2022年4月20日 16:16
> 收件人: devel@edk2.groups.io
> 抄送: bob.c.f...@intel.com; gaolim...@byosoft.com.cn;
>
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3904
TdxDxe driver is introduced for Intel TDX feature. Unfortunately, this
driver also breaks boot process in SEV-ES guest. The root cause is in
the PciLib which is imported by TdxDxe driver.
In a SEV-ES guest the AmdSevDxe driver performs a
Hi Micheal,
Sorry for my so carelessness, I actually fixed our code yesterday, I think this
bug was brought on by when I modified the code formatting, I will check
carefully next time. Sorry again.
--
Thanks,
Chao
On 4月 20 2022, at 10:45 晚上, "Michael Kubacki"
wrote:
While input object is NULL, do not generate attribute with empty string
value. This can reduce the size of HTTP context while sending "PATCH"
or "POST" request to Redfish service.
Signed-off-by: Nickle Wang
Cc: Abner Chang
---
RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c | 5 ++---
1
I will merge it. Thanks
Reviewed-by: Abner Chang
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Wang,
> Nickle (Server BIOS)
> Sent: Thursday, April 21, 2022 11:16 AM
> To: devel@edk2.groups.io
> Cc: Wang, Nickle (Server BIOS) ; Chang, Abner (HPS
> SW/FW Technologist)
Merged!
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Abner
> Chang
> Sent: Thursday, April 21, 2022 12:57 PM
> To: devel@edk2.groups.io; Wang, Nickle (Server BIOS)
>
> Cc: Chang, Abner (HPS SW/FW Technologist)
> Subject: Re: [edk2-devel] [edk2-staging][PATCH] edk2-
>
Drop 'restrict' keyword which older visual studio compiler
versions complain about.
Fixes: fab6285a73c4 ("CryptoPkg/CrtLibSupport: fix strcpy")
Signed-off-by: Gerd Hoffmann
---
CryptoPkg/Library/Include/CrtLibSupport.h | 4 ++--
CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c | 4
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3906
update smbiosview type 0 related fileds.
Signed-off-by: Bo Chang Ke
Cc: Ray Ni
Cc: Zhichao Gao
---
.../UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 6 ++
.../SmbiosView/SmbiosViewStrings.uni| 2
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3904
TdxDxe driver is introduced for Intel TDX feature. Unfortunately, this
driver also breaks boot process in SEV-ES guest. The root cause is in
the PciLib which is imported by TdxDxe driver.
In a SEV-ES guest the AmdSevDxe driver performs a
Reviewed-by: Jiewen Yao
> -Original Message-
> From: Gerd Hoffmann
> Sent: Wednesday, April 20, 2022 2:17 PM
> To: devel@edk2.groups.io
> Cc: Lu, Xiaoyu1 ; Oliver Steffen ;
> Pawel Polawski ; Yao, Jiewen ;
> Jiang, Guomin ; Wang, Jian J
> ; Gerd Hoffmann
> Subject: [PATCH 1/1]
Thanks Min.
Would you please add some comment in the APRIORI section, to explain why the
order is in this way?
It also reminds people that the order should not be changed.
With comment added, reviewed-by: Jiewen Yao
> -Original Message-
> From: Xu, Min M
> Sent: Wednesday, April
61 matches
Mail list logo
