Re: [edk2-devel] [PATCH v5 2/6] CryptoPkg/CryptoPkg.ci.yaml: Allow dependency upon ArmPkg

Why CryptoPkg needs to depend on ArmPkg? Can we move content to MdePkg? > -Original Message- > From: Pierre Gondois > Sent: Tuesday, November 21, 2023 4:47 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Li, Yi1 ; Lu, > Xiaoyu1 > ; Jiang, Guomin ; Leif Lindholm > ; Ard Biesheuvel ; >

Re: [edk2-devel] [PATCH 2/3] ShellPkg/UefiShellDebug1CommandsLib: remove gEfiMpsTableGuid ref from DMEM

I would leave the decision to the right owner of LegacyBiosMpTable.h in MdePkg. Once pass review on MdePkg, I am fine with this patch. Thanks, Zhichao > -Original Message- > From: Laszlo Ersek > Sent: Thursday, November 9, 2023 8:06 PM > To: devel@edk2.groups.io > Cc: Gao, Zhichao >

Re: [edk2-devel] [PATCH v5 0/6] MPAM ACPI definitions and parser

Sorry, I finished review on my local, but forgot if I gave R-B or not. For ShellPkg part: Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: Rohit Mathew > Sent: Monday, November 20, 2023 8:17 PM > To: devel@edk2.groups.io; Rohit Mathew > Cc: Kinney, Michael D ;

[edk2-devel] [PATCH v5 0/6] CryptoPkg: Enable Openssl native instruction support for AARCH64

v5: - [PATCH v5 1/6] ArmPkg/ArmLib: Add macros/helper functions around AA64Isar0 register - Remove unused ArmReadIdAA64Isar0() declaration - [PATCH v4 5/6] CryptoPkg/OpensslLib: Add AArch64Cap for arch specific hooks - Removed unused GET_BITFIELD() macro - Indentation v4: - Added Acked-by

[edk2-devel] [PATCH v5 1/6] ArmPkg/ArmLib: Add macros/helper functions around AA64Isar0 register

Add macro definitions and helper functions to access AArch64 capabilities described in the AA64Isar0 register. Reviewed-by: Leif Lindholm Signed-off-by: Pierre Gondois --- ArmPkg/Include/Chipset/AArch64.h | 60 +++- ArmPkg/Include/Library/ArmLib.h| 218 +++-

[edk2-devel] [PATCH v5 6/6] CryptoPkg: Enable Openssl Accel builds for AARCH64

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4601 Enable the following modules builds for AARCH64: - OpensslLibAccel.inf - OpensslLibFullAccel.inf Acked-by: Gerd Hoffmann Signed-off-by: Pierre Gondois --- CryptoPkg/CryptoPkg.dsc | 23 --- CryptoPkg/Readme.md | 14

[edk2-devel] [PATCH v5 2/6] CryptoPkg/CryptoPkg.ci.yaml: Allow dependency upon ArmPkg

Allow dependency upon ArmPkg to pass the dependency Check. Signed-off-by: Pierre Gondois --- CryptoPkg/CryptoPkg.ci.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/CryptoPkg/CryptoPkg.ci.yaml b/CryptoPkg/CryptoPkg.ci.yaml index f961d85927c0..3bbb220d3224 100644 ---

[edk2-devel] [PATCH v5 3/6] CryptoPkg/OpensslLib: Add native instruction support for AARCH64

Add native instruction support for AARCH64. Acked-by: Gerd Hoffmann Signed-off-by: Pierre Gondois --- .../Library/OpensslLib/OpensslLibAccel.inf| 21 ++- .../OpensslLib/OpensslLibFullAccel.inf| 21 ++- CryptoPkg/Library/OpensslLib/UefiAsm.conf |

[edk2-devel] [PATCH v5 5/6] CryptoPkg/OpensslLib: Add AArch64Cap for arch specific hooks

Add AARCH64 specific implementations of: - OPENSSL_cpuid_setup(), probing hardware capabilitie (presence of FEAT_AES, etc.) - OPENSSL_rdtsc(), returning non-trusted entropy by accessing system counter. Acked-by: Gerd Hoffmann Acked-by: Leif Lindholm Signed-off-by: Pierre Gondois ---

Re: [edk2-devel] [PATCH v4 5/6] CryptoPkg/OpensslLib: Add AArch64Cap for arch specific hooks

On 11/20/23 19:39, Leif Lindholm wrote: On Mon, Nov 20, 2023 at 14:48:25 +0100, Pierre Gondois wrote: Add AARCH64 specific implementations of: - OPENSSL_cpuid_setup(), probing hardware capabilitie (presence of FEAT_AES, etc.) - OPENSSL_rdtsc(), returning non-trusted entropy by accessing

回复: 回复: edk2-stable202311: Re: [edk2-devel] [PATCH] DynamicTablesPkg: Fix ETE _UID Creation

Sami: I have merged it. Please check. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Sami > Mujawar > 发送时间: 2023年11月21日 19:57 > 收件人: gaoliming ; 'Laszlo Ersek' > ; 'Michael Kinney' ; > devel@edk2.groups.io; ashishsin...@nvidia.com; quic_llind...@quicinc.com; >

Re: [edk2-devel] [PATCH v3 09/39] MdePkg: Add a new library named PeiServicesTablePointerLibReg

On 11/17/23 10:59, Chao Li wrote: > Since some ARCH or platform not require execute code on memory during > PEI phase, some values may transferred via CPU registers. > > Adding PeiServcieTablePointerLibReg to allow set and get the PEI service > table pointer depend by a CPU register, this library

Re: 回复: edk2-stable202311: Re: [edk2-devel] [PATCH] DynamicTablesPkg: Fix ETE _UID Creation

Hi Liming, On 21/11/2023, 01:05, "gaoliming" mailto:gaolim...@byosoft.com.cn>> wrote: Sami: I am OK to merge this patch for this stable bug. I will add push label for https://github.com/tianocore/edk2/pull/5061 [SAMI] Thank you for picking this

Re: [edk2-devel] [PATCH v5 2/6] CryptoPkg/CryptoPkg.ci.yaml: Allow dependency upon ArmPkg

Hello Jiewen, On 11/21/23 12:27, Yao, Jiewen wrote: Why CryptoPkg needs to depend on ArmPkg? Can we move content to MdePkg? The OpensslLib needs to discover the native instruction supported by the underlying platform before using them. This could also be done through the MdePkg as you

[edk2-devel] [PATCH] Maintainers.txt: add Aaron Young as MptScsi and PvScsi reviewer

I asked Aaron if he'd be willing to take the "R" role for the MptScsi and PvScsi drivers in OvmfPkg, given their low maintenance needs and previous commit 1774a44ad91d ("Maintainers.txt: Remove MptScsi and PvScsi reviewers", 2022-07-28). Designate Aaron as reviewer for those drivers, with many

Re: [edk2-devel] [PATCH v5 2/6] CryptoPkg/CryptoPkg.ci.yaml: Allow dependency upon ArmPkg

This Bugzilla is filed in 2022-10-26. Now it is 2023-11-21. I agree with you that it is a big task. May I know what is the plan? E.g. who is working on that? When do you expect it will be done? According to the dependency rule, what we need is only *interface* definition, but not

Re: 回复: 回复: edk2-stable202311: Re: [edk2-devel] [PATCH] DynamicTablesPkg: Fix ETE _UID Creation

Hi Liming, Thanks a lot. I can see it in the mainline. Regards, Sami Mujawar On 21/11/2023, 14:15, "gaoliming" mailto:gaolim...@byosoft.com.cn>> wrote: Sami: I have merged it. Please check. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io

Re: [edk2-devel] [PATCH v5 2/6] CryptoPkg/CryptoPkg.ci.yaml: Allow dependency upon ArmPkg

Hi Jiewen, On Tue, Nov 21, 2023 at 13:41:21 +, Yao, Jiewen wrote: > Thanks to let me know the background. > > Please be aware that there is fundamental difference between > dependency in INF and dependency in DSC. > > What we have previously in the ArmPkg in *DSC*. We don’t need add >

Re: [edk2-devel] [PATCH v5 2/6] CryptoPkg/CryptoPkg.ci.yaml: Allow dependency upon ArmPkg

Thanks to let me know the background. Please be aware that there is fundamental difference between dependency in INF and dependency in DSC. What we have previously in the ArmPkg in *DSC*. We don’t need add ArmPkg in yaml. However, what you try to introduce is ArmPkg in *INF*, e.g. your patch

Re: [edk2-devel] [PATCH v3 03/11] MdePkg/Acpi65: Add _PSD/_CPC/State Coordination Types macros

These ACPI methods were there since long ago. Why do you only add the related definitions to 65.h? > Cf. s8.3 Power, Performance, and Throttling State Dependencies What does "Cf. s8.3" mean? Thanks, Ray > -Original Message- > From: devel@edk2.groups.io On Behalf Of > PierreGondois >

Re: [edk2-devel] [PATCH V3 0/4] Add New Memory Attributes

On 11/20/23 05:59, Dhaval Sharma wrote: > Did you mean to add it as a memory type by itself like > EFI_MEMORY_TYPE_INFORMATION? Yes, a new enum constant for EFI_MEMORY_TYPE. (It wasn't a "loaded question", just wanted to understand the reasoning.) > My interpretation of Memory Type is that it

Re: [edk2-devel] [Bug] Building NetworkPkg fails due to missing SynchronizationLib dependency of BaseCryptLib

Hi Sean and Michael, The NetworkPkg.ci.yaml is pointing at a DSC file in the NetworkPkg. If I try a local build of that DSC file, it does fail immediately with a missing library mapping. Any ideas on how this was not seen by CI? Either for PR or Push actions? Thanks, Mike > -Original

[edk2-devel] [RFC PATCH 1/1] ArmPkg,MdePkg: move ArmLib.h to MdePkg

Related to https://bugzilla.tianocore.org/show_bug.cgi?id=4121, but not resolving it. (Nearly?) all of ArmPkg describes industry standard behaviour, and hence according to general rules, ought to live in MdePkg. Addressing this will however be a substantial task. Take a first step by moving the

[edk2-devel] [PATCH v3 02/11] ArmPkg/ArmScmiDxe: Add PERFORMANCE_DESCRIBE_FASTCHANNEL support

The PERFORMANCE_DESCRIBE_FASTCHANNEL Scmi command is available since SCMI v2.0 and allows to query information about the supported fast-channels of the Scmi performance protocol. Add support for this command. Also move SCMI_MESSAGE_ID_PERFORMANCE enum definition up in the file to use it in

[edk2-devel] [PATCH v3 03/11] MdePkg/Acpi65: Add _PSD/_CPC/State Coordination Types macros

Add macros for: - _PSD version - _CPC version - C-state/T-state/P-state Coordination Types These objects were present in previous ACPI specification version, but are only added to the latest availbable version (6.5). Signed-off-by: Pierre Gondois --- MdePkg/Include/IndustryStandard/Acpi65.h |

[edk2-devel] [PATCH v3 04/11] DynamicTablesPkg: Use new CPC revision macro

Make use of the newly added CPC revision macro. Signed-off-by: Pierre Gondois --- DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c

[edk2-devel] [PATCH v3 05/11] DynamicTablesPkg: Rename AmlCpcInfo.h to AcpiObjects.h

The DynamicTables framework uses the AmlLib to generate some Aml objects. It is done by using structured known by both frameworks, e.g. the AML_CPC_INFO/CM_ARM_CPC_INFO structures. To prepare adding similar structures (e.g. representing _PSD information), rename AmlCpcInfo.h to AcpiObjects.h.

[edk2-devel] [PATCH v3 06/11] DynamicTablesPkg: Add CM_ARM_PSD_INFO object

Add an object describing _PSD information, cf. ACPI 6.5, s8.4.5.5 _PSD (P-State Dependency). Also add the corresponding CmObjParser. Signed-off-by: Pierre Gondois --- DynamicTablesPkg/Include/AcpiObjects.h| 20 +++ .../Include/ArmNameSpaceObjects.h | 10

[edk2-devel] [PATCH v3 08/11] DynamicTablesPkg: Add AmlCreatePsdNode() to generate _PSD

Add AmlCreatePsdNode() to the AmlLib to generate _PSD objects. _PSD objects allow to describe 'performance control, P-state or CPPC, logical processor dependency', Cf. ACPI 6.5, s8.4.5.5 _PSD (P-State Dependency). Signed-off-by: Pierre Gondois --- .../Include/Library/AmlLib/AmlLib.h |

[edk2-devel] [PATCH v3 09/11] DynamicTablesPkg: Generate _PSD in SsdtCpuTopologyGenerator

Make use of the newly added AmlCreatePsdNode() to generate _PSD objects. _PSD objects allow to describe 'performance control, P-state or CPPC, logical processor dependency', Cf. ACPI 6.4, s8.4.5.5 _PSD (P-State Dependency). Signed-off-by: Pierre Gondois --- .../SsdtCpuTopologyGenerator.c

[edk2-devel] [PATCH v3 07/11] DynamicTablesPkg: Add PsdToken field to CM_ARM_GICC_INFO object

The _PSD object (cf. ACPI 6.5, s8.4.5.5 _PSD (P-State Dependency) allows to describe CPU's power state dependencies. Add a PsdToken field to the CM_ARM_GICC_INFO object so that interdependent CPUs can reference the same CM_ARM_PSD_INFO object. Signed-off-by: Pierre Gondois ---

[edk2-devel] [PATCH v3 00/11] DynamicTablesPkg: Enable _PSD/_CPC generation using SCMI

v1: - https://edk2.groups.io/g/devel/message/104115 v2: - https://edk2.groups.io/g/devel/message/104115 - Rebase patches on latest version. v3: [PATCH 01/11] ArmPkg/ArmScmiDxe: Rename PERFORMANCE_PROTOCOL_VERSION - Note the referenced spec spec is SCMI v3.2 [PATCH 02/11] ArmPkg/ArmScmiDxe: Add

[edk2-devel] [PATCH v3 01/11] ArmPkg/ArmScmiDxe: Rename PERFORMANCE_PROTOCOL_VERSION

Rename PERFORMANCE_PROTOCOL_VERSION to reflect the different versions of the protocol. The macro is neither used in edk2 nor in edk2-platforms. Signed-off-by: Pierre Gondois --- .../Include/Protocol/ArmScmiPerformanceProtocol.h | 13 - 1 file changed, 8 insertions(+), 5

Re: [edk2-devel] [PATCH v3 01/11] ArmPkg/ArmScmiDxe: Rename PERFORMANCE_PROTOCOL_VERSION

On Tue, Nov 21, 2023 at 17:49:57 +0100, Pierre Gondois wrote: > Rename PERFORMANCE_PROTOCOL_VERSION to reflect the different > versions of the protocol. The macro is neither used in edk2 nor > in edk2-platforms. > > Signed-off-by: Pierre Gondois Reviewed-by: Leif Lindholm > --- >

Re: [edk2-devel] [PATCH v2 4/5] MdeModulePkg/Bus/Pci/PciBusDxe: Fix NULL_RETURNS Coverity issue

On 11/20/23 04:57, Ranbir Singh wrote: > > > On Wed, Nov 15, 2023 at 3:20 PM Laszlo Ersek > wrote: > > On 11/14/23 17:21, Kinney, Michael D wrote: > > Hi Ranbir, > > > >   > > > > First I want to recognize your efforts to collect Coverity

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Fix typos in Bus and Core

On 11/21/23 03:07, Page Chen via groups.io wrote: > begining -> beginning > Cabability -> Capability > CHNAGED -> CHANGED > compatability -> compatibility > concident -> coincident > correspoding -> corresponding > defered -> deferred > Dispacher -> Dispatcher > execuing -> executing > exhausive

Re: [edk2-devel] BaseTools KeyError When Building EmulatorPkg

Adding Sean Laszlo On 11/19/23 23:43, ryderkeys via groups.io wrote: > Hi all, > > I am trying to build EDK2 from most recent Github (namely, EmulatorPkg) with > the new Stuart build system on Windows 10 22H2 64 bit with VS 2019. I'm > getting the following error which directed me to this

Re: [edk2-devel] [PATCH v5 0/6] CryptoPkg: Enable Openssl native instruction support for AARCH64

On Tue, 21 Nov 2023 at 03:48, Pierre Gondois wrote: > > v5: > - [PATCH v5 1/6] ArmPkg/ArmLib: Add macros/helper functions around AA64Isar0 > register > - Remove unused ArmReadIdAA64Isar0() declaration > - [PATCH v4 5/6] CryptoPkg/OpensslLib: Add AArch64Cap for arch specific hooks > - Removed

Re: [edk2-devel] [PATCH] Modified ShellPkg/Library/UefiShellLevel2CommandsLib/Reset.c to follow error handling instead of success handling

On 11/16/23 07:16, Daniel Nguyen wrote: > Signed-off-by: Daniel Nguyen > --- > .../UefiShellLevel2CommandsLib/Reset.c| 43 +++ > 1 file changed, 24 insertions(+), 19 deletions(-) > > diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/Reset.c >

Re: [edk2-devel] [PATCH v3 1/3] Platform/ARM: Juno: Fix typo

On Tue, Nov 21, 2023 at 17:51:33 +0100, PierreGondois wrote: > Fix a typo. > > Change-Id: I84807f18855ff4c0a2f34a3556edc4698eea2170 You've accidentally included your internal Change-Id in the commit messages for all patches in this set. / Leif > Signed-off-by: Pierre Gondois > --- >

Re: [edk2-devel] [PATCH v1 1/1] Bug 2861 - HiiDatabaseDxe, ConfigRouting.c, GetElementsFromRequest incorrect error handling.

On 11/18/23 14:06, Chip wrote: > How many different patches are you looking for? > > One patch to fix bug 2861 specifically, and a separate patch that fixes > the uninitialized pointer issue? I can't easily say, because I'm not familiar with HiiDatabaseDxe. So looking at the present patch, I can

Re: [edk2-devel] [Bug] Building NetworkPkg fails due to missing SynchronizationLib dependency of BaseCryptLib

On 11/20/23 11:25, Crossed Carpet wrote: > Good morning Laszlo, > Thank you for your reply. I feared this was intentional due to believing > that it would have been caught with automated testing.  > Doesn't the Azure Pipeline try to build all packages to make sure no > dependency broke? Right, we

Re: [edk2-devel] [PATCH v2 3/3] UefiCpuPkg/PiSmmCpuDxeSmm: Use processor extended information

On 11/20/23 13:42, Wu, Jiaxin wrote: > For core id in cpu features library, I agree it should be not easy or > simple change to 0x1f. > >   > > But in SMM CPU, there is no usage case depends on the number of cores > retrieved from cupid 0x0b return value, only PackageId will be used. So, > this

Re: [edk2-devel] Fail to build boot with tools code failure

On 11/16/23 04:46, Jackie Lien (Temp) via groups.io wrote: > Hi team, > > Please help with the build error in BOOT.MXF.1.1.1. The command and log > are listed below. > >   > > Sync & build command: > > 1. python sync_crm.py BOOT.MXF.1.1.1-00175-Olympic-1 > 2. copy manifest to my local sync

[edk2-devel] [PATCH v3 0/3] Platform/ARM: Enable _CPC/_PSD generation on Juno-r2

v1: - https://edk2.groups.io/g/devel/message/104127 v2: - https://edk2.groups.io/g/devel/message/110048 - Rebase patches on latest version. - Correct frequency values which were advertised in KHz when CPPC spec require them to be in MHz. v3: - Rebase on latest master - Use ACPI 6.5 definitions

[edk2-devel] [PATCH v3 3/3] Platform/ARM: Juno: Generate _CPC objects for JunoR2

The SsdtCpuTopologyGenerator can generate _CPC objects. This is done by querying the SCP for the relevant performance state information through SCMI. CM_ARM_CPC_INFO are then populated and used to generate _CPC objects in the Ssdt Cpu topology. Use the DynamicTablesScmiInfoLib and add the

[edk2-devel] [PATCH v3 10/11] DynamicTablesPkg: Add DynamicTablesScmiInfoLib

The SCP holds some power information that could be advertised through the _CPC object. The communication with the SCP is done through SCMI protocols (c.f. ArmScmiDxe). Use the SCMI protocols to query information and feed it to the DynamicTablesPkg. Signed-off-by: Pierre Gondois ---

[edk2-devel] [PATCH v3 11/11] DynamicTablesPkg: Remove check for _CPC field

When generating _CPC objects, some fields are mandatory by spec [1]. Some fields cannot be supported by a the Juno platform, which is used to test the _CPC generation. Therefore, don't prevent the generation of _CPC objects if the fields below are missing, and let the OS handle the missing

[edk2-devel] [PATCH v3 1/3] Platform/ARM: Juno: Fix typo

Fix a typo. Change-Id: I84807f18855ff4c0a2f34a3556edc4698eea2170 Signed-off-by: Pierre Gondois --- .../ConfigurationManagerDxe/ConfigurationManager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[edk2-devel] [PATCH v3 2/3] Platform/ARM: Juno: Generate _PSD objects

The SsdtCpuTopologyGenerator can generate _PSD objects. Add _PSD information and handling to the Configuration Manager to generate them. Change-Id: I4bb23582d250d43c173a3e6ee86eb6b0349f1b03 Signed-off-by: Pierre Gondois --- .../ConfigurationManager.c| 98 +--

Re: [edk2-devel] [PATCH v3 10/11] DynamicTablesPkg: Add DynamicTablesScmiInfoLib

On Tue, Nov 21, 2023 at 17:50:06 +0100, Pierre Gondois wrote: > The SCP holds some power information that could be advertised > through the _CPC object. The communication with the SCP is done > through SCMI protocols (c.f. ArmScmiDxe). > > Use the SCMI protocols to query information and feed it

Re: [edk2-devel] [PATCH v3 1/3] Platform/ARM: Juno: Fix typo

On 11/21/23 18:00, Leif Lindholm wrote: On Tue, Nov 21, 2023 at 17:51:33 +0100, PierreGondois wrote: Fix a typo. Change-Id: I84807f18855ff4c0a2f34a3556edc4698eea2170 You've accidentally included your internal Change-Id in the commit messages for all patches in this set. / Leif Yes

Re: [edk2-devel] [PATCH v5 2/6] CryptoPkg/CryptoPkg.ci.yaml: Allow dependency upon ArmPkg

On Tue, Nov 21, 2023 at 14:46:05 +, Yao, Jiewen wrote: > This Bugzilla is filed in 2022-10-26. Now it is 2023-11-21. Oh, I'm sure I voiced the same opinion for many years before someone (rightly) told me to go gile that bugzilla. > I agree with you that it is a big task. May I know what is

Re: [edk2-devel] [PATCH v5 2/6] CryptoPkg/CryptoPkg.ci.yaml: Allow dependency upon ArmPkg

On Tue, 21 Nov 2023 at 10:55, Leif Lindholm wrote: > > On Tue, Nov 21, 2023 at 14:46:05 +, Yao, Jiewen wrote: > > This Bugzilla is filed in 2022-10-26. Now it is 2023-11-21. > > Oh, I'm sure I voiced the same opinion for many years before someone > (rightly) told me to go gile that bugzilla.

Re: [edk2-devel] [PATCH] Maintainers.txt: add Aaron Young as MptScsi and PvScsi reviewer

Thanks Laszlo. Yes, ajyoung-oracle is my github user ID. Reviewed-by: Aaron Young Thanks, -Aaron -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111558): https://edk2.groups.io/g/devel/message/111558 Mute This Topic:

Re: [edk2-devel] [PATCH v5 2/6] CryptoPkg/CryptoPkg.ci.yaml: Allow dependency upon ArmPkg

Cool, thanks for considering that! > -Original Message- > From: Ard Biesheuvel > Sent: Wednesday, November 22, 2023 12:03 AM > To: devel@edk2.groups.io; quic_llind...@quicinc.com > Cc: Yao, Jiewen ; Pierre Gondois > ; Li, Yi1 ; Lu, Xiaoyu1 > ; Jiang, Guomin ; Ard > Biesheuvel ; Sami

Re: [edk2-devel] [PATCH v2] OvmfPkg/MemEncryptSevLib: Fix address overflow during PVALIDATE

On 11/20/23 08:55, Gerd Hoffmann wrote: > On Fri, Nov 17, 2023 at 10:39:13PM +0100, Laszlo Ersek wrote: >> On 11/17/23 12:42, Gerd Hoffmann wrote: >>> On Fri, Nov 17, 2023 at 10:16:10AM +0100, Laszlo Ersek wrote: (+Liming +Mike) On 11/16/23 10:01, Gerd Hoffmann wrote: > On Wed,

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Fix typos in Bus and Core

Thanks for the feedback. I will break down into smaller pieces. Page > On Nov 21, 2023, at 8:17 AM, Laszlo Ersek wrote: > > On 11/21/23 03:07, Page Chen via groups.io wrote: >> begining -> beginning >> Cabability -> Capability >> CHNAGED -> CHANGED >> compatability -> compatibility >>

Re: [edk2-devel] [PATCH] Modified ShellPkg/Library/UefiShellLevel2CommandsLib/Reset.c to follow error handling instead of success handling

Please follow https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format for the commit message. And introduce why you need to make the change. The error handling would be taken care later. Thanks, Zhichao > -Original Message- > From: devel@edk2.groups.io On Behalf

Re: [edk2-devel] [PATCH v3 09/39] MdePkg: Add a new library named PeiServicesTablePointerLibReg

Hi Laszlo, Thanks, Chao On 2023/11/21 22:37, Laszlo Ersek wrote: On 11/17/23 10:59, Chao Li wrote: Since some ARCH or platform not require execute code on memory during PEI phase, some values may transferred via CPU registers. Adding PeiServcieTablePointerLibReg to allow set and get the PEI

Re: [edk2-devel] [PATCH v3 03/11] MdePkg/Acpi65: Add _PSD/_CPC/State Coordination Types macros

Hello Ray, On 11/22/23 01:03, Ni, Ray wrote: These ACPI methods were there since long ago. Why do you only add the related definitions to 65.h? I have only added the definitions to the latest ACPI definition file (i.e. 6.5) because: - as it was not defined before, I assumed it was not used

[edk2-devel] [Patch V3 1/3] UefiCpuPkg/MpInitLib: Eliminate redundant microcode loading in DXE.

The DXE stage's Microcode loading process has been elimincated by: 1. Let ShadowMicrocodeUpdatePatch and MicrocodeDetect for BSP performed only during the PEI phase. DXE skip those actions. 2. BSP in DXE WakeUpAp only for synchronizing MTRR settings, not loading microcode. Synchronizing the MTRR

[edk2-devel] [Patch V3 2/3] UefiCpuPkg/MpInitLib: Store MTRRs settings only when CpuCount>1

Store BSP's MTRR setting only when CpuCount>1. Cc: Ray Ni Cc: Eric Dong Cc: Rahul Kumar Cc: Tom Lendacky Cc: Laszlo Ersek Signed-off-by: Yuanhao Xie --- UefiCpuPkg/Library/MpInitLib/MpLib.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git

[edk2-devel] [Patch V3 3/3] UefiCpuPkg/MpInitLib: Extract Dump Microcode Revision as function.

There is no functional changes, only extract DumpMicrocodeRevision since only in PEI BSP will detect, apply microcode, and APs will sync microcode. Cc: Ray Ni Cc: Eric Dong Cc: Rahul Kumar Cc: Tom Lendacky Cc: Laszlo Ersek Signed-off-by: Yuanhao Xie ---

Re: [edk2-devel] [PATCH v3 0/5] Designware MMCDXE changes and enhancement

Hi Leif, Ard, By any chance you have time to review this series of patches? Thank you. Regards, John -Original Message- From: YuinYee Chew Sent: Friday, November 3, 2023 10:51 AM To: devel@edk2.groups.io Cc: YuinYee Chew ; Sunil V L ; Leif Lindholm ; Ard Biesheuvel ; Michael D

[edk2-devel] [Patch V3 0/3] UefiCpuPkg/MpInitLib: Eliminate redundant microcode loading in DXE.

The DXE stage's Microcode loading process has been eliminated. Store BSP's MTRR setting only when CpuCount>1. Compare with V2, V3 also Extract Dump Microcode Revision as function xieyuanh (3): UefiCpuPkg/MpInitLib: Eliminate redundant microcode loading in DXE. UefiCpuPkg/MpInitLib: Store