Re: [edk2-devel] [PATCH v4 00/14] Add SmmRelocationLib

Jiaxin, You need to add the missing Reviewed-by for each patch if the patch doesn't change in V4. Can you reply to this mail to list what patches have already got Reviewed-by from whom? Thanks, Ray From: Wu, Jiaxin Sent: Friday, April 26, 2024 20:17 To:

Re: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Handle the NULL gMpInformation2HobGuid

Hi Ray,     Some of AMD platform doesnt use CpuMpPeim. Also this patch helps not to enforce the platform to brinup all AP's in PEI phase. Thanks AbduL On 30-04-2024 11:17, Ni, Ray wrote: Caution: This message originated from an External Source. Use proper caution when opening

Re: [edk2-devel] [PATCH ovmf v2 0/5] Enable AMD SEV-ES DebugSwap

On 22/4/24 22:16, Alexey Kardashevskiy wrote: This is to prevent #DB interception on SEV-ES VM with enabled DebugSwap feature, more details in 3/5. The corresponding Linux change (HV and VM) went upstream long time ago:

[edk2-devel] [PATCH v5 0/8] Adjust the QemuFwCfgLibMmio and add PEI stage

Patch1: Added three PCDs for QemuFwCfgLibMmio Patch2: Sparate QemuFwCfgLibMmio.c into two files and default as DXE stage library. Patch3: Added QemuFwCfgMmiLib PEI version Patch4: Rename QemuFwCfgLibMmio.inf to QemuFwCfgMmioDxeLib.inf and enable it in AARCH64 and RISCV64. V1 -> V2: 1. Use HOBs

[edk2-devel] [PATCH v5 1/8] OvmfPkg: Add a GUID for QemuFwCfgLib

Added a new GUID for QemuFwCfgLib MMIO version, called gQemuFirmwareResourceHobGuid, which is used to save QEMU firmware configure resource during PEI stage. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4755 Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Gerd Hoffmann Signed-off-by: Chao Li ---

回复: [edk2-devel] [PATCH v2] MdePkg: Add Cxl30.h into IndustryStandard

Foster: This change has been merged. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Nong, Foster > 发送时间: 2024年4月29日 15:19 > 收件人: devel@edk2.groups.io > 抄送: Kinney, Michael D ; Liming Gao > ; Ni, Ray ; Chris Li > > 主题: Re: [edk2-devel] [PATCH v2] MdePkg: Add Cxl30.h into >

Re: [edk2-devel] [PATCH v5 0/8] Adjust the QemuFwCfgLibMmio and add PEI stage

On Tue, 30 Apr 2024 at 09:47, Chao Li wrote: > > Patch1: Added three PCDs for QemuFwCfgLibMmio > Patch2: Sparate QemuFwCfgLibMmio.c into two files and default as DXE > stage library. > Patch3: Added QemuFwCfgMmiLib PEI version > Patch4: Rename QemuFwCfgLibMmio.inf to QemuFwCfgMmioDxeLib.inf and >

回复: [edk2-devel] [PATCH] Changes to print PMIC info in Shell Smbiosview

Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Shenbagadevi > R via groups.io > 发送时间: 2024年4月23日 20:00 > 收件人: devel@edk2.groups.io; Shenbagadevi R > 抄送: gaolim...@byosoft.com.cn; Sainadh Nagolu ; > Sundaresan S ; Srinivasan Mani > ; Ramesh R ; Karthika R > > 主题:

Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: Remove the dependency with MinPlatform

Reviewed-by: Abdul Lateef Attar On 29-04-2024 10:31, abner.ch...@amd.com wrote: From: Abner Chang BZ# 4695 Signed-off-by: Abner Chang Cc: Abdul Lateef Attar Cc: Nickle Wang --- .../ManageabilityPkg/ManageabilityPkg.dsc | 72 ++- 1 file changed, 56 insertions(+), 16

Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: Remove the dependency with MinPlatform

[AMD Official Use Only - General] Thanks for reviewing this, the change is merged. Abner From: Attar, AbdulLateef (Abdul Lateef) Sent: Tuesday, April 30, 2024 3:36 PM To: Chang, Abner ; devel@edk2.groups.io Cc: Nickle Wang Subject: Re: [edk2-platforms][PATCH] ManageabilityPkg: Remove the

Re: [edk2-devel] [PATCH v4 00/14] Add SmmRelocationLib

Thanks Ray, I missed to add some already reviewed-by tag in v4. All V4 patches are tested & acted by Gerd: Tested-by: Gerd Hoffmann mailto:kra...@redhat.com>> Acked-by: Gerd Hoffmann mailto:kra...@redhat.com>> For each one: listed as below, *so need Ray "reviewed-by" tag on the patch:

回复: [edk2-devel] [PATCH] MdePkg:Added support for Smbios 3.7.0 Spec

I see your patch in ShellPkg. For this change in MdePkg, Reviewed-by: Liming Gao Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 gaoliming via > groups.io > 发送时间: 2024年4月15日 14:33 > 收件人: devel@edk2.groups.io; shenbagade...@ami.com > 抄送: 'Sainadh Nagolu' ; 'Sundaresan S' > ;

[edk2-devel] [PATCH v5 2/8] OvmfPkg: Separate QemuFwCfgLibMmio.c into two files

Separate QemuFwCfgLibMmio.c into two files named QemuFwCfgLibMmio.c and QemuFwCfgLibMmioDxe.c, added a new header named QemuFwCfgLibMmioInternal.h for MMIO version. Some DXE stage variables became non-static in this patch, they will be restored to static in the next patch. Build-tested only

[edk2-devel] [PATCH v5 3/8] OvmfPkg: Add the way of HOBs in QemuFwCfgLibMmio

Added the HOB methods to load and store the QEMU firmware configure address, data address and DMA address, which are not enabled during the DXE stage. Build-tested only (with "ArmVirtQemu.dsc and RiscVVirtQemu.dsc"). BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4755 Cc: Ard Biesheuvel

[edk2-devel] [PATCH v5 8/8] OvmfPkg: Remove QemuFwCfgLibMmio.inf

All of platforms are switching to QemuFwCfgMmioDxeLib.inf, remove QemuFwCfgLibMmio.inf now. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4755 Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Gerd Hoffmann Signed-off-by: Chao Li --- .../Library/QemuFwCfgLib/QemuFwCfgLibMmio.inf | 54

[edk2-devel] [PATCH v5 6/8] ArmVirtPkg: Enable QemuFwCfgMmioDxeLib.inf

Enable QemuFwCfgMmioDxeLib.inf in ArmVirtQemu.dsc and ArmVirtQemuKernel.dsc. Build-tested only (with "ArmVirtQemu.dsc"). BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4755 Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Gerd Hoffmann Cc: Leif Lindholm Cc: Sami Mujawar Signed-off-by: Chao Li

[edk2-devel] [PATCH v5 7/8] OvmfPkg/RiscVVirt: Enable QemuFwCfgMmioDxeLib.inf

Enable QemuFwCfgMmioDxeLib.inf in RiscVVirtQemu.dsc Build-tested only (with "RiscVVirtQemu.dsc"). BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4755 Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Gerd Hoffmann Cc: Sunil V L Cc: Andrei Warkentin Signed-off-by: Chao Li ---

[edk2-devel] [PATCH v5 5/8] OvmfPkg: Copy the same new INF as QemuFwCfgLibMmio.inf

Copy QemuFwCfgLibMmio.inf to QemuFwCfgMmioDxeLib.inf, QemuFwCfgLibMmio.inf will be deleted when all platforms switching is completed. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4755 Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Gerd Hoffmann Signed-off-by: Chao Li ---

[edk2-devel] [PATCH v5 4/8] OvmfPkg: Add the QemuFwCfgMmioLib PEI stage version

Added the PEI stage library for QemuFwCfgMmioLib, which uses the FDT to find the fw_cfg and parse it. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4755 Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Gerd Hoffmann Co-authored-by: Xianglai Li Signed-off-by: Chao Li ---

Re: [edk2-devel] [PATCH v4 00/14] Add SmmRelocationLib

On Fri, Apr 26, 2024 at 08:17:06PM GMT, Jiaxin Wu wrote: > PR: https://github.com/tianocore/edk2/pull/5546 > > Intel plans to separate the smbase relocation logic from > PiSmmCpuDxeSmm driver, and the related behavior will be > moved to the new interface defined by the SmmRelocationLib > class. >

Re: [edk2-devel] [PATCH v3] OvmfPkg: Don't make APIC MMIO accesses with encryption bit set

On Fri, Apr 26, 2024 at 02:50:07PM GMT, Roth, Michael via groups.io wrote: > For the most part, OVMF will clear the encryption bit for MMIO regions, > but there is currently one known exception during SEC when the APIC > base address is accessed via MMIO with the encryption bit set for >

Re: [edk2-devel] [PATCH] Added support for ACPI related data structures for RISC_V64 platform

Hi Lingheng Du, What is the use of adding this header file and how did you create it? I think EDK2 needs ACPI spec to be released to get these definitions added. Also, these are not part of 6.5 and hence names like EFI_ACPI_6_5* are incorrect. So, it will be helpful if you add some commit message

Re: [edk2-devel] [PATCH] EmbeddedPkg/VirtualRealTimeClockLib: Support SOURCE_DATE_EPOCH

Hi all, On Fri, Apr 12, 2024 at 06:03:35PM +0800, joeyli via groups.io wrote: > Hi experts, > > On Fri, Apr 12, 2024 at 03:25:56PM +0800, Lee, Chun-Yi wrote: > > From: Chun-Yi Lee > > > > RISC-V ovmf used VirtualRealTimeClockLib but the default epoch is a > > compilation time. It causes that

[edk2-devel] [PATCH 1/5] MdeModulePkg/Bus/Spi/SpiBus: Adding SpiBus Drivers

From: Brit Chesley Added SpiBus DXE and SMM drivers. This code translates SPI requests from the application layer into SPI Bus transactions on the SPI host controller. The code is responsible for checking if the transaction is valid, then setting up the SPI clock and chip select properly before

[edk2-devel] [PATCH 4/5] MdeModulePkg: SpiHc: SpiHc Drivers

From: Brit Chesley Added SpiHc DXE and SMM drivers. This code receives bus transactions from the SpiBus layer and passes them onto the SpiHcPlatformLib Platform Initialization Spec 1.7 volume 5 section 18.1.7 Bugzilla #4753 Cc: Abner Chang Cc: Abdul Lateef Attar Signed-off-by: Brit Chesley

[edk2-devel] [PATCH 3/5] MdeModulePkg:BaseSpiHcPlatformLib: Adding NULL lib instance

From: Brit Chesley Adding NULL SpiHcPlatformLib instance. This library is responsible for handling the low level details of the SPI host controller. Since this is platform specific this library will be dependent on OEM SPI implementation. The SPI host controller layer will utilize this library

[edk2-devel] [PATCH 0/5] SPI Driver Stack

From: Brit Chesley This patchset introduces the SPI driver stack as defined in the Platform Initialization specification Volume 5 chapter 18 (DXE) and Volume 4 chapter 12 (SMM). The SPI stack decouples the SPI chip details from the SPI controller and SPI bus configuration details to enable

[edk2-devel] [PATCH 5/5] MdeModulePkg: Adding SpiHc Drivers

From: Brit Chesley Including the SpiHc drivers in MdeModulePkg.dsc Bugzilla #4753 Cc: Liming Gao Cc: Ray Ni Cc: Abner Chang Cc: Abdul Lateef Attar Signed-off-by: Brit Chesley --- MdeModulePkg/MdeModulePkg.dsc | 2 ++ 1 file changed, 2 insertions(+) diff --git

[edk2-devel] [PATCH 2/5] MdeModulePkg: Adding SpiBus Drivers

From: Brit Chesley Including the SpiBus drivers in MdeModulePkg.dsc Platform Initialization spec 1.7 volume 5 section 18.1.6 Bugzilla #4753 Cc: Liming Gao Cc: Ray Ni Cc: Abner Chang Cc: Abdul Lateef Attar Signed-off-by: Brit Chesley --- MdeModulePkg/MdeModulePkg.dsc | 2 ++ 1 file

Re: [edk2-devel] [PATCH v6 3/4] MdePkg: Adding support for EFI_CONFORMANCE_PROFILE_TABLE

Liming, I will do that; I will also update the EBBR definition to include the GUID from the most recent EBBR release. Thanks, Sam -Original Message- From: gaoliming Sent: Monday, April 29, 2024 8:48 PM To: Sam Kaynor ; devel@edk2.groups.io Cc: 'Michael D Kinney' ; 'Zhiguang Liu'

Re: [edk2-devel] [PATCH v2] MdeModulePkg/PciBusDxe: plug device hierarchy leak upon bridge hot-unplug

[AMD Official Use Only - General] Hi @ray...@intel.com, Sorry you bother you, may I have your feedback for this patch? If it looks good to you could you help to give me an R-b ? Thank you. Regards, Neo From: Laszlo Ersek Sent: Sunday,

Re: [edk2-devel] 回复: [PATCH 0/7] General Updates based on UEFI 2.10 and PI 1.8 Specification

Liming, In PI 1.8 macros for major and minor versions have been replaced with a single revision macro combining both version elements. Refer to: PEI: https://uefi.org/specs/PI/1.8/V1_PEI_Services_Table.html#related-definitions DXE:

[edk2-devel] [PATCH 0/3] TCG_Sp800_155_PlatformId_Event3 support

In December 2023, the TCG published the PC Client Platform Firmware Profile version 1.06 revision 52. This revision includes a new event type for NIST SP 800-155 recommended signed BIOS reference measurements. The new type allows for the event log auditor to find local or remote copies of the

[edk2-devel] [PATCH 1/3] MdePkg: Add TcgSp800155Event3 type info

TCG PC Client Platform Firmware Profile 1.06 revision 52 of December 2023 added a new event signature and extended information about where a reference measurement document for the firmware can be found. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Dionna Glaze ---

Re: [edk2-devel] [PATCH 1/3] MdePkg: Add TcgSp800155Event3 type info

I think it is confusing to add "TCG_Sp800_155_PlatformId_Event3" field for "TCG_Sp800_155_PlatformId_Event2" structure. Maybe just create a new "TCG_Sp800_155_PlatformId_Event3" structure? > -Original Message- > From: devel@edk2.groups.io On Behalf Of Dionna Glaze > via groups.io >

[edk2-devel] [PATCH 2/3] SecurityPkg: recognize sp800155Event3 event too

The signatures for event2 or event3 are now valid TCG SP800155 event types. Cc: Jiewen Yao Cc: Rahul Kumar Signed-off-by: Dionna Glaze --- SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c

[edk2-devel] [PATCH 3/3] OvmfPkg: add sp800155Event3 support

The signatures for event2 or event3 are now valid TCG SP800155 event types. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Gerd Hoffmann Signed-off-by: Dionna Glaze --- OvmfPkg/Tcg/TdTcg2Dxe/TdTcg2Dxe.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git

Re: [edk2-devel] [PATCH 0/3] TCG_Sp800_155_PlatformId_Event3 support

Reviewed-by: Jiewen Yao > -Original Message- > From: Dionna Glaze > Sent: Wednesday, May 1, 2024 8:53 AM > To: devel@edk2.groups.io > Cc: Dionna Glaze ; Kinney, Michael D > ; Liming Gao ; Liu, > Zhiguang ; Yao, Jiewen ; > Kumar, Rahul R ; Ard Biesheuvel > ; Gerd Hoffmann > Subject: