[edk2-devel] [PATCH v1 10/11] ShellPkg: acpiview: GTDT: Add error-checking in the parsing logic

1. Check if the global pointers (in the scope of this ACPI table parser) have been successfully updated before they are later used to control the parsing logic. 2. Test against buffer overruns. 3. Allow silencing ACPI table content validation errors which do not cause table parsing to fail. 4. R

[edk2-devel] [PATCH v1 11/11] ShellPkg: acpiview: DBG2: Add error-checking in the parsing logic

1. Check if the global pointers (in the scope of this ACPI table parser) have been successfully updated before they are later used to control the parsing logic. 2. Remove redundant forward function declarations by repositioning blocks of code. 3. Test against buffer overruns. 4. Introduce a ACPI

[edk2-devel] [PATCH v1 09/11] ShellPkg: acpiview: IORT: Add error-checking in the parsing logic

1. Check if the global pointers (in the scope of this ACPI table parser) have been successfully updated before they are later used to control the parsing logic. 2. Remove redundant forward function declarations by repositioning blocks of code. 3. Test against buffer overruns. 4. Allow silencing

[edk2-devel] [PATCH v1 08/11] ShellPkg: acpiview: PPTT: Add error-checking in the parsing logic

1. Check if the global pointers (in the scope of this ACPI table parser) have been successfully updated before they are later used to control the parsing logic. 2. Give forward progress guarantee when parsing the PPTT table. Report an error if a PPTT structure is too small to be valid. Without thi

[edk2-devel] [PATCH v1 07/11] ShellPkg: acpiview: MADT: Add error-checking in the parsing logic

1. Check if the global pointers (in the scope of this ACPI table parser) have been successfully updated before they are later used to control the parsing logic. 2. Give forward progress guarantee when parsing the MADT table. Report an error if a MADT structure is too small to be valid. Without thi

[edk2-devel] [PATCH v1 06/11] ShellPkg: acpiview: SRAT: Add error-checking in the parsing logic

1. Check if the global pointers (in the scope of this ACPI table parser) have been successfully updated before they are later used to control the parsing logic. 2. Give forward progress guarantee when parsing the SRAT table. Report an error if a SRAT structure is too small to be valid. Without thi

[edk2-devel] [PATCH v1 01/11] ShellPkg: acpiview: FADT: Validate global pointers before use

1. Check if the global pointer have been successfully updated before they are later used to control the parsing logic in the FADT acpiview parser. 2. Remove redundant forward function declarations by repositioning blocks of code. 3. Allow silencing ACPI table content validation errors which do no

[edk2-devel] [PATCH v1 03/11] ShellPkg: acpiview: RSDP: Make printing table checksum optional

1. Don't validate Root System Description Pointer (RSDP) structure checksum if the '-q' command line flag is used with the acpiview UEFI shell tool. This change makes the RSDP parser consistent with the parsers for other ACPI tables. 2. Check if XsdtAddress pointer has been successfully updated be

[edk2-devel] [PATCH v1 00/11] Add security checks in the Acpiview table parsers

The following patches modify existing ACPI table parsers to add checks which prevent many potential security issues. These include: 1. Entering infinite loops when ACPI structure lengths are zero. 2. Use of pointers which failed to be initialized because of invalid ACPI table/structure lengths. 3.

[edk2-devel] [PATCH v1 04/11] ShellPkg: acpiview: XSDT: Remove redundant ParseAcpi() call

1. Remove a call to ParseAcpi responsible for getting the XSDT table length. This call is not needed because the ACPI table buffer length is provided as an input argument to the ParseAcpiXsdt() function. 2. Use ParseAcpiXsdt function argument instead of a global variable to check against table buf

[edk2-devel] [PATCH v1 02/11] ShellPkg: acpiview: SPCR: Remove redundant forward declaration

Reposition blocks of code to remove redundant forward function declarations in order to reduce the code size. Signed-off-by: Krzysztof Koch --- Changes can be seen at: https://github.com/KrzysztofKoch1/edk2/commit/9be55a64f804c3d99e7c692208c8086d5b9ca553 Notes: v1: - remove redundant f

[edk2-devel] [PATCH v1 05/11] ShellPkg: acpiview: SLIT: Add error-checking in the parsing logic

1. Check if the global pointers (in the scope of this ACPI table parser) have been successfully updated before they are later used to control the parsing logic. 2. Test against buffer overruns. 3. Allow silencing ACPI table content validation errors which do not cause table parsing to fail. 4. C

Re: [edk2-devel] [PATCH v2 6/7] EmbeddedPkg: Fix DwEmmc SendCommand polling

Leif, Some comments inlined. > -Original Message- > From: Loh, Tien Hock > Sent: Tuesday, June 11, 2019 5:12 PM > To: Leif Lindholm > Cc: 'Haojian Zhuang' ; 'devel@edk2.groups.io' > ; 'thlo...@gmail.com' ; 'Ard > Biesheuvel' > Subject: RE: [PATCH v2 6/7] EmbeddedPkg: Fix DwEmmc SendComma

Re: [edk2-devel] [edk2-platforms Patch 26/28] Vlv2TbltDevicePkg: Clean up all build scripts

bld_vlv.sh should probably have "set -e" at the top, like the change to Build_IFWI.sh See https://bugzilla.tianocore.org/show_bug.cgi?id=1599 ("bld_vlv.sh isn't `set -e` and doesn't check if commands completed successfully"). -- Rebecca Cran On 7/10/19 1:05 PM, Michael D Kinney wrote: * R

Re: [edk2-devel] [edk2-platforms Patch 23/28] Vlv2TbltDevicePkg: Import TlsLib for HTTPS Boot

Reviewed-by: Rebecca Cran On 7/10/19 1:05 PM, Michael D Kinney wrote: From: Gary Lin When setting NETWORK_TLS_ENABLE to TRUE, we need TlsLib. Cc: Zailiang Sun Cc: Yi Qian Cc: Michael D Kinney Signed-off-by: Gary Lin --- Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgGccIA32.dsc | 3 +++

Re: [edk2-devel] [edk2-platforms Patch 02/28] Vlv2TbltDevicePkg/Build_IFWI.sh: Change the root directory path

On 2019-07-10 13:04, Michael D Kinney wrote: > echo "Build_IFWI: Calling BIOS build Script..." > -./$PLATFORM_PACKAGE/bld_vlv.sh $Build_Flags $Platform_Type $Build_Target > +./Platform/Intel/$PLATFORM_PACKAGE/bld_vlv.sh $Build_Flags $Platform_Type > $Build_Target It looks like these changes ar

Re: [edk2-devel] [edk2-platforms Patch 01/28] Vlv2TbltDevicePkg/Build_IFWI.sh: Add "set -e" to exit on error

On 2019-07-10 13:04, Michael D Kinney wrote: > +set -e > + Reviewed-by: Rebecca Cran -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43635): https://edk2.groups.io/g/devel/message/43635 Mute This Topic: https://groups

Re: [edk2-devel] [edk2-platforms Patch 18/28] Vlv2TbltDevicePkg/Build_IFWI.sh: Check the WORKSPACE env variable

Reviewed-By: Zailiang Sun -Original Message- From: Kinney, Michael D Sent: Thursday, July 11, 2019 3:05 AM To: devel@edk2.groups.io Cc: Gary Lin ; Sun, Zailiang ; Qian, Yi Subject: [edk2-platforms Patch 18/28] Vlv2TbltDevicePkg/Build_IFWI.sh: Check the WORKSPACE env variable From: Ga

Re: [edk2-devel] [edk2-platforms Patch 23/28] Vlv2TbltDevicePkg: Import TlsLib for HTTPS Boot

Reviewed-By: Zailiang Sun -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Michael D Kinney Sent: Thursday, July 11, 2019 3:05 AM To: devel@edk2.groups.io Cc: Gary Lin ; Sun, Zailiang ; Qian, Yi Subject: [edk2-devel] [edk2-platforms Patch 23/28]

Re: [edk2-devel] [edk2-platforms Patch 00/28] Vlv2TbltDevicePkg: Fix Linux build issues

Reviewed-By: Zailiang Sun -Original Message- From: Kinney, Michael D Sent: Thursday, July 11, 2019 3:05 AM To: devel@edk2.groups.io Cc: Sun, Zailiang ; Qian, Yi ; Gary Lin Subject: [edk2-platforms Patch 00/28] Vlv2TbltDevicePkg: Fix Linux build issues * Update Readme.md for multiple r

Re: [edk2-devel] [edk2-platforms Patch 13/28] Vlv2TbltDevicePkg/AcpiPlatform: Fix the error from InstallAcpiTable

Reviewed-By: Zailiang Sun -Original Message- From: Kinney, Michael D Sent: Thursday, July 11, 2019 3:05 AM To: devel@edk2.groups.io Cc: Gary Lin ; Sun, Zailiang ; Qian, Yi Subject: [edk2-platforms Patch 13/28] Vlv2TbltDevicePkg/AcpiPlatform: Fix the error from InstallAcpiTable From:

Re: [edk2-devel] [edk2-platforms Patch 15/28] Vlv2TbltDevicePkg: Import SD/MMC drivers

Reviewed-By: Zailiang Sun -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Michael D Kinney Sent: Thursday, July 11, 2019 3:05 AM To: devel@edk2.groups.io Cc: Gary Lin ; Sun, Zailiang ; Qian, Yi Subject: [edk2-devel] [edk2-platforms Patch 15/28]

Re: [edk2-devel] [edk2-platforms Patch 14/28] Vlv2TbltDevicePkg/SmBiosMiscDxe: Fix the indentation

Reviewed-By: Zailiang Sun -Original Message- From: Kinney, Michael D Sent: Thursday, July 11, 2019 3:05 AM To: devel@edk2.groups.io Cc: Gary Lin ; Sun, Zailiang ; Qian, Yi Subject: [edk2-platforms Patch 14/28] Vlv2TbltDevicePkg/SmBiosMiscDxe: Fix the indentation From: Gary Lin Fix

Re: [edk2-devel] [edk2-platforms Patch 24/28] Vlv2TbltDevicePkg: Reorganize the libraries

Reviewed-By: Zailiang Sun -Original Message- From: Kinney, Michael D Sent: Thursday, July 11, 2019 3:05 AM To: devel@edk2.groups.io Cc: Gary Lin ; Sun, Zailiang ; Qian, Yi Subject: [edk2-platforms Patch 24/28] Vlv2TbltDevicePkg: Reorganize the libraries From: Gary Lin * Simplify th

Re: [edk2-devel] [edk2-platforms Patch 12/28] Vlv2TbltDevicePkg/AcpiPlatform: Remove a unused variable

Reviewed-By: Zailiang Sun -Original Message- From: Kinney, Michael D Sent: Thursday, July 11, 2019 3:05 AM To: devel@edk2.groups.io Cc: Gary Lin ; Sun, Zailiang ; Qian, Yi Subject: [edk2-platforms Patch 12/28] Vlv2TbltDevicePkg/AcpiPlatform: Remove a unused variable From: Gary Lin

Re: [edk2-devel] [edk2-platforms Patch 11/28] Vlv2TbltDevicePkg/GenerateCapsule: Fix the bash scripts

Reviewed-By: Zailiang Sun -Original Message- From: Kinney, Michael D Sent: Thursday, July 11, 2019 3:05 AM To: devel@edk2.groups.io Cc: Gary Lin ; Sun, Zailiang ; Qian, Yi Subject: [edk2-platforms Patch 11/28] Vlv2TbltDevicePkg/GenerateCapsule: Fix the bash scripts From: Gary Lin A

Re: [edk2-devel] [PATCH 2/3] MdePkg/BaseLib: rewrite Base64Decode()

Sorry for late respond. The whole code is OK for me. And I write a tiny test for it without the memory address check. See https://github.com/ZhichaoGao/edk2/commit/615356ba32d3147957d215debd844e7709f06849 . It is tested in Emulator environment. If it is OK, I think you can take my Tested-by for

[edk2-devel] Upcoming Event: TianoCore Community Meeting - APAC/NAMO - Thu, 07/11/2019 7:30pm-8:00pm #cal-reminder

*Reminder:* TianoCore Community Meeting - APAC/NAMO *When:* Thursday, 11 July 2019, 7:30pm to 8:00pm, (GMT-07:00) America/Los Angeles *Where:* https://zoom.us/j/769108409 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=458030 ) *Organizer:* Stephano Cetola stephano.cet...@intel.c

[edk2-devel] [Patch 0/2] UefiCpuPkg/RegisterCpuFeaturesLib: Avoid AP calls gBS service.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1972 AP calls CollectProcessorData() to collect processor info. CollectProcessorData function finally calls PcdGetSize function to get DynamicPCD PcdCpuFeaturesSetting value. PcdGetSize will use gBS which caused ASSERT. This patch serial fixes t

[edk2-devel] [Patch 2/2] UefiCpuPkg/Library/RegisterCpuFeaturesLib: avoid use dynamic PCD.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1972 Function in this library may be used by APs. Assert will be trig if AP uses dynamic pcd. This patch enhance the current code, remove the unnecessary usage of dynamic PCD. This change try to avoid report this issue again later. Cc: Ray Ni C

[edk2-devel] [Patch 1/2] UefiCpuPkg/RegisterCpuFeaturesLib: Avoid AP calls gBS service.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1972 AP calls CollectProcessorData() to collect processor info. CollectProcessorData function finally calls PcdGetSize function to get DynamicPCD PcdCpuFeaturesSetting value. PcdGetSize will use gBS which caused below assert info: Processor Info:

Re: [edk2-devel] [PATCH] SecurityPkg: Don't Verify the enrolled PK in setup mode

Hi Laszlo: Your investigation makes sense to me. For Keep old logic as an option will be a mild evolution. HI Derek, Would you please update your patch based on Laszlo’s comments? Please don’t forget to CC Laszlo. From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Laszlo

[edk2-devel] Upcoming Event: TianoCore Design Meeting - APAC/NAMO - Thu, 07/11/2019 6:30pm-7:30pm #cal-reminder

*Reminder:* TianoCore Design Meeting - APAC/NAMO *When:* Thursday, 11 July 2019, 6:30pm to 7:30pm, (GMT-07:00) America/Los Angeles *Where:* https://zoom.us/j/969264410 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=460286 ) *Organizer:* Stephano Cetola stephano.cet...@intel.com

Re: [edk2-devel] [Patch v5 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Enable MM MP Protocol

Hi Laszlo, Thanks for your patch and regression test. I will include your change when I push the patches. Thanks, Eric > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, July 12, 2019 1:54 AM > To: devel@edk2.groups.io; Dong, Eric > Cc: Ni, Ray > Subj

[edk2-devel] Upcoming Event: TianoCore Bug Triage - APAC / NAMO - Thu, 07/11/2019 5:00pm-5:30pm #cal-reminder

*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Thursday, 11 July 2019, 5:00pm to 5:30pm, (GMT-07:00) America/Los Angeles *Where:* https://zoom.us/j/251103409 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=460283 ) *Organizer:* Stephano Cetola stephano.cet...@intel.com (

Re: [edk2-devel] [PATCH] PL031: Actually disable interrupts

> Am 11.07.2019 um 19:07 schrieb Laszlo Ersek : > >> On 07/10/19 19:13, Leif Lindholm wrote: >>> On Wed, Jul 10, 2019 at 04:53:11PM +0200, Alexander Graf via Groups.Io >>> wrote: >>> The PL031 interrupt mask register (IMSC) is not very clearly documented >>> in the PL031 specification. However

Re: [edk2-devel] [Patch v5 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Enable MM MP Protocol

Hello Eric, On 07/10/19 09:56, Dong, Eric wrote: > V5 changes: > 1. some small enhancement. > > v4 changes: > 1. Use link list to save the token info. > > v3 changes: > 1. Fix Token clean up too early caused CheckProcedure return error. > > v2 changes: > 1. Remove some duplicated global variables.

Re: [edk2-devel] [PATCH] PL031: Actually disable interrupts

On 07/10/19 19:13, Leif Lindholm wrote: > On Wed, Jul 10, 2019 at 04:53:11PM +0200, Alexander Graf via Groups.Io wrote: >> The PL031 interrupt mask register (IMSC) is not very clearly documented >> in the PL031 specification. However, bit 0 (RTCIMSC) indicates whether >> interrupts are enabled, not

Re: [edk2-devel] GCC compiler version

Hello Liming, On 07/11/19 07:07, Liming Gao wrote: > Hi, all > Recently, I find some failure with the different GCC compiler version. I > want to collect which GCC version are used by you. Now, I use GCC 5.5 for the > verification. It may be a little old. I use multiple GCC* toolchains, with

[edk2-devel] [off-topic] Readme.md: add submodule policy and clone commands

(off-topic, as marked in the subject) On 07/10/19 19:17, Leif Lindholm wrote: > On Wed, Jul 10, 2019 at 05:08:32PM +, Kinney, Michael D wrote: >> Leif, >> >> I think the following command has to be run from the git >> dir that the edk2 repo was cloned into. >> >> $ git submodule update -

Re: [edk2-devel] [PATCH v6 edk2-platforms 1/1] Silicon/Synopsys/Designware/Driver: DwEmacSnpDxe: Add DesignWare EMAC driver

Hi Tzy Way, Nearly there, but please make sure BaseTools/Scripts/PatchCheck.py runs without warnings or errors (there are quite a few still in this version). Building the .dsc using current edk2 fails with 'MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf is not found in packages path' The path needs

Re: [edk2-devel] [Patch v5 1/2] MdePkg: Add new MM MP Protocol definition.

Hi Ray, On 07/11/19 08:42, Ni, Ray wrote: > + MdePkg maintainers > > We need to follow the open source community process to include MdePkg > maintainers for this change review. > > Laszlo, > You are in the Cc list and had given Regression-Tested-By for V3 patch series. > It would be great if you

[edk2-devel] Upcoming Event: TianoCore Community Meeting - EMEA/NAMO - Thu, 07/11/2019 9:00am-10:00am #cal-reminder

*Reminder:* TianoCore Community Meeting - EMEA/NAMO *When:* Thursday, 11 July 2019, 9:00am to 10:00am, (GMT-07:00) America/Los Angeles *Where:* https://zoom.us/j/188375690 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=458033 ) *Organizer:* Stephano Cetola stephano.cet...@intel.

Re: [edk2-devel] [Patch 1/1] BaseTools: Singleton the object to handle build conf file

Yes. it will work after I fix this bug in WorkspaceAutoGen._GetMetaFiles() Here, the code assumes the tools_def.txt and build_rule.txt are always in Conf directory. # # add build_rule.txt & tools_def.txt # AllWorkSpaceMetaFiles.add(os.path.join(GlobalData.gConfDir

Re: [edk2-devel] [Patch 1/1] BaseTools: Singleton the object to handle build conf file

Bob: > -Original Message- > From: Feng, Bob C > Sent: Thursday, July 11, 2019 8:13 PM > To: devel@edk2.groups.io; Feng, Bob C ; Gao, Liming > > Subject: RE: [edk2-devel] [Patch 1/1] BaseTools: Singleton the object to > handle build conf file > > Liming, > > I tested the cases: > 1. m

Re: [edk2-devel] [PATCH] Revert "FmpDevicePkg: Fix various typos"

Revert patch submitted: efa12a3f029bd6ff4d2ada406c285f001b252907 Reapply patch submitted: 91cc60bafc7d6e49b7bc85990f895d6228f51364 Thanks! Chasel > -Original Message- > From: Antoine Cœur [mailto:co...@gmx.fr] > Sent: Thursday, July 11, 2019 5:37 PM > To: devel@edk2.groups.io > Cc: Ant

Re: [edk2-devel] ExtScsiPassThru support for Logical SCSI devices

Hello Ravi Kumar, For: Now the issue is, The same GUID cannot be installed more than once onto the same handle (Controller handle). So to support 2nd instance we need to create new device path (virtual device path) for that. Yes. A new handled is needed for the ExtScsiPassThru protocol logical i

Re: [edk2-devel] [PATCH v2 2/3] MdePkg/BaseLib.h: Update IA32_CR4 structure for 5-level paging

On 07/11/19 05:25, Ni, Ray wrote: > Laszlo, Mike, > Sorry I did violate the process. > I had two assumptions which led me violate the process: > 1. Reviewed-by from UefiCpuPkg maintainers on this IA32_CR4 change is more > important > than that from MdePkg maintainers. In another word, I though

Re: [edk2-devel] [PATCH v2 3/3] UefiCpuPkg/PiSmmCpu: Enable 5 level paging when CPU supports

On 07/11/19 03:19, Ni, Ray wrote: > Mike, > Thanks for raising this build failure. > I just tried in my Ubuntu 18 in Win10. Even GCC7 complains about this. My bad! > I just posted a fix. Thanks -- as I requested there, please do not push this new patch until the revert+reapply completes. Laszlo

Re: [edk2-devel] [PATCH v2 2/3] MdePkg/BaseLib.h: Update IA32_CR4 structure for 5-level paging

On 07/10/19 21:38, Kinney, Michael D wrote: > Laszlo, > > I agree with your feedback. Process must be followed. > > I also agree that it may make sense to add some more maintainers > to the MdePkg, especially for some of the content in MdePkg that > is closely related to the UefiCpuPkg content.

Re: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpu: Fix GCC7/GCC8 build failure

On 07/11/19 12:02, Laszlo Ersek wrote: > Hello Ray, > > On 07/11/19 03:16, Ray Ni wrote: >> Signed-off-by: Ray Ni >> Cc: Michael D Kinney >> Cc: Eric Dong >> Cc: Laszlo Ersek >> --- >> UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff

Re: [edk2-devel] [Patch 1/1] BaseTools: Singleton the object to handle build conf file

Liming, I tested the cases: 1. move tool_def.txt and build_rule.txt from Conf to another folder and update target.txt to set BUILD_RULE_CONF and TOOL_CHAIN_CONF to point to the new folder. 2. Move Conf folder to a new place and Set WORKSPACE to point the parent folder of Conf. Append original W

Re: [edk2-devel] [PATCH v2 2/3] MdePkg/BaseLib.h: Update IA32_CR4 structure for 5-level paging

On 07/11/19 06:05, Ni, Ray wrote: > Laszlo, Mike, > > An update to my revert proposal, I will only revert the below 2 patches: > > 7c5010c7f88b790f4524c4a5311819e3af5e2752 > * MdePkg/BaseLib.h: Update IA32_CR4 structure for 5-level paging > > 7365eb2c8cf1d7112330d09918c0c67e8d0b827a > * UefiCpuP

Re: [edk2-devel] [PATCH] SecurityPkg: Don't Verify the enrolled PK in setup mode

On 07/11/19 05:20, Zhang, Chao B wrote: > HI Laszlo: >There is a discussion over this issue in UEFI Manits > https://mantis.uefi.org/mantis/view.php?id=1983 > The justification lies here: > Spec perspective: > Section 8.2.2 : In SetupMode Secure Boot Policy variables shall consider > s

Re: [edk2-devel] [PATCH V2 2/4] UefiCpuPkg/CpuDxe: Implement Cpu2 protocol

On Thu, Jul 11, 2019 at 12:24:46PM +0200, Laszlo Ersek wrote: > Every single source file must have both copyright notice(s) and > licensing information. > > - Licensing information without copyright holder(s) makes zero sense -- > the licensing terms are offered / dictated *by* the copyright holde

Re: [edk2-devel] [PATCH V2 2/4] UefiCpuPkg/CpuDxe: Implement Cpu2 protocol

On 07/11/19 04:36, Gao, Zhichao wrote: > > >> -Original Message- >> From: Dong, Eric >> Sent: Thursday, July 11, 2019 10:22 AM >> To: Gao, Zhichao ; devel@edk2.groups.io >> Cc: Sean Brogan ; Ni, Ray ; >> Laszlo Ersek ; Gao, Liming ; >> Michael Turner ; Bret Barkelew >> >> Subject: RE: [P

Re: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpu: Fix GCC7/GCC8 build failure

Hello Ray, On 07/11/19 03:16, Ray Ni wrote: > Signed-off-by: Ray Ni > Cc: Michael D Kinney > Cc: Eric Dong > Cc: Laszlo Ersek > --- > UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c > b/

Re: [edk2-devel] [PATCH] Revert "FmpDevicePkg: Fix various typos"

Reviewed-by: Chasel Chiu > -Original Message- > From: Antoine Cœur [mailto:co...@gmx.fr] > Sent: Thursday, July 11, 2019 5:37 PM > To: devel@edk2.groups.io > Cc: Antoine Cœur ; Zeng, Star ; Chiu, > Chasel > Subject: [PATCH] Revert "FmpDevicePkg: Fix various typos" > > This reverts com

[edk2-devel] [PATCH] Revert "FmpDevicePkg: Fix various typos"

This reverts commit f527942e6bdd9f198db90f2de99a0482e9be5b1b. Commit message was incorrect. Signed-off-by: Coeur --- .../FspSecCore/Ia32/FspApiEntryM.nasm | 4 +-- .../FspSecCore/Ia32/InitializeFpu.nasm| 4 +-- .../FspSecCore/Ia32/SaveRestoreSseNasm.inc| 4 +-- IntelFsp2Pk

Re: [edk2-devel] [Patch 1/1] BaseTools: Singleton the object to handle build conf file

Liming, Thanks for your comments. I'll test the cases you mentioned. Thanks, Bob -Original Message- From: Gao, Liming Sent: Thursday, July 11, 2019 5:11 PM To: Feng, Bob C ; devel@edk2.groups.io Subject: RE: [Patch 1/1] BaseTools: Singleton the object to handle build conf file Bob:

[edk2-devel] [Patch 1/1] BaseTools: Split WorkspaceAutoGen._InitWorker into multiple functions

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 The WorkspaceAutoGen.__InitWorker function is too long, it's hard to read and understand. This patch is to separate the __InitWorker into multiple small ones. Cc: Liming Gao Signed-off-by: Bob Feng --- BaseTools/Source/Python/AutoGen/Auto

Re: [edk2-devel] [PATCH] Revert "FmpDevicePkg: Fix various typos" + Reapply as "IntelFsp2Pkg: Fix various typos"

Coeur: Please use git send-email to send those patches. And, Signed-off-by: Cœur . Can you change it Signed-off-by: Coeur with Ascii char only? Thanks Liming From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of C?ur Sent: Thursday,

Re: [edk2-devel] [Patch 1/1] BaseTools: Singleton the object to handle build conf file

Bob: target.txt is from Conf directory. build_rule.txt and tools_def.txt are specified in target.txt. Please take care this case that they may have the different file name. And, Conf directory is relative to WORKSPACE and PACKAGES_PATH. Does this patch support it? Thanks Liming >-Orig

[edk2-devel] [PATCH] Revert "FmpDevicePkg: Fix various typos" + Reapply as "IntelFsp2Pkg: Fix various typos"

Two patches attached: 1. revert f527942e6bdd9f198db90f2de99a0482e9be5b1b, because the commit message was incorrect. 2. reapply it with a correct commit message. If you apply both patches, the balance of changes should be zero (except for the commit messages). Sorry for the confusion. Coeur -

Re: [edk2-devel] [Patch 0/7] Revert new added BfmLib/FCE/FMMT

On Thu, Jul 11, 2019 at 09:44:33AM +0800, Liming Gao wrote: > Rewrite those tools for review again. > Now, move them into edk2-staging/FceFmmt branch. > > Cc: Leif Lindholm > Cc: Feng Bob C Thanks for this. For the series: Reviewed-by: Leif Lindholm > Liming Gao (7): > Revert "BaseTools/FCE

Re: [edk2-devel] [edk2-platforms: PATCH] Marvell/Drivers: XenonDxe: Explicitly disable HS400

On Thu, Jul 11, 2019 at 10:07:27AM +0200, Marcin Wojtas wrote: > Hi Leif, > > śr., 26 cze 2019 o 11:58 Marcin Wojtas napisał(a): > > > > Hi Leif, > > > > śr., 26 cze 2019 o 11:31 Leif Lindholm > > napisał(a): > > > > > > On Wed, Jun 26, 2019 at 09:04:14AM +0200, Marcin Wojtas wrote: > > > >

Re: [edk2-devel] [Patch] ShellPkg/AcpiView: Fix IA32 link error

Hi Mike, Since LocalityCount is 64-bit wide the SLIT validation code could possibly end up in an infinite loop. I am not aware of a platform that has a large enough LocalityCount to hit this condition. However, would it be good to have a check that limits the validation to MAX_UINT32? e.g. Som

Re: [edk2-devel] [edk2-platforms: PATCH] Marvell/Drivers: XenonDxe: Explicitly disable HS400

Hi Leif, śr., 26 cze 2019 o 11:58 Marcin Wojtas napisał(a): > > Hi Leif, > > śr., 26 cze 2019 o 11:31 Leif Lindholm napisał(a): > > > > On Wed, Jun 26, 2019 at 09:04:14AM +0200, Marcin Wojtas wrote: > > > Ensure that in case of SlowMode or 3.3V operation, > > > also the HS400 capability will be