CC the maintainers.
This is only a small subset of all the spelling/typo issues from MdeModulePkg.
But I don't want to overload you with too much to review, so I'll only post one MdeModulePkg batch at a time.
Coeur
Gesendet: Samstag, 13. Juli 2019 um 12:57 Uhr
Von: "Antoine Cœur"
An:
Fix various typos in MdeModulePkg.
Signed-off-by: Coeur
---
.../Application/CapsuleApp/CapsuleApp.c | 2 +-
.../Application/CapsuleApp/CapsuleDump.c | 6 ++---
.../PlatformVarCleanupLib/PlatVarCleanupLib.c | 10 +++
MdeModulePkg/MdeModulePkg.dec | 26 +---
Mike, That make sense for me. /Zailiang
-Original Message-
From: Kinney, Michael D
Sent: Saturday, July 13, 2019 7:42 AM
To: devel@edk2.groups.io; g...@suse.com; Sun, Zailiang
; Kinney, Michael D
Cc: Qian, Yi
Subject: RE: [edk2-devel] [edk2-platforms Patch 10/28]
Vlv2TbltDevicePkg/bld
Add "set -e" to postbuild scripts to cause them to exit if an error
occurs.
Since GenCapsuleSampleColor.sh is passed arguments, it should be run
directly and not sourced into the environment so it can evaluate $1, $2
etc. Otherwise, it tries to use the toolchain name passed to 'build' as
the GUID
I tested this patch on python2.7 and 3.7. It works fine.
Reviewed-by: Bob Feng
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Saturday, July 13, 2019 5:03 AM
To: Cole Robinson ; devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming
Subject: Re: [PATCH] BaseTools: F
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1781
GITHUB: https://github.com/idesai/edk2/tree/enable_sm3_measured_boot_v6
EDK2 Support for SM3 digest algorithm is needed to enable TPM with SM3 PCR
banks. This digest algorithm is part of the China Crypto algorithm suite.
This integration has
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1781
GITHUB: https://github.com/idesai/edk2/tree/enable_sm3_measured_boot_v6
EDK2 Support for SM3 digest algorithm is needed to enable TPM with SM3 PCR
banks. This digest algorithm is part of the China Crypto algorithm suite.
This integration has
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1781
GITHUB: https://github.com/idesai/edk2/tree/enable_sm3_measured_boot_v6
EDK2 Support for SM3 digest algorithm is needed to enable TPM with SM3 PCR
banks. This digest algorithm is part of the China Crypto algorithm suite.
This integration has
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1781
GITHUB: https://github.com/idesai/edk2/tree/enable_sm3_measured_boot_v6
EDK2 Support for SM3 digest algorithm is needed to enable TPM with SM3 PCR
banks. This digest algorithm is part of the China Crypto algorithm suite.
This integration has
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1781
GITHUB: https://github.com/idesai/edk2/tree/enable_sm3_measured_boot_v6
EDK2 Support for SM3 digest algorithm is needed to enable TPM with SM3 PCR
banks. This digest algorithm is part of the China Crypto algorithm suite.
This integration has
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1781
GITHUB: https://github.com/idesai/edk2/tree/enable_sm3_measured_boot_v6
EDK2 Support for SM3 digest algorithm is needed to enable TPM with SM3 PCR
banks. This digest algorithm is part of the China Crypto algorithm suite.
This integration has
For all patches in this series authored by Gary Lin
Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io]
> On Behalf Of Michael D Kinney
> Sent: Wednesday, July 10, 2019 12:05 PM
> To: devel@edk2.groups.io
> Cc: Sun, Zailian
Zailiang,
This appears to be the behavior of GIT when the Author of
a patch is not the same as the person who sends the patch
email. The "From:" line is shows the Author of the patch
and is used to fill in the Author field when the patch
email is applied to a git repo. So no edits to the commit
On 07/12/19 19:01, Leif Lindholm wrote:
> Add a new script GetMaintainer.py that uses the new Maintainer.txt format
> to determine which addresses to cc on patch submission.
>
> Signed-off-by: Leif Lindholm
> Reviewed-by: Philippe Mathieu-Daude
> Tested-by: Philippe Mathieu-Daude
> ---
> BaseT
On 07/12/19 19:01, Leif Lindholm wrote:
> Changes are available directly from:
> https://git.linaro.org/people/leif.lindholm/edk2.git/log/?h=upstreaming/git-maintainer-v1
>
> This series adds new tags to the Maintainers.txt format, making it possible
> to describe which filesystem paths are looked
On 07/12/19 19:01, Leif Lindholm wrote:
> Add Ard and Leif as responsible for any path matching
> F: */Arm/
> F: */AArch64/
>
> Signed-off-by: Leif Lindholm
> Reviewed-by: Philippe Mathieu-Daude
> Tested-by: Philippe Mathieu-Daude
> ---
> Maintainers.txt | 8
> 1 file changed, 8 inser
On 07/12/19 19:01, Leif Lindholm wrote:
> Add comment describing new F: and X: tags for associating maintainership
> sections with specific filesystem paths, including wildcards.
>
> Add global section associating *all* code with devel@edk2.groups.io,
> with a default '*' F: tag directing all modi
Hi,
On 07/10/19 23:17, Rebecca Cran wrote:
> o Use '$SCRIPTNAME' consistently instead of 'edksetup.sh'
>
> o Use the bash environment variable $PWD instead of executing the pwd
> command.
>
> o Add quotes around variables to ensure they're evaluated correctly.
>
> o Simplify SetupPython3() an
On 07/12/19 03:53, Eric Dong wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1972
>
> AP calls CollectProcessorData() to collect processor info.
> CollectProcessorData function finally calls PcdGetSize function to
> get DynamicPCD PcdCpuFeaturesSetting value. PcdGetSize will use gBS
>
On 07/12/19 12:12, Star Zeng wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1961
> Enhance Ppin code to enable and unlock for TRUE State,
> and disable and lock for FALSE State.
> Note: enable and lock could not be set both.
>
> Cc: Laszlo Ersek
> Cc: Eric Dong
> Cc: Ray Ni
> Cc: C
On 06/10/19 14:32, Ravi Kumar Siadri wrote:
> Hi all,
>
> I have couple of queries regarding the
> EFI_EXT_SCSI_PASS_THRU_ATTRIBUTES_LOGICAL attribute support in
> EFI_EXT_SCSI_PASS_THRU_PROTOCOL.
>
> 1.
> The Attributes field of the EFI_EXT_SCSI_PASS_THRU_PROTOCOL interface
> tells if the interfac
On 07/12/19 19:29, Cole Robinson wrote:
> Building with python3.8 shows a warning like:
>
> SyntaxWarning: invalid escape sequence \(
> GuidName = re.compile("\(GUID=[-a-fA-F0-9]+")
>
> It seems harmless, but it's easy enough to fix: mark the string as
> raw with the 'r' prefix like is used els
Since .uni files are Unicode and git treats them as binary, I've pushed
my change to a fork on GitHub: it's at
https://github.com/bcran/edk2-platforms/commit/7c914946bd014dc1f3cf0a0ef189e7c2d33d382f
.
The current/latest E3900 builds use UEFI 2.70 while the Platform Setup
screen still reports "Cor
On 07/12/19 04:31, Gao, Zhichao wrote:
> Sorry for late respond.
> The whole code is OK for me. And I write a tiny test for it without the
> memory address check. See
> https://github.com/ZhichaoGao/edk2/commit/615356ba32d3147957d215debd844e7709f06849
> . It is tested in Emulator environment. If
Building with python3.8 shows a warning like:
SyntaxWarning: invalid escape sequence \(
GuidName = re.compile("\(GUID=[-a-fA-F0-9]+")
It seems harmless, but it's easy enough to fix: mark the string as
raw with the 'r' prefix like is used elsewhere in the file
Signed-off-by: Cole Robinson
---
Add a new script GetMaintainer.py that uses the new Maintainer.txt format
to determine which addresses to cc on patch submission.
Signed-off-by: Leif Lindholm
Reviewed-by: Philippe Mathieu-Daude
Tested-by: Philippe Mathieu-Daude
---
BaseTools/Scripts/GetMaintainer.py | 190
Add comment describing new F: and X: tags for associating maintainership
sections with specific filesystem paths, including wildcards.
Add global section associating *all* code with devel@edk2.groups.io,
with a default '*' F: tag directing all modifications that do not hit a
rule to the stewards.
Add Ard and Leif as responsible for any path matching
F: */Arm/
F: */AArch64/
Signed-off-by: Leif Lindholm
Reviewed-by: Philippe Mathieu-Daude
Tested-by: Philippe Mathieu-Daude
---
Maintainers.txt | 8
1 file changed, 8 insertions(+)
diff --git a/Maintainers.txt b/Maintainers.txt
ind
Changes are available directly from:
https://git.linaro.org/people/leif.lindholm/edk2.git/log/?h=upstreaming/git-maintainer-v1
This series adds new tags to the Maintainers.txt format, making it possible
to describe which filesystem paths are looked after by which people, and
hence automating the e
On 2019-07-12 10:23, Michael D Kinney wrote:
> Hi Rebecca,
>
> Vlv2 is already in edk2-platforms/master. This patch series is fixing some
> Linux/GCC build issues.
>
> I have a few more queued up after this to make it even better by
> removing the use of the FCE tool in the build script.
Oh, th
Hi Rebecca,
Vlv2 is already in edk2-platforms/master. This patch series is fixing some
Linux/GCC build issues.
I have a few more queued up after this to make it even better by
removing the use of the FCE tool in the build script.
Mike
> -Original Message-
> From: Rebecca Cran [mailto:
On 2019-07-10 15:17, Rebecca Cran wrote:
> o Use '$SCRIPTNAME' consistently instead of 'edksetup.sh'
>
> o Use the bash environment variable $PWD instead of executing the pwd
> command.
>
> o Add quotes around variables to ensure they're evaluated correctly.
>
> o Simplify SetupPython3() and Setu
I think it would be easier to see/review these changes logically if the
functional changes (1 and 3) were separate from the refactoring change (2).
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Krzysztof Koch [mailto:krzysztof.k...@arm.com]
> Sent: Thursday, July 11, 2019 11:53
I am anxiously waiting for the review comments.
Thanks
Ashraf
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Javeed,
> Ashraf
> Sent: Friday, July 5, 2019 4:42 PM
> To: Ni, Ray ; Gao, Liming ;
> devel@edk2.groups.io; ler...@redhat.com
> Cc: Kinney, Michael D
> Subject: Re
Push @a79841a0244ab2afd1efc3b9d4cc91e27fa90d71
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Liming
> Gao
> Sent: Tuesday, July 9, 2019 2:26 PM
> To: Yao, Jiewen ; Lu, XiaoyuX ;
> devel@edk2.groups.io
> Cc: Feng, Bob C
> Subject: Re: [edk2-
Push @43622317c67f031f9b2e33c3320f2c89484bd506
From: Cœur [mailto:co...@gmx.fr]
Sent: Tuesday, July 9, 2019 1:08 AM
To: Gao; Gao, Liming ; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] FmpDevicePkg: Fix various typos
On Mon, Jul 8, 2019 at 09:21 AM, Liming Gao wrote:
Please add Signed-of
4 comments are added inline.
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Dong, Eric
> Sent: Friday, July 12, 2019 9:53 AM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Laszlo Ersek ; Kumar,
> Chandana C ; Zeng, Star
>
> Subject: [edk2-devel]
Some minor comments inline.
> -Original Message-
> From: Dong, Eric
> Sent: Friday, July 12, 2019 9:53 AM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Laszlo Ersek ; Kumar,
> Chandana C ; Zeng, Star
>
> Subject: [Patch 1/2] UefiCpuPkg/RegisterCpuFeaturesLib: Avoid AP calls gBS
> service.
"
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1961
Enhance Ppin code to enable and unlock for TRUE State,
and disable and lock for FALSE State.
Note: enable and lock could not be set both.
Cc: Laszlo Ersek
Cc: Eric Dong
Cc: Ray Ni
Cc: Chandana Kumar
Cc: Kevin Li
Signed-off-by: Star Zeng
Push @2d100d1d73a9f9a38f224e87c48276ba1e84d8ce
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Liming
> Gao
> Sent: Thursday, July 11, 2019 2:54 PM
> To: devel@edk2.groups.io; Feng, Bob C
> Subject: Re: [edk2-devel] [Patch 1/1] BaseTools: Fixe
40 matches
Mail list logo
