Re: [edk2-devel] Cancelled Event: TianoCore Design / Bug Triage - EMEA - Wednesday, 17 July 2019 #cal-cancelled

There were no design submissions and the list of bugs to triage is small, so we will be able to get to all of them on Thursday's meeting. Canceling this one. Cheers, Stephano -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43845):

[edk2-devel] Cancelled Event: TianoCore Design / Bug Triage - EMEA - Wednesday, 17 July 2019 #cal-cancelled

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCEL CALSCALE:GREGORIAN BEGIN:VEVENT STATUS:CANCELLED UID:calendar.15...@groups.io DTSTAMP:20190717T051444Z ORGANIZER;CN=Stephano Cetola:mailto:stephano.cet...@linux.intel.com

[edk2-devel] [edk2-test][PATCH] Adding HII to IHVSCT

From: shrishailp <50140165+shrisha...@users.noreply.github.com> Adding HII to IHVSCT --- uefi-sct/SctPkg/CommonGenFramework.bat| 2 +- uefi-sct/SctPkg/CommonGenFramework.sh | 2 +- uefi-sct/SctPkg/Config/Data/Category.ini | 7 + .../HIIConfigAccess/BlackBoxTest/Guid.c

Re: [edk2-devel] [Patch v3 2/2] UefiCpuPkg/RegisterCpuFeaturesLib: avoid use dynamic PCD.

Reviewed-by: Ray Ni > -Original Message- > From: Zeng, Star > Sent: Wednesday, July 17, 2019 11:40 AM > To: Dong, Eric ; devel@edk2.groups.io > Cc: Ni, Ray ; Laszlo Ersek ; Kumar, > Chandana C ; Zeng, Star > > Subject: RE: [Patch v3 2/2] UefiCpuPkg/RegisterCpuFeaturesLib: avoid use >

Re: [edk2-devel] [Patch v3 2/2] UefiCpuPkg/RegisterCpuFeaturesLib: avoid use dynamic PCD.

Reviewed-by: Star Zeng > -Original Message- > From: Dong, Eric > Sent: Wednesday, July 17, 2019 9:59 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Laszlo > Ersek ; Kumar, Chandana C > ; Zeng, Star > Subject: [Patch v3 2/2] UefiCpuPkg/RegisterCpuFeaturesLib: avoid use >

Re: [edk2-devel] [edk2-test][PATCH] Adding HII to IHVSCT

Hi Shrishail, Thank you for the patch for adding HiiConfigAccess to IHV SCT. Two comments below are about the patch format. They can be caught by edk2\BaseTools\Scripts\PatchCheck.py 1) The commit message format is not valid: * Missing Signed-off-by! (Note: this must be added by the code

Re: [edk2-devel] [PATCH] UefiCpuPkg DxeRegisterCpuFeaturesLib: Fix VS2012 build failure

Reviewed-by: Eric Dong > -Original Message- > From: Zeng, Star > Sent: Wednesday, July 17, 2019 11:23 AM > To: devel@edk2.groups.io > Cc: Zeng, Star ; Laszlo Ersek ; > Dong, Eric ; Ni, Ray ; Bi, Dandan > > Subject: [PATCH] UefiCpuPkg DxeRegisterCpuFeaturesLib: Fix VS2012 build > failure

Re: [edk2-devel] [PATCH 1/1] edksetup.sh: rework python executable scanning

Leif: I agree to discuss the behavior first, then review the code logic in detail. I add my comments below. > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Wednesday, July 17, 2019 6:05 AM > To: Laszlo Ersek > Cc: devel@edk2.groups.io; Rebecca

[edk2-devel] [PATCH] UefiCpuPkg DxeRegisterCpuFeaturesLib: Fix VS2012 build failure

The new VS2012 build failure is caused by 7a0df26. xxx\registercpufeatureslib\dxeregistercpufeatureslib.c(258) : warning C4701: potentially uninitialized local variable 'MpEvent' used It is a false positive alarm. MpEvent is assigned at line 238 and will be used at line 258, both lines are

Re: [edk2-devel] [PATCH v4 1/6] edksetup.sh: Use bash variable $PWD instead of executing pwd command

Rebecca: The change is good. Reviewed-by: Liming Gao for 1-4, and 6. For patch 5, I see Leif sends another version update. I will give the comments on his change. Thanks Liming > -Original Message- > From: Rebecca Cran [mailto:rebe...@bsdio.com] > Sent: Wednesday, July 17, 2019

[edk2-devel] FW:[edk2-test][PATCH] Adding HII to IHVSCT

Forward to devel@edk2.groups.io with public review. -Original Message- From: shrishail Sent: Friday, July 12, 2019 5:47 PM To: Jin, Eric Cc: shrishailp <50140165+shrisha...@users.noreply.github.com> Subject: [PATCH] Adding HII to IHVSCT From: shrishailp

[edk2-devel] [Patch v3 1/2] UefiCpuPkg/RegisterCpuFeaturesLib: Avoid AP calls PeiServices table.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1972 AP calls CollectProcessorData() to collect processor info. CollectProcessorData function finally calls PcdGetSize function to get DynamicPCD PcdCpuFeaturesSetting value. PcdGetSize will use PeiServices table which caused below assert info:

[edk2-devel] [Patch v3 2/2] UefiCpuPkg/RegisterCpuFeaturesLib: avoid use dynamic PCD.

From: "Dong, Eric" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1972 Function in this library may be used by APs. Assert will be trig if AP uses dynamic pcd. This patch enhance the current code, remove the unnecessary usage of dynamic PCD. This change try to avoid report this issue again

[edk2-devel] [Patch v3 0/2] UefiCpuPkg/RegisterCpuFeaturesLib: Avoid AP calls PeiServices table

V3 Changes: 1. Remove IsCpuFeatureMatch function. V2 Changes: 1. Revert IsBitMaskMatchCheck change which is not correct. 2. refine some variable name. v1 changes: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1972 AP calls CollectProcessorData() to collect processor info.

Re: [edk2-devel] [RFC] Fine-grained review ownership for MdeModulePkg

> -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Tuesday, July 16, 2019 9:53 PM > To: Wu, Hao A > Cc: r...@edk2.groups.io; devel@edk2.groups.io; Andrew Fish; Laszlo Ersek; > Kinney, Michael D; Wang, Jian J; Ni, Ray; Zeng, Star > Subject: Re: [edk2-devel]

[edk2-devel] [PATCH v1 0/1] Maintainers.txt: Review ownership for MdeModulePkg

This patch is also available at: https://github.com/hwu25/edk2/tree/mdemodulepkg_reviewers Also, please note that on the above branch, the proposed patch (MdeModulePkg reviewers) is inserted between: * [edk2-devel] [PATCH 4/4] Maintainers.txt: split out section "OvmfPkg: CSM modules" (from

[edk2-devel] [PATCH v1 1/1] Maintainers.txt: Fine-grained review ownership for MdeModulePkg

This commit add the reviewers information for modules within MdeModulePkg. For now the modules list includes: ACPI BDS Console and Graphic Core services (PEI, DXE and Runtime) Device and Peripheral Firmware Update HII and UI Reset S3 SMBIOS SMM Variable Please note that, for MdeModulePkg

Re: [edk2-devel] [PATCH] MdePkg/BaseLib: Base64Decode(): don't declare variables in nested blocks

Reviewed-by: Liming Gao > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, July 17, 2019 6:59 AM > To: edk2-devel-groups-io > Cc: Gao, Liming ; Kinney, Michael D > ; Philippe Mathieu-Daudé > ; Gao, Zhichao > Subject: [PATCH] MdePkg/BaseLib:

Re: [edk2-devel] [PATCH] MdePkg/BaseLib: Base64Decode(): don't declare variables in nested blocks

On 2019-07-16 16:59, Laszlo Ersek wrote: > > Hoist such variable declarations in Base64Decode() to the outermost > function scope. > > Cc: Liming Gao > Cc: Michael D Kinney > Cc: Philippe Mathieu-Daudé > Cc: Zhichao Gao > Fixes: 35e242b698cdc6205e99a6d6a188bf27fecf9fb4 > Ref:

[edk2-devel] [PATCH] MdePkg/BaseLib: Base64Decode(): don't declare variables in nested blocks

The EDK II C Coding Standards Specification (v2.20) strongly discourages variable declarations in nested block scope: 5 Source Files 5.4 Code File Structure 5.4.1 Scoping Rules 5.4.1.1 Scope > Block (local) Scope > > [...] > > Data declarations may follow the opening brace of a

Re: [edk2-devel] [PATCH 4/4] Maintainers.txt: split out section "OvmfPkg: CSM modules"

On Tue, 2019-07-16 at 22:55 +0200, Laszlo Ersek wrote: > something must have gone wrong -- I don't see your message in my list > folder, and I haven't received a moderation request either. Do you have > an idea why your message may not have reached the list, or been > reflected by the list? > >

Re: [edk2-devel] [PATCH 1/1] edksetup.sh: rework python executable scanning

On Tue, Jul 16, 2019 at 10:49:03PM +0200, Laszlo Ersek wrote: > Hi Leif, > > On 07/16/19 21:07, Leif Lindholm wrote: > > If PYTHON_COMMAND is set, use that. > > If PYTHON_COMMAND is not set, use first working of "python", "python3", > > "python2". > > If none of those work, search the path for

Re: [edk2-devel] [PATCH 0/3] MdePkg, OvmfPkg: rewrite Base64Decode(), clean up call site

On 07/02/19 12:28, Laszlo Ersek wrote: > Repo: https://github.com/lersek/edk2.git > Branch: base64_decode_bz1891 > > Base64Decode() has a number of issues; see > > - > > - and the mailing list discussion linked from >

Re: [edk2-devel] [PATCH 4/4] Maintainers.txt: split out section "OvmfPkg: CSM modules"

Hi David, On 07/15/19 19:08, David Woodhouse wrote: > On Mon, 2019-07-15 at 19:07 +0200, Philippe Mathieu-Daudé wrote: >> On 7/15/19 7:04 PM, Laszlo Ersek wrote: >>> We ask contributors to copy David on patches that affect "CSM modules" >>> under OvmfPkg. With the "GetMaintainer.py" script being

Re: [edk2-devel] [PATCH 1/1] edksetup.sh: rework python executable scanning

Hi Leif, On 07/16/19 21:07, Leif Lindholm wrote: > If PYTHON_COMMAND is set, use that. > If PYTHON_COMMAND is not set, use first working of "python", "python3", > "python2". > If none of those work, search the path for python*[0-9], using the highest > version > number across x.y.z format. > >

Re: [edk2-devel] [PATCH 1/1] edksetup.sh: rework python executable scanning

On 2019-07-16 13:07, Leif Lindholm wrote: > +EXECUTABLE=`basename $file` > +VERSION=`echo $EXECUTABLE | sed 's/[^0-9.]//g'` > + > +MAJOR=`echo $VERSION | sed 's/\([0-9]*\)\.*.*/\1/'` > +MINOR=`echo $VERSION | sed 's/[0-9]*\.*\([0-9]*\).*/\1/'` > +PATCH=`echo

[edk2-devel] [PATCH 1/1] edksetup.sh: rework python executable scanning

If PYTHON_COMMAND is set, use that. If PYTHON_COMMAND is not set, use first working of "python", "python3", "python2". If none of those work, search the path for python*[0-9], using the highest version number across x.y.z format. Finally, set PYTHON3_ENABLE if selected python is python 3.

Re: [edk2-devel] [PATCH 1/3] MdePkg/BaseLib: re-specify Base64Decode(), and add temporary stub impl

On 07/16/19 16:59, Philippe Mathieu-Daudé wrote: > On 7/16/19 4:14 PM, Laszlo Ersek wrote: >> On 07/16/19 11:41, Philippe Mathieu-Daudé wrote: >>> Hi Laszlo, >>> >>> On 7/16/19 10:38 AM, Philippe Mathieu-Daudé wrote: On 7/2/19 12:28 PM, Laszlo Ersek wrote: > Rewrite Base64Decode() from

Re: [edk2-devel] [PATCH v4 5/6] edksetup.sh: Simplify SetupPython3 and SetupPython functions.

On 07/16/19 18:55, Rebecca Cran wrote: > On Linux, "whereis" matches python3, python3.7, as well as > man pages, libs etc. While on macOS it only matches the specified > name, and so misses python3.7. Improve this by looping over > potential version numbers and seeing if such a binary exists and

Re: [edk2-devel] [PATCH v6 edk2-platforms 1/1] Silicon/Synopsys/Designware/Driver: DwEmacSnpDxe: Add DesignWare EMAC driver

Hi Tzy Way, On Tue, Jul 16, 2019 at 09:37:38AM +, Ooi, Tzy Way wrote: > I am new to the compilation tools. May I know if you can share to me > how to run the compilation with Debian's gcc 8.3 so that I can see > the same warning described below? Currently, I am using linaro > toolchain 7.2.1

Re: [edk2-devel] [PATCH 1/4] Maintainers.txt: split out section "ArmVirtPkg: modules used on Xen"

Hi, On 15/07/2019 18:04, Laszlo Ersek wrote: We ask contributors to copy Julien on patches that affect "Xen modules" under ArmVirtPkg. With the "GetMaintainer.py" script being introduced later, express this expectation in "Maintainers.txt" in machine-readable format. Cc: Andrew Fish Cc: Ard

Re: [edk2-devel] [PATCH V2] ShellPkg/Type.c: Add value check before (LoopVar - 1)

Reviewed-by: Andrew Fish Thanks, Andrew Fish > On Jul 16, 2019, at 9:58 AM, Carsey, Jaben wrote: > > Reviewed-by: Jaben Carsey > > > Thanks > -Jaben > >> -Original Message- >> From: Gao, Zhichao >> Sent: Tuesday, July 16, 2019 2:12 AM >> To:

Re: [edk2-devel] [PATCH 1/3] MdePkg/BaseLib: re-specify Base64Decode(), and add temporary stub impl

On 07/16/19 16:56, Gao, Liming wrote: > Laszlo: > Yes. Patch 1 & Patch 2 in MdePkg are both good to me. I have no other > comments. Reviewed-by: Liming Gao Many thanks! Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43809):

Re: [edk2-devel] [PATCH V2] ShellPkg/Type.c: Add value check before (LoopVar - 1)

Reviewed-by: Jaben Carsey Thanks -Jaben > -Original Message- > From: Gao, Zhichao > Sent: Tuesday, July 16, 2019 2:12 AM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; > Andrew Fish > Subject: [PATCH V2] ShellPkg/Type.c: Add value check before (LoopVar - 1) > > REF:

[edk2-devel] [PATCH v4 2/6] edksetup.sh: Use $SCRIPTNAME consistently instead of 'edksetup.sh'

Signed-off-by: Rebecca Cran Reviewed-by: Laszlo Ersek Reviewed-by: Leif Lindholm --- edksetup.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/edksetup.sh b/edksetup.sh index ab58fe4a6e..752e47e7cb 100755 --- a/edksetup.sh +++ b/edksetup.sh @@ -49,11 +49,11 @@

[edk2-devel] [PATCH v4 5/6] edksetup.sh: Simplify SetupPython3 and SetupPython functions.

On Linux, "whereis" matches python3, python3.7, as well as man pages, libs etc. While on macOS it only matches the specified name, and so misses python3.7. Improve this by looping over potential version numbers and seeing if such a binary exists and can be executed. Signed-off-by: Rebecca Cran

[edk2-devel] [PATCH v4 1/6] edksetup.sh: Use bash variable $PWD instead of executing pwd command

This is a (very minor) optimization: `pwd` runs the command (even as a built-in), whereas $PWD simply evaluates the value of the variable. ALso, modern scripts should generally use $(...) to run commands, instead of `...`. Signed-off-by: Rebecca Cran Reviewed-by: Laszlo Ersek Reviewed-by: Leif

[edk2-devel] [PATCH v4 6/6] edksetup.sh: Add quotes and explicit checks in test statements

There are unquoted variables that remain: only the ones considered most important to fix (in terms of potential bugs) were changed in this commit. Signed-off-by: Rebecca Cran Reviewed-by: Laszlo Ersek Reviewed-by: Leif Lindholm --- edksetup.sh | 4 ++-- 1 file changed, 2 insertions(+), 2

[edk2-devel] [PATCH v3 1/6] edksetup.sh: Use bash variable $PWD instead of executing pwd command

This is a (very minor) optimization: `pwd` runs the command (even as a built-in), whereas $PWD simply evaluates the value of the variable. ALso, modern scripts should generally use $(...) to run commands, instead of `...`. Signed-off-by: Rebecca Cran Reviewed-by: Laszlo Ersek --- edksetup.sh

[edk2-devel] [PATCH v3 4/6] edksetup.sh: remove redundant -?, -h and --help in options parsing

Signed-off-by: Rebecca Cran Reviewed-by: Laszlo Ersek --- edksetup.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/edksetup.sh b/edksetup.sh index 76c8d7916e..06d2f041e6 100755 --- a/edksetup.sh +++ b/edksetup.sh @@ -194,7 +194,7 @@ do RECONFIG=TRUE shift

[edk2-devel] [PATCH v3 2/6] edksetup.sh: Use $SCRIPTNAME consistently instead of 'edksetup.sh'

Signed-off-by: Rebecca Cran Reviewed-by: Laszlo Ersek --- edksetup.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/edksetup.sh b/edksetup.sh index ab58fe4a6e..752e47e7cb 100755 --- a/edksetup.sh +++ b/edksetup.sh @@ -49,11 +49,11 @@ function SetWorkspace() return

[edk2-devel] [PATCH v3 3/6] edksetup.sh: when executing arithmetic commands, $ isn't needed

Signed-off-by: Rebecca Cran Reviewed-by: Laszlo Ersek --- edksetup.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/edksetup.sh b/edksetup.sh index 752e47e7cb..76c8d7916e 100755 --- a/edksetup.sh +++ b/edksetup.sh @@ -199,7 +199,7 @@ do break ;; esac -

Re: [edk2-devel] [PATCH v2] edksetup.sh: Simplify SetupPython3 and SetupPython functions.

On 2019-07-16 08:22, Leif Lindholm wrote: > Do (either) of these systems have a "python" binary, and if so, what > is that? FreeBSD doesn't, but macOS does, and the 'python' binary is Python 2.7. For FreeBSD we could just set PYTHON_COMMAND - which is better than creating a symlink in

[edk2-devel] Upcoming Event: TianoCore Design / Bug Triage - EMEA - Wed, 07/17/2019 8:00am-9:00am #cal-reminder

*Reminder:* TianoCore Design / Bug Triage - EMEA *When:* Wednesday, 17 July 2019, 8:00am to 9:00am, (GMT-07:00) America/Los Angeles *Where:* https://zoom.us/j/695893389 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=502931 ) *Organizer:* Stephano Cetola

Re: [edk2-devel] [PATCH 1/3] MdePkg/BaseLib: re-specify Base64Decode(), and add temporary stub impl

On 7/16/19 4:14 PM, Laszlo Ersek wrote: > On 07/16/19 11:41, Philippe Mathieu-Daudé wrote: >> Hi Laszlo, >> >> On 7/16/19 10:38 AM, Philippe Mathieu-Daudé wrote: >>> On 7/2/19 12:28 PM, Laszlo Ersek wrote: Rewrite Base64Decode() from scratch, due to reasons listed in the second reference

Re: [edk2-devel] [PATCH 1/3] MdePkg/BaseLib: re-specify Base64Decode(), and add temporary stub impl

Laszlo: Yes. Patch 1 & Patch 2 in MdePkg are both good to me. I have no other comments. Reviewed-by: Liming Gao Thanks Liming > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Laszlo > Ersek > Sent: Tuesday, July 16, 2019 6:49 PM > To: Gao,

Re: [edk2-devel] [PATCH v2] edksetup.sh: Simplify SetupPython3 and SetupPython functions.

On 07/16/19 13:35, Leif Lindholm wrote: > +Bob, Liming, Zhijux > > On Mon, Jul 15, 2019 at 08:36:06PM -0600, Rebecca Cran wrote: >> On Linux, "whereis" matches python3, python3.7, as well as >> man pages, libs etc. While on macOS it only matches the specified >> name, and so misses python3.7.

Re: [edk2-devel] [PATCH 2/3] MdePkg/BaseLib: rewrite Base64Decode()

On 07/16/19 12:05, Philippe Mathieu-Daudé wrote: > Hi Laszlo, > > On 7/2/19 12:28 PM, Laszlo Ersek wrote: >> Rewrite Base64Decode() from scratch, due to reasons listed in the second >> reference below. >> >> Implement Base64Decode() according to the specification added in the >> previous patch.

Re: [edk2-devel] [PATCH 1/3] MdePkg/BaseLib: re-specify Base64Decode(), and add temporary stub impl

On 07/16/19 11:41, Philippe Mathieu-Daudé wrote: > Hi Laszlo, > > On 7/16/19 10:38 AM, Philippe Mathieu-Daudé wrote: >> On 7/2/19 12:28 PM, Laszlo Ersek wrote: >>> Rewrite Base64Decode() from scratch, due to reasons listed in the second >>> reference below. >>> >>> As first step, redo the

Re: [edk2-devel] [RFC] Fine-grained review ownership for MdeModulePkg

Hi Hao Wu, Are you ready to send out a v1 yet? (Or did I miss it?) I would prefer to get this in before the GetMaintainer.py script, and after the comment updates to Maintainers.txt. Best Regards, Leif On Mon, Jun 24, 2019 at 01:16:05AM +, Wu, Hao A wrote: > Hello all, > > With Leif's

Re: [edk2-devel] [PATCH 1/6] edksetup.sh: Use bash variable $PWD instead of executing pwd command

On Tue, Jul 16, 2019 at 10:16:30AM +0100, Leif Lindholm wrote: > For 1-5/6: *cough* Blatantly given my follow-up email, I meant 1-4,6/6. / Leif > Reviewed-by: Leif Lindholm > > Afraid I'm going to need to bikeshed over 6/6. > > On Mon, Jul 15, 2019 at 04:25:11PM -0600, Rebecca Cran

Re: [edk2-devel] [PATCH v2] edksetup.sh: Simplify SetupPython3 and SetupPython functions.

+Bob, Liming, Zhijux On Mon, Jul 15, 2019 at 08:36:06PM -0600, Rebecca Cran wrote: > On Linux, "whereis" matches python3, python3.7, as well as > man pages, libs etc. While on macOS it only matches the specified > name, and so misses python3.7. Improve this by looping over > potential version

Re: [edk2-devel] [PATCH 1/3] MdePkg/BaseLib: re-specify Base64Decode(), and add temporary stub impl

sending a separate ping here as well, for clarity -- Liming, Mike, can one of you please R-b or A-b this specific patch too? Thanks! Laszlo On 07/02/19 12:28, Laszlo Ersek wrote: > Rewrite Base64Decode() from scratch, due to reasons listed in the second > reference below. > > As first step,

Re: [edk2-devel] [PATCH 2/3] MdePkg/BaseLib: rewrite Base64Decode()

On 07/16/19 03:18, Gao, Zhichao wrote: > > >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Tuesday, July 16, 2019 5:56 AM >> To: Gao, Liming ; Gao, Zhichao >> >> Cc: devel@edk2.groups.io; Kinney, Michael D ; >> Marvin Häuser ; Philippe Mathieu-Daudé >>

Re: [edk2-devel] [PATCH v2] edksetup.sh: Simplify SetupPython3 and SetupPython functions.

On 07/16/19 04:36, Rebecca Cran wrote: > On Linux, "whereis" matches python3, python3.7, as well as > man pages, libs etc. While on macOS it only matches the specified > name, and so misses python3.7. Improve this by looping over > potential version numbers and seeing if such a binary exists and

Re: [edk2-devel] [PATCH 5/6] edksetup.sh: Simplify SetupPython3 and SetupPython functions.

On 07/16/19 04:27, Rebecca Cran wrote: > On 2019-07-15 20:16, Laszlo Ersek wrote: >> That said, if you wouldn't like to rework the patch, I can give my R-b >> as-is (please confirm). > > > Thanks, I like your suggested changes. And I just ran shellcheck and was > told "SC2230: which is

Re: [edk2-devel] [PATCH 1/6] edksetup.sh: Use bash variable $PWD instead of executing pwd command

On 07/16/19 12:32, Laszlo Ersek wrote: > On 07/16/19 04:13, Rebecca Cran wrote: >> On 2019-07-15 19:37, Laszlo Ersek wrote: >>> >>> (Sorry if the reason was already given and I missed it:) >>> >>> Why is this an improvement? >>> >>> The docs at say: >>> >>> "pwd

Re: [edk2-devel] [PATCH 6/6] edksetup.sh: Add quotes and explicit checks in test statements

On 07/16/19 04:20, Rebecca Cran wrote: > On 2019-07-15 19:53, Laszlo Ersek wrote: >> >> But, I think the question stands; there's more that could be quoted. >> What is the reason for quoting just these? > > > Mainly because I thought those were the ones that were most important to > add quotes

Re: [edk2-devel] [PATCH 1/6] edksetup.sh: Use bash variable $PWD instead of executing pwd command

On 07/16/19 04:13, Rebecca Cran wrote: > On 2019-07-15 19:37, Laszlo Ersek wrote: >> >> (Sorry if the reason was already given and I missed it:) >> >> Why is this an improvement? >> >> The docs at say: >> >> "pwd also exists as a built-in to ksh(1), which may have a

Re: [edk2-devel] [PATCH 2/3] MdePkg/BaseLib: rewrite Base64Decode()

Hi Laszlo, On 7/2/19 12:28 PM, Laszlo Ersek wrote: > Rewrite Base64Decode() from scratch, due to reasons listed in the second > reference below. > > Implement Base64Decode() according to the specification added in the > previous patch. The decoder scans the input buffer once, it has no inner >

[edk2-devel] [[edk2-platforms]PATCH v5 1/1] Platform: Intel: Add Stratix 10 platform support

From: "Tien Hock, Loh" Adds support for Intel Stratix 10 Platform. Signed-off-by: "Tien Hock, Loh" Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney --- Platform/Intel/Stratix10/Drivers/IntelPlatformDxe/IntelPlatformDxe.c

Re: [edk2-devel] [PATCH 1/3] MdePkg/BaseLib: re-specify Base64Decode(), and add temporary stub impl

Hi Laszlo, On 7/16/19 10:38 AM, Philippe Mathieu-Daudé wrote: > On 7/2/19 12:28 PM, Laszlo Ersek wrote: >> Rewrite Base64Decode() from scratch, due to reasons listed in the second >> reference below. >> >> As first step, redo the interface contract, and replace the current >> implementation with

Re: [edk2-devel] [PATCH v6 edk2-platforms 1/1] Silicon/Synopsys/Designware/Driver: DwEmacSnpDxe: Add DesignWare EMAC driver

Hi Leif, I am new to the compilation tools. May I know if you can share to me how to run the compilation with Debian's gcc 8.3 so that I can see the same warning described below? Currently, I am using linaro toolchain 7.2.1 and follow the guide in the link below to compile the source code.

Re: [edk2-devel] [PATCH 1/6] edksetup.sh: Use bash variable $PWD instead of executing pwd command

For 1-5/6: Reviewed-by: Leif Lindholm Afraid I'm going to need to bikeshed over 6/6. On Mon, Jul 15, 2019 at 04:25:11PM -0600, Rebecca Cran wrote: > Signed-off-by: Rebecca Cran > --- > edksetup.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/edksetup.sh

[edk2-devel] [PATCH V2] ShellPkg/Type.c: Add value check before (LoopVar - 1)

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1964 If the file begin with single line Feed ('\n'), then "AsciiChar == '\n' && ((CHAR8*)Buffer)[LoopVar-1] != '\r'" would cause a underflow. Add this condition "(AsciiChar == '\n' && LoopVar == 0)" before it to make sure (LoopVar - 1) would

Re: [edk2-devel] [PATCH 1/3] MdePkg/BaseLib: re-specify Base64Decode(), and add temporary stub impl

On 7/2/19 12:28 PM, Laszlo Ersek wrote: > Rewrite Base64Decode() from scratch, due to reasons listed in the second > reference below. > > As first step, redo the interface contract, and replace the current > implementation with a stub that asserts FALSE, then fails. > > Cc: Liming Gao > Cc:

Re: [edk2-devel] [PATCH] UefiCpuPkg CpuCommonFeaturesLib: Enhance Ppin code

Done SHA-1: 84a459472075d94963463bffaa5dc6eee47f14c3 * UefiCpuPkg CpuCommonFeaturesLib: Enhance Ppin code BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1961 Enhance Ppin code to enable and unlock for TRUE State, and disable and lock for FALSE State. Note: enable and lock could not be set

Re: [edk2-devel] [PATCH] UefiCpuPkg CpuCommonFeaturesLib: Enhance Ppin code

Eric, Thanks for the comments. Attach the updated patch, and you may help push it if it is ok. Thanks, Star > -Original Message- > From: Dong, Eric > Sent: Tuesday, July 16, 2019 3:24 PM > To: Zeng, Star ; devel@edk2.groups.io > Cc: Laszlo Ersek ; Ni, Ray ; Kumar, > Chandana C ; Li,