[edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpu: Allow SMM access-out when static paging is OFF

2019-07-17 Thread Ni, Ray
Commit c60d36b4d1ee1f69b7cca897d3621dfa951895c2 * UefiCpuPkg/SmmCpu: Block access-out only when static paging is used updated page fault handler to treat SMM access-out as allowed address when static paging is not used. But that commit is not complete because the page table is still updated in Se

[edk2-devel] [edk2-platforms] [PATCH v2] KabylakeSiliconPkg: Possible out-of-bounds memory writes

2019-07-17 Thread Nate DeSimone
- Add check for the DSDT not existing. - Fixed logic errors in loop boundary check. Cc: Chasel Chiu Cc: Michael A Kubacki Cc: Sai Chaganty Co-authored-by: John Mathews Signed-off-by: Nate DeSimone --- .../Library/DxeAslUpdateLib/DxeAslUpdateLib.c | 10 -- 1 file changed, 8

Re: [edk2-devel] [PATCH] ClevoOpenBoardPkg: Added NVMe boot support

2019-07-17 Thread Nate DeSimone
Committed: https://github.com/tianocore/edk2-platforms/commit/ff90342886b01de2faf606122c273eef99d446ba -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Wednesday, July 17, 2019 11:32 PM To: Agyeman, Prince ; devel@edk2.groups.io Cc: Gao, Liming ; Sinha, Anki

Re: [edk2-devel] [PATCH] ClevoOpenBoardPkg: Added NVMe boot support

2019-07-17 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Agyeman, Prince Sent: Monday, July 15, 2019 3:24 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Sinha, Ankit ; Kubacki, Michael A ; Desimone, Nathaniel L ; Chiu, Chasel Subject: [PATCH] ClevoOpenBoardPkg: Added NVMe boot support Adde

[edk2-devel] [Patch 7/9] BaseTools: Add LogAgent to support multiple process Autogen

2019-07-17 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 AutoGen processes race the logfile. To resolve this issue, this patch create a LogAgent thread in main process to write the log content to console or file, Other process will send the log content to the LogAgent. Cc: Liming Gao Signed-off-b

[edk2-devel] [Patch 8/9] BaseTools: Move BuildOption parser out of build.py

2019-07-17 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 Build tool supports user to specify the conf folder. To make the build options be evaluated at the beginning of launching build, extract the buildoption function from build.py to a new .py file. Signed-off-by: Bob Feng Cc: Liming Gao ---

[edk2-devel] [Patch 9/9] BaseTools: Add the support for python 2

2019-07-17 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 python3 change the module name of Queue to queue. python3 add a new log handler of QueueHandler. This patch is to make Multiple process AutoGen feature work for python2 Cc: Liming Gao Signed-off-by: Bob Feng --- .../Source/Python/AutoGen

[edk2-devel] [Patch 0/9] Enable multiple process AutoGen

2019-07-17 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 In order to improve the build performance, we implemented multiple-processes AutoGen. This change will reduce 20% time for AutoGen phase. The design document can be got from: https://edk2.groups.io/g/devel/files/Designs/2019/0627/Multiple-th

[edk2-devel] [Patch 1/9] BaseTools: Singleton the object to handle build conf file

2019-07-17 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 The build config files are target.txt, build rule, tooldef During a build, the config is not changed, so the object to handle them need to be singleton. Cc: Liming Gao Signed-off-by: Bob Feng --- BaseTools/Source/Python/AutoGen/AutoGen.py

[edk2-devel] [Patch 6/9] BaseTools: Add shared data for processes

2019-07-17 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 Add shared data for autogen processes. Cc: Liming Gao Signed-off-by: Bob Feng --- BaseTools/Source/Python/AutoGen/AutoGenWorker.py | 3 ++- BaseTools/Source/Python/build/build.py | 10 ++ 2 files changed, 8 insertions(+

[edk2-devel] [Patch 2/9] BaseTools: Split WorkspaceAutoGen._InitWorker into multiple functions

2019-07-17 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 The WorkspaceAutoGen.__InitWorker function is too long, it's hard to read and understand. This patch is to separate the __InitWorker into multiple small ones. Cc: Liming Gao Signed-off-by: Bob Feng --- BaseTools/Source/Python/AutoGen/Auto

[edk2-devel] [Patch 5/9] BaseTools: Enable Multiple Process AutoGen

2019-07-17 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 Assign the Module AutoGen tasks into multiple sub process. Cc: Liming Gao Signed-off-by: Bob Feng --- .../Source/Python/AutoGen/AutoGenWorker.py| 160 ++ BaseTools/Source/Python/AutoGen/DataPipe.py | 6 + BaseTools

[edk2-devel] [Patch 3/9] BaseTools: Add functions to get platform scope build options

2019-07-17 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 These functions are used for get platform scope build options. They will be used in later patches. Cc: Liming Gao Signed-off-by: Bob Feng --- BaseTools/Source/Python/AutoGen/AutoGen.py| 10 +- .../Source/Python/Workspace/DscBu

Re: [edk2-devel] [PATCH v1 1/1] Maintainers.txt: Fine-grained review ownership for MdeModulePkg

2019-07-17 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Leif Lindholm > Sent: Wednesday, July 17, 2019 10:37 PM > To: Laszlo Ersek > Cc: Wu, Hao A; devel@edk2.groups.io; Andrew Fish; Kinney, Michael D; Bi, > Dandan; Dong, Eric; Gao, Liming; Ni, Ray; Ze

Re: [edk2-devel] [PATCH v2 1/1] Maintainers.txt: Fine-grained review ownership for MdeModulePkg

2019-07-17 Thread Dandan Bi
Reviewed-by: Dandan Bi Thanks, Dandan > -Original Message- > From: Wu, Hao A > Sent: Thursday, July 18, 2019 9:19 AM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Andrew Fish ; > Laszlo Ersek ; Leif Lindholm ; > Kinney, Michael D ; Bi, Dandan > ; Dong, Eric ; Gao, Liming > ; Zeng, Star ; G

Re: [edk2-devel] [PATCH v2 1/1] Maintainers.txt: Fine-grained review ownership for MdeModulePkg

2019-07-17 Thread Zeng, Star
Reviewed-by: Star Zeng for my part. > -Original Message- > From: Wu, Hao A > Sent: Thursday, July 18, 2019 9:19 AM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Andrew Fish ; > Laszlo Ersek ; Leif Lindholm ; > Kinney, Michael D ; Bi, Dandan > ; Dong, Eric ; Gao, Liming > ; Zeng, Star ; Gao

Re: [edk2-devel] [PATCH v2 1/1] Maintainers.txt: Fine-grained review ownership for MdeModulePkg

2019-07-17 Thread Gao, Zhichao
Reviewed-by: Zhichao Gao > -Original Message- > From: Wu, Hao A > Sent: Thursday, July 18, 2019 9:19 AM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Andrew Fish ; > Laszlo Ersek ; Leif Lindholm ; > Kinney, Michael D ; Bi, Dandan > ; Dong, Eric ; Gao, Liming > ; Zeng, Star ; Gao, Zhichao >

Re: [edk2-devel] [PATCH 0/4] Maintainers.txt: formalize ArmVirtPkg and OvmfPkg subsystem pathnames

2019-07-17 Thread Philippe Mathieu-Daudé
On 7/15/19 7:04 PM, Laszlo Ersek wrote: > Repo: https://github.com/lersek/edk2.git > Branch: ovmfpkg_maintainers > > The patches in this series should be inserted between Leif's patches > > * [edk2-devel] [PATCH 2/3] Maintainers.txt: add wildcard path association for > Arm/AArch64 > 20190712

Re: [edk2-devel] [PATCH 3/3] MdeModulePkg/CapsuleRuntimeDxe: Control runtime services supported

2019-07-17 Thread Gao, Zhichao
> -Original Message- > From: Kinney, Michael D > Sent: Wednesday, July 17, 2019 11:41 PM > To: devel@edk2.groups.io; Gao, Zhichao ; Kinney, > Michael D > Cc: Wang, Jian J ; Wu, Hao A ; > Ni, Ray ; Zeng, Star ; Gao, Liming > ; Sean Brogan ; > Michael Turner ; Bret Barkelew > > Subject:

Re: [edk2-devel] [PATCH v2 1/1] Maintainers.txt: Fine-grained review ownership for MdeModulePkg

2019-07-17 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Wu, Hao A > Sent: Thursday, July 18, 2019 9:19 AM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Andrew Fish ; > Laszlo Ersek ; Leif Lindholm ; > Kinney, Michael D ; Bi, Dandan > ; Dong, Eric ; Gao, Liming > ; Zeng, Star ; Gao, Zhichao >

Re: [edk2-devel] [PATCH 0/3] MdePkg/MdeModulePkg: Introduce a pcd to control runtime services

2019-07-17 Thread Gao, Zhichao
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Laszlo Ersek > Sent: Wednesday, July 17, 2019 9:15 PM > To: devel@edk2.groups.io; Gao, Zhichao > Cc: Kinney, Michael D ; Gao, Liming > ; Wang, Jian J ; Wu, Hao A > ; Ni, Ray ; Zeng, Star > ; Se

Re: [edk2-devel] [PATCH v2 1/1] Maintainers.txt: Fine-grained review ownership for MdeModulePkg

2019-07-17 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Wu, Hao > A > Sent: Thursday, July 18, 2019 9:19 AM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Andrew Fish ; Laszlo > Ersek ; Leif Lindholm > ; Kinney, Michael D ; > B

[edk2-devel] [PATCH v2 1/1] Maintainers.txt: Fine-grained review ownership for MdeModulePkg

2019-07-17 Thread Wu, Hao A
This commit add the reviewers information for modules within MdeModulePkg. For now the modules list includes: ACPI ACPI S3 BDS Console and Graphics Core services (PEI, DXE and Runtime) Device and Peripheral Firmware Update HII and UI Management Mode (MM, SMM) Reset SMBIOS UEFI Variable Please not

[edk2-devel] [PATCH v2 0/1] Maintainers.txt: Review ownership for MdeModulePkg

2019-07-17 Thread Wu, Hao A
This patch is also available at: https://github.com/hwu25/edk2/tree/mdemodulepkg_reviewers_v2 Also, please note that on the above branch, the proposed patch (MdeModulePkg reviewers) is inserted between: * [edk2-devel] [PATCH 4/4] Maintainers.txt: split out section "OvmfPkg: CSM modules" (from La

Re: [edk2-devel] [PATCH 0/4] Add a pcd PcdBootManagerInBootOrder to control whether BootManager is in BootOrder

2019-07-17 Thread Ni, Ray
I see. I have no concerns on the 3 &4 in different patches. > -Original Message- > From: Gao, Zhichao > Sent: Wednesday, July 17, 2019 4:44 PM > To: Ni, Ray ; devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Zeng, Star ; Gao, Liming > ; Sean Brogan ; Michael > Turner ; Bret > Bark

Re: [edk2-devel] [PATCH v1 1/1] Maintainers.txt: Fine-grained review ownership for MdeModulePkg

2019-07-17 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Laszlo Ersek > Sent: Wednesday, July 17, 2019 8:41 PM > To: Wu, Hao A; devel@edk2.groups.io > Cc: Andrew Fish; Leif Lindholm; Kinney, Michael D; Bi, Dandan; Dong, Eric; > Gao, Liming; Ni, Ray; Zen

Re: [edk2-devel] [PATCH 1/1] edksetup.sh: rework python executable scanning

2019-07-17 Thread Leif Lindholm
On Wed, Jul 17, 2019 at 03:23:26AM +, Gao, Liming wrote: > Leif: > I agree to discuss the behavior first, then review the code logic in > detail. I add my comments below. > > > -Original Message- > > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > > So, first of all - I am

Re: [edk2-devel] [PATCH 1/1] edksetup.sh: rework python executable scanning

2019-07-17 Thread Laszlo Ersek
On 07/17/19 16:32, Gao, Liming wrote: > Laszlo: > >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Wednesday, July 17, 2019 6:22 PM >> To: Gao, Liming ; Leif Lindholm >> >> Cc: devel@edk2.groups.io; Rebecca Cran ; Feng, Bob C >> ; Kinney, Michael D >> ; af

Re: [edk2-devel] [PATCH 2/4] Maintainers.txt: split out section "OvmfPkg: Xen-related modules"

2019-07-17 Thread Anthony PERARD
On Mon, Jul 15, 2019 at 07:04:29PM +0200, Laszlo Ersek wrote: > We ask contributors to copy Anthony and Julien on patches that affect "Xen > modules" under OvmfPkg. With the "GetMaintainer.py" script being > introduced later, express this expectation in "Maintainers.txt" in > machine-readable forma

Re: [edk2-devel] [PATCH 3/3] MdeModulePkg/CapsuleRuntimeDxe: Control runtime services supported

2019-07-17 Thread Michael D Kinney
Zhichao, Why is CapsuleRuntimeDxe the component that is responsible for setting the UEFI Variable for supported RT services? I would think this should be in: MdeModulePkg\Core\RuntimeDxe I agree that each RT driver that populates the RT Services Table with a RT services can consume the

Re: [edk2-devel] [PATCH v1 1/1] Maintainers.txt: Fine-grained review ownership for MdeModulePkg

2019-07-17 Thread Ni, Ray
Regarding the role assigned to me, Reviewed-by: Ray Ni > -Original Message- > From: Leif Lindholm > Sent: Wednesday, July 17, 2019 10:37 PM > To: Laszlo Ersek > Cc: Wu, Hao A ; devel@edk2.groups.io; Andrew Fish > ; Kinney, Michael D ; Bi, > Dandan ; Dong, Eric ; Gao, > Liming ; Ni, Ray

Re: [edk2-devel] [PATCH 1/1] edksetup.sh: rework python executable scanning

2019-07-17 Thread Liming Gao
Laszlo: > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, July 17, 2019 6:22 PM > To: Gao, Liming ; Leif Lindholm > > Cc: devel@edk2.groups.io; Rebecca Cran ; Feng, Bob C > ; Kinney, Michael D > ; af...@apple.com > Subject: Re: [PATCH 1/1] edksetup.

Re: [edk2-devel] [PATCH] MdePkg/BaseLib: Base64Decode(): don't declare variables in nested blocks

2019-07-17 Thread Laszlo Ersek
On 07/17/19 00:59, Laszlo Ersek wrote: > The EDK II C Coding Standards Specification (v2.20) strongly discourages > variable declarations in nested block scope: > > 5 Source Files > 5.4 Code File Structure > 5.4.1 Scoping Rules > 5.4.1.1 Scope > >> Block (local) Scope >> >> [...] >> >

Re: [edk2-devel] [PATCH v1 1/1] Maintainers.txt: Fine-grained review ownership for MdeModulePkg

2019-07-17 Thread Leif Lindholm
Top-posting because lazy. Basically, I agree with all of Laszlo's comments. I would be happy for this to remain a single patch, however. Partly because I'm lazy. But also because this is effectively "converting" a single package (MdeModulePkg) into multiple sections. (This is not a strong preferen

Re: [edk2-devel] [PATCH 1/1] edksetup.sh: rework python executable scanning

2019-07-17 Thread Leif Lindholm
On Tue, Jul 16, 2019 at 02:10:43PM -0600, Rebecca Cran wrote: > On 2019-07-16 13:07, Leif Lindholm wrote: > > +EXECUTABLE=`basename $file` > > +VERSION=`echo $EXECUTABLE | sed 's/[^0-9.]//g'` > > + > > +MAJOR=`echo $VERSION | sed 's/\([0-9]*\)\.*.*/\1/'` > > +MINOR=`

Re: [edk2-devel] [PATCH v1 01/11] ShellPkg: acpiview: FADT: Validate global pointers before use

2019-07-17 Thread Krzysztof Koch
Hi Jaben, I will split the changes into separate patch sets with each patch set having the same logical change made to every applicable acpiview table parser. The per-parser modifications will be separate commits as well. Kind regards, Krzysztof -Original Message- From: devel@edk2.gro

Re: [edk2-devel] [PATCH 0/3] MdePkg/MdeModulePkg: Introduce a pcd to control runtime services

2019-07-17 Thread Laszlo Ersek
Hello Zhichao, On 07/17/19 09:37, Gao, Zhichao wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1907 > > UEFI spec 2.8 introduce a new variable L"RuntimeServicesSupported". > If some runtime sevices is not supported at runtime phase, the variable > should present at boot services. It

Re: [edk2-devel] [PATCH 0/4] Add a pcd PcdBootManagerInBootOrder to control whether BootManager is in BootOrder

2019-07-17 Thread Laszlo Ersek
On 07/17/19 10:07, Ni, Ray wrote: > Zhichao, > > Firstly, patch 4/4 is a fix to patch 3/4, why not merge them into one patch? > Do we have a policy to strictly cherry-pick the patches from MU? > > Secondly, the change that skips to add the to BootOrder may cause the > Boot pointing to

Re: [edk2-devel] [PATCH v1 1/1] Maintainers.txt: Fine-grained review ownership for MdeModulePkg

2019-07-17 Thread Laszlo Ersek
On 07/17/19 03:44, Hao A Wu wrote: > This commit add the reviewers information for modules within MdeModulePkg. > > For now the modules list includes: > ACPI > BDS > Console and Graphic > Core services (PEI, DXE and Runtime) > Device and Peripheral > Firmware Update > HII and UI > Reset > S3 > SMB

[edk2-devel] [edk2-platforms: PATCH 3/3] Platform/RPi3: Reduce debug noise when using a USB network device

2019-07-17 Thread Pete Batard
From: Michael Brown The design of the EFI_USB2_HC_PROTOCOL does not allow for long-lived bulk IN transactions as used by network devices, but instead requires the network driver to rely on repeatedly issuing bulk IN transactions with a very short timeout and in the expectation that most bulk IN t

[edk2-devel] [edk2-platforms: PATCH 0/3] Platform/RPi3: Improve timeout handling in DwUsbHostDxe

2019-07-17 Thread Pete Batard
Networking applications (e.g. iPXE) might experience failures when submitting a bulk IN for the NIC's RX endpoint, because the bulk IN (correctly) times out when no received packet is waiting, but DwUsbHostDxe.c treats this as a fatal error. With these patches, iPXE is able to successfully downloa

[edk2-devel] [edk2-platforms: PATCH 1/3] Platform/RPi3: Use Wait4Bit return value consistently

2019-07-17 Thread Pete Batard
From: Michael Brown There are multiple points in the existing code that take the UINT32 value returned by Wait4Bit and return it directly as an EFI_STATUS value. If Wait4Bit fails, this will result in a spurious EFI_STATUS value of 0x1 (EFI_WARN_UNKNOWN_GLYPH) being returned to the caller. A ca

[edk2-devel] [edk2-platforms: PATCH 2/3] Platform/RPi3: Gracefully disable USB channel after a timeout

2019-07-17 Thread Pete Batard
From: Michael Brown When a timeout occurs, attempt to gracefully disable the channel. Report a final status of EFI_TIMEOUT if the channel was disabled successfully, or EFI_DEVICE_ERROR if we were unable to disable the channel. Signed-off-by: Michael Brown Signed-off-by: Pete Batard --- Platfo

Re: [edk2-devel] [PATCH v6 edk2-platforms 1/1] Silicon/Synopsys/Designware/Driver: DwEmacSnpDxe: Add DesignWare EMAC driver

2019-07-17 Thread Leif Lindholm
Hi Tzy Way, On Wed, Jul 17, 2019 at 09:25:49AM +, Ooi, Tzy Way wrote: > Ya. I am on Linux. I managed to replicated the warning that you have > provided in the previous email thread by using the gcc 8.3. Excellent. > Currently, I'm looking at the compiler warning/error. While I am > fixing t

Re: [edk2-devel] [PATCH 1/1] edksetup.sh: rework python executable scanning

2019-07-17 Thread Laszlo Ersek
On 07/17/19 05:23, Gao, Liming wrote: > Leif: > I agree to discuss the behavior first, then review the code logic in > detail. I add my comments below. > >> -Original Message- >> From: Leif Lindholm [mailto:leif.lindh...@linaro.org] >> Sent: Wednesday, July 17, 2019 6:05 AM >> To: Lasz

Re: [edk2-devel] [PATCH 1/1] edksetup.sh: rework python executable scanning

2019-07-17 Thread Laszlo Ersek
On 07/17/19 00:04, Leif Lindholm wrote: > On Tue, Jul 16, 2019 at 10:49:03PM +0200, Laszlo Ersek wrote: >> Hi Leif, >> >> On 07/16/19 21:07, Leif Lindholm wrote: >>> If PYTHON_COMMAND is set, use that. >>> If PYTHON_COMMAND is not set, use first working of "python", "python3", >>> "python2". >>> I

Re: [edk2-devel] [PATCH v1 07/11] ShellPkg: acpiview: MADT: Add error-checking in the parsing logic

2019-07-17 Thread Alexei Fedorov
Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43867): https://edk2.groups.io/g/devel/message/43867 Mute This Topic: https://groups.io/mt/32439510/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

Re: [edk2-devel] [PATCH v1 03/11] ShellPkg: acpiview: RSDP: Make printing table checksum optional

2019-07-17 Thread Alexei Fedorov
Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43870): https://edk2.groups.io/g/devel/message/43870 Mute This Topic: https://groups.io/mt/32439506/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

Re: [edk2-devel] [PATCH v1 06/11] ShellPkg: acpiview: SRAT: Add error-checking in the parsing logic

2019-07-17 Thread Alexei Fedorov
Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43868): https://edk2.groups.io/g/devel/message/43868 Mute This Topic: https://groups.io/mt/32439509/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

Re: [edk2-devel] [PATCH v1 05/11] ShellPkg: acpiview: SLIT: Add error-checking in the parsing logic

2019-07-17 Thread Alexei Fedorov
Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43872): https://edk2.groups.io/g/devel/message/43872 Mute This Topic: https://groups.io/mt/32439502/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

Re: [edk2-devel] [PATCH v1 02/11] ShellPkg: acpiview: SPCR: Remove redundant forward declaration

2019-07-17 Thread Alexei Fedorov
Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43871): https://edk2.groups.io/g/devel/message/43871 Mute This Topic: https://groups.io/mt/32439504/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

Re: [edk2-devel] [PATCH v1 08/11] ShellPkg: acpiview: PPTT: Add error-checking in the parsing logic

2019-07-17 Thread Alexei Fedorov
Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43866): https://edk2.groups.io/g/devel/message/43866 Mute This Topic: https://groups.io/mt/32439512/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

Re: [edk2-devel] [PATCH v1 00/11] Add security checks in the Acpiview table parsers

2019-07-17 Thread Alexei Fedorov
Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43873): https://edk2.groups.io/g/devel/message/43873 Mute This Topic: https://groups.io/mt/32439501/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

Re: [edk2-devel] [PATCH v1 04/11] ShellPkg: acpiview: XSDT: Remove redundant ParseAcpi() call

2019-07-17 Thread Alexei Fedorov
Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43869): https://edk2.groups.io/g/devel/message/43869 Mute This Topic: https://groups.io/mt/32439507/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

Re: [edk2-devel] [PATCH v1 11/11] ShellPkg: acpiview: DBG2: Add error-checking in the parsing logic

2019-07-17 Thread Alexei Fedorov
Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43863): https://edk2.groups.io/g/devel/message/43863 Mute This Topic: https://groups.io/mt/32439516/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

Re: [edk2-devel] [PATCH v1 09/11] ShellPkg: acpiview: IORT: Add error-checking in the parsing logic

2019-07-17 Thread Alexei Fedorov
Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43865): https://edk2.groups.io/g/devel/message/43865 Mute This Topic: https://groups.io/mt/32439513/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

Re: [edk2-devel] [PATCH v1 10/11] ShellPkg: acpiview: GTDT: Add error-checking in the parsing logic

2019-07-17 Thread Alexei Fedorov
Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43864): https://edk2.groups.io/g/devel/message/43864 Mute This Topic: https://groups.io/mt/32439515/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

Re: [edk2-devel] [PATCH 4/4] Maintainers.txt: split out section "OvmfPkg: CSM modules"

2019-07-17 Thread Laszlo Ersek
Stephano, On 07/17/19 00:05, David Woodhouse wrote: > On Tue, 2019-07-16 at 22:55 +0200, Laszlo Ersek wrote: >> something must have gone wrong -- I don't see your message in my list >> folder, and I haven't received a moderation request either. Do you have >> an idea why your message may not have

Re: [edk2-devel] [PATCH v6 edk2-platforms 1/1] Silicon/Synopsys/Designware/Driver: DwEmacSnpDxe: Add DesignWare EMAC driver

2019-07-17 Thread Ooi, Tzy Way
Hi Leif, Ya. I am on Linux. I managed to replicated the warning that you have provided in the previous email thread by using the gcc 8.3. Currently, I'm looking at the compiler warning/error. While I am fixing the issue when compiling the source code, I encountered another issue where the com

Re: [edk2-devel] [PATCH 0/4] Add a pcd PcdBootManagerInBootOrder to control whether BootManager is in BootOrder

2019-07-17 Thread Gao, Zhichao
Sorry to miss the first question. I used to send a patch to the community to merge my change and the changes from Mu. And Leif suggests to separate them. That would distinguish the contributor when encounter copyright issue. And also make a history of it. Here is the message link: https://edk2.gr

Re: [edk2-devel] [PATCH 0/4] Add a pcd PcdBootManagerInBootOrder to control whether BootManager is in BootOrder

2019-07-17 Thread Ni, Ray
I don't know the requirement. That's just my guess so I used "if". You need to clarify with Bret Barkelew and get real requirement. > -Original Message- > From: Gao, Zhichao > Sent: Wednesday, July 17, 2019 4:29 PM > To: Ni, Ray ; devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Zen

Re: [edk2-devel] [PATCH 0/4] Add a pcd PcdBootManagerInBootOrder to control whether BootManager is in BootOrder

2019-07-17 Thread Gao, Zhichao
Ray, You are right. I didn't view the implementation of BmGetFreeOptionNumber. Only use it base on its comments. If new options are added after BootManagerMenuApp with the pcd's value FALSE then it would be overwriten. 3/4 would remove the BootManagerMenuApp option from Boot and BootOrder.

Re: [edk2-devel] [PATCH 0/4] Add a pcd PcdBootManagerInBootOrder to control whether BootManager is in BootOrder

2019-07-17 Thread Ni, Ray
Zhichao, Firstly, patch 4/4 is a fix to patch 3/4, why not merge them into one patch? Do we have a policy to strictly cherry-pick the patches from MU? Secondly, the change that skips to add the to BootOrder may cause the Boot pointing to the BootManagerMenu be overwritten later. Reason

[edk2-devel] [PATCH 0/4] Add a pcd PcdBootManagerInBootOrder to control whether BootManager is in BootOrder

2019-07-17 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1979 Add a pcd to control whether the BootManager is in BootOrder variable. >From a UI perspective, it never want to see a Front Page UI in the boot order list. So add a pcd PcdBootManagerInBootOrder to control it. If it is FALSE, the BootManager

[edk2-devel] [PATCH 3/4] MdeModulePkg: Use pcd to control if BootManager in BootOrder

2019-07-17 Thread Gao, Zhichao
From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1979 Use pcd PcdBootManagerInBootOrder to control whether BootManager is in BootOrder. Also add EFI_UNSUPPORTED to indicate the BootManager is not in the BootOrder. Cc: Jian J Wang Cc: Hao A Wu Cc: Ray Ni Cc: Star Zeng

[edk2-devel] [PATCH 2/4] MdeModulePkg: Add prompt and help string for PcdBootManagerInBootOrder

2019-07-17 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1979 Add prompt and help string for PcdBootManagerInBootOrder. Cc: Jian J Wang Cc: Hao A Wu Cc: Ray Ni Cc: Star Zeng Cc: Liming gao Cc: Sean Brogan Cc: Michael Turner Cc: Bret Barkelew Signed-off-by: Zhichao Gao --- MdeModulePkg/MdeMod

[edk2-devel] [PATCH 4/4] MdeModulePkg: PcdBootManagerInBootOrder should only affect BootOrder

2019-07-17 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1979 The PcdBootManagerInBootOrder should only control whether BootManager is in BootOrder. It shouldn't affect the Hotkey service with BootManager. Acctually, setting this pcd hides the boot option from BootOrder. But it didn't disable the boot

[edk2-devel] [PATCH 1/4] MdeModulePkg: Add PcdBootManagerInBootOrder to dec file

2019-07-17 Thread Gao, Zhichao
From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1979 Add defination of PcdBootManagerInBootOrder to MdeModulePkg.dec. This pcd indicates if the Boot Manager should be in the Boot Order list. Cc: Jian J Wang Cc: Hao A Wu Cc: Ray Ni Cc: Star Zeng Cc: Liming gao Cc: Se

[edk2-devel] [PATCH 2/3] MdePkg: Add new pcd PcdRuntimeServicesSupport

2019-07-17 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1907 Add pcd PcdRuntimeServicesSupport to control whether runtime services is supported at runtime phase. It is a UINT16 type bitmask value. Refer to Uefi Spec 2.8, Section 8.1.1. Cc: Michael D Kinney Cc: Liming Gao Cc: Sean Brogan Cc: Michae

[edk2-devel] [PATCH 3/3] MdeModulePkg/CapsuleRuntimeDxe: Control runtime services supported

2019-07-17 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1907 Add PcdRuntimeServicesSupport to control whether the capsule services is supported during runtime phase. If the L"RuntimeServicesSupported" variable is not set yet, it would set the variable base on the pcd. If the pcd value is 0x3FFF that m

[edk2-devel] [PATCH 1/3] MdePkg/UefiSpec.h: Add define of runtime services support

2019-07-17 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1907 UEFI spec 2.8, Section 8.1.1 define some MACROs for RuntimeServicesSupported variable. Add them to UefiSpec.h. Cc: Michael D Kinney Cc: Liming Gao Cc: Sean Brogan Cc: Michael Turner Cc: Bret Barkelew Signed-off-by: Zhichao Gao --- Md

[edk2-devel] [PATCH 0/3] MdePkg/MdeModulePkg: Introduce a pcd to control runtime services

2019-07-17 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1907 UEFI spec 2.8 introduce a new variable L"RuntimeServicesSupported". If some runtime sevices is not supported at runtime phase, the variable should present at boot services. It is a bitmask value, the bit value of zero indicate the related ru

Re: [edk2-devel] [PATCH] MdePkg/BaseLib: Base64Decode(): don't declare variables in nested blocks

2019-07-17 Thread Philippe Mathieu-Daudé
On 7/17/19 12:59 AM, Laszlo Ersek wrote: > The EDK II C Coding Standards Specification (v2.20) strongly discourages > variable declarations in nested block scope: > > 5 Source Files > 5.4 Code File Structure > 5.4.1 Scoping Rules > 5.4.1.1 Scope > >> Block (local) Scope >> >> [...] >>