I'd kind of like to remove the ADD_QEMU_HDA support. I think, way, way
back qemu would not boot if no drives were added, so this kind of
helped. (OVMF can still load the shell with no drives.)
If qemu will still run the firmware without a drive, then maybe maybe
we can just dump ADD_QEMU_HDA.
I tested with QEMU 1.6.2 and it works.
I’ll update the patch to make it read-write.
—
Rebecca Cran
> On Jul 23, 2019, at 8:54 PM, Jordan Justen wrote:
>
>> On 2019-07-23 18:51:00, wrote:
>> Specify the firmware to use via the newer '-drive if=pflash' syntax
>> which allows specifying the
On 2019-07-23 18:51:00, wrote:
> Specify the firmware to use via the newer '-drive if=pflash' syntax
> which allows specifying the raw format and readonly parameters. This
> avoids warnings with newer version of QEMU.
>
> Signed-off-by: Rebecca Cran
> ---
> OvmfPkg/build.sh | 2 +-
> 1 file
On 2019-07-23 18:20:31, wrote:
> Running qemu before building the firmware image doesn't make much sense.
> Move things so qemu is run after building OvmfPkg.
>
> Signed-off-by: Rebecca Cran
> ---
> OvmfPkg/build.sh | 11 +--
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff
Reviewed-by: Eric Dong
> -Original Message-
> From: Ni, Ray
> Sent: Monday, July 22, 2019 4:16 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Laszlo Ersek
> Subject: [PATCH 3/4] MdeModulePkg/DxeIpl: Introduce PCD
> PcdUse5LevelPageTable
>
> REF:
The $BUILD_ROOT_ARCH directory has too many files to
work as a fat filesystem. QEMU fails with the message:
Too many entries in root directory
Use the $QEMU_FIRMWARE_DIR as the root directory instead.
Signed-off-by: Rebecca Cran
---
OvmfPkg/build.sh | 2 +-
1 file changed, 1 insertion(+), 1
Specify the firmware to use via the newer '-drive if=pflash' syntax
which allows specifying the raw format and readonly parameters. This
avoids warnings with newer version of QEMU.
Signed-off-by: Rebecca Cran
---
OvmfPkg/build.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Mike,
Thanks for the suggestion.
I will try to move Cpuid.h to MdePkg/Include/Register directory in V2 patch.
Thanks,
Ray
> -Original Message-
> From: Kinney, Michael D
> Sent: Wednesday, July 24, 2019 7:54 AM
> To: devel@edk2.groups.io; ler...@redhat.com; Ni, Ray ;
> Kinney, Michael D
Sorry, I miss this mail. I am OK for this change.
Ack-by: Liming Gao
Thanks
Liming
> -Original Message-
> From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
> Sent: Friday, July 19, 2019 5:57 AM
> To: Laszlo Ersek
> Cc: edk2-devel-groups-io ; Andrew Fish
> ; Kinney, Michael D ;
>
Running qemu before building the firmware image doesn't make much sense.
Move things so qemu is run after building OvmfPkg.
Signed-off-by: Rebecca Cran
---
OvmfPkg/build.sh | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
index
Signed-off-by: Rebecca Cran
---
OvmfPkg/build.sh | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
index e94aa2a37e..1c28e65404 100755
--- a/OvmfPkg/build.sh
+++ b/OvmfPkg/build.sh
@@ -174,11 +174,11 @@ case $PROCESSOR in
#
Laszlo,
There already a few examples in MdePkg/Include/Library/BaseLib.h.
For example, the bit field structures for CR0, CR4, EFLAGS,
and a segment descriptor are in that .h file. These are all
within:
#if defined (MDE_CPU_IA32) || defined (MDE_CPU_X64)
. . .
#endif
We have since used a
https://bugzilla.tianocore.org/show_bug.cgi?id=1373
Replace BSD 2-Clause License with BSD+Patent License. This change is
based on the following emails:
https://lists.01.org/pipermail/edk2-devel/2019-February/036260.html
https://lists.01.org/pipermail/edk2-devel/2018-October/030385.html
https://bugzilla.tianocore.org/show_bug.cgi?id=1373
Replace BSD 2-Clause License with BSD+Patent License. This change is
based on the following emails:
https://lists.01.org/pipermail/edk2-devel/2019-February/036260.html
https://lists.01.org/pipermail/edk2-devel/2018-October/030385.html
https://bugzilla.tianocore.org/show_bug.cgi?id=1373
Replace BSD 2-Clause License with BSD+Patent License. This change is
based on the following emails:
https://lists.01.org/pipermail/edk2-devel/2019-February/036260.html
https://lists.01.org/pipermail/edk2-devel/2018-October/030385.html
On 07/23/19 17:29, Ni, Ray wrote:
>
>
>> -Original Message-
>> From: devel@edk2.groups.io On Behalf Of Laszlo Ersek
>> Sent: Tuesday, July 23, 2019 5:46 PM
>> To: devel@edk2.groups.io; Ni, Ray
>> Cc: Dong, Eric
>> Subject: Re: [edk2-devel] [PATCH 4/4] MdeModulePkg/DxeIpl: Create
On 07/23/19 14:19, Leif Lindholm wrote:
> On Tue, Jul 23, 2019 at 01:54:54PM +0200, Laszlo Ersek wrote:
I wasn't annoyed at the feature itself -- if it helps developers catch
unlisted headers as soon as incomplete INF files are introduced, then
it's not a bad feature IMO.
>>>
>>> I
On Mon, Jul 22, 2019 at 08:56:36PM +0900, Masahisa Kojima wrote:
> The latest NetsecDxe requires issueing phy reset at the
> last stage of initialization to safely exit loopback mode.
> However, as a result, it takes a couple of seconds for link state
> to get stable, which could cause auto-chosen
On Tue, Jul 23, 2019 at 11:42:07AM +0200, Roger Pau Monné wrote:
> On Mon, Jul 22, 2019 at 03:53:19PM +0100, Anthony PERARD wrote:
> > On Mon, Jul 15, 2019 at 04:15:21PM +0200, Roger Pau Monné wrote:
> > > On Thu, Jul 04, 2019 at 03:42:22PM +0100, Anthony PERARD wrote:
> > > You could maybe
On Mon, Jul 22, 2019 at 08:56:35PM +0900, Masahisa Kojima wrote:
> NETSEC hardware requires stable RXCLK input upon initialization
> triggered with DISCORE = 0.
> However, RXCLK input could be unstable depending on phy chipset
> and deployed network environment, which could cause NETSEC to
> hang
On Mon, Jul 22, 2019 at 08:56:34PM +0900, Masahisa Kojima wrote:
> This is a refactoring of phy address handling in Netsec driver.
> NETSEC SDK, low level driver for NetsecDxe, did not store phy address.
> User should specify the phy address as an argument to
> the SDK public functions.
> It
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Laszlo Ersek
> Sent: Tuesday, July 23, 2019 5:46 PM
> To: devel@edk2.groups.io; Ni, Ray
> Cc: Dong, Eric
> Subject: Re: [edk2-devel] [PATCH 4/4] MdeModulePkg/DxeIpl: Create 5-level
> page table for long mode
>
> On
*Reminder:* TianoCore Design / Bug Triage - EMEA
*When:* Wednesday, 24 July 2019, 8:00am to 9:00am, (GMT-07:00) America/Los
Angeles
*Where:* https://zoom.us/j/695893389
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=502932 )
*Organizer:* Stephano Cetola
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1928
1. Implement OpenSSL HKDF wrapped function in CryptHkdf.c file.
2. Implement stub implementation function in CryptHkdfNull.c file.
3. Add wrapped HKDF function declaration to BaseCryptLib.h file.
4. Add CryptHkdf.c to module information
On Tue, Jul 23, 2019 at 01:02:42PM +, Gao, Liming wrote:
> > > > I am just not pleased with the issue
> > > > bringing this to the fore is caused by the new caching feature using a
> > > > different mechanism for tracking header file dependencies than the
> > > > primary build process.
> > >
>
Leif:
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Leif
> Lindholm
> Sent: Tuesday, July 23, 2019 8:20 PM
> To: Laszlo Ersek
> Cc: devel@edk2.groups.io; Kinney, Michael D ; Ard
> Biesheuvel ; Wang, Jian J
> ; Ye, Ting
> Subject: Re:
On Tue, Jul 23, 2019 at 01:54:54PM +0200, Laszlo Ersek wrote:
> >> I wasn't annoyed at the feature itself -- if it helps developers catch
> >> unlisted headers as soon as incomplete INF files are introduced, then
> >> it's not a bad feature IMO.
> >
> > I agree that the optional nature of whether
On 07/23/19 09:47, Jordan Justen wrote:
> Reviewed-by: Jordan Justen
>
> Laszlo, want me to add your r-b?
Yes, please:
86503359-2f97-a602-b918-abb8cb3d6da2@redhat.com">http://mid.mail-archive.com/86503359-2f97-a602-b918-abb8cb3d6da2@redhat.com
https://edk2.groups.io/g/devel/message/44239
(At
On 07/23/19 10:05, Jordan Justen wrote:
> On 2019-07-23 00:44:06, Laszlo Ersek wrote:
>> On 07/23/19 02:00, Rebecca Cran wrote:
>>> On 2019-07-22 17:14, Jordan Justen wrote:
I was suggesting that if they didn't specify -n as a param to
build.sh, then build.sh should not send -n to
Good suggestion. I think ThreadNum * 10 is better than a const. I'll update it
in patches V4.
I'd like to collect more comments on other parts and update all the comments in
V4.
Thanks,
Bob
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Tuesday, July 23, 2019
On 07/23/19 11:06, Leif Lindholm wrote:
> On Tue, Jul 23, 2019 at 12:56:23AM +0200, Laszlo Ersek wrote:
>> Hi Mike,
>>
>> On 07/22/19 20:47, Michael D Kinney wrote:
>>> We could consider checking for these type of issues in
>>> the ECC tool instead of build and make it an error from
>>> ECC
This is a simple test of email configuration, and how the line ending
survive the different MTAs. (There should only be CRLFs in the hunk, and
LFs everywhere else.)
---
Readme.md | 9 +
1 file changed, 9 insertions(+)
diff --git a/Readme.md b/Readme.md
index e564c6c09b..5b3eb4442f
On 07/23/19 05:58, Bob Feng wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
>
> In order to improve the build performance, we implemented
> multiple-processes AutoGen. This change will reduce 20% time
> for AutoGen phase.
>
> The design document can be got from:
>
Just adding a comment for one item, that isn't directly relevant to what
direction we should take with this patch, but that clarifies where we
got our .dtb's from.
On 2019.07.23 12:00, Michael Brown wrote:
On 23/07/2019 11:34, Leif Lindholm wrote:
On Fri, Jul 19, 2019 at 06:29:07PM +0100,
On Tue, Jul 23, 2019 at 12:00:04PM +0100, Michael Brown wrote:
> > Why is this patch useful?
> > I understand the problem, but we include the .dtb from our own
> > edk2-non-osi tree. And it seems that device tree already provides an
> > alias to support both:
> >
On 23/07/2019 11:34, Leif Lindholm wrote:
On Fri, Jul 19, 2019 at 06:29:07PM +0100, Michael Brown wrote:
Older device trees tend to use the alias "ethernet". Newer device
trees tend to use "ethernet0" since older versions of U-Boot would
skip aliases that do not include an index number. See,
On Fri, Jul 19, 2019 at 06:29:07PM +0100, Michael Brown wrote:
> Older device trees tend to use the alias "ethernet". Newer device
> trees tend to use "ethernet0" since older versions of U-Boot would
> skip aliases that do not include an index number. See, for example,
> Linux kernel commit
On 07/23/19 05:58, Bob Feng wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
>
> To support Ctrl+S and Ctrl+Q, we enable block queue
> for log.
>
> Cc: Liming Gao
> Signed-off-by: Bob Feng
> ---
> BaseTools/Source/Python/Common/EdkLogger.py | 10 ++
>
Reviewed-by: Sami Mujawar
-Original Message-
From: Krzysztof Koch
Sent: 22 July 2019 09:25 AM
To: devel@edk2.groups.io; Krzysztof Koch
Cc: jaben.car...@intel.com; ray...@intel.com; zhichao@intel.com; Sami
Mujawar ; nd
Subject: RE: [edk2-devel] [PATCH v2 0/6] Acpiview table
On 07/23/19 02:32, rebe...@bsdio.com wrote:
> Enable multithreaded builds by default when building OvmfPkg
> using build.sh.
> This can drastically reduce build times. For example, on a
> modern ThreadRipper system the time required to build decreases
> from 3 minutes to 1 minute.
>
>
On 07/22/19 10:15, Ni, Ray wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2008
>
> DxeIpl is responsible to create page table for DXE phase running
> either in long mode or in 32bit mode with certain protection
> mechanism enabled (refer to ToBuildPageTable()).
>
> The patch
On Fri, Jul 19, 2019 at 01:07:54PM +, Gao, Liming wrote:
> > Yes.
> > But perhaps the user isn't the admin, and the admin installs a new
> > version of python without updating the default links, in order to let
> > a different user test the new version. Thinking this will not affect
> > users,
On Mon, Jul 22, 2019 at 03:53:19PM +0100, Anthony PERARD wrote:
> On Mon, Jul 15, 2019 at 04:15:21PM +0200, Roger Pau Monné wrote:
> > On Thu, Jul 04, 2019 at 03:42:22PM +0100, Anthony PERARD wrote:
> > > When running as a Xen PVH guest, there is no CMOS to read the memory
> > > size from. Rework
On 07/22/19 10:15, Ni, Ray wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2008
>
> Signed-off-by: Ray Ni
> Cc: Eric Dong
> Cc: Laszlo Ersek
> ---
> UefiCpuPkg/CpuDxe/CpuPageTable.c | 22 --
> 1 file changed, 20 insertions(+), 2 deletions(-)
>
> diff --git
Later (after more feedback has been collected), I would like to
regression-test this series; for now, just some superficial comments:
On 07/22/19 10:15, Ni, Ray wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2008
>
> MpInitLib is the library that's responsible to wake up APs to
On Tue, Jul 23, 2019 at 12:56:23AM +0200, Laszlo Ersek wrote:
> Hi Mike,
>
> On 07/22/19 20:47, Michael D Kinney wrote:
> > We could consider checking for these type of issues in
> > the ECC tool instead of build and make it an error from
> > ECC instead of a warning.
>
> I'm sorry, my reply to
On Mon, Jul 22, 2019 at 09:28:20PM +0200, Laszlo Ersek wrote:
> On 07/22/19 15:49, Anthony PERARD wrote:
> > On Mon, Jul 15, 2019 at 04:22:19PM +0200, Roger Pau Monné wrote:
> >> On Thu, Jul 04, 2019 at 03:42:07PM +0100, Anthony PERARD wrote:
> >>> ACPI Timer does not work in a PVH guest, but
On Mon, Jul 22, 2019 at 03:58:59PM -0700, Michael D Kinney wrote:
> Update to use S3BootScriptWidth enum values instead of
> EfiBootScriptWidth enum values when calling S3BootScriptLib
> services. This fixes an XCODE5 build failure.
>
Reviewed-by: Gary Lin
> Cc: Zailiang Sun
> Cc: Yi Qian
>
On Mon, Jul 22, 2019 at 03:58:54PM -0700, Michael D Kinney wrote:
> Update calls to S3BootScriptxxx() services to use type
> S3_BOOT_SCRIPT_LIB_WIDTH instead of EFI_BOOT_SCRIPT_WIDTH.
> Fixes XCODE5 build failures.
>
Reviewed-by: Gary Lin
> Cc: Zailiang Sun
> Cc: Yi Qian
> Cc: Gary Lin
>
On 07/23/19 00:52, rebe...@bsdio.com wrote:
> On 2019-07-22 16:16, Laszlo Ersek wrote:
>>
>> should we push patches #1 through #4 from this series?
>>
>> They are independent of python detection (which is still being discussed).
>
>
> I think that's a good idea.
Pushed patches #1 through #4 as
On Mon, Jul 22, 2019 at 03:58:53PM -0700, Michael D Kinney wrote:
> Remove non-ASCII characters from comments in source files. These
> are preventing the build tool from generating report files on
> Linux systems.
>
I see the report file now. Thanks for fixing those characters.
Reviewed-by:
On Tue, Jul 23, 2019 at 07:12:33AM +, Kinney, Michael D wrote:
> Reviewed-by: Michael D Kinney
Thanks!
> > -Original Message-
> > From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
> > Sent: Tuesday, July 9, 2019 9:08 AM
> > To: devel@edk2.groups.io
> > Cc: Kinney, Michael D
> >
On Mon, Jul 22, 2019 at 03:58:51PM -0700, Michael D Kinney wrote:
> Convert all the BAT/sh files used to generate capsules to
> OS independent Python script.
>
Reviewed-by: Gary Lin
> Cc: Zailiang Sun
> Cc: Yi Qian
> Cc: Gary Lin
> Signed-off-by: Michael D Kinney
> Reviewed-by: Zailiang Sun
On 2019-07-23 00:44:06, Laszlo Ersek wrote:
> On 07/23/19 02:00, Rebecca Cran wrote:
> > On 2019-07-22 17:14, Jordan Justen wrote:
> >>
> >> I was suggesting that if they didn't specify -n as a param to
> >> build.sh, then build.sh should not send -n to the edk2 build command.
> >> The effect
(+ Brijesh, and one comment below)
On 07/23/19 04:05, Wu, Hao A wrote:
>> -Original Message-
>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ni,
>> Ray
>> Sent: Monday, July 22, 2019 4:16 PM
>> To: devel@edk2.groups.io
>> Cc: Dong, Eric; Laszlo Ersek
>> Subject:
On 07/23/19 02:00, Rebecca Cran wrote:
> On 2019-07-22 17:14, Jordan Justen wrote:
>>
>> I was suggesting that if they didn't specify -n as a param to
>> build.sh, then build.sh should not send -n to the edk2 build command.
>> The effect would be for the edk2 build command to check
>>
On 07/22/19 19:06, Anthony PERARD wrote:
> On Wed, Jul 10, 2019 at 12:48:57PM +0200, Laszlo Ersek wrote:
>> On 07/04/19 16:42, Anthony PERARD wrote:
>>> On a Xen PVH guest, none of the existing serial or console interface
>>> works, so we add a new one, based on XenConsoleSerialPortLib, and
>>>
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
> Sent: Tuesday, July 9, 2019 9:08 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D
> Subject: [PATCH edk2-platforms 3/3] Silicon/Hisilicon:
> add SPDX license tags to IORT
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
> Sent: Tuesday, July 9, 2019 9:08 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D
> Subject: [PATCH edk2-platforms 2/3] Platform/RaspberryPi:
> add license header to
Reviewed-by: Michael D Kinney
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io]
> On Behalf Of Leif Lindholm
> Sent: Tuesday, July 9, 2019 9:08 AM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Kinney,
> Michael D
> Subject: [edk2-devel] [PATCH
60 matches
Mail list logo
