Mike,
All the CPUID definitions also applies to AMD processors.
There are two Cpuid.h in UefiCpuPkg today.
1. UefiCpuPkg/Include/Register/Cpuid.h
2. UefiCpuPkg/Include/Register/Amd/Cpuid.h
The second one contains additional structures needed by AMD processor.
But first one also applies to AMD
From: Matthew Carlson
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2016
Added arch output to build report so it's easy to tell
which arch is being generated. Useful when multiple versions
of a single module is being emitted for multiple archs.
This patch is going to Added arch output
Cc:
From: Bob Feng
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2015
Not all output works in utf-8, so change the encoding to
the default
This patch is going to fix that issue.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Zhiju.Fan
---
BaseTools/Source/Python/Common/Misc.py
From: Max Knutsen
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2014
Add extra debugging to improve error identification.
Error while processing file if the file is read incorrectly
This patch is going to fix that issue.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Zhiju.Fan
---
From: Sean Brogan
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2013
chinese quotation mark are used in the file
This patch is going to fix that issue.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Zhiju.Fan
---
BaseTools/Source/Python/Pkcs7Sign/Readme.md | 2 +-
1 file changed, 1
Reviewed-by: Jordan Justen
On 2019-07-24 14:44:04, Rebecca Cran wrote:
> Specify the firmware to use via the newer '-drive if=pflash' syntax
> which allows specifying the raw format parameter. This
> avoids warnings with newer version of QEMU.
>
> Signed-off-by: Rebecca Cran
> ---
>
I agree with this enhancement. Please update build spec for new ARCH field.
Besides, this patch is from Mu project, please keep original author.
Thanks
Liming
>-Original Message-
>From: Fan, ZhijuX
>Sent: Thursday, July 25, 2019 8:45 AM
>To: devel@edk2.groups.io
>Cc: Gao, Liming ;
On 2019-07-24 15:57, Jordan Justen wrote:
>
> I think we've tried to keep the range of versions that it works with
> as wide as possible, but I think we could (and perhaps should) discuss
> raising the minimum supported version of qemu. qemu 2.0 is over 5
> years old now. qemu 0.10.0 is over 10
Reviewed-by: Jordan Justen
0dd8d7d556df46c503254d37b22b2b34f6ad12f6
But I still forgot to fix up your git author name after applying the
patch. :\
On 2019-07-24 18:35:40, wrote:
> Signed-off-by: Rebecca Cran
> ---
> OvmfPkg/build.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Signed-off-by: Rebecca Cran
---
OvmfPkg/build.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
index 960382f633..78f44e3a96 100755
--- a/OvmfPkg/build.sh
+++ b/OvmfPkg/build.sh
@@ -40,7 +40,7 @@ ARCH_X64=no
BUILDTARGET=DEBUG
The latest NetsecDxe requires issueing phy reset at the
last stage of initialization to safely exit loopback mode.
However, as a result, it takes a couple of seconds for link state
to get stable, which could cause auto-chosen pxeboot to fail
due to MediaPresent check error.
This patch adds link
NETSEC hardware requires stable RXCLK input upon initialization
triggered with DISCORE = 0.
However, RXCLK input could be unstable depending on phy chipset
and deployed network environment, which could cause NETSEC to
hang up during initialization.
We solve this platform/environment dependent
This patch series is bugfix for the hang-up issue in Netsec driver.
Some linux distributions such as Ubuntu power down the ethernet phy
in reboot. In this case, Netsec initialization fails and
system hungs.
This patch series add the robust netsec initialization,
set ethernet phy as loopback mode
This is a refactoring of phy address handling in Netsec driver.
NETSEC SDK, low level driver for NetsecDxe, did not store phy address.
User should specify the phy address as an argument to
the SDK public functions.
It prevented NETSEC SDK from internally controlling phy,
and it also bothers user
Ray,
I think the use of Include/Register is good for this
type of content. But we may need a Vendor directory.
The general form would be:
Include/Register//.h
Since the definitions being discussed here are from
an Intel public document, perhaps the path should be:
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2015
Not all output works in utf-8, so change the encoding to
the default
This patch is going to fix that issue.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Zhiju.Fan
---
BaseTools/Source/Python/Common/Misc.py | 2
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2016
Added arch output to build report so it's easy to tell
which arch is being generated. Useful when multiple versions
of a single module is being emitted for multiple archs.
This patch is going to Added arch output
Cc: Bob Feng
Cc: Liming
Mike,
Are you suggesting that
1. Copy Cpuid.h in MdePkg/Include/IndustryStandard/
2. Change UefiCpuPkg/Include/Register/Cpuid.h to just include
It looks like a potential issue that there are two "Cpuid.h" public header file
in different folders.
But given the include pattern used: "" VS
"",
Add extra debugging to improve error identification.
Error while processing file if the file is read incorrectly
This patch is going to fix that issue.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Zhiju.Fan
---
BaseTools/Source/Python/AutoGen/StrGather.py | 16 ++--
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2013
chinese quotation mark are used in the file
This patch is going to fix that issue.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Zhiju.Fan
---
BaseTools/Source/Python/Pkcs7Sign/Readme.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Jordan Justen
On 2019-07-24 14:44:05, Rebecca Cran wrote:
> $ADD_QEMU_HDA was added because QEMU used to refuse to run without a
> disk. Since newer versions run without any disks, remove it.
>
> Signed-off-by: Rebecca Cran
> ---
> OvmfPkg/build.sh | 14 --
> 1 file
On 2019-07-24 05:21:35, Philippe Mathieu-Daudé wrote:
> On 7/23/19 2:32 AM, rebe...@bsdio.com wrote:
> > Enable multithreaded builds by default when building OvmfPkg
> > using build.sh.
> > This can drastically reduce build times. For example, on a
> > modern ThreadRipper system the time required
On 2019-07-24 10:39:20, Philippe Mathieu-Daudé wrote:
> On 7/24/19 7:26 PM, Jordan Justen wrote:
> > Hmm, it looks like qemu 2.0 is when the multiple flash device support
> > was added: https://wiki.qemu.org/ChangeLog/2.0
> >
> > The build.sh script currently attempts to detect 1.6 and newer for
On 2019-07-24 06:30, Philippe Mathieu-Daudé wrote:
>
> Why add $() ?
>
>> then
>># build the tools if they don't yet exist. BinWrapper scheme
>>echo Building tools no $EDK_TOOLS_PATH/Source/C/bin directory
>>
I've sent another copy of this patch, in the v2 series of
OvmfPkg/build.sh
Specify the firmware to use via the newer '-drive if=pflash' syntax
which allows specifying the raw format parameter. This
avoids warnings with newer version of QEMU.
Signed-off-by: Rebecca Cran
---
OvmfPkg/build.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Signed-off-by: Rebecca Cran
---
OvmfPkg/build.sh | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
index e94aa2a37e..1c28e65404 100755
--- a/OvmfPkg/build.sh
+++ b/OvmfPkg/build.sh
@@ -174,11 +174,11 @@ case $PROCESSOR in
#
On 24/07/2019 19:53, Leif Lindholm wrote:
SanitizePSCI ();
CleanMemoryNodes ();
CleanSimpleFramebuffer ();
+ FixEthernetAliases ();
...would it be worth having a return value here and Print()ing a
message visible regardless of build profile if this function fails?
Yes, I think
$ADD_QEMU_HDA was added because QEMU used to refuse to run without a
disk. Since newer versions run without any disks, remove it.
Signed-off-by: Rebecca Cran
---
OvmfPkg/build.sh | 14 --
1 file changed, 14 deletions(-)
diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
index
On Wed, Jul 24, 2019 at 09:53:00PM +0100, Michael Brown wrote:
> On 24/07/2019 19:53, Leif Lindholm wrote:
> > > SanitizePSCI ();
> > > CleanMemoryNodes ();
> > > CleanSimpleFramebuffer ();
> > > + FixEthernetAliases ();
> >
> > ...would it be worth having a return value here and
On 2019-07-23 20:40, Jordan Justen wrote:
>
> We exit after running qemu. In other words, if qemu is present on the
> command line, then we run qemu, but don't try to build OVMF.
>
> One use case for running qemu multiple times without building is to
> preserve non-volatile variables across
On 2019-07-24 11:39, Philippe Mathieu-Daudé wrote:
>
> Where can I find the range of QEMU versions used by EDK2?
> I'm trying to understand why it is important to still maintain scripts
> for a such old version.
I was going to suggest it was because some distros move pretty slowly -
for example
Hi Michael,
śr., 24 lip 2019 o 00:58 Michael D Kinney
napisał(a):
> https://bugzilla.tianocore.org/show_bug.cgi?id=1373
>
> Replace BSD 2-Clause License with BSD+Patent License. This change is
> based on the following emails:
>
>
Hi Michael,
Thanks for this.
One comment below.
On Wed, Jul 24, 2019 at 03:31:14PM +0100, Michael Brown wrote:
> Older device trees tend to use the alias "ethernet". Newer device
> trees tend to use "ethernet0" since older versions of U-Boot would
> skip aliases that do not include an index
On Tue, Jul 23, 2019 at 03:58:01PM -0700, Michael D Kinney wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=1373
>
> Replace BSD 2-Clause License with BSD+Patent License. This change is
> based on the following emails:
>
>
Committed:
https://github.com/tianocore/edk2-non-osi/commit/723db5259e0bb602893a6d531af4f0d8448333e6
-Original Message-
From: devel@edk2.groups.io On Behalf Of Nate DeSimone
Sent: Monday, July 22, 2019 9:57 PM
To: Agyeman, Prince ; devel@edk2.groups.io
Cc: Gao, Liming ; Sinha, Ankit ;
On 7/24/19 7:26 PM, Jordan Justen wrote:
> On 2019-07-24 05:27:28, Philippe Mathieu-Daudé wrote:
>> On 7/24/19 4:54 AM, Jordan Justen wrote:
>>> On 2019-07-23 18:51:00, wrote:
Specify the firmware to use via the newer '-drive if=pflash' syntax
which allows specifying the raw format and
On 2019-07-24 05:27:28, Philippe Mathieu-Daudé wrote:
> On 7/24/19 4:54 AM, Jordan Justen wrote:
> > On 2019-07-23 18:51:00, wrote:
> >> Specify the firmware to use via the newer '-drive if=pflash' syntax
> >> which allows specifying the raw format and readonly parameters. This
> >> avoids
Hi Ray,
Given that there may be register definitions for other
CPUs or devices added to MdePkg in the future, should
an extra directory level be added? Doing that would
break source compatibility for existing components that
use #include from UefiCpuPkg. We could
keep Cpuid.h in UefiCpuPkg,
On Wed, Jul 24, 2019 at 03:17:56PM +, Gao, Liming wrote:
> > Would it be feasible to update the --hash functionality to make use of
> > the include dependencies extracted from the source files? (Clearly, we
> > know when the source files change, so we would also know when we would
> > need to
Rebecca,
If you are interested, I prototyped using a python
script and POSTBUILD statement in the DSC file to
support 'run' targets for OVMF in the following
branch. This potentially allows the same code to
be used for all host OS environments to launch QEMU.
Thanks Bob, Liming.
GetMaintainer.py patch pushed as 7d0a56c4a125
On Wed, Jul 24, 2019 at 02:03:34AM +, Feng, Bob C wrote:
> Patch looks fine for me.
>
> Reviewed-by: Bob Feng
>
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Leif
>
On 7/23/19 2:48 AM, Laszlo Ersek wrote:
> (+ Brijesh, and one comment below)
>
> On 07/23/19 04:05, Wu, Hao A wrote:
>>> -Original Message-
>>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ni,
>>> Ray
>>> Sent: Monday, July 22, 2019 4:16 PM
>>> To:
Older device trees tend to use the alias "ethernet". Newer device
trees tend to use "ethernet0" since older versions of U-Boot would
skip aliases that do not include an index number. See, for example,
Linux kernel commit 10b6c0c ("ARM: dts: bcm2835: add index to the
ethernet alias") and U-Boot
This standalone patch fixes FdtDxe.c to handle newer Raspberry Pi
device trees using the "ethernet0" alias (while retaining
compatibility with older device trees).
Changes from v1: as per Leif's request, the patch now ensures that
both "ethernet" and "ethernet0" aliases exist within the device
On Tue, Jul 23, 2019 at 11:42:07AM +0200, Roger Pau Monné wrote:
> On Mon, Jul 22, 2019 at 03:53:19PM +0100, Anthony PERARD wrote:
> > On Mon, Jul 15, 2019 at 04:15:21PM +0200, Roger Pau Monné wrote:
> > > On Thu, Jul 04, 2019 at 03:42:22PM +0100, Anthony PERARD wrote:
> > > > + // error
Leif:
> -Original Message-
> From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
> Sent: Tuesday, July 23, 2019 5:45 PM
> To: Gao, Liming
> Cc: devel@edk2.groups.io; Laszlo Ersek ; Rebecca Cran
> ; Feng, Bob C ;
> Kinney, Michael D ; af...@apple.com
> Subject: Re: [edk2-devel] [PATCH
Leif:
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Leif
> Lindholm
> Sent: Tuesday, July 23, 2019 9:26 PM
> To: Gao, Liming
> Cc: devel@edk2.groups.io; Laszlo Ersek ; Kinney, Michael D
> ; Ard Biesheuvel
> ; Wang, Jian J ; Ye, Ting
>
>
On 2019-07-24 06:30, Philippe Mathieu-Daudé wrote:
>
>> -elif [[ ( -f `which build` || -f `which GenFv` ) && ! -d
>> $EDK_TOOLS_PATH/Source/C/bin ]];
>> +elif [[ ( $(command -v build) || $(command -v GenFv) ) && ! -d
>> $EDK_TOOLS_PATH/Source/C/bin ]];
> Why add $() ?
They're needed when
Hi Rebecca,
On 7/24/19 2:49 AM, rebe...@bsdio.com wrote:
> Signed-off-by: Rebecca Cran
> ---
> OvmfPkg/build.sh | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
> index e94aa2a37e..1c28e65404 100755
> --- a/OvmfPkg/build.sh
On 7/24/19 4:54 AM, Jordan Justen wrote:
> On 2019-07-23 18:51:00, wrote:
>> Specify the firmware to use via the newer '-drive if=pflash' syntax
>> which allows specifying the raw format and readonly parameters. This
>> avoids warnings with newer version of QEMU.
>>
>> Signed-off-by: Rebecca Cran
On 7/18/19 9:34 AM, Bob Feng wrote:
> This patch is going to sort the file list in generated
> Makefile. This change make the autogen makefile easy to
> compare.
Good idea.
>
> Cc: Liming Gao
> Signed-off-by: Bob Feng
Reviewed-by: Philippe Mathieu-Daude
> ---
>
On 7/23/19 2:32 AM, rebe...@bsdio.com wrote:
> Enable multithreaded builds by default when building OvmfPkg
> using build.sh.
> This can drastically reduce build times. For example, on a
> modern ThreadRipper system the time required to build decreases
> from 3 minutes to 1 minute.
>
>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2008
Signed-off-by: Ray Ni
Cc: Eric Dong
Cc: Laszlo Ersek
---
UefiCpuPkg/CpuDxe/CpuPageTable.c | 18 +-
UefiCpuPkg/CpuDxe/CpuPageTable.h | 3 ++-
2 files changed, 19 insertions(+), 2 deletions(-)
diff --git
Today's code defines macros like CR0_PG, CR0_WP, CR4_PSE, CR4_PAE
when checking whether individual bits are set in CR0 or CR4 register.
The patch changes the code to use IA32_CR0 and IA32_CR4 structure
defined in MdePkg/Include/Library/BaseLib.h so that the module
local macros can be removed.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2008
DxeIpl is responsible to create page table for DXE phase running
either in long mode or in 32bit mode with certain protection
mechanism enabled (refer to ToBuildPageTable()).
The patch updates DxeIpl to create 5-level page table for DXE
v2:
Refined the patch according to reviewers' all comments except:
0A0h cannot be changed to A0h or build fails.
A big change in this patch is Cpuid.h is moved from UefiCpuPkg to MdePkg.
The move is based on real requirement when certain modules that cannot
depend on UefiCpuPkg
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2008
The PCD indicates if 5-Level Paging will be enabled in long mode.
5-Level Paging will not be enabled when the PCD is TRUE but CPU
doesn't support 5-Level Paging.
Signed-off-by: Ray Ni
Cc: Eric Dong
Cc: Laszlo Ersek
Cc: Hao A Wu
Cc:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2008
MdeModulePkg/DxeIpl needs to get CPUID output for CPU
5-level paging capability detection.
In order to use the macros/structures defined in
UefiCpuPkg/Include/Register/Cpuid.h, the patch moves
Cpuid.h to MdePkg/Include/Register/ directory.
From: Haojian Zhuang
It's used to create NonDiscoverableDevice in embedded platform. Since
there's no PCI bus.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Chris Co
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Haojian Zhuang
Signed-off-by: Tien Hock, Loh
---
From: Haojian Zhuang
Add PlatformDwMmc protocol. It's used to set properties of DwMmc
device in platform driver.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Chris Co
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Haojian Zhuang
---
Hello:
Could you please clarify if there is any plan to support Static IP based HTTP
Boot.
In order to perform the HTTP Boot it requires an server which leases the DHCP
IP, since it performs the DHCP Process before perform the HTTP Boot.
Assume in the case where the server is running HTTP
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1973
Add definition for new EDKII_PEI_MP_SERVICES2_PPI.
It includes all APIs existed in EFI_PEI_MP_SERVICES_PPI
and add new API EDKII_PEI_MP_SERVICES_STARTUP_ALL_CPUS.
Cc: Ray Ni
Cc: Laszlo Ersek
Cc: Chandana Kumar
Cc: Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1973
For semaphore type register, it required all processors to do the
task at the same time.
Current logic begins BSP's task after all APs have finished their tasks.
This will caused set semaphore task hang if semaphore has package
level type.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1973
Add new MpInitLibStartupAllCPUs API uses to start all processors
at the same time.
Cc: Ray Ni
Cc: Laszlo Ersek
Cc: Chandana Kumar
Cc: Star Zeng
Signed-off-by: Eric Dong
Reviewed-by: Ray Ni
---
UefiCpuPkg/Include/Library/MpInitLib.h
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1973
Add new MpInitLibStartupAllCPUs API uses to start all processors
at the same time.
Cc: Ray Ni
Cc: Laszlo Ersek
Cc: Chandana Kumar
Cc: Star Zeng
Signed-off-by: Eric Dong
Reviewed-by: Ray Ni
---
UefiCpuPkg/Library/MpInitLib/DxeMpLib.c
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1973
Add new MpInitLibStartupAllCPUs API uses to start all processors
at the same time.
Cc: Ray Ni
Cc: Laszlo Ersek
Cc: Chandana Kumar
Cc: Star Zeng
Signed-off-by: Eric Dong
---
UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.c | 35
v3 changes:
1. Fix function header definition conflict issue.
2. Update copyright.
V2 changes:
1. Enable new API for MpInitLibUp.
2. Remove useless parameter FailedCpuList.
3. Rename StartupAllAPsWorker to StartupAllCpusWorker.
V1 Changes:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1973
> -Original Message-
> From: Laszlo Ersek
> Sent: Tuesday, July 23, 2019 5:23 PM
> To: devel@edk2.groups.io; Ni, Ray
> Cc: Dong, Eric
> Subject: Re: [edk2-devel] [PATCH 2/4] UefiCpuPkg/CpuDxe: Support parsing
> 5-level page table
>
> On 07/22/19 10:15, Ni, Ray wrote:
> > REF:
> -Original Message-
> From: Laszlo Ersek
> Sent: Tuesday, July 23, 2019 5:15 PM
> To: devel@edk2.groups.io; Ni, Ray
> Cc: Dong, Eric
> Subject: Re: [edk2-devel] [PATCH 1/4] UefiCpuPkg/MpInitLib: Enable 5-level
> paging for AP when BSP's enabled
>
> Later (after more feedback has been
On Wed, 24 Jul 2019 at 01:14, Leif Lindholm wrote:
>
> On Mon, Jul 22, 2019 at 08:56:36PM +0900, Masahisa Kojima wrote:
> > The latest NetsecDxe requires issueing phy reset at the
> > last stage of initialization to safely exit loopback mode.
> > However, as a result, it takes a couple of seconds
70 matches
Mail list logo
