Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-12 Thread Dong, Eric
Hi Donald, Thanks for your explanation. In this case, Reviewed-by: Eric Dong Thanks, Eric > -Original Message- > From: Kuo, Donald > Sent: Tuesday, August 13, 2019 11:26 AM > To: Dong, Eric ; devel@edk2.groups.io > Cc: Ni, Ray ; Zeng, Star ; Chan, > Amy ; Chaganty, Rangasai V > >

Re: [edk2-devel] [Patch 1/1] BaseTools: Fix incremental build bug

2019-08-12 Thread Liming Gao
Reviewed-by: Liming Gao >-Original Message- >From: Feng, Bob C >Sent: Tuesday, August 13, 2019 12:12 PM >To: devel@edk2.groups.io >Cc: Gao, Liming ; Feng, Bob C >Subject: [Patch 1/1] BaseTools: Fix incremental build bug > >https://bugzilla.tianocore.org/show_bug.cgi?id=2078 > >This is a

Re: [edk2-devel] [Patch] BaseTools: Add "-" in a re to parse line in .map file

2019-08-12 Thread Liming Gao
Reviewed-by: Liming Gao >-Original Message- >From: Feng, Bob C >Sent: Tuesday, August 13, 2019 9:58 AM >To: devel@edk2.groups.io >Cc: Gao, Liming ; Feng, Bob C >Subject: [Patch] BaseTools: Add "-" in a re to parse line in .map file > >https://bugzilla.tianocore.org/show_bug.cgi?id=2058

[edk2-devel] [Patch 1/1] BaseTools: Fix incremental build bug

2019-08-12 Thread Bob Feng
https://bugzilla.tianocore.org/show_bug.cgi?id=2078 This is a build tool regression issue that is introduced by multiple-process-autogen. The workspace timestamp value is not pass to module autogen object correctly, so build tool does not detect the change of .dsc and ignore the autogen. This

[edk2-devel] [PATCH v2 3/4] BaseTools: Change the [Arch][Name] module key in Build cache

2019-08-12 Thread Steven Shi
From: "Shi, Steven" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1951 Current build cache use the module's [self.Arch][self.Name] info as the ModuleAutoGen object key in hash list and dictionary. The [self.Arch][self.Name] is not safe as the module key because there could be two modules

[edk2-devel] [PATCH v2 4/4] BaseTools: Add GenFds multi-thread support in build cache

2019-08-12 Thread Steven Shi
From: "Shi, Steven" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1923 Fix the issue that the GenFds multi-thread will build fail if enable the build cache together. Cc: Liming Gao Cc: Bob Feng Signed-off-by: Steven Shi --- BaseTools/Source/Python/AutoGen/ModuleAutoGen.py | 23

[edk2-devel] [PATCH v2 2/4] BaseTools: Print first cache missing file for build cachle

2019-08-12 Thread Steven Shi
From: "Shi, Steven" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1925 When a module build cache miss, add support to print the first cache missing file path and name. Cc: Liming Gao Cc: Bob Feng Signed-off-by: Steven Shi --- BaseTools/Source/Python/AutoGen/AutoGenWorker.py | 2 ++

[edk2-devel] [PATCH v2 0/4] Build cache enhancement

2019-08-12 Thread Steven Shi
From: "Shi, Steven" Enhance the edk2 build cache with below patches: Patch 01/04: Improve the cache hit rate through new cache checkpoint and hash algorithm Patch 02/04: Print more info to explain why a module build cache miss Patch 03/04: Fix the unsafe [self.Arch][self.Name] key usage in

[edk2-devel] [PATCH v2 1/4] BaseTools: Improve the cache hit in the edk2 build cache

2019-08-12 Thread Steven Shi
From: "Shi, Steven" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1927 Current cache hash algorithm does not parse and generate the makefile to get the accurate dependency files for a module. It instead use the platform and package meta files to get the module depenedency in a quick but

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-12 Thread Donald Kuo
Hi Eric, The CPUID Leaf 0x1:EDX.TSC[bit 4] is to check capability for IA32_TIME_STAMP_COUNTER MSR and RDTSC instruction which defined in IA32 SDM chapter 17.17 And what we implement is based on IA32 SDM Chapter 18.7 for CPU core XTAL clock frequency which is from CPUID Leaf 0x15 and new TSC

Re: [edk2-devel] [edk2-test][PATCH V3 2/3] Adding HII to IHVSCT

2019-08-12 Thread Eric Jin
Hello Shrishail, The patch set format is strange to me and have issue when I try to apply them. Could you please check or send to me(eric@intel.com) your patch series as attachment? Thanks. @@ -279,7 +279,8 @@ rem copy %ProcessorType%\IhvUsbHcTest.efi

Re: [edk2-devel] [PATCHv3 0/4] Add EDKII_UFS_HC_PLATFORM_PROTOCOL to support platform specific programming of UFS host controllers

2019-08-12 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Wu, Hao A > Sent: Monday, August 12, 2019 10:39 AM > To: Albecki, Mateusz; devel@edk2.groups.io > Cc: Andrew Fish; Laszlo Ersek; Leif Lindholm; Kinney, Michael D; Gao, Liming > Subject: Re:

Re: [edk2-devel] [Patch v2 0/6] Add "test then write" mechanism.

2019-08-12 Thread Dong, Eric
Hi Laszlo, Yes, I already checked IA32 build. As Ray is leaving these days, can you help to review this serial? Thanks, Eric > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Laszlo Ersek > Sent: Monday, August 12, 2019 10:15 PM > To: Dong,

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-12 Thread Dong, Eric
Hi Donald, Do you think it's necessary to check the TIME_STAMP_COUNTER capability before using it? I see SDM has CPUID(0x01) which return the capability of TIME_STAMP_COUNTER. Thanks, Eric > -Original Message- > From: Kuo, Donald > Sent: Monday, August 12, 2019 7:23 PM > To:

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/DxeIplPeim: Relocate the operation of PageMapLevel5Entry++

2019-08-12 Thread Dong, Eric
Agree with Dandan's comments. With that update, Reviewed-by: Eric Dong > -Original Message- > From: Bi, Dandan > Sent: Tuesday, August 13, 2019 10:04 AM > To: Zhang, Shenglei ; devel@edk2.groups.io > Cc: Gao, Liming ; Wu, Hao A ; > Laszlo Ersek ; Dong, Eric > Subject: RE: [PATCH 1/1]

[edk2-devel] NetworkPkg: sending a second HTTPS request without tearing down instance in-between causes a crash

2019-08-12 Thread rebecca
I've been working to debug a problem I've been seeing booting FreeBSD via HTTPS. I filed a BZ at https://bugzilla.tianocore.org/show_bug.cgi?id=1917 . I've done some more debugging and tracked the issue down to attempting to request a file twice without tearing down the http instance

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/DxeIplPeim: Relocate the operation of PageMapLevel5Entry++

2019-08-12 Thread Dandan Bi
> -Original Message- > From: Zhang, Shenglei > Sent: Monday, August 12, 2019 2:25 PM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Gao, Liming ; > Wu, Hao A ; Laszlo Ersek ; Dong, > Eric > Subject: [PATCH 1/1] MdeModulePkg/DxeIplPeim: Relocate the operation of > PageMapLevel5Entry++ > >

Re: [edk2-devel] [edk2-non-osi patch 1/1] SimicsICH10SiliconBinPkg: Add UNDI ROM for SIMICS QSP Platform

2019-08-12 Thread Nate DeSimone
Hi David, I would prefer if we follow Pascal casing and rename this package to SimicsIch10SiliconBinPkg (instead of SimicsICH10SiliconBinPkg). Also, I think it would be good if we can also add owners for the new packages to the Maintainers.txt file. (SimicsIch10SiliconBinPkg, SimicsX58SktPkg,

[edk2-devel] [Patch] BaseTools: Add "-" in a re to parse line in .map file

2019-08-12 Thread Bob Feng
https://bugzilla.tianocore.org/show_bug.cgi?id=2058 If there are multiple module instances with different guid used in .dsc file, the temp path of the module will contain 8-4-4-4-12 format guid string. So "-" need to be added into the regular expression for parsing it correctly. Cc: Liming Gao

Re: [edk2-devel][edk2-platfoms][PATCH v2 06/22] Platform/CoreDxeInclude.dsc: Add ResetUtilityLib to dsc file

2019-08-12 Thread Kubacki, Michael A
Reviewed-by: Michael Kubacki > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Gao, > Zhichao > Sent: Sunday, August 11, 2019 8:05 PM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Leif Lindholm > ; Kinney, Michael D ; > Kubacki, Michael A ;

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/DxeIplPeim: Relocate the operation of PageMapLevel5Entry++

2019-08-12 Thread Wu, Hao A
Hello Eric, Could you help to take a look at this one as well? > -Original Message- > From: Zhang, Shenglei > Sent: Monday, August 12, 2019 2:25 PM > To: devel@edk2.groups.io > Cc: Bi, Dandan; Gao, Liming; Wu, Hao A; Laszlo Ersek; Dong, Eric > Subject: [PATCH 1/1]

Re: [edk2-devel] [PATCH v2 3/3] IntelFsp2Pkg/FspSecCore: Add missing header file in INF file

2019-08-12 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Zhang, Shenglei Sent: Sunday, August 11, 2019 11:23 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Zeng, Star Subject: [edk2-devel] [PATCH v2 3/3] IntelFsp2Pkg/FspSecCore: Add

Re: [edk2-devel][edk2-platfoms][PATCH v2 06/22] Platform/CoreDxeInclude.dsc: Add ResetUtilityLib to dsc file

2019-08-12 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Gao, Zhichao Sent: Sunday, August 11, 2019 8:05 PM To: devel@edk2.groups.io Cc: Ard Biesheuvel ; Leif Lindholm ; Kinney, Michael D ; Kubacki, Michael A ; Chiu, Chasel ; Desimone, Nathaniel L ; Gao,

Re: [edk2-devel] [edk2-platforms] [PATCH] ClevoOpenBoardPkg: Remove batch build scripts

2019-08-12 Thread Kubacki, Michael A
Reviewed-by: Michael Kubacki > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Agyeman, Prince > Sent: Friday, August 9, 2019 9:35 AM > To: devel@edk2.groups.io > Subject: [edk2-devel] [edk2-platforms] [PATCH] ClevoOpenBoardPkg: Remove > batch

Re: [edk2-devel] [PATCH 0/3] Move MdeModulePkg/Include/Protocol/Dpc.h to NetworkPkg

2019-08-12 Thread Wu, Hao A
> -Original Message- > From: Zhang, Shenglei > Sent: Monday, August 12, 2019 4:37 PM > To: devel@edk2.groups.io > Cc: Fu, Siyuan; Wu, Jiaxin; Wang, Jian J; Wu, Hao A > Subject: [PATCH 0/3] Move MdeModulePkg/Include/Protocol/Dpc.h to > NetworkPkg > > The file

Re: [edk2-devel] [edk2-platforms] [PATCH v2] Platform/Intel: Update Readme.md to point to edk2-non-osi master branch

2019-08-12 Thread Nate DeSimone
Pushed: https://github.com/tianocore/edk2-platforms/commit/2c93b663817b69c809a329f4920f9584b1fe5eb8 -Original Message- From: Kubacki, Michael A Sent: Monday, August 12, 2019 8:57 AM To: Desimone, Nathaniel L ; devel@edk2.groups.io Cc: Andrew Fish ; Laszlo Ersek ; Leif Lindholm ;

Re: [edk2-devel] [PATCH v2 0/3] Fix warning message issues

2019-08-12 Thread Carsey, Jaben
Thanks. I had not checked each of the patches in the set, only the one CC'd to me and this one. Thanks -Jaben > -Original Message- > From: Zhang, Shenglei > Sent: Monday, August 12, 2019 5:53 PM > To: Carsey, Jaben ; devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A > ; Ni, Ray ;

Re: [edk2-devel] [RFC] BZ 1772 MdeModulePkg: Transfer reset data for 201908 stable tag

2019-08-12 Thread Gao, Zhichao
It is an recommended feature change. But the specific function isn't implemented with any platform yet. So it wouldn't affect any section of the edk2. And it changed a lot of platform dsc files(or module package dsc files) in both edk2 and edk2-paltform. That may take time for the review work.

Re: [edk2-devel] [RFC] BZ 1772 MdeModulePkg: Transfer reset data for 201908 stable tag

2019-08-12 Thread Liming Gao
Zhichao: Do you propose this feature for 201908 stable tag? From: Gao, Zhichao Sent: Monday, August 12, 2019 4:33 PM To: r...@edk2.groups.io Cc: devel@edk2.groups.io; Gao, Liming Subject: [RFC] BZ 1772 MdeModulePkg: Transfer reset data HI, BZ:

[edk2-devel] ovmf build fail with gcc 4.8.5

2019-08-12 Thread Chen, Farrah
Hi, When build ovmf with the latest two commits of master branch, we meet error on Red Hat 7.6 with gcc version 4.8.5, but succeed on Red Hat 8.0 with gcc version 8.2.1. Steps: git clone https://github.com/tianocore/edk2.git cd edk2 git submodule init git submodule update -recursive

Re: [edk2-devel] [PATCH v6 1/1] Platform: Intel: Add Stratix 10 platform support

2019-08-12 Thread Loh, Tien Hock
Hi Leif, I'll update it and send another patch on top of the previously reviewed patch. Thanks! > -Original Message- > From: Leif Lindholm > Sent: Friday, August 9, 2019 6:16 PM > To: Loh, Tien Hock > Cc: Kinney, Michael D ; devel@edk2.groups.io; > thlo...@gmail.com; Ard Biesheuvel

Re: [edk2-devel] [PATCH v2 0/3] Fix warning message issues

2019-08-12 Thread Zhang, Shenglei
Jaben: I add the v2 message below "---". And here is the link for v2 patch. https://edk2.groups.io/g/devel/message/45398?p=,,,20,0,0,0::Created,,MdeModulePkg%3A+Add+missing+header+files+in+INF+files,20,2,0,32838103 Thanks, Shenglei > -Original Message- > From: Carsey, Jaben > Sent:

Re: [edk2-devel] [Patch] MdeModulePkg DxeCore: Fix for missing MAT update

2019-08-12 Thread Michael D Kinney
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] > On Behalf Of Laszlo Ersek > Sent: Monday, August 12, 2019 9:24 AM > To: devel@edk2.groups.io; Gao, Liming > > Cc: Mike Turner ; Wang, Jian J > ; Wu, Hao A ; > Bi, Dandan > Subject: Re: [edk2-devel]

Re: [edk2-devel] [PATCH] MdePkg: Add STATIC_ASSERT macro

2019-08-12 Thread Michael D Kinney
Hi Vitaly, Thanks for the contribution. I see you are using _MSC_VER. The rest of Base.h uses _MSC_EXTENSIONs and only if that is defined is _MSC_VER used and _MSC_VER is only used if a specific version value check is required. What version of VS introduced this feature? We can define this

Re: [edk2-devel] static data in dxe_runtime modules

2019-08-12 Thread Roman Kagan
On Fri, Aug 09, 2019 at 04:07:00PM +, Roman Kagan via Groups.Io wrote: > On Thu, Aug 08, 2019 at 07:39:14PM +0200, Laszlo Ersek wrote: > > On 08/07/19 19:41, Andrew Fish wrote: > > >> On Aug 7, 2019, at 10:29 AM, Laszlo Ersek wrote: > > >> On 08/05/19 12:18, Roman Kagan wrote: > > >>> On Sat,

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option

2019-08-12 Thread Jonathan Watt
I see this landed last week. Many thanks to everyone for their input and for getting this landed. Jonathan On 05/08/2019 01:51, Gao, Zhichao wrote: > Agree. I would prepare this patch for push. > > Thanks, > Zhichao > >> -Original Message- >> From: Carsey, Jaben >> Sent: Saturday,

Re: [edk2-devel] [Patch] MdeModulePkg DxeCore: Fix for missing MAT update

2019-08-12 Thread Laszlo Ersek
On 08/10/19 16:10, Liming Gao wrote: > From: Mike Turner > > The Fpdt driver (FirmwarePerformanceDxe) saves a memory address across > reboots, and then does an AllocatePage for that memory address. > If, on this boot, that memory comes from a Runtime memory bucket, > the MAT table is not

Re: [edk2-devel] [edk2-platforms] [PATCH] Platform/Intel: Update Readme.md to point to edk2-non-osi master branch

2019-08-12 Thread Kubacki, Michael A
I also support moving the MinPlatform platforms to a dedicated directory. Leif, please let me know if I can be of any help to prepare the RFC. Thanks, Michael > -Original Message- > From: Desimone, Nathaniel L > Sent: Sunday, August 11, 2019 4:53 PM > To: Leif Lindholm > Cc:

Re: [edk2-devel] [edk2-platforms] [PATCH v2] Platform/Intel: Update Readme.md to point to edk2-non-osi master branch

2019-08-12 Thread Kubacki, Michael A
Reviewed-by: Michael Kubacki > -Original Message- > From: Desimone, Nathaniel L > Sent: Sunday, August 11, 2019 4:45 PM > To: devel@edk2.groups.io > Cc: Andrew Fish ; Laszlo Ersek ; Leif > Lindholm ; Kinney, Michael D > ; Kubacki, Michael A > ; Sinha, Ankit ; Chiu, > Chasel > Subject:

Re: [edk2-devel] [Patch V3] BaseTools: Fix checking for Sources section in INF file

2019-08-12 Thread Liming Gao
Tested-by: Liming Gao > -Original Message- > From: Rodriguez, Christian > Sent: Monday, August 12, 2019 11:32 PM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > Subject: [Patch V3] BaseTools: Fix checking for Sources section in INF file > > BZ:

[edk2-devel] [Patch V3] BaseTools: Fix checking for Sources section in INF file

2019-08-12 Thread Christian Rodriguez
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1804 The check to see if [Sources] section lists all the header type files of a module is missing the exclusion of source files that fall under the scope of Package includes. This change adds the exclusions. Signed-off-by: Christian Rodriguez

Re: [edk2-devel] [PATCH v4 11/15] UefiPayloadPkg: Add ResetUtilityLib to UefiPayloadPkgIa32X64.dsc

2019-08-12 Thread Guo Dong
Reviewed-by: Dong, Guo Thanks, Guo > -Original Message- > From: Gao, Zhichao > Sent: Sunday, August 11, 2019 8:08 PM > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Dong, Guo > ; You, Benjamin ; Gao, > Liming > Subject: [PATCH v4 11/15] UefiPayloadPkg: Add ResetUtilityLib to >

Re: [edk2-devel] [PATCH v4 10/15] UefiPayloadPkg/UefiPayloadPkgIa32.dsc: Add ResetUtilityLib to dsc file

2019-08-12 Thread Guo Dong
Reviewed-by: Dong, Guo Thanks, Guo > -Original Message- > From: Gao, Zhichao > Sent: Sunday, August 11, 2019 8:08 PM > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Dong, Guo > ; You, Benjamin ; Gao, > Liming > Subject: [PATCH v4 10/15] UefiPayloadPkg/UefiPayloadPkgIa32.dsc: Add >

Re: [edk2-devel] [PATCH V2 00/10] Multiple Controllers Support solution

2019-08-12 Thread Eric Jin
Liming, Thank you for comment. We will update GetLowestSupportedVersion() API function header to include Private param when we push the code to repo. Thanks. Best Regards Eric -Original Message- From: Gao, Liming Sent: Monday, August 12, 2019 5:24 PM To: Jin, Eric ;

Re: [edk2-devel] [PATCH v4 00/35] Specific platform to run OVMF in Xen PVH and HVM guests

2019-08-12 Thread Anthony PERARD
On Tue, Jul 30, 2019 at 03:10:13PM +0200, Laszlo Ersek wrote: > Hi Anthony, > > On 07/29/19 17:39, Anthony PERARD wrote: > > Patch series available in this git branch: > > https://xenbits.xen.org/git-http/people/aperard/ovmf.git > > br.platform-xen-pvh-v4 > > > > Changes in v4: > > - patch

Re: [edk2-devel] [PATCH v2 0/3] Fix warning message issues

2019-08-12 Thread Carsey, Jaben
What changed in v2? Thanks -Jaben > -Original Message- > From: Zhang, Shenglei > Sent: Sunday, August 11, 2019 11:23 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A > ; Carsey, Jaben ; Ni, Ray > ; Gao, Zhichao ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Zeng, Star >

Re: [edk2-devel] [PATCH v4 29/35] OvmfPkg/OvmfXen: Override PcdFSBClock to Xen vLAPIC timer frequency

2019-08-12 Thread Anthony PERARD
On Thu, Aug 08, 2019 at 05:18:15PM +0200, Roger Pau Monné wrote: > On Thu, Aug 08, 2019 at 03:26:41PM +0100, Anthony PERARD wrote: > > So EDKII doesn't have that capability, FSBClock is a build time value > > and can't be changed at run time. But OVMF (on KVM or HVM) doesn't use > > that value at

Re: [edk2-devel] [PATCH] ShellPkg/UefiShellLevel2CommansLib: Pointer Resonse should be checked

2019-08-12 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey Thanks -Jaben > -Original Message- > From: Gao, Zhichao > Sent: Sunday, August 11, 2019 5:36 PM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray > Subject: [PATCH] ShellPkg/UefiShellLevel2CommansLib: Pointer Resonse > should be checked > > REF:

[edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-12 Thread Donald Kuo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1909 Cc: Ray Ni Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Donald Kuo --- .../Library/BaseCpuTimerLib/BaseCpuTimerLib.c | 40 +++ .../Library/BaseCpuTimerLib/BaseCpuTimerLib.inf

[edk2-devel] [PATCH] UefiCpuPkg: Add new TimerLib for CPUID Leaf 0x15 Core Crystal Clock Frequency

2019-08-12 Thread Donald Kuo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1909 Cc: Ray Ni Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Donald Kuo --- .../Library/BaseCpuTimerLib/BaseCpuTimerLib.c | 40 +++ .../Library/BaseCpuTimerLib/BaseCpuTimerLib.inf

[edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-12 Thread Donald Kuo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1909 Cc: Ray Ni Cc: Star Zeng Cc: Eric Dong Signed-off-by: Donald Kuo --- .../Library/BaseCpuTimerLib/BaseCpuTimerLib.c | 40 +++ .../Library/BaseCpuTimerLib/BaseCpuTimerLib.inf| 35 +++

[edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-12 Thread Donald Kuo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1909 Cc: Ray Ni Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Donald Kuo --- .../Library/BaseCpuTimerLib/BaseCpuTimerLib.c | 40 +++ .../Library/BaseCpuTimerLib/BaseCpuTimerLib.inf

[edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-12 Thread Donald Kuo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1909 Cc: Ray Ni Cc: Star Zeng Cc: Eric Dong Cc: Amy Chan Cc: Rangasai V Chaganty Signed-off-by: Donald Kuo --- .../Library/BaseCpuTimerLib/BaseCpuTimerLib.c | 40 +++ .../Library/BaseCpuTimerLib/BaseCpuTimerLib.inf| 35 +++

[edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-12 Thread Donald Kuo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1909 Cc: Ray Ni Cc: Star Zeng Cc: Eric Dong Cc: Amy Chan Cc: Rangasai V Chaganty Signed-off-by: Donald Kuo --- .../Library/BaseCpuTimerLib/BaseCpuTimerLib.c | 40 +++ .../Library/BaseCpuTimerLib/BaseCpuTimerLib.inf| 35 +++

[edk2-devel] [PATCH] MdePkg: Add STATIC_ASSERT macro

2019-08-12 Thread vit9696 via Groups.Io
Implements https://bugzilla.tianocore.org/show_bug.cgi?id=2048. Best regards, Vitaly Cheptsov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#45451): https://edk2.groups.io/g/devel/message/45451 Mute This Topic:

[edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-12 Thread Donald Kuo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1909 Cc: Ray Ni Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Donald Kuo --- .../Library/BaseCpuTimerLib/BaseCpuTimerLib.c | 40 +++ .../Library/BaseCpuTimerLib/BaseCpuTimerLib.inf

[edk2-devel] [PATCH v2] IntelSiliconPkg-Vtd: A new PMR interface

2019-08-12 Thread Evelyn Wang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1770 1) IOMMU PMR feature should be generic to support different hardware architecture. Platforms may request no overlap between PMR regions and system reserve memory. Create an interface to control PLMR/PHMR regions. It allows silicon code to

[edk2-devel] [PATCH] MdePkg: Add STATIC_ASSERT macro

2019-08-12 Thread via Groups.Io
Implements https://bugzilla.tianocore.org/show_bug.cgi?id=2048. Best regards, Vitaly Cheptsov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#45445): https://edk2.groups.io/g/devel/message/45445 Mute This Topic:

Re: [edk2-devel] [Patch v2 0/6] Add "test then write" mechanism.

2019-08-12 Thread Laszlo Ersek
On 08/12/19 12:31, Eric Dong wrote: > V2 changes: > 1. Split CR read/write action in to one discrete patch > 2. Keep the old logic which continue the process if error found. > > Below code is current implementation: > if (MsrRegister[ProcessorNumber].Bits.Lock == 0) { >

Re: [edk2-devel] [Patch v2 3/6] UefiCpuPkg/PiSmmCpuDxeSmm: Supports test then write new value logic.

2019-08-12 Thread Laszlo Ersek
On 08/12/19 12:31, Eric Dong wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040 > > Supports new logic which test current value before write new value. > Only write new value when current value not same as new value. > > Signed-off-by: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek

Re: [edk2-devel] [Patch v2 2/6] UefiCpuPkg/PiSmmCpuDxeSmm: Combine CR read/write action in one function.

2019-08-12 Thread Laszlo Ersek
On 08/12/19 12:31, Eric Dong wrote: > Signed-off-by: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > --- > UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 106 ++ > 1 file changed, 63 insertions(+), 43 deletions(-) > > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c >

Re: [edk2-devel] [PATCH v4 15/15] MdePkg/UefiRuntimeLib: Change the comment

2019-08-12 Thread Laszlo Ersek
Hi, On 08/12/19 05:07, Gao, Zhichao wrote: > Change the comment of EfiResetSystem base on the > UEFI spec 2.8 > > Cc: Michael D Kinney > Cc: Liming Gao > Signed-off-by: Zhichao Gao > --- > MdePkg/Library/UefiRuntimeLib/RuntimeLib.c | 8 > 1 file changed, 4 insertions(+), 4

Re: [edk2-devel] [PATCH v4 08/15] OvmfPkg/OvmfPkgIa32X64.dsc: Add ResetUtilityLib to dsc file

2019-08-12 Thread Laszlo Ersek
On 08/12/19 05:07, Zhichao Gao wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772 > > ResetUtilityLib would be consumed by CapsuleRuntimeDxe. > So add it for the platform dsc file. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Liming Gao > Signed-off-by:

Re: [edk2-devel] [PATCH v4 03/15] ArmVirtPkg/ArmVirtQemu.dsc: Add ResetUtilityLib to dsc file

2019-08-12 Thread Laszlo Ersek
On 08/12/19 15:49, Laszlo Ersek wrote: > Hi, > > On 08/12/19 05:07, Zhichao Gao wrote: >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772 >> >> ResetUtilityLib would be consumed by CapsuleRuntimeDxe. >> So add it for the platform dsc file. >> >> Cc: Laszlo Ersek >> Cc: Ard Biesheuvel

Re: [edk2-devel] [PATCH v4 03/15] ArmVirtPkg/ArmVirtQemu.dsc: Add ResetUtilityLib to dsc file

2019-08-12 Thread Laszlo Ersek
Hi, On 08/12/19 05:07, Zhichao Gao wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772 > > ResetUtilityLib would be consumed by CapsuleRuntimeDxe. > So add it for the platform dsc file. > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Liming Gao >

[edk2-devel] [edk2-platforms: PATCH 0/1] Platforms/RPi3: Add multiple embedded Device Tree selection

2019-08-12 Thread Pete Batard
The purpose of this patch is to enable the automatic provision of a relevant Raspberry Pi 3 Device Tree at runtime, as there currently exists 2 models of Raspberry Pi 3 (model B and model B+) but we only embed the Device Tree for a single one (model B). Obviously, the provision of only a single

[edk2-devel] [edk2-platforms: PATCH 1/1] Platforms/RPi3: Add multiple embedded Device Tree selection

2019-08-12 Thread Pete Batard
The Raspberry Pi 3 platform currently has 2 different models, each with a different Device Tree. Rather than embedding a single one, and requiring users to manually provide the other, this patch ensures that we now embed both and and serve the relevant one at runtime. Signed-off-by: Pete Batard

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/DxeIplPeim: Relocate the operation of PageMapLevel5Entry++

2019-08-12 Thread Laszlo Ersek
Hello Shenglei, On 08/12/19 08:24, Shenglei Zhang wrote: > PageMapLevel5Entry may be uninitialized in original code, which means > uninitialized pointer will be modified at some circumstance. > So relocate the operation of PageMapLevel5Entry++ in order to make sure > the pointer could be modified

Re: [edk2-devel] [Patch 1/4] UefiCpuPkg/RegisterCpuFeaturesLib: Add "detect before set" Micros.

2019-08-12 Thread Laszlo Ersek
On 08/12/19 09:46, Dong, Eric wrote: > Hi Laszlo, > >> -Original Message- >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >> Laszlo Ersek >> Sent: Friday, August 9, 2019 11:14 PM >> To: Dong, Eric ; devel@edk2.groups.io >> Cc: Ni, Ray >> Subject: Re: [edk2-devel]

Re: [edk2-devel] [Patch] Readme.md: Remove tag release from Readme

2019-08-12 Thread Laszlo Ersek
On 08/12/19 04:09, Liming Gao wrote: > The latest tag release can be found in Release Planning. > They are not required to be listed here. > > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc: Michael D Kinney > Signed-off-by: Liming Gao > --- > Readme.md | 3 --- > 1 file

[edk2-devel] [Patch v2 3/6] UefiCpuPkg/PiSmmCpuDxeSmm: Supports test then write new value logic.

2019-08-12 Thread Dong, Eric
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040 Supports new logic which test current value before write new value. Only write new value when current value not same as new value. Signed-off-by: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek --- UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 29

[edk2-devel] [Patch v2 5/6] UefiCpuPkg/RegisterCpuFeaturesLib: Supports test then write new value logic.

2019-08-12 Thread Dong, Eric
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040 Supports new logic which test current value before write new value. Only write new value when current value not same as new value. Signed-off-by: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek --- .../CpuFeaturesInitialize.c |

[edk2-devel] [Patch v2 1/6] UefiCpuPkg/RegisterCpuFeaturesLib: Add "Test Then Write" Macros.

2019-08-12 Thread Dong, Eric
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040 Add below new micros which test the current value before write the new value. Only write new value when current value not same as new value. CPU_REGISTER_TABLE_TEST_THEN_WRITE32 CPU_REGISTER_TABLE_TEST_THEN_WRITE64

[edk2-devel] [Patch v2 2/6] UefiCpuPkg/PiSmmCpuDxeSmm: Combine CR read/write action in one function.

2019-08-12 Thread Dong, Eric
Signed-off-by: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek --- UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 106 ++ 1 file changed, 63 insertions(+), 43 deletions(-) diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c b/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c index d8c6b19ead..b20992d5ab

[edk2-devel] [Patch v2 6/6] UefiCpuPkg/CpuCommonFeaturesLib: Use new macros.

2019-08-12 Thread Dong, Eric
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040 Below code is current implementation: if (MsrRegister[ProcessorNumber].Bits.Lock == 0) { CPU_REGISTER_TABLE_WRITE_FIELD ( ProcessorNumber, Msr, MSR_IA32_FEATURE_CONTROL, MSR_IA32_FEATURE_CONTROL_REGISTER,

[edk2-devel] [Patch v2 0/6] Add "test then write" mechanism.

2019-08-12 Thread Dong, Eric
V2 changes: 1. Split CR read/write action in to one discrete patch 2. Keep the old logic which continue the process if error found. Below code is current implementation: if (MsrRegister[ProcessorNumber].Bits.Lock == 0) { CPU_REGISTER_TABLE_WRITE_FIELD ( ProcessorNumber, Msr,

[edk2-devel] [Patch v2 4/6] UefiCpuPkg/RegisterCpuFeaturesLib: Combine CR read/write action in one function.

2019-08-12 Thread Dong, Eric
Signed-off-by: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek --- .../CpuFeaturesInitialize.c | 112 ++ 1 file changed, 64 insertions(+), 48 deletions(-) diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-12 Thread Zeng, Star
Some comments below. > -Original Message- > From: Kuo, Donald > Sent: Monday, August 12, 2019 1:57 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Zeng, Star ; Dong, Eric > > Subject: [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) > TSC leaf > > REF:

Re: [edk2-devel] [PATCH V2 00/10] Multiple Controllers Support solution

2019-08-12 Thread Liming Gao
That's good information. In patch 5, GetLowestSupportedVersion() API function header should be updated to include Private param. I have no other comments. With this change, Reviewed-by: Liming Gao /// @@ -193,7 +200,7 @@ GetImageTypeNameString ( **/ UINT32 GetLowestSupportedVersion ( -

Re: [edk2-devel] [PATCH 2/3] NetworkPkg: Move Dpc.h from MdeModulePkg to NetworkPkg

2019-08-12 Thread Siyuan, Fu
Reviewed-by: Siyuan Fu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Zhang, > Shenglei > Sent: 2019年8月12日 16:37 > To: devel@edk2.groups.io > Cc: Fu, Siyuan ; Wu, Jiaxin > Subject: [edk2-devel] [PATCH 2/3] NetworkPkg: Move Dpc.h from > MdeModulePkg to NetworkPkg > >

Re: [edk2-devel] [PATCH 1/3] NetworkPkg: Add Dpc protocol

2019-08-12 Thread Siyuan, Fu
Reviewed-by: Siyuan Fu > -Original Message- > From: Zhang, Shenglei > Sent: 2019年8月12日 16:37 > To: devel@edk2.groups.io > Cc: Fu, Siyuan ; Wu, Jiaxin > Subject: [PATCH 1/3] NetworkPkg: Add Dpc protocol > > To move Dpc.h from MdeModulePkg to NetworkPkg, > we need to introduce the Guid

[edk2-devel] [PATCH 3/3] MdeModulePkg/MdeModulePkg.dec: Remove gEfiDpcProtocolGuid

2019-08-12 Thread Zhang, Shenglei
Since the transfer has been finished in previous patches, gEfiDpcProtocolGuid can be removed. https://bugzilla.tianocore.org/show_bug.cgi?id=1949 Cc: Jian J Wang Cc: Hao A Wu Signed-off-by: Shenglei Zhang --- MdeModulePkg/MdeModulePkg.dec | 3 --- 1 file changed, 3 deletions(-) diff --git

[edk2-devel] [PATCH 1/3] NetworkPkg: Add Dpc protocol

2019-08-12 Thread Zhang, Shenglei
To move Dpc.h from MdeModulePkg to NetworkPkg, we need to introduce the Guid of protocol first. https://bugzilla.tianocore.org/show_bug.cgi?id=1949 Cc: Siyuan Fu Cc: Jiaxin Wu Signed-off-by: Shenglei Zhang --- NetworkPkg/NetworkPkg.dec | 4 1 file changed, 4 insertions(+) diff --git

[edk2-devel] [PATCH 2/3] NetworkPkg: Move Dpc.h from MdeModulePkg to NetworkPkg

2019-08-12 Thread Zhang, Shenglei
Move Dpc.h from MdeModulePkg to NetworkPkg. And remove the dependency on MdeModulePkg.dec in INFs. https://bugzilla.tianocore.org/show_bug.cgi?id=1949 Cc: Siyuan Fu Cc: Jiaxin Wu Signed-off-by: Shenglei Zhang --- NetworkPkg/DpcDxe/DpcDxe.inf| 1 - {MdeModulePkg =>

[edk2-devel] [PATCH 0/3] Move MdeModulePkg/Include/Protocol/Dpc.h to NetworkPkg

2019-08-12 Thread Zhang, Shenglei
The file MdeModulePkg/Include/Protocol/Dpc.h is consumed by the modules in NetworkPkg. Hence, this protocol header file should be moved into NetworkPkg. https://bugzilla.tianocore.org/show_bug.cgi?id=1949 Cc: Siyuan Fu Cc: Jiaxin Wu Cc: Jian J Wang Cc: Hao A Wu Shenglei Zhang (3):

Re: [edk2-devel] [Patch 3/4] UefiCpuPkg/PiSmmCpuDxeSmm: Supports detect before set new value logic.

2019-08-12 Thread Dong, Eric
Hi Laszlo, > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Laszlo Ersek > Sent: Friday, August 9, 2019 11:31 PM > To: Dong, Eric ; devel@edk2.groups.io > Cc: Ni, Ray > Subject: Re: [edk2-devel] [Patch 3/4] UefiCpuPkg/PiSmmCpuDxeSmm: >

[edk2-devel] [RFC] BZ 1772 MdeModulePkg: Transfer reset data

2019-08-12 Thread Gao, Zhichao
HI, BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1772 Before the ResetData of ResetSystem is limit by ResetType and ResetStatus. As the Uefi spec update to 2.8, there is no limit any longer. Here we introduce a new API ResetSystemWithSubtype to transfer a null string and GUID data with

Re: [edk2-devel] [edk2-platforms] [PATCH v2] Platform/Intel: Update Readme.md to point to edk2-non-osi master branch

2019-08-12 Thread Leif Lindholm
On Sun, Aug 11, 2019 at 04:44:48PM -0700, Nate DeSimone wrote: > Updated Platform/Intel/Readme.md to point to master branch on > edk2-non-osi instead of devel-MinPlatform > > Updated edk2-platforms/Readme.md to point to Platform/Intel/Readme.md > for build instructions on Intel based Minimum

Re: [edk2-devel] [Patch] Readme.md: Remove tag release from Readme

2019-08-12 Thread Leif Lindholm
On Mon, Aug 12, 2019 at 10:09:15AM +0800, Liming Gao wrote: > The latest tag release can be found in Release Planning. > They are not required to be listed here. > > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc: Michael D Kinney > Signed-off-by: Liming Gao Reviewed-by: Leif

Re: [edk2-devel] [Patch 1/4] UefiCpuPkg/RegisterCpuFeaturesLib: Add "detect before set" Micros.

2019-08-12 Thread Dong, Eric
Hi Laszlo, Will fix it in my next version change. Thanks, Eric > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, August 9, 2019 11:31 PM > To: Dong, Eric ; devel@edk2.groups.io > Cc: Ni, Ray > Subject: Re: [Patch 1/4]

Re: [edk2-devel] [Patch 1/4] UefiCpuPkg/RegisterCpuFeaturesLib: Add "detect before set" Micros.

2019-08-12 Thread Dong, Eric
Hi Laszlo, > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Laszlo Ersek > Sent: Friday, August 9, 2019 11:14 PM > To: Dong, Eric ; devel@edk2.groups.io > Cc: Ni, Ray > Subject: Re: [edk2-devel] [Patch 1/4] UefiCpuPkg/RegisterCpuFeaturesLib:

[edk2-devel] [PATCH V2 2/2] BaseTools/Capsule: Tool to generate Windows Firmware Update Driver

2019-08-12 Thread Eric Jin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1837 The tool is designed to generate Windows Firmware Update Drivers, the input is one drivername.cap with related parameters, the output Windows Driver package are composed by drivername.cap, drivername.inf and drivername.cat to update the

[edk2-devel] [RFC] BZ 2067 BaseTools/Scripts: Add GetUtcDateTime.py for edk2-stable201908 stable tag.

2019-08-12 Thread Chiu, Chasel
Hello, I would like to add below simple script to 201908 stable tag, review was sent on August 8th: A script that can return UTC date and time in ascii format which is convenient for patching build time information in any binary. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2067

[edk2-devel] [PATCH V2 1/2] BaseTools/Capsule: Add WindowsCapsuleSupportHelper

2019-08-12 Thread Eric Jin
From: Sean Brogan Add initial version WindowsCapsuleSupportHelper.py original source comes from https://github.com/microsoft/mu_basecore/blob/dev/201905/BaseTools/Plugin/WindowsCapsuleSupportHelper/WindowsCapsuleSupportHelper.py commit ebd9aad90dee3a3094b575928670cf81b8c685b5 Convert EOL to CRLF

[edk2-devel] [PATCH V2 0/2] Enable Windows Firmware Update Driver Tool

2019-08-12 Thread Eric Jin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1837 The tool makes driver capsule as input, leverage edk2-pytool-library to creates INF, Cat, and signs it. The generated Windows Driver package is composed by drivername.cap, drivername.inf and drivername.cat files. V2: No update to code,

Re: [edk2-devel] [PATCH V2 00/10] Multiple Controllers Support solution

2019-08-12 Thread Eric Jin
Liming, The differences between V2 and V1 are listed below. 1) The series is composed of 10 patches in V2 (14 in V1). patch 14 is merged into patch 4, and patch 11/12/13 are merged into patch 5. 2) Try to fix the issue exposed by ECC. Btw, the patch of edk2-platform

[edk2-devel] [RFC] BZ 1837 Enable Windows Firmware Update Driver Tool in Edk2/BaseTools for 201908 stable tag

2019-08-12 Thread Eric Jin
Hi All, It is the request to Enable Windows Firmware Update Driver Tool in Edk2/BaseTools and catch the Q3 tag. The new tool will leverage the edk2-pytool-library to generate the cat/inf file based on the cap file. The output driver package can be trigged in Windows OS to complete capsule

Re: [edk2-devel] [PATCH v2 1/3] MdeModulePkg: Add missing header files in INF files

2019-08-12 Thread Wu, Hao A
> -Original Message- > From: Zhang, Shenglei > Sent: Monday, August 12, 2019 2:23 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J; Wu, Hao A > Subject: [PATCH v2 1/3] MdeModulePkg: Add missing header files in INF files > > The header files are used but missing in INF,which causes >

Re: [edk2-devel] [PATCH v2 3/3] IntelFsp2Pkg/FspSecCore: Add missing header file in INF file

2019-08-12 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Zhang, Shenglei > Sent: Monday, August 12, 2019 2:23 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH v2 3/3] IntelFsp2Pkg/FspSecCore: Add missing header file in > INF file >

[edk2-devel] [PATCH 1/1] MdeModulePkg/DxeIplPeim: Relocate the operation of PageMapLevel5Entry++

2019-08-12 Thread Zhang, Shenglei
PageMapLevel5Entry may be uninitialized in original code, which means uninitialized pointer will be modified at some circumstance. So relocate the operation of PageMapLevel5Entry++ in order to make sure the pointer could be modified only when it is uninitialized. Cc: Dandan Bi Cc: Liming Gao

  1   2   >