REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2098
In the ExitBootServices() test, after ExitBootServices() call, all
boot services are forbidden. The original design is to save the return
status value of ExitBootServices() in variable using variable service
and reset, but this needs one
Thank you Mike!
That is good reference on the real hardware behavior. (Glad it is public.)
For threat model, the unique part in virtual environment is temp RAM.
The temp RAM in real platform is per CPU cache, while the temp RAM in virtual
platform is global memory.
That brings one more
Hi Supreeth,
> -Original Message-
> From: Supreeth Venkatesh [mailto:supreeth.venkat...@arm.com]
> Sent: Friday, August 23, 2019 2:43 AM
> To: devel@edk2.groups.io; Jin, Eric
> Subject: Re: [edk2-devel] [edk2-test][Patch 1/1] uefi-sct/SctPkg: Eliminate
> 2nd execution of ExitBootServices
Hi Laszlo, Chao,
Sorry for late response in this thread.
I review Mantis#1983 and this discussion again. I agree with Laszlo.
1. UEFI spec 2.8 is not very clear about PK validation in Setup mode.
2. This patch only reduce the complexity of update PK process.
Having a FeaturePCD to control this
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zurcher, Christopher J
> Sent: Friday, August 23, 2019 6:02 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D; Yao, Jiewen; Wang, Jian J; Gao, Liming; Wu, Hao A
> Subject: [edk2-devel] [PATCH
*Reminder:* TianoCore Design Meeting - APAC/NAMO
*When:* Thursday, 22 August 2019, 6:30pm to 7:30pm, (GMT-07:00) America/Los
Angeles
*Where:* https://zoom.us/j/969264410
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=470780 )
*Organizer:* Stephano Cetola
Paolo,
I find the following links related to the discussions here
along with one example feature called GENPROTRANGE.
https://csrc.nist.gov/CSRC/media/Presentations/The-Whole-is-Greater/images-media/day1_trusted-computing_200-250.pdf
The zoom meeting started late, so please try to rejoin if you could not get in
a few minutes ago.
Mike
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io]
Sent: Thursday, August 22, 2019 4:45 PM
To: devel@edk2.groups.io
Subject: [edk2-devel] Upcoming Event: TianoCore Bug Triage - APAC /
*Reminder:* TianoCore Bug Triage - APAC / NAMO
*When:* Thursday, 22 August 2019, 5:00pm to 5:30pm, (GMT-07:00) America/Los
Angeles
*Where:* https://zoom.us/j/251103409
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=470778 )
*Organizer:* Stephano Cetola
Reviewed-by: Ray Ni
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael D
> Kinney
> Sent: Thursday, August 22, 2019 10:36 AM
> To: devel@edk2.groups.io
> Cc: Justen, Jordan L ; Ni, Ray ;
> Andrew Fish ; Tim Lewis
> Subject: [edk2-devel] [Patch][edk2-stable201908
Mike,
Thanks for fixing this regression issue.
I also did a comparison between this and the Nt32 accordingly code.
They are almost the same.
I also noticed your unit test steps in Bugzilla and the behavior is expected.
I agree and also suggest that this fix to be included in the coming stable
Paolo,
It is my understanding that real HW hot plug uses the SDM defined
methods. Meaning the initial SMI is to 3000:8000 and they rebase
to TSEG in the first SMI. They must have chipset specific methods
to protect 3000:8000 from DMA.
Can we add a chipset feature to prevent DMA to 64KB range
Hi Mike,
Please see the updates online below. Please let me know if you have any more
comments.
Thanks
David
-Original Message-
From: Kubacki, Michael A
Sent: Monday, August 19, 2019 6:04 PM
To: Wei, David Y ; devel@edk2.groups.io
Cc: Wu, Hao A ; Gao, Liming ; Sinha,
Ankit ; Agyeman,
Replacing "magic numbers" in the Peripheral Type check with defines for
the reserved range from IndustryStandard/Scsi.h
Cc: Michael D Kinney
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Liming Gao
Signed-off-by: Christopher J Zurcher
---
MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c | 5 +++--
1 file
This patch implements the Security Protocol In and Security Protocol Out
commands in UefiScsiLib to prepare support for the Storage Security
Command Protocol.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Liming Gao
Signed-off-by: Christopher J Zurcher
---
MdePkg/Include/IndustryStandard/Scsi.h | 48
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1546
V5 changes:
Split MdeModulePkg changes into separate patches. Add ReinstallProtocol
calls for StorageSecurityCommand Protocol. Restore original MediaPresent
and ReadCapacity behavior, with new implementation for WLUN type media.
Clear
This patch implements the EFI_STORAGE_SECURITY_COMMAND_PROTOCOL in the
ScsiDiskDxe driver.
Support is currently limited to the RPMB Well-known LUN for UFS devices.
Cc: Michael D Kinney
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Liming Gao
Signed-off-by: Christopher J Zurcher
---
Currently UfsPassThru only checks for 8 common LUNs. This adds a check
for the RPMB Well-known LUN and sets the corresponding bit-mask. Further
handling of the WLUN is already present in the driver.
Cc: Michael D Kinney
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Liming Gao
Signed-off-by: Christopher
On 2019-08-22 06:46:07, Laszlo Ersek wrote:
> On 08/21/19 23:51, Jordan Justen wrote:
> > On 2019-08-21 07:21:25, Laszlo Ersek wrote:
> >> On 08/19/19 23:35, Lendacky, Thomas wrote:
> >>> From: Tom Lendacky
> >>>
> >>> + //
> >>> + // Enable caching
> >>> + //
> >>> + AsmEnableCache ();
> >>>
Laszlo,
I believe all the code for the AP startup vector
is already in edk2.
It is a combination of the reset vector code in
UefiCpuPkg/ResetVecor/Vtf0 and an IA32/X64 specific
feature in the GenFv tool. It sets up a 4KB aligned
location near 4GB which can be used to start an AP
using
Paolo,
The SMBASE register is internal and cannot be directly accessed
by any CPU. There is an SMBASE field that is member of the SMM Save
State area and can only be modified from SMM and requires the
execution of an RSM instruction from SMM for the SMBASE register to
be updated from the
On 22/08/19 20:29, Laszlo Ersek wrote:
> On 08/22/19 08:18, Paolo Bonzini wrote:
>> On 21/08/19 22:17, Kinney, Michael D wrote:
>>> DMA protection of memory ranges is a chipset feature. For the current
>>> QEMU implementation, what ranges of memory are guaranteed to be
>>> protected from DMA? Is
On 22/08/19 19:59, Laszlo Ersek wrote:
> The firmware and QEMU could agree on a formula, which would compute the
> CPU-specific SMBASE from a value pre-programmed by the firmware, and the
> initial APIC ID of the hot-added CPU.
>
> Yes, it would duplicate code -- the calculation -- between QEMU
On Wed, 2019-08-21 at 20:50 -0500, Eric Jin via Groups.Io wrote:
> Hij Supreeth,
Hi Eric,
>
> > -Original Message-
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf
> > Of
> > Supreeth Venkatesh
> > Sent: Thursday, August 22, 2019 12:43 AM
> > To: Jin, Eric ;
Reviewed-by: Ankit Sinha
-Original Message-
From: Kubacki, Michael A
Sent: Thursday, August 22, 2019 11:17 AM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Gao, Liming
; Sinha, Ankit
Subject: [edk2-platforms][PATCH V2 2/2] ClevoOpenBoardPkg: Fix GCC Build
Failures
Fixes build
On 08/22/19 08:18, Paolo Bonzini wrote:
> On 21/08/19 22:17, Kinney, Michael D wrote:
>> Paolo,
>>
>> It makes sense to match real HW.
>
> Note that it'd also be fine to match some kind of official Intel
> specification even if no processor (currently?) supports it.
I agree, because...
>> That
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2109
These patches build failures found in Kaby Lake based platforms.
V2 Changes:
* Extended copyright date in BaseGpioExpanderLib.c to 2019.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Ankit Sinha
Signed-off-by: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2109
Fixes build failures on GCC7.3.0. Tested on Ubunutu 18.04.1 LTS.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Signed-off-by: Michael Kubacki
---
Fixes build failures on GCC7.3.0. Tested on Ubunutu 18.04.1 LTS.
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Ankit Sinha
Signed-off-by: Michael Kubacki
---
Platform/Intel/ClevoOpenBoardPkg/Library/BaseGpioExpanderLib/BaseGpioExpanderLib.c
| 7 ++-
1 file changed, 2 insertions(+), 5
BaseGpioExpanderLib.c still having 2017 in copyright, please help to extend it.
With above change Reviewed-by: Chasel Chiu
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Kubacki, Michael A
> Sent: Friday, August 23, 2019 1:40 AM
> To:
This file still having 2018 in copyright, so please help to extend it.
With above change Reviewed-by: Chasel Chiu
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zhang, Shenglei
> Sent: Thursday, August 22, 2019 3:08 PM
> To:
On 08/21/19 19:05, Paolo Bonzini wrote:
> On 21/08/19 17:48, Kinney, Michael D wrote:
>> Perhaps there is a way to avoid the 3000:8000 startup
>> vector.
>>
>> If a CPU is added after a cold reset, it is already in a
>> different state because one of the active CPUs needs to
>> release it by
On 08/21/19 17:48, Kinney, Michael D wrote:
> Perhaps there is a way to avoid the 3000:8000 startup
> vector.
>
> If a CPU is added after a cold reset, it is already in a
> different state because one of the active CPUs needs to
> release it by interacting with the hot plug controller.
>
> Can the
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2109
These patches build failures found in Kaby Lake based platforms.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Ankit Sinha
Signed-off-by: Michael Kubacki
Michael Kubacki (2):
KabylakeOpenBoardPkg: Fix GCC Build Failures
Fixes build failures on GCC7.3.0. Tested on Ubunutu 18.04.1 LTS.
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Ankit Sinha
Signed-off-by: Michael Kubacki
---
Platform/Intel/ClevoOpenBoardPkg/Library/BaseGpioExpanderLib/BaseGpioExpanderLib.c
| 7 ++-
1 file changed, 2 insertions(+), 5
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2109
Fixes build failures on GCC7.3.0. Tested on Ubunutu 18.04.1 LTS.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Signed-off-by: Michael Kubacki
---
I'm ok with the change but next time please help to take care:
1. Use subject-prefix="edk2-platforms:PATCH" for edk2-platforms related patches.
2. suggest to generate separate patches in a series for cross package changes.
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Chen,
On 8/22/19 9:12 AM, Laszlo Ersek wrote:
> On 08/21/19 23:42, Lendacky, Thomas wrote:
>> On 8/21/19 9:31 AM, Laszlo Ersek wrote:
>>> On 08/19/19 23:35, Lendacky, Thomas wrote:
From: Tom Lendacky
Allocate memory for the GHCB pages during SEV initialization for use
during Pei and
Laszlo:
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, August 22, 2019 7:56 PM
> To: Gao, Liming
> Cc: devel@edk2.groups.io; Kinney, Michael D ;
> Mike Turner ; Wang, Jian J
> ; Wu, Hao A ; Bi, Dandan
> ; Anthony Perard
> ; Justen, Jordan L
>
Reviewed-by: Liming Gao
> -Original Message-
> From: Feng, Bob C
> Sent: Thursday, August 22, 2019 12:01 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
> Subject: [Patch V2][edk2-stable201908] BaseTools: Incorrect error message for
> library instance not found
>
>
On 08/21/19 23:42, Lendacky, Thomas wrote:
> On 8/21/19 9:31 AM, Laszlo Ersek wrote:
>> On 08/19/19 23:35, Lendacky, Thomas wrote:
>>> From: Tom Lendacky
>>>
>>> Allocate memory for the GHCB pages during SEV initialization for use
>>> during Pei and Dxe phases. Since the GHCB pages must be mapped
Hi Andrew
Thanks for the information and clarification!
The strange is that at some systems I have checked these SMBIOS tables,
have nothing that would indicate the current mode of operation in a direct
way.
The closest to this is this field, taken from "Type 17" from SMBIOS spec
3.2.0 :
On 08/21/19 23:51, Jordan Justen wrote:
> On 2019-08-21 07:21:25, Laszlo Ersek wrote:
>> On 08/19/19 23:35, Lendacky, Thomas wrote:
>>> From: Tom Lendacky
>>>
>>> Currently, the OVMF code relies on the hypervisor to enable the cache
>>> support on the processor in order to improve the boot speed.
(+Anthony, +Jordan)
On 08/21/19 16:14, Gao, Liming wrote:
> Laszlo:
>
>> -Original Message-
>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Laszlo
>> Ersek
>> Sent: Wednesday, August 21, 2019 4:46 PM
>> To: Gao, Liming ; devel@edk2.groups.io; Kinney,
>> Michael
On 21/08/19 22:17, Kinney, Michael D wrote:
> Paolo,
>
> It makes sense to match real HW.
Note that it'd also be fine to match some kind of official Intel
specification even if no processor (currently?) supports it.
> That puts us back to
> the reset vector and handling the initial SMI at
>
On 21/08/19 19:25, Kinney, Michael D wrote:
> Could we have an initial SMBASE that is within TSEG.
>
> If we bring in hot plug CPUs one at a time, then initial
> SMBASE in TSEG can reprogram the SMBASE to the correct
> value for that CPU.
>
> Can we add a register to the hot plug controller
Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in
DSC file to make sure that the deprecated APIs will not be
used in our code.
https://bugzilla.tianocore.org/show_bug.cgi?id=2111
Cc: Dandan Bi
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
Add build option "/D DISABLE_NEW_DEPRECATED_INTERFACES"
to make sure the deprecated APIs are not used in our code.
https://bugzilla.tianocore.org/show_bug.cgi?id=2111
Cc: Dandan Bi
Cc: Liming Gao
Cc: Sai Chaganty
Cc: Eric Dong
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
shenglei
Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in
DSC file to make sure that the deprecated APIs will not be
used in our code.
https://bugzilla.tianocore.org/show_bug.cgi?id=2111
Cc: Eric Dong
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in
DSC file to make sure that the deprecated APIs will not be
used in our code.
https://bugzilla.tianocore.org/show_bug.cgi?id=2111
Cc: Michael Kubacki
Cc: Sai Chaganty
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in
DSC file to make sure that the deprecated APIs will not be
used in our code.
https://bugzilla.tianocore.org/show_bug.cgi?id=2111
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
51 matches
Mail list logo
