Reviewed-by: Liming Gao
>-Original Message-
>From: Gao, Zhichao
>Sent: Thursday, September 19, 2019 1:46 PM
>To: devel@edk2.groups.io
>Cc: Andrew Fish ; Laszlo Ersek ; Leif
>Lindholm ; Kinney, Michael D
>; Ni, Ray ; Ard Biesheuvel
>; Gao, Liming
>Subject: [PATCH] Edk2: Add Zhichao as
Zhichao is responsible for the IA32 and X64 ARCH shell binary generation.
Cc: Andrew Fish
Cc: Laszlo Ersek
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Ray Ni
Cc: Ard Biesheuvel
Cc: Liming Gao
Signed-off-by: Zhichao Gao
---
Maintainers.txt | 1 +
1 file changed, 1 insertion(+)
diff --git
Abner:
Please add BZ URL in the commit message, and separate this patch to three
changes. Each one is for each package of MdePkg, MdeModulePkg and ShellPkg.
As Leif say, SmBios 3.3 spec is not published. This patch will not be pushed
until SmBios 3.3 is published.
>-Original
Zhichao:
If GUID MACRO is not required, you don't need to add header file. But for
this case, GUID MACRO is required.
So, you have to add the header file. Then, I suggest to add extern GuidCName
together in this header file to match GUID MACRO.
Thanks
Liming
>-Original Message-
Hi Hao,
I used to get comments from Mike not to add MARCO name and extern declaration
of the GUIDs to the header file.
See https://edk2.groups.io/g/devel/message/40054.
The MARCO is used in the patch #3, so I kept it.
Thanks,
Zhichao
> -Original Message-
> From: Wu, Hao A
> Sent:
1. PatchCheck flags commit message length
2. Please put [edk2-platforms] in the subject line for patches to the
edk2-platforms repository
3. Please send a new patch with these changes and the changes for Chasel's
feedback included
> -Original Message-
> From: Zhang, Shenglei
> Sent:
There's some style issues with spaces missing before opening parenthesis. Those
can be fixed before submission this time.
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Wei, David Y
> Sent: Monday, September 16, 2019 3:39 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Gao,
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Wei, David Y
> Sent: Monday, September 16, 2019 3:40 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Gao, Liming ;
> Sinha, Ankit ; Agyeman, Prince
> ; Kubacki, Michael A
> ; Desimone, Nathaniel L
> ; Kinney, Michael D
>
>
The initial header file commit for SiFive U5-MC Coreplex and U500 Core
Local interrupt definitions.
Signed-off-by: Gilbert Chen
---
.../SiFive/U500Pkg/Include/SiFiveU5MCCoreplex.h| 51 ++
Platform/RiscV/SiFive/U500Pkg/Include/U500Clint.h | 19
2 files changed,
Common RISC-V SEC module for RISC-V platforms.
Signed-off-by: Gilbert Chen
---
Platform/RiscV/Universal/Sec/Riscv64/SecEntry.S | 438
Platform/RiscV/Universal/Sec/SecMain.c | 524
Platform/RiscV/Universal/Sec/SecMain.h | 57 +++
OpneSbiPlatformLib
- In order to reduce the dependencies with RISC-V OpenSBI project
(https://github.com/riscv/opensbi) and less burdens to EDK2 build
process, the implementation of RISC-V EDK2 platform is leverage
platform source code from OpenSBI code tree. The "platform.c"
under
Initial version of SiFive RISC-V core libraries. Library of each core
creates processor core SMBIOS data hob for building SMBIOS
records in DXE phase.
Signed-off-by: Gilbert Chen
---
.../E51/Library/PeiCoreInfoHobLib/CoreInfoHob.c| 242 +
Update Readme.md and Maintainers.txt for RISV-V platforms.
Signed-off-by: Gilbert Chen
---
Maintainers.txt | 9 +
Readme.md | 11 +++
2 files changed, 20 insertions(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index 876ae561..c494c9d5 100644
--- a/Maintainers.txt
FirmwareContextProcessorSpecificLib.h
- The difinitions of Firmware Context EDK2 implementaion based on
RISC-V OpenSBI.
Signed-off-by: Gilbert Chen
---
.../Library/FirmwareContextProcessorSpecificLib.h | 40 ++
1 file changed, 40 insertions(+)
create mode 100644
"devel-riscv-v2" is a new branch created for reviewing code changes of SiFive
U500 VC707 FPGA
platform EDK2 port. Compare to old "devel-riscv" branch, the patches sent to
"devel-riscv-v2"
branch are made based on the most recent edk2/master. The corresponding patches
of
edk2 code changes were
Timer DXE driver for U500 platform based U500 platform implementation
specifc timer registers.
Signed-off-by: Gilbert Chen
---
.../SiFive/U500Pkg/Universal/Dxe/TimerDxe/Timer.c | 311 +
.../SiFive/U500Pkg/Universal/Dxe/TimerDxe/Timer.h | 174
Add SiFive silicon EDK2 metafile and header files of
SiFive RISC-V cores.
Signed-off-by: Gilbert Chen
---
Silicon/SiFive/Include/Library/SiFiveE51.h | 60 ++
Silicon/SiFive/Include/Library/SiFiveU54.h | 60 ++
Firmware Volume Block driver instance for ram based EFI variable on U500
platform.
Signed-off-by: Gilbert Chen
---
.../Dxe/RamFvbServicesRuntimeDxe/FvbInfo.c | 127 +++
.../FvbServicesRuntimeDxe.inf | 81 ++
.../Dxe/RamFvbServicesRuntimeDxe/FwBlockService.c |
This is the platform-implementation specific library which is executed
in early PEI phase for platform initialization.
Signed-off-by: Gilbert Chen
---
.../SiFive/U500Pkg/Universal/Pei/PlatformPei/Fv.c | 49
.../U500Pkg/Universal/Pei/PlatformPei/MemDetect.c | 74 +
The initial version of SiFive U500 platform package.
Signed-off-by: Gilbert Chen
---
Platform/RiscV/SiFive/U500Pkg/Readme.md| 62 +++
Platform/RiscV/SiFive/U500Pkg/U500.dec | 34 ++
Platform/RiscV/SiFive/U500Pkg/U500.dsc | 549 +
SiFive RISC-V U500 Platform Boot Manager library.
Signed-off-by: Gilbert Chen
---
.../Library/PlatformBootManagerLib/MemoryTest.c| 682 +
.../PlatformBootManagerLib/PlatformBootManager.c | 274 +
.../PlatformBootManagerLib/PlatformBootManager.h | 135
Initial version of RISC-V platform package which provides the common
libraries, drivers, PCD and etc. for RISC-V platform development.
Signed-off-by: Gilbert Chen
---
Platform/RiscV/Readme.md | 89
Platform/RiscV/RiscVPlatformPkg.dec | 72
FirmwareContextProcessorSpecificLib
- Common library to consume EFI_RISCV_FIRMWARE_CONTEXT_HART_SPECIFIC
and build up processor specific data HOB.
RealTimClockLibNull
- NULL instance of Real Time Clock library.
Signed-off-by: Gilbert Chen
---
.../FirmwareContextProcessorSpecificLib.c
> -Original Message-
> From: Gao, Liming [mailto:liming@intel.com]
> Sent: Tuesday, September 17, 2019 10:43 PM
> To: devel@edk2.groups.io; leif.lindh...@linaro.org; Chang, Abner (HPS
> SW/FW Technologist)
> Cc: Kinney, Michael D ; Chen, Gilbert
>
> Subject: RE: [edk2-devel]
Update SmBios header file to conform with SMBIOS v3.3.0.
The major update is to add definitions of SMBIOS Type 44h record.
Signed-off-by: Abner Chang
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Leif Lindholm
Cc: Gilbert Chen
---
MdeModulePkg/MdeModulePkg.dec | 6 +-
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2068
This change sets the serial IRQ mode to continuous to allow the PS/2
keyboard and mouse to function properly in the OS. In the UEFI boot
environment, the device uses a polling model so this change is not
strictly required for that
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2203
This patch is going to fix a regression issue that
build breaks when the custom makefile exist.
Cc: Liming Gao
Cc: Steven Shi
Signed-off-by: Bob Feng
---
BaseTools/Source/Python/AutoGen/GenMake.py | 6 +-
1 file changed, 5
Reviewed-by: Bob Feng
-Original Message-
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Leif
Lindholm
Sent: Thursday, September 19, 2019 6:44 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming
Subject: [edk2-devel] [PATCH 8/9] BaseTools: correct line
Reviewed-by: Bob Feng
-Original Message-
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Leif
Lindholm
Sent: Thursday, September 19, 2019 6:43 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming
Subject: [edk2-devel] [PATCH 5/9] BaseTools: fix line endings
Reviewed-by: Bob Feng
-Original Message-
From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
Sent: Thursday, September 19, 2019 6:43 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming
Subject: [PATCH 1/9] BaseTools: add missing newlines at end of files
Some scripts in
Dear Edk2 Base tool owner,
Do latest edk2 build tool support C99 standard?
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#47525): https://edk2.groups.io/g/devel/message/47525
Mute This Topic: https://groups.io/mt/34195857/21656
Reviewed-by: Liming Gao for the changes in BaseTools.
>-Original Message-
>From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
>Sent: Thursday, September 19, 2019 6:43 AM
>To: devel@edk2.groups.io
>Cc: Alexei Fedorov ; Ard Biesheuvel
>; Feng, Bob C ; Wu,
>Jiaxin ; Gao, Liming ; Sami
Update all occurrences of "Jian Wang" to be "Jian J Wang".
Cc: Laszlo Ersek
Cc: Liming Gao
Signed-off-by: Jian J Wang
---
Maintainers.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index dcf81c737a..e30d62cb28 100644
---
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Gao, Zhichao
> Sent: Wednesday, September 18, 2019 1:34 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J; Wu, Hao A; Ni, Ray; Ard Biesheuvel; Laszlo Ersek; Gao,
> Liming
> Subject: [edk2-devel]
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Gao, Zhichao
> Sent: Wednesday, September 18, 2019 1:34 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J; Wu, Hao A; Ni, Ray; Ard Biesheuvel; Laszlo Ersek; Gao,
> Liming
> Subject: [edk2-devel]
Reviewed-by: Dandan Bi
Thanks,
Dandan
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, September 18, 2019 3:49 AM
> To: edk2-devel-groups-io
> Cc: Bi, Dandan ; Wu, Hao A ;
> Wang, Jian J ; Gao, Liming
> Subject: [PATCH 11/35] MdeModulePkg:
Reviewed-by: Dandan Bi
Thanks,
Dandan
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Wednesday, September 18, 2019 3:49 AM
> To: edk2-devel-groups-io
> Cc: Bi, Dandan ; Dong, Eric ;
> Wu, Hao A ; Wang, Jian J ;
> Gao,
Reviewed-by: Dandan Bi
Thanks,
Dandan
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, September 18, 2019 3:49 AM
> To: edk2-devel-groups-io
> Cc: Bi, Dandan ; Dong, Eric ;
> Wu, Hao A ; Wang, Jian J ; Ni,
> Ray ; Gao, Zhichao
> Subject: [PATCH
Reviewed-by: Dandan Bi
Thanks,
Dandan
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, September 18, 2019 3:49 AM
> To: edk2-devel-groups-io
> Cc: Bi, Dandan ; Dong, Eric ;
> Wu, Hao A ; Wang, Jian J ;
> Gao, Liming ; Ni, Ray
> Subject: [PATCH
Reviewed-by: Dandan Bi
Thanks,
Dandan
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, September 18, 2019 3:49 AM
> To: edk2-devel-groups-io
> Cc: Bi, Dandan ; Wu, Hao A ;
> Wang, Jian J ; Gao, Liming
> Subject: [PATCH 13/35] MdeModulePkg: PEI
Reviewed-by: Dandan Bi
Thanks,
Dandan
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, September 18, 2019 3:49 AM
> To: edk2-devel-groups-io
> Cc: Bi, Dandan ; Dong, Eric ;
> Wu, Hao A ; Wang, Jian J
> Subject: [PATCH 08/35]
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Wednesday, September 18, 2019 3:49 AM
> To: edk2-devel-groups-io
> Cc: Achin Gupta; Andrew Fish; Anthony Perard; Ard Biesheuvel; You,
> Benjamin; Zhang, Chao B; Bi, Dandan;
https://bugzilla.tianocore.org/show_bug.cgi?id=2199
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Signed-off-by: Michael D Kinney
---
.../Applications/EepromCmd/EepromCmd.uni | Bin 3558 -> 1778 bytes
.../Applications/FirmwareUpdate/FUpdate.uni | Bin 3500 -> 1749 bytes
https://bugzilla.tianocore.org/show_bug.cgi?id=2199
Convert UNI files in Hisilicon and Marvel packages from UTF-16 to UTF-8.
There are no file content changes in these patches.
The patch files show these as binary files due to the UTF-16 encoding. Future
updates to these files in UTF-8 format
https://bugzilla.tianocore.org/show_bug.cgi?id=2199
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Signed-off-by: Michael D Kinney
---
.../BoardFeature2PHi1610Strings.uni | Bin 3538 -> 1780 bytes
.../Type09/MiscSystemSlotDesignation.uni | Bin 826 -> 412 bytes
2 files changed, 0
Leif,
We prefer ASCII only in source files. I have deleted or changed
to an appropriate ASCII character when I have seen these types
of special symbols.
Mike
> -Original Message-
> From: devel@edk2.groups.io On
> Behalf Of Leif Lindholm
> Sent: Wednesday, September 18, 2019 3:43 PM
>
Leif,
Since this is a readme file, perhaps those should be changed
to `text` markdown style in an ASCII text file and rename the
file to README.md so it is rendered correctly from the GitHub
web view.
Mike
> -Original Message-
> From: devel@edk2.groups.io On
> Behalf Of Leif Lindholm
>
Reviewed-by: Siyuan Fu
> -Original Message-
> From: Leif Lindholm
> Sent: 2019年9月19日 6:43
> To: devel@edk2.groups.io
> Cc: Fu, Siyuan ; Wu, Jiaxin
> Subject: [PATCH 3/9] NetworkPkg: add missing newline at end of file
>
> Add missing newline at end of WifiConnectionManagerDxe .uni.
>
A paragraph sign in a comment came from some ISO8859 encoding,
convert it (and hence the file) to UTF-8.
Cc: Ard Biesheuvel
Signed-off-by: Leif Lindholm
---
ArmPkg/Drivers/ArmScmiDxe/ArmScmiPerformanceProtocolPrivate.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
This file contained what looked like windows 1250 encoded single
quotation marks. Convert them to UTF-8.
Cc: Ard Biesheuvel
Signed-off-by: Leif Lindholm
---
EmbeddedPkg/Scripts/LauterbachT32/README.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Some scripts in Source/Python were missing newlines at end of files,
so add them.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Leif Lindholm
---
BaseTools/Source/Python/AutoGen/DataPipe.py | 2 +-
BaseTools/Source/Python/Common/DataType.py | 2 +-
BaseTools/Source/Python/Common/GlobalData.py
A file header license/copyright header copied around in commit
5b3e695d8ac5 ("BaseTools: add centralized location for git config files")
was missing a CR - add it in both faulty locations.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Leif Lindholm
---
BaseTools/Conf/diff.order| 2 +-
Add missing newline at end of WifiConnectionManagerDxe .uni.
Cc: Siyuan Fu
Cc: Jiaxin Wu
Signed-off-by: Leif Lindholm
---
NetworkPkg/WifiConnectionManagerDxe/WifiConnectionManagerDxeStrings.uni | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Correct line ending in package .dsc.
Cc: Sami Mujawar
Cc: Alexei Fedorov
Signed-off-by: Leif Lindholm
---
DynamicTablesPkg/DynamicTablesPkg.dsc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/DynamicTablesPkg/DynamicTablesPkg.dsc
b/DynamicTablesPkg/DynamicTablesPkg.dsc
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Leif Lindholm
---
BaseTools/Scripts/ConvertFceToStructurePcd.py | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/BaseTools/Scripts/ConvertFceToStructurePcd.py
b/BaseTools/Scripts/ConvertFceToStructurePcd.py
index
I have started looking into doing the CRLF->native conversion for EDK2,
and as part of my initial scan, I found a bunch of trivial issues that
would be easier to just fix beforehand.
Leif Lindholm (9):
BaseTools: add missing newlines at end of files
EmbeddedPkg: add missing newline at end of
While looking at encoding and line ending errors, I found this file
in fact simply points to a sourceforge page which no longer exists.
Since there is nothing more to say than "this is an import of
libfdt", let's just delete it.
Cc: Ard Biesheuvel
Signed-off-by: Leif Lindholm
---
Reviewed-by: Ray Ni
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Jordan Justen
> Sent: Wednesday, September 18, 2019 11:53 AM
> To: Gao, Liming ; devel@edk2.groups.io
> Cc: Johnson, Michael ; Andrew Fish
> ; Ni, Ray ;
> Johnson
> Subject: Re: [edk2-devel] [Patch]
On 2019-09-18 01:13:54, Liming Gao wrote:
> From: mjohn4
It looks like the author is not set properly. If you run "git log -1",
then it'll probably show mjohn4 rather than Michael Johnson.
Michael should run:
$ git config --global user.name "Michael Johnson"
After that when git commit it will
On 09/18/19 17:43, John E Lofgren wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2150
> V3 changes:
> change to mov instruction (non locking instuction) instead
> of xchg to simplify design.
This patch should have been posted as "v4" actually -- it differs from
what you originally
On 09/18/19 17:55, Andrew Fish wrote:
>
>
>> On Sep 18, 2019, at 1:41 AM, Laszlo Ersek wrote:
>>
>> On 09/17/19 22:22, Andrew Fish wrote:
>>>
>>>
On Sep 17, 2019, at 1:06 PM, Ni, Ray wrote:
Laszlo,
Thank you very much for this work.
They are quite helpful to detect
On 09/18/19 17:16, Kinney, Michael D wrote:
>> -Original Message-
>> From: Laszlo Ersek
>> However, if we wanted to allow new projects to #define
>> STRICTER_UEFI_TYPES as their normal mode of operation
>> (and not just for a sanity check in CI), then we'd have
>> to update the UEFI spec
On Tue, Sep 17, 2019 at 09:49:02PM +0200, Laszlo Ersek wrote:
> This patch is unrelated to the rest of the series; it just makes sure that
> "EmbeddedPkg/EmbeddedPkg.dsc" builds for all platforms advertised in
> SUPPORTED_ARCHITECTURES (in particular, X64).
Hmm, I'm nearly 100% sure I have tested
> On Sep 18, 2019, at 3:50 AM, Tiger Liu(BJ-RD) wrote:
>
> Hi, Laszlo:
> Thanks for your reply!
>
> Is Using PcdUse5LevelPageTable also a method to reduce paging table's memory
> requirement?
>
Tiger,
No the 5-level page tables [1] are about increasing the size of the virtual
addresses
Thanks Baptiste,
Ard: I would appreciate if you could sanity check the syntax
conversion in 2/3 - it looks correct to me.
>From my point of view, for the series:
Reviewed-by: Leif Lindholm
But we also need a nod from the MdePkg maintainers.
/
Leif
On Wed, Sep 18, 2019 at 06:05:21PM
On Wed, Sep 18, 2019 at 08:55:42AM -0700, Andrew Fish via Groups.Io wrote:
> >> #ifndef STRICTER_UEFI_TYPES
> >> typedef VOID*EFI_PEI_FV_HANDLE;
> >> #else
> >> struct EFI_PEI_FV_OBJECT;
> >> typedef struct EFI_PEI_FV_OBJECT *EFI_PEI_FV_HANDLE;
> >> #endif
> >
> > Technically, this would work
From: Baptiste GERONDEAU
RVCT and MSFT's ARM assembler share the same file syntax, but some
instructions use pre-UAL syntax that is not picked up
by MSFT's ARM assembler, this commit translates those instructions
into MSFT-buildable ones (subset of UAL/THUMB).
Signed-off-by: Baptiste Gerondeau
From: Baptiste GERONDEAU
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1750;
Since RVCT shares the same assembler syntax as MSFT, use .asm files
and associate them with MSFT, which would be a first step to addressing
the above Bugzilla issue.
RVCT will also have to be erased from
From: Baptiste GERONDEAU
Add a space between the '|' and the name of the toolchain to use,
as is the case in all other INF files.
Note that I did not touch the RVCT lines, since a following commit in
the set will address those.
Signed-off-by: Baptiste Gerondeau
---
> On Sep 18, 2019, at 1:41 AM, Laszlo Ersek wrote:
>
> On 09/17/19 22:22, Andrew Fish wrote:
>>
>>
>>> On Sep 17, 2019, at 1:06 PM, Ni, Ray wrote:
>>>
>>> Laszlo,
>>> Thank you very much for this work.
>>> They are quite helpful to detect potential issues.
>>>
>>> But without this
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2150
V3 changes:
change to mov instruction (non locking instuction) instead
of xchg to simplify design.
V2 changes:
Add xchg 16 bit instructions to handle sgdt and sidt base
63:48 bits and 47:32 bits.
Add comment to explain why xchg 64bit isnt
Sorry. I forgot amend it to the commit. Ill fix it.
Sorry Again,
John
>-Original Message-
>From: Laszlo Ersek [mailto:ler...@redhat.com]
>Sent: Wednesday, September 18, 2019 1:52 AM
>To: devel@edk2.groups.io; Lofgren, John E
>Subject: Re: [edk2-devel] [Patch V3]
> -Original Message-
> From: Laszlo Ersek
> Sent: Wednesday, September 18, 2019 1:42 AM
> To: Andrew Fish ; Ni, Ray
>
> Cc: devel@edk2.groups.io; Achin Gupta
> ; Anthony Perard
> ; Ard Biesheuvel
> ; You, Benjamin
> ; Zhang, Chao B
> ; Bi, Dandan
> ; David Woodhouse
> ; Dong, Eric
> ;
From: Baptiste GERONDEAU
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1750;
Since RVCT shares the same assembler syntax as MSFT, use .asm files
and associate them with MSFT, which would be a first step to addressing
the above Bugzilla issue.
RVCT will also have to be erased from
From: Baptiste GERONDEAU
Add a space between the '|' and the name of the toolchain to use,
as is the case in all other INF files.
Note that I did not touch the RVCT lines, since a following commit in
the set will address those.
Signed-off-by: Baptiste Gerondeau
---
We are currently making an effort to make ARM (and AARCH64 eventually)
builds using Microsoft's Visual Studio Compiler (aka MSVC/MSFT).
These 3 patches correspond to an effort to make the assembler work with
MSFT, which entails :
- Feeding MSFT the RVCT .asm files, since they share syntax
From: Baptiste GERONDEAU
RVCT and MSFT's ARM assembler share the same file syntax, but some
instructions use pre-UAL syntax that is not picked up
by MSFT's ARM assembler, this commit translates those instructions
into MSFT-buildable ones (subset of UAL/THUMB).
Signed-off-by: Baptiste Gerondeau
On 09/17/19 21:10, Michael D Kinney wrote:
> Series Reviewed-by: Michael D Kinney
>
> I also agree that the macros would be cleaner, easy to review, and
> and fewer lines of code without the comment block. If I objected
> previously, then I have also changed my mind. I agree we can go
> ahead
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2201
An error occurs using special VpdPcd that is not used in the Inf file
In dsc:
[PcdsDynamicExVpd.common.DEFAULT]
gBoardModuleTokenSpaceGuid.test1|*|{CODE({
{0x0} // terminator
})}
In dec:
[PcdsDynamicEx]
# Vpd GPIO table
On Tue, Sep 17, 2019 at 09:49:22PM +0200, Laszlo Ersek wrote:
> Unlike the InstallMultipleProtocolInterfaces() boot service, which takes
> an (EFI_HANDLE*) as first parameter, the
> UninstallMultipleProtocolInterfaces() boot service takes an EFI_HANDLE as
> first parameter.
>
> This is an actual
On 09/18/19 00:49, John E Lofgren wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2150
> V3 changes:
> change to mov instruction (non locking instuction) instead
> of xchg to simplify design.
I think something's wrong -- the v3 update described above isn't
actually implemented in the
If AdapterInfo.SetInformation() is unsupported, it will return
EFI_UNSUPPORTED. Do not fail the test in this case.
Cc: Supreeth Venkatesh
Cc: Eric Jin
Signed-off-by: Tom Zhao
---
Notes:
v2:
- Change commit message to be closer to similar issues.
On 09/18/19 07:33, Zhichao Gao wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2186
>
> A common terminal console software Putty support various types of
> keyboard type, such as normal mode, Linux mode, Xterm R6, Vt400,
> VT100+ and SCO. Refer to the link:
>
On 09/17/19 22:22, Andrew Fish wrote:
>
>
>> On Sep 17, 2019, at 1:06 PM, Ni, Ray wrote:
>>
>> Laszlo,
>> Thank you very much for this work.
>> They are quite helpful to detect potential issues.
>>
>> But without this specific patch being checked in, future break will still
>> happen.
>> I
On 09/17/19 22:06, Ni, Ray wrote:
> Laszlo,
> Thank you very much for this work.
> They are quite helpful to detect potential issues.
>
> But without this specific patch being checked in, future break will still
> happen.
Yes, I agree; that's quite likely.
> I don't want it to be checked in
From: "Zhang, Shenglei"
As is requested in the BZ 2077, add two switches to support setting
compression mode and dictionary size.
(https://bugzilla.tianocore.org/show_bug.cgi?id=2077)
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
v2: 1.Update DictionarySize to
From: mjohn4
Add GetTimeInNanoSecond, already declared in the TimerLib API,
to EmulatorPkg implementations of TimerLib.
Cc: Jordan Justen
Cc: Andrew Fish
Cc: Ray Ni
Signed-off-by: Johnson, Michael
---
.../Library/DxeCoreTimerLib/DxeCoreTimerLib.c | 45 -
That's good. I have no other comment. Reviewed-by: Liming Gao
>-Original Message-
>From: Cheng, Ching JenX
>Sent: Wednesday, September 18, 2019 9:51 AM
>To: Gao, Liming ; devel@edk2.groups.io
>Subject: RE: [edk2-devel] [PATCH v2 0/2] *** Add VS2019 Support ***
>
>Hi Liming,
>
>The
Reviewed-by: Bob Feng
-Original Message-
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Steven Shi
Sent: Wednesday, September 18, 2019 11:21 AM
To: devel@edk2.groups.io
Cc: Gao, Liming ; Feng, Bob C
Subject: [edk2-devel] [PATCH v2 1/1] BaseTools: Add more
Simple changes for comments...
Signed-off-by: Gris87
---
MdePkg/Include/Protocol/AbsolutePointer.h | 12 ++--
MdePkg/Include/Protocol/SimplePointer.h | 4 ++--
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/MdePkg/Include/Protocol/AbsolutePointer.h
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1942
avoid using EFI_VARIABLE_RUNTIME_ACCESS without
EFI_VARIABLE_BOOTSERVICE_ACCESS in AttrArray.
Cc: Oleksiy
Cc: Supreeth Venkatesh
Cc: Eric Jin
Signed-off-by: xianhui liu
---
.../BlackBoxTest/AuthVariableServicesBBTestConformance.c
Some minor comments for coding style in below inline, you can correct them when
pushing the commit.
With those coding style issues fixed, Reviewed-by: Chasel Chiu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Zhang,
> Shenglei
> Sent: Wednesday, September 18, 2019
In DxeCheckBootVariable.c, add check for BootOrder and Variable
that return EFI_NOT_FOUND when they are NULL.
In DxeCheckGcd.c, add check for GcdIoMap to ensure it not NULL
when allocating memory to what it points to.
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
93 matches
Mail list logo
