With Zhichao's comments addressed, Reviewed-by: Ray Ni
> -Original Message-
> From: Wang, Jian J
> Sent: Tuesday, October 22, 2019 9:27 PM
> To: Wang, Sunny (HPS SW) ; Gao, Zhichao
> ; devel@edk2.groups.io;
> ler...@redhat.com; Wu, Hao A ; Ni, Ray
> Cc: Li, Walon
> Subject: RE:
Liming,
Could you please modify your commit message changing
WIN_SEC_BUILD to WIN_HOST_BUILD to reflect the real code changes.
> -Original Message-
> From: Gao, Liming
> Sent: Tuesday, October 22, 2019 10:44 PM
> To: devel@edk2.groups.io
> Cc: Justen, Jordan L ; Andrew Fish
> ; Ni, Ray
Thanks Liming!
Please move this to the edk2-staging branch UEFI_PCI_ENHANCE-2.
Just for your reference...
Remote repository:- https://github.com/ashrafj/edk2-staging
This commit:
https://github.com/ashrafj/edk2-staging/commit/170caa6c822c95e5e4fa5506cc8bea479ff2f885
Ashraf
> -Original
Hi Mike and Laszlo,
I agree with Mike's proposal. We can submit new bugz to remove the binary.
Thanks,
Eric
-Original Message-
From: Kinney, Michael D
Sent: Wednesday, October 23, 2019 7:39 AM
To: Laszlo Ersek ; devel@edk2.groups.io; Kinney, Michael D
Cc: Sean Brogan ; Dong, Eric ;
Reviewed-by: Liming Gao
>-Original Message-
>From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com]
>Sent: Tuesday, October 22, 2019 8:44 PM
>To: devel@edk2.groups.io; Kinney, Michael D
>Cc: Sean Brogan ; Gao, Liming
>
>Subject: Re: [edk2-devel] [Patch] FmpDevicePkg: Fix spelling
Hi Philippe,
It is a different patch. I think this is a case where
more than one developer was working in the same area.
I will review the patches from Antoine Cœur
to see if there are additional fixes that were missed in
Sean's patch.
Thanks,
Mike
> -Original Message-
> From:
Update DEBUG() macro to use DEBUG_INFO to address PatchCheck.py error.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Signed-off-by: Michael D Kinney
---
SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
From: Sean Brogan
https://bugzilla.tianocore.org/show_bug.cgi?id=2265
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Signed-off-by: Michael D Kinney
---
SecurityPkg/FvReportPei/FvReportPei.c | 4 ++--
SecurityPkg/Hash2DxeCrypto/Driver.c | 6 ++---
https://bugzilla.tianocore.org/show_bug.cgi?id=2265
Same as V1, with the EFI_D_INFO to DEBUG_INFO change split out into its
own patch. V2 is dropped.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Signed-off-by: Michael D Kinney
Michael D Kinney (1):
SecurityPkg: Change EFI_D_INFO to
Laszlo,
Can we move forward with this patch and enter a new
BZ to remove the binary module?
Mike
> -Original Message-
> From: Laszlo Ersek
> Sent: Tuesday, October 22, 2019 4:27 PM
> To: Kinney, Michael D ;
> devel@edk2.groups.io
> Cc: Sean Brogan ; Dong, Eric
> ; Ni, Ray ; Wei,
>
(+David, +Prince)
On 10/23/19 01:13, Kinney, Michael D wrote:
> Laszlo,
>
> I see 2 usages of this module in edk2-platforms:
>
> edk2-platforms\Silicon\Intel\SimicsX58SktPkg\SktPkgPei.dsc(13):
> UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
>
>
On 10/22/19 20:27, Kinney, Michael D wrote:
> Hi Laszlo,
>
> I agree with the challenges in reviewing these types of
> code changes. The spelling errors in comments are easier
> to review because we know if it is in a comment there is
> no change to code functionality.
>
> The original patch
Laszlo,
I see 2 usages of this module in edk2-platforms:
edk2-platforms\Silicon\Intel\SimicsX58SktPkg\SktPkgPei.dsc(13):
UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
edk2-platforms\Silicon\Intel\SimicsX58SktPkg\SktSecInclude.fdf(16):INF
RuleOverride=RESET_VECTOR USE = IA32
On 10/22/19 21:06, Michael D Kinney wrote:
> From: Sean Brogan
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=2255
>
> Update UefiCpuPkg.dsc to guarantee all libraries and
> modules are always built. Add the following components.
>
> * UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
> *
From: Sean Brogan
https://bugzilla.tianocore.org/show_bug.cgi?id=2257
Add a Null instance of the BaseCryptLib class. This lib instance
can be used as a template for new implementations of the BaseCryptLib
class and can also be used to reduce CI build times for build
checks that depend on the
PcdCpuMaxLogicalProcessorNumber and PcdCpuApInitTimeOutInMicroSeconds are
only referenced in "OvmfPkg/PlatformPei/PlatformPei.inf", and OvmfXen does
not include that module. Remove the unnecessary dynamic PCD defaults from
"OvmfXen.dsc".
Cc: Anthony Perard
Cc: Ard Biesheuvel
Cc: Igor Mammedov
In v1.5.0, QEMU's "pc" (i440fx) board gained a "CPU present bitmap"
register block. In v2.0.0, this was extended to the "q35" board.
In v2.7.0, a new (read/write) register interface was laid over the "CPU
present bitmap", with an option for the guest to switch the register block
to the new
Repo: https://github.com/lersek/edk2.git
Branch: max_cpus_bz_1515_v2
Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=1515
Version 1 was:
[edk2-devel] [PATCH 0/4]
UefiCpuPkg, OvmfPkg: separate PCDs for boot CPU count vs. max CPU count
MaxCpuCountInitialization() currently handles the following options:
(1) QEMU does not report the boot CPU count (FW_CFG_NB_CPUS is 0)
In this case, PlatformPei makes MpInitLib enumerate APs up to the
default PcdCpuMaxLogicalProcessorNumber value (64) minus 1, or until
the default
From: Sean Brogan
https://bugzilla.tianocore.org/show_bug.cgi?id=2258
Add a Null instance of the TlsLib class. This lib instance
can be used as a template for new implementations of the TlsLib
class and can also be used to reduce CI build times for build
checks that depend on the TlsLib class.
From: Sean Brogan
https://bugzilla.tianocore.org/show_bug.cgi?id=2254
Update CryptoPkg.dsc to guarantee all libraries and modules
are always built. Add the following components.
* CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
Cc: Jian J Wang
Cc: Xiaoyu Lu
Signed-off-by: Michael D Kinney
From: Sean Brogan
https://bugzilla.tianocore.org/show_bug.cgi?id=2255
Update UefiCpuPkg.dsc to guarantee all libraries and
modules are always built. Add the following components.
* UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
*
Hello,
I'd like to propose removing the following packages from edk2-platforms/master
since they are no longer maintained:
* Platform/Intel/PurleyOpenBoardPkg
* Silicon/Intel/LewisburgPkg
* Silicon/Intel/PurleyRcPkg
* Silicon/Intel/PurleySktPkg
There is no plan from the current set of
On 10/21/19 22:13, Laszlo Ersek wrote:
> From: Peter Jones
>
> Currently some tests check the value of SOURCE_DEBUG_ENABLE, and some
> tests check if it's defined or not. Additionally, in UefiPayloadPkg as
> well as some other trees, we define it as FALSE in the .dsc file.
>
> This patch
Hi Laszlo,
I agree with the challenges in reviewing these types of
code changes. The spelling errors in comments are easier
to review because we know if it is in a comment there is
no change to code functionality.
The original patch only changed a single EFI_D_ to DEBUG_
for the one DEBUG()
Hi Mike,
On 10/22/19 19:37, Michael D Kinney wrote:
> Update all DEBUG() macros in the SecurityPkg to use
> DEBUG_ instead of EFI_D_. This is required to pass
> PatchCheck.py checks.
[...]
> 45 files changed, 410 insertions(+), 410 deletions(-)
(
If the SecurityPkg maintainers are happy
https://bugzilla.tianocore.org/show_bug.cgi?id=2265
Replace EFI_D_* with DEBUG_* to pass PatchCheck.py checks.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Signed-off-by: Michael D Kinney
Michael D Kinney (1):
SecurityPkg: Replace EFI_D_* with DEBUG_*
Sean Brogan (1):
SecurityPkg: Fix
Update all DEBUG() macros in the SecurityPkg to use
DEBUG_ instead of EFI_D_. This is required to pass
PatchCheck.py checks.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Signed-off-by: Michael D Kinney
---
SecurityPkg/Hash2DxeCrypto/Driver.c | 2 +-
From: Sean Brogan
https://bugzilla.tianocore.org/show_bug.cgi?id=2265
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Signed-off-by: Michael D Kinney
---
SecurityPkg/FvReportPei/FvReportPei.c | 4 ++--
SecurityPkg/Hash2DxeCrypto/Driver.c | 6 ++---
On 10/22/19 6:08 PM, Michael D Kinney wrote:
Response below.
Mike
-Original Message-
From: Philippe Mathieu-Daudé
Sent: Tuesday, October 22, 2019 5:41 AM
To: devel@edk2.groups.io; Kinney, Michael D
Cc: Sean Brogan ; Yao,
Jiewen ; Wang, Jian J
; Zhang, Chao B
Subject: Re:
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603
CLANG9 generated PE image exposes below two issues.
1. SectionSize is used to copy PE section data. It should be smaller than
section raw size.
2. The real data is required to be copied. So, copy the min size of
VirtualSize and SizeOfRawData.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603
Signed-off-by: Liming Gao
Cc: Bob Feng
---
BaseTools/Conf/build_rule.template | 26 ++
BaseTools/Conf/tools_def.template | 102 +
2 files changed, 118 insertions(+), 10 deletions(-)
diff
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603
CLANG9 tool chain defines __clang__ macro only,
doesn't define __GNUC__ macro. But, it uses some same definitions with GCC.
So, update base definition for CLANG9 tool chain.
Signed-off-by: Liming Gao
Cc: Michael Kinney
Reviewed-by:
In v4, use common GCC_ASM_FLAGS to replace GCC5_ASM_FLAGS.
Update the fix in EmulatorPkg with WIN_HOST_BUILD flag.
This version has got the review from all package maintainers.
If no more comment, I will plan to push this patch set on Thursday 10-24.
In v3, add the detail commit message for patch
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603
Define the same macro in the different OS. It can make CLANG generate the same
image in the different host OS.
Signed-off-by: Liming Gao
Reviewed-by: Hao A Wu
---
MdeModulePkg/Library/LzmaCustomDecompressLib/Sdk/C/7zTypes.h | 2 +-
1 file
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603
With this change, global variable _fltused will not be removed by LTO
Signed-off-by: Liming Gao
Reviewed-by: Jian J Wang
Reviewed-by: Philippe Mathieu-Daude
---
CryptoPkg/Library/IntrinsicLib/MemoryIntrinsics.c | 10 --
1 file
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603
$(DEST_DIR_DEBUG) path is in Include directory.
It is not required to be specified again.
Signed-off-by: Liming Gao
Reviewed-by: Bob Feng
---
BaseTools/Conf/tools_def.template | 22 +++---
1 file changed, 11 insertions(+),
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603
Signed-off-by: Liming Gao
Reviewed-by: Hao A Wu
---
MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf | 3 +++
1 file changed, 3 insertions(+)
diff --git
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603
__inline__ has no functional difference effect with the GCC48 / GCC49 / GCC5
toolchains, but it breaks the build with CLANG9. Remove __inline__.
Signed-off-by: Liming Gao
Acked-by: Laszlo Ersek
Cc: Michael Kinney
Reviewed-by: Philippe
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603
Disable warning reported from CLANG9.
Signed-off-by: Liming Gao
Reviewed-by: Jian J Wang
---
CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf| 1 +
CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 1 +
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603
1. Add WIN_SEC_BUILD macro check for CLANG9 tool chain
build -p EmulatorPkg\EmulatorPkg.dsc -a IA32 -DWIN_SEC_BUILD=TRUE -t CLANG9
build -p EmulatorPkg\EmulatorPkg.dsc -a X64 -DWIN_SEC_BUILD=TRUE -t CLANG9
2. Append CLANG CC and LINK flags to
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603
1. Apply CLANG9 Linker option.
2. Exclude -mno-mmx -mno-sse compiler option for CLANG9
These two options will cause CLANG Linker crush.
Signed-off-by: Liming Gao
Reviewed-by: Laszlo Ersek
---
OvmfPkg/OvmfPkgIa32.dsc| 4 +++-
Ashraf:
I have no comments for this patch on edk2-staging. Reviewed-by: Liming Gao
Thanks
Liming
> -Original Message-
> From: Javeed, Ashraf
> Sent: Tuesday, October 22, 2019 11:06 AM
> To: devel@edk2.groups.io; Javeed, Ashraf
> Cc: Kinney, Michael D ; Gao, Liming
> ; Ni, Ray
>
I'm not familiar this part of code. Ray is expert.
Acked-by: Jian J Wang
> -Original Message-
> From: Wang, Sunny (HPS SW)
> Sent: Wednesday, October 16, 2019 5:43 PM
> To: Gao, Zhichao ; devel@edk2.groups.io;
> ler...@redhat.com; Wang, Jian J ; Wu, Hao A
>
> Cc: Ni, Ray ; Li, Walon ;
Hi Michael,
Few review comment below.
On 10/18/19 9:01 PM, Michael D Kinney wrote:
From: Sean Brogan
https://bugzilla.tianocore.org/show_bug.cgi?id=2265
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Signed-off-by: Michael D Kinney
---
SecurityPkg/FvReportPei/FvReportPei.c | 4
On 10/18/19 10:24 PM, Michael D Kinney wrote:
From: Sean Brogan
https://bugzilla.tianocore.org/show_bug.cgi?id=2262
Cc: Liming Gao
Cc: Michael D Kinney
Signed-off-by: Michael D Kinney
---
.../CapsuleUpdatePolicyDxe/CapsuleUpdatePolicyDxe.c | 4 ++--
.../CapsuleUpdatePolicyDxe.inf
Hi Andrew,
Thank you, for the detail answer. It seems this is what I'm looking for. Now
I've found the UEFI specification of the UEFI application I build, and it
appears that the specification of the application is greater than the EFI Shall
specification it is going to be used with. Is it ok,
On 10/21/19 10:13 PM, Laszlo Ersek wrote:
From: Peter Jones
Currently some tests check the value of SOURCE_DEBUG_ENABLE, and some
tests check if it's defined or not. Additionally, in UefiPayloadPkg as
well as some other trees, we define it as FALSE in the .dsc file.
This patch changes all of
On Mon, Oct 21, 2019 at 10:13:20PM +0200, Laszlo Ersek wrote:
> From: Peter Jones
>
> Currently some tests check the value of SOURCE_DEBUG_ENABLE, and some
> tests check if it's defined or not. Additionally, in UefiPayloadPkg as
> well as some other trees, we define it as FALSE in the .dsc
I agree that we want this PCD mentioned in BaseLib header, but most likely it
should be done in a shorter form.
What about something like this?
Unless PcdAssertOnSafeStringConstraints is set to FALSE:
If String is NULL, then ASSERT().
If Data is NULL, then ASSERT().
If String is not
In BaseLib.h, we have below comments in each safe string function header.
===
If an error would be returned, then the function will also ASSERT().
===
As I mentioned earlier, the original purpose is to let the caller guarantee the
correctness of the input. Similar to
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054
Requesting for merge in edk2-stable2019011.
Changes since V1:
- Enable assertions by default to preserve the original behaviour
- Fix bugzilla reference link
Vitaly Cheptsov (1):
MdePkg: Add PCD to disable safe string constraint
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054
Runtime data checks are not meant to cause debug assertions
unless explicitly needed by some debug code (thus the PCD)
as this breaks debug builds validating data with BaseLib.
Signed-off-by: Vitaly Cheptsov >
---
MdePkg/MdePkg.dec
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2054
Requesting for merge in edk2-stable2019011.
Vitaly Cheptsov (1):
MdePkg: Add PCD to disable safe string constraint assertions
MdePkg/MdePkg.dec | 6 ++
MdePkg/Library/BaseLib/BaseLib.inf | 11 ++-
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054
Runtime data checks are not meant to cause debug assertions
unless explicitly needed by some debug code (thus the PCD)
as this breaks debug builds validating data with BaseLib.
Signed-off-by: Vitaly Cheptsov >
---
MdePkg/MdePkg.dec
55 matches
Mail list logo
