> -Original Message-
> From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com]
> Sent: Tuesday, January 7, 2020 3:10 PM
> To: Gao, Zhichao ; devel@edk2.groups.io
> Cc: Ni, Ray
> Subject: Re: [PATCH v2 0/2] ShellPkg: Document the use of
> EFI_INVALID_PARAMETER by two functions
>
> Hi
Hi, Mike
I met a GCC failure in edk2 CI test for my pull request #275 and I’m not sure
whether it’s a CI test issue or my patch problem. Could you please help to
check it? Thanks
https://github.com/tianocore/edk2/pull/275
Failed jobs: Build_GCC5 TARGET_MDE_CPU/Update apt and Copy base tools
Hi Zhichao,
On 1/7/20 8:01 AM, Gao, Zhichao wrote:
Sorry for late response:
-Original Message-
From: Philippe Mathieu-Daude
Sent: Thursday, December 19, 2019 10:10 PM
To: devel@edk2.groups.io
Cc: Ni, Ray ; Gao, Zhichao ;
Philippe Mathieu-Daude
Subject: [PATCH v2 0/2] ShellPkg:
Sorry for late response:
> -Original Message-
> From: Philippe Mathieu-Daude
> Sent: Thursday, December 19, 2019 10:10 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Gao, Zhichao ;
> Philippe Mathieu-Daude
> Subject: [PATCH v2 0/2] ShellPkg: Document the use of
> EFI_INVALID_PARAMETER by
Thomas,
Are you able to share the Clang-format file? I would like to get a format file
as close to edk2 style as possible and then see if we can move the community to
auto formatted code. This could then be easily enforced by a PR gate that
requires all modified/new files to conform to auto
Reviewed-by: Ray Ni
> -Original Message-
> From: Fu, Siyuan
> Sent: Friday, January 3, 2020 3:14 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Wu, Hao A
>
> Subject: [Patch 1/1] UefiCpuPkg: Remove redundant alignment check when
> calculate microcode patch size.
>
> This
Hi Laszlo,
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Monday, January 6, 2020 6:48 PM
> To: Dong, Eric ; devel@edk2.groups.io; Ni, Ray
>
> Subject: Re: [edk2-devel] [PATCH v3 2/2] UefiCpuPkg/PiSmmCpuDxeSmm:
> Fix buffer overflow issue.
>
> On 01/06/20
Reviewed-by: Eric Dong
> -Original Message-
> From: Fu, Siyuan
> Sent: Friday, January 3, 2020 3:14 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Wu, Hao A
>
> Subject: [Patch 1/1] UefiCpuPkg: Remove redundant alignment check when
> calculate microcode patch size.
>
> This
This change has no functionality impact. I agree to make this change in MdePkg
library for the module development support in EFI1.10/UEFI2.7/PI1.7.
With this change, you also need to remove gEfiEventExitBootServicesGuid or
gEfiEventVirtualAddressChangeGuid from module INF file if they are not
Reviewed-by: Ray Ni
> -Original Message-
> From: Ard Biesheuvel
> Sent: Monday, January 6, 2020 11:13 PM
> To: devel@edk2.groups.io
> Cc: Ma, Maurice ; Dong, Guo
> ; You, Benjamin ; Ni, Ray
> ; Gao, Liming ; Wu, Hao A
> ; ler...@redhat.com; Ard Biesheuvel
>
> Subject: [PATCH 0/5]
This reverts commit 123b720eeb371e0a31eb727bcf59255b584e355f.
The commit message for commit 123b720eeb37 is not correct.
Cc: Ray Ni
Cc: Laszlo Ersek
Signed-off-by: Eric Dong
---
UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2434
Current code use below loops to enumerate the CPUs:
for (Index = mMaxNumberOfCpus; Index-- > 0;) {
it has no issue but not easy for the developers to read the code.
Update above code to below style,
for (Index = 0; Index <
This patch serial used to update the commit message.
Rollback the old change and resend it with new commit message.
Cc: Ray Ni
Cc: Laszlo Ersek
Eric Dong (2):
Revert "UefiCpuPkg/PiSmmCpuDxeSmm: Fix buffer overflow issue."
UefiCpuPkg/PiSmmCpuDxeSmm: improve the coding style
On Mon, Jan 6, 2020 at 10:43 AM, Vitaly Cheptsov wrote:
>
> My original suggestion was to remove the assertions entirely, but several
> people here said that they use them to verify usage errors when handling
> trusted data. This makes good sense to me, so we suggest to support both
> cases by
Hi Mike,
Yes, the primary use case is for UEFI Applications. We do not want to disable
ASSERT’s completely, as assertions that make sense, i.e. the ones signalising
about interface misuse, are helpful for debugging.
I have already explained in the BZ that basically all safe string constraint
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Baraneedharan Anbazhagan to have his/her name
and email address displayed properly in the git history.
Cc: Baraneedharan Anbazhagan
Reviewed-by: Baraneedharan Anbazhagan
Signed-off-by: Philippe
Hi Laszlo,
On 1/6/20 7:13 PM, Laszlo Ersek wrote:
On 01/06/20 12:53, Philippe Mathieu-Daude wrote:
The .mailmap git feature helps fixing commit mistakes (in name/email).
The easiest way to use it is with the --use-mailmap flag:
$ git log --use-mailmap
See documentation [1] and [2], and
Hi Vitaly,
Is the use case for UEFI Applications?
There is a different mechanism to disable all ASSERT()
statements within a UEFI Application.
If a component is consuming data from an untrusted source,
then that component is required to verify the untrusted
data before passing it to a
Laszlo,
Sorry for the delay in getting to these PactchCheck.py updates.
I know it is frustrating to be blocked by these types of issues.
I try to look at 2406 tomorrow. I think the manual override is
potentially more complex to implement than the requested changed
to PatchCheck.py.
You were on
On 01/06/20 12:53, Philippe Mathieu-Daude wrote:
> The .mailmap git feature helps fixing commit mistakes (in name/email).
>
> The easiest way to use it is with the --use-mailmap flag:
>
> $ git log --use-mailmap
>
> See documentation [1] and [2], and interesting blog [3].
>
> Laszlo replied
Hi Mike,
On 11/12/19 03:55, Michael D Kinney wrote:
> EDK II Maintainers,
>
> EDK II CI Phase 1 feature is now active on edk2/master.
>
> Please use a GitHub pull request from a branch in a personal
> fork of the edk2 repository with a 'push' label to request
> a set of patches to be pushed to
On 01/06/20 16:13, Ard Biesheuvel wrote:
> EnterS3WithImmediateWake () no longer has any callers, so remove it
> from ResetSystemLib.
>
> Signed-off-by: Ard Biesheuvel
> ---
> ArmVirtPkg/Library/ArmVirtPsciResetSystemLib/ArmVirtPsciResetSystemLib.c |
> 14 --
> 1 file changed, 14
On 01/06/20 16:13, Ard Biesheuvel wrote:
> EnterS3WithImmediateWake () no longer has any callers, so remove it
> from ResetSystemLib.
>
> Signed-off-by: Ard Biesheuvel
> ---
> OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c | 18 --
> 1 file changed, 18 deletions(-)
>
> diff
On 01/06/20 11:36, Anthony PERARD wrote:
> On Fri, Jan 03, 2020 at 02:42:14PM +0100, Laszlo Ersek wrote:
>> On 01/03/20 10:07, Philippe Mathieu-Daudé wrote:
>>> From: Antoine Coeur
>>>
>>> Fix various typos in comments and documentation.
>>>
>>> Cc: Jordan Justen
>>> Cc: Laszlo Ersek
>>> Cc:
EnterS3WithImmediateWake () no longer has any callers, so remove it
from ResetSystemLib.
Signed-off-by: Ard Biesheuvel
---
UefiPayloadPkg/Library/ResetSystemLib/ResetSystemLib.c | 18 --
1 file changed, 18 deletions(-)
diff --git
EnterS3WithImmediateWake () no longer has any callers, so remove it
from ResetSystemLib.
Signed-off-by: Ard Biesheuvel
---
ArmVirtPkg/Library/ArmVirtPsciResetSystemLib/ArmVirtPsciResetSystemLib.c | 14
--
1 file changed, 14 deletions(-)
diff --git
EnterS3WithImmediateWake () no longer has any callers, so remove it
from ResetSystemLib.
Signed-off-by: Ard Biesheuvel
---
PcAtChipsetPkg/Library/ResetSystemLib/ResetSystemLib.c | 17 -
1 file changed, 17 deletions(-)
diff --git
EnterS3WithImmediateWake () no longer has any callers, so remove it
from ResetSystemLib.
Signed-off-by: Ard Biesheuvel
---
OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c | 18 --
1 file changed, 18 deletions(-)
diff --git a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c
EnterS3WithImmediateWake () no longer has any callers, so remove it
from ResetSystemLib.
Signed-off-by: Ard Biesheuvel
---
MdeModulePkg/Include/Library/ResetSystemLib.h| 11
---
MdeModulePkg/Library/BaseResetSystemLibNull/BaseResetSystemLibNull.c | 14
After a refactor of the capsule update support, EnterS3WithImmediateWake()
was left without any callers in the tree, so remove the declaration and the
various definitions.
Ard Biesheuvel (5):
MdeModulePkg: remove EnterS3WithImmediateWake () from ResetSystemLib
PcAtChipsetPkg: remove
On 1/2/20 7:36 PM, Kinney, Michael D wrote:
Hi Phil,
I am curious why the GIT committer information is so important.
Before CI, for any given package, the committer can be the
primary maintainer, the backup maintainer, or a steward.
The maintainer that actually does the commit is following the
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Yu-Chen Lin to have his/her name and email
address displayed properly in the git history.
Cc: Yu-Chen Lin
Reviewed-by: Yu-Chen Lin
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 1 +
1 file
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Star Zeng to have his/her name and email address
displayed properly in the git history.
Cc: Star Zeng
Reviewed-by: Star Zeng
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 3 +++
1 file
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Yonghong Zhu to have his/her name and email
address displayed properly in the git history.
Cc: Yonghong Zhu
Reviewed-by: Yonghong Zhu
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 2 ++
1
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Ray Ni to have his/her name and email address
displayed properly in the git history.
Cc: Ray Ni
Reviewed-by: Ray Ni
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 7 +++
1 file changed, 7
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Nikolai Saoukh to have his/her name and email
address displayed properly in the git history.
Cc: Nikolai Saoukh
Reviewed-by: Nikolai Saoukh
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 1 +
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Philippe Mathieu-Daudé to have his/her name and
email address displayed properly in the git history.
Reviewed-by: Laszlo Ersek
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 1 +
1 file
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Samer El-Haj-Mahmoud to have his/her name and
email address displayed properly in the git history.
Cc: Samer El-Haj-Mahmoud
Cc: Samer El-Haj-Mahmoud
Reviewed-by: Samer El-Haj-Mahmoud
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Michael Kubacki to have his/her name and email
address displayed properly in the git history.
Cc: Michael Kubacki
Reviewed-by: Michael Kubacki
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 2
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Shenglei Zhang to have his/her name and email
address displayed properly in the git history.
Cc: Shenglei Zhang
Reviewed-by: Shenglei Zhang
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 1 +
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Vitaly Cheptsov to have his/her name and email
address displayed properly in the git history.
Cc: Vitaly Cheptsov
Reviewed-by: Vitaly Cheptsov
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 1
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Ming Tan to have his/her name and email address
displayed properly in the git history.
Cc: Ming Tan
Reviewed-by: Ming Tan
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 1 +
1 file changed, 1
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Maurice Ma to have his/her name and email
address displayed properly in the git history.
Cc: Maurice Ma
Reviewed-by: Maurice Ma
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 1 +
1 file
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Vladimir Olovyannikov to have his/her name and
email address displayed properly in the git history.
Cc: Vladimir Olovyannikov
Reviewed-by: Vladimir Olovyannikov
Signed-off-by: Philippe Mathieu-Daude
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Laszlo Ersek to have his/her name and email
address displayed properly in the git history.
Cc: Laszlo Ersek
Reviewed-by: Laszlo Ersek
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 2 ++
1
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Antoine Cœur to have his/her name and email
address displayed properly in the git history.
Cc: Antoine Cœur
Reviewed-by: Antoine Cœur
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 2 ++
1
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Maciej Rabeda to have his/her name and email
address displayed properly in the git history.
Cc: Maciej Rabeda
Reviewed-by: Maciej Rabeda
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 1 +
1
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Erik Bjorge to have his/her name and email
address displayed properly in the git history.
Cc: Erik Bjorge
Reviewed-by: Erik Bjorge
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 1 +
1 file
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Christopher J Zurcher to have his/her name and
email address displayed properly in the git history.
Cc: Christopher J Zurcher
Reviewed-by: Christopher J Zurcher
Signed-off-by: Philippe Mathieu-Daude
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Ashley DeSimone to have his/her name and email
address displayed properly in the git history.
Cc: Ashley DeSimone
Reviewed-by: Ashley DeSimone
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 1
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Liming Gao to have his/her name and email
address displayed properly in the git history.
Cc: Liming Gao
Reviewed-by: Liming Gao
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 4
1 file
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Ard Biesheuvel to have his/her name and email
address displayed properly in the git history.
Cc: Ard Biesheuvel
Reviewed-by: Ard Biesheuvel
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 1 +
The .mailmap git feature helps fixing commit mistakes (in name/email).
The easiest way to use it is with the --use-mailmap flag:
$ git log --use-mailmap
See:
* https://git-scm.com/docs/git-shortlog#_mapping_authors
* https://git-scm.com/docs/git-check-mailmap#_mapping_authors
Reviewed-by:
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Jiewen Yao to have his/her name and email
address displayed properly in the git history.
Cc: Jiewen Yao
Reviewed-by: Jiewen Yao
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 6 ++
1 file
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Aaron Li to have his/her name and email address
displayed properly in the git history.
Cc: Aaron Li
Cc: Songpeng Li
Reviewed-by: Aaron Li
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 2 ++
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Hao Wu to have his/her name and email address
displayed properly in the git history.
Cc: Hao Wu
Reviewed-by: Hao A Wu
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 2 ++
1 file changed, 2
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Marvin Häuser to have his/her name and email
address displayed properly in the git history (in particular,
commit 62ec4a5e).
Cc: Marvin Häuser
Cc: Marvin Häuser
Reviewed-by: Marvin Häuser
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Eric Dong to have his/her name and email
address displayed properly in the git history.
Cc: Eric Dong
Reviewed-by: Eric Dong
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 4
1 file
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Marc-André Lureau to have his/her name and email
address displayed properly in the git history.
Cc: Marc-André Lureau
Reviewed-by: Marc-André Lureau
Signed-off-by: Philippe Mathieu-Daude
---
The .mailmap git feature helps fixing commit mistakes (in name/email).
The easiest way to use it is with the --use-mailmap flag:
$ git log --use-mailmap
See documentation [1] and [2], and interesting blog [3].
Laszlo replied [4] to v1 explaining stewards want to avoid avoid
cross-domain
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Chasel Chiu to have his/her name and email
address displayed properly in the git history.
Cc: Chasel Chiu
Reviewed-by: Chasel Chiu
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 1 +
1 file
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Hot Tian to have his/her name and email address
displayed properly in the git history.
Cc: Hot Tian
Reviewed-by: Hot Tian
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 2 ++
1 file changed,
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Jim Dailey to have his/her name and email
address displayed properly in the git history.
Cc: Jim Dailey
Reviewed-by: Jim Dailey
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 2 ++
1 file
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Baraneedharan Anbazhagan to have his/her name
and email address displayed properly in the git history.
Cc: Baraneedharan Anbazhagan
Reviewed-by: Baraneedharan Anbazhagan
Signed-off-by: Philippe
On 1/6/20 11:41 AM, Laszlo Ersek wrote:
On 01/03/20 14:56, Philippe Mathieu-Daudé wrote:
On 1/3/20 2:48 PM, Laszlo Ersek wrote:
Apparently, there is a patch that
prevents the series from being merged? Which one?
This comment was about patch 13/32, but Jiewen Yao already reviewed
it,
OK,
On 01/06/20 02:15, Dong, Eric wrote:
> Hi Laszlo,
>
>> -Original Message-
>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>> Laszlo Ersek
>> Sent: Saturday, January 4, 2020 2:11 AM
>> To: devel@edk2.groups.io; Ni, Ray ; Dong, Eric
>>
>> Subject: Re: [edk2-devel]
On 01/03/20 14:56, Philippe Mathieu-Daudé wrote:
> On 1/3/20 2:48 PM, Laszlo Ersek wrote:
>> Apparently, there is a patch that
>> prevents the series from being merged? Which one?
>
> This comment was about patch 13/32, but Jiewen Yao already reviewed
> it,
OK, thanks.
> so this series is fully
On Fri, Jan 03, 2020 at 02:42:14PM +0100, Laszlo Ersek wrote:
> On 01/03/20 10:07, Philippe Mathieu-Daudé wrote:
> > From: Antoine Coeur
> >
> > Fix various typos in comments and documentation.
> >
> > Cc: Jordan Justen
> > Cc: Laszlo Ersek
> > Cc: Ard Biesheuvel
> > Cc: Anthony Perard
> >
We are checking different emails from the signature list. We are
going to check more. To be able to differency, add a description
field, so the error reported is clearer.
Cc: Liming Gao
Cc: Jordan Justen
Signed-off-by: Philippe Mathieu-Daude
---
BaseTools/Scripts/PatchCheck.py | 10 +++---
To avoid patches committed with incorrect email address,
use the EmailAddressCheck class on the committer email too.
Cc: Liming Gao
Cc: Jordan Justen
Signed-off-by: Philippe Mathieu-Daude
---
v2: Do not use "" because we use subprocess.Popen (Jordan Justen)
---
BaseTools/Scripts/PatchCheck.py
To avoid patches committed with incorrect email address,
use the EmailAddressCheck class on the author email too.
Example:
$ python BaseTools/Scripts/PatchCheck.py 1a04951309f
Checking git commit: 1a04951309f
The 'Author' email address is not valid:
* The email address cannot contain a
Last month I cleaned the git-history incorrect email
addresses: https://edk2.groups.io/g/devel/message/51834
but today I noticed more incorrect addresses got committed
(see caa917491a4..33a3293651).
To avoid having the same cleanup in the future, fix the
problem once for all by having PatchCheck
As we are going to reuse this code out of the CommitMessageCheck
class, extract it in a new class: EmailAddressCheck.
Cc: Liming Gao
Cc: Jordan Justen
Signed-off-by: Philippe Mathieu-Daude
---
BaseTools/Scripts/PatchCheck.py | 82 +
1 file changed, 53
Hi Ray,
Could you help review this patch?
Thanks,
Shenglei
> -Original Message-
> From: Chen, Marc W
> Sent: Thursday, December 26, 2019 2:53 PM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A ; Chaganty, Rangasai V
> ; Gao, Liming ;
> Zhang, Shenglei ; Chen, Marc W
>
> Subject:
74 matches
Mail list logo
