Ray,
I applied this change to an internal desktop machine and did below tests:
1. boot it to shell
2. reboot the system to shell.
Thanks,
Eric
From: Ni, Ray
Sent: Wednesday, January 15, 2020 3:43 PM
To: devel@edk2.groups.io; Dong, Eric
Cc: Laszlo Ersek
Subject: RE: [edk2-devel]
Eric,
What unit test was done for this patch?
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Dong, Eric
> Sent: Wednesday, January 15, 2020 2:07 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Laszlo Ersek
> Subject: [edk2-devel] [PATCH] UefiCpuPkg/Library/MpInitLib:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2392
Current code implementation assumes BSP index is 0 at the begin.
This code change removes this assumption. It get BSP index from
the saved data structure if it existed.
Cc: Ray Ni
Cc: Laszlo Ersek
Signed-off-by: Eric Dong
---
Since I don't have a strong opinion either, I won't make any changes to V1 at
this time.
Thanks,
Michael
> -Original Message-
> From: Wang, Jian J
> Sent: Tuesday, January 14, 2020 8:09 PM
> To: Kubacki, Michael A ;
> devel@edk2.groups.io
> Cc: Gao, Liming ; Kinney, Michael D
> ;
Mike,
Thanks for explaining. You're right that the error is rare case and it won't
cause big problem, and NonVolatileLastVariableOffset will be approaching
the whole FV size after some time. I don't have strong opinion. Both work
for me.
Regards,
Jian
> -Original Message-
> From:
Hi Jian,
I considered that but these are the reasons I settled on the approach in patch
V1.
1. With the variable store filled, the length of
mVariableModuleGlobal->NonVolatileLastVariableOffset will only marginally be a
smaller value than mNvVariableCache->Size (since variable writes grow the
Amol:
This is new feature. Please submit BZ (https://bugzilla.tianocore.org/) to
track it. If this feature catches edk2 2020 Q1 stable tag, I will add it into
edk2 feature planning.
Thanks
Liming
-Original Message-
From: devel@edk2.groups.io On Behalf Of Wang, Jian J
Sent:
Laszlo,
I tend to make it a platform local implementation first.
Your proposals impact a broader scope which we could
consider later if it's hard for a platform to handle the issue.
Thanks,
Ray
> -Original Message-
> From: Laszlo Ersek
> Sent: Saturday, January 11, 2020 12:24 AM
> To:
Amol,
1. Your patch doesn't support hashing more than one algorithm at the same time.
Is this on purpose? Sorry I don't remember the conclusion in last discussion.
2. There're trailing spaces in BaseHashLibCommon.c and BashHashLibCommon.h.
You can use BaseTools\Scripts\PatchCheck.py to
> -Original Message-
> From: af...@apple.com
> Sent: Wednesday, January 15, 2020 1:45 AM
> To: devel@edk2.groups.io; Ard Biesheuvel
> Cc: Laszlo Ersek ; Ni, Ray ; Leif
> Lindholm ; Gao, Zhichao ;
> Ma, Maurice ; Dong, Guo ;
> You, Benjamin
> Subject: Re: [edk2-devel] [RFC PATCH 2/2]
HI Bret
That is awesome.
I am also excited to see that.
I really like the rust unit test idea because the framework is embedded in the
language and compiler.
That is perfect example to demonstrate the value of rust for EDKII. ☺
I have a quick look at the code. Here is my thought:
1) about the
Reviewed-by: Bob Feng
-Original Message-
From: Li, Aaron
Sent: Friday, January 10, 2020 9:58 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming
Subject: [PATCH v1] BaseTools/Capsule: Add capsule dependency support
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2412
What’s better than UnitTests almost being ready for deployment in TianoCore?
How about using those UnitTests to validate a native Rust port of one of our
VarCheck libs?
Building upon Jiewen’s work (among others) I’ve finally managed to prototype a
port of the UefiVariablePolicyLib to Rust, and
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Albecki, Mateusz
> Sent: Tuesday, January 14, 2020 8:05 PM
> To: devel@edk2.groups.io
> Cc: Albecki, Mateusz; Wu, Hao A; Marcin Wojtas; Gao, Zhichao; Gao, Liming
> Subject: [edk2-devel] [PATCHv2
Reviewed-by: Eric Dong
> -Original Message-
> From: Bi, Dandan
> Sent: Tuesday, January 14, 2020 4:57 PM
> To: devel@edk2.groups.io
> Cc: Haug, Brian R ; Gao, Liming
> ; Dong, Eric
> Subject: [patch] MdeModulePkg/Setup: Update opcode number variable
> type to UINTN
>
> From: Brian R
On Tue, Jan 14, 2020 at 16:32:53 +, Leif Lindholm wrote:
> I changed jobs at the turn of the year and now work for NUVIA
> (https://nuviainc.com/). My employer would like me to continue working
> on TianoCore, so let's just update the address to my current one.
>
> I have Cc:d anyone I share
On Tue, 14 Jan 2020 at 17:43, Ard Biesheuvel wrote:
>
> On Tue, 7 Jan 2020 at 10:22, Ard Biesheuvel wrote:
> >
> > Some preparatory fixes for TPM measured boot on ARM systems.
> >
> > Patch #1 removes EnterS3WithImmediateWake() with the associated support
> > code from ArmSmcPsciResetSystemLib.
CC Phil
On 01/14/20 17:32, Leif Lindholm wrote:
> Leif now works at NUVIA Inc, update email address accordingly.
>
> Cc: Andrew Fish
> Cc: Ard Biesheuvel
> Cc: Laszlo Ersek
> Cc: Michael D Kinney
> Cc: Ray Ni
> Cc: Zhichao Gao
> Cc: Leif Lindholm
> Signed-off-by: Leif Lindholm
> ---
>
Reviewed-by: Ashley DeSimone
-Original Message-
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Desimone,
Nathaniel L
Sent: Thursday, January 9, 2020 5:04 PM
To: devel@edk2.groups.io
Cc: Desimone, Ashley E ; Pandya, Puja
; Bjorge, Erik C ; Bret
Barkelew ;
On 1/14/20 5:37 PM, Ard Biesheuvel wrote:
On Tue, 14 Jan 2020 at 17:32, Leif Lindholm wrote:
I changed jobs at the turn of the year and now work for NUVIA
(https://nuviainc.com/). My employer would like me to continue working
on TianoCore, so let's just update the address to my current one.
From: Pierre Gondois
The dependencies for C files are satisfied by the build system.
However, there are use cases where source files with different
languages are inter-dependent. The EDKII build framework
currently doesn't have options to specify such dependencies.
E.g. It may be necessary to
From: Pierre Gondois
The "-tc" option of the iasl compiler allows to generate a
.hex file containing a C array storing AML bytecode.
An online discussion suggested that this "-tc" option
was specific to the iasl compiler and it shouldn't be relied
on. This conversation is available at:
> On Jan 14, 2020, at 8:46 AM, Ard Biesheuvel wrote:
>
> On Mon, 13 Jan 2020 at 18:57, Andrew Fish via Groups.Io
> wrote:
>>
>> Ard,
>>
>> Is the problem GFX console? Would it be possible to have a PCD to assume
>> graphics console, and if non was found on the boot connect those PCI
On Tue, 14 Jan 2020 at 18:18, Leif Lindholm wrote:
>
> Apologies for late response - only just got email fully back up.
> Minor comment below.
>
> On Tue, Jan 07, 2020 at 10:22:14 +0100, Ard Biesheuvel wrote:
> > EnterS3WithImmediateWake () no longer has any callers, so remove it
> > from
On Tue, 14 Jan 2020 at 18:26, Leif Lindholm wrote:
>
> On Tue, Jan 07, 2020 at 10:27:39 +0100, Ard Biesheuvel wrote:
> > The PCD PcdArmReenterPeiForCapsuleWarmReboot is going away so drop the
> > definition for DeveloperBox.
> >
> > Signed-off-by: Ard Biesheuvel
>
> Reviewed-by: Leif Lindholm
>
On Tue, Jan 07, 2020 at 10:27:39 +0100, Ard Biesheuvel wrote:
> The PCD PcdArmReenterPeiForCapsuleWarmReboot is going away so drop the
> definition for DeveloperBox.
>
> Signed-off-by: Ard Biesheuvel
Reviewed-by: Leif Lindholm
> ---
> Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc | 1
On Tue, Jan 07, 2020 at 10:22:15 +0100, Ard Biesheuvel wrote:
> While the alternative PEI-less SEC implementation in PrePi already
> takes the EnableVFP PCD into account, the PrePeiCore code does not,
> and so we may end up triggering synchronous exception when code
> attempts to use FP or SIMD
Hi Gao,
> Hi Vladimir,
>
> > -Original Message-
> > From: Vladimir Olovyannikov
> > Sent: Saturday, January 11, 2020 12:33 AM
> > To: Ni, Ray ; devel@edk2.groups.io; Gao, Zhichao
> >
> > Subject: RE: [edk2-devel] [PATCH 1/1] ShellPkg/Application: Support
> > nested variables
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2453
Fixed coding style issues as reported by the ECC tool
Cc: Shenglei Zhang
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Michael Kubacki
Signed-off-by: Prince Agyeman
---
.../BoardModulePkg/LegacySioDxe/ComponentName.h | 5 +
Apologies for late response - only just got email fully back up.
Minor comment below.
On Tue, Jan 07, 2020 at 10:22:14 +0100, Ard Biesheuvel wrote:
> EnterS3WithImmediateWake () no longer has any callers, so remove it
> from ResetSystemLib. Note that this means the hack to support warm
> reboot
Leif now works at NUVIA Inc, update email address accordingly.
Cc: Andy Hayes
Cc: Ard Biesheuvel
Cc: Marcin Wojtas
Cc: Michael D Kinney
Cc: Pete Batard
Cc: Leif Lindholm
Signed-off-by: Leif Lindholm
---
Maintainers.txt | 24
1 file changed, 12 insertions(+), 12
I changed jobs at the turn of the year and now work for NUVIA
(https://nuviainc.com/). My employer would like me to continue working
on TianoCore, so let's just update the address to my current one.
I have Cc:d anyone I share a section in a Maintainers.txt with, but I
don't think I need
Leif now works at NUVIA Inc, update email address accordingly.
Cc: Andrew Fish
Cc: Ard Biesheuvel
Cc: Laszlo Ersek
Cc: Michael D Kinney
Cc: Ray Ni
Cc: Zhichao Gao
Cc: Leif Lindholm
Signed-off-by: Leif Lindholm
---
Maintainers.txt | 14 +++---
1 file changed, 7 insertions(+), 7
On Mon, 13 Jan 2020 at 18:57, Andrew Fish via Groups.Io
wrote:
>
> Ard,
>
> Is the problem GFX console? Would it be possible to have a PCD to assume
> graphics console, and if non was found on the boot connect those PCI devices
> and update the NVRAM to cause a console to connect. You might
On Tue, 7 Jan 2020 at 10:22, Ard Biesheuvel wrote:
>
> Some preparatory fixes for TPM measured boot on ARM systems.
>
> Patch #1 removes EnterS3WithImmediateWake() with the associated support
> code from ArmSmcPsciResetSystemLib. EnterS3WithImmediateWake () is no
> longer being called anywhere,
On Tue, 14 Jan 2020 at 17:32, Leif Lindholm wrote:
>
> I changed jobs at the turn of the year and now work for NUVIA
> (https://nuviainc.com/). My employer would like me to continue working
> on TianoCore, so let's just update the address to my current one.
>
> I have Cc:d anyone I share a
This commit introduces a Unified Hash API to calculate hash using a
hashing algorithm specified by the PCD, PcdSystemHashPolicy. This library
interfaces with the various hashing API, such as, MD4, MD5, SHA1, SHA256,
SHA512 and SM3_256 implemented in CryptoPkg. The user can calculate the
desired
Currently, the UEFI drivers using the SHA/SM3 hashing algorithms use hard-coded
API to calculate the hash, for instance, sha_256(...), etc. Since SHA384 and/or
SM3_256 are being increasingly adopted for robustness, it becomes cumbersome to
modify each driver that calls into hash calculating API.
On 01/14/20 14:08, Laszlo Ersek wrote:
> Hi Dandan, Brian,
>
> On 01/14/20 09:56, Dandan Bi wrote:
>> From: Brian R Haug
>>
>> Update data type of variables which save the opcode numbers
>> to UINTN, in case some configuration module has lots of
>> configuration items.
>>
>> Cc: Liming Gao
>>
Hi Dandan, Brian,
On 01/14/20 09:56, Dandan Bi wrote:
> From: Brian R Haug
>
> Update data type of variables which save the opcode numbers
> to UINTN, in case some configuration module has lots of
> configuration items.
>
> Cc: Liming Gao
> Cc: Eric Dong
> Signed-off-by: Brian R Haug
>
On 01/14/20 11:34, Vitaly Cheptsov via Groups.Io wrote:
> - ConnectControllers
> ShellPkg/Library/UefiShellDriver1CommandsLib/Connect.c
>
> This one is more complex, as it supports explicitly connecting specified
> controllers, however, for connecting all controllers it locates handles with
>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2463
Perform Data and Address line test only if not ignore memory test.
Signed-off-by: Heng Luo
---
.../MemoryTest/GenericMemoryTestDxe/LightMemoryTest.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git
Hello Siva,
Which tools did you use to generate this patch? I cannot apply it via
'git am' command.
Did you follow the edk2 git guide (using git format-patch && git
send-email commands)?
This patch adds retries for async execution for commands that
failed due to the CRC errors.
Cc: Hao A Wu
Cc: Marcin Wojtas
Cc: Zhichao Gao
Cc: Liming Gao
Signed-off-by: Mateusz Albecki
---
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 6 --
1 file changed, 4 insertions(+), 2
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1140
Some of the boards report that just after we change the clock frequency to
200MHz link is unable to stabilize fast enough and when driver sends the CMD13
it will often fail randomly with CRC error. To protect against this kind of
random
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1140
Error detection function will now check if the command
failure has been caused by one of the errors that can
appear randomly on link(CRC error + end bit error). If
such an error has been a cause of failure, function will
return
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1140
To increase the resiliency driver will now attempt to
retry the commands that failed due to the CRC error up
to 5 times. This should address the problems with the commands
that fail due to random condition on links. This should also
help
Driver used to reset the DAT lane on a current error which
is not required according to SD specification(it's not going
to help). This patch will reset the DAT lane only on DAT
lane specific errors.
Cc: Hao A Wu
Cc: Marcin Wojtas
Cc: Zhichao Gao
Cc: Liming Gao
Signed-off-by: Mateusz Albecki
On 01/09/20 00:43, Laszlo Ersek wrote:
> Repo: https://github.com/lersek/edk2.git
> Branch: tweaks_for_large_http
>
> This series aims to improve HTTP(S) Boot experience with large (4GiB+)
> files.
>
> Cc: Hao A Wu
> Cc: Jian J Wang
> Cc: Jiaxin Wu
> Cc: Maciej Rabeda
> Cc: Ray Ni
> Cc:
In addition to my previous letter I have to mention a couple more newly
discovered details.
1. UEFI Shell (ShellPkg) actually has 3 functions dedicated to connecting
controllers and essentially doing the same thing:
- ConnectAllEfi
ShellPkg/Library/UefiShellLevel2CommandsLib/Load.c
This one
On 01/14/20 07:26, Jian J Wang wrote:
>> v2 changes:
>> - change HmacXxxInit to HmacXxxSetKey
>> - remove calling to HMAC_CTX_reset() since HmacXxxNew() has done it
>> already and user-supplied context is not supported any longer.
>> - update comments affected by above change
>
> REF:
From: Brian R Haug
Update data type of variables which save the opcode numbers
to UINTN, in case some configuration module has lots of
configuration items.
Cc: Liming Gao
Cc: Eric Dong
Signed-off-by: Brian R Haug
Reviewed-by: Dandan Bi
---
.../Universal/SetupBrowserDxe/IfrParse.c |
On 01/13/20 19:38, Kinney, Michael D wrote:
> Hi Laszlo,
>
> This patch has been pushed.
>
> https://github.com/tianocore/edk2/pull/297
>
> I also entered a new BZ to relax CVE pattern check.
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=2462
Thank you for both!
Laszlo
Ray,
We are quite reluctant to have patches in EDK II for a large amount of widely
adopted firmwares. Patches eventually break and require maintenance cost, and
currently we are trying to get rid of them all. We believe that EDK II Shell is
supposed to work on real world platforms and not only
54 matches
Mail list logo
