Re: [edk2-devel] [PATCH 07/19] Silicon/NXP: remove not needed components

2020-02-10 Thread Pankaj Bansal
> -Original Message- > From: Leif Lindholm > Sent: Monday, February 10, 2020 10:42 PM > To: Pankaj Bansal > Cc: Meenakshi Aggarwal ; Michael D Kinney > ; Varun Sethi ; > devel@edk2.groups.io > Subject: Re: [PATCH 07/19] Silicon/NXP: remove not needed components > > On Fri, Feb 07,

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 02/12] MdeModulePkg/PciBusDxe: Setup PCI Express init phase

2020-02-10 Thread Javeed, Ashraf
> -Original Message- > From: Ni, Ray > Sent: Monday, February 10, 2020 2:16 PM > To: Javeed, Ashraf ; devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A > Subject: RE: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 02/12] > MdeModulePkg/PciBusDxe: Setup PCI Express init phase >

Re: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB

2020-02-10 Thread Vitaly Cheptsov via Groups.Io
Liming, Done. As a side note, I am not positive how can 7990438f1437f47990a8890dee51978cb8dbc25c[1] resolve BZ 2415[2]. The bug was about CLANG38, and the toolchain updated was CLANGPDB. While it makes sense to update CLANGPDB with this flag to stay clean (it will not make a difference for

[edk2-devel] [PATCH V2 0/1] BaseTools: Switch to GNU mode for CLANGPDB

2020-02-10 Thread Vitaly Cheptsov via Groups.Io
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2397 I did not include __clang__ removal in this patch series, as it is also used in arm and aarch64 code, which makes me believe they could be using specialised toolchains. V2 performed a rebase onto recent master commits. Request this to be

Re: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB

2020-02-10 Thread Liming Gao
Vitaly: Can you update this patch based on the latest edk2 trunk? I will catch it for edk2 Q1 stable tag. Thanks Liming From: devel@edk2.groups.io On Behalf Of Liming Gao Sent: Tuesday, February 11, 2020 1:34 PM To: vit9696 ; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH 1/1]

Re: [edk2-devel] [PATCH v2] Add support for Diagnostics ACM in FitGen tool

2020-02-10 Thread Liming Gao
Push @ 8864a1ad2f090e8f71bb4a5da873baf903f5e053 > -Original Message- > From: devel@edk2.groups.io On Behalf Of Liming Gao > Sent: Monday, February 10, 2020 10:10 PM > To: Agrawal, Sachin ; devel@edk2.groups.io > Cc: Feng, Bob C > Subject: Re: [edk2-devel] [PATCH v2] Add support for

Re: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB

2020-02-10 Thread Liming Gao
Reviewed-by: Liming Gao From: vit9696 Sent: Tuesday, February 11, 2020 3:23 AM To: Gao, Liming ; devel@edk2.groups.io Subject: RE: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB Liming, We did run several of our projects based on EDK II in X64 mode, DEBUG, RELEASE,

Re: [edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Fix FADT Parser

2020-02-10 Thread Ashish Singhal
Thanks Zhichao, Just saw a bunch of ShellPkg changes got merged including mine. Thanks Ashish -Original Message- From: Gao, Zhichao Sent: Monday, February 10, 2020 7:55 PM To: devel@edk2.groups.io; Ashish Singhal ; Ni, Ray Subject: RE: [edk2-devel] [PATCH]

Re: [edk2-devel] [PATCH v1 0/2] Fix backward incompatible CPU_MP_DATA struct change

2020-02-10 Thread Wu, Hao A
> -Original Message- > From: Wu, Hao A > Sent: Tuesday, February 11, 2020 10:55 AM > To: devel@edk2.groups.io; Wu, Hao A > Cc: Kubacki, Michael A; Kinney, Michael D; Dong, Eric; Ni, Ray; Laszlo Ersek > Subject: RE: [edk2-devel] [PATCH v1 0/2] Fix backward incompatible > CPU_MP_DATA struct

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 01/12] MdeModulePkg/PciBusDxe: Setup for PCI Express features

2020-02-10 Thread Javeed, Ashraf
> -Original Message- > From: Ni, Ray > Sent: Monday, February 10, 2020 2:08 PM > To: Javeed, Ashraf ; devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A > Subject: RE: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 01/12] > MdeModulePkg/PciBusDxe: Setup for PCI Express features >

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg: acpiview: Remove duplicate ACPI structure size definitions

2020-02-10 Thread Gao, Zhichao
Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: Krzysztof Koch > Sent: Thursday, January 30, 2020 7:43 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Gao, Zhichao ; > matteo.carl...@arm.com; sami.muja...@arm.com; n...@arm.com > Subject: [PATCH v1 1/1] ShellPkg:

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg: acpiview: Validate ACPI table 'Length' field

2020-02-10 Thread Gao, Zhichao
> -Original Message- > From: devel@edk2.groups.io On Behalf Of Krzysztof > Koch > Sent: Friday, January 31, 2020 12:20 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Gao, Zhichao ; > matteo.carl...@arm.com; sami.muja...@arm.com; n...@arm.com > Subject: [edk2-devel] [PATCH v1 1/1] ShellPkg:

Re: [edk2-devel] [PATCH v1 0/2] Fix backward incompatible CPU_MP_DATA struct change

2020-02-10 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Wu, Hao A > Sent: Thursday, February 06, 2020 2:21 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A; Kinney, Michael D; Dong, Eric; Ni, Ray; Laszlo Ersek > Subject: Re: [edk2-devel] [PATCH

Re: [edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Fix FADT Parser

2020-02-10 Thread Gao, Zhichao
The patch is already merged in the trunk. 66360134f8049cc70765cd3f119a5e2be2b67aa4 Thanks, Zhichao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ashish > Singhal > Sent: Tuesday, February 11, 2020 1:39 AM > To: Gao, Zhichao ; devel@edk2.groups.io; Ni, Ray > > Subject:

Re: [edk2-devel] [PATCH v1 2/2] UefiCpuPkg/MpInitLib: Not pass microcode info between archs in CPU_MP_DATA

2020-02-10 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Wu, Hao A > Sent: Thursday, February 6, 2020 1:24 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Kubacki, Michael A > ; Kinney, Michael D > ; Dong, Eric ; Ni, Ray > ; Laszlo Ersek > Subject: [PATCH v1 2/2] UefiCpuPkg/MpInitLib: Not pass

Re: [edk2-devel] [edk2-non-osi] [PATCH V3 0/1] Add Intel® Management Engine Firmware Binaries for 2nd Generation Intel® Xeon®

2020-02-10 Thread Vincent Zimmer
Reviewed by: vincent zimmer -Original Message- From: devel@edk2.groups.io On Behalf Of Desimone, Nathaniel L Sent: Monday, February 10, 2020 3:53 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Zimmer, Vincent Subject: [edk2-devel] [edk2-non-osi] [PATCH V3 0/1] Add Intel® Management

[edk2-devel] [edk2-non-osi] [PATCH V3 1/1] Intel/PurleySiliconBinPkg: Add Intel(R) PCH Ignition Firmware 1.0.2.43

2020-02-10 Thread Nate DeSimone
IGNITION_01.00.02.043.0 Cc: Isaac W Oram Cc: Vincent Zimmer Signed-off-by: Nate DeSimone --- .../MeFirmware/IgnitionFirmware/License.txt | 37 + .../MeFirmware/IgnitionFirmware/MeRegion.bin | Bin 0 -> 471040 bytes .../Other_Licenses/libgcc_License.txt | 73

[edk2-devel] [edk2-non-osi] [PATCH V3 0/1] Add Intel® Management Engine Firmware Binaries for 2nd Generation Intel® Xeon®

2020-02-10 Thread Nate DeSimone
This patch series adds Intel® PCH Ignition Firmware binaries for the 2nd Generation Intel® Xeon® Scalable Processors and chipsets formerly known as Cascade Lake to the edk2-non-osi repository. Intel® PCH Ignition Firmware is a variant of Intel® Management Engine (ME) Firmware that is intended to

答复: [edk2-devel] [PATCH v2 00/78] Fix a bunch of typos (part 1)

2020-02-10 Thread Yao, Jiewen
Change in SecurityPkg, StandaloneMmPkg, SignedCapsulePkg Reviewed-by: Jiewen Yao 发件人: devel@edk2.groups.io [devel@edk2.groups.io] 代表 Maciej Rabeda [maciej.rab...@linux.intel.com] 发送时间: 2020年2月10日 23:22 收件人: devel@edk2.groups.io; phi...@redhat.com 抄送:

Re: [edk2-devel] [PATCH v3 00/78] Fix a bunch of typos (part 1)

2020-02-10 Thread Laszlo Ersek
On 02/07/20 11:51, Laszlo Ersek wrote: > On 02/07/20 02:07, Philippe Mathieu-Daude wrote: >> Around February of this year, Antoine posted various patches fixing >> a huge quantity of typos, over 8000+ lines (such [1]). >> >> This series salvages a third of his work. >> I recommend to review the

[edk2-devel] [Patch 1/2] UnitTestFrameworkPkg: Disable EBC in DSC file

2020-02-10 Thread Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=2514 Remove EBC as one of the supported architectures in the UnitTestFrameworkPkg DSC file. The EBC compiler does not support cararg macros and the UnitTestLib class uses this feature. Cc: Sean Brogan Cc: Bret Barkelew Signed-off-by: Michael D

[edk2-devel] [Patch 0/2] Disable EBC for unit tests

2020-02-10 Thread Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=2514 Cc: Sean Brogan Cc: Bret Barkelew Signed-off-by: Michael D Kinney Michael D Kinney (2): UnitTestFrameworkPkg: Disable EBC in DSC file MdePkg: Disable EBC for unit tests in MdePkg.dsc MdePkg/MdePkg.dsc | 1 +

[edk2-devel] [Patch 2/2] MdePkg: Disable EBC for unit tests in MdePkg.dsc

2020-02-10 Thread Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=2514 Update the target unit tests in MdePkg.dsc to only build for IA32, X64, ARM, AARCH64. This disables EBC for these components. The UnitTestLib class uses vararg macros that the EBC compiler does not support. Cc: Sean Brogan Cc: Bret Barkelew

Re: [edk2-devel] A problem with live migration of UEFI virtual machines

2020-02-10 Thread Laszlo Ersek
(Replying through the groups.io web interface, just this one time) wuchenye1995 wrote: > Hi all, > > We found a problem with live migration of UEFI virtual machines due to > size of OVMF.fd changes. > > Specifically, the size of OVMF.fd in edk with low version such as > edk-2.0-25 is 2MB while

[edk2-devel] Shell feature?

2020-02-10 Thread Andrew Fish via Groups.Io
I wanted to start a conversation on the mailing list prior to writing up a BZ, to make sure I'm not missing anything, or in case there is a better way to implement this. I was thinking it would be good to have a Shell API that lets you associate a file type with an internal or external shell

Re: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB

2020-02-10 Thread Vitaly Cheptsov via Groups.Io
Liming, We did run several of our projects based on EDK II in X64 mode, DEBUG, RELEASE, NOOPT. Noticed no change from XCODE5. We also tried building several EDK builtin packages like CryptoPkg, MdePkg, MdeModulePkg. Best wishes, Vitaly В пн, февр. 10, 2020 в 16:47, Gao, Liming пишет: >

Re: [edk2-devel] [Patch] UnitTestFrameworkPkg/UnitTestLib: Fix XCODE parenthesis issues

2020-02-10 Thread Sean via Groups.Io
Reviewed by: Sean Brogan -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#54158): https://edk2.groups.io/g/devel/message/54158 Mute This Topic: https://groups.io/mt/71145488/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

[edk2-devel] [Patch] UnitTestFrameworkPkg/UnitTestLib: Fix XCODE parenthesis issues

2020-02-10 Thread Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=2512 Remove extra sets of parenthesis that generate warnings on XCODE5 builds. Cc: Sean Brogan Cc: Bret Barkelew Signed-off-by: Michael D Kinney --- UnitTestFrameworkPkg/Library/UnitTestLib/Assert.c | 6 +++---

Re: [edk2-devel] [PATCH v4 08/40] UefiCpuPkg/CpuExceptionHandler: Add base support for the #VC exception

2020-02-10 Thread Lendacky, Thomas
On 2/10/20 8:09 AM, Laszlo Ersek wrote: > On 02/07/20 16:07, Tom Lendacky wrote: >> On 2/6/20 2:03 AM, Laszlo Ersek wrote: >>> Hi Tom, >>> >>> On 02/05/20 00:01, Lendacky, Thomas wrote: BZ:

Re: [edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Fix FADT Parser

2020-02-10 Thread Ashish Singhal
Hello Ray, Any update on this one? Thanks Ashish -Original Message- From: Gao, Zhichao Sent: Thursday, January 30, 2020 10:33 PM To: Ashish Singhal ; devel@edk2.groups.io; Ni, Ray Subject: RE: [edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Fix FADT Parser External

[edk2-devel] PCD Migration issue

2020-02-10 Thread Andrew Fish via Groups.Io
We recently hit an issue when updating our UDK version in our common code base. Our recovery update path started failing for older platforms since the PEI was the old UDK version and the DXE from the Capsule was the new UDK version. Basically the version of the PCD changed. It looks like there

Re: [edk2-devel] [PATCH 08/19] Silicon/NXP: Remove unnecessary PCDs

2020-02-10 Thread Leif Lindholm
On Fri, Feb 07, 2020 at 18:13:17 +0530, Pankaj Bansal wrote: > There is no need to keep SOC specific PCDs defined for each SOC. That sound like the definition of why we have SoC-specific Pcds, so I don't follow. > we can do away with these PCDs. After looking through this patchset, it looks

Re: [edk2-devel] [PATCH 07/19] Silicon/NXP: remove not needed components

2020-02-10 Thread Leif Lindholm
On Fri, Feb 07, 2020 at 18:13:16 +0530, Pankaj Bansal wrote: > We are changing the directory structure of code. > After PEI phase impelmentation this info would be put back > into appropriate location. The message needs clarifying: What is being deleted, why is this not a problem, and what is

Re: [edk2-devel] [EXTERNAL] [PATCH 06/19] Silicon/NXP: remove print information from Soc lib

2020-02-10 Thread Leif Lindholm
On Fri, Feb 07, 2020 at 18:13:15 +0530, Pankaj Bansal wrote: > The Soc info being printed can be removed from SOC lib. > We are in the process of implementing PEI Phase. > After PEI phase impelmentation this info would be printed in > common PEIM based on the information retrieved from PPIs. >

Re: [edk2-devel] [staging/RISC-V-V2]: Need to bump opensbi submodule to get sbi_hfence.S etc.

2020-02-10 Thread Abner Chang
Thanks Rebecca. Yes, the readme.md is still used. I will check your patch. -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Rebecca Cran Sent: Tuesday, February 11, 2020 12:24 AM To: Schaefer, Daniel Helmut (DualStudy) Cc: Chang, Abner (HPS SW/FW

Re: [edk2-devel] [staging/RISC-V-V2]: Need to bump opensbi submodule to get sbi_hfence.S etc.

2020-02-10 Thread Rebecca Cran
On 2020-02-10 08:13, Schaefer, Daniel Helmut (DualStudy) wrote: > if you want to update to opensbi master, please apply this patch. > Since opensbi 0.6 hasn't been released yet, we haven't pushed the > fixes yet. > Atish said it will be out soon. Thanks! That worked, with a couple of changes. It

[edk2-devel] A problem with live migration of UEFI virtual machines

2020-02-10 Thread "wuchenye1995
Hi all,   We found a problem with live migration of UEFI virtual machines due to size of OVMF.fd changes.   Specifically, the size of OVMF.fd in edk with low version such as edk-2.0-25 is 2MB while the size of it in higher version such as edk-2.0-30 is 4MB.   When we migrate a UEFI virtual machine

Re: [edk2-devel] [staging/RISC-V-V2]: Need to bump opensbi submodule to get sbi_hfence.S etc.

2020-02-10 Thread Schaefer, Daniel Helmut (DualStudy)
Hi Rebecca, if you want to update to opensbi master, please apply this patch. Since opensbi 0.6 hasn't been released yet, we haven't pushed the fixes yet. Atish said it will be out soon. diff --git a/RiscVPkg/Include/OpensbiTypes.h b/RiscVPkg/Include/OpensbiTypes.h index 800f97759a..c77dbdec11

[edk2-devel] [staging/RISC-V-V2]: Need to bump opensbi submodule to get sbi_hfence.S etc.

2020-02-10 Thread Rebecca Cran
Hi, I recently got a HiFive Unleashed board, and am interested in trying out RISCV EDK2 firmware either on it or in Qemu. It looks like the opensbi submodule in edk2-staging/RiscVPkg/Library/RiscVOpensbiLib/opensbi needs updated though: the commit currently used -

Re: [edk2-devel] [staging/RISC-V-V2]: Need to bump opensbi submodule to get sbi_hfence.S etc.

2020-02-10 Thread Rebecca Cran
On 2020-02-09 12:07, Rebecca Cran wrote: > I recently got a HiFive Unleashed board, and am interested in trying out > RISCV EDK2 firmware either on it or in Qemu. > > It looks like the opensbi submodule in > edk2-staging/RiscVPkg/Library/RiscVOpensbiLib/opensbi needs updated > though: the commit

[edk2-devel] A problem with live migration of UEFI virtual machines

2020-02-10 Thread "wuchenye1995
Hi all,   We found a problem with live migration of UEFI virtual machines due to size of OVMF.fd changes.   Specifically, the size of OVMF.fd in edk with low version such as edk-2.0-25 is 2MB while the size of it in higher version such as edk-2.0-30 is 4MB.   When we migrate a UEFI virtual machine

Re: [edk2-devel] [Patch 1/2] UefiCpuPkg: Remove FIT based microcode shadow logic from MpInitLib.

2020-02-10 Thread Laszlo Ersek
On 02/10/20 11:58, Siyuan Fu wrote: > Commit c7c964b and dd01704 add header file for FIT table and update > MpInitLib to support FIT based microcode shadow operation. There are > comments that FIT is Intel specific specification instead of industry > standard, which should not be placed in EDK2

[edk2-devel] [edk2 wiki][patch] Move TOCTOU feature from Q1 stable tag to Q2 stable tag

2020-02-10 Thread Liming Gao
Its solution is changed. This feature is moving to Q2 Stable tag. Signed-off-by: Liming Gao --- EDK-II-Release-Planning.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/EDK-II-Release-Planning.md b/EDK-II-Release-Planning.md index a1866d2..32488de 100644 ---

Re: [edk2-devel] [PATCH v2 00/78] Fix a bunch of typos (part 1)

2020-02-10 Thread Maciej Rabeda
On all NetworkPkg patches v3: Reviewed-by: Maciej Rabeda Thanks! Maciej On 03-Jan-20 10:06, Philippe Mathieu-Daudé wrote: Around February of this year, Antoine posted various patches fixing a huge quantity of typos, over 8000+ lines (such [1]). This series salvages a third of his work. I

Re: [edk2-devel] [PATCH v2] Add support for Diagnostics ACM in FitGen tool

2020-02-10 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Agrawal, Sachin > Sent: Saturday, February 8, 2020 6:32 AM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > Subject: [PATCH v2] Add support for Diagnostics ACM in FitGen tool > > From: "Agrawal, Sachin" > > REF

Re: [edk2-devel] [PATCH v4 08/40] UefiCpuPkg/CpuExceptionHandler: Add base support for the #VC exception

2020-02-10 Thread Laszlo Ersek
On 02/07/20 16:07, Tom Lendacky wrote: > On 2/6/20 2:03 AM, Laszlo Ersek wrote: >> Hi Tom, >> >> On 02/05/20 00:01, Lendacky, Thomas wrote: >>> BZ: >>>

Re: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB

2020-02-10 Thread Liming Gao
Vitaly: This change is good. Can you your test for it? I verify this patch for Ovmf platform on Windows. It can make ovmf pass build with CLANGPDB. Thanks Liming > -Original Message- > From: devel@edk2.groups.io On Behalf Of Vitaly > Cheptsov via Groups.Io > Sent: Monday, February

Re: [edk2-devel] [PATCH v3 2/2] BaseTools: Remove caret in NASM_INC macro

2020-02-10 Thread PierreGondois
Hello Bob, [From Bob] This patch cause UefiCpuPkg build fail. build -p UefiCpuPkg\UefiCpuPkg.dsc -a IA32 -t VS2015x86 As said in the cover letter of the v4 available at the link below, I was not able to reproduce the build fail that you pointed out. In the v4, the only thing that I am

Re: [edk2-devel] [PATCH 4/4] MdeModulePkg/SdMmcPciHcDxe: Fix PIO transfer mode

2020-02-10 Thread Albecki, Mateusz
I will write a test code and update the results in next patch series. Regarding the buffer data port read. Reading the spec I am not entirely sure on the behavior of the host when the data transfer is not aligned to DWORD boundary. I will test it with width set to 32bit and if that works I will

Re: [edk2-devel] [PATCH 1/2] IntelFsp2Pkg/GenCfgOpt.py: Coverity scan flags issues.

2020-02-10 Thread Chiu, Chasel
Hi Philippe, > -Original Message- > From: devel@edk2.groups.io On Behalf Of Philippe > Mathieu-Daude > Sent: Monday, February 10, 2020 4:36 PM > To: devel@edk2.groups.io; Chiu, Chasel > Cc: Ma, Maurice ; Desimone, Nathaniel L > ; Zeng, Star > Subject: Re: [edk2-devel] [PATCH 1/2]

[edk2-devel] [PATCH 0/1] BaseTools: Switch to GNU mode for CLANGPDB

2020-02-10 Thread Vitaly Cheptsov via Groups.Io
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2397 I did not include __clang__ removal in this patch series, as it is also used in arm and aarch64 code, which makes me believe they could be using specialised toolchains. Request this to be merged in edk2-stable202002. Vitaly Cheptsov (1):

Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions

2020-02-10 Thread Vitaly Cheptsov via Groups.Io
Hello, It has been quite some time since we submitted the patch with so far no negative response. As I mentioned previously, my team will strongly benefit from its landing in EDK II mainline. Since it does not add any regressions and can be viewed as a feature implementation for the rest of

[edk2-devel] [Patch] IntelSiliconPkg: FIT based shadow microcode PPI support.

2020-02-10 Thread Siyuan, Fu
This patch adds a platform PEIM for FIT based shadow microcode PPI support. A detailed design doc can be found here: https://edk2.groups.io/g/devel/files/Designs/2020/0214/Support%20 the%202nd%20Microcode%20FV%20Flash%20Region.pdf TEST: Tested on FIT enabled platform. BZ:

[edk2-devel] [Patch 1/2] UefiCpuPkg: Remove FIT based microcode shadow logic from MpInitLib.

2020-02-10 Thread Siyuan, Fu
Commit c7c964b and dd01704 add header file for FIT table and update MpInitLib to support FIT based microcode shadow operation. There are comments that FIT is Intel specific specification instead of industry standard, which should not be placed in EDK2 MdePkg and UefiCpuPkg. So this patch adds a

[edk2-devel] [Patch 2/2] MdePkg: Remove FIT table industry standard header file.

2020-02-10 Thread Siyuan, Fu
Commit c7c964b and dd01704 add header file for FIT table and update MpInitLib to support FIT based microcode shadow operation. There are comments that FIT is Intel specific specification instead of industry standard, which should not be placed in EDK2 MdePkg and UefiCpuPkg. This patch removes the

[edk2-devel] [PATCH 0/1] BaseTools: Switch to GNU mode for CLANGPDB

2020-02-10 Thread Vitaly Cheptsov via Groups.Io
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2397 I did not include __clang__ removal in this patch series, as it is also used in arm and aarch64 code, which makes me believe they could be using specialised toolchains. Request this to be merged in edk2-stable202002. Vitaly Cheptsov (1):

[edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB

2020-02-10 Thread Vitaly Cheptsov via Groups.Io
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2397 Signed-off-by: Vitaly Cheptsov --- BaseTools/Conf/tools_def.template | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template index

[edk2-devel] [Patch 0/2] Move FIT based microcode shadow to platform PEIM.

2020-02-10 Thread Siyuan, Fu
Commit c7c964b and dd01704 add header file for FIT table and update MpInitLib to support FIT based microcode shadow operation. There are comments that FIT is Intel specific specification instead of industry standard, which should not be placed in EDK2 MdePkg and UefiCpuPkg. So this patch adds a

[edk2-devel] [PATCH v4 0/2] BaseTools: Rationalise makefile generation

2020-02-10 Thread PierreGondois
v4: Remove caret in NASM_INC macro: I could not reproduce the build fail Bob Feng had when issuing the following command: build -p UefiCpuPkg\UefiCpuPkg.dsc -a IA32 -t VS2015x86 Nonetheless, this v4 should only have an impact on the builds made on Windows platforms using nmake. The

[edk2-devel] [PATCH v4 1/2] BaseTools: Rationalise makefile generation

2020-02-10 Thread PierreGondois
From: Pierre Gondois The GenMake.py script tests the platform environment to determine the type of makefile that needs to be generated. If a Windows build host is detected, the makefile generated is of Nmake type. Otherwise a GNUmake type is generated. Furthermore, the ___MAKE_PATH option in

[edk2-devel] [PATCH v4 2/2] BaseTools: Remove caret in NASM_INC macro

2020-02-10 Thread PierreGondois
From: Pierre Gondois NASM_INC contains the list of directory to include when using the nasm assembler. In nmake makefiles, a trailing backslash escapes the newline char and replaces it with a space ' '. To have a literal trailing backslash, it must be escaped with a caret '^'. This is not

[edk2-devel] [PATCH 0/1] ShellPkg: Add support for input with separately reported modifiers

2020-02-10 Thread Vitaly Cheptsov via Groups.Io
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2510 Some firmwares: - Report Shift modifier even when they report upper-case unicode letter. - Report Ctrl modifier with "shifted" UniChar (i.e. X - 'A' + 1). This change provides support for these firmwares preserving the compatibility with

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 02/12] MdeModulePkg/PciBusDxe: Setup PCI Express init phase

2020-02-10 Thread Ni, Ray
My proposal defines four phases: Initialize, Scan, Program, Finalize. The four phases are very similar to your December's patch with just one phase opt out. As below: ---BEGIN Each feature needs to provide function pointers for each phase and NULL means the feature doesn't need to do

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 01/12] MdeModulePkg/PciBusDxe: Setup for PCI Express features

2020-02-10 Thread Ni, Ray
> -Original Message- > From: Javeed, Ashraf > Sent: Monday, February 10, 2020 4:26 PM > To: Ni, Ray ; devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A > Subject: RE: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 01/12] > MdeModulePkg/PciBusDxe: Setup for PCI > Express

Re: [edk2-devel] [PATCH 1/2] IntelFsp2Pkg/GenCfgOpt.py: Coverity scan flags issues.

2020-02-10 Thread Philippe Mathieu-Daudé
On 2/10/20 4:53 AM, Chiu, Chasel wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1706 Issue was: invalid_operation: Invalid operation on null-like value "Base". Fixed it by initializing Base to 0 before entering while loop. Test: Compared script output before and after this patch

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 00/12] PciBusDxe: New PCI Express features

2020-02-10 Thread Javeed, Ashraf
Ray, I have responded to your review comments. These patches has been changed accommodating your previous review comments. Please check. Thanks Ashraf > -Original Message- > From: Ni, Ray > Sent: Monday, February 10, 2020 1:10 PM > To: Javeed, Ashraf ; devel@edk2.groups.io > Cc: Wang,

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 02/12] MdeModulePkg/PciBusDxe: Setup PCI Express init phase

2020-02-10 Thread Javeed, Ashraf
Thanks Ashraf > -Original Message- > From: Ni, Ray > Sent: Monday, February 10, 2020 1:07 PM > To: Javeed, Ashraf ; devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A > Subject: RE: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 02/12] > MdeModulePkg/PciBusDxe: Setup PCI Express

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 01/12] MdeModulePkg/PciBusDxe: Setup for PCI Express features

2020-02-10 Thread Javeed, Ashraf
My comments below. Thanks Ashraf > -Original Message- > From: Ni, Ray > Sent: Monday, February 10, 2020 12:50 PM > To: Javeed, Ashraf ; devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A > Subject: RE: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 01/12] >