Liming, no problem from our side. The patch is now reviewed and I believe I
provided all the necessarily material regarding its status.
In case Ray would rather postpone it, I give no objection to this without prior
notice. There is no problem from our side if EDK II team wants to prioritise
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2272
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2289
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2290
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2287
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2288
Index should
Ray, Zhichao and Vitaly:
Thanks. BZ is the good place to catch all discussion. Because we are close to
edk2 stable tag 202002, can you make the agreement soon for BZ 2510?
Thanks
Liming
From: Ni, Ray
Sent: Thursday, February 20, 2020 11:13 AM
To: Gao, Liming ; vit9696
Cc: Kinney, Michael D ;
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2272
Index should be off-by one than size of array, so when check
mUsbTypeString, the max index should less than size of array.
Signed-off-by: GuoMinJ
---
.../Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c | 2 +-
1 file changed,
This patch is for BZ https://bugzilla.tianocore.org/show_bug.cgi?id=2031
So, please add this line into the commit message. This can be done when submit
this patch. Don't need to send the patch again.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2031
Thanks
Liming
> -Original
Since there is no change for the V2 patch. It is a good behavior to add the R-B
from V1 to V2. That would make the reviewer aware that there is no code change
and review requirement for this patch. I would keep the R-B in V1 and help to
merge the patch.
Thanks,
Zhichao
> -Original
Gaurav:
Got it.
Lefi and Ard:
Can you review this patch for stable tag 202002?
Thanks
Liming
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Gaurav Jain
> Sent: Thursday, February 20, 2020 1:19 PM
> To: Gao, Liming ; devel@edk2.groups.io
> Cc: Leif Lindholm ; Ard
> Gaurav:
> Does this patch catch to edk2 stable tag 202002?
Yes
Thanks
Gaurav
> -Original Message-
> From: Gao, Liming
> Sent: Wednesday, February 19, 2020 2:36 PM
> To: devel@edk2.groups.io; Gaurav Jain
> Cc: Leif Lindholm ; Ard Biesheuvel
> ; Pankaj Bansal
> Subject: [EXT] RE:
Liming,
I provided my comments in the BZ.
From: Gao, Liming
Sent: Thursday, February 20, 2020 9:17 AM
To: vit9696
Cc: Kinney, Michael D ; Laszlo Ersek
; Guptha, Soumya K ;
l...@nuviainc.com; af...@apple.com; devel@edk2.groups.io; Marvin Häuser
; Ni, Ray ; Gao, Zhichao
Subject: RE: Patch
Reviewed-by: Bret Barkelew
- Bret
From: devel@edk2.groups.io on behalf of GuoMinJ via
Groups.Io
Sent: Tuesday, February 18, 2020 6:34:49 PM
To: devel@edk2.groups.io
Cc: GuoMinJ
Subject: [EXTERNAL] [edk2-devel] [PATCH] UnitTestFrameworkPkg: Suspicious check
Reviewed-by: Bret Barkelew
- Bret
From: Laszlo Ersek
Sent: Tuesday, February 11, 2020 1:02:17 AM
To: devel@edk2.groups.io ; Kinney, Michael D
Cc: Sean Brogan ; Bret Barkelew
Subject: [EXTERNAL] Re: [edk2-devel] [Patch 1/2] UnitTestFrameworkPkg: Disable
EBC
Reviewed-by: Bret Barkelew
- Bret
From: Michael D Kinney
Sent: Monday, February 10, 2020 10:43:32 AM
To: devel@edk2.groups.io
Cc: Sean Brogan ; Bret Barkelew
Subject: [EXTERNAL] [Patch] UnitTestFrameworkPkg/UnitTestLib: Fix XCODE
parenthesis issues
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2535
The UINT_TEST_STATUS and FAILURE_TYPE have used 0 as status, so use 0 as
unknown is confused, remove it from array enumeration but keep it
location in the array.
Signed-off-by: GuoMinJ
---
Vitaly:
I add my comments.
Zhichao and Ray:
Can you give your opinion for BZ
https://bugzilla.tianocore.org/show_bug.cgi?id=2510? Is it a bug fix or feature
enhancement?
Thanks
Liming
From: vit9696
Sent: Thursday, February 20, 2020 2:09 AM
To: Gao, Liming
Cc: Kinney, Michael D ; Laszlo
> -Original Message-
> From: Albecki, Mateusz
> Sent: Thursday, February 20, 2020 12:05 AM
> To: devel@edk2.groups.io
> Cc: Albecki, Mateusz; Wu, Hao A; Marcin Wojtas; Gao, Zhichao; Gao, Liming
> Subject: [PATCHv2 0/4] MdeModulePkg/SdMmcPciHcDxe: Refactor
> command processing
>
> This
Reviewed-by: Siyuan Fu
> -Original Message-
> From: Armour, Nicholas
> Sent: 2020年2月20日 8:23
> To: devel@edk2.groups.io
> Cc: Armour, Nicholas ; Wu, Jiaxin
> ; Maciej Rabeda ; Fu,
> Siyuan
> Subject: [PATCH v4 1/1] NetworkPkg/ArpDxe: Recycle invalid ARP packets
> (CVE-2019-14559)
>
>
Sorry for my mistake. Then I have no other comments for this patch.
Reviewed-by: Zhichao Gao mailto:zhichao@intel.com>>
Thanks,
Zhichao
From: vit9696
Sent: Wednesday, February 19, 2020 8:15 PM
To: Gao, Zhichao ; devel@edk2.groups.io
Subject: RE: [edk2-devel] [PATCH 1/1] ShellPkg: Add
Update copyright
Cc: Jiaxin Wu
Cc: Maciej Rabeda
Cc: Siyuan Fu
Signed-off-by: Nicholas Armour
---
NetworkPkg/ArpDxe/ArpImpl.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/NetworkPkg/ArpDxe/ArpImpl.c b/NetworkPkg/ArpDxe/ArpImpl.c
index 9cdb33f2bd66..ed2d756d3e17
Please change the Copyright year to 2020, with that:
Reviewed-by: Siyuan Fu
> -Original Message-
> From: Armour, Nicholas
> Sent: 2020年2月20日 6:53
> To: devel@edk2.groups.io
> Cc: Armour, Nicholas ; Wu, Jiaxin
> ; Maciej Rabeda ; Fu,
> Siyuan
> Subject: [PATCH v3 1/1]
Fixing subject line
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2031
This patch triggers the RecycleEvent for invalid ARP packets.
Prior to this, we would just ignore invalid ARP packets,
and never free them.
Cc: Jiaxin Wu
Cc: Maciej Rabeda
Cc: Siyuan Fu
Signed-off-by: Nicholas
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2031
This patch triggers the RecycleEvent for invalid ARP packets.
Prior to this, we would just ignore invalid ARP packets,
and never free them.
Cc: Jiaxin Wu
Cc: Maciej Rabeda
Cc: Siyuan Fu
Signed-off-by: Nicholas Armour
---
This patch series aims to refactor command processing to achieve following
- Trace the failing TRB packets to see what commands are failing and for what
reasons
- Get the response data even if data transfer timed out to allow easier
debugging
- Fix the PIO mode which is currently completely
This patch refactors the way in which the driver will check
the data transfer completion. Data transfer related
functionalities have been moved to separate function.
Cc: Hao A Wu
Cc: Marcin Wojtas
Cc: Zhichao Gao
Cc: Liming Gao
Signed-off-by: Mateusz Albecki
---
Current driver does not support PIO transfer mode for
commands other then tuning. This change adds the code
to transfer PIO data.
Cc: Hao A Wu
Cc: Marcin Wojtas
Cc: Zhichao Gao
Cc: Liming Gao
Signed-off-by: Mateusz Albecki
---
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 3 +
To allow for easier debug of failing commands we
have added a capability to print TRB and command
packet when we start execution of the TRB(on
DEBUG_VERBOSE level) and when the TRB failed to
execute correctly(on DEBUG_ERROR level). Additionally
we will also print error interrupt status and
SdMmcPciHcDxe driver used to read response only after
command and data transfer completed. According to SDHCI
specification response data is ready after the command
complete status is set by the host controller. Getting
the response data early will help debugging the cases
when command completed
It's done (pushed at 0997352ddb4761c49dfedf6fef46b4cd15f6c9bf)
Regards,
Jian
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Laszlo Ersek
> Sent: Wednesday, February 19, 2020 4:57 PM
> To: Bi, Dandan ; Wu, Hao A ;
> Wang, Jian J
> Cc: devel@edk2.groups.io;
Mike and Laszlo:
Thanks for your comments.
Vitaly:
You request below two patches to catch 202002 stable tag. I agree with Mike
and Laszlo comments. They are not ready to catch this stable tag. The first one
is under discussion. The second one is like the enhancement or feature instead
of
>From the function description of GetIfrBinaryData(), FormSetGuid can be NULL.
>However, FormSetGuid is passed to IsZeroGuid(). This causes exception when
>FormSetGuid is NULL.
Signed-off-by: Nickle Wang
---
MdeModulePkg/Universal/SetupBrowserDxe/Setup.c | 3 ++-
1 file changed, 2
Reviewed-by: Liming Gao
> -Original Message-
> From: Feng, YunhuaX
> Sent: Friday, February 14, 2020 5:15 PM
> To: devel@edk2.groups.io
> Cc: Gao, Liming ; Feng, Bob C ;
> Zhang, Hongbin1
> Subject: [edk2-staging/FceFmmt][PATCH] BaseTools/FCE: Fix multiple FVs with
> SEC module issue
Reviewed-by: Liming Gao
> -Original Message-
> From: Feng, YunhuaX
> Sent: Wednesday, February 12, 2020 2:24 PM
> To: devel@edk2.groups.io
> Cc: Gao, Liming ; Feng, Bob C
> Subject: [PATCH] [edk2-staging/FceFmmt]BaseTools: Support no UI section FFS
>
> REF:
Reviewed-by: Liming Gao
> -Original Message-
> From: Feng, YunhuaX
> Sent: Wednesday, February 19, 2020 8:13 PM
> To: devel@edk2.groups.io
> Cc: Gao, Liming ; Feng, Bob C
> Subject: [PATCH] Tools/FitGen: Check the input file path before open it
>
> REF:
Zhichao,
Thanks for your review. The comment is correct, as ShiftOnlyState means the
state where only shift (and no other modifiers) can be pressed or not.
Best wishes,
Vitaly
On Wed, Feb 19, 2020 at 09:55, Gao, Zhichao wrote:
> Hi Vitaly,
>
> See the comment below:
>
>> -Original
Hi Sai,
I have updated the feedback comments and please help to review at [edk2-devel]
[edk2-platforms] [PATCH V2 2/2] Enable build for CometlakeOpenBoardPkg
For comment : > [Sai]: typo - it should be "following"
I saw the Readme.md , below statement is correct as below at line 45.
"A UEFI
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2117
avoid path traversal attack check.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yunhua Feng
---
Silicon/Intel/Tools/FitGen/FitGen.c | 47 +
1 file changed, 47 insertions(+)
diff --git
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2280
This change adds the configuration to enable build for CometlakeURvp.
Also it updates Cometlake U Rvp details to the Readme.md.
Signed-off-by: Kathappan Esakkithevar
Cc: Sai Chaganty
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Deepika Kethi
Hi Pankaj,
Please see two comments inline:
On 2020.02.19 14:00, Pankaj Bansal wrote:
From: Pankaj Bansal
BaseSerialPortLib16550 has been modified to use SerialUartClockLib.
Therefore, add the default implementation of SerialUartClockLib for
all the platforms using BaseSerialPortLib16550.
On 2/19/20 6:58 AM, Bi, Dandan wrote:
This patch seems be reviewed but not submitted. Hope it can be covered in Q1
stable tag.
I have reopened
https://bugzilla.tianocore.org/show_bug.cgi?id=1869
Thanks,
Dandan
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this
From: Pankaj Bansal
Some platform support dynamic clocking, which is controlled by some
jumper setting or hardware registers. Result of that is that PCD
PcdSerialClockRate would need to be updated for frequency change.
This patch implements support for dynamic frequency for Uart.
This patch
From: Pankaj Bansal
This patch adds dynamic freqency support for UART.
This patch is modelled on below patch
(cbba5ca104fb ArmPlatformPkg: PL011 Dynamic clock freq Support )
i have to ask, after introducing the generic library in MdeModulePkg
shouldn't the PL011 specific library
From: Pankaj Bansal
BaseSerialPortLib16550 has been modified to use SerialUartClockLib.
Therefore, add the default implementation of SerialUartClockLib for
all the platforms using BaseSerialPortLib16550.
Signed-off-by: Pankaj Bansal
---
Notes:
[Dependency]
[PATCH 1/1] MdeModulePkg:
Reviewed-by: Ray Ni
> -Original Message-
> From: Fu, Siyuan
> Sent: Wednesday, February 19, 2020 7:04 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Ni, Ray
> ; Chaganty, Rangasai V
>
> Subject: [PATCH v7] IntelSiliconPkg: FIT based shadow microcode PPI support.
>
> V7
V7 Change:
Add check for FIT type 0 count.
Move all FIT table check to function IsValidFitTable().
V6 Changes:
Add missing EFIAPI for ShadowMicrocode().
Check FIT table version and checksum before use.
Merge ShadowMicrocodePatchByFit() to ShadowMicrocode().
V5 Changes:
Add FIT address check to see
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2534
Extend validation of ACPI structure lengths which are read from the
ACPI table being parsed. Additionally check if the structure 'Length'
field value is positive. If not, stop parsing the faulting table.
Some ACPI tables define internal
Gaurav:
Does this patch catch to edk2 stable tag 202002?
Thanks
Liming
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Gaurav Jain
> Sent: Tuesday, February 18, 2020 8:24 PM
> To: devel@edk2.groups.io
> Cc: Leif Lindholm ; Ard Biesheuvel
> ; Pankaj Bansal ; Gaurav
>
Siyuan,
Your pasted code only counts the Type 1 entry not Type 0 entry.
Thanks,
Ray
> -Original Message-
> From: Fu, Siyuan
> Sent: Wednesday, February 19, 2020 1:20 PM
> To: Ni, Ray ; devel@edk2.groups.io
> Cc: Kinney, Michael D ; Chaganty, Rangasai V
>
> Subject: RE: [PATCH v5]
On 02/19/20 06:58, Dandan Bi wrote:
> This patch seems be reviewed but not submitted. Hope it can be covered in Q1
> stable tag.
Should have been merged months ago.
Jian, Hao, can you pick up this patch now please?
Thanks
Laszlo
> -Original Message-
> From: devel@edk2.groups.io On
On 02/18/20 21:42, Kinney, Michael D wrote:
> Hi Laszlo,
>
> I agree with your assessments.
>
> One comment below.
>
> Mike
>
>> -Original Message-
>> From: Laszlo Ersek
>> Sent: Tuesday, February 18, 2020 12:04 PM
>> To: Gao, Liming ; Guptha, Soumya K
>> ; Kinney, Michael D
>> ;
Hi Leif,
On Tue, Feb 18, 2020 at 8:34 PM Leif Lindholm wrote:
>
> On Fri, Feb 14, 2020 at 19:11:29 +0530, Vijayenthiran Subramaniam wrote:
> > Changes since v2:
> > - Rename i to Idx in Patch 2/5
> > - Retaining R-b in rest of the patches as there's no change
> >
> > Changes since v1:
> > - Fix
Fix "use of logical '&&' with constant operand" error when built with
CLANG38 toolchain.
Signed-off-by: Vijayenthiran Subramaniam
---
Changes since v1:
- Fix Copyright year
Notes:
Fix Clan error reported by Leif in
https://edk2.groups.io/g/devel/message/54586.
Build tested with
Reviewed-by: Chasel Chiu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Nate
> DeSimone
> Sent: Wednesday, February 19, 2020 3:59 PM
> To: devel@edk2.groups.io
> Cc: Agyeman, Prince ; Chaganty, Rangasai V
> ; Chiu, Chasel
> Subject: [edk2-devel] [edk2-non-osi] [PATCH
Fix "use of logical '&&' with constant operand" error when built with
CLANG38 toolchain.
Signed-off-by: Vijayenthiran Subramaniam
---
Notes:
Fix Clan error reported by Leif in
https://edk2.groups.io/g/devel/message/54586.
Build tested with clang 9:
Reviewed-by: Sai Chaganty
-Original Message-
From: Desimone, Nathaniel L
Sent: Tuesday, February 18, 2020 11:59 PM
To: devel@edk2.groups.io
Cc: Agyeman, Prince ; Chaganty, Rangasai V
; Chiu, Chasel
Subject: [edk2-non-osi] [PATCH 1/1] Maintainers.txt: Update Intel maintainers
Removes
Removes Michael Kubacki as an Intel maintainer.
Adds Chasel Chiu as the second maintainer for KabylakeOpenBoardBinPkg
Cc: Prince Agyeman
Cc: Sai Chaganty
Cc: Chasel Chiu
Signed-off-by: Nate DeSimone
---
Maintainers.txt | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git
54 matches
Mail list logo
