Re: [edk2-devel] [Patch v9 2/2] MdePkg/Test/BaseLib: Add SAFE_STRING_CONSTRAINT_CHECK unit test

Time to get this land, thx Mike!Reviewed-By: Vitaly Cheptsov On Wed, May 20, 2020 at 23:10, Michael D Kinney wrote: Use the safe string function StrCpyS() in BaseLib to test theSAFE_STRING_CONSTRAINT_CHECK() macro.Cc: Andrew Fish Cc: Ard

Re: [edk2-devel] [Patch v9 2/2] MdePkg/Test/BaseLib: Add SAFE_STRING_CONSTRAINT_CHECK unit test

Time to get this land, thx Mike!Reviewed-By: Vitaly Cheptsov On Wed, May 20, 2020 at 23:10, Michael D Kinney wrote: Use the safe string function StrCpyS() in BaseLib to test theSAFE_STRING_CONSTRAINT_CHECK() macro.Cc: Andrew Fish Cc: Ard Biesheuvel Cc: Bret

Re: [edk2-devel] [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg/UnitTestResultReportLib: Use AsciiStrnCpyS()

Reviewed-by: Bret Barkelew - Bret From: michael.kuba...@outlook.com Sent: Wednesday, May 20, 2020 6:28:40 PM To: devel@edk2.groups.io Cc: Bret Barkelew ; Sean Brogan ; liming.gao ; Kinney, Michael D Subject: [EXTERNAL] [PATCH v1 1/1]

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: Add FunctionParametePtr to FspGlobalData.

Change pushed: 3f89db869028fa65a37756fd7f391cbd69f4579c Thanks, Chasel > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chiu, > Chasel > Sent: Wednesday, May 20, 2020 11:34 AM > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Desimone, Nathaniel L > ; Zeng, Star >

[edk2-devel] [PATCH v1 1/1] UnitTestFrameworkPkg/UnitTestResultReportLib: Use AsciiStrnCpyS()

From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2721 The ReportOutput() function in UnitTestResultReportLib copies characters from a function input buffer to an intermediate local buffer in fixed size chunks of the maximum size of the intermediate buffer. The

[edk2-devel] [PATCH 0/3] OvmfPkg/Tcg2ConfigPei: fix ARM/AARCH64 build failure

Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=2728 Repo: https://pagure.io/lersek/edk2.git Branch: restrict_tpm12_to_x86_bz_2728 Another regression fix for edk2-stable202005. End of February 2020, Ard and Marc-André worked on two TPM-related features in parallel. Respectively: -

[edk2-devel] [PATCH 2/3] OvmfPkg/Tcg2ConfigPei: factor out InternalTpm12Detect()

Move the calls to the Tpm12RequestUseTpm() and Tpm12SubmitCommand() Tpm12DeviceLib functions to a separate C file, so that we can override these actions in a subsequent patch. This code movement requires moving the TPM_RSP_GET_TICKS / TestTpm12() helper structure / function too. While at it,

[edk2-devel] [PATCH 1/3] OvmfPkg/Tcg2ConfigPei: clean up some lib class dependencies

Commit 89236992913f introduced an explicit Tpm12CommandLib dependency to Tcg2ConfigPei. In reality this lib class is not consumed by Tcg2ConfigPei at all (such a dependency is not even inherited from other lib instances). Simplify the module by dropping the superfluous dependency. (The

[edk2-devel] [PATCH 3/3] OvmfPkg/Tcg2ConfigPei: skip TPM-1.2 detection when building for ARM/AARCH64

Dating back to commits f5cb3767038e and ddd34a818315d, the "ArmVirtPkg/ArmVirtQemu.dsc" platform includes the "OvmfPkg/Tcg/Tcg2Config/Tcg2ConfigPei.inf" module when the TPM2_ENABLE build flag is defined. This was regressed in commit 89236992913f, which added a Tpm12DeviceLib dependency to

Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

off-topic, but for the record: On 05/19/20 22:10, Bret Barkelew via groups.io wrote: > In my history with TianoCore, I have learned to not be so quick to > say “this is fucking stupidâ€. Every time I’ve done that, I’ve > later > discovered the reasons behind it, and even come to the

Re: [edk2-devel] [PATCH 1/1] CryptoPkg: Fix VS2017 build problem for ARM/AARCH64

On 5/20/2020 2:26 PM, Rebecca Cran wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2029 1. CryptPkcs7VerifyEku.c contains internal/x509_int.h header file, this file contains internal/refcount.h file, if _M_ARM or _M_ARM64 defined, it will contains (intrin.h). So we undef

[edk2-devel] [PATCH 1/1] CryptoPkg: Fix VS2017 build problem for ARM/AARCH64

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2029 1. CryptPkcs7VerifyEku.c contains internal/x509_int.h header file, this file contains internal/refcount.h file, if _M_ARM or _M_ARM64 defined, it will contains (intrin.h). So we undef these flags for MSVC. It will fix include

Re: [edk2-devel] [Patch v8 2/2] MdePkg/Test/BaseLib: Add SAFE_STRING_CONSTRAINT_CHECK unit test

Bug created. https://bugzilla.tianocore.org/show_bug.cgi?id=2729 thanks Sean On 5/20/2020 1:11 PM, Kinney, Michael D wrote: Hi Sean, I agree that tis unit test can be reorganized a bit to support unit tests for all APIs in BaseLib. Can you enter a BZ for this and we can work on cleaning

Re: [edk2-devel] [Patch v8 2/2] MdePkg/Test/BaseLib: Add SAFE_STRING_CONSTRAINT_CHECK unit test

Hi Vitaly, I agree with all the comments here. I have made these updates in V9. Mike From: vit9696 Sent: Tuesday, May 19, 2020 11:08 PM To: Kinney, Michael D Cc: devel@edk2.groups.io; Andrew Fish ; Ard Biesheuvel ; Bret Barkelew ; Brian J . Johnson ; Chiu, Chasel ; Justen, Jordan L ;

Re: [edk2-devel] [Patch v8 2/2] MdePkg/Test/BaseLib: Add SAFE_STRING_CONSTRAINT_CHECK unit test

Hi Sean, I agree that tis unit test can be reorganized a bit to support unit tests for all APIs in BaseLib. Can you enter a BZ for this and we can work on cleaning this up after the stable tag? Mike > -Original Message- > From: devel@edk2.groups.io On > Behalf Of Sean > Sent:

Re: [edk2-devel] [Patch v9 0/2] Disable safe string constraint assertions

PR for V9 with all checks passing: https://github.com/tianocore/edk2/pull/636 Mike > -Original Message- > From: devel@edk2.groups.io On > Behalf Of Michael D Kinney > Sent: Wednesday, May 20, 2020 1:10 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [Patch v9 0/2] Disable safe >

[edk2-devel] [Patch v9 2/2] MdePkg/Test/BaseLib: Add SAFE_STRING_CONSTRAINT_CHECK unit test

Use the safe string function StrCpyS() in BaseLib to test the SAFE_STRING_CONSTRAINT_CHECK() macro. Cc: Andrew Fish Cc: Ard Biesheuvel Cc: Bret Barkelew Cc: Brian J. Johnson Cc: Chasel Chiu Cc: Jordan Justen Cc: Laszlo Ersek Cc: Leif Lindholm Cc: Liming Gao Cc: Marvin H?user Cc: Michael

[edk2-devel] [Patch v9 1/2] MdePkg: Fix SafeString performing assertions on runtime checks

From: Vitaly Cheptsov REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 Runtime checks returned via status return code should not work as assertions to permit parsing not trusted data with SafeString interfaces. Replace ASSERT() with a DEBUG_VERBOSE message. Cc: Andrew Fish Cc: Ard

[edk2-devel] [Patch v9 0/2] Disable safe string constraint assertions

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 V9 Update unit test comment and use zero buffers to verify more behavior. V8 Add DEBUG_VERBOSE message and unit test. V7 addressed review comments (only documentation changes). Current implementation of SafeString does not let one parse

Re: [edk2-devel] [Patch v8 2/2] MdePkg/Test/BaseLib: Add SAFE_STRING_CONSTRAINT_CHECK unit test

Mike, I would have thought the SafeString tests would have gone in a different c file. Base64UnitTest.c seems by its title to be targeted at the base64 encode/decode test. Looking at this i do see that would require some restructuring as there is no BaseLibUnitTest.c file for the common

Re: [edk2-devel] Patch List for 202005 stable tag

On 05/20/20 16:43, Gao, Liming wrote: > Leif and Laszlo: > I add my comments for previous three. Besides, I have got several changes > for edk2 202005 stable tag. > > Bug List (pass review) > 2. https://edk2.groups.io/g/devel/message/59921 [PATCH] IntelFsp2Pkg: Add > FunctionParametePtr to

Re: [edk2-devel] Patch List for 202005 stable tag

On 05/20/20 14:13, Chiu, Chasel wrote: > > Hi Liming, > > I would like to include https://edk2.groups.io/g/devel/message/59921 to > 202005 stable tag. > We missed something in previous FSP enhancement commit > (https://edk2.groups.io/g/devel/message/59438) and this patch fixed the bug. I

Re: [edk2-devel] Patch List for 202005 stable tag

On 05/20/20 11:47, Rabeda, Maciej wrote: > Hi Liming, > > I would like to pull this in. > https://edk2.groups.io/g/devel/message/59947 Already upstream at this time; commit d3733188a216 ("NetworkPkg/DxeNetLib: Change the order of conditions in IF statement", 2020-05-20). That's good, it does

Re: [edk2-devel] [PATCH v2 3/3] ProcessorPkg/Library: Add RiscVEdk2SbiLib

On Fri, May 15, 2020 at 15:39:37 +0200, Daniel Schaefer wrote: > Library provides interfaces to invoke SBI extensions. > > Signed-off-by: Daniel Schaefer > > Cc: Abner Chang > Cc: Gilbert Chen > Cc: Michael D Kinney > Cc: Leif Lindholm > --- >

Re: [edk2-devel] [Patch v8 2/2] MdePkg/Test/BaseLib: Add SAFE_STRING_CONSTRAINT_CHECK unit test

On 05/20/20 05:11, Michael D Kinney wrote: > Use the safe string function StrCpyS() in BaseLib to test the > SAFE_STRING_CONSTRAINT_CHECK() macro. > > Cc: Andrew Fish > Cc: Ard Biesheuvel > Cc: Bret Barkelew > Cc: Brian J. Johnson > Cc: Chasel Chiu > Cc: Jordan Justen > Cc: Laszlo Ersek >

Re: [edk2-devel] [Patch v8 1/2] MdePkg: Fix SafeString performing assertions on runtime checks

On 05/20/20 05:11, Michael D Kinney wrote: > From: Vitaly Cheptsov > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 > > Runtime checks returned via status return code should not work as > assertions to permit parsing not trusted data with SafeString > interfaces. Replace ASSERT()

Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

When this is done in a PR with branch protections this works out differently and in my view your concerns are mitigated. 1. There isn't a partial squash operation. All reviewers know that the final output of the PR is going to 1 commit. Thus there is no confusion of what or how it is being

Re: [EXTERNAL] Re: [edk2-devel] [Patch v8 1/2] MdePkg: Fix SafeString performing assertions on runtime checks

Reviewed-by: Bret Barkelew - Bret From: Vitaly Cheptsov via groups.io Sent: Tuesday, May 19, 2020 10:56 PM To: Kinney, Michael D; Laszlo Ersek Cc:

Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

On 05/19/20 23:02, Desimone, Nathaniel L wrote: > Of course, there may be other patch series that would be logical to > squash, especially if the author has not been careful to maintain > bisectability. For example, I think of some patch series went a > little overboard and could have been done

[edk2-devel] [PATCH v8 46/46] Maintainers.txt: Add reviewers for the OvmfPkg SEV-related files

Register reviewers for the SEV-related files in OvmfPkg. Cc: Andrew Fish Cc: Laszlo Ersek Cc: Leif Lindholm Cc: Michael D Kinney Cc: Brijesh Singh Signed-off-by: Tom Lendacky --- Maintainers.txt | 10 ++ 1 file changed, 10 insertions(+) diff --git a/Maintainers.txt

[edk2-devel] [PATCH v8 40/46] UefiCpuPkg: Add a 16-bit protected mode code segment descriptor

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 A hypervisor is not allowed to update an SEV-ES guests register state, so when booting an SEV-ES guest AP, the hypervisor is not allowed to set the RIP to the guest requested value. Instead, an SEV-ES AP must be transition from 64-bit long

[edk2-devel] [PATCH v8 41/46] UefiCpuPkg/MpInitLib: Add CPU MP data flag to indicate if SEV-ES is enabled

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 When starting APs in an SMP configuration, the AP needs to know if it is running as an SEV-ES guest in order to assign a GHCB page. Add a field to the CPU_MP_DATA structure that will indicate if SEV-ES is enabled. This new field is set

[edk2-devel] [PATCH v8 45/46] UefiCpuPkg/MpInitLib: Prepare SEV-ES guest APs for OS use

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Before UEFI transfers control to the OS, it must park the AP. This is done using the AsmRelocateApLoop function to transition into 32-bit non-paging mode. For an SEV-ES guest, a few additional things must be done: - AsmRelocateApLoop must

[edk2-devel] [PATCH v8 43/46] OvmfPkg: Use the SEV-ES work area for the SEV-ES AP reset vector

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 A hypervisor is not allowed to update an SEV-ES guest's register state, so when booting an SEV-ES guest AP, the hypervisor is not allowed to set the RIP to the guest requested value. Instead an SEV-ES AP must be re-directed from within the

[edk2-devel] [PATCH v8 42/46] UefiCpuPkg: Allow AP booting under SEV-ES

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Typically, an AP is booted using the INIT-SIPI-SIPI sequence. This sequence is intercepted by the hypervisor, which sets the AP's registers to the values requested by the sequence. At that point, the hypervisor can start the AP, which will

[edk2-devel] [PATCH v8 44/46] OvmfPkg: Move the GHCB allocations into reserved memory

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 After having transitioned from UEFI to the OS, the OS will need to boot the APs. For an SEV-ES guest, the APs will have been parked by UEFI using GHCB pages allocated by UEFI. The hypervisor will write to the GHCB SW_EXITINFO2 field of the

Re: [edk2-devel] [PATCH v2 0/3] New RISC-V Patches - Why in edk2-platforms

On 5/20/20 6:07 PM, Daniel Schaefer wrote: please reply here, fixed Mike's email address, sorry... On 5/20/20 6:03 PM, Daniel Schaefer wrote: On 5/20/20 1:43 PM, Leif Lindholm wrote: On Fri, May 15, 2020 at 15:39:34 +0200, Daniel Schaefer wrote: Previously we had two packages just for

Re: [edk2-devel] [PATCH v2 0/3] New RISC-V Patches - Why in edk2-platforms

please reply here, fixed Mike's email address, sorry... On 5/20/20 6:03 PM, Daniel Schaefer wrote: On 5/20/20 1:43 PM, Leif Lindholm wrote: On Fri, May 15, 2020 at 15:39:34 +0200, Daniel Schaefer wrote: Previously we had two packages just for RISC-V on our edk2 branch:    RiscVPkg and

Re: [edk2-devel] [PATCH v2 0/3] New RISC-V Patches - Why in edk2-platforms

On 5/20/20 1:43 PM, Leif Lindholm wrote: On Fri, May 15, 2020 at 15:39:34 +0200, Daniel Schaefer wrote: Previously we had two packages just for RISC-V on our edk2 branch: RiscVPkg and RiscVPlatformPkg They are now under Platform/RISC-V/PlatformPkg and Silicon/RISC-V/ProcessorPkg in

Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

On 05/20/20 13:44, Ard Biesheuvel wrote: > Gary reports the GCC 10 will emit calls to atomics intrinsics routines > unless -mno-outline-atomics is specified. This means GCC-10 introduces > new intrinsics, and even though it would be possible to work around this > by specifying the command line

Re: [edk2-devel] [Patch v8 1/2] MdePkg: Fix SafeString performing assertions on runtime checks

Reviewed-by: Liming Gao > -Original Message- > From: Kinney, Michael D > Sent: Wednesday, May 20, 2020 11:01 AM > To: devel@edk2.groups.io > Cc: Andrew Fish ; Ard Biesheuvel > ; Bret Barkelew ; > Brian J . Johnson ; Chiu, Chasel > ; Justen, Jordan L ; > Laszlo Ersek ; Leif Lindholm ;

Re: [edk2-devel] [PATCH v2 2/3] ProcessorPkg/Library: Add RiscVOpensbiLib

On 5/20/20 2:00 PM, Leif Lindholm wrote: (Fixing Mike's email in reply) On Fri, May 15, 2020 at 15:39:36 +0200, Daniel Schaefer wrote: From: Abner Chang EDK2 RISC-V OpenSBI library which pull in external source files under RISC-V/ProcessorPkg/Library/RiscVOpensbiLib/opensbi to the build

Re: [edk2-devel] Patch List for 202005 stable tag

Leif and Laszlo: I add my comments for previous three. Besides, I have got several changes for edk2 202005 stable tag. Bug List (pass review) 2. https://edk2.groups.io/g/devel/message/59921 [PATCH] IntelFsp2Pkg: Add FunctionParametePtr to FspGlobalData [Chiu, Chasel] We missed something in

Re: [edk2-devel] [PATCH V7 5/6] MdeModulePkg: Add FMP Capsule Image Header extension

PR https://github.com/tianocore/edk2/pull/635 has been created for UEFI28a. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Oleksiy > Yakovlev > Sent: Wednesday, May 20, 2020 9:57 PM > To: Gao, Liming ; devel@edk2.groups.io > Cc: Kinney, Michael D ; Wang, Jian J > ; Wu,

Re: [edk2-devel] [PATCH V7 5/6] MdeModulePkg: Add FMP Capsule Image Header extension

Hi Lining, Wei. Can you speed up pushing of 2.8a patches? Regards, Oleksiy. -Original Message- From: Gao, Liming [mailto:liming@intel.com] Sent: Monday, May 18, 2020 8:40 PM To: devel@edk2.groups.io; Oleksiy Yakovlev Cc: Kinney, Michael D; Wang, Jian J; Wu, Hao A; Yao, Jiewen;

Re: [edk2-devel] [PATCH v2] NetworkPkg/DxeNetLib: Change the order of conditions in IF statement

Merged: https://github.com/tianocore/edk2/pull/634 https://github.com/tianocore/edk2/commit/d3733188a2162abf72dd08c0cedd1119b5cfe6c4 Thanks, Maciej On 20-May-20 13:41, Philippe Mathieu-Daudé wrote: On 5/20/20 5:08 AM, Zhang, Shenglei wrote: The condition,

Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

Hi Ard, On 5/20/20 1:44 PM, Ard Biesheuvel wrote: Gary reports the GCC 10 will emit calls to atomics intrinsics routines unless -mno-outline-atomics is specified. This means GCC-10 introduces new intrinsics, and even though it would be possible to work around this by specifying the command line

Re: [edk2-devel] Patch List for 202005 stable tag

Hi Liming, I would like to include https://edk2.groups.io/g/devel/message/59921 to 202005 stable tag. We missed something in previous FSP enhancement commit (https://edk2.groups.io/g/devel/message/59438) and this patch fixed the bug. Thanks, Chasel From: devel@edk2.groups.io On Behalf Of

Re: [edk2-devel] [PATCH v2 2/3] ProcessorPkg/Library: Add RiscVOpensbiLib

(Fixing Mike's email in reply) On Fri, May 15, 2020 at 15:39:36 +0200, Daniel Schaefer wrote: > From: Abner Chang > > EDK2 RISC-V OpenSBI library which pull in external source files under > RISC-V/ProcessorPkg/Library/RiscVOpensbiLib/opensbi to the build process. > > Signed-off-by: Abner Chang

Re: [edk2-devel] [PATCH v2 1/3] ProcessorPkg/RiscVOpensbLib: Add opensbi submodule

On Fri, May 15, 2020 at 15:39:35 +0200, Daniel Schaefer wrote: > Add submodule opensbi under > Silicon/RISC-V/ProcessorPkg/Library/RiscVOpensbLlib. > The current supported opensbi version for RISC-V edk2 port is tags/v0.6. > > Signed-off-by: Daniel Schaefer > Co-authored-by: Gilbert Chen >

[edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

Gary reports the GCC 10 will emit calls to atomics intrinsics routines unless -mno-outline-atomics is specified. This means GCC-10 introduces new intrinsics, and even though it would be possible to work around this by specifying the command line option, this would require a new GCC10 toolchain

Re: [edk2-devel] Patch List for 202005 stable tag

On 5/20/20 11:47 AM, Maciej Rabeda wrote: Hi Liming, I would like to pull this in. https://edk2.groups.io/g/devel/message/59947 This patch is indeed worth for the stable tag. Thanks, Maciej On 19-May-20 13:09, Liming Gao wrote: Hi Stewards and all:   I collect current

Re: [edk2-devel] [PATCH v2 0/3] New RISC-V Patches

On Fri, May 15, 2020 at 15:39:34 +0200, Daniel Schaefer wrote: > In this updated version I addressed Leif's comments and made the following > changes: > > - Refactor sbi_call* to SbiCall* (EDKII style) > - Use OpenSBI constants if possible > - Include Base.h in OpensbiTypes.h > - Only use

Re: [edk2-devel] [PATCH v2] NetworkPkg/DxeNetLib: Change the order of conditions in IF statement

On 5/20/20 5:08 AM, Zhang, Shenglei wrote: The condition, NET_HEADSPACE(&(Nbuf->BlockOp[Index])) < Len, is meaningless if Index = 0. So checking 'Index != 0' should be performed first in the if statement. Cc: Maciej Rabeda Cc: Siyuan Fu Cc: Jiaxin Wu Signed-off-by: Shenglei Zhang --- v2:

Re: [edk2-devel] [PATCH v2 2/2] ArmPlatformPkg: Fix comparison of constants warning

[Top-posting is difficult to read on technical lists; it's better to reply inline; maybe GitHub will fix this problem after all] On 5/20/20 1:25 PM, Sami Mujawar wrote: Hi Philippe, I had put a descriptive message to make people aware that the pragma effects the next line of code only. But I

Re: [edk2-devel] [RFC edk2-platforms v3 0/3] Improve D0x

On Tue, May 19, 2020 at 22:08:59 +0800, Ming Huang wrote: > Changes since v2: > 1 Drop the Contributed-under tags. > 2 revert the renaming. > > > Ming Huang (3): > Silicon/Hisilicon: Fix a typo issue in M41T83RealTimeClockLib > Hisilicon/Library: Move two functions to RtcHelperLib >

Re: [edk2-devel] [PATCH v2 2/2] ArmPlatformPkg: Fix comparison of constants warning

Hi Philippe, I had put a descriptive message to make people aware that the pragma effects the next line of code only. But I agree we can abbreviate it as per your suggestion. However, there is an ongoing discussion about an alternative (by which we could avoid the pragma) on another thread at

Re: [edk2-devel] [PATCH v2 2/2] ArmPlatformPkg: Fix comparison of constants warning

Hi Sami, On 5/18/20 2:46 PM, Sami Mujawar wrote: The VS2017 compiler reports 'warning C6326: potential comparison of a constant with another constant' when a fixed PCD value is compared with a constant value. The faulting code is as marked by '-->' below: --> if (FixedPcdGet32

Re: [edk2-devel] [PATCH] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

On 5/20/20 12:28 PM, Leif Lindholm via groups.io wrote: On Wed, May 20, 2020 at 12:05:03 +0200, Ard Biesheuvel wrote: Gary reports that GCC 10 will emit calls to atomics intrinsics routines unless -mno-outline-atomics is specified. This means GCC-10 introduces new intrinsics, and even though it

Re: [edk2-devel] [PATCH] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

On Wed, May 20, 2020 at 12:05:03 +0200, Ard Biesheuvel wrote: > Gary reports that GCC 10 will emit calls to atomics intrinsics routines > unless -mno-outline-atomics is specified. This means GCC-10 introduces > new intrinsics, and even though it would be possible to work around this > by

Re: [edk2-devel] [edk2-rfc] [RFCv2] code-first process for UEFI-forum specifications

Are there any additional comments on the code first process for UEFI specifications? When should we expect the process to *actually* start being used? Thanks, --Samer > -Original Message- > From: r...@edk2.groups.io On Behalf Of Samer El-Haj- > Mahmoud via groups.io > Sent: Thursday,

[edk2-devel] [PATCH] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

Gary reports that GCC 10 will emit calls to atomics intrinsics routines unless -mno-outline-atomics is specified. This means GCC-10 introduces new intrinsics, and even though it would be possible to work around this by specifying the command line option, this would require a new GCC10 toolchain

Re: [edk2-devel] Patch List for 202005 stable tag

Hi Liming, I would like to pull this in. https://edk2.groups.io/g/devel/message/59947 Thanks, Maciej On 19-May-20 13:09, Liming Gao wrote: Hi Stewards and all:   I collect current patch lists in devel mail list. Those patch contributors request to add them for 200205 stable tag. Because we

Re: [edk2-devel] [PATCH] ArmPkg/PlatformBootManagerLib: reject 'default' parity and stop bit count

Hi Leif, Please find my response marked inline as [SAMI] Regards, Sami Mujawar -Original Message- From: Leif Lindholm Sent: 19 May 2020 12:16 PM To: devel@edk2.groups.io; ler...@redhat.com Cc: Ard Biesheuvel ; graeme.greg...@linaro.org; tanmay.jagd...@linaro.org; Sami Mujawar

Re: [edk2-devel] [PATCH v2] NetworkPkg/DxeNetLib: Change the order of conditions in IF statement

Reviewed-by: Maciej Rabeda On 20-May-20 05:08, Shenglei Zhang wrote: The condition, NET_HEADSPACE(&(Nbuf->BlockOp[Index])) < Len, is meaningless if Index = 0. So checking 'Index != 0' should be performed first in the if statement. Cc: Maciej Rabeda Cc: Siyuan Fu Cc: Jiaxin Wu

[edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Do not reconnect driver with form-update

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2701 Recording to the spec, the reconnect is activated upon exiting of the formset or the browser. Exiting is by user but form-browser internal logic. That means the reconnection is only happened when user press ESC or _EXIT action to exit form.

Re: [edk2-devel] Official way to build BaseTools - Edk2ToolsBuild.py?

Hi Sean, On 5/20/20 5:36 AM, Sean wrote: I am not sure what the community wants to do with it.  It was created for the CI build so it is tailored to the needs of the CI build but I have no problem with updates. FWIW I find it useful to reproduce CI failure locally and debug them (usually

Re: [edk2-devel] [Patch v8 2/2] MdePkg/Test/BaseLib: Add SAFE_STRING_CONSTRAINT_CHECK unit test

On 5/20/20 8:07 AM, Vitaly Cheptsov via groups.io wrote: Mike, This looks generally good to me, but there are few issues. 1. There is a mistake in the description here: +  // Negative test case with DestMax smaller than Source size +  // +  Status = StrCpyS (Destination, sizeof (Destination)

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: Add FunctionParametePtr to FspGlobalData.

Thanks! > -Original Message- > From: Zeng, Star > Sent: Wednesday, May 20, 2020 12:34 PM > To: Chiu, Chasel ; Desimone, Nathaniel L > ; devel@edk2.groups.io > Cc: Ma, Maurice ; Zeng, Star > Subject: RE: [PATCH] IntelFsp2Pkg: Add FunctionParametePtr to > FspGlobalData. > > No need to

Re: [edk2-devel] [PATCH] MdePkg: add definitions for ACPI NVDIMM Device Path

Reviewed-by: Liming Gao -Original Message- From: Liu, Zhiguang Sent: 2020年5月20日 13:18 To: devel@edk2.groups.io Cc: Kinney, Michael D ; Gao, Liming ; Anandraj, James Sushanth Subject: [PATCH] MdePkg: add definitions for ACPI NVDIMM Device Path REF:

Re: [edk2-devel] [Patch v8 2/2] MdePkg/Test/BaseLib: Add SAFE_STRING_CONSTRAINT_CHECK unit test

Mike, This looks generally good to me, but there are few issues. 1. There is a mistake in the description here: + // Negative test case with DestMax smaller than Source size + // + Status = StrCpyS (Destination, sizeof (Destination) / sizeof (CHAR16), Destination); This should read

Re: [edk2-devel] [PATCH] MdePkg: add definitions for ACPI NVDIMM Device Path

Hi all, Please review this patch and I want this patch to catch 202005 stable tag? Thanks Zhiguang > -Original Message- > From: devel@edk2.groups.io On Behalf Of > Zhiguang Liu > Sent: Wednesday, May 20, 2020 1:18 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ;