[edk2-devel] [PATCH V2 2/4] OvmfPkg: Add Tdx metadata

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Tdx Metadata describes the information about the image for VMM use. For example, the base address and length of the TdHob, TdMailbox, etc. Its offset is put in a GUID-ed structure which is appended in the GUID-ed chain from a fixed GPA

[edk2-devel] [PATCH V2 4/4] OvmfPkg/ResetVector: Update ResetVector to support Tdx

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 In Tdx all CPUs "reset" to run on 32-bit protected mode with flat descriptor (paging disabled). But in Non-Td guest the initial state of CPUs is 16-bit real mode. To resolve this conflict, BITS 16/32 is used in the very beginning of

[edk2-devel] [PATCH V2 3/4] UefiCpuPkg/ResetVector: Add Main32 entry point in Main.asm

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 In Tdx all CPUs "reset" to run on 32-bit protected mode with flat descriptor (paging disabled). Main32 entry point is added in UefiCpuPkg/ResetVector/Vtf0/Main.asm so that Main.asm can support the 32-bit protected mode. Init32.asm is the

[edk2-devel] [PATCH V2 0/4] Add Intel TDX support in OvmfPkg/ResetVector

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Intel's Trust Domain Extensions (Intel TDX) refers to an Intel technology that extends Virtual Machines Extensions (VMX) and Multi-Key Total Memory Encryption (MKTME) with a new kind of virutal machines guest called a Trust Domain (TD). A

[edk2-devel] [PATCH V2 1/4] OvmfPkg: Add Tdx BFV/CFV PCDs and PcdOvmfImageSizeInKb

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Tdx Virtual Firmware (TDVF) includes one Firmware Volume (FV) known as the Boot Firmware Volume (BFV). The FV format is defined in the UEFI Platform Initialization (PI) spec. BFV includes all TDVF components required during boot. TDVF also

Re: [edk2-devel] [Patch V2 3/3] Maintainers.txt: Add GitHub IDs

Reviewed-by: Andrew Fish > On Jul 8, 2021, at 12:50 PM, Michael D Kinney > wrote: > > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Signed-off-by: Michael D Kinney > --- > Maintainers.txt | 282 > 1 file changed, 139

Re: [edk2-devel] [PATCH 0/6] UefiPayloadPkg: LinuxBoot Support in UefiPayload

Bug created: https://bugzilla.tianocore.org/show_bug.cgi?id=3505 On Thu, Jul 22, 2021 at 9:29 AM gaoliming wrote: > This is new feature. Can you submit one BZ ( > https://bugzilla.tianocore.org/ ) for it? > > Thanks > Liming > > -邮件原件- > > 发件人: devel@edk2.groups.io 代表 Cheng-Chieh > >

Re: [edk2-devel] [PATCH 0/6] UefiPayloadPkg: LinuxBoot Support in UefiPayload

On Thu, Jul 22, 2021 at 9:59 AM Daniel Schaefer wrote: > On 7/22/21 9:44 AM, Ni, Ray wrote: > > Cheng-Chieh, > > Thanks for the detailed explanation in doc > https://docs.google.com/document/d/1mU6ICHTh0ot8U45uuRENKOGI8cVzizdyWHGYHpEguVg/edit#heading=h.xzptrog8pyxf > . > > > > My original

Re: [edk2-devel] [edk2-platforms: PATCH] Features/Intel/IpmiFeaturePkg: Use MdePkg macros instead of redefining.

Patch pushed: d549e39ca1a9da14d86ff841358f990a0ace71f5 Thanks, Chasel > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chiu, > Chasel > Sent: Thursday, July 15, 2021 10:38 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Chaganty, Rangasai V

Re: [edk2-devel] [edk2-rfc] RFC: EXT4 filesystem driver

> On Jul 21, 2021, at 6:20 PM, gaoliming wrote: > > > >> -邮件原件- >> 发件人: r...@edk2.groups.io > > 代表 Pedro Falcato >> 发送时间: 2021年7月22日 7:12 >> 收件人: devel@edk2.groups.io >> 抄送: r...@edk2.groups.io

Re: [edk2-devel] [PATCH v1 5/6] UefiPayloadPkg: Add DISABLE_MMX_SSE to avoid generating floating points operation

I mean, I will submit a patch to support DISABLE_GCC_MMX_SSE in tools_def. What do you think? -- Cheng-Chieh On Thu, Jul 22, 2021 at 9:28 AM gaoliming wrote: > Tools_def.txt doesn’t support build flag DISABLE_GCC_MMX_SSE. If this > flag is moved into BaseTools\Conf\tools_def.template, -mno-mmx

Re: [edk2-devel] [PATCH 0/6] UefiPayloadPkg: LinuxBoot Support in UefiPayload

On 7/22/21 9:44 AM, Ni, Ray wrote: Cheng-Chieh, Thanks for the detailed explanation in doc https://docs.google.com/document/d/1mU6ICHTh0ot8U45uuRENKOGI8cVzizdyWHGYHpEguVg/edit#heading=h.xzptrog8pyxf . My original thought was LinuxBoot is a payload that aims to boot OS. But the idea of

Re: [edk2-devel] [PATCH 0/6] UefiPayloadPkg: LinuxBoot Support in UefiPayload

Cheng-Chieh, Thanks for the detailed explanation in doc https://docs.google.com/document/d/1mU6ICHTh0ot8U45uuRENKOGI8cVzizdyWHGYHpEguVg/edit#heading=h.xzptrog8pyxf. My original thought was LinuxBoot is a payload that aims to boot OS. But the idea of chaining UefiPayload producing UEFI services

回复: [edk2-devel] [PATCH 0/6] UefiPayloadPkg: LinuxBoot Support in UefiPayload

This is new feature. Can you submit one BZ (https://bugzilla.tianocore.org/ ) for it? Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Cheng-Chieh > Huang via groups.io > 发送时间: 2021年7月21日 21:23 > 收件人: devel@edk2.groups.io > 抄送: Cheng-Chieh Huang ; Daniel Schaefer > ; Trammell

回复: [edk2-devel] [PATCH v1 5/6] UefiPayloadPkg: Add DISABLE_MMX_SSE to avoid generating floating points operation

Tools_def.txt doesn’t support build flag DISABLE_GCC_MMX_SSE. If this flag is moved into BaseTools\Conf\tools_def.template, -mno-mmx -mno-sse option will be the default GCC options. That means all platforms will apply them. Thanks Liming 发件人: devel@edk2.groups.io 代表 Cheng-Chieh Huang via

[edk2-devel] 回复: [edk2-rfc] RFC: EXT4 filesystem driver

> -邮件原件- > 发件人: r...@edk2.groups.io 代表 Pedro Falcato > 发送时间: 2021年7月22日 7:12 > 收件人: devel@edk2.groups.io > 抄送: r...@edk2.groups.io > 主题: [edk2-rfc] RFC: EXT4 filesystem driver > > EXT4 (fourth extended filesystem) is a filesystem developed for Linux > that has been in wide use

Re: [edk2-devel] [PATCH v2] Xcode.md: Update instructions to work on modern macOS and Xcode versions

Reviewed-by: Andrew Fish > On Jul 21, 2021, at 4:56 PM, Rebecca Cran wrote: > > The existing instructions no longer work on macOS Big Sur and Xcode 12.5. > Update them to include for example using lldb instead of gdb, installing > XQuartz, and using modern names such as macOS instead of Mac OS

Re: [edk2-devel] [tianocore.github.io.wiki PATCH 1/1] Xcode.md: Update instructions to work on modern macOS and Xcode versions

Thanks. I've just sent out a v2 with the MacPorts instructions removed. -- Rebecca Cran On 7/21/21 8:30 AM, Andrew Fish wrote: On Jul 21, 2021, at 7:24 AM, Rebecca Cran > wrote: I think most people (including myself) use brew nowadays, which installs to

[edk2-devel] [PATCH v2] Xcode.md: Update instructions to work on modern macOS and Xcode versions

The existing instructions no longer work on macOS Big Sur and Xcode 12.5. Update them to include for example using lldb instead of gdb, installing XQuartz, and using modern names such as macOS instead of Mac OS X. Also, since MacPorts is less popular these days, remove instructions for installing

[edk2-devel] RFC: EXT4 filesystem driver

EXT4 (fourth extended filesystem) is a filesystem developed for Linux that has been in wide use (desktops, servers, smartphones) since 2008. The Ext4Pkg implements the Simple File System Protocol for a partition that is formatted with the EXT4 file system. This allows UEFI Drivers, UEFI

Re: [edk2-devel] [edk2-platform][PATCH v1 1/1] Platform/RaspberryPi/RPi4: Fix non-standard ACPI HIDs

Reviewed-by: Andrei Warkentin From: Ard Biesheuvel Sent: Tuesday, July 20, 2021 10:37 AM To: Samer El-Haj-Mahmoud Cc: edk2-devel-groups-io ; Leif Lindholm ; Ard Biesheuvel ; Pete Batard ; Andrei Warkentin ; Mario Bălănică Subject: Re: [edk2-platform][PATCH

Re: [edk2-devel] [PATCH 1/1] MdePkg: add definition of LINUX_EFI_INITRD_MEDIA_GUID

Hi Jeff, I see. I missed the file rename line in the git patch. I think the description needs to be expanded to clearly describe the production and consumption of this device path with this GUID. 1. What component creates the UEFI handle with the Device Path Protocol and the LoadFile2

Re: [edk2-devel] [PATCH v1 5/6] UefiPayloadPkg: Add DISABLE_MMX_SSE to avoid generating floating points operation

Yes, we can. I will drop this patch for this uefipayload batch and send another one for support DISABLE_GCC_MMX_SSE in tools_de.txt. -- Cheng-Chieh On Thu, Jul 22, 2021, 12:35 AM Kinney, Michael D wrote: > Are those flags needed for all packages that build with GCC? > > Should this be moved

Re: [edk2-devel] [PATCH 1/1] MdePkg: add definition of LINUX_EFI_INITRD_MEDIA_GUID

Does this look good for text to add "Linux distro boot generally relies on an initial ramdisk (initrd) which is provided by the loader, and which contains additional kernel modules (for storage and network, for instance), and the initial user space startup code, i.e., the code which brings up the

Re: [edk2-devel] [PATCH v1 6/6] UefiPayloadPkg: LinuxBoot: use a text format for the configuration block.

On 21.07.21 15:23, Cheng-Chieh Huang via groups.io wrote: From: Trammell Hudson This adds a text command line for the UefiPayloadPkg that uses a textual magic number 'LnxBoot1' and a series of white-space separated key=value[,value...] pairs for the parameters. The v1 binary configuration

Re: [edk2-devel] [PATCH v1 5/6] UefiPayloadPkg: Add DISABLE_MMX_SSE to avoid generating floating points operation

Are those flags needed for all packages that build with GCC? Should this be moved into tools_def.txt? Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Cheng-Chieh > Huang via groups.io > Sent: Wednesday, July 21, 2021 6:23 AM > To: devel@edk2.groups.io > Cc:

Re: [edk2-devel] [PATCH 1/1] MdePkg: add definition of LINUX_EFI_INITRD_MEDIA_GUID

Hi Ard, If this device path node is considered as part of the standard interface between the Linux kernel and firmware, then it does make sense for it to be in the MdePkg. We usually try to reference a public specification in the include file that defines the interface. In this case, since

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] KabylakeOpenBoardPkg/PeiSerialPortLibSpiFlash: Remove PPI from HOB

Tested, working on my Acer Aspire VN7-572G (Skylake-U/KabylakeOpenBoardPkg) board port. Debug logs continue to be written until the end of PEI rather than stopping at temporary memory teardown. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] KabylakeOpenBoardPkg/PeiSerialPortLibSpiFlash: Remove PPI from HOB

Reminder to review/merge this patch. On 7/9/2021 12:08 PM, Michael Kubacki wrote: From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3486 The PPI pointer should not be cached in a HOB as it could get out of sync with the current pointers in the PPI list. Cc: Chasel

Re: [edk2-devel] [tianocore.github.io.wiki PATCH 1/1] Xcode.md: Update instructions to work on modern macOS and Xcode versions

> On Jul 21, 2021, at 7:24 AM, Rebecca Cran wrote: > > I think most people (including myself) use brew nowadays, which installs to > /usr/local/bin so the instructions work. > > I was wondering if we should remove the MacPorts instructions? > > > Rebecca, Makes sense to move the

[edk2-devel] [PATCH v1 6/6] UefiPayloadPkg: LinuxBoot: use a text format for the configuration block.

From: Trammell Hudson This adds a text command line for the UefiPayloadPkg that uses a textual magic number 'LnxBoot1' and a series of white-space separated key=value[,value...] pairs for the parameters. The v1 binary configuration structure is used if it is present instead for backwards

[edk2-devel] [PATCH v1 4/6] UefiPayloadPkg: Reserve Payload config in runtime services data

Signed-off-by: Cheng-Chieh Huang --- UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c index ae16f25c7c0e..70afbf83ed4a 100644 ---

[edk2-devel] [PATCH v1 5/6] UefiPayloadPkg: Add DISABLE_MMX_SSE to avoid generating floating points operation

This will allow we compile payload using gcc8 Signed-off-by: Cheng-Chieh Huang --- UefiPayloadPkg/UefiPayloadPkg.dsc | 5 + 1 file changed, 5 insertions(+) diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc index 8aa5f18cd35c..fa41c5a24af5 100644 ---

[edk2-devel] [PATCH v1 2/6] UefiPayloadPkg: Use legacy timer in Linuxboot payload

HPET timer may fail to init after prior linux taking over. Signed-off-by: Cheng-Chieh Huang --- UefiPayloadPkg/UefiPayloadPkg.dsc | 6 ++ UefiPayloadPkg/UefiPayloadPkg.fdf | 5 + 2 files changed, 11 insertions(+) diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc

[edk2-devel] [PATCH v1 3/6] UefiPayloadPkg: Update maximum logic processor to 256

Signed-off-by: Cheng-Chieh Huang --- UefiPayloadPkg/UefiPayloadPkg.dsc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc index e56e6f4a5379..8aa5f18cd35c 100644 --- a/UefiPayloadPkg/UefiPayloadPkg.dsc +++

[edk2-devel] [PATCH 0/6] UefiPayloadPkg: LinuxBoot Support in UefiPayload

These are necessary patches to Support LinuxBoot in UefiPayload. With these paches, we can boot to ESXi and Windows from a linux in QEMU. LinuxBoot README: https://github.com/linuxboot/edk2/blob/uefipayload/UefiPayloadPkg/README.md PR to tianocore: https://github.com/tianocore/edk2/pull/1820

[edk2-devel] [PATCH v1 1/6] UefiPayloadPkg: Add LINUXBOOT payload target

Initial commit to support linuxboot payload. Signed-off-by: Cheng-Chieh Huang --- UefiPayloadPkg/UefiPayloadPkg.dsc | 16 +- UefiPayloadPkg/Library/LbParseLib/LbParseLib.inf | 39 + UefiPayloadPkg/Include/Linuxboot.h |

Re: [edk2-devel] [tianocore.github.io.wiki PATCH 1/1] Xcode.md: Update instructions to work on modern macOS and Xcode versions

I think most people (including myself) use brew nowadays, which installs to /usr/local/bin so the instructions work. I was wondering if we should remove the MacPorts instructions? -- Rebecca Cran On 7/20/21 11:37 PM, Andrew Fish wrote: These Xcode instructions look good to me in general.

Re: [edk2-devel] [PATCH v3] OvmfPkg: Remove unused print service driver (PrintDxe)

Reviewed-by: Jiewen Yao > -Original Message- > From: Philippe Mathieu-Daudé > Sent: Wednesday, July 21, 2021 4:21 PM > To: devel@edk2.groups.io; Yao, Jiewen > Cc: Laszlo Ersek ; Ard Biesheuvel > ; Justen, Jordan L ; > Brijesh Singh ; Erdem Aktas > ; James Bottomley ; Xu, Min > M ; Tom

Re: [edk2-devel] [PATCH v7 2/3] CryptoPkg/OpensslLib: Add native instruction support for X64

Reviewed-by: Jiewen Yao > -Original Message- > From: christopher.zurc...@outlook.com > Sent: Wednesday, July 21, 2021 6:07 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J ; > Lu, XiaoyuX ; Kinney, Michael D > ; Ard Biesheuvel > Subject: [PATCH v7 2/3]

Re: [edk2-devel] [PATCH v7 1/3] BaseTools: Remove COMMON section from the GCC discard list

Acked-by: Jiewen Yao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Christopher > Zurcher > Sent: Wednesday, July 21, 2021 6:07 AM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Feng, Bob C ; > Liming Gao > Subject: [edk2-devel] [PATCH v7 1/3] BaseTools: Remove

Re: [edk2-devel] [PATCH] UefiCpuPkg VTF0 X64: Build page tables using 1-GByte Page Granularity

OVMF's ResetVector is including the UefiCpuPkg's ResetVector. So, OVMF owners please do evaluate the impact. I think this change assumes platform owner knows which format of page table should be chosen in build time. -Original Message- From: Dov Murik Sent: Tuesday, July 20, 2021

Re: [edk2-devel] [PATCH v3 10/11] OvmfPkg: add BlobVerifierLibSevHashes

Tom, Brijesh, Ard, I think I found a bug in this patch. I used libfuzzer to test the VerifyBlob implementation here, and it immediately found a few "read memory out of range" issues. See details below in VerifyBlob. If the Guest Owner properly validates the measurement (which includes the

回复: [edk2-devel] [PATCH v2 0/4] Allow EccCheck to run on other repositories

Pierre: I have merged this patch set at 40a9066439cbab235933525810f46f03806c6ef1..fb5b6220a9718fc28ae67f317d3611214a05589c Thanks Liming 发件人: devel@edk2.groups.io 代表 PierreGondois 发送时间: 2021年7月21日 16:20 收件人: PierreGondois ; devel@edk2.groups.io 主题: Re: [edk2-devel] [PATCH v2 0/4] Allow

Re: [edk2-devel] [PATCH v2 1/1] ArmVirtPkg: Remove meaningless comment

Hi Philippe, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 21/07/2021, 09:19, "Philippe Mathieu-Daudé" wrote: From: Philippe Mathieu-Daude The "Shell Embedded Boot Loader" description (added in commit 6f5872b1f401) does not add any value,

Re: [edk2-devel] [PATCH v3] OvmfPkg: Remove unused print service driver (PrintDxe)

Ping? On 7/7/21 8:02 PM, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daude > > PrintDxe produces gEfiPrint2ProtocolGuid and gEfiPrint2SProtocolGuid, > and those are consumed by the following PrintLib instance: > >

Re: [edk2-devel] [PATCH v2 0/4] Allow EccCheck to run on other repositories

Hi Sean and Bret, Do you have any comments on the patchset ? Regards, Pierre -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#78013): https://edk2.groups.io/g/devel/message/78013 Mute This Topic: https://groups.io/mt/84030563/21656 Group

[edk2-devel] [PATCH v2 1/1] ArmVirtPkg: Remove meaningless comment

From: Philippe Mathieu-Daude The "Shell Embedded Boot Loader" description (added in commit 6f5872b1f401) does not add any value, remove it. Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Cc: Julien Grall Suggested-by: Laszlo Ersek Signed-off-by: Philippe

Re: [edk2-devel] [PATCH 1/1] MdePkg: add definition of LINUX_EFI_INITRD_MEDIA_GUID

On 7/16/21 11:56 PM, Ard Biesheuvel wrote: On Fri, 16 Jul 2021 at 17:00, Kinney, Michael D wrote: Hi Ard, I see you were involved in the OS side changes. Can you explain what is required for the FW <-> OS interface with respect to Load File Protocol and this media device path node. What

Re: [edk2-devel] [PATCH v3 00/11] Measured SEV boot with kernel/initrd/cmdline

On 20/07/2021 20:27, Ard Biesheuvel wrote: > On Tue, 20 Jul 2021 at 19:22, Tom Lendacky wrote: >> >> On 7/20/21 3:03 AM, Dov Murik wrote: >>> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3457 >> >> I believe the convention is that this line be in the individual patch >> commit messages

Re: [edk2-devel] [PATCH v2 1/1] MdeModulePkg: Add BootDiscoveryPolicyUiLib.

Hi Greg, I just had an offline discussion with Zhichao. Zhichao made a good point. It looks like this feature requires platform code to add PCD override in DynamicHii type in its platform .dsc file. Otherwise, the PcdSet32S() call won't initiate the "BootDiscoveryPolicy" variable. Therefore,

Re: [edk2-devel] [RFC PATCH] OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization

On Tue, Jul 20, 2021 at 02:52:12PM +0800, Gary Lin via groups.io wrote: > On Mon, Jul 19, 2021 at 05:07:21PM +0100, Anthony PERARD wrote: > > It would have been nice to have this patch in a patch series with > > "OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe", mostly to make it simpler > > to