Re: [edk2-devel] [PATCH v2 2/2] UefiCpuPkg/BaseUefiCpuLib: Use toolchain-specific rodata section name

> On Aug 9, 2021, at 7:43 PM, Ni, Ray wrote: > > Acked-by: Ray Ni mailto:ray...@intel.com>> > > I will depend on tool owner to review the tool configuration change making > sure that the correct section name is chosen for different C compilers. > Ray, I made a detailed response about

[edk2-devel] [edk2-platforms] [PATCH V1] MinPlatformPkg: Cleanup PeiFspWrapperHobProcessLib dependencies

PeiFspWrapperHobProcessLib is currently set to depens on FspWrapperPlatformLib, but it does not use any of the functions implemented by that LibraryClass. This change removes that unneeded dependency. Cc: Chasel Chiu Cc: Michael Kubacki Cc: Benjamin Doron Signed-off-by: Nate DeSimone ---

[edk2-devel] [edk2-platforms] [PATCH V1] KabylakeSiliconPkg: Update SA_MISC_PEI_PREMEM_CONFIG

Updates SA_MISC_PEI_PREMEM_CONFIG from revision 1 to revision 3. Add initialization of the policy values. Cc: Chasel Chiu Cc: Michael Kubacki Cc: Benjamin Doron Signed-off-by: Nate DeSimone --- .../KabylakeRvp3/OpenBoardPkg.dsc | 24 +++--- .../PeiSiliconPolicyUpdateLib.c

Re: [edk2-devel] [PATCH v2 1/2] BaseTools: Define the read-only data section name per toolchain

> On Aug 9, 2021, at 2:51 AM, Marvin Häuser wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3318 > > Different toolchains of the EDK II build system may generate ELF or > Mach-O files, which use the ".rodata" naming convention, or PE/COFF > files, which use the ".rdata" naming

Re: [edk2-devel] [PATCH EDK2 v2 1/1] MdeModulePkg/UefiSortLib:Add UefiSortLib unit test

Sorry Mike, Do you have advice on how to deal with ECC reporting function naming issue on the 'main' function for unit test cases? So far, I think Wenyi has tried following the same pattern in file

[edk2-devel] [PATCH v2 5/6] Silicon/Broadcom/Bcm27xx: Move linkup check into the cfg accessor

The existing code fails to create/finish configuring the pcie subsystem if it fails to get a linkup. This is reasonable on the RPi4 because it generally won't happen, and the OS could not see the root port. Now that the OS can see the root port, its a bit odd if it only shows up when something is

[edk2-devel] [PATCH v2 6/6] Platform/RaspberryPi: Enable NVMe boot on CM4

The CM4 has a number of carrier boards with PCIe slots. With the PCIe changes in place its quite possible to utilize a NVMe root device. Lets allow people to boot from it. Reviewed-by: Andrei Warkentin Signed-off-by: Jeremy Linton --- Platform/RaspberryPi/RPi4/RPi4.dsc | 5 +

[edk2-devel] [PATCH v2 3/6] Platform/RaspberryPi: Add PCIe SSDT

Since we plan on toggling between XHCI and PCI the PCI root needs to be in its own SSDT. This is all thats needed of UEFI. The SMC conduit is provided directly to the running OS. When the OS detects this PCIe port on a machine without a MCFG it attempts to connect to the SMC conduit. The RPi

[edk2-devel] [PATCH v2 4/6] Silicon/Broadcom/Bcm27xx: Relax PCIe device restriction

The CM4 has an actual PCIe slot, so the device filtering need to be a little less restrictive WRT busses with more than 1 device given that switches can now appear in the topology. Since it is possible to start numbering the busses with a non-zero value, the bus restriction should be based on the

[edk2-devel] [PATCH v2 2/6] Platform/RaspberryPi: Break XHCI into its own SSDT

Lets prepare to switch between XHCI and PCI by moving the XHCI definition into its own SSDT. That way we can select it based on the menu settings. The resource producer/consumer flag is also corrected. Reviewed-by: Andrei Warkentin Signed-off-by: Jeremy Linton ---

[edk2-devel] [PATCH v2 1/6] Platform/RaspberryPi: Add XHCI/PCI selection menu

Arm has standardized a PCI SMC conduit that can be used to access the PCI config space in a standardized way. This functionality doesn't yet exist in many OS/Distro's. Lets add another advanced config item that allows the user to toggle between presenting the XHCI on the base RPi4 as a platform

[edk2-devel] [PATCH v2 0/6] RPi4: Enable ACPI PCIe conduit

A new Arm standard DEN0115A specifies how platforms that don't have standard ECAM can use the firmware to handle config read/write operations. This is mostly implemented in TFA but UEFI needs to assure that there is a description of the root complex in the ACPI namespace. This set adds that

[edk2-devel] Cancelled Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, August 10, 2021 #cal-cancelled

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCELLED CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles X-LIC-LOCATION:America/Los_Angeles BEGIN:DAYLIGHT

回复: [edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 08/10/2021 #cal-reminder

Hi, all Few issues are submitted this week. Let’s cancel this week meeting. 3542 EDK2 Code unassig...@tianocore.org UNCO [MdePkg/BaseLib] Unaligned APIs cannot be called safely

Re: [edk2-devel] [PATCH v2 1/1] MdeModulePkg/PiSmmCore: Drop deprecated image profiling commands

Thank you very much!! Reviewed-by: Ray Ni I will merge your patches after stable tag release. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Marvin Häuser > Sent: Monday, August 9, 2021 2:09 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Dong, Eric ;

Re: [edk2-devel] [PATCH v2 2/2] UefiCpuPkg/BaseUefiCpuLib: Use toolchain-specific rodata section name

Acked-by: Ray Ni I will depend on tool owner to review the tool configuration change making sure that the correct section name is chosen for different C compilers. Thanks, Ray > -Original Message- > From: Marvin Häuser > Sent: Monday, August 9, 2021 5:51 PM > To: devel@edk2.groups.io

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg: Add BaseSmmAccessLibNull

Michael, If your platform doesn't need SmmAccessPPI, you don't put the SmmAccess PEIM in the FDF. Why do you need: 1. Put SmmAccess PEIM in FDF 2. Let SmmAccess PEIM link to a NULL dummy-do-nothing library I feel the additional abstraction is not necessary. Thanks, Ray > -Original

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/PeiSmmAccessLib: Remove S3 requirement

Michael, Allowing the gPeiSmmAccessPpiGuid PPI installation in normal boot will further allow gEfiPeiSmmCommunicationPpiGuid installation in normal path, while without your change neither of the PPIs is installed in normal boot. + Jiewen for potential security concern. Thanks, Ray >

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 08/10/2021 #cal-reminder

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles X-LIC-LOCATION:America/Los_Angeles BEGIN:DAYLIGHT

Re: [edk2-devel] [Patch V2] MinPlatformPkg: Fix the incompatible change about SecureBootVariableLib

Reviewed-by: Chasel Chiu > -Original Message- > From: Tan, Dun > Sent: Monday, August 9, 2021 11:00 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Liming Gao ; > Dong, Eric ; Tan, Dun > Subject: [Patch V2] MinPlatformPkg: Fix the incompatible change

Re: [edk2-devel] [PATCH 1/1] OvmfPkg PlatformBootManagerLib: Move TryRunningQemuKernel()

On 10/8/21 12:52 am, James Bottomley wrote: > On Mon, 2021-08-09 at 22:53 +1000, Christoph Willing wrote: >> With soft feature freeze started, I wonder if this patch could be >> reviewed and pushed for edk2-stable202108 tag? I think it has >> languished because I didn't initially Cc appropriately

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/PeiSmmAccessLib: Remove S3 requirement

Reviewed-by: Sai Chaganty -Original Message- From: mikub...@linux.microsoft.com Sent: Monday, August 09, 2021 6:40 AM To: devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V Subject: [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/PeiSmmAccessLib: Remove S3 requirement From:

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg: Add BaseSmmAccessLibNull

Reviewed-by: Sai Chaganty -Original Message- From: mikub...@linux.microsoft.com Sent: Monday, August 09, 2021 7:16 AM To: devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V Subject: [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg: Add BaseSmmAccessLibNull From: Michael

Re: [edk2-devel] [PATCH v2 1/2] MdePkg/BaseLib: Fix unaligned API prototypes

> On Aug 9, 2021, at 9:15 AM, Michael D Kinney > wrote: > > Hi Marvin, > > Can you provide an example of which C compiler is flagging this as > an error and what error message is generated. > > Please enter a BZ with this background information and add link to the > BZ in the commit

Re: [edk2-devel] [PATCH v2 4/7] ArmPkg/DefaultExceptionHandlerLib: Check DebugImageInfoTable type safely

On 09/08/2021 14:40, Marvin Häuser wrote: On 09/08/2021 13:55, Ard Biesheuvel wrote: On Mon, 9 Aug 2021 at 11:51, Marvin Häuser wrote: C does not allow casting to or dereferencing incompatible pointer types. Use the ImageInfoType member of the union first to determine the data type before

[edk2-devel] [PATCH v3 1/2] MdePkg/BaseLib: Fix unaligned API prototypes

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3542 C prohibits not only dereferencing but also casting to unaligned pointers. Thus, the current set of unaligned APIs cannot be called safely. Update their prototypes to take VOID * pointers, which must be able to represent any valid pointer.

[edk2-devel] [PATCH v3 2/2] BaseTools/CommonLib: Fix unaligned API prototypes

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3542 C prohibits not only dereferencing but also casting to unaligned pointers. Thus, the current set of unaligned APIs cannot be called safely. Update their prototypes to take VOID * pointers, which must be able to represent any valid pointer.

Re: [edk2-devel] [Patch V2] MinPlatformPkg: Fix the incompatible change about SecureBootVariableLib

Reviewed-by: Nate DeSimone > -Original Message- > From: Tan, Dun > Sent: Monday, August 9, 2021 8:00 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Liming Gao > ; Dong, Eric ; Tan, Dun > > Subject: [Patch V2] MinPlatformPkg: Fix the incompatible change

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg/AcpiTables: Update structures for ACPI 6.3

Reviewed-by: Nate DeSimone > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Friday, August 6, 2021 12:54 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Liming Gao > ; Dong, Eric ; Maddy, > Daniel ; Michael Kubacki > > Subject:

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] MinPlatformPkg: TestPointCheckLib bug fixes and improvements

The series has been pushed as 5b257da~..89fb75a Thanks, Nate > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Thursday, August 5, 2021 6:33 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Liming Gao > ; Dong, Eric > Subject:

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] MinPlatformPkg: TestPointCheckLib bug fixes and improvements

For the series... Reviewed-by: Nate DeSimone > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Thursday, August 5, 2021 6:33 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Liming Gao > ; Dong, Eric > Subject: [edk2-platforms][PATCH v2 0/5]

[edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg/TestPointCheckLib: Add support for BME device exemption

From: Chris Ruffin REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3541 Some platforms have devices which do not expose any additional risk of DMA attacks but the BME bit cannot be disabled. To allow MinPlatformPkg consumers to selectively exempt certain devices from the PCI bus master test

Re: [edk2-devel] [PATCH v2 0/4] Ovmf: Disable the TPM2 platform hierarchy

On 8/9/21 1:54 PM, James Bottomley wrote: On Mon, 2021-08-09 at 12:37 -0400, Stefan Berger wrote: This series imports code from the edk2-platforms project related to changing the password of the TPM2 platform hierarchy and uses it to disable the TPM2 platform hierarchy in Ovmf. It addresses

Re: [edk2-devel] [PATCH v2 0/4] Ovmf: Disable the TPM2 platform hierarchy

On Mon, 2021-08-09 at 12:37 -0400, Stefan Berger wrote: > This series imports code from the edk2-platforms project related to > changing the password of the TPM2 platform hierarchy and uses it to > disable the TPM2 platform hierarchy in Ovmf. It addresses the Ovmf > aspects of the following bugs:

Re: [edk2-devel] [PATCH 2/3] OvmfPkg/ResetVector: update SEV support to use new work area format

On 8/9/21 11:54 AM, Tom Lendacky wrote: On 8/4/21 3:20 PM, Brijesh Singh wrote: BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Update the SEV support to switch to using the newer work area format. Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc: Jordan Justen

Re: [edk2-devel] [PATCH 1/3] OvmfPkg: introduce a common work area

On 8/9/21 11:40 AM, Tom Lendacky wrote: On 8/4/21 3:20 PM, Brijesh Singh wrote: BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Both the TDX and SEV support needs to reserve a page in MEMFD as a work area. The page will contain meta data specific to the guest type. Currently, the

Re: [edk2-devel] [PATCH 3/3] OvmfPkg/ResetVector: move the GHCB page setup in AmdSev.asm

On 8/4/21 3:20 PM, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > While build the initial page table, the SetCr3ForPageTables64 checks > whether SEV-ES is enabled. If so, clear the page encryption mask from the > GHCB page. Move the logic to clear the page

Re: [edk2-devel] [PATCH 2/3] OvmfPkg/ResetVector: update SEV support to use new work area format

On 8/4/21 3:20 PM, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > Update the SEV support to switch to using the newer work area format. > > Cc: James Bottomley > Cc: Min Xu > Cc: Jiewen Yao > Cc: Tom Lendacky > Cc: Jordan Justen > Cc: Ard Biesheuvel >

[edk2-devel] [PATCH v2 0/4] Ovmf: Disable the TPM2 platform hierarchy

This series imports code from the edk2-platforms project related to changing the password of the TPM2 platform hierarchy and uses it to disable the TPM2 platform hierarchy in Ovmf. It addresses the Ovmf aspects of the following bugs: https://bugzilla.tianocore.org/show_bug.cgi?id=3510

Re: [edk2-devel] [PATCH 1/3] OvmfPkg: introduce a common work area

On 8/4/21 3:20 PM, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > Both the TDX and SEV support needs to reserve a page in MEMFD as a work > area. The page will contain meta data specific to the guest type. > Currently, the SEV-ES support reserves a page in

[edk2-devel] [PATCH v2 3/4] OvmfPkg: Reference new TPM classes in the build system for compilation

Compile the added TPM related code now. Signed-off-by: Stefan Berger --- OvmfPkg/AmdSev/AmdSevX64.dsc | 3 +++ .../Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 + OvmfPkg/OvmfPkgIa32.dsc| 3 +++

[edk2-devel] [PATCH v2 2/4] OvmfPkg/TPM: Add a NULL implementation of TpmPlatformHierarchyLib

Add a NULL implementation of the library class TpmPlatformHierarchyLib Signed-off-by: Stefan Berger --- .../PeiDxeTpmPlatformHierarchyLib.c | 19 .../PeiDxeTpmPlatformHierarchyLib.inf | 31 +++ 2 files changed, 50 insertions(+) create mode 100644

[edk2-devel] [PATCH v2 1/4] OvmfPkg/TPM: Import PeiDxeTpmPlatformHierarchyLib.c from edk2-platforms

Import PeiDxeTpmPlatformHierarchyLib.c from edk2-platforms. Modify it so that ConfigureTpmPlatformHierarchy() is the only public function provided by this file. Signed-off-by: Stefan Berger --- .../Include/Library/TpmPlatformHierarchyLib.h | 27 +++ .../PeiDxeTpmPlatformHierarchyLib.c

[edk2-devel] [PATCH v2 4/4] OvmfPkg: Disable the TPM2 platform hierarchy

Use the newly added function to disable the TPM2 platform hierarchy. Signed-off-by: Stefan Berger --- OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 6 ++ OvmfPkg/Library/PlatformBootManagerLibBhyve/BdsPlatform.c | 6 ++

Re: [edk2-devel] [PATCH v2 1/2] MdePkg/BaseLib: Fix unaligned API prototypes

Hi Marvin, Can you provide an example of which C compiler is flagging this as an error and what error message is generated. Please enter a BZ with this background information and add link to the BZ in the commit message. This is a change to the BaseLib class, so we need to make sure there are

[edk2-devel] [PATCH v5 5/5] StandaloneMmPkg: build for 32bit arm machines

This change allows to build StandaloneMmPkg components for 32bit Arm StandaloneMm firmware. This change mainly moves AArch64/ source files to Arm/ side directory for several components: StandaloneMmCpu, StandaloneMmCoreEntryPoint and StandaloneMmMemLib. The source file is built for both 32b and

[edk2-devel] [PATCH v5 4/5] StandaloneMmPkg: fix pointer/int casts against 32bit architectures

Use intermediate (UINTN) cast when casting int from/to pointer. This is needed as UINT64 values cast from/to 32bit pointer for 32bit architectures. Signed-off-by: Etienne Carriere Acked-by: Jiewen Yao Reviewed-by: Sami Mujawar --- No change since v4 Changes since v3: - Remove Cc tags and

[edk2-devel] [PATCH v5 3/5] GenFv: Arm: support images entered in Thumb mode

Change GenFv for Arm architecture to generate a specific jump instruction as image entry instruction, when the target entry label is assembled with Thumb instruction set. This is possible since SecCoreEntryAddress value fetched from the PE32 has its LSBit set when the entry instruction executes in

[edk2-devel] [PATCH v5 2/5] ArmPkg: prepare 32bit ARM build of StandaloneMmPkg

Changes in ArmPkg to prepare building StandaloneMm firmware for 32bit Arm architectures. Adds ArmmmuStandaloneMmLib library to the list of the standard components build for ArmPkg on when ARM architectures. Changes path of source file AArch64/ArmMmuStandaloneMmLib.c and compile it for both 32bit

[edk2-devel] [PATCH v5 1/5] ArmPkg/IndustryStandard: 32b/64b agnostic FF-A, Mm SVC and Std SMC IDs

Defines ARM_SVC_ID_FFA_* and ARM_SVC_ID_SP_* identifiers for 32bit function IDs as per SMCCC specification. Defines also generic ARM SVC identifier macros to wrap 32bit or 64bit identifiers upon target built architecture. Signed-off-by: Etienne Carriere Reviewed-by: Sami Mujawar --- Changes

[edk2-devel] [Patch V2] MinPlatformPkg: Fix the incompatible change about SecureBootVariableLib

V1: The newly created lib will be consumed by SecureBootConfigDxe.inf in CoreDxeInclude.dsc V2: Add SecureBootVariableProvisionLib in CoreDxeInclude.dsc Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: DunTan ---

Re: [edk2-devel] [PATCH 1/1] OvmfPkg PlatformBootManagerLib: Move TryRunningQemuKernel()

On Mon, 2021-08-09 at 22:53 +1000, Christoph Willing wrote: > With soft feature freeze started, I wonder if this patch could be > reviewed and pushed for edk2-stable202108 tag? I think it has > languished because I didn't initially Cc appropriately - pls add > others as necessary. > > This patch

Re: [edk2-devel] [PATCH v6 1/6] OvmfPkg/BaseMemEncryptLib: Detect SEV live migration feature.

Hello Tom, On Mon, Aug 09, 2021 at 08:41:27AM -0500, Tom Lendacky wrote: > On 8/2/21 7:31 AM, Ashish Kalra wrote: > > + > > + Signature[12] = '\0'; > > + for (mKvmLeaf = 0x4000; mKvmLeaf < 0x4001; mKvmLeaf += 0x100) { > > I still really don't understand the need for the CPUID loop. KVM

Re: [edk2-devel] [PATCH v6 6/6] OvmfPkg/AmdSevDxe: Add support for SEV live migration.

On 8/2/21 7:33 AM, Ashish Kalra wrote: > From: Ashish Kalra > > Check for SEV live migration feature support, if detected > setup a new UEFI enviroment variable to indicate OVMF > support for SEV live migration. > > The new runtime UEFI environment variable is set via the > notification

Re: [edk2-devel] [PATCH v6 2/6] OvmfPkg/BaseMemEncryptLib: Hypercall API for page encryption state change

On 8/2/21 7:31 AM, Ashish Kalra wrote: > From: Ashish Kalra > > Add API to issue hypercall on page encryption state change. > > By default all the SEV guest memory regions are considered encrypted, > if a guest changes the encryption attribute of the page (e.g mark a > page as decrypted) then

[edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg: Add BaseSmmAccessLibNull

From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3540 Adds a NULL instance of SmmAccessLib. Cc: Ray Ni Cc: Rangasai V Chaganty Signed-off-by: Michael Kubacki --- Silicon/Intel/IntelSiliconPkg/Feature/SmmAccess/Library/BaseSmmAccessLibNull/BaseSmmAccessLibNull.c

Re: [edk2-devel] [PATCH v6 1/6] OvmfPkg/BaseMemEncryptLib: Detect SEV live migration feature.

On 8/2/21 7:31 AM, Ashish Kalra wrote: > From: Ashish Kalra > > Add support to check if we are running inside KVM HVM and > KVM HVM supports SEV Live Migration feature. > > Cc: Jordan Justen > Cc: Ard Biesheuvel > Signed-off-by: Ashish Kalra > --- >

[edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/PeiSmmAccessLib: Remove S3 requirement

From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3539 PeiInstallSmmAccessPpi() currently requires the boot mode be set to S3 to actually install gEfiPeiMmAccessPpiGuid. This change removes this requirement in the function implementation for two reasons: 1. Practical

Re: [edk2-devel] [PATCH 1/1] OvmfPkg PlatformBootManagerLib: Move TryRunningQemuKernel()

On Wed, 28 Jul 2021 at 04:18, Christoph Willing wrote: > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3504 > > This change ensures that PlatformBdsConnectSequence() is run > before TryRunningQemuKernel(). > > It reverses commit a34a886962561f6d8550b2a1bb193798ca456431 which aimed > to

Re: [edk2-devel] [PATCH 1/1] OvmfPkg PlatformBootManagerLib: Move TryRunningQemuKernel()

With soft feature freeze started, I wonder if this patch could be reviewed and pushed for edk2-stable202108 tag? I think it has languished because I didn't initially Cc appropriately - pls add others as necessary. This patch is a trivial (I think) change which fixes a long standing and annoying

Re: [edk2-devel] [PATCH] MinPlatformPkg: Fix the incompatible change about SecureBootVariableLib

Hi Dun, SecureBootConfigDxe.inf will also consume SecureBootVariableProvisionLib library. Can you also add the library in this patch? Thanks Zhiguang > -Original Message- > From: devel@edk2.groups.io On Behalf Of duntan > Sent: Monday, August 9, 2021 5:11 PM > To: devel@edk2.groups.io

Re: [edk2-devel] [PATCH v2 4/7] ArmPkg/DefaultExceptionHandlerLib: Check DebugImageInfoTable type safely

On 09/08/2021 13:55, Ard Biesheuvel wrote: On Mon, 9 Aug 2021 at 11:51, Marvin Häuser wrote: C does not allow casting to or dereferencing incompatible pointer types. Use the ImageInfoType member of the union first to determine the data type before dereferencing NormalImage. Cc: Leif Lindholm

Re: [edk2-devel] [PATCH v2 4/7] ArmPkg/DefaultExceptionHandlerLib: Check DebugImageInfoTable type safely

On Mon, 9 Aug 2021 at 11:51, Marvin Häuser wrote: > > C does not allow casting to or dereferencing incompatible pointer > types. Use the ImageInfoType member of the union first to determine > the data type before dereferencing NormalImage. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Vitaly

[edk2-devel] Soft Feature Freeze starts NOW for edk2-stable202108

Hi, all We enter into Soft Feature Freeze phase for edk2-stable202108. The tag edk2-stable202108-rc0 (d02dbb53cd78de799e6afaa237e98771fb5148db) has been created. In this phase, the feature under review will not be allowed to be pushed. The feature passed review can still be merged. The patch

Re: [edk2-devel] [PATCH edk2-test 1/1] uefi-sct/SctPkg: uefi-sct: QueryVariableInfo(EFI_VARIABLE_NON_VOLATILE)

The solution is upstreamed by commit-id: https://github.com/tianocore/edk2-test/commit/814b2af535d977b3967d65de77e42ab18a4f4db4 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#78952): https://edk2.groups.io/g/devel/message/78952 Mute

Re: [edk2-devel] [PATCH edk2-test 1/1] uefi-sct/SctPkg: uefi-sct: QueryVariableInfo(EFI_VARIABLE_NON_VOLATILE)

Reviewed-by: G Edhaya Chandran The bugzilla ticket is : 3469 – uefi-sct: QueryVariableInfo(attributes = EFI_VARIABLE_NON_VOLATILE) (tianocore.org) ( https://bugzilla.tianocore.org/show_bug.cgi?id=3469 ) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group.

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Update page alignment calculations

Thank you all. The solution is upstream by the commit :  https://github.com/tianocore/edk2-test/commit/e4be30440f081454d5d6f047510f484ee5bb8a88 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#78950):

[edk2-devel] [PATCH v2 1/7] MdeModulePkg/DxeCore: Consistent DebugImageInfoTable updates

In theory, modifications to the DebugImageInfoTable may cause exceptions. If the exception handler parses the table, this can lead to subsequent exceptions if the table state is inconsistent. Ensure the DebugImageInfoTable remains consistent during modifications. This includes: 1) Free the old

[edk2-devel] [PATCH v2 7/7] ArmPkg/DefaultExceptionHandlerLib: Mandatory LoadedImage for DebugImageInfoTable

To make parsing DebugImageInfoTable easier and safer, require the LoadedImage protocol instance to be valid for every NormalImage entry. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Vitaly Cheptsov Signed-off-by: Marvin Häuser ---

[edk2-devel] [PATCH v2 5/7] MdeModulePkg/CoreDxe: Mandatory LoadedImage for DebugImageInfoTable

To make parsing DebugImageInfoTable easier and safer, require the LoadedImage protocol instance to be valid for every NormalImage entry. Cc: Jian J Wang Cc: Hao A Wu Cc: Dandan Bi Cc: Liming Gao Cc: Vitaly Cheptsov Signed-off-by: Marvin Häuser ---

[edk2-devel] [PATCH v2 6/7] EmbeddedPkg/GdbStub: Mandatory LoadedImage for DebugImageInfoTable

To make parsing DebugImageInfoTable easier and safer, require the LoadedImage protocol instance to be valid for every NormalImage entry. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Abner Chang Cc: Daniel Schaefer Cc: Vitaly Cheptsov Signed-off-by: Marvin Häuser ---

[edk2-devel] [PATCH v2 3/7] EmbeddedPkg/GdbStub: Check DebugImageInfoTable type safely

C does not allow casting to or dereferencing incompatible pointer types. Use the ImageInfoType member of the union first to determine the data type before dereferencing NormalImage. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Abner Chang Cc: Daniel Schaefer Cc: Vitaly Cheptsov Signed-off-by:

[edk2-devel] [PATCH v2 2/2] UefiCpuPkg/BaseUefiCpuLib: Use toolchain-specific rodata section name

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3318 Correctly define the read-only data sections with the toolchain-specific section name. This hardens image permission security and may save image space. Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Vitaly Cheptsov Signed-off-by: Marvin

[edk2-devel] [PATCH v2 4/7] ArmPkg/DefaultExceptionHandlerLib: Check DebugImageInfoTable type safely

C does not allow casting to or dereferencing incompatible pointer types. Use the ImageInfoType member of the union first to determine the data type before dereferencing NormalImage. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Vitaly Cheptsov Signed-off-by: Marvin Häuser ---

[edk2-devel] [PATCH v2 2/2] BaseTools/CommonLib: Fix unaligned API prototypes

C prohibits not only dereferencing but also casting to unaligned pointers. Thus, the current set of unaligned APIs cannot be called safely. Update their prototypes to take VOID * pointers, which must be able to represent any valid pointer. Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Cc: Vitaly

[edk2-devel] [PATCH v2 2/2] SecurityPkg/SecureBootConfigDxe: Fix certificate lookup algorithm

The current certificate lookup code does not check the bounds of the authentication data before accessing it. Abort if the header cannot fit, and proceed to the next hashing algortihm if the OID of the current one exceeds the authentication data bounds. Additionally move the two-byte encoding

[edk2-devel] [PATCH v2 2/7] MdeModulePkg/DxeCore: Fix DebugImageInfoTable size report

Separate tracking the used entries from the table's self-reported size. Removing an entry from the table does not necessarily reduce the size of the table as defragmentation is not performed. Cc: Jian J Wang Cc: Hao A Wu Cc: Dandan Bi Cc: Liming Gao Cc: Vitaly Cheptsov Signed-off-by: Marvin

[edk2-devel] [PATCH v2 1/2] SecurityPkg/DxeImageVerificationLib: Fix certificate lookup algorithm

The current certificate lookup code does not check the bounds of the authentication data before accessing it. Abort if the header cannot fit. Also, the lookup code aborts once the authetication data is smaller than an algorithm's OID size. As OIDs are variably-sized, this may cause unexpected

[edk2-devel] [PATCH v2 1/2] BaseTools: Define the read-only data section name per toolchain

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3318 Different toolchains of the EDK II build system may generate ELF or Mach-O files, which use the ".rodata" naming convention, or PE/COFF files, which use the ".rdata" naming convention. Section permissions are chosen based on this name per

[edk2-devel] [PATCH v2 1/2] MdePkg/BaseLib: Fix unaligned API prototypes

C prohibits not only dereferencing but also casting to unaligned pointers. Thus, the current set of unaligned APIs cannot be called safely. Update their prototypes to take VOID * pointers, which must be able to represent any valid pointer. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu

[edk2-devel] [PATCH v2 0/7] Fix various issues regarding DebugImageInfoTable

There are various issues regarding DebugImageInfoTable: 1) Interrupting the table updates (e.g. an exception occured) may leave the table in an inconsistent state. 2) Deleting an entry from the table may hide a different entry. 3) The type of image entries is not checked before accessing them as

[edk2-devel] [PATCH] MinPlatformPkg: Fix the incompatible change about SecureBootVariableLib

The newly created lib will be consumed by SecureBootConfigDxe.inf in CoreDxeInclude.dsc Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: DunTan --- Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [edk2-devel] [PATCH edk2-Platform v1 1/1] Hisilicon:Fix header file issues

Hi Leif， According to your advice, I have changed the name of header to OemHisiMiscLib and snet the v2 patch to you. Please help reviewing it when you are free. Thanks Wenyi On 2021/8/4 20:24, Leif Lindholm wrote: > +Rebecca > > Apologies for slow response, this arrived while I was on

Re: [edk2-devel] [Patch] BaseTools: use shutil.copyfile instead shutil.copy2

On 7/28/21 1:45 PM, Bob Feng wrote: > In Split tool, the copy file actions only need to > copy file content but not need to copy file metadata. > > copy2() copies the file metadata that causes split > unit test failed under edk2-basetools CI environment. > > So this patch changes the call of

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix the non-ascii character in UniversalPayloadEntry.c

On 8/9/21 8:08 AM, duntan wrote: > Fix the non-ascii character in UniversalPayloadEntry.c > > Cc: Guo Dong > Cc: Ray Ni > Cc: Maurice Ma > Cc: Benjamin You > > Signed-off-by: DunTan > --- > UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [edk2-devel] [PATCH] MdeModulePkg/DxeCore: Consistent DebugImageInfoTable updates

> -Original Message- > From: devel@edk2.groups.io On Behalf Of Marvin > H?user > Sent: Monday, August 9, 2021 3:21 PM > To: Wu, Hao A ; devel@edk2.groups.io > Cc: Wang, Jian J ; Vitaly Cheptsov > > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/DxeCore: Consistent > DebugImageInfoTable

Re: [edk2-devel] [PATCH] MdeModulePkg/DxeCore: Consistent DebugImageInfoTable updates

On 09/08/2021 08:52, Wu, Hao A wrote: -Original Message- From: devel@edk2.groups.io On Behalf Of Marvin H?user Sent: Monday, August 9, 2021 2:16 PM To: Wu, Hao A ; devel@edk2.groups.io Cc: Wang, Jian J ; Vitaly Cheptsov Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/DxeCore: Consistent

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix the non-ascii character in UniversalPayloadEntry.c

Reviewed-by: Ray Ni -Original Message- From: Tan, Dun Sent: Monday, August 9, 2021 2:08 PM To: devel@edk2.groups.io Cc: Dong, Guo ; Ni, Ray ; Ma, Maurice ; You, Benjamin ; Tan, Dun Subject: [PATCH] UefiPayloadPkg: Fix the non-ascii character in UniversalPayloadEntry.c Fix the

Re: [edk2-devel] [PATCH] MdeModulePkg/DxeCore: Consistent DebugImageInfoTable updates

> -Original Message- > From: devel@edk2.groups.io On Behalf Of Wu, Hao > A > Sent: Monday, August 9, 2021 2:52 PM > To: devel@edk2.groups.io; mhaeu...@posteo.de > Cc: Wang, Jian J ; Vitaly Cheptsov > > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/DxeCore: Consistent >

Re: [edk2-devel] [PATCH] MdeModulePkg/DxeCore: Consistent DebugImageInfoTable updates

> -Original Message- > From: devel@edk2.groups.io On Behalf Of Marvin > H?user > Sent: Monday, August 9, 2021 2:16 PM > To: Wu, Hao A ; devel@edk2.groups.io > Cc: Wang, Jian J ; Vitaly Cheptsov > > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/DxeCore: Consistent > DebugImageInfoTable

Re: [edk2-devel] [PATCH] MdeModulePkg/DxeCore: Consistent DebugImageInfoTable updates

Good day Hao, Sorry for the confusion, and you are (rightfully!) not alone. :( I'll quote myself from a different patch: [...] for some reason, none of the other patch series had indices appended. I'm sure I can get that fixed shortly, but what to do then, re-send the entire bulk? I don't

Re: [edk2-devel] [PATCH] MdeModulePkg/DxeCore: Consistent DebugImageInfoTable updates

Sorry Marvin Häuser, Could you help to confirm that below 9 MdeModulePkg related patches are either: * All independent patches * Belong to a patch series that includes all these 9 MdeModulePkg related commits * Belong to several independent patch series MdePkg/Base.h: Introduce various

[edk2-devel] [PATCH v2 1/1] MdeModulePkg/PiSmmCore: Drop deprecated image profiling commands

The legacy codebase allowed SMM images to be registered for profiling from DXE. Support for this has been dropped entirely, so remove the remaining handlers. Cc: Jian J Wang Cc: Hao A Wu Cc: Eric Dong Cc: Ray Ni Cc: Vitaly Cheptsov Signed-off-by: Marvin Häuser ---

[edk2-devel] [PATCH] UefiPayloadPkg: Fix the non-ascii character in UniversalPayloadEntry.c

Fix the non-ascii character in UniversalPayloadEntry.c Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan --- UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git