That won't work on Unix, where the separator is ':', not ';'.
--
Rebecca Cran
On 6/5/23 02:12, Yuwei Chen wrote:
Currently, Python FMMT tool does not support automatically
select FMMTConf.ini file which saves GuidTool settings.
This patch support this features.
Cc: Rebecca Cran
Cc: Liming
Add DXE, SMM, and STANDALONE MM implementations of the
MemoryProtectionHobLib.
Signed-off-by: Taylor Beebe
Cc: Jian J Wang
Cc: Liming Gao
Cc: Dandan Bi
---
MdeModulePkg/Library/MemoryProtectionHobLib/DxeMemoryProtectionHobLib.c
| 182
DxeMemoryProtectionHobLib and MmMemoryProtectionHobLib will fetch
the memory protection settings HOB entry for their respective phase,
validate the settings, and populate a global for access.
Memory protection settings are currently dictated via
FixedAtBuild PCDs where the settings needed to be
These headers provide settings definitions for memory protections,
settings profiles for easily enabling memory protections,
and the GUIDs used for producing the memory protection HOB.
The settings options are functionally 1:1 with the existing
PCD bitfield definitions. Instead of setting a fixed
Memory protection settings are currently configured via FixedAtBuild
PCDs which resulted in a build-time configuration of memory mitigations.
To improve flexibility and compatibility, this patchset adds HOB definitions
and libraries required for configuring memory protection settings at runtime.
Any feedback?
From: devel@edk2.groups.io on behalf of Nolan Hergert
Sent: Wednesday, May 24, 2023 12:07 PM
To: devel@edk2.groups.io
Cc: Bi, Dandan ; Gao, Liming
Subject: [edk2-devel] [PATCH 1/1] MdeModulePkg: Cache device path during
LoadImage calls
v1 -> v2:
- Retain outer cast
- Add error check instead of Status storage removal
Ranbir Singh (2):
MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fix SIGN_EXTENSION Coverity
issue
MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fix UNUSED_VALUE Coverity issue
REF : https://bugzilla.tianocore.org/show_bug.cgi?id=4480
In the FspsWrapperPeim, before calling FspWrapperVariableRequestHandler
and FspWrapperMultiPhaseHandler ,FspHobListPtr should be available so
that BL will be able to get the correct FspHobListPtr value
Signed-off-by: kurugodx
Cc: Chasel
From: Ranbir Singh
The return value stored in Status after call to SetDriveParameters
is not made of any use thereafter and hence it remains as UNUSED.
Add error check as is done after calls to SetDeviceTransferMode.
Cc: Hao A Wu
Cc: Ray Ni
REF:
From: Ranbir Singh
Line number 1348 does contain a typecast with UINT32, but it is after
all the operations (16-bit left shift followed by OR'ing) are over.
To avoid any SIGN_EXTENSION, typecast the intermediate result after
16-bit left shift operation immediately with UINT32.
Cc: Hao A Wu
Cc:
REF : https://bugzilla.tianocore.org/show_bug.cgi?id=4480
In the FspsWrapperPeim, before calling FspWrapperVariableRequestHandler
and FspWrapperMultiPhaseHandler ,FspHobListPtr should be available so
that BL will be able to get the correct FspHobListPtr value
Signed-off-by: kurugodx
Cc: Chasel
Please update the subject per format requirement -
PackageName: title
With this update, Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Aishwarya, KurugoduMelmatamX
>
> Sent: Friday, June 9, 2023 6:40 AM
> To: devel@edk2.groups.io
> Cc: Aishwarya,
Reviewed-by: Jiaxin Wu
> -Original Message-
> From: Ni, Ray
> Sent: Wednesday, May 31, 2023 7:35 PM
> To: devel@edk2.groups.io
> Cc: Wu, Jiaxin ; Bi, Dandan ;
> Gao, Liming ; Wang, Jian J
>
> Subject: [PATCH V2 6/6] MdeModulePkg/SmmCorePerformanceLib: Disable
> perf-logging at
Reviewed-by: Jiaxin Wu
> -Original Message-
> From: Ni, Ray
> Sent: Wednesday, May 31, 2023 7:35 PM
> To: devel@edk2.groups.io
> Cc: Wu, Jiaxin ; Bi, Dandan ;
> Gao, Liming ; Wang, Jian J
>
> Subject: [PATCH V2 5/6] MdeModulePkg/SmmPerformanceLib: Disable perf-
> logging after ExitBS
Reviewed-by: Jiaxin Wu
> -Original Message-
> From: Ni, Ray
> Sent: Wednesday, May 31, 2023 7:35 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Gao, Liming
> ; Wu, Jiaxin
> Subject: [PATCH V2 4/6] MdeModulePkg/SmmCore: Add perf-logging for
> SmmDriverDispatchHandler
>
>
Could we also make below perf-logged?
PlatformHookBeforeSmmDispatch & PlatformHookAfterSmmDispatch
Others good to me.
Reviewed-by: Jiaxin Wu
Thanks,
Jiaxin
> -Original Message-
> From: Ni, Ray
> Sent: Wednesday, May 31, 2023 7:35 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J
> +//
>
> +// The list of all MP procedures that need to be perf-logged.
>
> +//
>
> +#define SMM_MP_PERF_PROCEDURE_LIST(_) \
>
> + _(SmmInitHandler), \
>
> + _(SmmRendezvousEntry), \
>
> + _(PlatformValidSmi), \
>
> + _(SmmRendezvousExit), \
>
> + _(SmmMpProcedureMax) // Add new
Reviewed-by: Ashraf Ali S
-Original Message-
From: Aishwarya, KurugoduMelmatamX
Sent: Friday, June 9, 2023 7:10 PM
To: devel@edk2.groups.io
Cc: Aishwarya, KurugoduMelmatamX ; Chiu,
Chasel ; Desimone, Nathaniel L
; Duggapu, Chinni B
; Chen, Gang C ; Zeng, Star
; Kuo, Ted ; S, Ashraf
>
> The patch adds perf-logging for the following potential
> time-consuming BSP procedures:
> * PiCpuSmmEntry
> - SmmRelocateBases
> * ExecuteFirstSmiInit
>
ExecuteFirstSmiInit is not belong to the SmmRelocateBases. Others good to me.
Reviewed-by: Jiaxin Wu
> * BSPHandler
> -
In UnsetGuardPage(), before SmmReadyToLock, remove NX and RO
memory attribute protection for guarded page since
EfiConventionalMemory in SMRAM is RW and executable before
SmmReadyToLock. If UnsetGuardPage() happens after SmmReadyToLock,
then apply EFI_MEMORY_XP to the guarded page to make sure
Remove code that apply AddressEncMask to non-leaf entry when split
smm page table by MemEncryptSevLib. In FvbServicesSmm driver, it
calls MemEncryptSevClearMmioPageEncMask to clear AddressEncMask
bit in page table for a specific range. In AMD SEV feature, this
AddressEncMask bit in page table is
In the V6 patch set:
In 'MdeModulePkg: Remove other attribute protection in UnsetGuardPage', add
code to apply EFI_MEMORY_XP to the guarded page to be freed in UnsetGuardPage()
if it happens after SmmReadyToLock.
Only resend the patches in MdeModulePkg and OvmfPkg for further review. Other
Hi Ard,
Thanks for your question. This patch does cause a difference that NX
protections maybe removed for some EfiConventionalMemory in SMRAM after
SmmReadyToLock.
Before SmmReadyToLock, EfiConventionalMemory in SMRAM is always RW and
executable.
When SmmReadyToLock, SetMemMapAttributes() in
Hi Hao Wu,
I will provide V4 for below next.
#1 Modify DSC file in patch 3/3
#2 add Acked-by: Hao A Wu
#3 modify DXE_DRIVER to UEFI_DRIVER
Thanks,
Richard
-Original Message-
From: Wu, Hao A
Sent: 2023年6月8日 2:23 PM
To: devel@edk2.groups.io; Richard Ho (何明忠)
Cc: Andrew Fish ; Leif
24 matches
Mail list logo
