> My suggestion is to wrap the newly added DEBUG statement with an if:
>
> if (OptionIndex == -1) {
> Status = EfiBootManagerAddLoadOptionVariable (, MAX_UINTN);
> +if (Status == EFI_OUT_OF_RESOURCES) {
> + DEBUG ((DEBUG_ERROR, "ERROR: Variable store is full.\n"));
> +}
>
Thanks. I am fine with the proposal below.
Could you please help to follow the step 11 in page:
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process
and check the CI test results for the upcoming patch?
Best Regards,
Hao Wu
> -Original Message-
> From: Henz,
From: Michael Kubacki
Many arrays are defined with a length of MAX_MENU_NUMBER in
FormGuid.h. Two of those are BootOptionOrder and DriverOptionOrder.
In UpdatePage.c, a pointer is set to either of those arrays. The
array buffer is accessed using an index whose range is checked after
the pointer
Pushed: https://github.com/tianocore/edk2-platforms/commit/bb6841e
-Original Message-
From: Ramkumar Krishnamoorthi
Sent: Thursday, August 31, 2023 10:53 AM
To: devel@edk2.groups.io
Cc: DOPPALAPUDI, HARIKRISHNA ; Ponnusamy, Suresh
; KARPAGAVINAYAGAM, MANICKAVASAKAM
; Venkatesan,
Reviewed-by: Nate DeSimone
-Original Message-
From: Ramkumar Krishnamoorthi
Sent: Thursday, August 31, 2023 10:53 AM
To: devel@edk2.groups.io
Cc: DOPPALAPUDI, HARIKRISHNA ; Ponnusamy, Suresh
; KARPAGAVINAYAGAM, MANICKAVASAKAM
; Venkatesan, Selvaraj ; Ramkumar
Krishnamoorthi ; Isaac
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: Mike Beaton
Sent: Thursday, September 7, 2023 11:35 AM
To: devel@edk2.groups.io
Cc: Dong, Eric ; Bi, Dandan ; Ard
Biesheuvel ; Mike Beaton
Subject: [PATCH v5] MdeModulePkg/HiiDatabase: Fix incorrect AllocateCopyPool
Hi Liming,
I'm running the CodeQL CLI
(https://docs.github.com/en/code-security/codeql-cli/getting-started-with-the-codeql-cli)
locally against the code with some new queries.
The queries in the codeql/cpp-queries pack listed here are relatively
easy to experiment with
Avinash:
Seemly, this patch set doesn't include the change in ShellPkg.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Avinash
> 发送时间: 2023年9月8日 3:00
> 收件人: devel@edk2.groups.io
> 主题: [edk2-devel] [PATCH 0/2] Add New Intel Processor family
>
> Content-Type: text/plain;
Mike:
Thanks for your detail information in the commit message. This change is
very clear.
Reviewed-by: Liming Gao
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Mike Beaton
> 发送时间: 2023年9月7日 11:35
> 收件人: devel@edk2.groups.io
> 抄送: Eric Dong ; Dandan Bi ;
> Ard Biesheuvel ;
Michael:
How do you detect those issues? Do you use the tool or do code review?
For this change, Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Michael
> Kubacki
> 发送时间: 2023年9月7日 1:41
> 收件人: devel@edk2.groups.io
> 抄送: Zhichao Gao ; Michael D Kinney
>
> 主题:
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: Rebecca Cran
> 发送时间: 2023年9月7日 3:47
> 收件人: devel@edk2.groups.io; mikub...@linux.microsoft.com
> 抄送: Michael D Kinney ; Liming Gao
> ; Zhiguang Liu ;
> Rebecca Cran
> 主题: Re: [edk2-devel] [PATCH v1 1/1] MdePkg/Library/BaseRngLib: Fix
> include
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: Yao, Jiewen
> 发送时间: 2023年9月7日 7:32
> 收件人: devel@edk2.groups.io; mikub...@linux.microsoft.com
> 抄送: Kinney, Michael D ; Gao, Liming
> ; Liu, Zhiguang ;
> Rebecca Cran
> 主题: RE: [edk2-devel] [PATCH v1 1/1] MdePkg/Library/TdxLib: Remove
>
On 9/7/2023 1:54 PM, Laszlo Ersek wrote:
On 9/7/23 19:50, Sean Brogan wrote:
I would argue that by declaring that your library class supports type
DXE_CORE (or any core type) that you have declared you understand the
uniqueness of the environment and have accounted for it.
For instances that
I was asking about the property of the global variables
being used in this patch. Are they already guaranteed to
be in BSD format and in range 0..9. If so, then no additional
code changes would be required. However, it would be good
to add comments about the properties of those global
Reviewed-by: Michael D Kinney
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Wednesday, September 6, 2023 10:41 AM
> To: devel@edk2.groups.io
> Cc: Gao, Zhichao ; Kinney, Michael D
>
> Subject: [PATCH v1 1/1] ShellPkg/UefiShellNetwork2CommandsLib: Check
> array index
Reviewed-by: Michael D Kinney
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Wednesday, September 6, 2023 10:34 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
> ; Liu, Zhiguang ;
> Rebecca Cran
> Subject: [PATCH v1 1/1] MdePkg/Library/TdxLib:
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Rebecca Cran
> Sent: Wednesday, September 6, 2023 12:47 PM
> To: devel@edk2.groups.io; mikub...@linux.microsoft.com
> Cc: Kinney, Michael D ; Gao, Liming
> ; Liu, Zhiguang ;
> Rebecca Cran
> Subject: Re: [edk2-devel] [PATCH v1
There's not package level control at the moment from a given package CI
YAML file. We've treated this as fundamental for "core" packages (those
often built from a single CISettings.py file) and on-by-default but with
a disable option via the env var for individual platform build files
(like
On 9/7/23 22:24, Het Gala wrote:
>
>
>
> Forwarded Message
> Subject: [edk2-discuss] UEFI variables not getting stored in nvram disk
> Date: Mon, 17 Jul 2023 23:24:45 +0530
> From: Het Gala
> To: disc...@edk2.groups.io
> CC: Kallol Biswas [C]
>
>
>
On 9/7/23 19:50, Sean Brogan wrote:
> I would argue that by declaring that your library class supports type
> DXE_CORE (or any core type) that you have declared you understand the
> uniqueness of the environment and have accounted for it.
>
> For instances that support DXE_CORE or MM_CORE module
> On Sep 7, 2023, at 12:11 PM, Marcin Juszkiewicz
> wrote:
>
> W dniu 7.09.2023 o 19:40, Andrew (EFI) Fish pisze:
>>> On Sep 7, 2023, at 8:00 AM, Marcin Juszkiewicz wrote:
>>>
>>> Is there a way to have VT100 (or any other black/white, non-ANSI) terminal
>>> for UEFI Shell?
>>>
>>> I do
On 9/7/23 17:17, Ard Biesheuvel wrote:
> On Thu, 7 Sept 2023 at 16:51, Laszlo Ersek wrote:
>>
>> On 9/7/23 16:27, Ard Biesheuvel wrote:
>>> On Mon, 16 Jan 2023 at 12:39, Evgeny Iakovlev
>>> wrote:
EL3 firmware may implement PSCI interface on aarch64 platforms,
including
W dniu 7.09.2023 o 19:40, Andrew (EFI) Fish pisze:
On Sep 7, 2023, at 8:00 AM, Marcin Juszkiewicz wrote:
Is there a way to have VT100 (or any other black/white, non-ANSI)
terminal for UEFI Shell?
I do many runs of QEMU/sbsa-ref with logging and all those ANSI colour
codes only make
This looks fine to me as far as an edit, but I didn't validate the commands.
Reviewed-by: Andrei Warkentin
> -Original Message-
> From: Laszlo Ersek
> Sent: Thursday, September 7, 2023 9:58 AM
> To: ler...@redhat.com; edk2-devel-groups-io
> Cc: Warkentin, Andrei ; Ard Biesheuvel
> ;
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4547
Add New Intel Processor family for SMBIOS Type 4
Hex value - 16h
Name - Intel® Processor
Signed-off-by: avinashbhargava
Cc: Zhiguang Liu
Cc: Dandan Bi
Cc: Star Zeng
Cc: Zhichao Gao
Cc: Benny Lin
Cc: Gua Guo
Cc: Prakashan Krishnadas
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4547
Add New Intel Processor family for SMBIOS
Hex value - 16h
Name - Intel® Processor
Signed-off-by: avinashbhargava
Cc: Zhiguang Liu
Cc: Dandan Bi
Cc: Star Zeng
Cc: Zhichao Gao
---
MdePkg/Include/IndustryStandard/SmBios.h | 1 +
1 file
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
*** BLURB HERE ***
Avinash (1):
MdePkg/SmBios.h : Add New Intel Processor family
Nhi Pham (1):
ShellPkg/SmbiosView: Update display of PCIe system slot ID
I don’t have strong opinions either. If we would prefer to cache the values
returned by GetPerformanceCounterProperties I would be more than happy to do
that. I could also modify XhcGetElapsedTime to return the elapsed ticks instead
of the elapsed time in nano seconds, the functions that call
I would argue that by declaring that your library class supports type
DXE_CORE (or any core type) that you have declared you understand the
uniqueness of the environment and have accounted for it.
For instances that support DXE_CORE or MM_CORE module types we often use
a global variable (to
> On Sep 7, 2023, at 8:00 AM, Marcin Juszkiewicz
> wrote:
>
> Is there a way to have VT100 (or any other black/white, non-ANSI) terminal
> for UEFI Shell?
>
> I do many runs of QEMU/sbsa-ref with logging and all those ANSI colour codes
> only make problems.
>
These are the supported
On Thu, Sep 07, 2023 at 22:46:43 +0700, Nhi Pham via groups.io wrote:
> This adds Rebecca Cran as reviewer, updates myself as maintainer, and
> Leif as reviewer. Also, removes Vu Nguyen and Thang Nguyen due to no
> longer working on EDK2.
>
> Signed-off-by: Nhi Pham
Reviewed-by: Leif Lindholm
On 9/7/2023 9:46 AM, Nhi Pham wrote:
This adds Rebecca Cran as reviewer, updates myself as maintainer, and
Leif as reviewer. Also, removes Vu Nguyen and Thang Nguyen due to no
longer working on EDK2.
Signed-off-by: Nhi Pham
---
Maintainers.txt | 7 +++
1 file changed, 3 insertions(+), 4
This adds Rebecca Cran as reviewer, updates myself as maintainer, and
Leif as reviewer. Also, removes Vu Nguyen and Thang Nguyen due to no
longer working on EDK2.
Signed-off-by: Nhi Pham
---
Maintainers.txt | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git
On 9/6/2023 11:22 PM, Oliver Smith-Denny wrote:
On 9/6/2023 1:50 AM, Ard Biesheuvel wrote:
On Wed, 6 Sept 2023 at 09:56, Nhi Pham
wrote:
On 9/6/2023 1:33 PM, Ni, Ray wrote:
[EXTERNAL EMAIL NOTICE: This email originated from an external sender.
Please be mindful of safe email handling and
On 9/7/2023 6:10 AM, Laszlo Ersek wrote:
(replying on the webui... sorry!)
The problem is actually embedded in MdePkg and MdeModulePkg.
- In DxeMain() (and in functions called by DxeMain()), we call DebugLib
APIs *before* reaching ProcessLibraryConstructorList().
- In ArmVirtQemu, we
On Thu, 7 Sept 2023 at 16:51, Laszlo Ersek wrote:
>
> On 9/7/23 16:27, Ard Biesheuvel wrote:
> > On Mon, 16 Jan 2023 at 12:39, Evgeny Iakovlev
> > wrote:
> >>
> >> EL3 firmware may implement PSCI interface on aarch64 platforms,
> >> including qemu-tcg-aarch64. However, EL3 firmware does not
On 9/7/23 16:58, Laszlo Ersek wrote:
> Explain how users can compose their pre-OS environment purely from
> binaries they've built themselves.
>
> Cc: Andrei Warkentin
> Cc: Ard Biesheuvel
> Cc: Gerd Hoffmann
> Cc: Jiewen Yao
> Cc: Jordan Justen
> Cc: Sunil V L
> Signed-off-by: Laszlo Ersek
Reviewed-by: Jian J Wang
Regards,
Jian
> -Original Message-
> From: Tan, Dun
> Sent: Wednesday, September 06, 2023 11:22 AM
> To: devel@edk2.groups.io; Tan, Dun
> Cc: Ni, Ray ; Wang, Jian J ; Gao,
> Liming
> Subject: RE: [edk2-devel] [Patch V2 1/5] MdeModulePkg: add MpService2Ppi
>
Is there a way to have VT100 (or any other black/white, non-ANSI)
terminal for UEFI Shell?
I do many runs of QEMU/sbsa-ref with logging and all those ANSI colour
codes only make problems.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online
Explain how users can compose their pre-OS environment purely from
binaries they've built themselves.
Cc: Andrei Warkentin
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Sunil V L
Signed-off-by: Laszlo Ersek
---
Notes:
rendered version:
On 9/7/23 16:27, Ard Biesheuvel wrote:
> On Mon, 16 Jan 2023 at 12:39, Evgeny Iakovlev
> wrote:
>>
>> EL3 firmware may implement PSCI interface on aarch64 platforms,
>> including qemu-tcg-aarch64. However, EL3 firmware does not usually own
>> pulling and deploying ACPI tables from qemu fw_cfg.
On Mon, 16 Jan 2023 at 12:39, Evgeny Iakovlev
wrote:
>
> EL3 firmware may implement PSCI interface on aarch64 platforms,
> including qemu-tcg-aarch64. However, EL3 firmware does not usually own
> pulling and deploying ACPI tables from qemu fw_cfg. Thus the only way
> EL3 can advertise PSCI on
On Thu, 29 Jun 2023 at 22:47, Jeff Brasen via groups.io
wrote:
>
> Add EFI_NOT_READY return if the CPU can not be enabled if the
> processor is already on.
>
> This can occur in normal use if the CPU is still being turned off from
> a previous call when this is called again.
>
> Signed-off-by:
*TianoCore edk2-test Bug Triage Meeting*
*When:*
Thursday, September 7, 2023
10:00pm to 11:00pm
(UTC+08:00) Asia/Shanghai
*Where:*
https://armltd.zoom.us/j/91247522013?pwd=ei9nUndTbG9oWEROS2M1aVREZkpiQT09=addon
*Organizer:* Edhaya Chandran edhaya.chand...@arm.com (
On Thu, 6 Jul 2023 at 14:30, Gerd Hoffmann wrote:
>
> Be consistent with pl011-based serial console setup.
>
> Suggested-by: Laszlo Ersek
> Signed-off-by: Gerd Hoffmann
Acked-by: Ard Biesheuvel
I'll queue this one up too
> ---
> ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c | 9
On Tue, 4 Jul 2023 at 11:52, Gerd Hoffmann wrote:
>
> The qemu/kvm SMM emulation uses the AMD SaveState layout.
>
> So, now that we have AMD SaveState support merged we can just use
> Amd/SmramSaveStateMap.h, QemuSmramSaveStateMap.h is not needed any more.
>
> Signed-off-by: Gerd Hoffmann
On Thu, 6 Jul 2023 at 17:31, Gerd Hoffmann wrote:
>
> Add DetectAndPreparePlatformVirtioDevicePath() helper function
> to setup virtio-mmio devices. Start with virtio-serial support.
>
> This makes virtio console usable with microvm.
>
> Signed-off-by: Gerd Hoffmann
Acked-by: Ard Biesheuvel
On Tue, 4 Jul 2023 at 09:28, Gerd Hoffmann wrote:
>
> On Fri, Jun 30, 2023 at 02:26:03AM +0400, Joursoir wrote:
> > Add the new section for Secure Boot.
> >
> > Signed-off-by: Alexander Goncharov
>
> Acked-by: Gerd Hoffmann
>
Thanks all
Queued as #4800
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io
*Reminder: TianoCore edk2-test Bug Triage Meeting*
*When:*
Thursday, September 7, 2023
10:00pm to 11:00pm
(UTC+08:00) Asia/Shanghai
*Where:*
https://armltd.zoom.us/j/91247522013?pwd=ei9nUndTbG9oWEROS2M1aVREZkpiQT09=addon
*Organizer:* Edhaya Chandran edhaya.chand...@arm.com (
Quoting Yao, Jiewen (2023-09-07 14:26:31)
> I don't think using ASSERT is a good idea here.
>
Some context:
We observed that EDK2 hits an ASSERT (Out of Resources) when booting
with a full variable store. The message provided in this case is not
helpful for non-experts.
I think the goal here is
(replying on the webui... sorry!)
The problem is actually embedded in MdePkg and MdeModulePkg.
- In DxeMain() (and in functions called by DxeMain()), we call DebugLib APIs
*before* reaching ProcessLibraryConstructorList().
- In ArmVirtQemu, we resolve the DXE Core's DebugLib dependency to
From: caiyuqing379 <202235...@mail.sdu.edu.cn>
Add SG2042Pkg for Sophgo SG2042 platform. Provides PCD tokens.
Signed-off-by: caiyuqing379 <202235...@mail.sdu.edu.cn>
Co-authored-by: USER0FISH
Cc: dahogn
Cc: meng-cz
Cc: yli147
Cc: ChaiEvan
Cc: Sunil V L
Cc: Leif Lindholm
---
From: caiyuqing379 <202235...@mail.sdu.edu.cn>
This driver installs SMBIOS information for SG2042. Install hardware
information by creating an SMBIOS table which includes BIOS version,
system manufacturer, product name, processor, memory, slots, storage,
and other.
Signed-off-by: caiyuqing379
From: caiyuqing379 <202235...@mail.sdu.edu.cn>
This driver implements the MMC Host protocol, which is used by SD
interface driver that the Sophgo SG2042 EVB supports. Add this driver
in Sophgo/SG2042Pkg leveraging the one form Embedded Package.
Signed-off-by: caiyuqing379
Hi, Leif
Thanks for your comments. We have conducted some testing and completed the
third version of the patch.
1) Blurb
We have added some descriptions in Blurb to explain the current status, testing
situation, and limitations of the project.
2) Milk-V Pioneer board
Our team does not have a
From: caiyuqing379 <202235...@mail.sdu.edu.cn>
Add infrastructure files to build edk2-platforms for Sophgo SG2042
platform. It follows PEI less design.
Signed-off-by: caiyuqing379 <202235...@mail.sdu.edu.cn>
Co-authored-by: USER0FISH
Cc: dahogn
Cc: meng-cz
Cc: yli147
Cc: ChaiEvan
Cc: Sunil
From: caiyuqing379 <202235...@mail.sdu.edu.cn>
This driver implements Sophgo SDHCI controller, which provides
the necessary interfaces for handling communication and data
transfer with SD cards.
Signed-off-by: caiyuqing379 <202235...@mail.sdu.edu.cn>
Co-authored-by: USER0FISH
Cc: dahogn
Cc:
From: caiyuqing379 <202235...@mail.sdu.edu.cn>
This module supports Sophgo SG2042 EVB platform. It uses the
PEI less design. Add this module in SG2042Pkg leveraging the
one from OvmfPkg/RiscVVirt.
Signed-off-by: caiyuqing379 <202235...@mail.sdu.edu.cn>
Co-authored-by: USER0FISH
Cc: dahogn
Cc:
From: caiyuqing379 <202235...@mail.sdu.edu.cn>
Description:
Deploy EDK2 to run on 64-core CPU under RISC-V architecture, and successfully
boot to OS.
Implementation can be found on
https://github.com/AII-SDU/edk2-platforms/tree/devel-Sophgo/SG2042Pkg/Platform/Sophgo.
Current progress and
From: caiyuqing379 <202235...@mail.sdu.edu.cn>
SG2042 (Xuantie C920) MMU can be enabled in SV39 mode. C920 has five
customizable page properties that control whether the page is Strong
order(SO), Cacheable(C), Bufferable(B), Shareable(SH), Trustable(Sec).
This driver modifies the page table
I don't think using ASSERT is a good idea here.
Why not return ERROR?
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Zhenyu
> Zhang
> Sent: Thursday, September 7, 2023 7:11 PM
> To: devel@edk2.groups.io
> Cc: zheny...@redhat.com; ostef...@redhat.com; kra...@redhat.com;
From: "Zhenyu Zhang"
When the variable store is full, edk2 will directly assert.
Add debug information to help users understand what caused
the assertion.
Actual results:
RecordVarErrorFlag (0xEF) 9A144FE2A47E:937FE521-95AE-4D1A-8929-
48BCD90AD31A - 0x0003 - 0x7E
CommonVariableSpace =
On Thu, 7 Sept 2023 at 05:35, Mike Beaton wrote:
>
> The immediately preceding call, GetBestLanguage, plus the implementation of
> HiiGetString, which is called immediately afterwards, make it clear that
> BestLanguage is a null-terminated ASCII string, and not just a five byte,
> non-null
On Wed, 6 Sept 2023 at 23:49, Oliver Smith-Denny
wrote:
>
> Currently, ArmVirtPkg does not provide a serial library for DxeCore,
> so any early prints are missed. These prints are extremely valuable
> for debugging.
>
> The early serial port lib used by PeiCore and PEIMs is also
> applicable to
On Thu, 7 Sept 2023 at 10:34, Corvin Köhne wrote:
>
> If OVMF fails to find the RSDP in memory, it should fall back installing
> the statically provided ACPI tables.
>
> Signed-off-by: Corvin Köhne
> Cc: Ard Biesheuvel
> Cc: Jiewen Yao
> Cc: Jordan Justen
> Cc: Gerd Hoffmann
> Cc: Rebecca
Hi Mike,
Could you please reply for me?
If you want to filter range 0-9, then I will send PR again.
Thanks,
Horace Lien
-Original Message-
From: devel@edk2.groups.io On Behalf Of Lien, HoraceX
Sent: Friday, September 1, 2023 3:06 PM
To: Kinney, Michael D ; devel@edk2.groups.io
Cc: Liu,
From: Linus Liu
https://bugzilla.tianocore.org/show_bug.cgi?id=3004
Cc: Qi Zhang
Cc: Rahul Kumar
Cc: Jiewen Yao
Cc: Tina Chen
Cc: Xiao X Chen
---
SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git
CI: https://github.com/tianocore/edk2/pull/4799
Corvin Köhne (1):
OvmfPkg/Bhyve: don't exit early if RSDP is not found in memory
OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c | 19 ---
1 file changed, 8 insertions(+), 11 deletions(-)
--
2.42.0
-=-=-=-=-=-=-=-=-=-=-=-
If OVMF fails to find the RSDP in memory, it should fall back installing
the statically provided ACPI tables.
Signed-off-by: Corvin Köhne
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Cc: Rebecca Cran
Cc: Peter Grehan
---
Thanks.
1) I think we need an else branch for " SupportedAttributes->MediaEncryption ",
to assign " AvalDiskActions->SecureErase = 0;"
> -AvalDiskActions->SecureErase = 1;
>
> +if (SupportedAttributes->MediaEncryption) {
>
> + AvalDiskActions->SecureErase = 1;
>
> +}
>
>
Speaking of PcAtChipsetPkg/Library/AcpiTimerLib, the implementation of below
instances:
* PeiAcpiTimerLib.inf
* DxeAcpiTimerLib.inf
* StandaloneMmAcpiTimerLib.inf
will not calculate the TSC frequency upon every call of
GetPerformanceCounterProperties().
Best Regards,
Hao Wu
> -Original
I do not have strong opinion on this considering it is an IO driver.
The call of GetTimeInNanoSecond() is also likely to invoke
GetPerformanceCounterProperties() call.
I will let the patch owner to decide on the open raised below.
Best Regards,
Hao Wu
> -Original Message-
> From: Mike
Hello Hao Wu,
Isn't GetPerformanceCounterProperties (, ) call
too "heavy" for XHCI paths?
May be it's better to cache timer direction once?
I'm asking in a context of PcAtChipsetPkg/Library/AcpiTimerLib
instance used by a number of Intel's platform in edk-platforms.
For this library
From: Wang Fan
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4533
There are use cases which not all FVs need be migrated from TempRam to
permanent memory before TempRam tears down. This new guid is introduced
to avoid unnecessary FV migration to improve boot performance. Platform
can
Reviewed-by: Jiewen Yao
Merged https://github.com/tianocore/edk2/pull/4798
> -Original Message-
> From: Sheng, W
> Sent: Thursday, September 7, 2023 9:57 AM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen ; Wang, Jian J ;
> Xu, Min M ; Chen, Zeyi ; Wang,
> Fiona ; Lu, Xiaoyu1 ; Jiang,
>
75 matches
Mail list logo
