Thanks. Just to clarify, In the earlier formatting
"InvalidateDataCacheRange:\
> + Zicbom not supported.\n" \
A missing " after *Range:\ was causing slightly skewed prints. After adding
this " it looks okay. So that is one change I had addressed.
But if keeping it in a single line works
Hi @Gao, Liming and @Rebecca Cran
I may need to get your help for review it, any concern you can also share for
us.
Thanks,
Gua
-Original Message-
From: devel@edk2.groups.io On Behalf Of Yuwei Chen
Sent: Friday, December 15, 2023 5:12 PM
To: devel@edk2.groups.io
Cc: Rebecca Cran ;
On Wed, Dec 13, 2023 at 08:29:31PM +0530, Dhaval wrote:
> This PCD provides a way for platform to override any
> HW features that are default enabled by previous stages
> of FW (like OpenSBI). For the case where previous/prev
> stage has disabled the feature, this override is not
> useful and its
On Wed, Dec 13, 2023 at 08:29:30PM +0530, Dhaval Sharma wrote:
> Use newly defined cache management operations for RISC-V where possible
> It builds up on the support added for RISC-V cache management
> instructions in BaseLib.
> Cc: Michael D Kinney
> Cc: Liming Gao
> Cc: Zhiguang Liu
> Cc:
There is the SmmCpuSyncLib Library class define the SMM CPU sync
flow, which is aligned with existing SMM CPU driver sync behavior.
This patch is to consume SmmCpuSyncLib instance directly.
With this change, SMM CPU Sync flow/logic can be customized
with different implementation no matter for any
To decrease the count of RunningApCount, InterlockedDecrement is
enough to achieve that.
This patch is to simplify RunningApCount decrement.
Cc: Laszlo Ersek
Cc: Eric Dong
Cc: Ray Ni
Cc: Zeng Star
Cc: Gerd Hoffmann
Cc: Rahul Kumar
Signed-off-by: Jiaxin Wu
Reviewed-by: Ray Ni
---
This patch is to specify SmmCpuSyncLib instance for UefiPayloadPkg.
Cc: Laszlo Ersek
Cc: Guo Dong
Cc: Sean Rhodes
Cc: James Lu
Cc: Gua Guo
Cc: Ray Ni
Cc: Zeng Star
Signed-off-by: Jiaxin Wu
Reviewed-by: Gua Guo
Reviewed-by: Ray Ni
---
UefiPayloadPkg/UefiPayloadPkg.dsc | 1 +
1 file
This patch is to specify SmmCpuSyncLib instance for OvmfPkg.
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Eric Dong
Cc: Ray Ni
Cc: Zeng Star
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Signed-off-by: Jiaxin Wu
Reviewed-by: Ray Ni
---
OvmfPkg/CloudHv/CloudHvX64.dsc |
Implements SmmCpuSyncLib Library instance. The instance refers the
existing SMM CPU driver (PiSmmCpuDxeSmm) sync implementation
and behavior:
1.Abstract Counter and Run semaphores into SmmCpuSyncCtx.
2.Abstract CPU arrival count operation to
SmmCpuSyncGetArrivedCpuCount(), SmmCpuSyncCheckInCpu(),
This patch is to add SafeIntLib in MdeLibs.dsc.inc
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Laszlo Ersek
Cc: Ray Ni
Cc: Zeng Star
Signed-off-by: Jiaxin Wu
Reviewed-by: Michael D Kinney
---
MdePkg/MdeLibs.dsc.inc | 1 +
1 file changed, 1 insertion(+)
diff --git
Intel is planning to provide different SMM CPU Sync implementation
along with some specific registers to improve the SMI performance,
hence need SmmCpuSyncLib Library for Intel.
This patch is to:
1.Adds SmmCpuSyncLib Library class in UefiCpuPkg.dec.
2.Adds SmmCpuSyncLib.h function declaration
This patch is to define 3 new functions (WaitForBsp & ReleaseBsp &
ReleaseOneAp) used for the semaphore sync between BSP & AP. With the
change, BSP and AP Sync flow will be easy understand as below:
BSP: ReleaseAllAPs or ReleaseOneAp --> AP: WaitForBsp
BSP: WaitForAllAPs <-- AP:
The series patches are to refine SMM CPU Sync flow.
After the refinement, SmmCpuSyncLib is abstracted for
any user to provide different SMM CPU Sync implementation.
Jiaxin Wu (8):
UefiCpuPkg/PiSmmCpuDxeSmm: Optimize Semaphore Sync between BSP and AP
UefiCpuPkg: Adds SmmCpuSyncLib library
Hi Ray,
Thanks,
Chao
On 2023/12/19 14:29, Ni, Ray wrote:
Plan B:
It only returns the attribute and length of the first part, leaving it up to
the caller to decide to look for the next part.
I'm leaning toward plan B, what do you think?
I like plan B as well. Do you think that "EndAddress"
Hello Saloni:
Thanks for Clarifying.
Yes. If Network Devices MUST install LoadFile2 then it would be good that
section 18 includes network devices. Do we need to request UEFI forum for the
same?
Thanks
Siva
From: Kasbekar, Saloni
Sent: Tuesday, December 19, 2023 1:41 AM
To:
Acked-by: Ray Ni
Thanks,
Ray
> -Original Message-
> From: Chao Li
> Sent: Tuesday, December 12, 2023 9:12 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Kumar,
> Rahul R ; Gerd Hoffmann ;
> Baoqi Zhang
> Subject: [PATCH v4 11/37] UefiCpuPkg: Add CPU exception library for
>
Acked-by: Ray Ni
Thanks,
Ray
> -Original Message-
> From: Chao Li
> Sent: Tuesday, December 12, 2023 9:12 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Kumar,
> Rahul R ; Gerd Hoffmann
> Subject: [PATCH v4 14/37] UefiCpuPkg: Add multiprocessor library for
> LoongArch64
>
Acked-by: Ray Ni
Thanks,
Ray
> -Original Message-
> From: Chao Li
> Sent: Tuesday, December 12, 2023 9:13 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Kumar,
> Rahul R ; Gerd Hoffmann ;
> Baoqi Zhang ; Dongyan Qian
>
> Subject: [PATCH v4 15/37] UefiCpuPkg: Add CpuDxe
Acked-by: Ray Ni
Thanks,
Ray
> -Original Message-
> From: Chao Li
> Sent: Tuesday, December 12, 2023 9:12 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Kumar,
> Rahul R ; Gerd Hoffmann
> Subject: [PATCH v4 10/37] UefiCpuPkg: Add LoongArch64 CPU Timer library
>
> Add the
> Plan B:
> It only returns the attribute and length of the first part, leaving it up to
> the caller to decide to look for the next part.
> I'm leaning toward plan B, what do you think?
I like plan B as well. Do you think that "EndAddress" can be removed from the
param list?
Imaging from
Fan:
This version patch is good to me. Reviewed-by: Liming Gao
for this patch set.
Thanks
Liming
> -邮件原件-
> 发件人: Wang, Fan
> 发送时间: 2023年12月14日 22:15
> 收件人: Gao, Liming ; Kumar, Rahul R
>
> 抄送: Wang, Fan ; Wang, Jian J
> ; Ni, Ray ; Kinney, Michael D
> ; Jiang, Guomin ;
>
>
> SemAddr is the address of allocated buffer (SemBuffer), "SemAddr +=
> OneSemSize" will make SemAddr point to the part of allocated buffer. is it
> possible integer overflow? If so, the allocatepage should fail?
Good reason! I agree.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive
Fix GCC compiler error in StandaloneMmGenericIpmi.
Cc: Abner Chang
Cc: Nate DeSimone
Signed-off-by: Lixia Huang
---
Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/StandaloneMm/StandaloneMmGenericIpmi.c
| 2 --
1 file changed, 2 deletions(-)
diff --git
Thanks Ray.
>
> 1. It's not "LockedCpuCount". It's "ArrivedCpuCountUponLock".
> Comments can be:
> Before the door is locked, CpuCount stores the arrived CPU count.
> After the door is locked, CpuCount is set to -1 indicating the door is
> locked.
> ArrivedCpuCpuntUponLock stores the
Hi Ray,
It means that:
The "SmmCpuRendezvous" function has a bug in that it summons all APs into SMM,
but there is a time gap before they are set as "present." During this window,
if using the "setVariable" operation, it can cause issues because "setVariable"
requires all APs to be in SMM and
Mantis: https://mantis.uefi.org/mantis/view.php?id=2025
To avoid messy parsing of the Depex section of a Capsule, it would
be a lot easier for everyone involved if we preceded the Capsule Depex
Section with a length declaration. It provides simple bounds checking
to avoid having to parse the
Mantis: https://mantis.uefi.org/mantis/view.php?id=2025
To avoid messy parsing of the Depex section of a Capsule, it would
be a lot easier for everyone involved if we preceded the Capsule Depex
Section with a length declaration. It provides simple bounds checking
to avoid having to parse the
Mantis: https://mantis.uefi.org/mantis/view.php?id=2025
To avoid messy parsing of the Depex section of a Capsule, it would
be a lot easier for everyone involved if we preceded the Capsule Depex
Section with a length declaration. It provides simple bounds checking
to avoid having to parse the
From: Abner Chang
Signed-off-by: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Cc: Mike Maslenkin
---
.../ComputerSystemCollectionDxe.c | 3 ++-
.../EdkIIRedfishResourceConfigLib.c| 7 ++-
.../Library/RedfishVersionLib/RedfishVersionLib.c
[AMD Official Use Only - General]
> -Original Message-
> From: Mike Maslenkin
> Sent: Tuesday, December 19, 2023 10:12 AM
> To: Chang, Abner
> Cc: devel@edk2.groups.io; nick...@nvidia.com; ig...@ami.com
> Subject: Re: [PATCH v2 13/14] RedfishDiscoverDxe: handle memory allocation
> error
Yuanhao, Zhihao,
Can you kindly explain a bit more about this sentence in commit message " SMM
read save state requires AP must be present."?
Thanks,
Ray
> -Original Message-
> From: Xie, Yuanhao
> Sent: Friday, December 15, 2023 5:30 PM
> To: devel@edk2.groups.io
> Cc: Xie, Yuanhao ;
Reviewed-by: Ray Ni
Thanks,
Ray
> -Original Message-
> From: Wu, Jiaxin
> Sent: Friday, December 15, 2023 5:55 PM
> To: devel@edk2.groups.io
> Cc: Laszlo Ersek ; Dong, Eric ; Ni,
> Ray ; Zeng, Star ; Kumar, Rahul R
> ; Gerd Hoffmann
> Subject: [PATCH v4 1/8] UefiCpuPkg/PiSmmCpuDxeSmm:
Reviewed-by: Ray Ni
Thanks,
Ray
> -Original Message-
> From: Wu, Jiaxin
> Sent: Friday, December 15, 2023 5:55 PM
> To: devel@edk2.groups.io
> Cc: Laszlo Ersek ; Dong, Eric ; Ni,
> Ray ; Zeng, Star ; Gerd Hoffmann
> ; Kumar, Rahul R
> Subject: [PATCH v4 2/8] UefiCpuPkg: Adds
Reviewed-by: Ray Ni
Thanks,
Ray
> -Original Message-
> From: Wu, Jiaxin
> Sent: Friday, December 15, 2023 5:55 PM
> To: devel@edk2.groups.io
> Cc: Laszlo Ersek ; Ard Biesheuvel
> ; Yao, Jiewen ; Justen,
> Jordan L ; Dong, Eric ; Ni,
> Ray ; Zeng, Star ; Kumar, Rahul R
> ; Gerd Hoffmann
Reviewed-by: Ray Ni
Thanks,
Ray
> -Original Message-
> From: Wu, Jiaxin
> Sent: Friday, December 15, 2023 5:55 PM
> To: devel@edk2.groups.io
> Cc: Laszlo Ersek ; Dong, Guo ;
> Rhodes, Sean ; Lu, James ;
> Guo, Gua ; Ni, Ray ; Zeng, Star
>
> Subject: [PATCH v4 6/8] UefiPayloadPkg:
Reviewed-by: Ray Ni
Thanks,
Ray
> -Original Message-
> From: Wu, Jiaxin
> Sent: Friday, December 15, 2023 5:55 PM
> To: devel@edk2.groups.io
> Cc: Laszlo Ersek ; Dong, Eric ; Ni,
> Ray ; Zeng, Star ; Gerd Hoffmann
> ; Kumar, Rahul R
> Subject: [PATCH v4 7/8] UefiCpuPkg/PiSmmCpuDxeSmm:
Reviewed-by: Ray Ni
Thanks,
Ray
> -Original Message-
> From: Wu, Jiaxin
> Sent: Friday, December 15, 2023 5:55 PM
> To: devel@edk2.groups.io
> Cc: Laszlo Ersek ; Dong, Eric ; Ni,
> Ray ; Zeng, Star ; Gerd Hoffmann
> ; Kumar, Rahul R
> Subject: [PATCH v4 8/8] UefiCpuPkg/PiSmmCpuDxeSmm:
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Mike Maslenkin
> Sent: Tuesday, December 19, 2023 9:00 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; nick...@nvidia.com;
> ig...@ami.com; Mike Maslenkin
> Subject: [edk2-redfish-client][PATCH
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Mike Maslenkin
> Sent: Tuesday, December 19, 2023 9:00 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; nick...@nvidia.com;
> ig...@ami.com; Mike Maslenkin
> Subject: [edk2-redfish-client][PATCH
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Mike Maslenkin
> Sent: Tuesday, December 19, 2023 9:00 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; nick...@nvidia.com;
> ig...@ami.com; Mike Maslenkin
> Subject: [edk2-redfish-client][PATCH
[AMD Official Use Only - General]
Yes, Copyright (c) 2023, Contributor is good for
you now.
Abner
> -Original Message-
> From: Mike Maslenkin
> Sent: Tuesday, December 19, 2023 10:40 AM
> To: Chang, Abner
> Cc: devel@edk2.groups.io; nick...@nvidia.com; ig...@ami.com
> Subject:
From: Abdul Lateef Attar
Adds API to generate AML code to invoke/call another
method. Also provides ability to pass arguments of
type integer, string, ArgObj or LocalObj.
Cc: Pierre Gondois
Cc: Sami Mujawar
Signed-off-by: Abdul Lateef Attar
---
.../Include/Library/AmlLib/AmlLib.h
From: Abdul Lateef Attar
Corrects the function pointer typedef AML_PARSE_FUNCTION,
otherwise some compiler like VS2019 gives error.
Cc: Pierre Gondois
Cc: Sami Mujawar
Signed-off-by: Abdul Lateef Attar
Reviewed-by: Pierre Gondois
---
From: Abdul Lateef Attar
Corrects the parameters of AmlCodeGenRdWordBusNumber() to
UINT16 to generate word bus number.
Cc: Pierre Gondois
Cc: Sami Mujawar
Signed-off-by: Abdul Lateef Attar
Reviewed-by: Pierre Gondois
---
DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h | 10
From: Abdul Lateef Attar
Add helper functions to generate AML resource data
for word I/O.
Cc: Pierre Gondois
Cc: Sami Mujawar
Signed-off-by: Abdul Lateef Attar
Reviewed-by: Pierre Gondois
---
.../Include/Library/AmlLib/AmlLib.h | 65 ++
From: Abdul Lateef Attar
PR: https://github.com/tianocore/edk2/pull/5157
Resending patch with CI failure fix and added example.
V4: delta changes
Address Pierre's review comments.
Merged patch 4 & patch 5.
Also added parameter logic suggested by Pierre.
V3: delta changes
CI fix and
Hi Abner,
On Mon, Dec 18, 2023 at 7:58 AM Chang, Abner wrote:
>
> [AMD Official Use Only - General]
>
> > -Original Message-
> > From: Mike Maslenkin
> > Sent: Friday, December 15, 2023 7:25 AM
> > To: devel@edk2.groups.io
> > Cc: Chang, Abner ; nick...@nvidia.com;
> > ig...@ami.com;
Hi Abner,
Ok. I've already done it. But copyright change mentioned is for
another patchset to edk2's RedfishPkg.
Whereas you mentioned FIRST - LAST, would you like me to add
copyrights for these changes?
I guess LAST is not required for the new added code.
I didn't add any copyrights previously,
*Reminder: TianoCore Bug Triage - APAC / NAMO*
*When:*
Tuesday, December 19, 2023
6:30pm to 7:30pm
(UTC-08:00) America/Los Angeles
*Where:*
Hi Abner,
On Mon, Dec 18, 2023 at 7:47 AM Chang, Abner wrote:
>
> [AMD Official Use Only - General]
>
> > -Original Message-
> > From: Mike Maslenkin
> > Sent: Friday, December 15, 2023 7:25 AM
> > To: devel@edk2.groups.io
> > Cc: Chang, Abner ; nick...@nvidia.com;
> > ig...@ami.com;
[AMD Official Use Only - General]
Hi Mike,
According the conversation I had with Rebecca, please update your copyright
that follow below format on the later patches you send; as you use the
individual contributor copyright.
Copyright (c) FIRST - LAST, Contributor
Thanks
Abner
>
Hi Ray,
For the GetMemoryRegionAttributes, here are some of my plans:
Thanks,
Chao
On 2023/12/14 10:53, Chao Li wrote:
Hi Ray,
For you two comments:
BTY, can you review the other UefiCpuPkg patches in this series?
On 2023/12/13 下午1:17, Ni, Ray wrote:
Chao,
Thanks for providing such a
[AMD Official Use Only - General]
Hmm, ok, thanks Rebecca.
So that would be:
Copyright (c) FIRST - LAST, Contributor
Thanks
Abner
> -Original Message-
> From: Rebecca Cran
> Sent: Monday, December 18, 2023 1:37 PM
> To: devel@edk2.groups.io; Chang, Abner
> Subject: Re: [edk2-devel]
It is possible that at the time of accessing to AsciiLocation pointer
the memory is not allocated.
Also gcc version 4.8.5 20150623 (Red Hat 4.8.5-44) emits a warning for
this case:
RedfishFeatureUtilityLib.c:1889:37: error: 'AsciiLocation' may be used
uninitialized in this function
Cc: Abner Chang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
Reviewed-by: Nickle Wang
---
RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c
This patch set contains minor fixes.
diff from v1:
original patch 4/4 with change related to BIOS resources provisioning removed.
PR: https://github.com/tianocore/edk2-redfish-client/pull/64
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nickle Wang
Signed-off-by: Mike Maslenkin
Initially RedfishPlatformConfigGetConfigureLang could return success
even if ConfigureLangList is empty. After fixing this condition,
RedfishPlatformConfigGetConfigureLang returns an error, but this doesn't
help to avoid ASSERT because the error path is the same as for non-empty
list.
Cc: Abner
On 12/15/23 00:39, Stuart Yoder wrote:
From: Joseph Hemann
Please, provide commit messages.
Signed-off-by: Joseph Hemann
Signed-off-by: Stuart Yoder
---
uefi-sct/SctPkg/UEFI/Protocol/TCG2.h | 179
1 file changed, 179 insertions(+)
diff --git
BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Groups.io Inc//Groups.io Calendar//EN
METHOD:CANCELLED
REFRESH-INTERVAL;VALUE=DURATION:PT1H
X-PUBLISHED-TTL:PT1H
CALSCALE:GREGORIAN
BEGIN:VTIMEZONE
TZID:America/Los_Angeles
LAST-MODIFIED:20230911T053111Z
BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Groups.io Inc//Groups.io Calendar//EN
METHOD:CANCELLED
REFRESH-INTERVAL;VALUE=DURATION:PT1H
X-PUBLISHED-TTL:PT1H
CALSCALE:GREGORIAN
BEGIN:VTIMEZONE
TZID:America/Los_Angeles
LAST-MODIFIED:20230911T053111Z
Hello all,
Same question again. Could we please make some progress on this?
Full thread here:
https://openfw.io/edk2-devel/20231031173700.647004-1-ngo...@fedoraproject.org/
If nobody objects, I will assume that the change is acceptable and
merge it by the end of the week.
Thanks,
Ard.
On
Hi Siva,
“The EFI_LOAD_FILE2_PROTOCOL is a simple protocol used to obtain files from
arbitrary devices that are not boot
options”
“The EFI_LOAD_FILE_PROTOCOL is used for devices that do not directly support
file systems. Network devices
commonly boot in this model where the image is
From: Abdul Lateef Attar
Adds API to generate AML code to invoke/call another
method. Also provides ability to pass arguments of
type integer, string, ArgObj or LocalObj.
Cc: Pierre Gondois
Cc: Sami Mujawar
Signed-off-by: Abdul Lateef Attar
---
.../Include/Library/AmlLib/AmlLib.h
From: Abdul Lateef Attar
Corrects the parameters of AmlCodeGenRdWordBusNumber() to
UINT16 to generate word bus number.
Cc: Pierre Gondois
Cc: Sami Mujawar
Signed-off-by: Abdul Lateef Attar
Reviewed-by: Pierre Gondois
---
DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h | 10
From: Abdul Lateef Attar
Corrects the function pointer typedef AML_PARSE_FUNCTION,
otherwise some compiler like VS2019 gives error.
Cc: Pierre Gondois
Cc: Sami Mujawar
Signed-off-by: Abdul Lateef Attar
Reviewed-by: Pierre Gondois
---
From: Abdul Lateef Attar
Add helper functions to generate AML resource data
for word I/O.
Cc: Pierre Gondois
Cc: Sami Mujawar
Signed-off-by: Abdul Lateef Attar
Reviewed-by: Pierre Gondois
---
.../Include/Library/AmlLib/AmlLib.h | 65 ++
From: Abdul Lateef Attar
PR: https://github.com/tianocore/edk2/pull/5157
V4: delta changes
Address Pierre's review comments.
Merged patch 4 & patch 5.
Also added parameter logic suggested by Pierre.
V3: delta changes
CI fix and error handling for
DynamicTablesPkg: Adds API to
Hi Sahil,
As such these changes look good to me. But, we would need to revisit
this based on my response for Patch 3/5.
Regards,
Sami Mujawar
On 16/11/2023 11:45 am, sahil wrote:
Signed-off-by: sahil
---
Platform/ARM/N1Sdp/N1SdpPlatform.dsc | 5 +
Hi Sahil,
Please see my response for Patch 3/5.
Regards,
Sami Mujawar
On 16/11/2023 11:45 am, sahil wrote:
Enable persistent storage on QSPI flash device.
Signed-off-by: sahil
---
Platform/ARM/N1Sdp/N1SdpPlatform.dsc | 20 ++--
Platform/ARM/N1Sdp/N1SdpPlatform.fdf | 4
Hi Sahil,
Where can I find the documentation for Cadence QSPI? Can you add a link
to the relevant file headers, please?
Also, this patch is duplicating a lot of the code in
edk2-platforms\Platform\ARM\Drivers\NorFlashDxe and I have already
spotted some new bugs in this patch.
Have you
Hi Sahil,
Please find my feedback marked inline as [SAMI].
With those fixed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 16/11/2023 11:45 am, sahil wrote:
Add NOR flash library, this library provides APIs for getting the list
of NOR flash devices on the platform.
Signed-off-by:
Hi Sahil,
Please see my response inline marked [SAMI].
Regards,
Sami Mujawar
On 16/11/2023 11:45 am, sahil via groups.io wrote:
Enable SCP QSPI flash region access by adding it in the PlatformLibMem
Signed-off-by: sahil
---
Silicon/ARM/NeoverseN1Soc/Include/NeoverseN1Soc.h |
Solved it! Found a OpensslLibFull.inf that accepts more ciphers. Thank you!
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112641): https://edk2.groups.io/g/devel/message/112641
Mute This Topic: https://groups.io/mt/103240785/21656
Group
Greetings!
I have been investigating a TLS_HANDSHAKE_ERROR in QEMU running Ovmf caused by
an HTTPS call which, upon closer inspection with WireShark, has been tracked
down to the cipher suite negotiated being too restrictive.
Enabling additional debugging messages shows them being skipped in
Reviewed-by: S, Ashraf Ali
Thanks.,
S, Ashraf Ali
-Original Message-
From: Kuo, Ted
Sent: Monday, December 18, 2023 9:33 AM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Chiu, Chasel
; Desimone, Nathaniel L
; Dong, Eric ; S, Ashraf
Ali ; Duggapu, Chinni B ;
Gao, Liming
> + ///
> + /// Indicate CPUs entered SMM after lock door.
> + ///
> + UINTN LockedCpuCount;
1. It's not "LockedCpuCount". It's "ArrivedCpuCountUponLock".
Comments can be:
Before the door is locked, CpuCount stores the arrived CPU count.
After the
Thanks Ray,
The PR is updated with "Reviewed-by" added.
https://github.com/tianocore/edk2/pull/5004
BR,
Wei
-Original Message-
From: Ni, Ray
Sent: Monday, December 18, 2023 1:02 PM
To: Xu, Wei6 ; devel@edk2.groups.io
Cc: Laszlo Ersek ; Ard Biesheuvel
; Sami Mujawar
Subject: RE:
77 matches
Mail list logo
