Re: [edk2-devel] [PATCH v2 1/1] MdePkg/BaseLib: Fix AARCH64 compilation error

2024-03-28 Thread Adam Liu
Hello all, The patch was reviewed and I submitted a pull request https://github.com/tianocore/edk2/pull/5482 for this patch. Is there any other requirement to let this patch merge into master? Regards, Adam -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group.

Re: [edk2-devel] [PATCH] SecurityPkg/Tcg2Config: Hide BIOS unsupported hash algorithm from UI

2024-03-28 Thread Kumar, Rahul R
Looks good. Reviewed-by: Rahul Kumar -Original Message- From: devel@edk2.groups.io On Behalf Of Xu, Wei6 Sent: Monday, March 18, 2024 8:41 AM To: devel@edk2.groups.io Cc: Xu, Wei6 ; Kumar, Rahul R ; Yao, Jiewen Subject: [edk2-devel] [PATCH] SecurityPkg/Tcg2Config: Hide BIOS

Re: [edk2-devel] [PATCH] SecurityPkg/Tcg2Config: Hide BIOS unsupported hash algorithm from UI

2024-03-28 Thread rahul . r . kumar
Reviewed-by: Rahul Kumar < rahul1.ku...@intel.com > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117227): https://edk2.groups.io/g/devel/message/117227 Mute This Topic: https://groups.io/mt/105005532/21656 Group Owner:

Re: [edk2-devel] [PATCH 0/3] CryptoPkg: Optimize APIs in BaseCryptLibMbedTls

2024-03-28 Thread Li, Yi
For this patch set: Looks good to me. Reviewed-by: Yi Li -Original Message- From: Hou, Wenxing Sent: Friday, March 29, 2024 10:33 AM To: devel@edk2.groups.io Cc: Yao, Jiewen ; Li, Yi1 Subject: [PATCH 0/3] CryptoPkg: Optimize APIs in BaseCryptLibMbedTls

Re: [edk2-devel] Attempting to update to latest Repository Won't Build.

2024-03-28 Thread Adam Liu
In Acme\Acme.dsc, find [LibraryClasses] and add below line should fix the problem. RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf Regards, Adam -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117225):

[edk2-devel] [PATCH v1] MdePkg: Adds a PCD to define IPMI interface type

2024-03-28 Thread Abdul Lateef Attar via groups.io
Define IPMI interface type as per specification version 2.0, section C1-1.1. Cc: Abner Chang Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Abdul Lateef Attar --- MdePkg/MdePkg.dec | 9 + 1 file changed, 9 insertions(+) diff --git a/MdePkg/MdePkg.dec

[edk2-devel] [PATCH 3/3] CryptoPkg: Remove interdependence for RsaPssVerify

2024-03-28 Thread Wenxing Hou
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4742 Remove interdependence for RsaPssVerify, only use original mbedtls API. Because APIs such as Sha512Init may be closed by the platform PCD. And this patch optimize the hash flow. Cc: Jiewen Yao Cc: Yi Li Signed-off-by: Wenxing Hou ---

[edk2-devel] [PATCH 2/3] CryptoPkg: Update Md5/Sha1/Sha2 by using new mbedtls api

2024-03-28 Thread Wenxing Hou
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4741 Update Md5/Sha1/Sha2 by using mbedtls 3.0 api in BaseCryptLibMbedTls, because the old API may be deprecated when open some MACRO. Cc: Jiewen Yao Cc: Yi Li Signed-off-by: Wenxing Hou --- .../Library/BaseCryptLibMbedTls/Hash/CryptMd5.c |

[edk2-devel] [PATCH 1/3] CryptoPkg: Update OPTIONAL location for BaseCryptLibMbedTls

2024-03-28 Thread Wenxing Hou
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4740 There is a wrong usage for OPTIONAL. Cc: Jiewen Yao Cc: Yi Li Signed-off-by: Wenxing Hou --- .../Library/BaseCryptLibMbedTls/Pk/CryptPkcs1OaepNull.c | 6 ++ CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptX509Null.c| 6 ++

[edk2-devel] [PATCH 0/3] CryptoPkg: Optimize APIs in BaseCryptLibMbedTls

2024-03-28 Thread Wenxing Hou
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4740 REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4741 REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4742 These patch will fix OPTIONAL location and update hash implementation and remove the interdependence for RsaPssVerify. And these

Re: [edk2-devel] [PATCH v2 00/13] Part 2 patch set to add LoongArch support into UefiCpuPkg

2024-03-28 Thread Chao Li
Hi Ray, I guess you are very busy recently. If you see this mail, please reply to me, can I can still use the low-high level libraries solution in next commit? Thanks, Chao On 2024/3/26 09:32, Chao Li wrote: Hi Ray, I responded your comments yesterday, it looks like we have different

Re: 回复: [edk2-devel] [PATCH v2 0/2] Update BaseTools NULL Include and Library Matching

2024-03-28 Thread Taylor Beebe
Hi Liming, Each patch describes the issue being fixed with an example. I created a bugzilla and assigned it to me for Patch 1: https://bugzilla.tianocore.org/show_bug.cgi?id=4744 GitHub PR: https://github.com/tianocore/edk2/pull/5365 Thanks :) -Taylor On 3/27/24 6:00 PM, gaoliming wrote:

Re: [edk2-devel] test message - my messages aren't showing up?

2024-03-28 Thread Andrew Fish via groups.io
David, You have to be subscribed to the list for the mails to got directly to the list. I think you just subscribed so I had to clear you as OK to post. Basically your posts were going to moderation and a human had to approve them. Thanks, Andrew Fish > On Mar 28, 2024, at 9:48 AM, David F.

[edk2-devel] Attempting to update to latest Repository Won't Build.

2024-03-28 Thread David F.
Hello, I was still on the SVN version (from 2019) and using VS2008. It would build fine. I created a new dir to use GIT now, I updated, ran: edksetup Reconfig Rebuild VS2019 So now, everything seems setup. I exit the command prompt, open it again, run my prep.bat script like I always did

[edk2-devel] test message - my messages aren't showing up?

2024-03-28 Thread David F.
I noticed the daily summary doesn't have my questions .. this is a test, can someone reply direct to confirm. Thanks. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117216): https://edk2.groups.io/g/devel/message/117216 Mute This Topic:

Re: [edk2-devel] [Patch V4] BaseTools: VfrCompiler Adds DefaultValueError

2024-03-28 Thread Zhang, Zifeng
Thanks Yuting for patch update! Hi @gaoliming, Would you like to review the V4 patch? Hope to merge it asap to avoid blocking feature complete. Best Regards, Zifeng -Original Message- From: Yang, Yuting2 Sent: Thursday, March 21, 2024 3:54 PM To: devel@edk2.groups.io; gaoliming Cc:

Re: [edk2-devel] [PATCH] SG2042Pkg/Sec:Modify Calculation LowestMemSize

2024-03-28 Thread Jingyu Li via groups.io
I have verified the above patch on the SG2042 platform. I agree with your understanding of the LowestMemBase. Best Regards, Jingyu -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117213): https://edk2.groups.io/g/devel/message/117213

Re: [edk2-devel] [PATCH v4 1/1] SbsaQemu: AcpiDxe: Create SRAT table at runtime

2024-03-28 Thread Leif Lindholm
On Thu, Mar 28, 2024 at 06:19:35 +, Xiong Yining wrote: > Add support to create SRAT(System resource affinity table) for > sbsa platform at runtime. > > Signed-off-by: Xiong Yining > Reviewed-by: Marcin Juszkiewicz > Reviewed-by: Leif Lindholm You are not supposed to add Reviewed-by: or

Re: [edk2-devel] [PATCH v4 1/1] SbsaQemu: AcpiDxe: Create SRAT table at runtime

2024-03-28 Thread Marcin Juszkiewicz
W dniu 28.03.2024 o 07:19, Xiong Yining pisze: Add support to create SRAT(System resource affinity table) for sbsa platform at runtime. Signed-off-by: Xiong Yining Reviewed-by: Marcin Juszkiewicz Reviewed-by: Leif Lindholm When you send a new version of patch, with changes done compared to

Re: [edk2-devel] [PATCH v4 1/1] SbsaQemu: add memory space for the high memory nodes

2024-03-28 Thread Leif Lindholm
On Wed, Mar 27, 2024 at 14:01:43 +, Xiong Yining wrote: > To support more memory nodes, we refer to the implement of > "OvmfPkg/Fdt/HighMemDxe" to add memory space for the high memory nodes > except the first one. "HighMem" doesn't really make sense outside x86. But I also don't want to delay

Re: [edk2-devel] [PATCH v11 2/4] Platform/SbsaQemu: use SbsaQemuHardwareInfoLib for cpu information

2024-03-28 Thread Leif Lindholm
On Thu, Mar 28, 2024 at 07:46:28 +, Xiong Yining wrote: > From: Marcin Juszkiewicz > > We have SbsaQemuHardwareInfoLib to ask for hardware details. No need to > parse DeviceTree anymore. > > Signed-off-by: Marcin Juszkiewicz > Signed-off-by: Xiong Yining > Reviewed-by: Leif Lindholm >

[edk2-devel] [PATCH v4 5/5] DynamicTablesPkg: Adds X64 arch MADT Table generator

2024-03-28 Thread Abdul Lateef Attar via groups.io
Adds X64 architecture specific MADT/APIC Table generator. Register/Deregister MADT table. Adds X64 architecture namespace objects. Cc: Sami Mujawar Cc: Pierre Gondois Signed-off-by: Abdul Lateef Attar --- DynamicTablesPkg/DynamicTables.dsc.inc| 6 +

[edk2-devel] [PATCH v4 4/5] DynamicTablesPkg: Adds ACPI SSDT HPET Table generator

2024-03-28 Thread Abdul Lateef Attar via groups.io
Adds generic ACPI SSDT HPET table generator library. Register/Deregister HPET table. Adds ACPI namespace object for HPET device. Adds Address space for HPET device. Cc: Sami Mujawar Cc: Pierre Gondois Signed-off-by: Abdul Lateef Attar --- DynamicTablesPkg/DynamicTables.dsc.inc| 2 +

[edk2-devel] [PATCH v4 1/5] DynamicTablesPkg: Adds ACPI FADT Table generator

2024-03-28 Thread Abdul Lateef Attar via groups.io
Adds generic ACPI FADT table generator library. Register/Deregister FADT table. Adds Arch namespace ids. Update the FADT table during boot as per specification. Cc: Sami Mujawar Cc: Pierre Gondois Signed-off-by: Abdul Lateef Attar --- DynamicTablesPkg/DynamicTables.dsc.inc| 10 +-

[edk2-devel] [PATCH v4 3/5] DynamicTablesPkg: Adds ACPI WSMT Table generator

2024-03-28 Thread Abdul Lateef Attar via groups.io
Adds generic ACPI WSMT table generator library. Register/Deregister WSMT table. Update the WSMT table during boot as per specification. Cc: Sami Mujawar Cc: Pierre Gondois Signed-off-by: Abdul Lateef Attar --- DynamicTablesPkg/DynamicTables.dsc.inc| 2 +

[edk2-devel] [PATCH v4 2/5] DynamicTablesPkg: Adds ACPI HPET Table generator

2024-03-28 Thread Abdul Lateef Attar via groups.io
Adds generic ACPI HPET table generator library. Register/Deregister HPET table. Update the HPET table during boot as per specification. Cc: Sami Mujawar Cc: Pierre Gondois Signed-off-by: Abdul Lateef Attar --- DynamicTablesPkg/DynamicTables.dsc.inc| 2 +

[edk2-devel] [PATCH v4 0/5] DynamicTablesPkg: Adds FADT, HPET, WSMT and MADT Table generators

2024-03-28 Thread Abdul Lateef Attar via groups.io
PR: https://github.com/tianocore/edk2/pull/5500/ V4: delta changes Added X64 arch specific MADT table generator. V3: delta changes Restructure the code as the review comments. Added sanity check for WSMT flags. Added CM object for HPET base address. V2: delta changes Addressed review

[edk2-devel] [edk2-platforms] MinPlatformPkg: Corret AcpiProcessorUid in MADT

2024-03-28 Thread duntan
Change AcpiProcessorUid in CpuApicIdOrderTable to the Index value in MP service regardless of diabled fore. Let take a simple example: CORE number APICID Index in MpService CORE0 0x_ 0 CORE1(Disabled) 0x_0010 1 CORE2 0x_0040

[edk2-devel] [edk2-platforms] MinPlatformPkg: Sort ApicIdOrderTable by special rules

2024-03-28 Thread duntan
Sort ApicIdOrderTable by following special rules: 1. Make sure BSP is the first entry. 2. For APs, big core first, then small core. 3. For APs, if the core type are the same, sort them by AcpiProcessorUid. With this implementation, BIOS can present cores in order of relative performance in

[edk2-devel] [PATCH v11 3/4] Platform/SbsaQemu: get the information of memory via SMC calls

2024-03-28 Thread Xiong Yining
Provide functions to check for memory information: - amount of memory nodes - memory address - NUMA node id for memory Values are read from TF-A using platform specific SMC calls. Signed-off-by: Xiong Yining Signed-off-by: Marcin Juszkiewicz Reviewed-by: Ard Biesheuvel Reviewed-by: Leif

[edk2-devel] [PATCH v10 0/4] get rid of DeviceTree from SbsaQemu

2024-03-28 Thread Xiong Yining
We want to stop parsing DeviceTree to gather hardware information. Instead we ask TF-A for those details using SMC calls. On real hardware platform it could be asking on-board Embedded Controller. Hardware information (CPU, Memory) is now in SbsaQemuHardwareInfoLib together with new code for

[edk2-devel] [PATCH v11 4/4] Platform/SbsaQemu: drop use of DeviceTree

2024-03-28 Thread Xiong Yining
From: Marcin Juszkiewicz There is no need for EDK2 to know that there is DeviceTree around. All hardware information is read using functions from SbsaQemuHardwareInfoLib library. Signed-off-by: Marcin Juszkiewicz Signed-off-by: Xiong Yining Reviewed-by: Leif Lindholm ---

[edk2-devel] [PATCH v11 1/4] Platform/SbsaQemu: add SbsaQemuHardwareInfoLib

2024-03-28 Thread Xiong Yining
From: Marcin Juszkiewicz This library provides functions to check for hardware information. For now it covers CPU ones: - amount of cpu cores - MPIDR value for cpu core - NUMA node id for cpu core Values are read from TF-A using platform specific SMC calls. Signed-off-by: Marcin Juszkiewicz

[edk2-devel] [PATCH v11 2/4] Platform/SbsaQemu: use SbsaQemuHardwareInfoLib for cpu information

2024-03-28 Thread Xiong Yining
From: Marcin Juszkiewicz We have SbsaQemuHardwareInfoLib to ask for hardware details. No need to parse DeviceTree anymore. Signed-off-by: Marcin Juszkiewicz Signed-off-by: Xiong Yining Reviewed-by: Leif Lindholm --- .../Qemu/SbsaQemu/OemMiscLib/OemMiscLib.inf | 6 ++

Re: [edk2-devel] [PATCH v2 1/1] MdeModulePkg/AcpiTableDxe: PCD switch to avoid using ACPI reclaim memory

2024-03-28 Thread Aaron Li
Hi Ard, We have a feature that requires to publish all ACPI table in EfiAcpiMemoryNVS. Currently only table "FACS" and "UEFI" was published in NVS memory. Best, Aaron -Original Message- From: devel@edk2.groups.io On Behalf Of Ard Biesheuvel Sent: Thursday, March 28, 2024 1:59 PM To:

Re: [edk2-devel] [edk2-redfish-client][PATCH V5 1/2] RedfishClientPkg: Set SettingsObject URI as the config language

2024-03-28 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi @Mike Maslenkin, would you like to review this patch again as I addressed your comments in V5 patch set. Thanks Abner > -Original Message- > From: Nickle Wang > Sent: Tuesday, March 26, 2024 8:14 PM > To: Chang, Abner ; devel@edk2.groups.io > Cc:

[edk2-devel] [PATCH v4 1/1] SbsaQemu: AcpiDxe: Create SRAT table at runtime

2024-03-28 Thread Xiong Yining
Add support to create SRAT(System resource affinity table) for sbsa platform at runtime. Signed-off-by: Xiong Yining Reviewed-by: Marcin Juszkiewicz Reviewed-by: Leif Lindholm --- .../Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.h | 27 ++ .../Include/Library/HardwareInfoLib.h | 10 ++

[edk2-devel] [PATCH v4 0/1] Add support for generating SRAT tables

2024-03-28 Thread Xiong Yining
SbsaQemu can configure with numa-related arguments, but OS cannot identify the numa architecture without SRAT tables. We add supporting for generating SRAT tables at runtime to solve this issue. the numa-related information and memory information can be obtained via SMC calls which is provided on