[AMD Official Use Only - General]
Hi Nickle,
See my comments in line.
Thanks
Abner
> -Original Message-
> From: Nickle Wang
> Sent: Tuesday, September 12, 2023 11:10 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
>
> Subject: [edk2-redfish-client][PATCH]
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Thursday, September 14, 2023 1:06 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Nickle Wang
> ; Igor Kulchytskyy
> Subject: [PATCH v2 1/7]
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Igor Kulchytskyy
> Sent: Wednesday, September 13, 2023 3:07 AM
> To: Nickle Wang ; devel@edk2.groups.io
> Cc: Chang, Abner ; Nick Ramirez
>
> Subject: RE: [EXTERNAL] [PATCH v2 1/1]
>
[AMD Official Use Only - General]
See my answer below,
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of
> Konstantin Aladyshev via groups.io
> Sent: Friday, September 1, 2023 12:02 AM
> To: Chang, Abner
> Cc: devel@edk2.groups.io; disc...@edk2.groups.io
> Subject: Re:
[AMD Official Use Only - General]
Hi Aladyshev,
> -Original Message-
> From: Konstantin Aladyshev
> Sent: Wednesday, August 30, 2023 11:09 PM
> To: Chang, Abner
> Cc: disc...@edk2.groups.io; devel@edk2.groups.io
> Subject: Re: [edk2-discuss] PLDM messages via MCTP over KCS
>
> Caution:
[AMD Official Use Only - General]
Yes Nickle,
I agree to have a common API for initializing the structure members.
Thanks
Abner
From: Nickle Wang
Sent: Wednesday, August 30, 2023 9:48 AM
To: Mike Maslenkin ; devel@edk2.groups.io; Chang,
Abner
Cc: ig...@ami.com
Subject: RE: [PATCH v2 1/6]
[AMD Official Use Only - General]
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of
> Konstantin Aladyshev via groups.io
> Sent: Thursday, August 31, 2023 10:57 PM
> To: Chang, Abner
> Cc: disc...@edk2.groups.io; devel@edk2.groups.io
> Subject: Re: [edk2-devel]
[AMD Official Use Only - General]
But wait, wee my another comment below,
> -Original Message-
> From: Chang, Abner
> Sent: Thursday, August 31, 2023 11:42 PM
> To: devel@edk2.groups.io; aladyshe...@gmail.com
> Cc: disc...@edk2.groups.io
> Subject: RE: [edk2-devel] [edk2-discuss] PLDM
at
this version.
Thanks
Abner
> -Original Message-
> From: disc...@edk2.groups.io On Behalf Of
> Chang, Abner via groups.io
> Sent: Saturday, October 14, 2023 5:11 PM
> To: Konstantin Aladyshev
> Cc: disc...@edk2.groups.io; devel@edk2.groups.io
> Subject: Re: [edk2-devel] [edk2-d
Oct 17, 2023 at 6:41 AM Chang, Abner
> wrote:
> >
> > [AMD Official Use Only - General]
> >
> > Hi Aladyshev,
> > I had updated code according to our discussion on PLDM over MCTP, please
> take a look at https://github.com/changab/edk2-
> platforms/tree/MCTP_OVER_
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Mike Maslenkin
> Sent: Friday, October 27, 2023 7:54 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; nick...@nvidia.com;
> ig...@ami.com; Mike Maslenkin
> Subject: [edk2-redfish-client][PATCH v2
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Mike Maslenkin
> Sent: Friday, October 27, 2023 7:54 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; nick...@nvidia.com;
> ig...@ami.com; Mike Maslenkin
> Subject: [edk2-redfish-client][PATCH v2
l@edk2.groups.io On Behalf Of Chang,
> Abner via groups.io
> Sent: Wednesday, October 18, 2023 12:53 PM
> To: devel@edk2.groups.io; Chang, Abner
> Cc: Attar, AbdulLateef (Abdul Lateef) ; Isaac
> Oram ; Nickle Wang ; Nate
> DeSimone ; Liming Gao
>
> Subject: Re: [edk2-dev
[AMD Official Use Only - General]
> -Original Message-
> From: Mike Maslenkin
> Sent: Friday, October 27, 2023 7:51 AM
> To: Chang, Abner
> Cc: devel@edk2.groups.io; nick...@nvidia.com; ig...@ami.com
> Subject: Re: [PATCH 9/9] RedfishClientPkg: fix StrnCpyS arguments
>
> Caution: This
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Wednesday, October 25, 2023 6:25 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
> ; Nick Ramirez ; Mike Maslenkin
>
> Subject: [PATCH v2]
[AMD Official Use Only - General]
Merged. I will send another patch for Uncrustify updates if any.
Abner
> -Original Message-
> From: Chang, Abner
> Sent: Tuesday, October 24, 2023 10:44 AM
> To: Konstantin Aladyshev ; devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul Lateef) ;
>
[AMD Official Use Only - General]
Ah sorry. Please ignore this. The patch is 0/3.
Abner
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chang,
> Abner via groups.io
> Sent: Thursday, October 26, 2023 1:40 PM
> To: Nickle Wang ; devel@edk2.groups.io
> Cc
[AMD Official Use Only - General]
Hi Nickle,
Seems no differences in this patch.
Abner
> -Original Message-
> From: Nickle Wang
> Sent: Tuesday, October 24, 2023 4:39 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
> ; Nick Ramirez
> Subject: [PATCH 0/3]
[AMD Official Use Only - General]
Here it is https://edk2.groups.io/g/devel/topic/101587129#109614
> -Original Message-
> From: Pedro Falcato
> Sent: Thursday, October 26, 2023 2:10 AM
> To: devel@edk2.groups.io; ler...@redhat.com
> Cc: Attar, AbdulLateef (Abdul Lateef) ; Chang,
> Abner
[AMD Official Use Only - General]
Sure, thanks for this change.
Reviewed-by: Abner Chang mailto:abner.ch...@amd.com>>
From: Nickle Wang
Sent: Wednesday, November 1, 2023 8:53 AM
To: Mike Maslenkin ; devel@edk2.groups.io; Chang,
Abner
Cc: Igor Kulchytskyy ; Nick Ramirez
Subject: RE:
, Abner:
Got it, Thanks.
Is there any plan to implement MTCP-over-smbus or MTCP-over-PCIE ?
Thanks
At 2023-10-31 15:00:03, "Chang, Abner via groups.io"
mailto:abner.chang=amd@groups.io>> wrote:
MCTP over KCS defines two types of KCS-like access, one is compatible with IP
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Thursday, October 26, 2023 4:35 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
> ; Nick Ramirez
> Subject: [edk2-redfish-client][PATCH]
]
>
> Hi Nate and Liming,
> Please help to review this patch.
>
> Thanks
> Abner
>
> > -Original Message-----
> > From: devel@edk2.groups.io On Behalf Of Chang,
> > Abner via groups.io
> > Sent: Tuesday, October 10, 2023 4:22 PM
> > To: devel@edk2
[AMD Official Use Only - General]
Hi Gong,
Please note that your code may have conflict as IpmiCommandLib was removed
(please check https://edk2.groups.io/g/devel/message/109510), now we are using
the one under MdeModulePKg.
Second, I had cleaned up those server management feature drivers and
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Tuesday, October 31, 2023 3:45 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
> ; Nick Ramirez
> Subject: [edk2-redfish-client][PATCH 2/3]
>
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Tuesday, October 31, 2023 3:45 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
> ; Nick Ramirez
> Subject: [edk2-redfish-client][PATCH 1/3]
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Tuesday, October 31, 2023 3:45 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
> ; Nick Ramirez
> Subject: [edk2-redfish-client][PATCH 3/3]
>
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Wei6 Xu
> Sent: Tuesday, October 31, 2023 11:08 AM
> To: devel@edk2.groups.io
> Cc: Wei6 Xu ; Chang, Abner ;
> Nate DeSimone ; Liming Gao
>
> Subject: [PATCH edk2-platforms 1/1]
[AMD Official Use Only - General]
Only one comment in line.
> -Original Message-
> From: Igor Kulchytskyy
> Sent: Thursday, November 2, 2023 4:18 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Nickle Wang
> ; Mike Maslenkin
> Subject: [PATCH v2] RedfishPkg: RedfishDiscoverDxe: Fix
[AMD Official Use Only - General]
I would say to have static for a function used by module is a good coding
practice and reduce the compile errors for the duplicated function naming, and
maybe other advantages I am not quite sure.
But from edk2 C coding standard spec perspective, in 5.4.2.2.2,
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Igor Kulchytskyy
> Sent: Tuesday, November 7, 2023 8:06 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Nickle Wang
>
> Subject: [PATCH v3] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4
>
[AMD Official Use Only - General]
Hi Nate and Liming,
Please check this patch. The one under IpmiFeaturePkg is an old one, we should
remove it to avoid the confusions.
Thanks
Abner
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chang,
> Abner via groups.
[AMD Official Use Only - General]
> -Original Message-
> From: Lixia Huang
> Sent: Tuesday, October 31, 2023 2:00 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Nate DeSimone
>
> Subject: [PATCH v3 1/1] IpmiFeaturePkg/GenericIpmi: Support Standalone
> MM
>
> Caution: This message
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
I can help to merge this change if maintainer or review have no problem with
it, as I am not any of those.
Abner
> -Original Message-
> From: Lixia Huang
> Sent: Tuesday, October 31, 2023 2:24 PM
> To: devel@edk2.groups.io
>
MCTP-over-KCS feature require some special LPC interface hardware changes?
Or, MCTP is just a software stack and it uses current LPC interface, not any
special hardward design change requirement.
Thanks
At 2023-10-26 13:03:02, "Chang, Abner via groups.io"
mailto:abner
[AMD Official Use Only - General]
Hi Lisa, please check the comments in line.
> -Original Message-
> From: Lixia Huang
> Sent: Monday, October 30, 2023 9:20 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Nate DeSimone
>
> Subject: [PATCH v2 1/1] IpmiFeaturePkg/GenericIpmi: Support
From: Abner Chang
Remove IpmiCommandLib from IpmiFeaturePkg as ManageabilityPkg
already had one and is newer.
Signed-off-by: Abner Chang
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Chasel Chiu
Cc: Li-Xia Huang
Cc: Abdul Lateef Attar
Cc: Nickle Wang
---
.../IpmiFeaturePkg/IpmiFeaturePkg.dec
Acked-by: Abner Chang
Still need Abdul's RB.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110290): https://edk2.groups.io/g/devel/message/110290
Mute This Topic: https://groups.io/mt/102269908/21656
Group Owner:
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Tuesday, October 24, 2023 4:39 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
> ; Nick Ramirez
> Subject: [PATCH 1/3] RedfishPkg/RedfishLib: introduce new
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Tuesday, October 24, 2023 4:39 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
> ; Nick Ramirez
> Subject: [PATCH 2/3] RedfishPkg/libredfish: introduce new
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Tuesday, October 24, 2023 4:40 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
> ; Nick Ramirez
> Subject: [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP
[AMD Official Use Only - General]
Yes, I know. Just letting you know there are some non industry standard common
code in this package and you probably can give some clarifications.
Sure, I am looking at the patch now.
Abner
> -Original Message-
> From: Huang, Li-Xia
> Sent:
From: Abner Chang
Run Uncrustify on the C source files those were
modified in commit ID from 3f4c4384 to 28ff8f29.
Signed-off-by: Abner Chang
Cc: Abdul Lateef Attar
Cc: Nickle Wang
Cc: Konstantin Aladyshev
---
.../Include/Library/BasePldmProtocolLib.h | 6 ++---
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Thursday, November 2, 2023 6:18 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
> ; Nick Ramirez
> Subject: [edk2-redfish-client][PATCH 1/2]
[AMD Official Use Only - General]
Looks good, you can move EDKII_REDFISH_OVERRIDE_PROTOCOL *RedfishOverride
from local variable to global variable and locate this protocol only once if
there are more than one use cases of Redfish override protocol in
RedfishFeatureCore in the future.
Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> On 10/19/23 07:43, Chang, Abner via groups.io wrote:
> > From: Abner Chang
> >
> > - Add two entries of MdePkg and MdeModulePkg for
> > manageability modules and files.
> &
From: Abner Chang
- Add entry of MdePkg for manageability industry
standard C header files.
- Add entry of MdeModulePkg for manageability modules
and files.
- Add entry of UefiCpuPkg for AMD implementation.
This change will be merged with at least one steward and
at lease one maintainer or
From: Abner Chang
- Add two entries of MdePkg and MdeModulePkg for
manageability modules and files.
- Add one entry of UefiCpuPkg AMD related files.
Signed-off-by: Abner Chang
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Abdul Lateef Attar
Cc: Nickle Wang
Cc: Jian J Wang
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Monday, September 18, 2023 9:13 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
> ; Nick Ramirez ; Mike Maslenkin
>
> Subject: [PATCH v2]
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Thursday, September 21, 2023 8:56 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
> ; Nick Ramirez
> Subject: [PATCH v2] RedfishPkg/JsonLib: fix
[AMD Official Use Only - General]
Thank you Nickle. RB is given to that patch.
Abner
> -Original Message-
> From: Nickle Wang
> Sent: Thursday, September 21, 2023 9:00 PM
> To: Chang, Abner ; Igor Kulchytskyy
> ; devel@edk2.groups.io
> Cc: Nick Ramirez
> Subject: RE: [EXTERNAL]
Hi Eric,
As the file naming is defined in the edk2 C coding standard, the AMD
terminology used in the file name should follow edk2 C coding standard. Such as
APCB should be Acpb, ABSupportNvramPei should be AbSupportNvnamePei.
Could you please review all of the files in this patch?
Thanks
Abner
Hi Eric,
You don't need the description follow "PATCH" actually, this makes the commit
subject too lone. It is better to keep the subject short. You can put the
detail information in the commit message body.
Thanks
Abner
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent
[AMD Official Use Only - General]
Hi Aladyshev,
Yes, this is my next task starts from next week.
Thanks
Abner
> -Original Message-
> From: Konstantin Aladyshev
> Sent: Friday, September 29, 2023 2:18 AM
> To: Chang, Abner
> Cc: devel@edk2.groups.io; disc...@edk2.groups.io
> Subject:
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Xing, Eric
> Sent: Friday, September 29, 2023 1:07 AM
> To: devel@edk2.groups.io
> Cc: Michael D Kinney ; Chang, Abner
> ; Leif Lindholm ; Attar,
> AbdulLateef (Abdul Lateef)
> Subject:
[AMD Official Use Only - General]
Hi Leif,
We have done the review on these patches.
Are you the steward of this repo and able to grant AMD folks the merge
privilege? To Eric, Abdul and me.
Btw, do we have to create a PR against non OSI repo for merging or we can just
push it?
Thanks
Abner
[AMD Official Use Only - General]
Hi Leif,
> -Original Message-
> From: Leif Lindholm
> Sent: Friday, September 29, 2023 6:49 PM
> To: Chang, Abner
> Cc: Xing, Eric ; devel@edk2.groups.io; Michael D Kinney
> ; Attar, AbdulLateef (Abdul Lateef)
>
> Subject: Re:
; when opening attachments, clicking links, or responding.
>
>
> On Fri, Sep 29, 2023 at 14:52:23 +, Chang, Abner via groups.io wrote:
> > > -Original Message-
> > > From: Leif Lindholm
> > > Sent: Friday, September 29, 2023 6:49 PM
> > > To: Chan
[AMD Official Use Only - General]
That makes sense.
Reviewed-by: Abner Chang
> -Original Message-
> From: Mike Maslenkin
> Sent: Saturday, September 30, 2023 5:59 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; nick...@nvidia.com;
> ig...@ami.com; Mike Maslenkin
> Subject: [PATCH
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Mike Maslenkin
> Sent: Saturday, September 30, 2023 5:59 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; nick...@nvidia.com;
> ig...@ami.com; Mike Maslenkin
> Subject: [PATCH 7/9]
[AMD Official Use Only - General]
Patch set Reviewed-by: Abner Chang
> -Original Message-
> From: Mike Maslenkin
> Sent: Saturday, September 30, 2023 6:24 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; nick...@nvidia.com;
> ig...@ami.com; Mike Maslenkin
> Subject: [RFC][PATCH
[AMD Official Use Only - General]
Hi Mike,
I can't apply the entire patch set from either outlook or Group.io. The format
of patch on both are looked weird. I can still review the short ones, but the
change of 5/9 is a bit long one. Could you please check the patch format and
resend 5/9? Thank
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Mike Maslenkin
> Sent: Saturday, September 30, 2023 5:59 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; nick...@nvidia.com;
> ig...@ami.com; Mike Maslenkin
> Subject: [PATCH 2/9]
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Mike Maslenkin
> Sent: Saturday, September 30, 2023 5:59 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; nick...@nvidia.com;
> ig...@ami.com; Mike Maslenkin
> Subject: [PATCH 1/9]
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Mike Maslenkin
> Sent: Saturday, September 30, 2023 5:59 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; nick...@nvidia.com;
> ig...@ami.com; Mike Maslenkin
> Subject: [PATCH 6/9]
[AMD Official Use Only - General]
> -Original Message-
> From: Mike Maslenkin
> Sent: Saturday, September 30, 2023 5:59 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; nick...@nvidia.com;
> ig...@ami.com; Mike Maslenkin
> Subject: [PATCH 8/9] RedfishClientPkg: fix pragma pack usage
>
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Mike Maslenkin
> Sent: Saturday, September 30, 2023 5:59 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; nick...@nvidia.com;
> ig...@ami.com; Mike Maslenkin
> Subject: [PATCH 4/9]
[AMD Official Use Only - General]
> -Original Message-
> From: Mike Maslenkin
> Sent: Saturday, September 30, 2023 5:59 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; nick...@nvidia.com;
> ig...@ami.com; Mike Maslenkin
> Subject: [PATCH 9/9] RedfishClientPkg: fix StrnCpyS arguments
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Mike Maslenkin
> Sent: Saturday, September 30, 2023 5:59 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; nick...@nvidia.com;
> ig...@ami.com; Mike Maslenkin
> Subject: [PATCH 3/9] RedfishLib:
[AMD Official Use Only - General]
Never mind, I see you had created a PR for this. However, we need
@nick...@nvidia.com to check if the code logic is kept the same with this
change.
Thank you for helping on this package, Mike.
Abner
> -Original Message-
> From: Chang, Abner
> Sent:
[AMD Official Use Only - General]
Thanks!
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Tuesday, October 3, 2023 8:02 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
>
> Subject: [edk2-redfish-client][PATCH v2] RedfishClientPkg: update
[AMD Official Use Only - General]
Hi Aladyshev,
I have updated the change you made and put those code on below link,
https://github.com/changab/edk2-platforms/commit/1c8d0d3fa403b47a34667f7f690add7822163111
I combined MCTP over KCS changes and IPMI over KCS functionality in
KcsCommonLib.c. I
[AMD Official Use Only - General]
Hi Nickle,
As we may use a protocol that provide the JSON interface for other packages or
drivers, could you please have a comment around the hardcoded number says the
hardcoded number would be removed when we have a protocol on top of jansson
lib? People can
[AMD Official Use Only - General]
Hi Aladyshev,
Thanks for providing the details, I will take a look at your code first,
implement it at my end and then response to your question.
Abner
> -Original Message-
> From: Konstantin Aladyshev
> Sent: Friday, September 8, 2023 8:57 PM
> To:
[AMD Official Use Only - General]
> -Original Message-
> From: disc...@edk2.groups.io On Behalf Of
> Konstantin Aladyshev via groups.io
> Sent: Thursday, October 5, 2023 1:57 AM
> To: Chang, Abner
> Cc: devel@edk2.groups.io; disc...@edk2.groups.io
> Subject: Re: [edk2-devel]
From: Abner Chang
Remove duplicate IpmiCommandLib.h and use the one
under MdeModulePKg instead.
Signed-off-by: Abner Chang
Cc: Abdul Lateef Attar
Cc: Isaac Oram
Cc: Nickle Wang
Cc: Isaac Oram
Cc: Nate DeSimone
---
.../IpmiFeaturePkg/BmcElog/BmcElog.inf| 1 +
From: Abner Chang
Remove duplicate IpmiCommandLib.h and use the one
under MdeModulePKg instead.
Signed-off-by: Abner Chang
Cc: Abdul Lateef Attar
Cc: Isaac Oram
Cc: Nickle Wang
---
.../Universal/IpmiBmcElog/BmcElog.inf | 1 +
.../Universal/IpmiFrb/FrbPei.inf | 1 +
[AMD Official Use Only - General]
Hi maintainers,
Please help to review this.
Thanks
Abner
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chang,
> Abner via groups.io
> Sent: Tuesday, October 10, 2023 4:36 PM
> To: devel@edk2.groups.io
> Cc: Attar,
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Konstantin Aladyshev
> Sent: Monday, October 16, 2023 9:18 PM
> To: devel@edk2.groups.io
> Cc: michael.d.kin...@intel.com; gaolim...@byosoft.com.cn;
> zhiguang@intel.com; Chang, Abner ;
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Konstantin Aladyshev
> Sent: Monday, October 16, 2023 9:18 PM
> To: devel@edk2.groups.io
> Cc: michael.d.kin...@intel.com; gaolim...@byosoft.com.cn;
> zhiguang@intel.com; Chang, Abner ;
[AMD Official Use Only - General]
Hi Nate and Liming,
Please help to review this patch.
Thanks
Abner
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chang,
> Abner via groups.io
> Sent: Tuesday, October 10, 2023 4:22 PM
> To: devel@edk2.groups.io
> Cc:
[AMD Official Use Only - General]
Hi Reviewers,
Please help to review this patch.
Thanks
Abner
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chang,
> Abner via groups.io
> Sent: Tuesday, October 10, 2023 4:22 PM
> To: devel@edk2.groups.io
> Cc:
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chang,
> Abner via groups.io
> Sent: Tuesday, October 10, 2023 4:36 PM
> To: devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul Lateef) ; Jian J
> Wang ; Liming Gao
> Subject: [edk2-devel] [PATCH 2/2] M
[AMD Official Use Only - General]
For entire series, Reviewed-by: Abner Chang
Hi Aladyshev,
Could you please provide the corresponding branch somewhere that contains the
latest version of this patch set? Then I can move forward to merge it after
edk2 portion is merged.
Thanks for this
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Wednesday, October 18, 2023 9:08 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
>
> Subject: [PATCH] RedfishPkg/RedfishDiscoverDxe: introduce
>
From: Abner Chang
Implment AppFn, 0x57 command.
Signed-off-by: Abner Chang
Cc: Abdul Lateef Attar
Cc: Nickle Wang
---
.../IpmiCommandLib/IpmiCommandLibNetFnApp.c | 68 +++
1 file changed, 68 insertions(+)
diff --git
From: Abner Chang
Define the structure for IPMI Get System Interface
Capabilities command (0x57)
Signed-off-by: Abner Chang
Cc: Abdul Lateef Attar
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
---
MdePkg/Include/IndustryStandard/IpmiNetFnApp.h | 8
1 file changed, 8
From: Abner Chang
Define the API for IPMI Get System Interface
Capabilities command (0x57)
Signed-off-by: Abner Chang
Cc: Abdul Lateef Attar
Cc: Jian J Wang
Cc: Liming Gao
---
MdeModulePkg/Include/Library/IpmiCommandLib.h | 17 +
1 file changed, 17 insertions(+)
diff --git
[AMD Official Use Only - General]
Hi Aladyshev,
Here is my response,
1. Shouldn't we update the PLDM protocol's 'PldmSubmit' function to receive
'MctpSrcEID'/'MctpDestEID'.
Yes, I see the use case of EFI shell application. I would like to have the
input parameters similar with
[AMD Official Use Only - General]
https://github.com/tianocore/edk2/pull/4906 is merged.
Abner
> -Original Message-
> From: Nhi Pham
> Sent: Wednesday, October 11, 2023 12:14 PM
> To: Nickle Wang ; Chang, Abner
> ; devel@edk2.groups.io
> Cc: Igor Kulchytskyy
> Subject: Re: [PATCH]
From: Abner Chang
BZ #: 4566
Update Redfish modules to use the small footprint
version of base SortLib by the means of module scoped
subelement . With this the platform
level SortLib (full version) is not impacted if
Redfish.dsc.inc is included in platform DSC.
Signed-off-by: Abner Chang
Cc:
[AMD Official Use Only - General]
Hi Lisa,
Issac was no longer the maintainer of IpmiFeaturePkg as he was retired. Nate
had sent the maintainers update for review.
As the conversation I had with Issac, we all agreed IpmiFeaturePkg should be
deprecated as the IPMI related drivers are now located
[AMD Official Use Only - General]
Add ManageabilityPkg reviewers in CC.
Abner
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Nate
> DeSimone via groups.io
> Sent: Tuesday, September 26, 2023 8:41 AM
> To: devel@edk2.groups.io
> Cc: Isaac Oram ; Chasel Chiu
> ; Michael D
[AMD Official Use Only - General]
> -Original Message-
> From: Konstantin Aladyshev
> Sent: Friday, October 13, 2023 8:16 PM
> To: Chang, Abner
> Cc: disc...@edk2.groups.io; devel@edk2.groups.io
> Subject: Re: [edk2-devel] [edk2-discuss] PLDM messages via MCTP over KCS
>
> Caution: This
[AMD Official Use Only - General]
> -Original Message-
> From: Konstantin Aladyshev
> Sent: Saturday, October 14, 2023 4:26 PM
> To: Chang, Abner
> Cc: disc...@edk2.groups.io; devel@edk2.groups.io
> Subject: Re: [edk2-devel] [edk2-discuss] PLDM messages via MCTP over KCS
>
> Caution:
[AMD Official Use Only - General]
Do we need this many maintainers for ManageabilityPkg? Seems to me we only need
one maintainer as the replacement of Issac.
Also Nate, some of modules under
Features/Intel/OutOfBandManagement/IpmiFeaturePkg were cloned and updated to
ManageabilityPkg. I think
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Joey Vagedes
> Sent: Tuesday, October 24, 2023 1:52 AM
> To: devel@edk2.groups.io
> Cc: Leif Lindholm ; Ard Biesheuvel
> ; Chang, Abner ;
> Daniel Schaefer
> Subject: [PATCH v2 05/12] EmbeddedPkg:
[AMD Official Use Only - General]
For entire V3 and the additional patch 16/16,
Reviewed-by: Abner Chang
I will do the Uncrustify check and merge this patch set once the corresponding
edk2 changes are merged.
Thanks
Abner
> -Original Message-
> From: Konstantin Aladyshev
> Sent:
[AMD Official Use Only - General]
Issac is removed.
Hi Lisa,
These two packages are diverging in IPMI transport (GenricIpmi) and some other
high level drivers such as IpmiCommandLib. I plan to take below actions.
1. Remove IpmiCommandLib from IpmiFeaturePkg, as the IPMI command support in
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Monday, October 23, 2023 10:18 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
> ; Nick Ramirez
> Subject: [PATCH] RedfishPkg/RedfishDiscoverDxe: remove
1 - 100 of 1182 matches
Mail list logo
