REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678
To simplify the implementation the variable Name/GUID has been
changed to "FspNvsBuffer" and gFspNvsBufferVariableGuid
regardless it stores the data from FSP_NON_VOLATILE_STORAGE_HOB2
or FSP_NON_VOLATILE_STORAGE_HOB.
Cc: Nate DeSimone
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678
To simplify the implementation the variable Name/GUID has been
changed to "FspNvsBuffer" and gFspNvsBufferVariableGuid
regardless it stores the data from FSP_NON_VOLATILE_STORAGE_HOB2
or FSP_NON_VOLATILE_STORAGE_HOB.
Cc: Sai Chaganty
Cc:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678
Implementation should search FSP_NON_VOLATILE_STORAGE_HOB2 firstly
and only search FSP_NON_VOLATILE_STORAGE_HOB when former one is not found.
Also added PeiGetLargeVariable () to support the scenarios where the
variable data size is bigger
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678
To simplify the implementation the variable Name/GUID has been
changed to "FspNvsBuffer" and gFspNvsBufferVariableGuid
regardless it stores the data from FSP_NON_VOLATILE_STORAGE_HOB2
or FSP_NON_VOLATILE_STORAGE_HOB.
Cc: Isaac Oram
Cc:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678
To simplify the implementation the variable Name/GUID has been
changed to "FspNvsBuffer" and gFspNvsBufferVariableGuid
regardless it stores the data from FSP_NON_VOLATILE_STORAGE_HOB2
or FSP_NON_VOLATILE_STORAGE_HOB.
Cc: Nate DeSimone
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678
To simplify the implementation the variable Name/GUID has been
changed to "FspNvsBuffer" and gFspNvsBufferVariableGuid
regardless it stores the data from FSP_NON_VOLATILE_STORAGE_HOB2
or FSP_NON_VOLATILE_STORAGE_HOB.
Cc: Isaac Oram
Cc:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678
To simplify the implementation the variable Name/GUID has been
changed to "FspNvsBuffer" and gFspNvsBufferVariableGuid
regardless it stores the data from FSP_NON_VOLATILE_STORAGE_HOB2
or FSP_NON_VOLATILE_STORAGE_HOB.
Cc: Nate DeSimone
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678
Implementation should search FSP_NON_VOLATILE_STORAGE_HOB2 firstly
and only search FSP_NON_VOLATILE_STORAGE_HOB when former one is not found.
Also added PeiGetLargeVariable () to support the scenarios where the
variable data size is bigger
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678
To simplify the implementation the variable Name/GUID has been
changed to "FspNvsBuffer" and gFspNvsBufferVariableGuid
regardless it stores the data from FSP_NON_VOLATILE_STORAGE_HOB2
or FSP_NON_VOLATILE_STORAGE_HOB.
Cc: Nate DeSimone
Esakkithevar
Cc: Liming Gao
Cc: Eric Dong
Signed-off-by: Chasel Chiu
Chasel Chiu (9):
MinPlatformPkg: Support FSP 2.3 FSP_NON_VOLATILE_STORAGE_HOB2.
CometlakeOpenBoardPkg: Use same variable name for FspNvsHob.
KabylakeOpenBoardPkg/AspireVn7Dash572G:Use same variable name for
FspNvsHob
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678
Implementation should search FSP_NON_VOLATILE_STORAGE_HOB2 firstly
and only search FSP_NON_VOLATILE_STORAGE_HOB when former one is not found.
Also added PeiGetLargeVariable () to support the scenarios where the
variable data size is bigger
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678
To simplify the implementation the variable Name/GUID has been
changed to "FspNvsBuffer" and gFspNvsBufferVariableGuid
regardless it stores the data from FSP_NON_VOLATILE_STORAGE_HOB2
or FSP_NON_VOLATILE_STORAGE_HOB.
Cc: Nate DeSimone
Cc:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678
To simplify the implementation the variable Name/GUID has been
changed to "FspNvsBuffer" and gFspNvsBufferVariableGuid
regardless it stores the data from FSP_NON_VOLATILE_STORAGE_HOB2
or FSP_NON_VOLATILE_STORAGE_HOB.
Cc: Nate DeSimone
Cc:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678
To simplify the implementation the variable Name/GUID has been
changed to "FspNvsBuffer" and gFspNvsBufferVariableGuid
regardless it stores the data from FSP_NON_VOLATILE_STORAGE_HOB2
or FSP_NON_VOLATILE_STORAGE_HOB.
Cc: Nate DeSimone
Cc:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678
To simplify the implementation the variable Name/GUID has been
changed to "FspNvsBuffer" and gFspNvsBufferVariableGuid
regardless it stores the data from FSP_NON_VOLATILE_STORAGE_HOB2
or FSP_NON_VOLATILE_STORAGE_HOB.
Cc: Sai Chaganty
Cc:
Hello,
Thanks for all your valuable feedbacks, I have sent V4 to incorporate all of
them, please help to review.
Thanks,
Chasel
> -Original Message-
> From: Chiu, Chasel
> Sent: Friday, October 8, 2021 2:43 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Oram, Isaac
: Rangasai V Chaganty
Cc: Deepika Kethi Reddy
Cc: Kathappan Esakkithevar
Cc: Liming Gao
Cc: Eric Dong
Signed-off-by: Chasel Chiu
Chasel Chiu (9):
MinPlatformPkg: Support FSP 2.3 FSP_NON_VOLATILE_STORAGE_HOB2.
CometlakeOpenBoardPkg: Use same variable name for FspNvsHob.
KabylakeOpenBoardPkg
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678
Implementation should search FSP_NON_VOLATILE_STORAGE_HOB2 firstly
and only search FSP_NON_VOLATILE_STORAGE_HOB when former one is not found.
Also added PeiGetLargeVariable () to support the scenarios where the
variable data size is bigger
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678
To simplify the implementation the variable Name/GUID has been
changed to "FspNvsBuffer" and gFspNvsBufferVariableGuid
regardless it stores the data from FSP_NON_VOLATILE_STORAGE_HOB2
or FSP_NON_VOLATILE_STORAGE_HOB.
Cc: Nate DeSimone
Cc:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678
To simplify the implementation the variable Name/GUID has been
changed to "FspNvsBuffer" and gFspNvsBufferVariableGuid
regardless it stores the data from FSP_NON_VOLATILE_STORAGE_HOB2
or FSP_NON_VOLATILE_STORAGE_HOB.
Cc: Nate DeSimone
Cc:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678
To simplify the implementation the variable Name/GUID has been
changed to "FspNvsBuffer" and gFspNvsBufferVariableGuid
regardless it stores the data from FSP_NON_VOLATILE_STORAGE_HOB2
or FSP_NON_VOLATILE_STORAGE_HOB.
Cc: Nate DeSimone
Cc:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678
To simplify the implementation the variable Name/GUID has been
changed to "FspNvsBuffer" and gFspNvsBufferVariableGuid
regardless it stores the data from FSP_NON_VOLATILE_STORAGE_HOB2
or FSP_NON_VOLATILE_STORAGE_HOB.
Cc: Nate DeSimone
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678
To simplify the implementation the variable Name/GUID has been
changed to "FspNvsBuffer" and gFspNvsBufferVariableGuid
regardless it stores the data from FSP_NON_VOLATILE_STORAGE_HOB2
or FSP_NON_VOLATILE_STORAGE_HOB.
Cc: Sai Chaganty
Cc:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678
To simplify the implementation the variable Name/GUID has been
changed to "FspNvsBuffer" and gFspNvsBufferVariableGuid
regardless it stores the data from FSP_NON_VOLATILE_STORAGE_HOB2
or FSP_NON_VOLATILE_STORAGE_HOB.
Cc: Nate DeSimone
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678
Implementation should search FSP_NON_VOLATILE_STORAGE_HOB2 firstly
and only search FSP_NON_VOLATILE_STORAGE_HOB when former one is not found.
Also added PeiGetLargeVariable () to support the scenarios where the
variable data size is bigger
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678
To simplify the implementation the variable Name/GUID has been
changed to "FspNvsBuffer" and gFspNvsBufferVariableGuid
regardless it stores the data from FSP_NON_VOLATILE_STORAGE_HOB2
or FSP_NON_VOLATILE_STORAGE_HOB.
Cc: Isaac Oram
Cc:
age-
> From: Chiu, Chasel
> Sent: Thursday, October 14, 2021 5:16 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Oram, Isaac W
> ; Desimone, Nathaniel L
> ; Luo, Heng ; Jeremy
> Soller ; Benjamin Doron
> ; Chaganty, Rangasai V
> ; Kethi Reddy, Deepika
> ; Esakk
l L
> ; Zeng, Star ; Chiu,
> Chasel
> Subject: [PATCH] IntelFsp2Pkg: Add support for config editor to handle
> multiple
> UPD
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3692
>
> In several use cases in bootloader, there are multiple instances of UPD with
>
Reviewed-by: Chasel Chiu
> -Original Message-
> From: S, Ashraf Ali
> Sent: Friday, September 24, 2021 7:43 PM
> To: devel@edk2.groups.io
> Cc: S, Ashraf Ali ; Chiu, Chasel
> ;
> Desimone, Nathaniel L ; Zeng, Star
> ; Kuo, Ted ; Duggapu, Chinni B
> ; Chaga
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Wednesday, September 29, 2021 9:03 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel
> Subject: [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Fix Build
>
> Commit
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Wednesday, September 29, 2021 9:03 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Benjamin Doron
>
> Subject: [edk2-platforms] [PATCH V1]
> KabylakeOpenBoardPkg/Aspir
Patch pushed:
https://github.com/tianocore/edk2/commit/f334c5a41dc4702b1c767c6614025aa2f802f9a4
Thanks,
Chasel
> -Original Message-
> From: Zhang, Xiaoqiang
> Sent: Thursday, September 16, 2021 11:45 AM
> To: devel@edk2.groups.io
> Cc: Zhang, Xiaoqiang ; Chiu, Chas
Thanks Nate! I will remove it.
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Saturday, October 2, 2021 6:15 AM
> To: Chiu, Chasel ; devel@edk2.groups.io
> Cc: Ma, Maurice ; Zeng, Star
> Subject: RE: [PATCH] IntelFsp2Pkg: Adopt FSP 2.3 specificati
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3674
Add ExtendedImageRevision in FSP_INFO_HEADER structure, also add
FSP_NON_VOLATILE_STORAGE_HOB2 header.
Cc: Maurice Ma
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
---
IntelFsp2Pkg/Include/Guid/FspHeaderFile.h
Patch pushed:
https://github.com/tianocore/edk2/commit/de9e5b7dc721d4ca319c0455cf83577347e0abef
Thanks,
Chasel
> -Original Message-
> From: S, Ashraf Ali
> Sent: Thursday, December 16, 2021 4:10 PM
> To: devel@edk2.groups.io
> Cc: S, Ashraf Ali ; Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3791
ExtendedImageRevision should be printed when Header revision >= 6.
Cc: Maurice Ma
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
---
IntelFsp2Pkg/FspSecCore/SecFsp.c | 10 +++---
1 file changed, 7 insertions(+), 3
Thanks Ray! I have sent a code review for removing EFIAPI, please help to
review.
Thanks,
Chasel
> -Original Message-
> From: Ni, Ray
> Sent: Monday, December 20, 2021 1:15 PM
> To: S, Ashraf Ali ; devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
>
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3642
Local functions do not need EFIAPI.
Cc: Nate DeSimone
Cc: Star Zeng
Cc: Ray Ni
Cc: Ashraf Ali S
Signed-off-by: Chasel Chiu
---
IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c | 1 -
Patch pushed:
https://github.com/tianocore/edk2/commit/7935be0fbd8f47266e5972f4cba1a1e58505061a
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
> Sent: Tuesday, December 28, 2021 6:58 PM
> To: devel@edk2.groups.io
> Cc: Ch
Patch pushed:
https://github.com/tianocore/edk2/commit/9ec2cc1f3138ef9314314df29fc6ce0aa5e120b9
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
> Sent: Tuesday, December 21, 2021 8:40 AM
> To: devel@edk2.groups.io
> C
Patch pushed:
https://github.com/tianocore/edk2/commit/9a95d11023ac2f2ee49a2958cf80658270442c42
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
> Sent: Tuesday, October 26, 2021 4:06 PM
> To: devel@edk2.groups.io
> Cc: Ch
Thanks Star.
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Zeng, Star
> Sent: Wednesday, October 27, 2021 8:00 PM
> To: devel@edk2.groups.io
> Cc: Zeng, Star ; Ma, Maurice ;
> Desimone, Nathaniel L ; Chiu, Chasel
>
> Subject: [PATCH] IntelFsp2Pkg Spli
imone, Nathaniel L ; Chiu, Chasel
>
> Subject: [PATCH] IntelFsp2Pkg SplitFspBin.py: Correct file name in file header
>
> Cc: Maurice Ma
> Cc: Nate DeSimone
> Cc: Chasel Chiu
> Signed-off-by: Star Zeng
> ---
> IntelFsp2Pkg/Tools/SplitFspBin.py | 2 +-
> 1 file change
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3705
FSP 2.3 has updated FSP_INFO_HEADER to support ExtendedImageRevision
and SplitFspBin.py needs to support it.
Also updated script to display integer value basing on length.
Cc: Maurice Ma
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by:
M
> To: S, Ashraf Ali ; devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star ; Duggapu,
> Chinni B ; Chaganty, Rangasai V
> ; Solanki, Digant H
> ; V, Sangeetha ; Ni, Ray
>
> Subject: RE: [PATCH v8] IntelFsp2WrapperPkg : FSPM/S UPD data address base
Thanks Ashraf!
Reviewed-by: Chasel Chiu
> -Original Message-
> From: S, Ashraf Ali
> Sent: Thursday, December 16, 2021 4:10 PM
> To: devel@edk2.groups.io
> Cc: S, Ashraf Ali ; Chiu, Chasel
> ;
> Desimone, Nathaniel L ; Zeng, Star
> ; Kuo, Ted ; Duggap
For below 2 packages, Reviewed-by: Chasel Chiu
Thanks,
Chasel
* IntelFsp2Pkg
* IntelFsp2WrapperPkg
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael D
> Kinney
> Sent: Monday, December 6, 2021 9:18 AM
> To: Michael Kubacki ; devel@edk2.groups.io;
>
For below patches, Reviewed-by: Chasel Chiu
Thanks,
Chasel
IntelFsp2Pkg: Apply uncrusitify changes
IntelFsp2WrapperPkg: Apply uncrusitify changes
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael D
> Kinney
> Sent: Wednesday, December 1, 2021 6:34 AM
> To:
Hi Nate,
Just one small feedbacks inline, please check them.
With that resolved: Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Wednesday, July 21, 2021 4:22 AM
> To: devel@edk2.groups.io
> Cc: Oram, Isaac W
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Tuesday, July 13, 2021 5:27 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Jeremy Soller
> ; Michael Kubacki ;
> Benjamin Doron
> Subject: [edk2-platforms][PATCH
Patch pushed: d549e39ca1a9da14d86ff841358f990a0ace71f5
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chiu,
> Chasel
> Sent: Thursday, July 15, 2021 10:38 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ;
Thanks for fixing this issue! Reviewed-by: Chasel Chiu
> -Original Message-
> From: Benjamin Doron
> Sent: Friday, July 23, 2021 10:27 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Liming Gao
> ; Dong, Eric
> Subject: [
Thanks Isaac! I will correct them when pushing the patch.
> -Original Message-
> From: Oram, Isaac W
> Sent: Saturday, February 12, 2022 8:48 AM
> To: devel@edk2.groups.io; Chiu, Chasel
> Cc: Desimone, Nathaniel L ; Gao, Liming
> ; Dong, Eric
> Subject: R
Thanks Ted for updating patch! Looks good to me.
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kuo, Ted
> Sent: Monday, March 14, 2022 10:48 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star ; S, Ashraf
> Ali
&
Thanks Ted for updating patch!
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kuo, Ted
> Sent: Monday, March 14, 2022 10:33 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star ; S, Ashraf
> Ali
> Subject: [edk2-devel
Fix has pushed:
https://github.com/tianocore/edk2-platforms/commit/c398756604f54515da7af75a3f60a0380429a78c
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
> Sent: Friday, February 18, 2022 10:52 AM
> To: devel@edk2.groups.i
Fix pushed:
https://github.com/tianocore/edk2-platforms/commit/cbc8e420ac4505e9c51aa0d4f049026691024ca5
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
> Sent: Friday, February 18, 2022 7:56 AM
> To: Desimone, Nathaniel L ;
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3829
Commit cbc8e420ac4505e9c51aa0d4f049026691024ca5 caused GCC build failure
which should be fixed.
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Eric Dong
Signed-off-by: Chasel Chiu
---
Thanks Nate, Isaac for good catch! I will correct them before pushing.
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Friday, February 18, 2022 7:22 AM
> To: devel@edk2.groups.io; Chiu, Chasel
> Cc: Gao, Liming ; Dong, Eric
> ; Oram, Isaac W
> Sub
From: "Chiu, Chasel"
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3829
Fixed the bug that existing variable will not be locked when it is
identical with hob data by creating LockLargeVariable function, also
switched to VariablePolicyProtocol for locking variables.
Faili
nt: Monday, February 14, 2022 4:38 PM
> To: devel@edk2.groups.io; S, Ashraf Ali
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star ; Kuo, Ted
> ; Duggapu, Chinni B ;
> Chaganty, Rangasai V ; Solanki, Digant H
> ; V, Sangeetha
> Subject: RE: [edk2-devel] [PATCH] IntelFsp2Pkg: Ba
Thanks Ray!
@S, Ashraf Ali I think we need to return 64bit pointer in 64bit build, please
help to verify and confirm.
Thanks,
Chasel
> -Original Message-
> From: Ni, Ray
> Sent: Monday, February 14, 2022 4:27 PM
> To: devel@edk2.groups.io; S, Ashraf Ali
> C
Thanks Yu!
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Pu, Yu
> Sent: Wednesday, March 2, 2022 5:19 PM
> To: devel@edk2.groups.io
> Cc: Pu, Yu ; Chiu, Chasel
> Subject: [PATCH v1 3/7] IntelFsp2Pkg: Invoke GetPhysicalAddressBits() and
> remove the dup
Reviewed-by: Chasel Chiu
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Wednesday, March 23, 2022 9:11 AM
> To: devel@edk2.groups.io
> Cc: Bret Barkelew ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Gao, Liming
> ; Dong, Eric
> Subject:
Reviewed-by: Chasel Chiu
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Wednesday, March 23, 2022 9:28 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Gao, Liming
> ; Dong, Eric
> Subject: [edk2-platforms][PATC
Thanks Ted!
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kuo, Ted
> Sent: Monday, March 14, 2022 12:23 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star ; S,
> Ashraf Ali
> Subject: [edk2-devel][PATCH] IntelF
Patch pushed:
https://github.com/tianocore/edk2/commit/ec0b54849b23efa25caf0055b0eef8bf9b4dec98
Thanks,
Chasel
> -Original Message-
> From: Kuo, Ted
> Sent: Monday, March 14, 2022 12:23 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3829
Fixed the bug that existing variable will not be locked when it is
identical with hob data, also switch to VariablePolicyProtocol for
locking variables.
This patch also updated SaveMemoryConfig driver to be unloaded after
execution because
From: "Chiu, Chasel"
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3829
Fixed the bug that existing variable will not be locked when it is
identical with hob data by creating LockLargeVariable function, also
switched to VariablePolicyProtocol for locking variables.
Faili
Thanks for sending this patch, Ted!
Our direction is to always use PcdFspmUpdDataAddress64 and
PcdFspsUpdDataAddress64 from platform side no matter building with IA32 or X64.
This will help retirement of old PcdFspmUpdDataAddress and
PcdFspsUpdDataAddress in the future.
Please help to check
Thanks Xiaoqiang!
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Zhang, Xiaoqiang
> Sent: Monday, February 7, 2022 4:11 PM
> To: devel@edk2.groups.io
> Cc: Zhang, Xiaoqiang ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Oram, Isaac W
> Subject: [
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3829
Fixed the bug that existing variable will not be locked when it is
identical with hob data by creating LockLargeVariable function, also
switched to VariablePolicyProtocol for locking variables.
This patch also modified SaveMemoryConfig
Thanks Ted for updating patch!
For this patch series, Reviewed-by: Chasel Chiu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Kuo,
> Ted
> Sent: Wednesday, April 13, 2022 10:43 AM
> To: devel@edk2.groups.io
> Subject: [edk2-devel][PATCH v4 0/8] Support PEI 64bit in
Hi Ted,
Please see my comments below inline.
Thanks,
Chasel
> -Original Message-
> From: Kuo, Ted
> Sent: Wednesday, April 13, 2022 10:43 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star ; S,
> Ashraf Ali
> Subject: [
Thanks Yu!
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Pu, Yu
> Sent: Friday, April 1, 2022 1:22 PM
> To: devel@edk2.groups.io
> Cc: Pu, Yu ; Chiu, Chasel ;
> Desimone, Nathaniel L ; Zeng, Star
>
> Subject: [PATCH v1 1/6] IntelFsp2Pkg: A
Thanks Yu!
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Pu, Yu
> Sent: Friday, April 1, 2022 1:22 PM
> To: devel@edk2.groups.io
> Cc: Pu, Yu ; Chiu, Chasel ;
> Desimone, Nathaniel L ; Zeng, Star
>
> Subject: [PATCH v1 2/6] IntelFsp2WrapperPkg: A
HI Ted,
Please see my comments below inline.
Thanks,
Chasel
> -Original Message-
> From: Kuo, Ted
> Sent: Monday, April 4, 2022 2:23 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star ; S,
> Ashraf Ali
> Subject: [
Hi Ted,
Please see my comments inline below.
Thanks,
Chasel
> -Original Message-
> From: Kuo, Ted
> Sent: Monday, April 4, 2022 2:23 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star ; S,
> Ashraf Ali
> Subject: [
Hi Ted,
Please see my comments inline below.
Thanks,
Chasel
> -Original Message-
> From: Kuo, Ted
> Sent: Monday, April 4, 2022 2:23 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star ; S,
> Ashraf Ali
> Subject: [
One more comments.
Thanks,
Chasel
> -Original Message-
> From: Chiu, Chasel
> Sent: Wednesday, April 6, 2022 10:40 PM
> To: Kuo, Ted ; devel@edk2.groups.io
> Cc: Desimone, Nathaniel L ; Zeng, Star
> ; S, Ashraf Ali
> Subject: RE: [edk2-devel][PATCH v2 2
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Pu, Yu
> Sent: Monday, April 11, 2022 5:46 PM
> To: devel@edk2.groups.io
> Cc: Pu, Yu ; Chiu, Chasel ;
> Desimone, Nathaniel L ; Zeng, Star
>
> Subject: [PATCH v1 02/15] IntelFsp2WrapperP
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Pu, Yu
> Sent: Monday, April 11, 2022 5:46 PM
> To: devel@edk2.groups.io
> Cc: Pu, Yu ; Chiu, Chasel ;
> Desimone, Nathaniel L ; Zeng, Star
>
> Subject: [PATCH v1 01/15] IntelFsp2Pkg: A
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Pu, Yu
> Sent: Monday, April 11, 2022 5:46 PM
> To: devel@edk2.groups.io
> Cc: Pu, Yu ; Chiu, Chasel ;
> Desimone, Nathaniel L ; Zeng, Star
>
> Subject: [PATCH v1 09/15] IntelFsp2Pkg: Remov
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Pu, Yu
> Sent: Tuesday, April 12, 2022 10:52 PM
> To: devel@edk2.groups.io
> Cc: Pu, Yu ; Chiu, Chasel ;
> Desimone, Nathaniel L ; Zeng, Star
>
> Subject: [PATCH v2 02/14] IntelFsp2Pkg: A
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Pu, Yu
> Sent: Tuesday, April 12, 2022 10:52 PM
> To: devel@edk2.groups.io
> Cc: Pu, Yu ; Chiu, Chasel ;
> Desimone, Nathaniel L ; Zeng, Star
>
> Subject: [PATCH v2 03/14] IntelFsp2WrapperP
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Pu, Yu
> Sent: Tuesday, April 12, 2022 10:52 PM
> To: devel@edk2.groups.io
> Cc: Pu, Yu ; Chiu, Chasel ;
> Desimone, Nathaniel L ; Zeng, Star
>
> Subject: [PATCH v2 08/14] IntelFsp2Pkg
Thanks for fixing issues Ted!
For this patch series: Reviewed-by: Chasel Chiu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Kuo,
> Ted
> Sent: Friday, April 15, 2022 4:38 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel][PATCH v5 0/8] Support PEI 64bit in
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Zhang, Hongbin1
> Sent: Thursday, August 24, 2023 8:15 PM
> To: devel@edk2.groups.io
> Cc: Zhang, Hongbin1 ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Duggapu, Chinni B
> ; Ng, Ray Han Lim ;
Merged:
https://github.com/tianocore/edk2/commit/2c7fd32676272e22ed44fdfc8fa7e47f5c7a93b8
Thanks,
Chasel
> -Original Message-
> From: Kuo, Ted
> Sent: Thursday, July 20, 2023 3:20 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng
merged:
https://github.com/tianocore/edk2/commit/b1e558f6369fc85ae053e0c16ffcd600880fe78d
Thanks,
Chasel
> -Original Message-
> From: Zhang, Hongbin1
> Sent: Thursday, August 24, 2023 8:15 PM
> To: devel@edk2.groups.io
> Cc: Zhang, Hongbin1 ; Chiu, Chasel
> ; Des
Thanks Michael!
For this patch series: Reviewed-by: Chasel Chiu
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Tuesday, April 12, 2022 4:58 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Gao, Liming
> ; Dong, E
-patch -v2 -1)
Thanks,
Chasel
> -Original Message-
> From: Soundara Pandian, Arun SuraX
> Sent: Tuesday, November 7, 2023 8:53 PM
> To: devel@edk2.groups.io
> Cc: Soundara Pandian, Arun SuraX ;
> Chiu, Chasel ; Duggapu, Chinni B
> ; Desimone, Nathaniel L
> ;
nty, Rangasai V ; Desimone, Nathaniel
> L ; Chiu, Chasel
> Subject: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg:
> remove references
>
> For removing "MdePkg/Include/IndustryStandard/LegacyBiosMpTable.h" from
> edk2, first remove the edk2-platforms referen
From: Ankit Sinha
Adds new PCDs to allow entries in FADT to be customized during platform
integration. Board packages will can update these PCDs during boot.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Eric Dong
Signed-off-by: Ankit Sinha
---
Thanks Chinni!
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Duggapu, Chinni B
> Sent: Tuesday, May 17, 2022 1:07 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star ; S,
> Ashraf Ali
> Subject: [PA
Thanks Chinni!
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Duggapu, Chinni B
> Sent: Tuesday, May 17, 2022 1:07 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star ; S,
> Ashraf Ali
> Subject: [PATCH v4
Thanks for clarification!
In this case, please use "mov rsp, rcx" to support 64bit addressing.
Thanks,
Chasel
> -Original Message-
> From: Duggapu, Chinni B
> Sent: Tuesday, May 17, 2022 12:33 AM
> To: Chiu, Chasel ; devel@edk2.groups.io
> Cc: Desimone, Natha
Thanks for fixing a small coding issue!
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Duggapu, Chinni B
> Sent: Tuesday, May 17, 2022 4:44 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star ; S,
> Ashraf Ali
>
Thanks Chinni!
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Duggapu, Chinni B
> Sent: Tuesday, May 17, 2022 4:44 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star ; S,
> Ashraf Ali
> Subject: [PATCH v5
:
[1/2] IntelFsp2Pkg patch
[2/2] IntelFsp2WrapperPkg patch
Thanks,
Chasel
> -Original Message-
> From: Duggapu, Chinni B
> Sent: Monday, May 16, 2022 6:54 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star ; S,
>
601 - 700 of 934 matches
Mail list logo
