Reviewed-by: Chasel Chiu
Thanks TungLun!
> -Original Message-
> From: Loo, Tung Lun
> Sent: Thursday, May 12, 2022 7:26 AM
> To: devel@edk2.groups.io
> Cc: Loo, Tung Lun ; Desimone, Nathaniel L
> ; Zeng, Star ; Chiu,
> Chasel
> Subject: [PATCH] IntelFsp
> ; Zeng, Star ; Chiu,
> Chasel
> Subject: [PATCH] IntelFsp2Pkg: Add FSP 2.3 header support
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3921
>
> This patch adds a couple of fields supported in FSP 2.3 header from both
> header
> generation and tool support per
Thanks Chinni! Just few comments below inline, please help to check.
Would you also help to update commit message format and include Bugzilla link
for reference?
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of
> cbduggap
> Sent: Thursday, May 12, 2022
Thanks for updating!
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kuo, Ted
> Sent: Tuesday, July 12, 2022 2:31 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star ; S, Ashraf
> Ali
> Subject: [edk2-devel][PA
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Tuesday, June 7, 2022 7:17 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Kubacki, Michael
> ; Benjamin Doron
> ; Soller, Jeremy
> Subject: [edk2-
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Wednesday, June 8, 2022 7:23 AM
> To: devel@edk2.groups.io
> Cc: Sinha, Ankit ; Chiu, Chasel
> ;
> Gao, Liming ; Dong, Eric ;
> Kubacki, Michael
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Tuesday, June 7, 2022 7:17 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Kubacki, Michael
>
> Subject: [edk2-platforms] [PATCH V2 2/4] WhiskeylakeOpenBoard
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Tuesday, June 7, 2022 7:17 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Kubacki, Michael
> ; Chaganty, Rangasai V
> ; Kethi Reddy, Deepika
> ;
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Tuesday, June 7, 2022 7:09 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Sinha, Ankit
> ;
> Kubacki, Michael ; Soller, Jeremy
>
> Subject:
patch series merged:
https://github.com/tianocore/edk2/commit/140446cd595cad870a0e8cef7a367bae8f09effa
https://github.com/tianocore/edk2/commit/24eac4caf31afae48349af44588a52783c1819b8
Thanks,
Chasel
> -Original Message-
> From: Chiu, Chasel
> Sent: Monday, July 18, 202
This patch series has been merged:
cfd7e5f231fd644a5cb585d8ab68aa701af6a286
0f836bd4e3e18b9bd0d1a73b849a554519ee82fa
Thanks,
Chasel
> -Original Message-
> From: Chiu, Chasel
> Sent: Monday, July 18, 2022 5:37 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimo
For this series, Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Oram, Isaac W
> Sent: Tuesday, July 19, 2022 12:43 PM
> To: devel@edk2.groups.io
> Cc: Oram, Isaac W ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Gao, Liming ;
> Dong, Eric
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3993
Adding the missing FSPI_ARCH_UPD, FSP_GLOBAL_DATA_VERSION bumpping up,
and some comments for clarification.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
---
IntelFsp2Pkg/Include/FspEas/FspApi.h | 69
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3993
Adding the missing FSPI_ARCH_UPD, FSP_GLOBAL_DATA_VERSION bumpping up,
and some comments for clarification.
Also fixed a bug in SplitFspBin.py for FSP-I support.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
---
Thanks Nate! I have sent V2 to add this comment, please review again.
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Wednesday, July 20, 2022 1:52 PM
> To: Chiu, Chasel ; devel@edk2.groups.io
> Cc: Zeng, Star
> Subject: RE: [PATCH] IntelFsp2Pkg: Add FSPI
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3993
Adding the missing FSPI_ARCH_UPD, FSP_GLOBAL_DATA_VERSION bumpping up,
and some comments for clarification.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
---
IntelFsp2Pkg/Include/FspEas/FspApi.h | 71
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Monday, July 18, 2022 1:28 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Andrew Fish ; Leif
> Lindholm ; Kinney, Michael D
>
> Subject: [PATCH] Maintainer
t: Monday, July 18, 2022 2:41 PM
> To: Chiu, Chasel ; devel@edk2.groups.io
> Cc: Zhang, Hongbin1 ; Zeng, Star
>
> Subject: RE: [PATCH] IntelFsp2Pkg/FspSecCore: Add FSP-I API for SMM support.
>
> Hi Chasel,
>
> Please see comments inline. Here is a summary of my feedback:
>
Thanks Nate! I have sent V2 accordingly, please help to review again.
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Monday, July 18, 2022 4:53 PM
> To: Chiu, Chasel ; devel@edk2.groups.io
> Cc: Oram, Isaac W ; Gao, Liming
> ; Dong, Eric
> Su
FSP_STATUS_RESET_REQUIRED_* will be either 32bit or 64bit basing
on the build and this patch series extended the support for 64bit build.
Cc: Nate DeSimone
Cc: Isaac Oram
Cc: Liming Gao
Cc: Eric Dong
Signed-off-by: Chasel Chiu
Chasel Chiu (2):
MinPlatformPkg/FspWrapper: FspResetType
FSP_STATUS_RESET_REQUIRED_* will be either 32bit or 64bit basing
on the build and this patch extended the support for 64bit build.
Cc: Nate DeSimone
Cc: Isaac Oram
Cc: Liming Gao
Cc: Eric Dong
Signed-off-by: Chasel Chiu
---
FSP_STATUS_RESET_REQUIRED_* will be either 32bit or 64bit basing
on the build and this patch extended the support for 64bit build.
Cc: Isaac Oram
Cc: Nate DeSimone
Signed-off-by: Chasel Chiu
---
Silicon/Intel/WhitleySiliconPkg/Library/FspWrapperPlatformLib/FspWrapperPlatformLib.c
| 4 ++--
FSP_STATUS_RESET_REQUIRED_* will be either 32bit or 64bit basing
on the build and this patch extended the support for 64bit build.
Cc: Isaac Oram
Cc: Nate DeSimone
Signed-off-by: Chasel Chiu
---
Silicon/Intel/WhitleySiliconPkg/Library/FspWrapperPlatformLib/FspWrapperPlatformLib.c
| 2 +-
1
FSP_STATUS_RESET_REQUIRED_* will be either 32bit or 64bit basing
on the build and this patch extended the support for 64bit build.
Cc: Nate DeSimone
Cc: Isaac Oram
Cc: Liming Gao
Cc: Eric Dong
Signed-off-by: Chasel Chiu
---
FSP_STATUS_RESET_REQUIRED_* will be either 32bit or 64bit basing on
the build and this patch series extended the support for 64bit build.
Cc: Nate DeSimone
Cc: Isaac Oram
Cc: Liming Gao
Cc: Eric Dong
Signed-off-by: Chasel Chiu
V2: Change ResetType from UINTN to EFI_STATUS
Chasel Chiu (2):
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Monday, July 18, 2022 1:17 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel
> Subject: [PATCH V1] IntelFsp2Pkg: Add Definition of EDKII_PEI_VARIABLE_PPI
&g
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3999
FspResetType will be either 32bit or 64 bit basing on
the build type.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
---
IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c | 10 +-
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3999
FspResetType will be either 32bit or 64 bit basing on
the build type
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
Chasel Chiu (2):
IntelFsp2Pkg: Support 64bit FspResetType for X64 build.
IntelFsp2WrapperPkg: Support
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3999
FspResetType will be either 32bit or 64 bit basing on
the build type.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
---
IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.c
| 6 +++---
This series has been merged:
https://github.com/tianocore/edk2/commit/9ab389c01b875869c6173557aa053d397aaf14f1
https://github.com/tianocore/edk2/commit/470206ba7f118aaa1153d66689cf3ee4d17051b7
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Kuo, Ted
>
From: Hongbin1 Zhang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3993
Add FSP-I API entry point for SMM support.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
Signed-off-by: Hongbin1 Zhang
---
IntelFsp2Pkg/FspSecCore/SecFspApiChk.c | 13 +
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3993
Fixed a logic bug in GenCfgOpt.py to skip FSPI_UPD when platforms
do not support.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
---
IntelFsp2Pkg/Tools/GenCfgOpt.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Patch merged:
https://github.com/tianocore/edk2/commit/0d0bfcb4571caa65b7875003f38e67e2ac7e5560
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
> Sent: Thursday, July 28, 2022 7:57 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Ch
Patch merged:
https://github.com/tianocore/edk2/commit/3eca64f157c340f9bbf552d89a69698a3090c080
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
> Sent: Wednesday, July 27, 2022 10:15 PM
> To: devel@edk2.groups.io
> C
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3993
FSPI_UPD is required only When platforms implemented FSP_I component.
Updated the scripts to allow FSPI_UPD not present scenario.
Also fixed FSP_GLOBAL_DATA structure alignment issue and unnecessary
non-backward compatibility change in
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3993
FSPI_UPD is required only When platforms implemented FSP_I component.
Updated the scripts to allow FSPI_UPD not present scenario.
Also fixed FSP_GLOBAL_DATA structure alignment issue and unnecessary
non-backward compatibility change in
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3993
Adding the missing FSPI_ARCH_UPD, FSP_GLOBAL_DATA_VERSION bumpping up,
and some comments for clarification.
Also fixed a bug in SplitFspBin.py for FSP-I support.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
---
Patch merged:
https://github.com/tianocore/edk2/commit/5a3641bfcdcf99fd76817833488f2af8abb69383
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
> Sent: Friday, July 22, 2022 10:49 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Ch
From: Hongbin1 Zhang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3993
Add FSP-I API entry point for SMM support.
Also update 64bit API entry code to assign ApiIdx to RAX
to avoid confusion.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
Signed-off-by: Hongbin1 Zhang
---
Hi,
I have sent V2 to assign ApiIdx to RAX in X64 case to avoid confusion.
Please help to review again,
Thanks,
Chasel
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Monday, July 18, 2022 4:41 PM
> To: Pedro Falcato ; edk2-devel-groups-io
>
> Cc: Ch
Hi Isaac,
Please see my question below inline.
Thanks,
Chasel
> -Original Message-
> From: Oram, Isaac W
> Sent: Wednesday, June 29, 2022 3:12 PM
> To: devel@edk2.groups.io
> Cc: Oram, Isaac W ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Gao, Liming ;
> Dong
Hi Star, this is following current specification.
Thanks,
Chasel
> -Original Message-
> From: Zeng, Star
> Sent: Wednesday, July 20, 2022 8:07 PM
> To: Chiu, Chasel ; devel@edk2.groups.io
> Cc: Desimone, Nathaniel L ; Zeng, Star
>
> Subject: RE: [PATCH
Thanks for fixing the typo!
Reviewed-by: Chasel Chiu
> -Original Message-
> From: pierre.gond...@arm.com
> Sent: Tuesday, August 23, 2022 9:00 AM
> To: devel@edk2.groups.io
> Cc: Pierre Gondois ; Chiu, Chasel
> ; Desimone, Nathaniel L
>
> Subject: [PATCH 11
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3916
Basing on offline feedbacks to rename
FspWrapperPlatformMultiPhaseLibSample to
FspWrapperPlatformMultiPhaseLibNull.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
---
Agree. I'm sending patch to rename this lib from edk2 and will send patch to
rename this lib from MinPlatformPkg dsc too.
Thanks,
Chasel
> -Original Message-
> From: Oram, Isaac W
> Sent: Wednesday, August 31, 2022 4:10 PM
> To: Chiu, Chasel ; devel@edk2.groups.io
&g
FSP Wrapper has implemented FSP 2.4 MultiPhase support
and required platform to include new library instance.
Cc: Nate DeSimone
Cc: Isaac Oram
Cc: Liming Gao
Cc: Eric Dong
Signed-off-by: Chasel Chiu
---
Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc | 2 ++
1 file changed, 2
Patch merged:
https://github.com/tianocore/edk2/commit/ec87181192f013f4f7ff916b2a39ff2c87b079f3
Thanks,
Chasel
> -Original Message-
> From: Chiu, Chasel
> Sent: Wednesday, August 31, 2022 11:00 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
Patch pushed:
https://github.com/tianocore/edk2-platforms/commit/07bcc0be8c1bcfbd88eb254ebd4f674217013dca
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chiu,
> Chasel
> Sent: Thursday, September 1, 2022 4:55 PM
> To: devel@edk2.group
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Tuesday, September 6, 2022 8:19 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star
> Subject: [PATCH v1 4/7] IntelFsp
patch3 Fsp24SecCore modules have been merged:
https://github.com/tianocore/edk2/commit/df25a5457f04ec465dce97428cfee96f462676e7
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
> Sent: Wednesday, August 31, 2022 11:13 AM
> To
Looks good to me! Thanks Michael!
> -Original Message-
> From: Michael Kubacki
> Sent: Tuesday, September 6, 2022 9:35 PM
> To: Chiu, Chasel ; devel@edk2.groups.io
> Cc: Desimone, Nathaniel L ; Zeng, Star
>
> Subject: Re: [edk2-devel] [PATCH v1 5/7] IntelFsp2W
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael
> Kubacki
> Sent: Tuesday, September 6, 2022 8:19 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star
> Subject
. Is it possible to support such
scenario in CI?
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael
> Kubacki
> Sent: Tuesday, September 6, 2022 8:19 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, S
Thanks for fixing this bug.
Reviewed-by: Chasel Chiu
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Tuesday, September 6, 2022 8:19 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star
> Subject: [PATCH
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4049
Link error occurred in certain compiling environment when building
FspSecCoreI: unresolved external symbol _TempRamInitApi.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
---
IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryI.nasm |
; From: Chiu, Chasel
> Sent: Tuesday, August 9, 2022 5:48 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star
> Subject: [PATCH v2 0/4] IntelFsp2(Wrapper)Pkg: Support FSP 2.4 MultiPhase.
>
> REF: https://bugzilla.tianocore.org/show_bug.c
FSP Wrapper has implemented FSP 2.4 MultiPhase support
and required platform to include new library instance.
Cc: Nate DeSimone
Cc: Isaac Oram
Cc: Liming Gao
Cc: Eric Dong
Signed-off-by: Chasel Chiu
---
Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc | 2 ++
1 file changed, 2
Patch 4 Fspw to adopt FSP 2.4 MultiPhase has been merged:
https://github.com/tianocore/edk2/commit/96f3efbd991db83c608909c1c861a77fe26982f1
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
> Sent: Tuesday, September 6, 202
Patch merged:
https://github.com/tianocore/edk2/commit/26638d2aa399e436f47d629f877e581ed402020a
Thanks,
Chasel
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Tuesday, October 25, 2022 3:19 PM
> To: Chiu, Chasel ; devel@edk2.groups.io
> Cc: Zeng, Star
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4119
Earlier version of FSP header may not have MultiPhase fields present in
the FspInfoHeader so the handler should verify header revision before
accessing the MultiPhase fields from the header.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4126
Common functions will have either 32bit or 64bit instances which
having different return code size. Function header should support both
scenarios.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
---
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4114
FSP specification supports input UPD as NULL cases which FSP will
use built-in UPD region instead.
FSP should not return INVALID_PARAMETER in such cases.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
---
Thanks Ted!
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kuo, Ted
> Sent: Thursday, September 15, 2022 6:40 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star ; S, Ashraf
> Ali ; Duggapu, Chinni B
> Subjec
Patch merged:
https://github.com/tianocore/edk2/commit/f46c7d1e36c901e72cc0daee8429275bcb319eb9
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
> Sent: Wednesday, September 7, 2022 12:43 PM
> To: devel@edk2.groups.io
> C
Patch merged:
https://github.com/tianocore/edk2/commit/981bf66d5a7b1a31be5ffccc15fe13b97300e124
Thanks,
Chasel
> -Original Message-
> From: Kuo, Ted
> Sent: Thursday, September 15, 2022 6:40 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
>
Patch has been merged:
https://github.com/tianocore/edk2-platforms/commit/ae75c51f27e21036b6ee021a2d5b9f365f951413
Thanks,
Chasel
> -Original Message-
> From: Chen, Aryeh
> Sent: Sunday, September 11, 2022 10:18 PM
> To: devel@edk2.groups.io
> Cc: Chen, Aryeh
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4092
To comply with coding style rule each library class
should have its own header even if it is just a private child library
instance consumed by parent public library in the same package.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by:
To comply with coding style rule each library class
should have its own header even if it is just a private child library
instance consumed by parent public library in the same package.
Cc: Nate DeSimone
Cc: Star Zeng
Cc: Michael Kubacki
Signed-off-by: Chasel Chiu
Reviewed-by: Nate DeSimone
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4092
To comply with coding style rule each library class
should have its own header even if it is just a private child library
instance consumed by parent public library in the same package.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4092
Duplicate library class header issue will be resolved and CI
exception for FspWrapperPlatformMultiPhaseLib should be removed too.
Cc: Nate DeSimone
Cc: Star Zeng
Cc: Michael Kubacki
Signed-off-by: Chasel Chiu
---
Yes. Thanks Michael!
> -Original Message-
> From: Michael Kubacki
> Sent: Tuesday, October 4, 2022 8:09 PM
> To: devel@edk2.groups.io; Chiu, Chasel ; Kinney,
> Michael D
> Cc: Desimone, Nathaniel L ; Zeng, Star
>
> Subject: Re: [edk2-devel] [PATCH v2 5/6] Int
f Chiu, Chasel
> Sent: Tuesday, October 4, 2022 6:22 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star ; Kubacki,
> Michael
> Subject: [edk2-devel] [PATCH 0/2] IntelFsp2WrapperPkg: Add header for
> PlatformMultiPhaseLib.
>
> To comply wi
nal Message-
> From: Michael Kubacki
> Sent: Tuesday, October 4, 2022 9:22 AM
> To: Kinney, Michael D ; devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star
> Subject: Re: [edk2-devel] [PATCH v2 5/6] IntelFsp2WrapperPkg: Add CI YAML file
>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3916
Provide FSP 2.4 MultiPhase interface and scripts
support.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
---
IntelFsp2Pkg/Library/BaseFspMultiPhaseLib/FspMultiPhaseLib.c | 176
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3916
Add FSP 2.4 MultiPhase interfaces and implementation.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
Chasel Chiu (4):
IntelFsp2Pkg: Add FSP 2.4 MultiPhase interface.
IntelFsp2WrapperPkg: Add FSP 2.4 MultiPhase interface
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3916
Implement MultiPhase wrapper handlers and only call to MultiPhase
handlers when FSP supports.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
---
IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c | 33
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3916
Adopt MultiPhase functions for both FspSecCoreS and FspSecCoreM.
For backward compatibility, new INF are created for new modules.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
---
IntelFsp2Pkg/FspSecCore/SecFsp.c
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3916
Provide FSP 2.4 MultiPhase wrapper support library.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
---
IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/PeiFspWrapperMultiPhaseProcessLib.c
| 337
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4019
FSPM_ARCH2_UPD in FspApiEntryM.nasm was not up-to-date and
should be fixed.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
---
IntelFsp2Pkg/FspSecCore/X64/FspApiEntryM.nasm | 3 ++-
1 file changed, 2 insertions(+), 1
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4019
FSPM_ARCH2_UPD in FspApiEntryM.nasm was not up-to-date and
should be fixed for both IA32 and X64 builds.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
---
IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm | 3 ++-
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Chen, Aryeh
> Sent: Monday, August 15, 2022 1:36 AM
> To: devel@edk2.groups.io
> Cc: Chen, Aryeh ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Oram, Isaac W ;
> Gao, Liming ; Dong, Eric
> Subject: [PA
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3916
Provide FSP 2.4 MultiPhase wrapper support library.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
---
IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformMultiPhaseLibSample/FspWrapperPlatformMultiPhaseLibSample.c
|
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3916
Provide FSP 2.4 MultiPhase interface and scripts
support.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
---
IntelFsp2Pkg/Library/BaseFspMultiPhaseLib/FspMultiPhaseLib.c | 184
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3916
Adopt MultiPhase functions for both FspSecCoreS and FspSecCoreM.
For backward compatibility, new INF are created for new modules.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
---
IntelFsp2Pkg/FspSecCore/SecFsp.c
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3916
Add FSP 2.4 MultiPhase interfaces and implementation.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
V2:
. Add FspMultiPhasePlatformGetNumberOfPhases() and
FspWrapperPlatformMultiPhaseHandler() to support
platform porting.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3916
Implement MultiPhase wrapper handlers and only call to MultiPhase
handlers when FSP supports.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
---
IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c | 33
Thanks Nate for detail reviewing and all the good feedbacks!
I have applied all of them and sent a V2 patch series, please help to review
again.
From: Desimone, Nathaniel L
Sent: Thursday, August 4, 2022 5:51 PM
To: Chiu, Chasel ; devel@edk2.groups.io
Cc: Zeng, Star
Subject: RE: [PATCH 0/4
Hello,
Patch has been merged:
https://github.com/tianocore/edk2-platforms/commit/d56523d0c1fae5311f5bcecd93ccabd8a5c73830
Thanks,
Chasel
> -Original Message-
> From: Chen, Aryeh
> Sent: Monday, August 15, 2022 1:36 AM
> To: devel@edk2.groups.io
> Cc: Chen, Aryeh
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Liu, Zhiguang
> Sent: Tuesday, November 1, 2022 12:59 AM
> To: devel@edk2.groups.io
> Cc: Yu Pu ; Chiu, Chasel ;
> Desimone, Nathaniel L ; Zeng, Star
>
> Subject: [PATCH v3 3/9] IntelFs
ET
returned 1
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Monday, October 31, 2022 5:52 PM
> To: Chiu, Chasel ; devel@edk2.groups.io
> Cc: Zeng, Star
> Subject: RE: [PATCH] IntelFsp2Pkg: Update Function header to support
> IA32/X64.
>
>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4114
FSP specification supports input UPD as NULL cases which FSP will
use built-in UPD region instead.
FSP should not return INVALID_PARAMETER in such cases.
In FSP-T entry point case, the valid FSP-T UPD region pointer will be
passed to
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Oram, Isaac W
> Sent: Wednesday, January 4, 2023 5:34 PM
> To: devel@edk2.groups.io
> Cc: Oram, Isaac W ; Desimone, Nathaniel L
> ; Chiu, Chasel ;
> Sinha, Ankit ; Ponnusamy, Suresh
>
> Subject: [edk2-d
Thanks for the update!
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Xie, Yuanhao
> Sent: Tuesday, December 27, 2022 12:31 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Oram, Isaac W
> ; Gao, Liming ;
> Dong, Eric
>
ed
> Sent: Wednesday, November 9, 2022 3:31 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star ; S,
> Ashraf Ali ; Duggapu, Chinni B
>
> Subject: [edk2-devel][PATCH v1] IntelFsp2Pkg: Improvement of supporting
> null UPD pointer in FSP-T
>
Thanks Liming!!
> -Original Message-
> From: gaoliming
> Sent: Thursday, November 10, 2022 5:37 PM
> To: devel@edk2.groups.io; Chiu, Chasel ; Kinney,
> Michael D
> Cc: Desimone, Nathaniel L ; Zeng, Star
> ; S, Ashraf Ali ; Duggapu,
> Chinni B ; Kuo, Ted
&g
Behalf Of
> gaoliming via groups.io
> Sent: Thursday, November 10, 2022 4:54 PM
> To: Chiu, Chasel ; Kinney, Michael D
>
> Cc: Desimone, Nathaniel L ; Zeng, Star
> ; S, Ashraf Ali ; Duggapu,
> Chinni B ; devel@edk2.groups.io; Kuo, Ted
>
> Subject: 回复: [edk2-devel][PA
Thanks Liming!!
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of
> gaoliming via groups.io
> Sent: Thursday, November 10, 2022 8:52 PM
> To: devel@edk2.groups.io; Chiu, Chasel ; Kinney,
> Michael D
> Cc: Desimone, Nathaniel L ; Zeng, Star
> ;
Hi Ted,
Please see my reply below inline.
Thanks,
Chasel
> -Original Message-
> From: Kuo, Ted
> Sent: Wednesday, November 2, 2022 7:32 PM
> To: devel@edk2.groups.io; Chiu, Chasel
> Cc: Desimone, Nathaniel L ; Zeng, Star
>
> Subject: RE: [edk2-devel] [PATCH
Patch merged:
https://github.com/tianocore/edk2/commit/b84f32ae5b475ce657ea1c9db29d4e4ec7711948
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chiu,
> Chasel
> Sent: Tuesday, November 1, 2022 10:46 PM
> To: devel@edk2.groups.io
>
Patch merged:
https://github.com/tianocore/edk2/commit/c46204e25f5b929fae2b336c03c73fada632d4f4
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chiu,
> Chasel
> Sent: Thursday, October 27, 2022 7:58 PM
> To: devel@edk2.groups.io
>
701 - 800 of 934 matches
Mail list logo
