On 2019-06-12 23:28:12, Wu, Hao A wrote:
>
> > -Original Message-
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > David Woodhouse
> > Sent: Thursday, June 13, 2019 5:43 AM
> >
> > The DX register is supposed to contain the required alignment for the
> >
On 2019-06-11 22:42:13, Liu, Zhiguang wrote:
> Thanks for the comments.
> I will change the commit message in the next version.
> But I don't think this is a issue worth making a major change.
> Given that the change is consistent with NT32, will you agree with this
> change?
Hmm. You are right
On 2019-06-11 00:32:27, Zhiguang Liu wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1686
>
> V3: I hope that changing the status of the mCpuSmbiosType4
> wouldn't affect other features except showing CPU speed.
> The value is zero in NT32Pkg.
>
> Cc
On 2019-06-10 18:43:07, Hao A Wu wrote:
> The series is also available at:
> https://github.com/hwu25/edk2/tree/ovmf_drop_framework_v2
>
> V2 changes:
>
> * Update to module OvmfPkg/Csm/CsmSupportLib/CsmSupportLib.inf has been
> dropped, since the module is proposed to be removed in another
ode support -ccc-host-tripe, for newer
> versions
> +# only older versions of Xcode support -ccc-host-triple, for newer
> versions
I don't like to include multiple fixes in one patch, but this is a
pretty minor typo.
> # it is -target
> - HOST_TOOLS=XCODE32
>
On 2019-04-27 17:55:02, Liming Gao wrote:
> >-Original Message-
> >From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> >Sent: Saturday, April 27, 2019 12:33 AM
> >
> >
> >This series confuses me. The existing CLANGxx toolchains already use
> >GenFw and ELF to PE/COFF conversion, so
Reviewed-by: Jordan Justen
On 2019-04-03 14:54:39, Kinney, Michael D wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=1657
>
> Add .sh file extension to the shell script GdbRun so
> changes to this file will pass PatchCheck.py.
>
> Cc: Jordan Justen
> Cc: Andre
that issue.
* Building on windows
* AARCH64/ARM TemporaryRamMigration.asm sources
Cc: Liu Yu
Cc: Ray Ni
Cc: Andrew Fish
Cc: Laszlo Ersek
Cc: Leif Lindholm
Cc: Michael D Kinney
Jordan Justen (6):
MdeModulePkg/Core/Pei: Add interface for assembly based
TemporaryRamSupport
MdeModuleP
Signed-off-by: Jordan Justen
Cc: Jian J Wang
Cc: Hao Wu
Cc: Ray Ni
Cc: Star Zeng
---
.../Ia32/TemporaryRamMigration.nasm | 77 +++
MdeModulePkg/Core/Pei/PeiMain.inf | 3 +
2 files changed, 80 insertions(+)
create mode 100644
MdeModulePkg/Core/Pei
ons have been added, PEI
Core will be updated to use the new assembly based code path.
Signed-off-by: Jordan Justen
Cc: Jian J Wang
Cc: Hao Wu
Cc: Ray Ni
Cc: Star Zeng
---
MdeModulePkg/Core/Pei/PeiMain.h | 52 +
1 file changed, 52 insertions(+)
diff --
Signed-off-by: Jordan Justen
Cc: Leif Lindholm
Cc: Ard Biesheuvel
---
.../Dispatcher/Arm/TemporaryRamMigration.S| 68 +++
.../Dispatcher/Arm/TemporaryRamMigration.asm | 68 +++
MdeModulePkg/Core/Pei/PeiMain.inf | 5 ++
3 files changed, 141
n make use of the assembly based PEI Core code path.
Signed-off-by: Jordan Justen
Cc: Jian J Wang
Cc: Hao Wu
Cc: Ray Ni
Cc: Star Zeng
---
MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c | 59 ---
1 file changed, 38 insertions(+), 21 deletions(-)
diff --git a/MdeModulePkg/Core/Pei/
Some compilers may optimize register usage in ways that are
incompatible with the TemporaryRamSupport PPI. Using assembly code to
call the TemporaryRamMigration function prevents this issue.
Signed-off-by: Jordan Justen
Cc: Jian J Wang
Cc: Hao Wu
Cc: Ray Ni
Cc: Star Zeng
---
.../Dispatcher
Signed-off-by: Jordan Justen
Cc: Leif Lindholm
Cc: Ard Biesheuvel
---
.../AArch64/TemporaryRamMigration.S | 63 +++
.../AArch64/TemporaryRamMigration.asm | 63 +++
MdeModulePkg/Core/Pei/PeiMain.inf | 4 ++
3 files changed, 130
Signed-off-by: Jordan Justen
Cc: Andrew Fish
Cc: Ray Ni
---
EmulatorPkg/build.sh | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/EmulatorPkg/build.sh b/EmulatorPkg/build.sh
index 89fd26baca..75561c116a 100755
--- a/EmulatorPkg/build.sh
+++ b/EmulatorPkg/build.sh
Signed-off-by: Jordan Justen
---
OvmfPkg/build.sh | 19 +++
1 file changed, 7 insertions(+), 12 deletions(-)
diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
index 4fcbdd2bc9..c92e90acfa 100755
--- a/OvmfPkg/build.sh
+++ b/OvmfPkg/build.sh
@@ -43,7 +43,6 @@ PLATFORMFILE
If we are building for a non-native ARM, then we may need to select a
cross-compiler based on the -a paramter.
Signed-off-by: Jordan Justen
---
OvmfPkg/build.sh | 99 +---
1 file changed, 51 insertions(+), 48 deletions(-)
diff --git a/OvmfPkg
Signed-off-by: Jordan Justen
---
OvmfPkg/build.sh | 26 ++
1 file changed, 22 insertions(+), 4 deletions(-)
diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
index 9d787452b5..e1a708942b 100755
--- a/OvmfPkg/build.sh
+++ b/OvmfPkg/build.sh
@@ -103,9 +103,6 @@ do
shift
This hasn't worked for me in quite some time. I always add a -cdrom
paramter, which causes build.sh to skip this.
Signed-off-by: Jordan Justen
---
OvmfPkg/build.sh | 3 ---
1 file changed, 3 deletions(-)
diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
index c92e90acfa..217abae683 100755
Signed-off-by: Jordan Justen
---
OvmfPkg/build.sh | 72
1 file changed, 60 insertions(+), 12 deletions(-)
diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
index 812441b9b1..9d787452b5 100755
--- a/OvmfPkg/build.sh
+++ b/OvmfPkg/build.sh
@@ -35,6
On 2019-04-10 09:41:43, Ard Biesheuvel wrote:
> On Wed, 10 Apr 2019 at 01:41, Jordan Justen wrote:
> >
> > https://github.com/jljusten/edk2.git temp-ram-support-v2
> >
> > https://github.com/jljusten/edk2/commits/temp-ram-support-v2
> >
> > v2:
> >
On 2019-04-10 08:37:22, Philippe Mathieu-Daudé wrote:
> Hi Jordan,
>
> On 4/10/19 11:34 AM, Jordan Justen wrote:
> > If we are building for a non-native ARM, then we may need to select a
> > cross-compiler based on the -a paramter.
>
> I am sorry but I am non-native E
On 2019-04-10 07:16:34, Laszlo Ersek wrote:
> Hi Jordan,
>
> I've asked Phil (CC'd) to review this series in my stead. I'll be happy
> to provide an ACK when Phil gives his R-b (if I should forget, please
> ping me separately).
>
> In the future, please include a cover letter; a cumulative
On 2019-04-12 16:31:20, Laszlo Ersek wrote:
> RH covscan justifiedly reports that accessing
> "EFI_COMMON_SECTION_HEADER.Size", which is of type UINT8[3], through a
> (UINT32*), is undefined behavior:
>
> > Error: OVERRUN (CWE-119):
> > edk2-89910a39dcfd/OvmfPkg/Sec/SecMain.c:178: overrun-local:
ever read
> > #Status = VirtioGpuSetScanout (
> > #^~
> > # 63| // by setting ResourceId=0 for it.
> > # 64| //
> > # 65|-> Status = VirtioGpuSetScanout (
> > # 66| VgpuGop->ParentBus
On 2019-04-11 08:51:22, Guo Dong wrote:
> CorebootModulePkg and CorebootPayloadPkg originally supports coreboot only.
> In order to support other bootloaders, such as Slim Bootloader, they need
> be updated to be more generic.
> UEFI Payload (UefiPayloadPkg) a converged package from
On 2019-04-16 03:59:48, Laszlo Ersek wrote:
> On 04/16/19 11:04, Jordan Justen wrote:
> > On 2019-04-15 09:15:31, Laszlo Ersek wrote:
> >> On 04/14/19 09:19, Jordan Justen wrote:
> >>> On 2019-04-12 16:31:20, Laszlo Ersek wrote:
> >>>>
On 2019-04-17 07:59:41, Laszlo Ersek wrote:
> On 04/17/19 13:44, Andrew Fish wrote:
>
> > Sorry I digressed into the C specification discussion, and did not
> > deal with the patch in general. My point is the original code is legal
> > C code. If you lookup CWE-119 it is written as a restriction
Short summary: Despite being part of the Platorm Initialization
Specificication, this proposal would remove support for the
TemporaryRamSupport PPI from PEI Core. Arguably, this would mean the
PEI Core does not support the PI spec, but we do not currently know if
any platforms require this PPI.
On 2019-04-10 02:07:34, Jordan Justen wrote:
> Signed-off-by: Jordan Justen
> Cc: Andrew Fish
> Cc: Ray Ni
ping
> ---
> EmulatorPkg/build.sh | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/EmulatorPkg/build.sh b/EmulatorPkg/bui
pushed as 55b9bbf40a1cf9788dd6a7b093851076851fc670
On 2019-06-19 09:57:20, Stephano Cetola wrote:
> The last compiler flag change was for Xcode 5.0, not Xcode 3.2. As such
> the HOST_TOOLS should be set to XCODE5.
>
> Also, fix a small typo.
>
> This fixes bug 447:
>
>
Fixes and assert seen when running ls under the shell. It appears the
assert was added in:
commit 99849a906e15ea3a9a0330d69bbae0d21ff49808
ShellPkg/ls: Display the file time in local time.
Signed-off-by: Jordan Justen
Cc: Andrew Fish
Cc: Ray Ni
---
For reference: https://linux.die.net
On 2019-07-29 19:24:00, wrote:
> On 2019-07-24 16:56, Jordan Justen wrote:
> > Reviewed-by: Jordan Justen
> >
> > On 2019-07-24 14:44:05, Rebecca Cran wrote:
> >> $ADD_QEMU_HDA was added because QEMU used to refuse to run without a
> >> disk. Since newer
t the wrong line endings are used in the patch.
>
> Cc: Bob Feng
> Cc: Liming Gao
> Cc: Jordan Justen
> Signed-off-by: Michael D Kinney
> ---
> BaseTools/Scripts/PatchCheck.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/BaseTools/Scripts/Pat
xes
>
> Cc: Bob Feng
> Cc: Liming Gao
> Cc: Jordan Justen
> Signed-off-by: Michael D Kinney
>
> Michael D Kinney (3):
> BaseTools/PatchCheck: Ignore blank lines in diff
> BaseTools/PatchCheck: Add copy from/to keywords
patches 1 and 2: Reviewed-by: Jordan
; >
> > Subject: Re: [Patch V4 06/10] EmulatorPkg: Fix XCODE5
> > lldb issues
> >
> > On 2019-08-15 19:14:33, Michael D Kinney wrote:
> > > Fix scripts to support lldb symbolic debugging when
> > using XCODE5 tool
> > > chain.
> >
> at the beginning of the function so the storage for
> this local variable is allocated for the entire
> lifetime of the function.
>
> Cc: Jordan Justen
> Cc: Ray Ni
> Cc: Michael D Kinney
> Signed-off-by: Andrew Fish
> ---
> EmulatorPkg/Sec/Sec.c | 16 +++-
On 2019-08-16 17:57:04, Michael D Kinney wrote:
>
> Andrew Fish (7):
> EmulatorPkg/Unix/Host: Disable inline/optimizations
Maybe add XCODE5 in commit message subject?
Acked-by: Jordan Justen
> EmulatorPkg: Fix XCODE5 lldb issues
There was another long line in the Emul
On 2019-08-15 19:14:33, Michael D Kinney wrote:
> Fix scripts to support lldb symbolic debugging when
> using XCODE5 tool chain.
>
> Cc: Jordan Justen
> Cc: Ray Ni
> Cc: Michael D Kinney
> Signed-off-by: Andrew Fish
Is this a Cc/Signed-off-by typo? (See also, patches
ject line for the patches too. :)
-Jordan
>
> Cc: Jordan Justen
> Cc: Ray Ni
> Cc: Michael D Kinney
> Signed-off-by: Andrew Fish
> ---
> EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c | 5 +
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/Emula
On 2019-08-21 07:21:25, Laszlo Ersek wrote:
> On 08/19/19 23:35, Lendacky, Thomas wrote:
> > From: Tom Lendacky
> >
> > Currently, the OVMF code relies on the hypervisor to enable the cache
> > support on the processor in order to improve the boot speed. However,
> > with SEV-ES, the hypervisor
On 2019-08-22 06:46:07, Laszlo Ersek wrote:
> On 08/21/19 23:51, Jordan Justen wrote:
> > On 2019-08-21 07:21:25, Laszlo Ersek wrote:
> >> On 08/19/19 23:35, Lendacky, Thomas wrote:
> >>> From: Tom Lendacky
> >>>
> >>> + //
> >
er that when git commit it will get the correct author name in the
patch.
Michael, Liming: You can adjust it locally with:
git commit --amend --author="Michael Johnson "
>
> Add GetTimeInNanoSecond, already declared in the TimerLib API,
> to EmulatorPkg implementations of TimerLib.
o strongly on this. I thought adding Laszlo's settings
to .gitattributes might amount to solving two issues with one change.
Since Laszlo acked this patch, I'll go ahead with:
Reviewed-by: Jordan Justen
> My expectation is that EDK II Maintainers need to review
> if a binary file is ok or not
ow_bug.cgi?id=2056
>
> * Fix VS20xx IA32 boot failure
> * Remove UNIX_SEC_BUILD/WIN_SEC_BUILD
> * Add -D DISABLE_NEW_DEPRECATED_INTERFACES
>
> Cc: Jordan Justen
> Cc: Andrew Fish
> Cc: Ray Ni
> Signed-off-by: Michael D Kinney
>
> Michael D Kinney (4):
> Emula
On 2019-07-23 00:44:06, Laszlo Ersek wrote:
> On 07/23/19 02:00, Rebecca Cran wrote:
> > On 2019-07-22 17:14, Jordan Justen wrote:
> >>
> >> I was suggesting that if they didn't specify -n as a param to
> >> build.sh, then build.sh should not send -n to the
On 2019-07-22 13:06:03, Laszlo Ersek wrote:
> On 07/22/19 09:11, Jordan Justen wrote:
>
> > It looks like if we tweaked things more, and omitted adding the -n
> > parameter to the build command by default, then it would use the
> > Conf/target.txt value, which by default
I'd kind of like to remove the ADD_QEMU_HDA support. I think, way, way
back qemu would not boot if no drives were added, so this kind of
helped. (OVMF can still load the shell with no drives.)
If qemu will still run the firmware without a drive, then maybe maybe
we can just dump ADD_QEMU_HDA.
On 2019-07-23 18:51:00, wrote:
> Specify the firmware to use via the newer '-drive if=pflash' syntax
> which allows specifying the raw format and readonly parameters. This
> avoids warnings with newer version of QEMU.
>
> Signed-off-by: Rebecca Cran
> ---
> OvmfPkg/build.sh | 2 +-
> 1 file
On 2019-07-23 18:20:31, wrote:
> Running qemu before building the firmware image doesn't make much sense.
> Move things so qemu is run after building OvmfPkg.
>
> Signed-off-by: Rebecca Cran
> ---
> OvmfPkg/build.sh | 11 +--
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff
On 2019-07-24 05:27:28, Philippe Mathieu-Daudé wrote:
> On 7/24/19 4:54 AM, Jordan Justen wrote:
> > On 2019-07-23 18:51:00, wrote:
> >> Specify the firmware to use via the newer '-drive if=pflash' syntax
> >> which allows specifying the raw format and readonly p
On 2019-07-24 05:21:35, Philippe Mathieu-Daudé wrote:
> On 7/23/19 2:32 AM, rebe...@bsdio.com wrote:
> > Enable multithreaded builds by default when building OvmfPkg
> > using build.sh.
> > This can drastically reduce build times. For example, on a
> > modern ThreadRipper system the time required
On 2019-07-24 10:39:20, Philippe Mathieu-Daudé wrote:
> On 7/24/19 7:26 PM, Jordan Justen wrote:
> > Hmm, it looks like qemu 2.0 is when the multiple flash device support
> > was added: https://wiki.qemu.org/ChangeLog/2.0
> >
> > The build.sh script currently attem
Reviewed-by: Jordan Justen
On 2019-07-24 14:44:04, Rebecca Cran wrote:
> Specify the firmware to use via the newer '-drive if=pflash' syntax
> which allows specifying the raw format parameter. This
> avoids warnings with newer version of QEMU.
>
> Signed-off-by: Rebecca Cran
&
Reviewed-by: Jordan Justen
On 2019-07-24 14:44:05, Rebecca Cran wrote:
> $ADD_QEMU_HDA was added because QEMU used to refuse to run without a
> disk. Since newer versions run without any disks, remove it.
>
> Signed-off-by: Rebecca Cran
> ---
> OvmfPkg/build.sh | 14 --
Reviewed-by: Jordan Justen
0dd8d7d556df46c503254d37b22b2b34f6ad12f6
But I still forgot to fix up your git author name after applying the
patch. :\
On 2019-07-24 18:35:40, wrote:
> Signed-off-by: Rebecca Cran
> ---
> OvmfPkg/build.sh | 2 +-
> 1 file changed, 1 insertion(+)
Maybe a commit message tweak would be:
OvmfPkg/build.sh: enable multithreaded build by default
On 2019-07-21 17:58:16, Rebecca Cran wrote:
> When building both BaseTools and OvmfPkg, enable multiprocessor builds,
> using up to the number of cores available in the system. This can
> drastically
Reviewed-by: Jordan Justen
On 2019-10-21 13:13:20, Laszlo Ersek wrote:
> From: Peter Jones
>
> Currently some tests check the value of SOURCE_DEBUG_ENABLE, and some
> tests check if it's defined or not. Additionally, in UefiPayloadPkg as
> well as some other trees, we def
On 2019-10-10 09:32:19, Laszlo Ersek wrote:
> Hi Liming, Andrew,
>
> On 10/10/19 14:32, Liming Gao wrote:
> > Laszlo:
> >
> >> -Original Message-
> >> From: Laszlo Ersek
> >> Sent: Wednesday, October 9, 2019 4:22 AM
> >> To: Gao, Liming ; devel@edk2.groups.io;
> >> af...@apple.com
> >>
On 2020-01-02 07:25:53, Philippe Mathieu-Daude wrote:
> To avoid patches committed with incorrect email address,
> use the EmailAddressCheck class on the committer email too.
>
> Cc: Liming Gao
> Cc: Jordan Justen
> Signed-off-by: Philippe Mathieu-Daude
> ---
> RFC b
On 2019-12-19 06:12:56, Philippe Mathieu-Daudé wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=113
>
> Strip the trailing characters before checking the subject line is
> less than 72 characters.
>
> Fixes: e61406708c83f
> Cc: Liming Gao
> Cc: Jor
Cc: Andrew Fish
Cc: Ray Ni
Signed-off-by: Jordan Justen
---
Maintainers.txt | 1 -
1 file changed, 1 deletion(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index 2cd356551e..96e792ab66 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -197,7 +197,6 @@ M: Ard Biesheuvel
EmulatorPkg
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Jordan Justen
---
Maintainers.txt | 1 -
1 file changed, 1 deletion(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index 96e792ab66..e986a3680c 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -423,7 +423,6 @@ R: Siyuan Fu
OvmfPkg
Cc: Andrew Fish
Cc: Ray Ni
Signed-off-by: Jordan Justen
Reviewed-by: Andrew Fish
---
Maintainers.txt | 1 -
1 file changed, 1 deletion(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index 2cd356551e..96e792ab66 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -197,7 +197,6 @@ M: Ard
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Jordan Justen
---
Maintainers.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index 96e792ab66..e384971238 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -423,9 +423,9 @@ R
On 2023-10-28 12:23:30, Michael D Kinney wrote:
> @@ -497,7 +463,6 @@ F: OvmfPkg/
> W: http://www.tianocore.org/ovmf/
> M: Ard Biesheuvel [ardbiesheuvel]
> M: Jiewen Yao [jyao1]
> -R: Jordan Justen [jljusten]
> R: Gerd Hoffmann [kraxel]
> S: Maintained
Ac
66 matches
Mail list logo
