Re: [edk2-devel] [PATCH v3 03/18] StandaloneMmPkg: StandaloneMmCoreHobLib: Extend support for x64 Mm Core

Hi Jiewen/Ard/Sami/Supreeth, I updated this patch in v2 to centralize common implementations for certain library functions. Do you by any chance have more comments on this patch? Any input is appreciated. Regards, Kun From: Kun Qin<mailto:ku...@outlook.com> Sent: Thursday, January 14, 2

Re: [edk2-devel] [PATCH v3 05/18] StandaloneMmPkg: StandaloneMmMemLib: Extends support for X64 architecture

168>. It introduces a new proposal to allow access of DXE/RT regions from MMRAM, but requires non trivial change. Please let me know if you hold different opinions towards the proposal or this patch. Thanks, Kun From: Kun Qin<mailto:ku...@outlook.com> Sent: Thursday, January 14, 2021 14:36 To

Re: [edk2-devel] [PATCH v3 01/18] BaseTools: Ecc/exception: Added _ModuleEntryPoint into exception list

Hi Bob/Liming/Yuwei, Do you mind providing some feedback on this patch? This is to unblock the second patch (adding driver entry point instance for Standalone X64) of this patch series. Thanks in advance! Regards, Kun From: Kun Qin<mailto:ku...@outlook.com> Sent: Thursday, January 14, 2

Re: [edk2-devel] [PATCH v3 01/18] BaseTools: Ecc/exception: Added _ModuleEntryPoint into exception list

stance for StandaloneMmCoreEntryPoint library and failed on ECC check 8006 due to the function name involved. Regards, Kun From: gaoliming<mailto:gaolim...@byosoft.com.cn> Sent: Wednesday, January 20, 2021 17:45 To: 'Kun Qin'<mailto:ku...@outlook.com>; devel@edk2.groups.io<mailto:devel@edk2.gro

Re: [edk2-devel] [PATCH v3 12/18] PcAtChipsetPkg: AcpiTimerLib: Added StandaloneMm instance of AcpiTimerLib

Hi Ray, I updated the file names as suggested on the previous round. Do you have any further comments/feedback? Thanks, Kun From: Kun Qin<mailto:ku...@outlook.com> Sent: Thursday, January 14, 2021 14:37 To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> Cc: Ray Ni<mailto:r

Re: [edk2-devel] [PATCH v3 17/18] UefiCpuPkg: CpuIo2Smm: Support of CpuIo driver under StandaloneMm

Hi Ray, I was suggested not to rename the file for review easiness and git history concern during v2 patch. Thread here: Re: [PATCH v2 15/16] UefiCpuPkg: CpuIo2Smm: Support of CpuIo driver under StandaloneMm (groups.io) Please let me know if you

Re: [edk2-devel] [PATCH v3 17/18] UefiCpuPkg: CpuIo2Smm: Support of CpuIo driver under StandaloneMm

Ray, Thanks for confirming. I will add the renaming patch in v4. Regards, Kun From: Ni, Ray<mailto:ray...@intel.com> Sent: Thursday, January 21, 2021 22:29 To: Kun Qin<mailto:ku...@outlook.com>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> Cc: Dong, Eric<mailt

Re: [edk2-devel] [PATCH v3 17/18] UefiCpuPkg: CpuIo2Smm: Support of CpuIo driver under StandaloneMm

Thanks for clarification. Will do. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#70693): https://edk2.groups.io/g/devel/message/70693 Mute This Topic: https://groups.io/mt/79688598/21656 Group Owner: devel+ow...@edk2.groups.io

Re: [edk2-devel] [PATCH v4 00/20] Extends Support of MM_STANDALONE Type Modules to X64

is merged ea56ebf67dd55483105aa9f9996a48213e78337e..3b468095cd3dfcd1aa4ae63bc623f534bc2390d2. Thanks Liming 发件人: bounce+27952+71028+4905953+8761...@groups.io 代表 Kun Qin 发送时间: 2021年2月2日 2:47 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn 抄送: 'Bob Feng' ; 'Yuwei Chen' ; 'Jian J Wang' ; 'Ha

[edk2-devel] [PATCH v4 09/20] MdeModulePkg: FirmwarePerformanceDataTable: Added StandaloneMm support

Wang Cc: Hao A Wu Cc: Dandan Bi Cc: Liming Gao Signed-off-by: Kun Qin Reviewed-by: Hao A Wu --- Notes: v4: - Previously reviewed. No change. v3: - Added reviewed-by tag [Hao] v2: - Removed "EFIAPI" for internally abstracted functions [Hao] - Supp

[edk2-devel] [PATCH v4 04/20] StandaloneMmPkg: StandaloneMmCoreMemoryAllocationLib: Fix compiler warning

type cast before value assignment. Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Jiewen Yao Cc: Supreeth Venkatesh Signed-off-by: Kun Qin Reviewed-by: Jiewen Yao --- Notes: v4: - Reviewed previously, no change v3: - Added reviewed-by tag [Jiewen] v2: - Changed variable typ

[edk2-devel] [PATCH v4 05/20] StandaloneMmPkg: StandaloneMmMemLib: Extends support for X64 architecture

This change extends StandaloneMmMemLib library to support X64 architecture. The implementation is ported from MdePkg/Library/SmmMemLib. Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Jiewen Yao Cc: Supreeth Venkatesh Signed-off-by: Kun Qin Reviewed-by: Jiewen Yao --- Notes: v4: - Added

[edk2-devel] [PATCH v4 13/20] PcAtChipsetPkg: AcpiTimerLib: Added StandaloneMm instance of AcpiTimerLib

This change added a new instance of AcpiTimerLib for StandaloneMm core and drivers. It centralizes the common routines into shared files and abstract the library constructor into corresponding files to accommodate each constructor function prototypes. Cc: Ray Ni Signed-off-by: Kun Qin Reviewed

[edk2-devel] [PATCH v4 06/20] MdeModulePkg: SmmLockBoxSmmLib: Support StandaloneMm for SmmLockBoxLib

Signed-off-by: Kun Qin Reviewed-by: Hao A Wu --- Notes: v4: - Previously reviewed. No change. v3: - Previously reviewed. No change. v2: - Removed "EFIAPI" for internal library functions [Hao] - Added Reviewed-by tag [Hao] MdeModulePkg/Library/Smm

[edk2-devel] [PATCH v4 07/20] MdeModulePkg: SmmReportStatusCodeLib: ReportStatusCodeLib in StandaloneMm

Wang Cc: Hao A Wu Cc: Dandan Bi Cc: Liming Gao Cc: Jiewen Yao Signed-off-by: Kun Qin Reviewed-by: Hao A Wu --- Notes: v4: - Previously reviewed. No change. v3: - Added reviewed-by tag [Hao] v2: - Removed "EFIAPI" for internal functions. - Mino

[edk2-devel] [PATCH v4 14/20] SecurityPkg: Tcg2PhysicalPresenceLib: Introduce StandaloneMm instance

Cc: Qi Zhang Cc: Rahul Kumar Signed-off-by: Kun Qin Reviewed-by: Jiewen Yao --- Notes: v4: - Previously reviewed. No change. v3: - Previously reviewed. No change. v2: - Added Reviewed-by tag [Jiewen] - Removed "EFIAPI" for internal functions

[edk2-devel] [PATCH v4 08/20] MdeModulePkg: StatusCodeHandler: StatusCodeHandler driver in StandaloneMm

Cc: Dandan Bi Cc: Liming Gao Cc: Jiewen Yao Signed-off-by: Kun Qin Reviewed-by: Hao A Wu --- Notes: v4: - Previously reviewed. No change. v3: - Added reviewed-by tag [Hao] v2: - New patch to support StatusCodeHandler in standalone mm [Liming] MdeModulePkg/Universal

[edk2-devel] [PATCH v4 15/20] SecurityPkg: Tcg2PpVendorLibNull: Added support for MM_STANDALONE type

This change extends this null instance of Tcg2PpVendorLib to support MM_STANDALONE drivers. Cc: Jiewen Yao Cc: Jian J Wang Cc: Qi Zhang Cc: Rahul Kumar Signed-off-by: Kun Qin Reviewed-by: Jiewen Yao --- Notes: v4: - Previously reviewed. No change. v3: - Previously

[edk2-devel] [PATCH v4 17/20] UefiCpuPkg: CpuIo2Smm: Move CpuIo2Smm driver to consume gMmst

This change replaced gSmst with gMmst to support broader compatibility under MM environment for CpuIo2Smm driver. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Cc: Rahul Kumar Signed-off-by: Kun Qin Reviewed-by: Laszlo Ersek Reviewed-by: Ray Ni --- Notes: v4: - Added reviewed-by tag

[edk2-devel] [PATCH v4 10/20] MdeModulePkg: ReportStatusCodeRouter: Support StandaloneMm RSC Router

maximal common implementations. Cc: Jian J Wang Cc: Hao A Wu Cc: Dandan Bi Cc: Liming Gao Signed-off-by: Kun Qin Reviewed-by: Hao A Wu --- Notes: v4: - Previously reviewed. No change. v3: - Added reviewed-by tag [Hao] - Updated function descriptions to match function

[edk2-devel] [PATCH v4 18/20] UefiCpuPkg: CpuIo2Smm: Abstract SMM specific functions into separate file

Kumar Signed-off-by: Kun Qin --- Notes: v4: - Newly created patch to rename files for existed SMM driver [Ray] UefiCpuPkg/CpuIo2Smm/{CpuIo2Smm.c => CpuIo2Mm.c} | 11 +- UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.c | 385 +--- UefiCpuPkg/CpuIo2Smm/{CpuIo2Sm

[edk2-devel] [PATCH v4 16/20] SecurityPkg: Tpm2DeviceLibDTpm: Introduce StandaloneMm instance

-by: Kun Qin Reviewed-by: Jiewen Yao --- Notes: v4: - Previously reviewed. No change. v3: - Previously reviewed. No change. v2: - Added Reviewed-by tag [Jiewen] - Removed "EFIAPI" for internal functions SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Devic

[edk2-devel] [PATCH v4 12/20] MdePkg: UefiDevicePathLib: Support UefiDevicePathLib under StandaloneMm

This change added an instance of UefiDevicePathLib for StandaloneMm. It abstracts DevicePathFromHandle function into different files for Standalone MM and other instances to avoid linking gBS into MM_STANDALONE drivers. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Kun

[edk2-devel] [PATCH v4 11/20] MdeModulePkg: SmmSmiHandlerProfileLib: Support StandaloneMm Instance

implementations. Cc: Jian J Wang Cc: Hao A Wu Cc: Eric Dong Cc: Ray Ni Signed-off-by: Kun Qin --- Notes: v4: - Newly created for SmmSmiHandlerProfileLib coverage. MdeModulePkg/Library/SmmSmiHandlerProfileLib/{SmmSmiHandlerProfileLib.c => MmSmiHandlerProfileLib.c} |

[edk2-devel] [PATCH v4 03/20] StandaloneMmPkg: StandaloneMmCoreHobLib: Extend support for x64 Mm Core

heuvel Cc: Sami Mujawar Cc: Jiewen Yao Cc: Supreeth Venkatesh Signed-off-by: Kun Qin Reviewed-by: Jiewen Yao --- Notes: v4: - Added reviewed-by tag [Jiewen] v3: - Pertains gHobList for AARCH64 instance. v2: - Moved common function implementations into Common

[edk2-devel] [PATCH v4 20/20] UefiCpuPkg: SmmCpuExceptionHandlerLib: Added StandaloneMm module support

This change of SmmCpuExceptionHandlerLib adds support for StandaloneMm components to allow x64 StandaloneMm environment setting up exception handlers. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Cc: Rahul Kumar Signed-off-by: Kun Qin Reviewed-by: Laszlo Ersek Reviewed-by: Ray Ni --- Notes

[edk2-devel] [PATCH v4 19/20] UefiCpuPkg: CpuIo2Smm: Support of CpuIo driver under StandaloneMm

This change adds a new CpuIo driver instance for MM_STANDALONE type. The new driver entrypoint is implemented in a separate file to match the interface definition of MM_STANDALONE modules. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Cc: Rahul Kumar Signed-off-by: Kun Qin --- Notes: v4

[edk2-devel] [PATCH v4 01/20] BaseTools: Ecc/exception: Added _ModuleEntryPoint into exception list

Signed-off-by: Kun Qin Reviewed-by: Liming Gao Reviewed-by: Bob Feng --- Notes: v4: - Added reviewed-by tags [Bob] - Added reviewed-by tags [Liming] v3: - Newly added to fix CI build on changing '_ModuleEntryPoint' BaseTools/Source/Python/Ecc/exception.xml | 4 1 file

[edk2-devel] [PATCH v4 02/20] StandaloneMmPkg: StandaloneMmCoreEntryPoint: Extends support for X64

This change extends StandaloneMmCoreEntryPoint library to support X64 architecture. Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Jiewen Yao Cc: Supreeth Venkatesh Signed-off-by: Kun Qin Reviewed-by: Jiewen Yao --- Notes: v4: - Reviewed previously. No change. v3: - Reviewed

[edk2-devel] [PATCH v4 00/20] Extends Support of MM_STANDALONE Type Modules to X64

: Supreeth Venkatesh Cc: Laszlo Ersek Kun Qin (20): BaseTools: Ecc/exception: Added _ModuleEntryPoint into exception list StandaloneMmPkg: StandaloneMmCoreEntryPoint: Extends support for X64 StandaloneMmPkg: StandaloneMmCoreHobLib: Extend support for x64 Mm Core Stand

Re: [edk2-devel] [PATCH v4 00/20] Extends Support of MM_STANDALONE Type Modules to X64

d from me to merge in these patches. Thanks in advance! Regards, Kun From: Kun Qin<mailto:ku...@outlook.com> Sent: Tuesday, January 26, 2021 11:45 To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> Cc: Bob Feng<mailto:bob.c.f...@intel.com>; Yuwei Chen<mailto:yuwei.c...@

[edk2-devel] [PATCH v2 3/4] ArmPkg: SpellCheck: Update valid acronyms in ExtendedWords

spell errors. Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Signed-off-by: Sean Brogan Signed-off-by: Kun Qin Reviewed-by: Ard Biesheuvel --- Notes: v2: - Moved Kun's signed-off tag to the last - Added reviewed-by tag [Ard] ArmPkg/ArmPkg.ci.yaml | 19

[edk2-devel] [PATCH v2 1/4] StandaloneMmPkg: Core: Spelling error in comment

From: Sean Brogan REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3445 This change fixed a misspelling that was not caught by spell check. Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Jiewen Yao Cc: Supreeth Venkatesh Cc: Sean Brogan Signed-off-by: Sean Brogan Signed-off-by: Kun Qin

[edk2-devel] [PATCH v2 4/4] Azurepipeline: SpellCheck: Enforce Node dependency to use version 14.x

not a function or its return value is not iterable" This change updates the lowest required node version to 14.x to support Cspell functionalities. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Kun Qin Reviewed-by: Ard Biesheuvel --- Notes:

[edk2-devel] [PATCH v2 2/4] ArmPlatformPkg: SpellCheck: Switch spellcheck CI to AuditOnly

potentially numerous spell errors. The correction action is to be revisited by package maintainers once the tool incompatibility is resolved. Cc: Leif Lindholm Cc: Ard Biesheuvel Signed-off-by: Sean Brogan Signed-off-by: Kun Qin Reviewed-by: Ard Biesheuvel --- Notes: v2: - Moved Kun's signed

[edk2-devel] [PATCH v2 0/4] Update Node to 14.x to resolve cspell failure

Cc: Jiewen Yao Cc: Supreeth Venkatesh Kun Qin (1): Azurepipeline: SpellCheck: Enforce Node dependency to use version 14.x Sean Brogan (3): StandaloneMmPkg: Core: Spelling error in comment ArmPlatformPkg: SpellCheck: Switch spellcheck CI to AuditOnly ArmPkg: SpellCheck: Update valid acron

Re: [edk2-devel] [PATCH v1 1/4] StandaloneMmPkg: Core: Spelling error in comment

Hi Ard, Sorry for the confusion and thanks for providing the r-b tag. This should be fixed in v2 patches: https://edk2.groups.io/g/devel/message/76479 Regards, Kun On 06/12/2021 01:22, Ard Biesheuvel wrote: On Sat, 12 Jun 2021 at 05:44, Kun Qin wrote: From: Sean Brogan REF: https

Re: [edk2-devel] [PATCH v1 1/5] EDK2 Code First: PI Specification: EFI_MM_COMMUNICATE_HEADER Update

a code change patch for this library in v2. Thanks for pointing this out. Regards, Kun On 06/11/2021 00:46, Wu, Hao A wrote: -Original Message- From: devel@edk2.groups.io On Behalf Of Kun Qin Sent: Thursday, June 10, 2021 9:43 AM To: devel@edk2.groups.io Cc: Kinney, Michael D ; Liming

Re: [edk2-devel] [PATCH v2 4/4] Azurepipeline: SpellCheck: Enforce Node dependency to use version 14.x

Hi pipeline maintainers, Could you please help reviewing this specific patch? Thanks to Ard, the other patches in this series are already reviewed and merged. Regards, Kun On 06/14/2021 11:34, Kun Qin via groups.io wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3445 Per update

Re: [edk2-devel] [PATCH v1 0/5] EDK2 Code First: PI Specification: Update EFI_MM_COMMUNICATE_HEADER

nclude/UnitTestFrameworkTypes.h). Please correct me if I am wrong. Would you mind letting me know why this is applicable here? We are trying to seek ideas on how to catch developer mistakes caused by this change. So any input is appreciated. Thank you for your work! Best regards, Marvin On 10.06.21 03:42, K

[edk2-devel] [PATCH v1 0/4] Update Node to 14.x to resolve cspell failure

tch v1 branch: https://github.com/kuqin12/edk2/tree/node_14_v1 Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Cc: Jiewen Yao Cc: Supreeth Venkatesh Kun Qin (1): Azurepipeline: SpellCheck: Enf

[edk2-devel] [PATCH v1 2/4] ArmPlatformPkg: SpellCheck: Switch spellcheck CI to AuditOnly

potentially numerous spell errors. The correction action is to be revisited by package maintainers once the tool incompatibility is resolved. Cc: Leif Lindholm Cc: Ard Biesheuvel Signed-off-by: Kun Qin Signed-off-by: Sean Brogan --- ArmPlatformPkg/ArmPlatformPkg.ci.yaml | 2 +- 1 file changed, 1

[edk2-devel] [PATCH v1 1/4] StandaloneMmPkg: Core: Spelling error in comment

From: Sean Brogan REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3445 This change fixed a misspelling that was not caught by spell check. Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Jiewen Yao Cc: Supreeth Venkatesh Cc: Sean Brogan Signed-off-by: Sean Brogan ---

[edk2-devel] [PATCH v1 4/4] Azurepipeline: SpellCheck: Enforce Node dependency to use version 14.x

not a function or its return value is not iterable" This change updates the lowest required node version to 14.x to support Cspell functionalities. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Kun Qin --- .azurepipelines/templates/spell-check-

[edk2-devel] [PATCH v1 3/4] ArmPkg: SpellCheck: Update valid acronyms in ExtendedWords

spell errors. Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Signed-off-by: Kun Qin Signed-off-by: Sean Brogan --- ArmPkg/ArmPkg.ci.yaml | 19 +++ 1 file changed, 19 insertions(+) diff --git a/ArmPkg/ArmPkg.ci.yaml b/ArmPkg/ArmPkg.ci.yaml index

[edk2-devel] [PATCH v1 1/1] Pytool: SpellCheck: Defer path expansion in cspell parameters

From: Sean Brogan REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3454 On Linux the shell expands the wildcard paths and causes multiple files to be missed. This change adds additional quotes to defer expansion in order to bring parity in cspell result. Cc: Sean Brogan Cc: Bret Barkelew

[edk2-devel] [PATCH v1 0/1] SpellCheck plugin inspects fewer files when run on Linux

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3454 When spellcheck plugin invokes cspell to check files, it uses wildcard path patterns, i.e. /**/*.h. On Linux system, this will be expanded by the shell therefore fewer files will be picked up than speficied through original command line.

Re: [edk2-devel] [PATCH v1 3/5] MdeModulePkg: MemoryProfileInfo: Updated MessageLength calculation

, Hao A wrote: -Original Message- From: Kun Qin Sent: Thursday, June 10, 2021 9:43 AM To: devel@edk2.groups.io Cc: Wang, Jian J ; Wu, Hao A Subject: [PATCH v1 3/5] MdeModulePkg: MemoryProfileInfo: Updated MessageLength calculation REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3398

Re: [edk2-devel] CI is failing - June 2021

Thanks for the heads up, Sean. The patch series was just sent for review: https://edk2.groups.io/g/devel/message/76419. The PR that passes all checks against this branch is here: https://github.com/tianocore/edk2/pull/1705 Any feedback is appreciated. Regards, Kun On 06/11/2021 20:41,

Re: 回复: [edk2-devel] [PATCH v1 1/1] Pytool: SpellCheck: Fix incorrect file mask across package matrices

Thanks for the review, Liming. Could you please help merging this patch to the master when you have a chance? Thanks in advance! Kun On 06/10/2021 20:23, gaoliming wrote: Reviewed-by: Liming Gao -邮件原件- 发件人: devel@edk2.groups.io 代表 Kun Qin 发送时间: 2021年6月10日 9:48 收件人: devel@edk2

[edk2-devel] [PATCH v2 6/6] MdePkg: MmCommunication: Extend MessageLength field size to UINT64

: Zhiguang Liu Signed-off-by: Kun Qin --- Notes: v2: - Removed comments with "BZ" MdePkg/Include/Protocol/MmCommunication.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdePkg/Include/Protocol/MmCommunication.h b/MdePkg/Include/Protocol/MmCommunicati

[edk2-devel] [PATCH v2 1/6] EDK2 Code First: PI Specification: EFI_MM_COMMUNICATE_HEADER Update

Fish Cc: Laszlo Ersek Cc: Leif Lindholm Cc: Hao A Wu Signed-off-by: Kun Qin --- Notes: v2: - Updated change impact analysis regarding SmmLockBoxDxeLib [Hao] BZ3430-SpecChange.md | 90 1 file changed, 90 insertions(+) diff --git a/BZ3430-SpecChange.md b/BZ3430

[edk2-devel] [PATCH v2 3/6] MdeModulePkg: MemoryProfileInfo: Updated MessageLength calculation

Cc: Hao A Wu Signed-off-by: Kun Qin --- Notes: v2: - Added a missed case this change should cover [Hao] - Removed "BZ" tags from comments [Hao] MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.c | 28 +++- 1 file changed, 21 insertions(+), 7

[edk2-devel] [PATCH v2 4/6] MdeModulePkg: SmiHandlerProfileInfo: Updated MessageLength calculation

Cc: Hao A Wu Cc: Eric Dong Cc: Ray Ni Signed-off-by: Kun Qin --- Notes: v2: - Updated comments by removing "BZ" tags [Hao] MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-)

[edk2-devel] [PATCH v2 0/6] EDK2 Code First: PI Specification: Update EFI_MM_COMMUNICATE_HEADER

om/kuqin12/edk2/tree/BZ3398-MmCommunicate-Length-v2 Cc: Jian J Wang Cc: Hao A Wu Cc: Eric Dong Cc: Ray Ni Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Andrew Fish Cc: Laszlo Ersek Cc: Leif Lindholm Kun Qin (6): EDK2 Code First: PI Specification: EFI_MM_COMMUNICATE_HEADER U

[edk2-devel] [PATCH v2 2/6] MdeModulePkg: PiSmmIpl: Update MessageLength calculation for MmCommunicate

to definitive size. Cc: Jian J Wang Cc: Hao A Wu Cc: Eric Dong Cc: Ray Ni Signed-off-by: Kun Qin Reviewed-by: Hao A Wu --- Notes: v2: - Removed "BZ" tags from comments and variables [Hao] - Added "Reviewed-by" tag [Hao] MdeModulePkg/Core/PiSmmCo

[edk2-devel] [PATCH v2 5/6] MdeModulePkg: SmmLockBoxDxeLib: Updated MessageLength calculation

Cc: Hao A Wu Cc: Eric Dong Cc: Ray Ni Signed-off-by: Kun Qin --- Notes: v2: - Newly added in v2 MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.c | 23 ++-- 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/MdeModulePkg/Library/SmmLockBoxLib

[edk2-devel] [PATCH v1 0/2] Add MM Configuration PPI definition to MdePkg

/tree/mm_config_ppi_v1 Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Michael Kubacki Kun Qin (2): MdePkg: MmConfiguration: Moved EFI_MM_RESERVED_MMRAM_REGION to PiMmCis.h MdePkg: MmConfiguration: Added definition of MM Configuration PPI MdePkg/Include/Pi/PiMmCis.h

[edk2-devel] [PATCH v1 2/2] MdePkg: MmConfiguration: Added definition of MM Configuration PPI

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3440 MM Configuration PPI was defined in PI Specification since v1.5. This change added definition of such PPI and related GUIDs into MdePkg. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Michael Kubacki Signed-off-by: Kun Qin

[edk2-devel] [PATCH v1 1/2] MdePkg: MmConfiguration: Moved EFI_MM_RESERVED_MMRAM_REGION to PiMmCis.h

-by: Kun Qin --- MdePkg/Include/Pi/PiMmCis.h | 16 MdePkg/Include/Protocol/MmConfiguration.h | 16 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/MdePkg/Include/Pi/PiMmCis.h b/MdePkg/Include/Pi/PiMmCis.h index fdf0591a03d6..422a3ea6c2bb

Re: [edk2-devel] [PATCH v1 0/5] EDK2 Code First: PI Specification: Update EFI_MM_COMMUNICATE_HEADER

6.21 17:34, Laszlo Ersek wrote: On 06/18/21 11:37, Marvin Häuser wrote: On 16.06.21 22:58, Kun Qin wrote: On 06/16/2021 00:02, Marvin Häuser wrote: 2) Is it feasible yet with the current set of supported compilers to support flexible arrays? My impression is that flexible arrays are already

Re: [edk2-devel] [PATCH v2 1/6] EDK2 Code First: PI Specification: EFI_MM_COMMUNICATE_HEADER Update

I can place this file under "CodeFirst" folder on the next round of patch series. It would be helpful to update the code-first process page so that others can be consistent on the process next time. Thanks, Kun On 06/23/2021 03:02, Laszlo Ersek wrote: On 06/18/21 11:02, Kun Qin w

Re: [edk2-devel] [PATCH v1 1/5] EDK2 Code First: PI Specification: EFI_MM_COMMUNICATE_HEADER Update

Otherwise, it will be the burden for the platform owners to review the platform codes following your guide mentioned in this patch. Hoping others can provide some inputs on this. Best Regards, Hao Wu -Original Message----- From: Kun Qin Sent: Wednesday, June 16, 2021 4:51 AM To: Wu, Hao A ;

Re: 回复: [edk2-devel] [PATCH v1 1/2] MdePkg: MmConfiguration: Moved EFI_MM_RESERVED_MMRAM_REGION to PiMmCis.h

: devel@edk2.groups.io 代表 Kun Qin 发送时间: 2021年6月18日 17:48 收件人: devel@edk2.groups.io 抄送: Michael D Kinney ; Liming Gao ; Zhiguang Liu ; Michael Kubacki 主题: [edk2-devel] [PATCH v1 1/2] MdePkg: MmConfiguration: Moved EFI_MM_RESERVED_MMRAM_REGION to PiMmCis.h REF: https://bugzilla.tianocore.org

[edk2-devel] [PATCH v2 1/1] Pytool: SpellCheck: Defer path expansion in cspell parameters

Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Sean Brogan Signed-off-by: Kun Qin Reviewed-by: Sean Brogan Reviewed-by: Bret Barkelew --- Notes: v2: - Added reviewed-by tags [Bret] - Added reviewed-by tag [Sean] - Added signed-off-by tag from Kun [Sean] .pytool/Plugin

[edk2-devel] [PATCH v2 0/1] SpellCheck plugin inspects fewer files when run on Linux

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3454 This patch series is a follow up of previous submission: https://edk2.groups.io/g/devel/message/76427 v2 patch change includes feedback for v1 series: a. Adding "Reviewed-by" tags; b. Adding "Signed-Off-by" tags for myself; Patch v2

Re: [EXTERNAL] Re: [edk2-devel] [PATCH v1 1/1] Pytool: SpellCheck: Defer path expansion in cspell parameters

mailto:michael.d.kin...@intel.com>; Liming Gao <mailto:gaolim...@byosoft.com.cn> *Subject: *[EXTERNAL] Re: [edk2-devel] [PATCH v1 1/1] Pytool: SpellCheck: Defer path expansion in cspell parameters Please update the signed-off-by to include yours. Reviewed-by: Sean Brogan Thanks S

[edk2-devel] [PATCH v1 2/5] MdeModulePkg: PiSmmIpl: Update MessageLength calculation for MmCommunicate

to definitive size. Cc: Jian J Wang Cc: Hao A Wu Cc: Eric Dong Cc: Ray Ni Signed-off-by: Kun Qin --- MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c | 13 - MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf | 1 + 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Core

[edk2-devel] [PATCH v1 4/5] MdeModulePkg: SmiHandlerProfileInfo: Updated MessageLength calculation

Cc: Hao A Wu Cc: Eric Dong Cc: Ray Ni Signed-off-by: Kun Qin --- MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c b

[edk2-devel] [PATCH v1 5/5] MdePkg: MmCommunication: Extend MessageLength field size to UINT64

: Zhiguang Liu Signed-off-by: Kun Qin --- MdePkg/Include/Protocol/MmCommunication.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MdePkg/Include/Protocol/MmCommunication.h b/MdePkg/Include/Protocol/MmCommunication.h index 34c3e2b5a9e3..24d88d3e0b68 100644 --- a/MdePkg/Include

[edk2-devel] [PATCH v1 1/1] Pytool: SpellCheck: Fix incorrect file mask across package matrices

From: Sean Brogan REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3443 Existing implementation could modify class global data that causes potential incorrect file mask to be used for execution of plugin. This change switches class variable to be tuple so that it cannot be accidently

[edk2-devel] [PATCH v1 0/1] Spell Check File Mask Leak into Sequential Package Checks

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3443 Current spell check routine on CI build pipelines is ignoring some files incorrectly. The issue is class variable, STANDARD_PLUGIN_DEFINED_PATHS from SpellCheck.py, is a list. In a local function the list is assigned to a local variable,

[edk2-devel] [PATCH v1 3/5] MdeModulePkg: MemoryProfileInfo: Updated MessageLength calculation

Cc: Hao A Wu Signed-off-by: Kun Qin --- MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.c | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.c b/MdeModulePkg/Application

[edk2-devel] [PATCH v1 0/5] EDK2 Code First: PI Specification: Update EFI_MM_COMMUNICATE_HEADER

Wang Cc: Hao A Wu Cc: Eric Dong Cc: Ray Ni Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Andrew Fish Cc: Laszlo Ersek Cc: Leif Lindholm Kun Qin (5): EDK2 Code First: PI Specification: EFI_MM_COMMUNICATE_HEADER Update MdeModulePkg: PiSmmIpl: Update MessageLength calculation

[edk2-devel] [PATCH v1 1/5] EDK2 Code First: PI Specification: EFI_MM_COMMUNICATE_HEADER Update

Fish Cc: Laszlo Ersek Cc: Leif Lindholm Signed-off-by: Kun Qin --- BZ3430-SpecChange.md | 88 1 file changed, 88 insertions(+) diff --git a/BZ3430-SpecChange.md b/BZ3430-SpecChange.md new file mode 100644 index ..33a1ffda447b --- /dev/null +++ b/BZ3430

[edk2-devel] [PATCH v1 1/1] MdePkg: MmControl: Fix function and structure definition mismatches

names. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Fixes: 6f33f7a262314af35e2b99c849e08928ea49aa55 Signed-off-by: Kun Qin --- MdePkg/Include/Ppi/MmControl.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/MdePkg/Include/Ppi/MmControl.h b/MdePkg/Includ

[edk2-devel] [PATCH v1 0/1] Fix function and structure definition mismatches in Ppi/MmControl.h

. This change corrected the name discrepancies in this header file. Patch v1 branch: https://github.com/kuqin12/edk2/tree/mm_control_ppi_v1 Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Kun Qin (1): MdePkg: MmControl: Fix function and structure definition mismatches MdePkg/Include/Ppi

[edk2-devel] [PATCH v2 1/2] MdePkg: MmConfiguration: Move definition of EFI_MM_RESERVED_MMRAM_REGION

-off-by: Kun Qin --- Notes: v2: - Changed definition from PiMmCis to PiMultiPhase [Liming] MdePkg/Include/Pi/PiMultiPhase.h | 16 MdePkg/Include/Protocol/MmConfiguration.h | 16 2 files changed, 16 insertions(+), 16 deletions(-) diff --git

[edk2-devel] [PATCH v2 0/2] Add MM Configuration PPI definition to MdePkg

to PiMultiPhase; b. Updated inclusion in new file accordingly; Patch v2 branch: https://github.com/kuqin12/edk2/tree/mm_config_ppi_v2 Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Michael Kubacki Kun Qin (2): MdePkg: MmConfiguration: Move definition of EFI_MM_RESERVED_MMRAM_REGION

[edk2-devel] [PATCH v2 2/2] MdePkg: MmConfiguration: Added definition of MM Configuration PPI

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3440 MM Configuration PPI was defined in PI Specification since v1.5. This change added definition of such PPI and related GUIDs into MdePkg. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Michael Kubacki Signed-off-by: Kun Qin

Re: [EXTERNAL] Re: [edk2-devel] [PATCH v1 0/5] EDK2 Code First: PI Specification: Update EFI_MM_COMMUNICATE_HEADER

*From:*devel@edk2.groups.io *On Behalf Of *Bret Barkelew via groups.io *Sent:* Tuesday, June 29, 2021 9:00 AM *To:* Marvin Häuser ; Laszlo Ersek ; Kun Qin ; Kinney, Michael D ; devel@edk2.groups.io *Cc:* Wang, Jian J ; Wu, Hao A ; Dong, Eric ; Ni, Ray ; Liming Gao ; Liu, Zhiguang ; Andrew

Re: [edk2-devel] [PATCH v1 0/5] EDK2 Code First: PI Specification: Update EFI_MM_COMMUNICATE_HEADER

-Original Message- From: Marvin Häuser Sent: Thursday, June 24, 2021 1:00 AM To: Kun Qin ; Laszlo Ersek ; devel@edk2.groups.io Cc: Wang, Jian J ; Wu, Hao A ; Dong, Eric ; Ni, Ray ; Kinney, Michael D ; Liming Gao ; Liu, Zhiguang ; Andrew Fish ; Leif Lindholm ; Bret Barkelew ; michael.kuba

Re: [EXTERNAL] Re: [edk2-devel] [PATCH v1 0/5] EDK2 Code First: PI Specification: Update EFI_MM_COMMUNICATE_HEADER

compatibility with UEFI ABI. The compiler issue must be resolved before the new compiler or change to existing compiler are accepted. Mike -Original Message- From: Kun Qin Sent: Tuesday, June 29, 2021 4:11 PM To: Kinney, Michael D ; devel@edk2.groups.io; bret.barke...@microsoft.com; Marvin

Re: [edk2-devel] [PATCH v1 0/1] Introduce DxeMmUnblockMemoryLib Interface

Hi Hao, These 2 modules seems to be the only ones need to be updated when we scrubbed and validated our code base. I will prepare for the tcg2 and variable module patches. Thanks, Kun -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online

Re: [edk2-devel] [PATCH v1 0/1] Introduce DxeMmUnblockMemoryLib Interface

Hi Hao, As mentioned in the cover letter and in BZ-3168, VariableStandaloneMm and Tcg2Smm would need this capability to unblock certain regions in order to access either variable runtime cache or NVS region patched into ACPI table, if non-MMRAM region is blocked for access. Just as a preview

[edk2-devel] [PATCH v2 0/6] Add DxeMmUnblockMemoryLib Interface and Usages

: Liming Gao Cc: Jiewen Yao Cc: Qi Zhang Cc: Rahul Kumar Kun Qin (6): MdeModulePkg: DxeMmUnblockMemoryLib: Added definition and null instance MdeModulePkg: VariableSmmRuntimeDxe: Added request unblock memory interface SecurityPkg: Tcg2Smm: Switching from gSmst to gMmst SecurityPkg

[edk2-devel] [PATCH v2 2/6] MdeModulePkg: VariableSmmRuntimeDxe: Added request unblock memory interface

: Jian J Wang Cc: Hao A Wu Cc: Liming Gao Signed-off-by: Kun Qin --- Notes: v2: - Newly added in v2. MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.c | 42 MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.inf | 1 + 2 files

[edk2-devel] [PATCH v2 3/6] SecurityPkg: Tcg2Smm: Switching from gSmst to gMmst

This change replaced gSmst with gMmst to support broader compatibility under MM environment for Tcg2Smm driver. Cc: Jiewen Yao Cc: Jian J Wang Cc: Qi Zhang Cc: Rahul Kumar Signed-off-by: Kun Qin --- Notes: v2: - Newly added in v2. SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c | 4

[edk2-devel] [PATCH v2 1/6] MdeModulePkg: DxeMmUnblockMemoryLib: Added definition and null instance

Yao Signed-off-by: Kun Qin --- Notes: v2: - Resend with practical usage. No change [Hao] MdeModulePkg/Library/DxeMmUnblockMemoryLib/DxeMmUnblockMemoryLibNull.c | 40 MdeModulePkg/Include/Library/DxeMmUnblockMemoryLib.h | 40

[edk2-devel] [PATCH v2 4/6] SecurityPkg: Tcg2Smm: Separate Tcg2Smm into 2 modules

: Jian J Wang Cc: Qi Zhang Cc: Rahul Kumar Signed-off-by: Kun Qin --- Notes: v2: - Newly added in v2. v2: - Newly added. SecurityPkg/Tcg/{Tcg2Smm/Tcg2Smm.c => Tcg2Acpi/Tcg2Acpi.c} | 350 SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c |

[edk2-devel] [PATCH v2 5/6] SecurityPkg: Tcg2Smm: Added support for Standalone Mm

for Tcg2 Standalone MM module is added. Cc: Jiewen Yao Cc: Jian J Wang Cc: Qi Zhang Cc: Rahul Kumar Signed-off-by: Kun Qin --- Notes: v2: - Newly added. SecurityPkg/Library/Tcg2MmDependencyLib/Tcg2MmDependencyLib.c | 48 SecurityPkg/Tcg/Tcg2Smm/Tcg2StandaloneMm.c

[edk2-devel] [PATCH v2 6/6] SecurityPkg: Tcg2Acpi: Added unblock memory interface for NVS region

Signed-off-by: Kun Qin --- Notes: v2: - Newly added in v2. SecurityPkg/Tcg/Tcg2Acpi/Tcg2Acpi.c | 6 ++ SecurityPkg/SecurityPkg.dsc | 1 + SecurityPkg/Tcg/Tcg2Acpi/Tcg2Acpi.inf | 1 + 3 files changed, 8 insertions(+) diff --git a/SecurityPkg/Tcg/Tcg2Acpi/Tcg2Acpi.c b

[edk2-devel] [PATCH v1 1/1] MdeModulePkg: DxeMmUnblockMemoryLib: Added definition and null instance

Yao Signed-off-by: Kun Qin --- MdeModulePkg/Library/DxeMmUnblockMemoryLib/DxeMmUnblockMemoryLibNull.c | 40 MdeModulePkg/Include/Library/DxeMmUnblockMemoryLib.h | 40 MdeModulePkg/Library/DxeMmUnblockMemoryLib

[edk2-devel] [PATCH v1 0/1] Introduce DxeMmUnblockMemoryLib Interface

Dong Cc: Ray Ni Cc: Jiewen Yao Kun Qin (1): MdeModulePkg: DxeMmUnblockMemoryLib: Added definition and null instance MdeModulePkg/Library/DxeMmUnblockMemoryLib/DxeMmUnblockMemoryLibNull.c | 40 MdeModulePkg/Include/Library/DxeMmUnblockMemoryLib.h

Re: [edk2-devel] [PATCH v4 00/20] Extends Support of MM_STANDALONE Type Modules to X64

ary 31, 2021 17:36 To: 'Kun Qin'<mailto:ku...@outlook.com>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> Cc: 'Bob Feng'<mailto:bob.c.f...@intel.com>; 'Yuwei Chen'<mailto:yuwei.c...@intel.com>; 'Jian J Wang'<mailto:jian.j.w...@intel.com>; 'Hao A Wu'<mailto:hao.a...@

[edk2-devel] [PATCH v1 0/1] Add buffer size check before save state read

/svst_width_v1 Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Cc: Rahul Kumar Kun Qin (1): UefiCpuPkg: PiSmmCpuDxeSmm: Check buffer size before accessing UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c | 7 +++ 1 file changed, 7 insertions(+) -- 2.31.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io

[edk2-devel] [PATCH v1 1/1] UefiCpuPkg: PiSmmCpuDxeSmm: Check buffer size before accessing

are written out of buffer boundary. This change adds a width check before copying IoInfo into output buffer. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Cc: Rahul Kumar Signed-off-by: Kun Qin --- UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c | 7 +++ 1 file changed, 7 insertions(+) diff

Re: [edk2-devel] [edk2-platforms][PATCH v2 4/5] Vlv2TbltDevicePkg: PlatformPkg DSC: Added library for VariableSmmRuntimeDxe

Hi Michael/Yi/Zailiang, Would you kindly review the patch below? We can also ignore this one if the package is no longer maintained. Please let me know how you would like to proceed. Thanks in advance. Regards, Kun On 03/18/2021 10:51, Kun Qin via groups.io wrote: Hi Michael, Could you

Re: [edk2-devel] [edk2-platforms][PATCH v2 4/5] Vlv2TbltDevicePkg: PlatformPkg DSC: Added library for VariableSmmRuntimeDxe

patch in a v3 after rewriting the commit message with reviewed-by tag. Thanks in advance! Regards, Kun On 03/30/2021 19:06, Kinney, Michael D wrote: Reviewed-by: Michael D Kinney Mike -Original Message- From: devel@edk2.groups.io On Behalf Of Kun Qin Sent: Tuesday, March 16, 2021 11

Re: [edk2-devel] [PATCH v1 1/1] UefiCpuPkg: PiSmmCpuDxeSmm: Check buffer size before accessing

Hi Laszlo, Thanks for the feedback. I will update the description in v2. Regards, Kun On 04/06/2021 05:09, Laszlo Ersek wrote: On 03/27/21 00:41, Kun Qin wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3283 Current SMM Save State routine does not check the number of bytes

  1   2   3   4   5   6   >