Laszlo:
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Laszlo
> Ersek
> Sent: Wednesday, August 14, 2019 11:13 PM
> To: Gao, Liming ; Kinney, Michael D
> ; devel@edk2.groups.io
> Cc: Mike Turner ; Wang, Jian J
> ; Wu, Hao A ; Bi, Dandan
>
From: Gao, Liming [mailto:liming@intel.com]
Sent: Friday, August 16, 2019 3:59 PM
To: Laszlo Ersek (ler...@redhat.com) ;
leif.lindh...@linaro.org; Kinney, Michael D ;
af...@apple.com; Cetola, Stephano
Cc: edk2-de...@lists.01.org
Subject: Patch List for 201908 stable tag
Hi Stewards and
Hi, all
Now, we enter into Soft Feature Freeze phase. In this phase, the feature
under review will not be allowed to be pushed. The patch review can continue
without break in edk2 community.
If the patch is sent before Soft Feature Freeze, and plans to catch this
stable tag, the patch
Andrew:
This is the history reason. Before, Edk2 BaseTools included the binary
Windows tools in BaseTools\Bin\Win32. There is no
BaseTools/BinWrappers/WindowsLike directory.
When migrate BaseTools Windows tools from binary to source build, Edk2
BaseTools C source is still compiled to
Rebecca:
I am glad that you add this support. But, I want to confirm whether someone
still uses VS2008 or VS2010.
Thanks
Liming
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>rebe...@bsdio.com
>Sent: Thursday, August 22, 2019 8:17 AM
>To:
happened one year
ago. Please see https://edk2.groups.io/g/devel/message/29436.
Liming
Thanks
发件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
mailto:devel@edk2.groups.io>> 代表 Liming Gao
发送时间: 2019年8月19日 22:46
收件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
te in
>UefiLib.c
>
>Cc: Michael D Kinney
>Cc: Liming Gao
>Signed-off-by: Tom Zhao
>---
> MdePkg/Include/Library/UefiLib.h | 16 ++
> MdePkg/Library/UefiLib/UefiLib.c | 59 +---
> 2 files changed, 54 insertions(+), 21 deletions(-)
>
>diff
Laszlo:
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, August 22, 2019 7:56 PM
> To: Gao, Liming
> Cc: devel@edk2.groups.io; Kinney, Michael D ;
> Mike Turner ; Wang, Jian J
> ; Wu, Hao A ; Bi, Dandan
> ; Anthony Perard
> ; Justen, Jordan L
>
Reviewed-by: Liming Gao
> -Original Message-
> From: Feng, Bob C
> Sent: Thursday, August 22, 2019 12:01 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
> Subject: [Patch V2][edk2-stable201908] BaseTools: Incorrect error message for
> libra
Can you follow this process to send this patch again?
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process
And, the commit message format is
https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format
Thanks
Liming
From: devel@edk2.groups.io
LeConfig.h: Add type EfiBluetoothSmpPeerAddressList
>>
>> To support auto-connection, EFI_BLUETOOTH_LE_SMP_DATA_TYPE needs
>to
>> add a new data type EfiBluetoothSmpPeerAddressList which associates
>> with a list of Bluetooth per address connected before.
>>
>&
gt;> Hello,
>>
>> Please refer to the below inline comments:
>>
>>
>> > -Original Message-
>> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>> > Zurcher, Christopher J
>> > Sent: Friday, August 23, 201
Mike:
I add my comments.
>-Original Message-
>From: r...@edk2.groups.io [mailto:r...@edk2.groups.io] On Behalf Of Michael
>D Kinney
>Sent: Friday, August 30, 2019 4:23 AM
>To: devel@edk2.groups.io; r...@edk2.groups.io
>Subject: [edk2-rfc] [RFC] EDK II Continuous Integration Phase 1
>
OK. So, you can't use git send-email to send this patch. Another way is to fork
edk2 and create the branch to include this change.
Then, send the mail to let people review this patch in your branch.
And, for this patch, can you submit BZ https://bugzilla.tianocore.org/ first?
Then, update its
This patch has passed the package maintainer review. So, I push this change
@8b8e91584555b6193f2099a36502763b47501533.
Thanks
Liming
>-Original Message-
>From: Desimone, Nathaniel L
>Sent: Tuesday, September 03, 2019 1:00 PM
>To: devel@edk2.groups.io; xypron.g...@gmx.de; Carsey, Jaben
>;
Reviewed-by: Liming Gao
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ni,
>Ray
>Sent: Tuesday, August 27, 2019 2:16 AM
>To: devel@edk2.groups.io
>Cc: Kinney, Michael D ; Gao, Liming
>
>Subject: [edk2-devel] [PATCH] [ed
-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Liming Gao
>Sent: Monday, September 2, 2019 9:31 AM
>To: devel@edk2.groups.io
>Cc: Feng, Bob C
>Subject: [edk2-devel] [Patch] BaseTools: Update GenFw tool to support -e -z
>opt
Bob:
This fix is clear. Reviewed-by: Liming Gao
Thanks
Liming
> -Original Message-
> From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
> Sent: Wednesday, August 28, 2019 10:01 PM
> To: devel@edk2.groups.io; Feng, Bob C
> Cc: Gao, Liming
> Subject: Re: [edk2-d
Bob:
This is the critical regression issue for the incremental build. I request to
catch it in this stable tag 201908.
This patch corrects the behavior. Reviewed-by: Liming Gao
Thanks
Liming
> -Original Message-
> From: Feng, Bob C
> Sent: Wednesday, August 28, 201
[edk2-stable201908] BaseTools: fix an
> > incremental build issue.
> >
> > Bob:
> > This is the critical regression issue for the
> > incremental build. I request to catch it in this stable
> > tag 201908.
> >
> > This patch corrects the behavior. Rev
ay
From: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
mailto:devel@edk2.groups.io>> On Behalf Of Liming Gao
Sent: Wednesday, August 28, 2019 12:59 AM
To: jayanth.raghu...@dell.com<mailto:jayanth.raghu...@dell.com>;
devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc
Acked-by: Michael D Kinney
> >
> > Thanks,
> >
> > Mike
> >
> >> -Original Message-
> >> From: Gao, Liming
> >> Sent: Wednesday, August 28, 2019 8:22 AM
> >> To: Leif Lindholm ; devel@edk2.groups.io;
> >> F
edk2\Readme.md Submodules section gives the command to update edk2 project.
Thanks
Liming
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>rebe...@bsdio.com
>Sent: Saturday, August 24, 2019 6:24 AM
>To: devel@edk2.groups.io; af...@apple.com
ks,
> > >> Christopher Zurcher
> > >>
> > >> -Original Message-
> > >> From: Wu, Hao A
> > >> Sent: Monday, August 26, 2019 20:03
> > >> To: devel@edk2.groups.io; Zurcher, Christopher J
> > >>
> > >
a language is supported
>
> BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2100
>
> Add a function that checks if a target language is in the supported
> languages list. Refactor UefiLib to use this function where appropriate
> internally.
>
> Cc: Michael D Kin
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1727
-e -z option is to generate EFI image with zero debug entry.
It can be used to check the EFI image in DEBUG build.
Signed-off-by: Liming Gao
Cc: Bob Feng
---
BaseTools/Source/C/GenFw/GenFw.c | 17 +++--
1 file changed, 15
This change is good to me. Reviewed-by: Liming Gao
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
jayanth.raghu...@dell.com
Sent: Friday, August 30, 2019 12:32 AM
To: devel@edk2.groups.io
Subject: [edk2-devel] Subject: [PATCH v2] MdePkg/DxeHstiLib: Added checks
Reviewed-by: Liming Gao
> -Original Message-
> From: Shi, Steven
> Sent: Tuesday, August 27, 2019 1:17 PM
> To: devel@edk2.groups.io
> Cc: Gao, Liming ; Feng, Bob C ;
> Shi, Steven
> Subject: [PATCH] BaseTools: Support more file types in build cache
>
> F
Push @17f8c9e97d770c74f84194576bcd97322fbed21e
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Liming Gao
Sent: Monday, September 2, 2019 12:15 PM
To: devel@edk2.groups.io; jayanth.raghu...@dell.com
Subject: Re: [edk2-devel] Subject: [PATCH v2] MdePkg/DxeHstiLib: Added
Reviewed-by: Liming Gao
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Bob Feng
> Sent: Wednesday, August 21, 2019 5:57 PM
> To: devel@edk2.groups.io
> Cc: Gao, Liming ; Feng, Bob C
> Subject: [edk2-devel] [Patch]
Done. And, push @30781febe2106cc0d7186e70136120353cd67df2
Thanks
Liming
> -Original Message-
> From: Zeng, Star
> Sent: Tuesday, August 20, 2019 10:00 PM
> To: Gao, Liming ; Kuo, Donald ;
> devel@edk2.groups.io; ler...@redhat.com; Dong, Eric
>
> Cc: Ni, Ray ; Chan, Amy ; Chaganty,
>
ming
> Subject: [Patch][edk2-stable201908] BaseTools: Incorrect error message for
> library instance not found
>
> BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2099
> This is a regression issue introduced by commit e8449e.
>
> This patch is to fix this issue.
>
>
Laszlo:
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Laszlo
> Ersek
> Sent: Wednesday, August 21, 2019 4:46 PM
> To: Gao, Liming ; devel@edk2.groups.io; Kinney, Michael
> D
> Cc: Mike Turner ; Wang, Jian J
> ; Wu, Hao A ; Bi, Dandan
>
>
...@intel.com>
Add a function that checks if a target language is in the supported
languages list. Add some calls to this function where appropriate in
UefiLib.c
Cc: Michael D Kinney
<mailto:michael.d.kin...@intel.com>
Cc: Liming Gao <mailto:liming@intel.com>
Signed-off-by: T
Hi, all
Today, we will enter into Hard Feature Freeze phase until edk2-stable201908
tag is created at 2019-08-30. In this phase, there is no feature to be pushed.
The critical bug fix is still allowed.
If the patch is sent after Hard Feature Freeze, and plans to catch this
stable tag,
Is this warning reported on ARM arch?
In Base.h, VA_START is defined as below for ARM arch. Do you mean VS2017 report
the warning for below macro?
If so, can you propose the change in VA_START macro to fix this warning, then
doesn't need to update consumer source code.
#define
d Link Speeds Vector bit 3 indicate
>> the speed 16 GT/s and bit 4 indicate the speed 32 GT/s.
>> Add the support to shell command 'pci ...'.
>>
>> Change the MaxLinkSpeed other values' result from 'Unknown'
>> to 'Reserved' to make the result align.
>>
>>
for supporting S3 feature.
> So far this driver only install EFI_PEI_MM_ACCESS_PPI for S3 resume case.
>
> Change-Id: Ie5841047be350f411650ad30f16d210b98197dc4
> Cc: Michael Kubacki
> Cc: Sai Chaganty
> Cc: Liming Gao
> Signed-off-by: Marc Chen
> --
teven ;
> Feng, Bob C
> Subject: [edk2-devel] [Patch 1/1] BaseTools: Fixed issue for IgnoreAutoGen
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=2080
>
> This patch is to improve build -u option to re-use
> GlobalVar__.bin file which is
> introduced by multiple-proce
Bob:
Can you list the platform list have been verified with this change?
Thanks
Liming> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Bob Feng
> Sent: Thursday, September 5, 2019 11:11 AM
> To: devel@edk2.groups.io
> Subject: [edk2-devel]
Tom:
Thanks for your update function header with RFC 4646 Languages. Please remove
function name
CompareIso639LanguageCode() in function header. Because this API is UefiLib
internal function,
It is not defined in UefiLib.h. With this update, Reviewed-by: Liming Gao
Thanks
Liming
Ack-by: Liming Gao
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ard
> Biesheuvel
> Sent: Wednesday, September 4, 2019 10:22 PM
> To: Leif Lindholm
> Cc: edk2-devel-groups-io ; Gao, Liming
>
> Subject: Re: [edk2-
Zhichao:
One clarification. What terminal type will be introduced? Xterm, VT400 and
Linux?
Thanks
Liming
From: Gao, Zhichao
Sent: Friday, September 06, 2019 12:56 PM
To: r...@edk2.groups.io
Cc: devel@edk2.groups.io; Gao, Liming ; Xu, Shiwei
Subject: [edk2-rfc] UEFI terminal console keyboard
push@5e5abfcab4c2962005be89c951a86f55db27555e
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Liming Gao
Sent: Tuesday, September 10, 2019 11:23 PM
To: devel@edk2.groups.io; bur...@gmail.com
Subject: Re: [edk2-devel] Increase robustness of nmake BaseTools build for
space
Push @204ae9da230ecbf0910c21acac7aa5d5e8cbb8d0
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Philippe Mathieu-Daudé
>Sent: Tuesday, September 10, 2019 2:30 PM
>To: devel@edk2.groups.io; vit9...@protonmail.com
>Subject: Re: [edk2-devel] [PATCH
Common definitions are not consumed by VFR. They are not required to be
defined in Tcg2ConfigNvData.h with WA way. New shared internal header
file is added to include those common definitions.
Cc: Jian Wang
Cc: Chao Zhang
Signed-off-by: Liming Gao
---
In V2:
Keep struct TCG2_DEVICE_DETECTION
Reviewed-by: Liming Gao
>-Original Message-
>From: Feng, Bob C
>Sent: Wednesday, September 11, 2019 6:14 PM
>To: devel@edk2.groups.io
>Cc: Gao, Liming ; Feng, Bob C
>Subject: [Patch 1/1] BaseTools: Fixed a bug of IgnoreAutoGen
>
>REF: https://bugzilla.tianocore.
Liming Gao
>-Original Message-
>From: Feng, Bob C
>Sent: Thursday, September 05, 2019 10:06 PM
>To: devel@edk2.groups.io; Feng, Bob C ; Gao, Liming
>
>Cc: Shi, Steven
>Subject: RE: [edk2-devel] [Patch 1/1] BaseTools: Fixed issue for
>IgnoreAutoGen
>
>Sorry
Reviewed-by: Liming Gao
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Vitaly Cheptsov via Groups.Io
>Sent: Saturday, August 17, 2019 7:58 AM
>To: devel@edk2.groups.io
>Subject: [edk2-devel] [PATCH v1 0/3] Repl
Reviewed-by: Liming Gao
>-Original Message-
>From: Feng, Bob C
>Sent: Thursday, September 05, 2019 5:45 PM
>To: devel@edk2.groups.io
>Cc: Gao, Liming ; Feng, Bob C
>Subject: [Patch 1/1] BaseTools: Fix a bug for Hii Pcd override
>
>BZ: https://bugzilla.tianocore.
Reviewed-by: Liming Gao
> -Original Message-
> From: Feng, Bob C
> Sent: Monday, September 9, 2019 9:14 AM
> To: devel@edk2.groups.io
> Cc: Gao, Liming ; Shi, Steven ;
> Feng, Bob C
> Subject: [Patch 1/1] BaseTools: Fixed build clean regression
Sorry, should be Acked-by: Liming Gao
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Liming Gao
>Sent: Monday, September 09, 2019 2:59 PM
>To: Feng, Bob C ; devel@edk2.groups.io
>Cc: Shi, Steven
>Subject: Re: [e
Sec input file is allow to be non-existent.
>
>This patch is to let "make" continue if gensec input file not exist.
>
>Cc: Liming Gao
>Signed-off-by: Bob Feng
>---
> BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(
Vitaly:
I see https://edk2.groups.io/g/devel/message/45743 and
https://edk2.groups.io/g/devel/message/45691 gives RB.
If no other comments, I will push this change this week.
Thanks
Liming
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Vitaly
Cheptsov via Groups.Io
Reviewed-by: Liming Gao
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Bob Feng
>Sent: Wednesday, September 04, 2019 3:54 PM
>To: devel@edk2.groups.io
>Cc: Feng, Bob C ; Gao, Liming
>; Shi, Steven
>Subject: [edk2-deve
Reviewed-by: Liming Gao
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Burt
Silverman
Sent: Sunday, September 8, 2019 6:10 AM
To: devel@edk2.groups.io
Subject: [edk2-devel] Increase robustness of nmake BaseTools build for space
also used by make
Author: Burt Silverman
Bob:
I have no other comments for this patch set. Reviewed-by: Liming Gao
Thanks
Liming
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Bob Feng
> Sent: Friday, September 6, 2019 9:23 PM
> To: devel@edk2.groups.io
> Subje
gzilla.tianocore.org/show_bug.cgi?id=1302
> >
> >If GenSec input file not exist, the related command will fail and make
> >will stop on Linux. GenSec input file is allow to be non-existent.
> >
> >This patch is to let "make" continue if gensec input file not exist
vswhere
> to get the correct VS2017/VS2019's InstallationPath
>
> Change-Id: I72d5ef66fd39d3d42b0b2ea57199b4fa27260ab6
Remove Change-Id.
> Cc: Amy Chan
> Cc: Bob Feng
> Cc: Liming Gao
> Signed-off-by: Ching JenX Cheng
> ---
> BaseTools/get_vsvars.bat| 39 ++
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2196
Network related guid definitions have been moved into NetworkPkg.dec.
So, they can be removed from MdeModulePkg.dec.
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Liming Gao
---
MdeModulePkg/MdeModulePkg.dec | 10 --
1 file changed
Cc: Siyuan Fu
Cc: Jiaxin Wu
Signed-off-by: Liming Gao
---
NetworkPkg/ArpDxe/ArpDxe.inf | 1 -
NetworkPkg/Dhcp4Dxe/Dhcp4Dxe.inf | 1 -
NetworkPkg/DnsDxe/DnsDxe.inf | 1 -
NetworkPkg/HttpDxe/HttpDxe.inf | 1 -
NetworkPkg
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2195
Cc: Siyuan Fu
Cc: Jiaxin Wu
Signed-off-by: Liming Gao
---
NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
b/NetworkPkg/UefiPxeBcDxe
Cc: Siyuan Fu
Cc: Jiaxin Wu
Cc: Jian J Wang
Cc: Hao A Wu
Liming Gao (6):
NetworkPkg: Move network related header files from MdeModulePkg to
NetworkPkg
MdeModulePkg: Remove network related guid definitions from
MdeModulePkg.dec
NetworkPkg: Add PcdTftpBlockSize in NetworkPkg.dec
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2195
This PCD has been moved to NetworkPkg.dec file.
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Liming Gao
---
MdeModulePkg/MdeModulePkg.dec | 6 --
MdeModulePkg/MdeModulePkg.uni | 6 --
2 files changed, 12 deletions(-)
diff --git
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2195
PcdTftpBlockSize is network related PCD. It should be defined in NetworkPkg.dec.
Cc: Siyuan Fu
Cc: Jiaxin Wu
Signed-off-by: Liming Gao
---
NetworkPkg/NetworkPkg.dec | 7 +++
NetworkPkg/NetworkPkg.uni | 6 ++
2 files changed, 13
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2196
Cc: Siyuan Fu
Cc: Jiaxin Wu
Signed-off-by: Liming Gao
---
{MdeModulePkg => NetworkPkg}/Include/Guid/Ip4Config2Hii.h | 0
{MdeModulePkg => NetworkPkg}/Include/Guid/Ip4IScsiConfigHii.h | 0
{MdeModulePkg => NetworkPkg}/Inc
Reviewed-by: Liming Gao
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Bob Feng
>Sent: Tuesday, September 10, 2019 5:37 PM
>To: devel@edk2.groups.io
>Subject: [edk2-devel] [Patch 0/3] Clean BaseTools code for build performanc
Push @ea331a5c21f7d71980fe0ea2e4aa425474f8ffb2
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Liming Gao
>Sent: Wednesday, September 11, 2019 10:56 PM
>To: devel@edk2.groups.io; tz...@solarflare.com
>Cc: Kinney, Michael D
&
Push
@0d85e67714e31e0dbe4241ab2ebb7c423aba174d..d8c4b87ec460233d2c6f3e1343b6638f8b4a1ddf
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Liming Gao
>Sent: Monday, September 09, 2019 8:54 AM
>To: devel@edk2.groups.io; vit9...
caused by
>> 0d85e67714e31e0dbe4241ab2ebb7c423aba174d
>>
>> Cc: Hao A Wu
>> Cc: Ray Ni
>> Signed-off-by: Liming Gao
>> ---
>> MdeModulePkg/Universal/SerialDxe/SerialDxe.inf | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>
Fix regression issue caused by 0d85e67714e31e0dbe4241ab2ebb7c423aba174d
Cc: Hao A Wu
Cc: Ray Ni
Signed-off-by: Liming Gao
---
MdeModulePkg/Universal/SerialDxe/SerialDxe.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdeModulePkg/Universal/SerialDxe/SerialDxe.inf
b
how you tested this code, since it
>won't even build. Could you elaborate?
>
>--
>Ard.
>
>
>> Cc: Jian J Wang
>> Cc: Hao A Wu
>> Cc: Ray Ni
>> Cc: Ard Biesheuvel
>> Cc: Laszlo Ersek
>> Cc: Liming Gao
>> Signed-of-by: Zhichao Gao
-by: Liming Gao
---
SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigPeim.c | 1 +
SecurityPkg/Tcg/Tcg2Config/TpmDetection.c | 1 +
SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDxe.inf | 1 +
SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.h | 3 ++
SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigNvData.h | 48
Reviewed-by: Liming Gao
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Laszlo Ersek
>Sent: Wednesday, September 18, 2019 3:49 AM
>To: edk2-devel-groups-io
>Cc: Gao, Liming ; Kinney, Michael D
>
>Subject: [edk2-dev
That's good. I have no other comment. Reviewed-by: Liming Gao
>-Original Message-
>From: Cheng, Ching JenX
>Sent: Wednesday, September 18, 2019 9:51 AM
>To: Gao, Liming ; devel@edk2.groups.io
>Subject: RE: [edk2-devel] [PATCH v2 0/2] *** Add VS2019 Support *
From: mjohn4
Add GetTimeInNanoSecond, already declared in the TimerLib API,
to EmulatorPkg implementations of TimerLib.
Cc: Jordan Justen
Cc: Andrew Fish
Cc: Ray Ni
Signed-off-by: Johnson, Michael
---
.../Library/DxeCoreTimerLib/DxeCoreTimerLib.c | 45 -
Ching:
The change is good. With this change, have you verified VS2017 tool chain?
I want to make sure there is no impact on VS2017.
Thanks
Liming
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Cheng,
> Ching JenX
> Sent: Tuesday,
he
> specification gets released we can take it into edk2.
>
> (After code review, a couple of minor comments below.)
>
> > The major update is to add definitions of SMBIOS Type 44h record.
> >
> > Signed-off-by: Abner Chang
> >
> > Cc: Michael D Kinne
Leif:
> -Original Message-
> From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
> Sent: Tuesday, September 17, 2019 5:15 PM
> To: devel@edk2.groups.io; Zhang, Shenglei
> Cc: ard.biesheu...@linaro.org; Wang, Jian J ; Wu, Hao
> A ; Ni, Ray ;
> Laszlo Erse
Reviewed-by: Liming Gao
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Zhang, Shenglei
>Sent: Monday, September 02, 2019 8:05 PM
>To: devel@edk2.groups.io
>Cc: Kubacki, Michael A ; Chaganty, Rangasai V
>; Gao, Liming
Reviewed-by: Liming Gao
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Zhang, Shenglei
>Sent: Monday, September 02, 2019 8:05 PM
>To: devel@edk2.groups.io
>Cc: Kubacki, Michael A ; Chaganty, Rangasai V
>; Gao, Liming
: [edk2-devel] [PATCH] BaseTools/LzmaCompress: Add two switches
>
>As is requested in the BZ 2077, add two switches to support setting
>compression mode and dictionary size.
>(https://bugzilla.tianocore.org/show_bug.cgi?id=2077)
>
>Cc: Bob Feng
>Cc: Liming Gao
>Signe
Reviewed-by: Liming Gao
>-Original Message-
>From: Zhang, Shenglei
>Sent: Wednesday, September 04, 2019 4:17 PM
>To: devel@edk2.groups.io
>Cc: Kinney, Michael D ; Gao, Liming
>; Yao, Jiewen ; Wang, Jian J
>; Zhang, Chao B
>Subject: [PATCH 0/2] Update lib class h
Reviewed-by: Liming Gao
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Tom Zhao
> Sent: Wednesday, September 11, 2019 10:40 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
>
> Subject: [edk2-devel]
Tom:
I miss one minor comments on doxygen style in function header comments.
Please see below.
The code logic is good to me. Reviewed-by: Liming Gao
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Tom Zhao
> Sent: Wednesday, Sep
er file
>
>Update SmBios header file to conform with SMBIOS v3.3.0.
>The major update is to add definitions of SMBIOS Type 44h record.
>
>Signed-off-by: Abner Chang
>
>Cc: Michael D Kinney
>Cc: Liming Gao
>Cc: Leif Lindholm
>Cc: Gilbert Chen
>---
> MdeModulePkg/Md
> >
>> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2186
>> >
>> > A common terminal console software Putty support various types of
>> > keyboard type, such as normal mode, Linux mode, Xterm R6, Vt400,
>> > VT100+ and SCO. Refer to the l
I add my comments.
>-Original Message-
>From: Baptiste Gerondeau [mailto:baptiste.gerond...@linaro.org]
>Sent: Thursday, September 19, 2019 12:05 AM
>To: devel@edk2.groups.io
>Cc: ard.biesheu...@linaro.org; leif.lindh...@linaro.org; Kinney, Michael D
>; Gao, Liming ; Zhang,
>Shenglei ;
l ; Andrew Fish
>; Ni, Ray ; Johnson
>Subject: Re: [edk2-devel] [Patch] EmulatorPkg/TimerLib: Add missing
>GetTimeInNanoSecond function
>
>On 2019-09-18 01:13:54, Liming Gao wrote:
>> From: mjohn4
>
>It looks like the author is not set properly. If you run "git log -1
fig process
>in Setup Batch Files,
>Because VS2019 and VS2017 could using same vswhere.exe
>to detect the InstallationPath,
>So we add the -version as the parameter of vswhere
>to get the correct VS2017/VS2019's InstallationPath
>
>Cc: Amy Chan
>Cc: Bob Feng
>Cc: Li
Reviewed-by: Liming Gao
>-Original Message-
>From: Gao, Zhichao
>Sent: Thursday, September 19, 2019 1:46 PM
>To: devel@edk2.groups.io
>Cc: Andrew Fish ; Laszlo Ersek ; Leif
>Lindholm ; Kinney, Michael D
>; Ni, Ray ; Ard Biesheuvel
>; Gao, Liming
>Subject
Push@95fb75883d2917e985f960969f004ea63ad83adf
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Liming Gao
>Sent: Monday, July 29, 2019 3:54 PM
>To: Javeed, Ashraf ; devel@edk2.groups.io
>Cc: Kinney, Michael D ; Ni, Ray
>; Wu
Push@d21e5dbbbf11589113d39619b3e01eb1e8966819
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Liming Gao
>Sent: Tuesday, July 30, 2019 11:21 AM
>To: Chen, Marc W ; devel@edk2.groups.io
>Cc: Kinney, Michael D ; Ni, Ray
>
>
Ashraf:
Thanks for your update. The change is good to be added into edk2-staging.
Reviewed-by: Liming Gao
Thanks
Liming
>-Original Message-
>From: Javeed, Ashraf
>Sent: Wednesday, July 31, 2019 11:59 AM
>To: devel@edk2.groups.io; Javeed, Ashraf
>Cc: Kinney, Michael
;> From: Chen, Marc W
>> > >>>> Sent: Thursday, August 1, 2019 4:48 PM
>> > >>>> To: Gao, Liming ; devel@edk2.groups.io
>> > >>>> Cc: Kinney, Michael D ; Ni, Ray
>> > >>>>
>> > >>>> Subject
Reviewed-by: Liming Gao
>-Original Message-
>From: Kinney, Michael D
>Sent: Friday, August 02, 2019 11:23 AM
>To: devel@edk2.groups.io
>Cc: Gao, Liming ; Justen, Jordan L
>; Andrew Fish ; Ni, Ray
>
>Subject: [Patch 4/4] MdePkg/X64/ProcessorBind.h: Fix Emulator
and where
>BZs are referenced in the message, also copied into the BZ.
>
Good suggestion. I will update BZ to include those information.
Thanks
Liming
>/
>Leif
>
>On Thu, Aug 01, 2019 at 12:57:36PM +, Liming Gao wrote:
>> Good catch. I have pushed this patch. C
Sorry for the missing. Reviewed-by: Liming Gao
>-Original Message-
>From: Fan, ZhijuX
>Sent: Friday, June 28, 2019 3:01 PM
>To: devel@edk2.groups.io
>Cc: Gao, Liming ; Feng, Bob C
>Subject: [PATCH V2] BaseTools:Add the Judgment Method of "--exclude"
>
>
Mike:
For this patch set, I am OK for those changes. Reviewed-by: Liming Gao
But, I see there are some discussion on patch 3. After we make the
conclusion, you can push it.
Thanks
Liming
>-Original Message-
>From: Kinney, Michael D
>Sent: Friday, August 02, 201
Reviewed-by: Liming Gao
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Bob Feng
>Sent: Friday, August 02, 2019 3:22 PM
>To: devel@edk2.groups.io
>Cc: Gao, Liming ; Feng, Bob C
>Subject: [edk2-devel] [Patch 1/1] Base
401 - 500 of 1272 matches
Mail list logo
