Hi Ashraf,
The PcdValueInit feature is not limited to only PCDs of type VPD. It is
for any structured PCDs. Did you test PCDs with all types (e.g.
PcdsFixedAtBuild
PcdsPactahbleInModule, PcdsDynamicHii, PcdsDynamicDatabase, PcdsDynamicVpd,
PcdsDynamicExHii, PcdsDynamicExDatabase,
[edk2-devel] [PATCH V2 1/1] MdePkg: Update the definition of
> FileName on EFI_FILE_INFO
>
> Add the description of FileName to align with UEFI spec 2.10.
>
> REF: UEFI spec 2.10 Table 13.5.16
>
> Signed-off-by: Suqiang Ren
> Cc: Michael D Kinney
> Cc: Liming Gao
>
RTIES_TABLE configuration table should be published
> describing which runtime services are supported at runtime. So need to
> add EFI_UNSUPPORTED return for some Runtime Service functions.
>
> REF: UEFI spec 2.10 section 8 Services — Runtime Services
>
> Signed-off-by: Suqiang Ren
&
Hi Ray,
+Andrew Fish
That optimization was imported into git history 17 years ago, so
it has effectively always been there. I do not recall the performance
improvement at the time the optimization was originally implemented.
The difference in behavior is that caching the result may miss
an
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Joey Vagedes
> Sent: Monday, January 22, 2024 3:21 PM
> To: devel@edk2.groups.io
> Cc: Liming Gao ; Kinney, Michael D
> ; Sean Brogan
> Subject: [PATCH v1 1/1] .pytool/Plugin: UncrustifyCheck: use stat
ImageSize is not too small and Image is NULL."
> >
> > 2.For EFI_FIRMWARE_MANAGEMENT_PROTOCOL.GetImageInfo():
> > Add the following sentence at the end of the ImageInfo parameter
> > description."May be NULL with a zero ImageInfoSize in order to
> > determine the size of t
Hi Rebecca,
I do not recall any statements in the EFI Spec that require 4KB
alignment of the UEFI System Table, Boot Services Table,
or Runtime Services Table.
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Rebecca
> Cran
> Sent: Monday, January 22, 2024 11:53 AM
f casting for
> TD MMIO read
>
> Reviewed-by: Michael D Kinney
>
> Please include Cc tags in commit message with the maintainers of
> the patch for review. Otherwise, the maintainers may miss the
> email patches.
>
> Thanks,
>
> Mike
>
>
>
&
Merged: https://github.com/tianocore/edk2/pull/5277
From: devel@edk2.groups.io On Behalf Of gaoliming via
groups.io
Sent: Tuesday, January 16, 2024 6:18 AM
To: devel@edk2.groups.io; sami.muja...@arm.com; 'PierreGondois'
Subject: 回复: [edk2-devel] [PATCH v2 1/1] MdePkg/IndustryStandard: Add
Reviewed-by: Michael D Kinney
Please include Cc tags in commit message with the maintainers of
the patch for review. Otherwise, the maintainers may miss the
email patches.
Thanks,
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Zhiquan
> Li
> Se
10:10 AM
> To: devel@edk2.groups.io; Ren, SuqiangX
> Cc: Kinney, Michael D ; Liu, Zhiguang
> ; Li, Yi1
> Subject: 回复: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of
> HiiConfigAccess ExtractConfig
>
> Reviewed-by: Liming Gao
>
> > -----邮件原件-
>
Hi Ashraf,
What is captured in the file?
What PCD/VPD changes will invalidate the cache? Just the number and
type of PCD/VPD elements or their default values/sizes?
How was this tested? Were all conditions that invalidate the cache
tested? I ask because incremental build is a very important
Hi Zhi,
Some comments below.
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Zhi Jin
> Sent: Tuesday, January 16, 2024 10:45 PM
> To: devel@edk2.groups.io
> Cc: Jin, Zhi ; Liming Gao ;
> Ni, Ray
> Subject: [edk2-devel] [PATCH 1/2] MdeModulePkg: Remove the handle
>
I agree that this implements the similar check as other
optional protocols to adjust driver binding order to skip
checks for which where are no instances of the optional
protocol.
Reviewed-by: Michael D Kinney
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Z
The issue is if AsmCpuid() is called for an Index value that does depend on
ECX. That would be a bug on the caller's part and would not have deterministic
behavior because ECX on input is not deterministic. That is the condition that
would be good to catch.
Mike
From: Ni, Ray
Sent: Friday,
Hi Ray,
It is about having deterministic behavior if a call if made for
a CPUID EAX value that does depend on ECX. If ECX is not zeroed,
then it will have a random value that may return different
information.
The problem statement from Tom is not about zeroing ECX. It is
about avoiding code
s.io>>; Clark-williams, Zachary
mailto:zachary.clark-willi...@intel.com>>;
Jeff Brasen mailto:jbra...@nvidia.com>>; Gao, Liming
mailto:gaolim...@byosoft.com.cn>>
Cc: Kinney, Michael D
mailto:michael.d.kin...@intel.com>>
Subject: RE: [PATCH] NetworkPkg/Ip4Dxe: Fix R
Acked-by: Michael D Kinney
I will prepare PR for merge
From: Kasbekar, Saloni
Sent: Wednesday, January 17, 2024 9:27 AM
To: Ashish Singhal ; devel@edk2.groups.io;
Clark-williams, Zachary ; Jeff Brasen
; Kinney, Michael D ; Gao,
Liming
Subject: RE: [PATCH] NetworkPkg/Ip4Dxe: Fix Reset
Reviewed-by: Michael D Kinney
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Xu, Wei6
> Sent: Wednesday, January 17, 2024 10:12 AM
> To: devel@edk2.groups.io
> Cc: Xu, Wei6 ; Abner Chang ;
> Desimone, Nathaniel L
> Subject: [edk2-devel] [PAT
Hi Tom,
I do not see any harm in zeroing ECX in AsmCpuid().
If it is not zeroed, then it would have an undefined value.
However, calling AsmCpuid() for any Index that evaluates ECX
(including a check for 0) should never be done. If ECX is
evaluated for a given Index, then AsmCpuIdEx() must be
Acked-by: Michael D Kinney
> -Original Message-
> From: Abdul Lateef Attar
> Sent: Wednesday, January 17, 2024 7:54 PM
> To: devel@edk2.groups.io
> Cc: Abdul Lateef Attar ; Kinney, Michael D
> ; Liming Gao ;
> Liu, Zhiguang ; Ni, Ray ;
> Kumar, Rahul R ; Ge
; > From: Kinney, Michael D
> > Sent: Thursday, January 18, 2024 12:03 PM
> > To: Pethaiyan, Madhan ;
> devel@edk2.groups.io
> > Cc: Gao, Liming ; Xu, Wei6
> > ; Tan, Ming ; S, Ashraf Ali
> > ; Kinney, Michael D
>
> > Subject: RE: [PATCH V2] FmpDevicePk
D
> Subject: RE: [PATCH V2] FmpDevicePkg: GetImageInfo Add missing condition
>
> Reviewed-by: Michael D Kinney
>
>
>
> > -Original Message-
> > From: Pethaiyan, Madhan
> > Sent: Thursday, January 18, 2024 12:57 AM
> > To: devel@edk2.groups.io
>
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Pethaiyan, Madhan
> Sent: Thursday, January 18, 2024 12:57 AM
> To: devel@edk2.groups.io
> Cc: Gao, Liming ; Kinney, Michael D
> ; Xu, Wei6 ; Tan, Ming
> ; S, Ashraf Ali
> Subject: RE: [PATCH V2] Fm
Unit tests for the math calculations would help with reviews too.
Mike
> -Original Message-
> From: Laszlo Ersek
> Sent: Tuesday, January 16, 2024 2:03 AM
> To: Kinney, Michael D ; Pedro Falcato
> ; devel@edk2.groups.io; Ni, Ray
>
> Cc: Desimone, Nathaniel L ; Kumar, Rahul
> R ; Gerd
Hi Ray,
I think nesting may be possible in physical platforms, but very hard to induce.
One option is to consolidate to a single LocalApicTimerDxe implementation
in the UefiCpuPkg, but allow the platform DSC to either specify a Null
NestedInterruptTplLib for physical platforms or the full one
D
Cc: pedro.falc...@gmail.com; Laszlo Ersek ;
n...@os.amperecomputing.com; ardb+tianoc...@kernel.org
Subject: Re: [edk2-devel] Memory Attribute for depex section
On Jan 12, 2024, at 8:37 AM, Michael D Kinney
mailto:michael.d.kin...@intel.com>> wrote:
Hi Pedro,
Thank you for eval
Hi Pedro,
Thank you for evaluating this idea change from linked list to improve
performance of the handle database.
The concept of using integers for an EFI_HANDLE has been considered before.
One advantage over pointers is that a guarantee can be made that an EFI_HANDLE
value can be guaranteed
Merged: https://github.com/tianocore/edk2/pull/5256
From: Joey Vagedes via groups.io
Sent: Thursday, January 11, 2024 3:16 PM
To: Kinney, Michael D ; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH v1 1/1] pip-requirements.txt: Update to latest
Thanks Mike,
I've updated the PR / branch
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Joey Vagedes
> Sent: Thursday, January 11, 2024 1:35 PM
> To: devel@edk2.groups.io
> Cc: Andrew Fish ; Leif Lindholm ;
> Kinney, Michael D
> Subject: [PATCH v1 1/1] pip-requirements.txt: Update to la
Meeting canceled.
Mike
> -Original Message-
> From: Kinney, Michael D
> Sent: Wednesday, January 10, 2024 10:37 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D
> Subject: TianoCore Community Meeting - call for topics
>
> Any topics for the TianoCore Community meeting this week?
Any topics for the TianoCore Community meeting this week?
Mike
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113539): https://edk2.groups.io/g/devel/message/113539
Mute This Topic: https://groups.io/mt/103646667/21656
Group Owner:
There are several advantages for this direction:
* Current VFR compiler in C has dependencies on very old libs that
have not been updated.
* The movement to python will remove the pre-build step that requires
some of the build tools to be built using host C compiler before
running edk2
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Wu, Jiaxin
> Sent: Friday, December 15, 2023 1:55 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
> ; Liu, Zhiguang ;
> Laszlo Ersek ; Ni, Ray ; Zeng, Star
>
> Subject: [PATCH v4
Reviewed-by: Michael D Kinney
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael
> Kubacki
> Sent: Tuesday, December 12, 2023 11:24 AM
> To: devel@edk2.groups.io
> Cc: Ni, Ray
> Subject: [edk2-devel] [PATCH v1 1/1] FatPkg/FatPei: Check arra
[edk2-devel] [PATCH 2/2] MdePkg:simplify Fifo API in
> BaseIoLibIntrinsic
>
> Acked-by: Michael D Kinney
>
> Mike
>
> > -Original Message-
> > From: Tan, Dun
> > Sent: Wednesday, December 6, 2023 1:26 AM
> > To: devel@edk2.groups.io; Tan, Dun
Acked-by: Michael D Kinney
Mike
> -Original Message-
> From: Tan, Dun
> Sent: Wednesday, December 6, 2023 1:26 AM
> To: devel@edk2.groups.io; Tan, Dun
> Cc: Kinney, Michael D ; Gao, Liming
> ; Liu, Zhiguang ; Ni,
> Ray
> Subject: RE: [edk2-devel] [PATCH 2/2]
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Jayaprakash, N
> Sent: Saturday, December 9, 2023 9:43 AM
> To: devel@edk2.groups.io
> Cc: Jayaprakash, N ; Rebecca Cran
> ; Kinney, Michael D
> Subject: [edk2-libc Patch 1/1] ek2-libc: writeio funct
, Michael D
>
> Subject: RE: [PATCH v3] MdePkg: Add a new memory type definition
>
> Reviewed-by: Michael D Kinney
>
> > -Original Message-
> > From: Srinivasan, ManickamX
> > Sent: Thursday, December 7, 2023 9:37 PM
> > To: devel@edk2.groups
Series Reviewed-by: Michael D Kinney
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Rebecca
> Cran via groups.io
> Sent: Friday, December 8, 2023 4:20 PM
> To: Kinney, Michael D ; Gao, Liming
> ; Liu, Zhiguang ; Ard
> Biesheuvel ; Laszlo Ersek
>
, Michael D
>
> Subject: RE: [PATCH v2] MdePkg: Define the DevicePath argument from
> LoadImage as optional
>
> Reviewed-by: Michael D Kinney
>
> > -Original Message-
> > From: Srinivasan, ManickamX
> > Sent: Thursday, December 7, 2023 9:41 PM
> &g
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Srinivasan, ManickamX
> Sent: Thursday, December 7, 2023 9:41 PM
> To: devel@edk2.groups.io
> Cc: Srinivasan, ManickamX ; Kinney,
> Michael D ; Gao, Liming
> ; Liu, Zhiguang ; T V,
> Krishnamoorthy
>
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Srinivasan, ManickamX
> Sent: Thursday, December 7, 2023 9:37 PM
> To: devel@edk2.groups.io
> Cc: Srinivasan, ManickamX ; Kinney,
> Michael D ; Gao, Liming
> ; Liu, Zhiguang ; T V,
> Krishnamoorthy
>
No topics. Meeting canceled.
Mike
From: Kinney, Michael D
Sent: Tuesday, December 5, 2023 3:11 PM
To: devel@edk2.groups.io
Cc: Kinney, Michael D
Subject: TianoCore Community Meeting call for topics
Are there any topics for the TianoCore Community Meeting this week?
Thanks,
Mike
Merged
Mike
From: Kinney, Michael D
Sent: Wednesday, December 6, 2023 8:47 AM
To: Jake Garver ; Gao, Liming ;
devel@edk2.groups.io
Cc: Liu, Zhiguang ; Kinney, Michael D
Subject: RE: [PATCH v2] BaseStackCheckLib: Fix STACK FAULT message
Hi Jake,
PR opened with Rb tag added:
Hi Jake,
PR opened with Rb tag added: https://github.com/tianocore/edk2/pull/5113
Mike
From: Jake Garver
Sent: Wednesday, December 6, 2023 8:37 AM
To: Gao, Liming ; devel@edk2.groups.io
Cc: Kinney, Michael D ; Liu, Zhiguang
Subject: Re: [PATCH v2] BaseStackCheckLib: Fix STACK FAULT message
Are there any topics for the TianoCore Community Meeting this week?
Thanks,
Mike
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112083): https://edk2.groups.io/g/devel/message/112083
Mute This Topic:
higuang ; Sean Brogan
> ; Kinney, Michael D
> Subject: RE: [PATCH v4 1/1] MdePkg:Add NVME Sanitize command support to
> Nvme.h
>
> Reviewed-by: Michael D Kinney
>
> > -Original Message-
> > From: Chen, Tina
> > Sent: Wednesday, November 8, 2023 11:5
AULTLIB for FW components.
>
> With /NODEFAULTLIB removed from UnitTestFrameworkPkgHost.dsc.inc
> This series is:
>
> Reviewed-by: Michael D Kinney
>
> I have taken the branch from Michael Kubacki and added this
> one change to run through EDK II CI and added by
options
common to IA32/X64.
-Wno-microsoft-static-assert added to CLANGPDB CC_FLAGS to
address warnings.
Cc: Andrew Fish
Cc: Ray Ni
Cc: Pedro Falcato
Signed-off-by: Michael D Kinney
---
EmulatorPkg/Win/Host/WinHost.inf | 32 +++-
1 file changed, 19 insertions(+), 13
and to the EmulatorPkg/Host/Win. I have verified that
/NODEFAULTLIB can be removed from both of these use cases
and only use /NODEFAULTLIB for FW components.
With /NODEFAULTLIB removed from UnitTestFrameworkPkgHost.dsc.inc
This series is:
Reviewed-by: Michael D Kinney
I have taken the branch from
Hi Pedro,
Thanks for the follow up and debug.
I suspect some of those flags were inherited from
EmulatorPkg builds and may not apply to GoogeTest
builds.
I will investigate.
Very happy to see a solution for this issue.
Mike
> -Original Message-
> From: Pedro Falcato
> Sent:
erformanceCounterFrequency to STATIC. Since this variable is not
> > used outside of the DxeStandaloneMmAcpiTimerLib.c compilation unit,
> > there is no reason to have it exported as a global.
> >
> > Cc: Ray Ni
> > Cc: Michael D Kinney
> > Signed-off-by: N
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Thursday, November 30, 2023 4:18 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Ni, Ray ;
> Chaganty, Rangasai V ; Gao, Liming
> ; Kinney, Michael D ;
> Kelly Steele ;
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Thursday, November 30, 2023 4:18 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Ni, Ray ;
> Chaganty, Rangasai V ; Gao, Liming
> ; Kinney, Michael D ;
> Sun, Zailiang ; Q
t; To: devel@edk2.groups.io; Kinney, Michael D
> Cc: Savva Mitrofanov ; Gao, Liming
> ; Liu, Zhiguang
> Subject: Re: [edk2-devel] [PATCH 2/2] MdePkg/Test: Add google tests for
> BaseLib
>
> On Thu, Nov 30, 2023 at 7:32 PM Michael D Kinney
> wrote:
> >
> > With
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Pedro Falcato
> Sent: Wednesday, November 29, 2023 6:46 PM
> To: devel@edk2.groups.io
> Cc: Savva Mitrofanov ; Pedro Falcato
> ; Gao, Liming ; Kinney,
> Michael D ; Liu, Zhiguang
>
> Subject: [PAT
With one comment below addressed
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Pedro Falcato
> Sent: Wednesday, November 29, 2023 6:46 PM
> To: devel@edk2.groups.io
> Cc: Savva Mitrofanov ; Pedro Falcato
> ; Gao, Liming ; Kinney,
> Michael D ; Liu,
Acked-by: Michael D Kinney
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Wednesday, November 29, 2023 9:01 AM
> To: devel@edk2.groups.io
> Cc: Joey Vagedes ; Laszlo Ersek
> ; Kinney, Michael D ; Sean
> Brogan
> Subject: [PATCH v1 1/1] .git
Hi Maciej,
Reviewed-by: Michael D Kinney
I have invited you to the EDK II Staging Maintainer team that
allows you to create this new branch in the edk2-staging repo.
Mike
> -Original Message-
> From: Czajkowski, Maciej
> Sent: Monday, November 13, 2023 7:09 AM
> To
Reviewed-by: Michael D Kinney
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Monday, November 27, 2023 4:17 PM
> To: devel@edk2.groups.io
> Cc: Andrew Fish ; Leif Lindholm
> ; Kinney, Michael D
> ; Rebecca Cran
> Subject: [PATCH v1 1/1] .git-b
Reviewed-by: Michael D Kinney
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Monday, November 27, 2023 11:45 AM
> To: devel@edk2.groups.io
> Cc: Andrew Fish ; Chris Fernald
> ; Joey Vagedes ; Leif
> Lindholm ; Gao, Liming
> ; Kinney, M
Hi Sean and Michael,
The NetworkPkg.ci.yaml is pointing at a DSC file in the NetworkPkg.
If I try a local build of that DSC file, it does fail immediately with
a missing library mapping.
Any ideas on how this was not seen by CI? Either for PR or Push actions?
Thanks,
Mike
> -Original
Series Reviewed-by: Michael D Kinney
> -Original Message-
> From: Laszlo Ersek
> Sent: Thursday, November 16, 2023 1:51 PM
> To: devel@edk2.groups.io
> Cc: Andrew Fish ; Ard Biesheuvel
> ; Gerd Hoffmann ; Yao,
> Jiewen ; Leif Lindholm
> ; Kinney, Michael D
> ;
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Chen, Tina
> Sent: Wednesday, November 8, 2023 11:51 PM
> To: devel@edk2.groups.io
> Cc: Chen, Tina ; Ni, Ray ;
> Chen, Xiao X ; Chen, Arthur G
> ; Gao, Liming ;
> Liu, Zhiguang ; Sean Brogan
> ; Kin
Hello,
Looks like the process for permissions needs to be adjusted during soft/hard
freeze.
Liming reduced EDK II Maintainers team to "Triage" for edk2 repo.
But from this documentation lists Triage as allowing add/remove labels.
Hi Ranbir,
First I want to recognize your efforts to collect Coverity issues and propose
changes to address
them.
I still disagree with adding CpuDealLoop() for any static analysis issues.
There have been previous discussions about adding a PANIC() or FATAL() macro
that would
perform platform
Hi Michael,
Have you tried to upstream the edk2 specific elements to the
uncrustify project? That would be a path to remove the fork
and eventually all the distros would catch up.
Mike
> -Original Message-
> From: Michael Kubacki
> Sent: Monday, November 13, 2023 12:22 PM
> To: Pedro
eredDict() to accumulate unique addresses.
> >
> > Changes since v2:
> > - Reworked internal return logic to use dictionaries.
> > - Reordered cleanup before new functionality.
> > Changes since v1:
> > - Split into patch series
> >
> > Cc: Rebecca Cran
Hi Leif,
Thank you for the addition cleanup.
Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: Leif Lindholm
> Sent: Friday, November 10, 2023 11:31 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Rebecca Cran
> ; Gao, Liming ; Feng, Bob
>
. This also allows this module to be used
by other scripts that need to distinguish between maintainers,
reviewers, and lists.
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Cc: Yuwei Chen
Cc: Leif Lindholm
Signed-off-by: Michael D Kinney
---
BaseTools/Scripts/GetMaintainer.py | 28
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4593
Fix logic bug where maintainers is incorrectly added to lists.
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Cc: Yuwei Chen
Cc: Leif Lindholm
Signed-off-by: Michael D Kinney
---
BaseTools/Scripts/GetMaintainer.py | 2 +-
1 file
get_section_maintainers().
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Cc: Yuwei Chen
Cc: Leif Lindholm
Signed-off-by: Michael D Kinney
---
BaseTools/Scripts/GetMaintainer.py | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/BaseTools/Scripts/GetMaintainer.py
b/BaseTools/Scripts
of OrderedDict to accumulate the
list of unique addresses that are sorted alphabetically.
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Cc: Yuwei Chen
Cc: Leif Lindholm
Signed-off-by: Michael D Kinney
---
BaseTools/Scripts/GetMaintainer.py | 11 ++-
1 file changed, 6 insertions(+), 5
of output addresses alphabetically and use set()
instead of OrderedDict() to accumulate unique addresses.
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Cc: Yuwei Chen
Cc: Leif Lindholm
Signed-off-by: Michael D Kinney
Michael D Kinney (4):
BaseTools/Scripts/GetMaintainer: Fix logic bug
gt; Cc: devel@edk2.groups.io; Rebecca Cran ; Gao,
> Liming ; Feng, Bob C ;
> Chen, Christine
> Subject: Re: [edk2-devel] [edk2-stable202311][Patch 1/1]
> BaseTools/Scripts: Handle reviewer only case in GetMaintainer.py
>
> On Wed, Nov 08, 2023 at 12:43:23 -0800, Mi
I approve this change for edk2-stable202311
The PR looks out of sync with this email patch.
Can you please update PR with latest patch and commit
message that was reviewed and add review tags?
Mike
> -Original Message-
> From: Wu, Jiaxin
> Sent: Thursday, November 9, 2023 4:01 PM
>
Hi Ranbir,
A deadloop without even a debug print is not good behavior.
If this condition really represents a condition where it is not possible
to complete the PCI resource allocation/assignment, then an error status
code should be returned to the caller of NotifyPhase(). Perhaps
e tag.
>
> Thanks
> Liming
> > -邮件原件-
> > 发件人: devel@edk2.groups.io 代表 Leif Lindholm
> > 发送时间: 2023年11月9日 17:51
> > 收件人: Michael D Kinney ;
> > devel@edk2.groups.io
> > 抄送: Andrew Fish ; Erdem Aktas
> > ; Jiewen Yao ; Min Xu
> >
Merged:
https://github.com/tianocore/edk2/pull/5023
https://github.com/tianocore/edk2/commit/e077ccff6d0f2e8c3fc44b3e2ab71aff66927c3b
Mike
> -Original Message-
> From: Leif Lindholm
> Sent: Thursday, November 9, 2023 6:39 AM
> To: devel@edk2.groups.io; Gao, Liming
> Cc: 'Yeping Song
+Ray
Unless I missed it, I do not see review of the patch series Ray sent back in
July.
Mike
From: devel@edk2.groups.io On Behalf Of Aaron Young via
groups.io
Sent: Thursday, November 9, 2023 8:29 AM
To: Gerd Hoffmann ; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH 0/4] Sync BSP's
scripts and distinguish types.
Sort the list of output addresses alphabetically.
Fix logic bug where maintainers was incorrectly added to lists.
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Cc: Yuwei Chen
Cc: Leif Lindholm
Signed-off-by: Michael D Kinney
---
BaseTools/Scripts
Hi Ranbir,
Ignoring false positive in static analysis tools is typically a burden.
It is better to avoid false positives with code changes as long as the code
changes do not make the implementation confusing and hard to maintain.
I think depending on fall through case statements is confusing
Cc: Tom Lendacky
Cc: Michael Roth
Signed-off-by: Michael D Kinney
---
Maintainers.txt | 1 -
1 file changed, 1 deletion(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index cfbde42f2e04..7c0b4cb58cfd 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -497,7 +497,6 @@ F: OvmfPkg/Include
Hi Jose,
1. This logic needs to move into an AARCH64 specific directory/file. Other
architectures handle this in other ways.
2. There are many places throughout edk2 sources that perform PCI config
write operations. You are only fixing it in a single location. You may want
to look at
This comment style only works with Coverity.
Other static analysis tools may flag the same issue again.
It is better to update the logic so no static analysis tool will
flag this issue.
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Laszlo
> Ersek
> Sent: Tuesday,
Acked-by: Michael D Kinney
> -Original Message-
> From: Chao Li
> Sent: Sunday, November 5, 2023 7:28 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
> ; Liu, Zhiguang
> Subject: [PATCH v2 08/30] MdePkg: Add IOCSR operation for LoongArc
Acked-by: Michael D Kinney
> -Original Message-
> From: Chao Li
> Sent: Sunday, November 5, 2023 7:27 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
> ; Liu, Zhiguang
> Subject: [PATCH v2 03/30] MdePkg: Add LoongArch64 exception functi
Acked-by: Michael D Kinney
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chao Li
> Sent: Sunday, November 5, 2023 7:27 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
> ; Liu, Zhiguang ;
> Bibo Mao
> Subject: [edk2-devel]
Acked-by: Michael D Kinney
> -Original Message-
> From: Chao Li
> Sent: Sunday, November 5, 2023 7:27 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
> ; Liu, Zhiguang
> Subject: [PATCH v2 06/30] MdePkg: Add read stable counter operation
>
Acked-by: Michael D Kinney
> -Original Message-
> From: Chao Li
> Sent: Sunday, November 5, 2023 7:27 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
> ; Liu, Zhiguang
> Subject: [PATCH v2 05/30] MdePkg: Add LoongArch Cpucfg function
>
&
Acked-by: Michael D Kinney
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chao Li
> Sent: Sunday, November 5, 2023 7:27 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
> ; Liu, Zhiguang
> Subject: [edk2-devel] [PATCH v2 02/30] Md
Acked-by: Michael D Kinney
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chao Li
> Sent: Sunday, November 5, 2023 7:27 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
> ; Liu, Zhiguang
> Subject: [edk2-devel] [PATCH v2 04/30] Md
Acked-by: Michael D Kinney
> -Original Message-
> From: Chao Li
> Sent: Sunday, November 5, 2023 7:26 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
> ; Liu, Zhiguang
> Subject: [PATCH v2 01/30] MdePkg: Add the header file named Csr.h for
>
Hi Tom,
It likely would have been better to define AsmCpuid() to
set ECX=0.
However, how would new source code know if the BaseLib they
linking against has this new behavior or not?
It is probably safer to do what you propose which is to use
AsmCpuidEx() that specifies exactly how ECX is set.
Please update the Nvme.h file header that the version being
used is 2.0c.
Thanks,
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Tina
> Chen
> Sent: Monday, November 6, 2023 6:01 AM
> To: devel@edk2.groups.io
> Cc: Chen, Tina ; Chen, Xiao X
> ; Chen, Arthur G ; Ni,
Reviewed-by: Michael D Kinney
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Page
> Chen via groups.io
> Sent: Monday, November 6, 2023 12:43 PM
> To: devel@edk2.groups.io
> Cc: Page Chen ; Gao, Zhichao
> ; Andrew Fish
> Subject: [edk2-devel] [
Series Reviewed-by: Michael D Kinney
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Joey
> Vagedes via groups.io
> Sent: Monday, November 6, 2023 12:12 PM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran ; Gao, Liming
> ; Feng, Bob C ; Chen,
> Chr
What is the random data at the end of your path emails???
Thanks,
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Joey
> Vagedes via groups.io
> Sent: Monday, November 6, 2023 12:09 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH v1 0/1]
Hi,
Can you please follow up with your Github ID and the additional details in a
patch email wit Readme.MD content?
https://github.com/tianocore/edk2-staging/blob/about/README
4) Process to add a new feature to edk2-staging
a) Maintainer sends patch email to edk2-devel mailing
101 - 200 of 2507 matches
Mail list logo
