and windows types.
The commit that added the workaround is:
https://github.com/tianocore/edk2/commit/ff52068d9261b9391d75b83a2a4e40e040f3b6eb
Cc: Gerd Hoffmann
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Michael D Kinney
---
MdePkg/Include/IndustryStandard/PeImage.h | 5
EmulatorPkg
in the WinInclude.h file that addresses all the name
collisions between edk2 types and windows types.
Cc: Gerd Hoffmann
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Andrew Fish
Cc: Ray Ni
Signed-off-by: Michael D Kinney michael.d.kin...@intel.com
Michael D Kinney (2
Update WinInclude.h to prevent error due to redefinition of
RUNTIME_FUNCTION using same technique that has been used
in the past for structure types such as LIST_ENTRY.
Cc: Gerd Hoffmann
Cc: Rebecca Cran
Cc: Andrew Fish
Cc: Ray Ni
Signed-off-by: Michael D Kinney
---
EmulatorPkg/Win/Host
compiler and build optimization this can fill the
> variable with garbage that is later used by res_init().
> Fix is trivial - explicitly initialize _res.
>
> Cc: Rebecca Cran
> Cc: Michael D Kinney
> Co-authored-by: Kloper, Dimitry
> Signed-off-by: Jayaprakash N
>
Miki
> Cc: Kasbekar, Saloni ; Nickle Wang
> ; Clark-williams, Zachary willi...@intel.com>; Abner Chang ; Igor Kulchytskyy
> ; Nick Ramirez
> Subject: Re: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver
> binding start issue.
>
> On Thu, 20 Jul 2023 at 03:41, Mic
Kulchytskyy ;
> Nick Ramirez ; Kinney, Michael D
>
> Subject: RE: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver
> binding start issue.
>
> Acked-by: Michael D Kinney
>
> > -Original Message-
> > From: Kasbekar, Saloni
> > Sent: Thursday, July
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Michael Kubacki
> Sent: Friday, June 30, 2023 4:00 PM
> To: devel@edk2.groups.io; kuqi...@gmail.com
> Cc: Sean Brogan ; Kinney, Michael D
>
> Subject: Re: [edk2-devel] [PATCH v3 1/1]
Acked-by: Michael D Kinney
> -Original Message-
> From: Kasbekar, Saloni
> Sent: Thursday, July 13, 2023 9:13 AM
> To: Nickle Wang ; devel@edk2.groups.io; Clark-
> williams, Zachary ; Kinney, Michael D
>
> Cc: Abner Chang ; Igor Kulchytskyy ;
> Nick Ramirez
&g
A general approach to this type of issues is to enable the new feature by
default
and optionally provide a setup option to disable the new feature.
If there is a way to detect the failure case and fail gracefully back to the
boot manager with an error message that indicates the type of issue and
There is a similar lib API for SMI handlers:
https://github.com/tianocore/edk2/blob/master/MdePkg/Include/Library/SmmPeriodicSmiLib.h
/**
This function returns the time in 100ns units since the periodic SMI
handler function was called. If the periodic SMI handler was resumed
through Period
Using the same include guard define name is preferred.
Why was anything other than that considered?
Mike
> -Original Message-
> From: Xue, Gavin
> Sent: Friday, June 30, 2023 2:29 AM
> To: Kinney, Michael D ;
> devel@edk2.groups.io; Pedro Falcato
> Cc: suni...@ventanamicro.com; Warkent
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Joey Vagedes
> Sent: Wednesday, June 28, 2023 10:39 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
> ; Liu, Zhiguang
> Subject: [PATCH v2 1/2] MdePkg: IndustryStandard: Add DLL Charact
Merged: https://github.com/tianocore/edk2/pull/4584
> -Original Message-
> From: Kinney, Michael D
> Sent: Tuesday, June 27, 2023 5:50 PM
> To: Clark-williams, Zachary ; Li, Yi1
> ; devel@edk2.groups.io; Andrew Fish ;
> Leif Lindholm
> Cc: Maciej Rabeda ; Kinney, Michael D
>
> Subject:
hael D
> Subject: RE: [PATCH 1/1] Maintainers.txt: Update NetworkPkg maintainers and
> reviewers
>
> Reviewed-by: Michael D Kinney
>
> > -Original Message-
> > From: Clark-williams, Zachary
> > Sent: Thursday, June 15, 2023 11:32 AM
> > To: Kasbe
Working on it:
https://github.com/tianocore/edk2/pull/4584
> -Original Message-
> From: Clark-williams, Zachary
> Sent: Tuesday, June 27, 2023 2:46 PM
> To: Li, Yi1 ; devel@edk2.groups.io; Kinney, Michael D
> ; Andrew Fish ; Leif Lindholm
>
> Cc: Maciej Rabeda
> Subject: RE: [PATCH V3
2] MdePkg: IndustryStandard: Add DLL Characteristics
>
> Add the bit masks for DLL Characteristics, used within the optional
> header of a PE, to the PeImage.h header file.
>
> Cc: Michael D Kinney
> mailto:michael.d.kin...@intel.com>>
> Cc: Liming Gao mailto:ga
It is better if we can use the same include guard names, but is not
strictly required for builds to work.
What is the specific error message seen when using the same include guard
names as other CPU types?
Include guards have 2 elements work discussing:
* Use of define names that start with '_'
Mock Library for UefiBootServicesTableLib
>
> Cc: Michael D Kinney
> Cc: Liming Gao
> Cc: Zhiguang Liu
>
> Signed-off-by: LakX Huang
> ---
> MdePkg/Test/MdePkgHostTest.dsc| 1 +
> .../Library/MockUefiBootServicesTableLib.h| 71 +++
s.io
> Cc: Kinney, Michael D ; Gao, Liming
> ; Liu, Zhiguang
> Subject: [PATCH v1 1/2] MdePkg: IndustryStandard: Add DLL Characteristics
>
> Add the bit masks for DLL Characteristics, used within the optional
> header of a PE, to the PeImage.h header file.
>
> Cc:
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Tuan Phan
> Sent: Friday, June 23, 2023 11:39 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
> ; Liu, Zhiguang ;
> suni...@ventanamicro.com; g...@danielschaefer.me; Warkentin, A
I have sent the invite.
Mike
From: devel@edk2.groups.io On Behalf Of gaoliming via
groups.io
Sent: Monday, June 26, 2023 5:53 PM
To: devel@edk2.groups.io; Duggapu, Chinni B
Cc: Chiu, Chasel ; Kinney, Michael D
Subject: 回复: [edk2-devel] Need help to add me to the edk-ii-maintainers and
edk-i
Thank you for fixing this.
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Joey Vagedes
> Sent: Tuesday, June 27, 2023 9:27 AM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran ; Gao, Liming
> ; Feng, Bob C ; Chen,
> Christine ; Kinney, Michael D
>
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Clark-williams, Zachary
> Sent: Thursday, June 15, 2023 11:32 AM
> To: Kasbekar, Saloni ; devel@edk2.groups.io
> Cc: Kinney, Michael D ; Andrew Fish
> ; Leif Lindholm
> Subject: RE: [PATCH 1/1] Ma
Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Kun Qin
> Sent: Thursday, June 8, 2023 11:25 AM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen ; Wang, Jian J
> ; Zhang, Qi1 ; Kumar, Rahul R
> ; Kinney, Michael D
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Tan, Dun
> Sent: Wednesday, June 14, 2023 2:41 AM
> To: devel@edk2.groups.io; Tan, Dun
> Cc: Ni, Ray ; Kinney, Michael D
> ; Gao, Liming ; Liu,
> Zhiguang
> Subject: RE: [edk2-devel] [Patch V2] MdePkg:
;
> > > Subject: RE: [edk2-devel] failed pr
> > >
> > > Merged
> > >
> > > Mike
> > >
> > > > -Original Message-
> > > > From: Ard Biesheuvel
> > > > Sent: Friday, June 2, 2023 4:39 PM
> > > >
Merged
Mike
> -Original Message-
> From: Li, Yong
> Sent: Monday, June 5, 2023 12:45 AM
> To: devel@edk2.groups.io; suni...@ventanamicro.com; Kinney, Michael D
> ; Gao, Liming
> Cc: Warkentin, Andrei ; Chai, Evan
> ; Tuan Phan
> Subject: Re: [edk2-devel] [PATCH v2 1/1] MdePkg/BaseLib:
> > Subject: Re: [edk2-devel] failed pr
> >
> > Another one
> >
> > https://github.com/tianocore/edk2/pull/4473
> >
> > On Sat, 3 Jun 2023 at 00:32, Ard Biesheuvel wrote:
> > >
> > > Thanks!
> > >
> > > On Fri, 2 Jun 202
; Subject: RE: [PATCH v2] MdePkg ACPI65: Update MADT Revision pre ACPI Spec
> 6.5
>
> Reviewed-by: Michael D Kinney
>
>
>
> > -Original Message-
> > From: Chen, Aryeh
> > Sent: Thursday, June 1, 2023 4:56 AM
> > To: devel@edk2.groups.io
> > Cc:
o, Liming ; Liu,
> > > Zhiguang ; Oliver Smith-Denny
> > > ; Pop, Aaron
> > > Subject: Re: [Patch v2 1/3] MdePkg/Include/IndustryStandard: Add
> Operator
> > > and Xor field names
> > >
> > > On Tue, May 30, 2023 at 7:53 PM Michael D Ki
thub.com/tianocore/edk2/pull/4473
>
> On Sat, 3 Jun 2023 at 00:32, Ard Biesheuvel wrote:
> >
> > Thanks!
> >
> > On Fri, 2 Jun 2023 at 18:38, Michael D Kinney
> > wrote:
> > >
> > > Done.
> > >
> > > Mike
> > >
> &g
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Oliver Smith-Denny
> Sent: Friday, June 2, 2023 1:45 PM
> To: devel@edk2.groups.io
> Cc: Sean Brogan ; Michael Kubacki
> ; Kinney, Michael D
> ; Gao, Liming
> Subject: [edk2-devel][PATCH v1 1/1] CharEnc
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Chen, Aryeh
> Sent: Thursday, June 1, 2023 4:56 AM
> To: devel@edk2.groups.io
> Cc: Chen, Aryeh ; Kinney, Michael D
> ; Gao, Liming ; Liu,
> Zhiguang ; Yao, Jiewen
> Subject: [PATCH v2] MdePkg ACPI65:
Done.
Mike
> -Original Message-
> From: Kinney, Michael D
> Sent: Friday, June 2, 2023 9:37 AM
> To: devel@edk2.groups.io; a...@kernel.org; Michael Kubacki
> ; Sean Brogan
> Cc: Kinney, Michael D
> Subject: RE: [edk2-devel] failed pr
>
> I am working on it.
>
> Mike
>
> > -Origi
I am working on it.
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Ard
> Biesheuvel
> Sent: Friday, June 2, 2023 9:19 AM
> To: Kinney, Michael D ; Michael Kubacki
> ; Sean Brogan ;
> edk2-devel-groups-io
> Subject: [edk2-devel] failed pr
>
> Could someone push the
t; >> Instead of saving the files to the same file system of unit test
> >> application, this change will save the cache file to the path where the
> >> user ran this test application.
> >>
> >> This change was tested on proprietary physical hardware platf
Hi Gerd,
Can you update this patch series to the latest edk2 so we can work
on adding OpenSSL 3.0 in the June timeframe so it can perhaps be
part of the August stable tag?
You mention some CI issues. Do you have a summary? Do you need help
on specific blocking issues?
Do you have OVMF X64 work
; Oliver Smith-Denny
> > ; Pop, Aaron
> > Subject: Re: [Patch v2 1/3] MdePkg/Include/IndustryStandard: Add Operator
> > and Xor field names
> >
> > On Tue, May 30, 2023 at 7:53 PM Michael D Kinney
> > wrote:
> > >
> > > Update Tpm12.h and Tpm20.h
the files to the same file system of unit test
> application, this change will save the cache file to the path where the
> user ran this test application.
>
> This change was tested on proprietary physical hardware platforms and
> QEMU based virtual platform.
>
> C
dard: Add Operator
> and Xor field names
>
> On Tue, May 30, 2023 at 7:53 PM Michael D Kinney
> wrote:
> >
> > Update Tpm12.h and Tpm20.h and not use c++ reserved keywords
> > operator and xor in C structures to support use of these
> > include files when
Zhiguang ; Oliver Smith-Denny
> ; Pop, Aaron
> Subject: Re: [Patch 0/2] Address C++ keyword collisions
>
> On Mon, May 29, 2023 at 6:06 PM Michael D Kinney
> wrote:
> >
> > Update Tpm12.h and Tpm20.h and not use c++ reserved keywords
> > operator and xor in C struct
nny
Cc: Pedro Falcato
Cc: Aaron Pop
Signed-off-by: Michael D Kinney
Michael D Kinney (3):
MdePkg/Include/IndustryStandard: Add Operator and Xor field names
SecurityPkg/Library/TpmCommandLib: Change xor to Xor
MdePkg/Include/IndustryStandard: Address C++ keyword collisions
MdePkg/Includ
names to the new field names.
Warning 4201 is disabled for VS20xx tool chains is a temporary
change to allow the use of anonymous unions.
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Oliver Smith-Denny
Cc: Pedro Falcato
Cc: Aaron Pop
Signed-off-by: Michael D Kinney
---
MdePkg/Include/IndustryStandard
Change xor to Xor to avoid C++ reserved work name collisions
when building with C++ compilers.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Oliver Smith-Denny
Cc: Pedro Falcato
Cc: Aaron Pop
Signed-off-by: Michael D Kinney
---
SecurityPkg/Library/Tpm2CommandLib/Tpm2Capability.c | 6
ver Smith-Denny
Cc: Pedro Falcato
Cc: Aaron Pop
Signed-off-by: Michael D Kinney
---
MdePkg/Include/IndustryStandard/Tpm12.h | 20 +---
MdePkg/Include/IndustryStandard/Tpm20.h | 25 ++---
2 files changed, 3 insertions(+), 42 deletions(-)
diff --git a/MdePkg/Incl
ginal Message-
> > > From: Ard Biesheuvel
> > > Sent: Tuesday, May 30, 2023 7:36 AM
> > > To: devel@edk2.groups.io; Kinney, Michael D
>
> > > Cc: Sean Brogan ; Rebecca Cran
> ;
> > > Kubacki, Michael ; Gao, Liming
> > >
> > >
30, 2023 7:36 AM
> To: devel@edk2.groups.io; Kinney, Michael D
> Cc: Sean Brogan ; Rebecca Cran ;
> Kubacki, Michael ; Gao, Liming
>
> Subject: Re: [edk2-devel] failed Pr
>
> On Mon, 29 May 2023 at 18:45, Michael D Kinney
> wrote:
> >
> > Hi Sean,
> >
,
Thanks for your comments.
According to DscBuildData.py , it only supports VS on windows OS. How can we
support Cygwin to compile Pcdvalueinit on windows OS?
Thanks
Yepings
From: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
mailto:devel@edk2.groups.io>> On Behalf Of Michael D
h. And consumers of these include files that access
the "operator" or "xor" fields must be updated.
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Oliver Smith-Denny
Cc: Pedro Falcato
Cc: Aaron Pop
Signed-off-by: Michael D Kinney
---
MdePkg/Include/IndustryStandard/Tpm12.
Yao
Cc: Jian J Wang
Cc: Oliver Smith-Denny
Cc: Pedro Falcato
Cc: Aaron Pop
Signed-off-by: Michael D Kinney
---
SecurityPkg/Library/Tpm2CommandLib/Tpm2Capability.c | 6 +++---
SecurityPkg/Library/Tpm2CommandLib/Tpm2Object.c | 6 +++---
SecurityPkg/Library/Tpm2CommandLib/Tpm2Session.c| 2
his is a non-backwards compatible change to Tpm12.h
and Tmp20.h. And consumers of these include files that access
the "operator" or "xor" fields must be updated.
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Oliver Smith-Denny
Cc: Pedro Falcato
Cc: Aaron Pop
Signed-off-by: Michael D
Hi Sean,
I see the "rerun" button on the "checks" page of GitHub from my login.
We have a mix of both Azure Pipelines and GitHub Actions today, so I think it
is important to see the "rerun" from GitHub view for Maintainers.
This github page describes the feature, but not the permissions require
Hi Sean,
Do you know what GitHub permissions are required to see the re-run button?
I think it is reasonable for all Maintainers to have that available.
Mike
From: devel@edk2.groups.io On Behalf Of Sean
Sent: Monday, May 29, 2023 8:12 AM
To: devel@edk2.groups.io; a...@kernel.org; Rebecca Cran
Move initialization of local variable structure from declaration
to statements to fix VS2015x86 build break.
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Signed-off-by: Michael D Kinney
---
OvmfPkg/VirtioSerialDxe/VirtioSerial.c | 10 +-
1 file changed, 5
Pedro and Oliver,
Yes. Renaming the struct members is my preferred solution.
This is why I did not send this as a code review as an
official change request.
It was just to complete the set of options to consider
* No code changes. Figure out compiler flags to address.
STATUS: No complete so
lity with MdePkg's
> IndustyStandard header files
>
> On Thu, May 25, 2023 at 1:24 AM Michael D Kinney
> wrote:
> >
> > That is exactly what I did. Along with pragma to disable error on macros
> redefining operators.
> >
> > With that change use of "oper
gt; IndustyStandard header files
>
> On Wed, May 24, 2023 at 10:23 PM Michael D Kinney
> wrote:
> >
> > After trying a few GCC experiments, there does not appear to be any way
> to work around “xor” keyword.
> >
> >
> >
> > I recommend we update ED
After trying a few GCC experiments, there does not appear to be any way to work
around "xor" keyword.
I recommend we update EDK II sources to not use c++ keywords to avoid this
issue all together.
This may require changes that do not match names from industry standard specs.
Mike
From: Aaron
Hi Aaron,
Don't know if this will completely resolve your issues, but if you add some
preprocessor statements around the problematic includes in your unit test CPP
file, you may be able to get it to build.
For example, I added the highlighted lines to
MdePkg\Test\GoogleTest\Library\BaseSafeInt
It is supposed to use the host compiler. Same one used to build
BaseTools/Source/C
Mike
From: devel@edk2.groups.io On Behalf Of
yepi...@qti.qualcomm.com
Sent: Wednesday, May 24, 2023 1:58 AM
To: devel@edk2.groups.io
Subject: [edk2-devel] BaseTools: how to generate PcdValueInit without VS?
Hi
8:51 AM
> To: devel@edk2.groups.io; Kinney, Michael D
>
> Cc: ler...@redhat.com; Ni, Ray ; Yao, Jiewen
> ; Gerd Hoffmann ; Taylor
> Beebe ; Oliver Smith-Denny
> Subject: Re: [edk2-devel] managing memory attributes in PEI
>
> On Tue, 23 May 2023 at 17:15, Michael D Kinney
>
> -Original Message-
> From: Ard Biesheuvel
> Sent: Tuesday, May 23, 2023 7:59 AM
> To: Kinney, Michael D
> Cc: devel@edk2.groups.io; ler...@redhat.com; Ni, Ray ;
> Yao, Jiewen ; Gerd Hoffmann
> ; Taylor Beebe ; Oliver Smith-
> Denny
> Subject: Re: [edk2-devel] managing memory attribut
Ard,
I would prefer to keep the IA32 PEI support for OVMF.
Ray had proposed an idea to introduce a library class to help
with the DXEIPL complexity. Perhaps that can be combines with
this effort.
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Laszlo
> Ersek
> Se
t; I cannot set the 'push' label myself, it seems.
>
>
>
> On Mon, 22 May 2023 at 16:10, Kinney, Michael D
> wrote:
> >
> > Acked-by: Michael D Kinney
> >
> > No objection to merging for the stable tag.
> >
> > Mike
> >
>
Acked-by: Michael D Kinney
No objection to merging for the stable tag.
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Leif
> Lindholm
> Sent: Monday, May 22, 2023 3:56 AM
> To: Ard Biesheuvel
> Cc: devel@edk2.groups.io; Gao, Liming ;
> Kinne
edk2 pip modules
>
> I rebased the commit and added Mike's R-b in the PR.
>
> https://github.com/tianocore/edk2/pull/4401
>
> On 5/17/2023 9:01 PM, Michael D Kinney wrote:
> > Reviewed-by: Michael D Kinney
> >
> >> -Original Message-
> >
guess my other question… If this turns out to be a compiler bug should we
scope the change to the broken toolchain. I’m not sure what the right answer is
for that, but I want to ask the question?
Thanks,
Andrew Fish
On May 18, 2023, at 10:19 AM, Michael D Kinney
mailto:michael.d.kin...@intel.c
piler issue right now, but I’ve
NOT gotten feedback from anyone on the spec committee yet.
If we move Index to a static global that would likely work around the compiler
issue.
Thanks,
Andrew Fish
On May 18, 2023, at 8:36 AM, Michael D Kinney
mailto:michael.d.kin...@intel.com>> w
:36 AM, Michael D Kinney
mailto:michael.d.kin...@intel.com>> wrote:
Hi Ray,
So the code generated does deadloop, but is just not easy to resume from as we
have been able to do in the past.
We use CpuDeadloop() for 2 purposes. One is a terminal condition with no
reason to ever continue
ocated 3 pages is 8KB-aligned, then the higher
> > 2 pages range of allocated 3 pages is 8KB-aligned and will be
> > selected and removed from free pages. The remaining lower one page
> > of allocated 3 pages will be free and merged with left lower free
> > memory. This can
Hi Ray,
So the code generated does deadloop, but is just not easy to resume from as we
have been able to do in the past.
We use CpuDeadloop() for 2 purposes. One is a terminal condition with no
reason to ever continue.
The 2nd is a debug aide for developers to halt the system at a specific
l
Reviewed-by: Michael D Kinney
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael
> Kubacki
> Sent: Wednesday, May 17, 2023 5:50 PM
> To: devel@edk2.groups.io; Kinney, Michael D ;
> Gao, Liming ; rebe...@bsdio.com; 'Liming Gao'
>
>
Is there a PR with EDK II CI results?
Mike
> -Original Message-
> From: Michael Kubacki
> Sent: Wednesday, May 17, 2023 5:13 PM
> To: devel@edk2.groups.io; Gao, Liming ;
> rebe...@bsdio.com; Kinney, Michael D ;
> 'Liming Gao'
> Cc: 'Sean Brogan' ; 'Andrew Fish'
> ; 'Leif Lindholm'
> Su
Please add Cc lines for all package owners so it matches typical email filters.
I agree this is a good cleanup to use GCC instead of GCC5 consistently.
We should let each package owner provide feedback on if this change should go
in before or after the stable tag.
It is not a critical bug fix,
gt; > > > > To: Kinney, Michael D ;
> > > > > > devel@edk2.groups.io
> > > > > > Cc: Sunil V L
> > > > > > Subject: Re: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed
> > > > > > SerialLib
> > > > > >
> > &g
l] [PATCH v7 0/3] RISC-V SBI-backed
> > > > > SerialLib
> > > > >
> > > > > Thanks for the review. I believe this patch set is ready for merging.
> > > > > Sunil had one comment on the contents of the UNI file, which I
> >
r merging.
> > > Sunil had one comment on the contents of the UNI file, which I
> > > clarified. Sunil, anything else you wanted from this patch set or is it
> > > good
> > to go?
> > >
> > > A
> > >
> > > >
Hi Isaac,
We do have a standard handler for unexpected exception that dumps all CPU state
to serial.
UefiCpuPkg\Library\CpuExceptionHandlerLib
This seems similar/related use case.
Mike
> -Original Message-
> From: Oram, Isaac W
> Sent: Tuesday, May 16, 2023 12:12 PM
> To: Kinney, Mi
Hi Isaac,
Multiple status code handlers can be registered. One for memory and one for
serial.
Why would we mix serial into memory one?
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Isaac
> Oram
> Sent: Tuesday, May 16, 2023 10:39 AM
> To: devel@edk2.groups.io; O
rage files in single command line to
> > > breaking it up into many command lines with one coverage file per
> > > command line in order to prevent single line is over to 8191 characters.
> > >
> > > - Command Line 1
> > >> OpenCppCoverage
>
Merged
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Rebecca
> Cran
> Sent: Wednesday, May 10, 2023 7:50 AM
> To: Ard Biesheuvel
> Cc: devel@edk2.groups.io; Gao, Liming ; Feng,
> Bob C ; Chen, Christine ;
> Kinney, Michael D ; Gao, Liming
>
> Subject: Re: [edk2-de
?id=4144
>
> This Library provides API to dump Trace Hub message.
>
> Cc: Michael D Kinney
> Cc: Guo Gua
> Cc: Chan Laura
> Cc: Prakashan Krishnadas Veliyathuparambil
>
> Cc: K N Karthik
> Signed-off-by: Guo Gua
> Reviewed-by: Michael D Kinney
>
37,6 +437,14 @@ R: Zhiguang Liu
> > [LiuZhiguang001]
> > > R: Ray Ni [niruiyu]
> > > R: Gua Guo [gguo11837463]
> > >
> > > +MdeModulePkg: Trace Hub debug message related library instance
> > > +F: MdeModulePkg/Library/TraceHubDebugSysTLib/
> >
bDebugSysTLib/
> > +F: MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h
> > +M: Gua Guo [gguo11837463]
> > +M: Prakashan Krishnadas Veliyathuparambil
> [kprakas2]
> > +R: Chan Laura [lauracha]
> > +R: K N Karthik [karthikkabbigere1]
> > +
> > MdePkg
> >
> From: Gua Guo
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4144
> >
> > This Library provides functions consuming MIPI SYS-T submodule.
> >
> > Cc: Michael D Kinney
> > Cc: Guo Gua
> > Cc: Chan Laura
> > Cc:
Series Reviewed-by: Michael D Kinney
Liming, this code review started well before the soft freeze. It has now
passed review.
We should include this in this stable-tag release.
Mike
> -Original Message-
> From: Guo, Gua
> Sent: Wednesday, May 10, 2023 2:20 AM
> To
Series Reviewed-by: Michael D Kinney
Series Tested-by: Michael D Kinney
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Rebecca
> Cran
> Sent: Tuesday, May 9, 2023 4:54 PM
> To: devel@edk2.groups.io; Gao, Liming ; Feng,
> Bob C ; Chen, Christine
Is there a PR with Rbs added to commit messages?
Mike
> -Original Message-
> From: Rebecca Cran
> Sent: Tuesday, May 9, 2023 5:29 PM
> To: Gao, Liming ; devel@edk2.groups.io;
> pedro.falc...@gmail.com
> Cc: Feng, Bob C ; Chen, Christine
> ; 'Andrew Fish' ; 'Leif Lindholm'
> ; Kinney, Mic
CH v3 0/2] Add more google mock library
>
> Series Reviewed-by: Michael D Kinney
>
> Mike
>
> > -Original Message-
> > From: devel@edk2.groups.io On Behalf Of Guo,
> > Gua
> > Sent: Monday, May 8, 2023 5:04 PM
> > To: devel@edk2.groups.io
>
ks for everyone.
> >>
> >> Mike
> >>
> >>> -Original Message-
> >>> From: Oliver Smith-Denny
> >>> Sent: Monday, May 1, 2023 10:53 AM
> >>> To: Ard Biesheuvel ; devel@edk2.groups.io; Kinney,
> >>> Mic
Series Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Guo, Gua
> Sent: Monday, May 8, 2023 5:04 PM
> To: devel@edk2.groups.io
> Cc: Guo, Gua
> Subject: [edk2-devel] [PATCH v3 0/2] Add more google mock library
When reviewing the Variable feature that adds integrity and confidentiality,
I suggested that the interface between the Variable services and the NVStorage
could provide an abstraction to encode/decode the stored data that would
support encryption, compression, or both. Could also support a platfo
yathuparambil
> ; K N, Karthik
>
> Subject: [PATCH 1/4] MdePkg: Add MipiSysTLib library
>
> From: VictorX Hsu
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4144
>
> This Library provides functions consuming MIPI SYS-T submodule.
>
> Cc: Michael D Ki
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4144
>
> This Library provides API to dump Trace Hub message.
>
> Cc: Michael D Kinney
> Cc: Guo Gua
> Cc: Chan Laura
> Cc: Prakashan Krishnadas Veliyathuparambil
>
> Cc: K N Karthik
> Signed-off
haracter limitation,
> enhance it to make command too long can be resloved.
>
> Change-Id: I7f1d8d46274f1c0104572d47253d499900effe76
> Cc: Michael D Kinney
> Cc: Sean Brogan
> Cc: Michael Kubacki
> Signed-off-by: Gua Guo
> ---
> .../HostBasedUnitTestRunner.py
Can you please send the updated email patches. I could not get the previous
version to apply.
Mike
> -Original Message-
> From: Hsu, VictorX
> Sent: Sunday, May 7, 2023 10:19 PM
> To: Kinney, Michael D ; Guo, Gua
> ; devel@edk2.groups.io
> Cc: Chiu, Chasel ; Prakashan, Krishnadas
> Vel
Gua,
I see this PR says it passes CI but there are merge conflicts.
Can you please update the series to address the conflicts.
Thanks,
Mike
> -Original Message-
> From: Guo, Gua
> Sent: Thursday, April 20, 2023 7:33 PM
> To: devel@edk2.groups.io; Hsu, VictorX
> Cc: Chiu, Chasel ; Kin
> > Cc: 'Rebecca Cran' ; Feng, Bob C
> > > ; Chen, Christine
> > > Subject: 回复: [edk2-devel] [Patch 1/1] BaseTools/Conf: Add quotes to
> > > ADDDEBUGFLAG in tools_def.txt
> > >
> > > Mike:
> > > Do you mean $(DEBUG_DIR)/$(MODULE_NAME).d
gt; Subject: 回复: [edk2-devel] [Patch 1/1] BaseTools/Conf: Add quotes to
> ADDDEBUGFLAG in tools_def.txt
>
> Mike:
> Do you mean $(DEBUG_DIR)/$(MODULE_NAME).debug file path may have
> space on
> windows OS? Does the workspace directory include the space?
>
> Thanks
> L
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4448
Update tools_def.txt to add quotes around the file target in
OBJCOPY_ADDDEBUGFLAGS for compatibility with GCC like tool
chains used on Windows.
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Cc: Yuwei Chen
Signed-off-by: Michael D Kinney
401 - 500 of 2244 matches
Mail list logo
