[edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: update Readme.md

Update readme for below topics: - The call flow of BIOS Redfish provisioning scenario. - The call flow of BIOS Redfish pending settings scenario. - The call flow of Redfish feature driver dispatch. - Redfish foundation driver stack design. - The design of Redfish Platform Config Protocol. - The

[edk2-devel] [PATCH v2 1/1] RedfishPkg/RedfishPlatformConfigDxe: fix can not set one-of option issue.

StatementValue->Buffer is converted from ASCII to Unicode by caller already so we don't have to convert it again. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishPlatformConfigDxe.c| 11 +-- 1 file changed, 5

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformConfigDxe: fix can not set one-of option issue.

Hi Igor, Version 2 is here: https://edk2.groups.io/g/devel/message/108516 Please help me to review this while you have chance. Thanks, Nickle > -Original Message- > From: Igor Kulchytskyy > Sent: Thursday, August 3, 2023 9:27 PM > To: Nickle Wang ; devel@edk2.groups.io > Cc: Abner

Re: [edk2-devel] [PATCH v2 3/6] RedfishClientPkg: fix leak of allocated Etag data

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Tuesday, August 29, 2023 4:01 PM > To: devel@edk2.groups.io > Cc: abner.ch...@amd.com; Nickle Wang ; > ig...@ami.com; Mike Maslenkin > Subject: [PATCH v2 3/6] RedfishClientPkg: fix leak of

Re: [edk2-devel] [PATCH v2 2/6] RedfishClientPkg: fix access to uninitialized variable

Thanks for fixing this issue, Mike. Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Tuesday, August 29, 2023 4:01 PM > To: devel@edk2.groups.io > Cc: abner.ch...@amd.com; Nickle Wang ; > ig...@ami.com; Mike Maslenkin > Subject: [PATCH v2

Re: [edk2-devel] [PATCH v2 1/6] RedfishClientPkg: fix crash on access to uninialized list variable.

Reviewed-by: Nickle Wang @abner.ch...@amd.com, I am thinking that we may need to provide allocation function for CS structure so caller does not need to handle linked-list initialization like this one, or other stuff requies understanding to CS structure

Re: [edk2-devel] [PATCH v2 5/6] RedfishClientPkg: fix misprints in Readme.md

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Tuesday, August 29, 2023 4:01 PM > To: devel@edk2.groups.io > Cc: abner.ch...@amd.com; Nickle Wang ; > ig...@ami.com; Mike Maslenkin > Subject: [PATCH v2 5/6] RedfishClientPkg: fix

Re: [edk2-devel] [PATCH v2 6/6] RedfishClientPkg: spelling fixes

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Tuesday, August 29, 2023 4:01 PM > To: devel@edk2.groups.io > Cc: abner.ch...@amd.com; Nickle Wang ; > ig...@ami.com; Mike Maslenkin > Subject: [PATCH v2 6/6] RedfishClientPkg: spelling

Re: [edk2-devel] [PATCH v2 4/6] RedfishClientPkg: fix memory leak during EFI variables write.

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Tuesday, August 29, 2023 4:01 PM > To: devel@edk2.groups.io > Cc: abner.ch...@amd.com; Nickle Wang ; > ig...@ami.com; Mike Maslenkin > Subject: [PATCH v2 4/6] RedfishClientPkg: fix memory

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishCrtLib: remove multiple definitions.

> double declaration of 'strcpy' is still there. Thanks for catching this, Mike. Version 2 patch file was sent. Regards, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Mike > Maslenkin via groups.io > Sent: Tuesday, October 24, 2023 4:23 AM > To: Nickle Wang >

Re: [edk2-devel] [edk2-platforms][PATCH 1/2] ManageabilityPkg/Ipmi: Remove IpmiCommandLib.h from ManageabilityPkg

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, Abner > via groups.io > Sent: Wednesday, October 18, 2023 12:51 PM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; Isaac Oram > ; Nickle Wang >

Re: [edk2-devel] [PATCH v3] RedfishPkg/RedfishCrtLib: remove multiple definitions.

chments > > > On Tue, Oct 31, 2023 at 3:56 PM Nickle Wang via groups.io > mailto:nicklew=nvidia@groups.io>> wrote: > > > > There are two definitions for below functions in RedfishCrtLib.h. > > Create this change to remote duplicated functions. >

Re: [edk2-devel] [PATCH v2] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx

This change looks good to me. Just minor comments: > DEBUG ((DEBUG_INFO, "%a: all required protocols are found on this controller > handle: %p.\n", __func__, ControllerHandle)); Could we use DEBUG_MANAGEABILITY to replace DEBUG_INFO in Redfish driver? This gives us the way to show

[edk2-devel] [edk2-redfish-client][PATCH 0/2] introduce Redfish override protocol

Introduce Redfish override protocol. If platform likes to do specific operation before system reboot, platform implement this protocol and Redfish feature core driver will call it to notify platform that system is going to reboot. Platform can reject system reboot by returning error status based

[edk2-devel] [edk2-redfish-client][PATCH 2/2] RedfishClientPkg/RedfishFeatureCoreDxe: notify platform before reboot.

Call Redfish override protocol to notify platform that the Redfish changes system settings and about to perform system reboot. Platform firmware can do platform specific operation before system rebooted. To follow platform policy, platform can reject system reboot by returning error status and

[edk2-devel] [edk2-redfish-client][PATCH 1/2] RedfishClientPkg: introduce Redfish override protocol

Introduce Redfish override protocol to notify platform that the Redfish changes system settings and about to perform system reboot. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- RedfishClientPkg/RedfishClientPkg.dec | 2 +

Re: [edk2-devel] [PATCH v3] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx

Thanks for fixing this issue. This version looks good to me. I test it on my system and it works well. Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Igor Kulchytskyy > Sent: Tuesday, November 7, 2023 8:06 PM > To: devel@edk2.groups.io > Cc: Abner Chang ;

Re: [edk2-devel] [PATCH v3] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx

Hi @Liming Gao, @Kinney, Michael D > If the patch is sent before Soft Feature Freeze, and plans to catch this > stable tag, the patch contributor need reply to his patch and notify edk2 > community We would like to

[edk2-devel] [edk2-redfish-client][PATCH 3/3] RedfishClientPkg/RedfishFeatureUtilityLib: fix issues and enhancement

-Add RedfishDebugLib to print Redfish request and response details when PATCH and POST request return error. -Use "%a:" in debug print to align with the style in EDK2. -Enhance GetConfigureLang() to handle pending resource URI. Pending resource share ths same schema as its active resource. So we

[edk2-devel] [edk2-redfish-client][PATCH 0/3] Fix various issues and enhancement.

Fix various issues and add enhancement to RedfishClientPkg. PR is opened here: https://github.com/tianocore/edk2-redfish-client/pull/55 Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Nickle Wang (3): RedfishClientPkg/RedfishETagDxe: fix uninitialized

[edk2-devel] [edk2-redfish-client][PATCH 1/3] RedfishClientPkg/RedfishETagDxe: fix uninitialized variable issue

Status variable is not initialized. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c

[edk2-devel] [edk2-redfish-client][PATCH 2/3] RedfishClientPkg/RedfishConfigLangMapDxe: uninitialized variable issue

-RedfishConfigLangMapDxe relies on variable arch protocol. -Status variable is not initialized. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.inf | 4 ++--

Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: Uncrustify on C source files

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Laszlo Ersek > Sent: Thursday, October 26, 2023 5:50 PM > To: devel@edk2.groups.io; Chang, Abner > Cc: Attar, AbdulLateef (Abdul Lateef) ; Nickle > Wang ; Konstantin Aladyshev > Subject: Re: [edk2-devel]

Re: [edk2-devel] [edk2-redfish-client][PATCH v2 0/11] RedfishClientPkg: various minor fixes

Reviewed this patch series. Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Friday, October 27, 2023 7:54 AM > To: devel@edk2.groups.io > Cc: abner.ch...@amd.com; Nickle Wang ; > ig...@ami.com; Mike Maslenkin > Subject:

[edk2-devel] [PATCH v3] RedfishPkg/RedfishCrtLib: remove multiple definitions.

There are two definitions for below functions in RedfishCrtLib.h. Create this change to remote duplicated functions. Function list: strcmp(), strncmp(), strncpy(), strcpy(), strcat(), strlen(), strchr(), strcasecmp(), strstr(), memcmp(), memset(), memcpy(), memchr(), memcmp() and memmove().

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishCrtLib: remove multiple definitions.

Thanks Mike! By following the logic, strlen() can be removed too. Version 3 patch is here: https://edk2.groups.io/g/devel/message/110408 I removed memcmp, memmove, and strlen. Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Sunday, October 29, 2023 9:58 PM > To:

Re: [edk2-devel] [PATCH 0/9] RedfishClientPkg: various minor fixes

Reviewed this patch series. Hi Mike, Could you please address Abner's comment on "[PATCH 9/9] RedfishClientPkg: fix StrnCpyS arguments"? This patch series can be merged after Abner gives reviewed-by to patch 9/9. Thanks, Nickle > -Original Message- > From: Mike Maslenkin > Sent:

[edk2-devel] [edk2-redfish-client][PATCH v2] RedfishClientPkg/RedfishLib: align with edk2 RedfishLib

Update RedfishLib to align with RedfishLib in edk2 repository. RedfishLib commits on edk2: cf68ff61 RedfishPkg/RedfishLib: introduce new interfaces. 1cbdd6e9 RedfishPkg/libredfish: introduce new interfaces. 8765f3eb RedfishPkg/RedfishLib: return HTTP headers to caller. Signed-off-by: Nickle Wang

[edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/RedfishLib: align with edk2 RedfishLib

Update RedfishLib to align with RedfishLib in edk2 repository. RedfishLib commits on edk2: cf68ff61 RedfishPkg/RedfishLib: introduce new interfaces. 1cbdd6e9 RedfishPkg/libredfish: introduce new interfaces. 8765f3eb RedfishPkg/RedfishLib: return HTTP headers to caller. Signed-off-by: Nickle Wang

Re: [edk2-devel] [PATCH 1/2] MdePkg/Include: Definitions of IPMI Get System Interface Capabilities

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, Abner > via groups.io > Sent: Tuesday, October 10, 2023 4:36 PM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; Michael D > Kinney ; Liming Gao ; >

Re: [edk2-devel] [PATCH 2/2] MdeModulePkg/Include: API of IPMI Get System Interface Capabilities

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, Abner > via groups.io > Sent: Tuesday, October 10, 2023 4:36 PM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; Jian J Wang > ; Liming Gao > Subject:

Re: [edk2-devel] [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP headers to caller

Hi Igor, If the DELETE request to BMC is handled by Redfish task, we need to return HTTP header to caller so caller can get Task URI. But from BIOS Redfish perspective, I don't see this use case yet. Thanks, Nickle > -Original Message- > From: Igor Kulchytskyy > Sent: Thursday,

Re: [edk2-devel] [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP headers to caller

According to my experience, BIOS Redfish is usually the owner to handle Redfish task request, not the user to create task. So, I think that BIOS has no chance to read HTTP header in DELETE request/response. But from specification perspective, Redfish task URI can be returned in HTTP header in

[edk2-devel] [PATCH v2] RedfishPkg/RedfishCrtLib: remove multiple definitions.

There are two definitions for below functions in RedfishCrtLib.h. Create this change to remote duplicated functions. Function list: strcmp(), strncmp(), strncpy(), strcpy(), strcat(), strchr(), strcasecmp(), strstr(), memcmp(), memset(), memcpy() and memchr(). Signed-off-by: Nickle Wang Cc:

Re: [edk2-devel] [PATCH 1/1] Maintainers.txt: Update maintainers list

Acked-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Thursday, October 19, 2023 1:43 PM > To: devel@edk2.groups.io > Cc: Andrew Fish ; Leif Lindholm ; > Michael D Kinney ; Abdul Lateef Attar > ; Nickle Wang ; Jian J > Wang ; Liming Gao ; >

[edk2-devel] [PATCH v2] RedfishPkg/JsonLib: fix JsonObjectGetValue issue

JsonObjectGetValue() cannot find corresponding JSON value when the EDKII_JSON_VALUE object is created by another UEFI driver. This is because "hashtable_seed" is initialized by current time while JsonLib is loaded. So, "hashtable_seed" will be different in each individual UEFI driver.

Re: [edk2-devel] [PATCH] RedfishPkg/JsonLib: fix JsonObjectGetValue issue

Hi Igor, According to my understanding to jansson implementation, json_object_seed() is only called in three places. Two of them are in test code and we don't use them in EDK2. The only chance to call json_object_seed() is in json_object(). So, it is called when driver create new JSON object

Re: [edk2-devel] [PATCH v2] RedfishPkg/RedfishRestExDxe: return HTTP status code to caller.

- > From: devel@edk2.groups.io On Behalf Of Nickle Wang > via groups.io > Sent: Monday, September 18, 2023 9:13 PM > To: devel@edk2.groups.io > Cc: Abner Chang ; Igor Kulchytskyy ; > Nick Ramirez ; Mike Maslenkin > > Subject: [edk2-devel] [PATCH v2] RedfishPkg/Redfis

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishRestExDxe: return HTTP status code to caller.

Hi Mike, Sorry for my late response. Version2 is here: https://edk2.groups.io/g/devel/message/108778 Please help me to review it while you have chance. Thanks, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Thursday, August 3, 2023 6:16 PM > To: Nickle Wang > Cc:

[edk2-devel] [PATCH] RedfishPkg/JsonLib: fix JsonObjectGetValue issue

JsonObjectGetValue() cannot find corresponding JSON value when the EDKII_JSON_VALUE object is created by another UEFI driver. This is because "hashtable_seed" is initialized by current time while JsonLib is loaded. So, "hashtable_seed" will be different in each individual UEFI driver.

[edk2-devel] [PATCH v2] RedfishPkg/RedfishRestExDxe: return HTTP status code to caller.

Return unsupported HTTP status code to caller so caller can handle HTTP error status code. Current implementation only return EFI error to caller. Without knowing the HTTP status code, caller has trouble to handle HTTP request failure. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor

Re: [edk2-devel] [PATCH] RedfishPkg/JsonLib: fix JsonObjectGetValue issue

Hi Abner, I add suggested comment in version 2: https://edk2.groups.io/g/devel/message/108942 Thanks, Nickle > -Original Message- > From: Chang, Abner > Sent: Thursday, September 21, 2023 10:20 AM > To: Igor Kulchytskyy ; Nickle Wang ; > devel@edk2.groups.io > Cc: Nick Ramirez >

[edk2-devel] [edk2-redfish-client][PATCH v2] RedfishClientPkg: update Readme.md

Update readme for below topics: - The call flow of BIOS Redfish provisioning scenario. - The call flow of BIOS Redfish pending settings scenario. - The call flow of Redfish feature driver dispatch. - Redfish foundation driver stack design. - The design of Redfish Platform Config Protocol. - The

Re: [edk2-devel] [RFC][PATCH 0/2][edk2-redfish-client]: tune uncrustify script

Patch set Reviewed-by: Nickle Wang mailto:nick...@nvidia.com>> Hi @Mike Maslenkin, could you please add Abner and my Reviewed-by to two commit messages in this PR? https://github.com/tianocore/edk2-redfish-client/pull/53 And then I will merge this pull

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishRestExDxe: return HTTP status code to caller.

Thanks, Mike! I will add your acked-by to commit message and merge it. Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Tuesday, September 19, 2023 9:54 PM > To: Nickle Wang > Cc: devel@edk2.groups.io; Abner Chang ; Igor > Kulchytskyy ; Nick Ramirez > Subject: Re:

[edk2-devel] [PATCH] RedfishPkg/RedfishDiscoverDxe: introduce PcdRedfishSendReceiveTimeout

Introduce PCD PcdRedfishSendReceiveTimeout to RedfishDiscoverDxe driver. The SendReceiveTimeout is hard-code value in Redfish discover driver. With this PCD, platform owner can configure timeout value easily. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy ---

Re: [edk2-devel] [PATCH 8/9] RedfishClientPkg: fix pragma pack usage

Sorry for my late response. > Do we need pack(1) for this structure? We can remove pack directive if we > don't > need to have packed structure members. @nick...@nvidia.com, could you > please confirm this? I see the use of "pack(1)" in EDK2 DriverSample.h. I think we can keep it.

Re: [edk2-devel] [PATCH] RedfishPkg: Use base version SortLib for the specific modules

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Wednesday, October 11, 2023 11:41 AM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy ; Nhi > Pham > Subject: [PATCH] RedfishPkg: Use base version SortLib for the

Re: [edk2-devel] [PATCH 5/9] RedfishClientPkg: reduce identation level by adding early return

Sorry for the delay review. I go through the changes, and it looks good to me. Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Chang, Abner > Sent: Monday, October 2, 2023 11:10 AM > To: Mike Maslenkin ; devel@edk2.groups.io; Nickle > Wang > Cc: ig...@ami.com

[edk2-devel] [PATCH] RedfishPkg/RedfishPlatformConfigDxe: add debug message.

Add debug prints to show HII option name when assert happens. This helps developer to debug assert issue easily while Redfish failed to convert HII value to Redfish value. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishPlatformConfigDxe.c

[edk2-devel] [PATCH] RedfishPkg/RedfishCrtLib: remove multiple definitions.

There are two definitions for below functions in RedfishCrtLib.h. Create this change to remote duplicated functions. Function list: strcmp(), strncmp(), strncpy(), strcat(), strchr(), strcasecmp(), strstr(), memcmp(), memset(), memcpy() and memchr(). Signed-off-by: Nickle Wang Cc: Abner Chang

[edk2-devel] [PATCH] RedfishPkg/RedfishDiscoverDxe: remove Redfish false alarm

- It is expected that caller receives EFI_NO_MAPPING status when call issues Configure() to unconfigured network interface. Remove this false alarm in GetSubnetInfo() function. - Fix typos Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez ---

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishCrtLib: multiple definitions of strncpy.

Hi Mike, Sorry for the delay. I remove all duplicated definitions in RedfishCrtLib.h. Please check new patch file here: https://edk2.groups.io/g/devel/message/109925 Thanks, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Nickle Wang > via groups.

[edk2-devel] [PATCH 0/3] RedfishPkg/RedfishLib: Return HTTP headers to caller

The purpose of this patch series is to add new interfaces in RedfishLib to return HTTP headers to caller. I also fix typos and compile error in RedfishLib. PR is opened here: https://github.com/tianocore/edk2/pull/4944 Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick

[edk2-devel] [PATCH 1/3] RedfishPkg/RedfishLib: introduce new interfaces.

Add two new interface: RedfishServiceInPayload() and RedfishPutToUri() for Redfish HTTP protocol implementation. Fix several typos and add missing JsonLib in INF file. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez ---

[edk2-devel] [PATCH 2/3] RedfishPkg/libredfish: introduce new interfaces.

- Add new interfaces to return HTTP headers back to caller. New interfaces are: getUriFromServiceEx(), patchUriFromServiceEx(), postUriFromServiceEx() and putUriFromServiceEx(). - Fix compile error in payload.c Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez

[edk2-devel] [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP headers to caller

Call Ex interface to get HTTP headers and return to caller. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git

Re: [edk2-devel] [PATCH v2 08/12] RedfishPkg: CI: Add PrEval entry

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Joey Vagedes > Sent: Tuesday, October 24, 2023 1:52 AM > To: devel@edk2.groups.io > Cc: Abner Chang ; Nickle Wang ; > Igor Kulchytskyy > Subject: [PATCH v2 08/12] RedfishPkg: CI: Add PrEval entry > > External

Re: [edk2-devel] [PATCH 0/5] RedfishClientPkg: fix issues with local variables.

Hi Mike, > I didn't find any codyng-style issues in uncrustify output. I fetch your branch and run uncrustify tool to fix error in vs code editor. I push the fix to your branch at this commit for your reference:

Re: [edk2-devel] [PATCH 0/5] RedfishClientPkg: fix issues with local variables.

al spelling fixes. Do I need to > resend v.2 to > the list? > > Regards, > Mike. > > On Mon, Aug 28, 2023 at 12:03 PM Nickle Wang via groups.io > wrote: > > > > Hi Mike, > > > > > I didn't find any codyng-style issues in uncrustify output. > >

[edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialLib: IPMI implementation

This library follows Redfish Host Interface specification and use IPMI command to get bootstrap account credential(NetFn 2Ch, Command 02h) from BMC. RedfishHostInterfaceDxe will use this credential for the following communication between BIOS and BMC. Cc: Abner Chang Cc: Nick Ramirez

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialLib: IPMI implementation

Thanks for your review comments, Abner! I will update new version patch later. The CI build error will be handled together. > please add Igor as reviewer too Sure! > + *UserId = AllocateZeroPool (sizeof (CHAR8) * USERNAME_MAX_SIZE); > + if [Chang, Abner] Allocation memory with the size

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialLib: IPMI implementation

Hi Igor, Thank you for your help to review my changes. > And it will be blocked by our IPMI call. I see your point. So, BIOS should never be the person to shutdown credential service because BIOS always get executed prior to OS, right? > Should it be configured with some PCD? Maybe user may

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialLib: IPMI implementation

can deliver the credential to OS through EFI variable with disabling the bootstrap credential at exit boot service. Abner > RedfishCredentialGetAuthInfo and then use those cashed credentials on > subsequential calls? > It will also may save a boot time, since there is no need to send IPM

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishDiscoverDxe: Fix memory free issue

Reviewed-by: Nickle Wang From: devel@edk2.groups.io on behalf of Chang, Abner via groups.io Sent: Saturday, October 29, 2022 11:59 AM To: devel@edk2.groups.io Cc: Nickle Wang ; Igor Kulchytskyy Subject: [edk2-devel] [PATCH] RedfishPkg/RedfishDiscoverDxe: Fix

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialLib: IPMI implementation

OS through EFI variable with disabling the bootstrap credential at exit boot service. Abner > RedfishCredentialGetAuthInfo and then use those cashed credentials on > subsequential calls? > It will also may save a boot time, since there is no need to send IPMI > command. > > Thank you, >

[edk2-devel] [PATCH] RedfishPkg/JsonLib: Fix JsonLib build failure

VS2019 reports build failure: "warning C4701: potentially uninitialized local variable 'Ucs2Str' used". Initial Ucs2Str to NULL at the beginning of function. Cc: Abner Chang Cc: Nick Ramirez Signed-off-by: Nickle Wang --- RedfishPkg/Library/JsonLib/JsonLib.c | 2 ++ 1 file changed, 2

[edk2-devel] [PATCH] Maintainers.txt: Update email address

Update Nickle's email address from csie.io to nvidia.com for those packages which are reviewed by Nickle. Per suggestion from Abner, change Nickle from reviewer to maintainer for RedfishPkg. Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney Cc: Abner Chang Signed-off-by: Nickle Wang ---

Re: [edk2-devel] [PATCH V2 3/3] RedfishPkg/Include: Redfish USB Interface V2 update

Reviewed-by: Nickle Wang Regards, Nickle -Original Message- From: abner.ch...@amd.com Sent: Wednesday, December 28, 2022 1:14 PM To: devel@edk2.groups.io Cc: Nickle Wang ; Igor Kulchytskyy Subject: [PATCH V2 3/3] RedfishPkg/Include: Redfish USB Interface V2 update External email: Use

Re: [edk2-devel] [PATCH 3/3] RedfishPkg/Include: Redfish USB Interface V2 update

Hi Abner, Could you please also fix the typo in USB_INTERFACE_DEVICE_DESCRIPTOR_V2 structure together? There is typo at line 43: https://github.com/tianocore/edk2/blob/a086f4a63bc0295b0b02f8ee76381c6b437122bf/RedfishPkg/Include/IndustryStandard/RedfishHostInterface.h#L43 UINT8

[edk2-devel] [edk2-staging][PATCH] edk2-staging/RedfishClientPkg: Fix typo

Fix typo in RedfishPlatformConfigImpl.c Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[edk2-devel] [edk2-staging][PATCH] edk2-staging/RedfishClientPkg: Fix GCC build error

Fix below GCC build error: 1) "Head" dereference issue. 2) "BooleanArrayBuffer" uninitialized variable issue. 3) Multiple definition of mRedfishVariableGuid. 4) Multiple definition of medfishResourceConfigProtocolHandle. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick

[edk2-devel] [PATCH] MdeModulePkg/RegularExpressionDxe: Fix GCC build error

Fix GCC build error on AARCH64 system. Signed-off-by: Nickle Wang Cc: Jian J Wang Cc: Liming Gao Cc: Nick Ramirez --- .../Universal/RegularExpressionDxe/OnigurumaUefiPort.h | 5 + 1 file changed, 5 insertions(+) diff --git

Re: [edk2-devel] [Patch 1/1] RedfishPkg: Remove overlapping private include path in DEC file

Reviewed-by: Nickle Wang Regards, Nickle From: devel@edk2.groups.io On Behalf Of Igor Kulchytskyy via groups.io Sent: Tuesday, December 6, 2022 10:32 PM To: Chang, Abner ; Michael D Kinney ; devel@edk2.groups.io Cc: Nickle Wang Subject: Re: [edk2-devel] [Patch 1/1] RedfishPkg: Remove

Re: [edk2-devel] [PATCH 2/2] EmulatorPkg/RedfishHostInterface: Add NULL function

Reviewed-by: Nickle Wang Regards, Nickle -Original Message- From: abner.ch...@amd.com Sent: Monday, December 19, 2022 10:17 PM To: devel@edk2.groups.io Cc: Nickle Wang ; Igor Kulchytskyy Subject: [PATCH 2/2] EmulatorPkg/RedfishHostInterface: Add NULL function External email: Use

Re: [edk2-devel] [PATCH V2 1/2] RedfishPkg/RedfishHostInterface: Platform Redfish HI notification

Thanks for addressing my comment. Reviewed-by: Nickle Wang Regards, Nickle -Original Message- From: abner.ch...@amd.com Sent: Monday, December 19, 2022 10:51 PM To: devel@edk2.groups.io Cc: Nickle Wang ; Igor Kulchytskyy Subject: [PATCH V2 1/2] RedfishPkg/RedfishHostInterface:

Re: [edk2-devel] [PATCH V2 2/2] EmulatorPkg/RedfishHostInterface: Add NULL function

Reviewed-by: Nickle Wang Regards, Nickle -Original Message- From: abner.ch...@amd.com Sent: Monday, December 19, 2022 10:52 PM To: devel@edk2.groups.io Cc: Nickle Wang ; Igor Kulchytskyy Subject: [PATCH V2 2/2] EmulatorPkg/RedfishHostInterface: Add NULL function External email: Use

Re: [edk2-devel] [PATCH 1/2] RedfishPkg/RedfishHostInterface: Platform Redfish HI notification

Hi Abner, @@ -119,7 +123,7 @@ RedfishCreateSmbiosTable42 ( } else { NewProtocolRecords = ReallocatePool (CurrentProtocolsDataLength, NewProtocolsDataLength, (VOID *)ProtocolRecords); if (NewProtocolRecords == NULL) { -DEBUG ((DEBUG_ERROR, "%a: Fail to allocate memory

Re: [edk2-devel] [PATCH V3 1/2] RedfishPkg/RedfishHostInterface: Platform Redfish HI notification

Reviewed-by: Nickle Wang Thanks, Nickle -Original Message- From: abner.ch...@amd.com Sent: Tuesday, December 20, 2022 2:41 PM To: devel@edk2.groups.io Cc: Nickle Wang ; Igor Kulchytskyy Subject: [PATCH V3 1/2] RedfishPkg/RedfishHostInterface: Platform Redfish HI notification

Re: [edk2-devel] [PATCH V3 2/2] EmulatorPkg/RedfishHostInterface: Add NULL function

Reviewed-by: Nickle Wang Regards, Nickle -Original Message- From: abner.ch...@amd.com Sent: Tuesday, December 20, 2022 2:42 PM To: devel@edk2.groups.io Cc: Nickle Wang ; Igor Kulchytskyy Subject: [PATCH V3 2/2] EmulatorPkg/RedfishHostInterface: Add NULL function External email: Use

Re: [edk2-devel] [PATCH V2 1/2] RedfishPkg/RedfishHostInterface: Platform Redfish HI notification

al Message- From: devel@edk2.groups.io On Behalf Of Nickle Wang via groups.io Sent: Monday, December 19, 2022 11:11 PM To: abner.ch...@amd.com; devel@edk2.groups.io Cc: Igor Kulchytskyy Subject: Re: [edk2-devel] [PATCH V2 1/2] RedfishPkg/RedfishHostInterface: Platform Redfish HI notification

[edk2-devel] [edk2-staging][PATCH 3/3] edk2-staging/RedfishPkg: Add new interfaces to Redfish library

Add two new iterfaces to Redfish Platform Config Library in order to support GetAttribute() and GetDefaultValue() interfaces. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../Library/RedfishPlatformConfigLib.h| 44

[edk2-devel] [edk2-staging][PATCH 0/3] Add new interfaces to Redfish protocol

Introduce two new iterfaces to Redfish Platform Config Protocol: - GetAttribute() returns attribute details from HII question. - GetDefaultValue() returns default value of attribute. They are used to generate BIOS attribute registry. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor

[edk2-devel] [edk2-staging][PATCH 2/3] edk2-staging/RedfishPkg: Introduce new interfaces to Redfish protocol

Add two new iterfaces to Redfish Platform Config Protocol. GetAttribute() return attribute details and GetDefaultValue() get default value of attribute. These two interfaces are used to generate BIOS Attribute Registry Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick

[edk2-devel] [edk2-staging][PATCH 1/3] edk2-staging/RedfishPkg: Add interface to get question default value

Implement GetQuestionDefault() in HiiUtilityLib. Caller can get question default value from this interface. GetQuestionDefault() is created and modifed from SetupBrowserDxe\Setup.c under MdeModulePkg. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez ---

[edk2-devel] [edk2-staging][PATCH 0/3] Introduce resource addendum protocol

Introduce EDKII_REDFISH_RESOURCE_ADDENDUM_PROTOCOL to Redfish feature driver. Feature driver uses this protocol to query OEM resource from platform in order to support Redfish OEM property. This protocol is also used to get addendum data that is required by BMC to manage Redfish BIOS service.

[edk2-devel] [edk2-staging][PATCH 2/3] edk2-staging/RedfishClientPkg: Add Redfish Resource Addendum Library

Implement RedfishAddendumLib to support Redfish Resource Addendum Protocol. Feature driver calls this library to get addendum data before providing data to Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez ---

[edk2-devel] [edk2-staging][PATCH 3/3] edk2-staging/RedfishClientPkg: Utilize RedfishAddendumLib

Bios feature driver utilizes RedfishAddendumLib and get additional data before sending BIOS attributes to Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../Features/Bios/v1_0_9/Common/BiosCommon.c | 100 ++

[edk2-devel] [edk2-staging][PATCH 1/3] edk2-staging/RedfishClientPkg: Add Redfish Resource Addendum Protocol

Introduce Redfish Resource Addendum Protocol to Redfish feature driver. Feature driver uses this protocol to query OEM resource from platform in order to support Redfish OEM property. This protocol is also used to get addendum data that is required by BMC to manage Redfish BIOS service.

Re: [edk2-devel] [PATCH] MdeModulePkg/RegularExpressionDxe: Fix GCC build error

32-bit archs and assume all others are 64-bit. #if defined (MDE_CPU_IA32) || defined (MDE_CPU_ARM) || defined (MDE_CPU_EBC) #define SIZEOF_VOIDP 4 #else #define SIZEOF_VOIDP 8 #endif Thanks, Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Nickle > Wan

[edk2-devel] [edk2-staging][PATCH V2] edk2-staging/RedfishClientPkg: Fix typo

Fix typo in RedfishPlatformConfigImpl.c Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[edk2-devel] [PATCH V3] MdeModulePkg/RegularExpressionDxe: Fix GCC build error

Fix GCC build error on AARCH64 system. Signed-off-by: Nickle Wang Cc: Jian J Wang Cc: Liming Gao Cc: Michael D Kinney Cc: Nick Ramirez --- .../Universal/RegularExpressionDxe/OnigurumaUefiPort.h | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git

[edk2-devel] [PATCH V2] MdeModulePkg/RegularExpressionDxe: Fix GCC build error

Fix GCC build error on AARCH64 system. Signed-off-by: Nickle Wang Cc: Jian J Wang Cc: Liming Gao Cc: Nick Ramirez --- .../Universal/RegularExpressionDxe/OnigurumaUefiPort.h | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git

Re: [edk2-devel] [PATCH 1/1] RedfishPkg: Fix typos of the .inc filenames

Reviewed-by: Nickle Wang Regards, Nickle -Original Message- From: Chang, Abner Sent: Friday, December 2, 2022 7:36 AM To: Rebecca Cran ; devel@edk2.groups.io; Nickle Wang Cc: Igor Kulchytskyy Subject: RE: [PATCH 1/1] RedfishPkg: Fix typos of the .inc filenames External email: Use

Re: [edk2-devel] [PATCH 1/2] NetworkPkg/HttpDxe: provide function to disable TLS host verify

2/2023 11:06, Nickle Wang via groups.io wrote: > Thanks for catching this. To prevent the change to data structure, > would you suggest me to create new interface in EFI_HTTP_PROTOCOL and > disable TLS host verify? Adding an interface to EFI_HTTP_PROTOCOL would also break the ABI by

[edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialIpmiLib: IPMI implementation

This library follows Redfish Host Interface specification and use IPMI command to get bootstrap account credential(NetFn 2Ch, Command 02h) from BMC. RedfishHostInterfaceDxe will use this credential for the following communication between BIOS and BMC. Signed-off-by: Nickle Wang Cc: Abner Chang

Re: [edk2-devel] [PATCH 1/2] NetworkPkg/HttpDxe: provide function to disable TLS host verify

com>>; Abner Chang mailto:abner.ch...@amd.com>>; Igor Kulchytskyy mailto:ig...@ami.com>>; Nick Ramirez mailto:nrami...@nvidia.com>> Subject: Re: [edk2-devel] [PATCH 1/2] NetworkPkg/HttpDxe: provide function to disable TLS host verify External email: Use caution opening

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialIpmiLib: IPMI implementation

Hi Abner, Thanks for your review. >> + // >> + // Get bootstrap credential from variable first // Status = >> + GetBootstrapAccountCredentialsFromVariable (*UserId, *Password); if >> + (!EFI_ERROR (Status)) { >> +return EFI_SUCCESS; >> + } > I think the process should keep going if

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialIpmiLib: IPMI implementation

Hi Igor, Thank you for your review. I will incorporate your comments in version 2 patch files. Regards, Nickle -Original Message- From: Igor Kulchytskyy Sent: Saturday, March 11, 2023 2:49 AM To: Nickle Wang ; devel@edk2.groups.io Cc: Abner Chang ; Nick Ramirez Subject: RE:

Re: [edk2-devel] [PATCH 2/3] RedfishPkg: Update Redfish DSC

Reviewed-by: Nickle Wang Regards, Nickle -Original Message- From: abner.ch...@amd.com Sent: Thursday, March 9, 2023 11:41 PM To: devel@edk2.groups.io Cc: Nickle Wang ; Igor Kulchytskyy Subject: [PATCH 2/3] RedfishPkg: Update Redfish DSC External email: Use caution opening links or

  1   2   3   4   5   6   >