[edk2-devel] [PATCH v2 1/4] ArmPkg/CompilerIntrinsicsLib: Remove unused sources and clean up .inf

2019-05-13 Thread Pete Batard
None of the .c/.h in Arm/ are used any more => remove them. Also merge the CC flags for MSFT ARM and ARM64, since these are the only archs we support for this package. Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Pete Batard --- ArmPkg/Library/CompilerIntrinsicsLib/Arm/Llvm_int_li

[edk2-devel] [PATCH v2 4/4] ArmPkg/CompilerIntrinsicsLib: Add uread, uwrite GCC assembly sources

2019-05-13 Thread Pete Batard
The new sources are a copy of the RVCT version. Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Pete Batard --- ArmPkg/Library/CompilerIntrinsicsLib/Arm/uread.S | 54 ArmPkg/Library/CompilerIntrinsicsLib/Arm/uwrite.S | 53

[edk2-devel] [PATCH 1/2] RaspberryPi/RPi3: Enable RAM Disk

2019-06-07 Thread Pete Batard
Also remove UsbNetworking/Ax88772b/Ax88772b.inf references since this module is no longer present. Signed-off-by: Pete Batard --- Platform/RaspberryPi/RPi3/RPi3.dsc | 6 +- Platform/RaspberryPi/RPi3/RPi3.fdf | 6 +- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git

[edk2-devel] [PATCH 0/2] RaspberryPi/RPi3: Minor updates to platform

2019-06-07 Thread Pete Batard
The following 2 patches provide minor updates for the Raspberry Pi 3 platform, by enabling the use of the RAM Disk feature as well as the new network stack fragment file. Pete Batard (2): RaspberryPi/RPi3: Enable RAM Disk RaspberryPi/RPi3: Update DSC/FDF to use NetworkPkg DSC/FDF Platform

[edk2-devel] [PATCH 2/2] RaspberryPi/RPi3: Update DSC/FDF to use NetworkPkg DSC/FDF

2019-06-07 Thread Pete Batard
This patch updates the platform DSC/FDF files to use the include fragment files provided by NetworkPkg. Signed-off-by: Pete Batard --- Platform/RaspberryPi/RPi3/RPi3.dsc | 31 Platform/RaspberryPi/RPi3/RPi3.fdf | 11 +-- 2 files changed, 13 insertions(+), 29 deletions

[edk2-devel] [edk2-platforms: PATCH v2 1/2] RaspberryPi/RPi3: Enable RAM Disk

2019-06-07 Thread Pete Batard
Also update UsbNetworking/Ax88772b/Ax88772b.inf references. Signed-off-by: Pete Batard --- Platform/RaspberryPi/RPi3/RPi3.dsc | 7 ++- Platform/RaspberryPi/RPi3/RPi3.fdf | 7 ++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b

[edk2-devel] [edk2-platforms: PATCH v2 0/2] Minor updates to platform

2019-06-07 Thread Pete Batard
* v2 to update UsbNetworking/Ax88772b/Ax88772b.inf reference instead of removing it. The following 2 patches provide minor updates for the Raspberry Pi 3 platform, by enabling the use of the RAM Disk feature as well as the new network stack fragment file. Pete Batard (2): RaspberryPi/RPi3

[edk2-devel] [edk2-platforms: PATCH v2 2/2] RaspberryPi/RPi3: Update DSC/FDF to use NetworkPkg DSC/FDF

2019-06-07 Thread Pete Batard
This patch updates the platform DSC/FDF files to use the include fragment files provided by NetworkPkg. Signed-off-by: Pete Batard --- Platform/RaspberryPi/RPi3/RPi3.dsc | 31 Platform/RaspberryPi/RPi3/RPi3.fdf | 11 +-- 2 files changed, 13 insertions(+), 29 deletions

[edk2-devel] [edk2-non-osi: PATCH 1/1] Platform/RaspberryPi/RPi3: Update ATF binaries to v2.1

2019-06-10 Thread Pete Batard
This patch updates the ARM Trusted Firmware to the latest release using AppVeyor built binaries that provide verifiable evidence that the files have not been altered from a vanilla source compilation. Signed-off-by: Pete Batard --- Platform/RaspberryPi/RPi3/TrustedFirmware/License.txt | 2

[edk2-devel] [edk2-non-osi: PATCH 0/1] Platform/RaspberryPi/RPi3: Update ATF

2019-06-10 Thread Pete Batard
that, if you clone the script above and issue your own AppVeyor builds, you will end up with a different SHA-256. However, binary comparison can easily demonstrate that the only difference between the binaries has to do with the build date. Regards, /Pete Pete Batard (1): Platform/RaspberryPi

[edk2-devel] [PATCH v2 2/4] ArmPkg/CompilerIntrinsicsLib: Add memcmp, memmove intrinsics for MSFT

2019-05-13 Thread Pete Batard
We could have reused memmove.asm for ARM, but we would still need to add an implemention for ARM64, so we use the same source for both archs. Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Pete Batard --- ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf | 2 ++ ArmPkg

[edk2-devel] [PATCH v2 3/4] ArmPkg/CompilerIntrinsicsLib: Add lasr ARM assembly source for GCC

2019-05-13 Thread Pete Batard
The new source is a port of the RVCT version. Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Pete Batard --- ArmPkg/Library/CompilerIntrinsicsLib/Arm/lasr.S| 30 ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf | 1 + 2 files changed

Re: [edk2-devel] [PATCH v2 0/4] ArmPkg/CompilerIntrinsicsLib: Update MSFT, GCC intrinsics

2019-05-13 Thread Pete Batard
Hi Leif, On 2019.05.13 16:56, Leif Lindholm wrote: Hi Pete, On Mon, May 13, 2019 at 09:54:12AM +0100, Pete Batard wrote: This patch series cleans up and updates the CompilerIntrinsicsLib for ArmPkg. The first patch removes sources that are no longer used and cleans up the .inf. The second

[edk2-devel] [PATCH 1/1] ArmPkg/CompilerIntrinsicsLib: Add lasr assembly source for gcc/arm

2019-05-07 Thread Pete Batard
Biesheuvel CC: Leif Lindholm Signed-off-by: Pete Batard --- ArmPkg/Library/CompilerIntrinsicsLib/Arm/lasr.S| 22 ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf | 1 + 2 files changed, 23 insertions(+) diff --git a/ArmPkg/Library/CompilerInt

Re: [edk2-devel] tool chain tag setting for vs2017

2019-05-08 Thread Pete Batard
Hi Flynn, On 2019.05.08 09:00, " wrote: Hey guys, I may found a problem here.. I'm trying to build tianocore with visual studio 2017, the tianocore commit id is df7c81b5b219c9aee776baa466dd64c9d318dd80(Tue Apr 30 10:16:01 2019), after seting up the build environment and change

[edk2-devel] [edk2-platforms: PATCH v2 2/2] Platform/Rpi3: Add custom CPU frequency support

2019-07-04 Thread Pete Batard
Allow users to set a custom CPU frequency [100 - 1600 MHz] in 'Device Manager' -> 'Raspberry Pi Configuration'. Signed-off-by: Pete Batard --- Platform/RaspberryPi/RPi3/Drivers/ConfigDxe/ConfigDxe.c | 13 +++- Platform/RaspberryPi/RPi3/Drivers/ConfigDxe/ConfigDxe.

[edk2-devel] [edk2-platforms: PATCH v2 0/2] Platform/RPi3: Improve boot order and add custom freqs

2019-07-04 Thread Pete Batard
So I guess EFI_VARIABLE_RUNTIME_ACCESS applies to more than OS access. Regards, /Pete Pete Batard (2): Platform/RPi3: Set the boot option of UEFI Shell as non-active Platform/Rpi3: Add custom CPU frequency support Platform/RaspberryPi/RPi3/Drivers/ConfigDxe/ConfigDxe.c | 13

Re: [edk2-devel] [edk2-platforms: PATCH 2/2] Platform/Rpi3: Add custom CPU frequency support

2019-07-03 Thread Pete Batard
Hi Leif, On 2019.07.03 12:42, Leif Lindholm wrote: On Tue, Jul 02, 2019 at 05:13:41PM +0100, Pete Batard wrote: Allow users to set a custom CPU frequency [100 - 1600 MHz] in 'Device Manager' -> 'Raspberry Pi Configuration'. Signed-off-by: Pete Batard --- Platform/RaspberryPi/RPi3/Driv

[edk2-devel] [edk2-platforms: PATCH 0/2] Platform/RPi3 improve boot order and add custom freqs

2019-07-02 Thread Pete Batard
allowing to pick from a limited set of default values. Regards, /Pete Pete Batard (2): Platform/RPi3: Set the boot option of UEFI Shell as non-active Platform/Rpi3: Add custom CPU frequency support Platform/RaspberryPi/RPi3/Drivers/ConfigDxe/ConfigDxe.c | 13

[edk2-devel] [edk2-platforms: PATCH 1/1] Platforms/RPi3: Add multiple embedded Device Tree selection

2019-08-12 Thread Pete Batard
The Raspberry Pi 3 platform currently has 2 different models, each with a different Device Tree. Rather than embedding a single one, and requiring users to manually provide the other, this patch ensures that we now embed both and and serve the relevant one at runtime. Signed-off-by: Pete Batard

[edk2-devel] [edk2-platforms: PATCH 0/1] Platforms/RPi3: Add multiple embedded Device Tree selection

2019-08-12 Thread Pete Batard
seem like overkill for now (with cases that could be merged), it should make the reuse of that driver easier. We also tried to harmonize debug output if FtdDxe (avoid acronyms and provide human readable error codes). Pete Batard (1): Platforms/RPi3: Add multiple embedded Device Tree selection

Re: [edk2-devel] [edk2-platforms: PATCH 1/1] Platforms/RPi3: Add multiple embedded Device Tree selection

2019-08-15 Thread Pete Batard
Hi Leif, On 2019.08.15 13:13, Leif Lindholm wrote: On Mon, Aug 12, 2019 at 02:06:34PM +0100, Pete Batard wrote: The Raspberry Pi 3 platform currently has 2 different models, each with a different Device Tree. Rather than embedding a single one, and requiring users to manually provide the other

[edk2-devel] [edk2-platforms: PATCH v2 0/2] Platforms/RPi3: Device Tree driver improvements

2019-08-16 Thread Pete Batard
the Raspberry Pi 4 are a direct byproduct of the changes required for multiple Device Tree support, I did not feel the need to break them down into a separate patch. Pete Batard (2): Platforms/RPi3: Improve debug output in FdtDxe Platforms/RPi3: Add multiple embedded Device Tree selection Platform

[edk2-devel] [edk2-platforms: PATCH v2 2/2] Platforms/RPi3: Add multiple embedded Device Tree selection

2019-08-16 Thread Pete Batard
for the Raspberry Pi 4 in FdtDxe. Signed-off-by: Pete Batard --- Platform/RaspberryPi/RPi3/Drivers/FdtDxe/FdtDxe.c | 56 +--- Platform/RaspberryPi/RPi3/Drivers/FdtDxe/FdtDxe.inf | 5 +- Platform/RaspberryPi/RPi3/RPi3.dec | 8 ++- Platform/RaspberryPi/RPi3

[edk2-devel] [edk2-platforms: PATCH v2 1/2] Platforms/RPi3: Improve debug output in FdtDxe

2019-08-16 Thread Pete Batard
Harmonize messages, avoid acronyms and provide human readable status codes. Signed-off-by: Pete Batard --- Platform/RaspberryPi/RPi3/Drivers/FdtDxe/FdtDxe.c | 24 ++-- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/Platform/RaspberryPi/RPi3/Drivers/FdtDxe

[edk2-devel] [PATCH 1/1] ArmPlatformPkg: Add missing header files in INF file

2019-08-31 Thread Pete Batard
The header files are used but missing in INF, which causes warning message when building them. Signed-off-by: Pete Batard --- ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.inf | 1 + ArmPlatformPkg/Library/HdLcd/HdLcd.inf | 1 + ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.inf | 1

[edk2-devel] [edk2-non-osi PATCH 1/1] Platform/RaspberryPi/RPi3: Use official Device Tree binaries

2019-08-31 Thread Pete Batard
. This patch replaces the existing .dtb's with the most recent official ones and also removes the custom .dts from which previous .dtb's were produced. Signed-off-by: Pete Batard --- Platform/RaspberryPi/RPi3/DeviceTree/Readme.md|6 + Platform/RaspberryPi/RPi3/DeviceTree/bcm2710-rpi-3-b

[edk2-devel] [edk2-platforms PATCH 1/1] Platform/RPi3: Add missing header files in INF file

2019-08-31 Thread Pete Batard
The header files are used but missing in INF, which causes warning message when building them. Signed-off-by: Pete Batard --- Platform/RaspberryPi/RPi3/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.inf | 1 + Platform/RaspberryPi/RPi3/Drivers/ConfigDxe/ConfigDxe.inf

Re: [edk2-devel] [edk2-platforms: PATCH v2 1/1] Platform/Rpi3: Add compatible property to the "usb" Device Tree node

2019-08-29 Thread Pete Batard
Hi Leif, On 2019.08.29 14:54, Leif Lindholm wrote: On Fri, Aug 23, 2019 at 01:20:50PM +0100, Pete Batard wrote: Some Linux kernels (e.g. Debian) require "bcm,bcm2835-usb" to be present in Is the typo here or in the code? ('bcm,' vs. 'brcm,') Sorry, should have been 'brcm,bcm2835-

[edk2-devel] [edk2-platforms: PATCH 0/1] Platform/Rpi3: Add compatible property to the "usb" Device Tree node

2019-08-23 Thread Pete Batard
we should be able to replace the Device Tree blobs we currently have in edk2-non-osi for the RPi3 platform (that have been manually modified to have "bcm,bcm2835-usb") with the untouched ones from the Raspberry Pi Foundation. I will therefore send a patch to that effect once these change

[edk2-devel] [edk2-platforms: PATCH 1/1] Platform/Rpi3: Add compatible property to the "usb" Device Tree node

2019-08-23 Thread Pete Batard
Some Linux kernels (e.g. Debian) require "bcm,bcm2835-usb" to be present in the list of compatible properties for the "usb" node, else they are unable to handle some USB devices. This patch ensures that the compatible property is added if not present. Signed-off-by: Pete B

[edk2-devel] [edk2-platforms: PATCH v2 1/1] Platform/Rpi3: Add compatible property to the "usb" Device Tree node

2019-08-23 Thread Pete Batard
Some Linux kernels (e.g. Debian) require "bcm,bcm2835-usb" to be present in the list of compatible properties for the "usb" node, else they are unable to handle some USB devices. This patch ensures that the compatible property is added if not present. Signed-off-by: Pete B

[edk2-devel] [edk2-platforms: PATCH v2 0/1] Platform/Rpi3: Add compatible property to the "usb" Device Tree node

2019-08-23 Thread Pete Batard
the Debian installer. Also, once this patch has been applied, we should be able to replace the Device Tree blobs we currently have in edk2-non-osi for the RPi3 platform (that have been manually modified to have "bcm,bcm2835-usb") with the untouched ones from the Raspberry Pi Foundation. I will

[edk2-devel] [edk2-platforms PATCH 2/2] Platform/RPi3: Improve the population of PlatformSmbiosDxe elements

2019-09-04 Thread Pete Batard
t;x.y" value being passed in PcdFirmwareVersionString will now be used to populate the BIOS major and minor. Additional minor improvements are also applied, such as consistent use of uppercase values. Signed-off-by: Pete Batard --- Platform/RaspberryPi/RPi3/Drivers/Platfor

[edk2-devel] [edk2-platforms PATCH 0/2] Platform/RPi3: PlatformSmbios improvements

2019-09-04 Thread Pete Batard
Physical Array Handle: 0x Partition Width: 1 Handle 0x000A, DMI type 32, 11 bytes System Boot Information Status: No errors detected Handle 0xFEFF, DMI type 127, 4 bytes End Of Table ------ Pete

[edk2-devel] [edk2-platforms PATCH 1/2] Platform/RPi3: Add more query functions in RpiFirmwareDxe

2019-09-04 Thread Pete Batard
in PlatformSmbiosDxe. Also fixes a typo where "%s" was used instead of "%a" and improves RpiFirmwareGetSerial() to derive a serial from the the MAC address in case the platform returns 0 for the serial. Signed-off-by: Pete Batard --- Platform/RaspberryPi/RPi3/Drivers/RpiFirmware

Re: [edk2-devel] [PATCH v2 1/2] Add VS2019 Toolchain def

2019-09-17 Thread Pete Batard
patches look good to me now. Thanks. Reviewed-by: Pete Batard Cc: Amy Chan Cc: Bob Feng Cc: Liming Gao Signed-off-by: Ching JenX Cheng --- BaseTools/Conf/tools_def.template | 220

Re: [edk2-devel] [PATCH 1/2] Add VS2019 Toolchain def

2019-09-16 Thread Pete Batard
e tested ShellPkg as well as other custom applications recompilation with VS2019 for ARM/AARCH64 on my platform, and found no issues. If you need more details, please let me know. Regards, /Pete Thank you, Best Regards, Allen -Original Message- From: devel@edk2.groups.io [mailt

Re: [edk2-devel] [PATCH 1/2] Add VS2019 Toolchain def

2019-09-11 Thread Pete Batard
Hi Ching JenX, Please see two comments inline. On 2019.09.11 07:08, Cheng, Ching JenX wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2182 In order to support VS2019, the first thing need to do is add 2019 toolchain on tools_def.template Change-Id:

Re: [edk2-devel] [edk2-platforms: PATCH v2 1/1] Platform/RPi3: Add Debian 10 installation in Systems.md

2019-08-07 Thread Pete Batard
Hi Leif, On 2019.08.06 18:25, Leif Lindholm wrote: Minor suggestions inline: On Thu, Jul 25, 2019 at 04:22:48PM +0100, Pete Batard wrote: This documents the installation of vanilla Debian 10.0 ARM64 (netinst), which we validated for both Model B and Model B+. Also fix an erroneous reference

[edk2-devel] [edk2-platforms: PATCH v3 1/1] Platform/RPi3: Add Debian 10 installation in Systems.md

2019-08-08 Thread Pete Batard
This documents the installation of vanilla Debian 10.0 ARM64 (netinst), which we validated for both Model B and Model B+. Also fix an erroneous reference in an RPi3.fdf comment. Signed-off-by: Pete Batard --- Platform/RaspberryPi/RPi3/RPi3.fdf | 2 +- Platform/RaspberryPi/RPi3/Readme.md

[edk2-devel] [edk2-platforms: PATCH v3 0/1] Platform/RPi3: Add Debian 10 installation in Systems.md

2019-08-08 Thread Pete Batard
Changes from v2: - Use "on-CPU" rather than "ondie". - Make sure the options to force FAT16 are provided for both Windows and Linux. - Provide a maximum size for FAT16 and add a forward references to the additional notes and the `fdisk` fixup, for people who might still

Re: [edk2-devel] [edk2-platforms: PATCH 1/1] Platform/RPi3: Accept "ethernet" or "ethernet0" aliases in device tree

2019-07-23 Thread Pete Batard
Just adding a comment for one item, that isn't directly relevant to what direction we should take with this patch, but that clarifies where we got our .dtb's from. On 2019.07.23 12:00, Michael Brown wrote: On 23/07/2019 11:34, Leif Lindholm wrote: On Fri, Jul 19, 2019 at 06:29:07PM +0100,

Re: [edk2-devel] [edk2-platforms: PATCH 0/3] Platform/RPi3: Improve timeout handling in DwUsbHostDxe

2019-07-19 Thread Pete Batard
Hi Leif, On 2019.07.19 12:53, Leif Lindholm wrote: Hi Pete, On Wed, Jul 17, 2019 at 12:46:42PM +0100, Pete Batard wrote: Networking applications (e.g. iPXE) might experience failures when submitting a bulk IN for the NIC's RX endpoint, because the bulk IN (correctly) times out when

[edk2-devel] [edk2-platforms: PATCH 1/3] Platform/RPi3: Use Wait4Bit return value consistently

2019-07-17 Thread Pete Batard
Brown Signed-off-by: Pete Batard --- Platform/RaspberryPi/RPi3/Drivers/DwUsbHostDxe/DwUsbHostDxe.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/Platform/RaspberryPi/RPi3/Drivers/DwUsbHostDxe/DwUsbHostDxe.c b/Platform/RaspberryPi/RPi3/Drivers/DwUsbHostDxe

[edk2-devel] [edk2-platforms: PATCH 3/3] Platform/RPi3: Reduce debug noise when using a USB network device

2019-07-17 Thread Pete Batard
sole call site and restricted to the situation in which the subsequent attempt to gracefully disable the channel did actually fail. Signed-off-by: Michael Brown Signed-off-by: Pete Batard --- Platform/RaspberryPi/RPi3/Drivers/DwUsbHostDxe/DwUsbHostDxe.c | 5 + 1 file changed, 1 insertion(

[edk2-devel] [edk2-platforms: PATCH 0/3] Platform/RPi3: Improve timeout handling in DwUsbHostDxe

2019-07-17 Thread Pete Batard
Networking applications (e.g. iPXE) might experience failures when submitting a bulk IN for the NIC's RX endpoint, because the bulk IN (correctly) times out when no received packet is waiting, but DwUsbHostDxe.c treats this as a fatal error. With these patches, iPXE is able to successfully

[edk2-devel] [edk2-platforms: PATCH 2/3] Platform/RPi3: Gracefully disable USB channel after a timeout

2019-07-17 Thread Pete Batard
From: Michael Brown When a timeout occurs, attempt to gracefully disable the channel. Report a final status of EFI_TIMEOUT if the channel was disabled successfully, or EFI_DEVICE_ERROR if we were unable to disable the channel. Signed-off-by: Michael Brown Signed-off-by: Pete Batard

[edk2-devel] [edk2-platforms: PATCH 1/1] Platform/RPi3: Add Debian 10 installation in Systems.md

2019-07-25 Thread Pete Batard
This documents the installation of vanilla Debian 10.0 ARM64 (netinst), which we validated for both Model B and Model B+. Also fix an erroneous reference in an RPi3.fdf comment. Signed-off-by: Pete Batard --- Platform/RaspberryPi/RPi3/RPi3.fdf | 2 +- Platform/RaspberryPi/RPi3/Readme.md

[edk2-devel] [edk2-platforms: PATCH v2 0/1] Platform/RPi3: Add Debian 10 installation in Systems.md

2019-07-25 Thread Pete Batard
Sending a v2 that fixes a few typos: "In that is the case" -> "If that is the case" "that you can safely ignore it by selecting" -> "that you can safely ignore by selecting" "prevents the same partition to be remounted" -> "pr

[edk2-devel] [edk2-platforms: PATCH v2 1/1] Platform/RPi3: Add Debian 10 installation in Systems.md

2019-07-25 Thread Pete Batard
This documents the installation of vanilla Debian 10.0 ARM64 (netinst), which we validated for both Model B and Model B+. Also fix an erroneous reference in an RPi3.fdf comment. Signed-off-by: Pete Batard --- Platform/RaspberryPi/RPi3/RPi3.fdf | 2 +- Platform/RaspberryPi/RPi3/Readme.md

Re: [edk2-devel] [edk2-platforms PATCH 1/1] Platforms/RPi3: DisplayDxe virtual resolution improvements

2019-09-27 Thread Pete Batard
Pete, On 9/27/19 11:20 AM, Pete Batard wrote: From: Andrei Warkentin The Pi GPU decouples requested resolution from actual physical resolution and can perform scaling of virtual resolutions. This enables platform users to do something like ask for 1024x768 and get a framebuffer of that size

Re: [edk2-devel] [edk2-platforms PATCH 1/1] Platforms/RPi3: DisplayDxe virtual resolution improvements

2019-09-27 Thread Pete Batard
Hi Philippe, On 2019.09.27 17:38, Philippe Mathieu-Daudé wrote: Hi Pete, On 9/27/19 11:20 AM, Pete Batard wrote: From: Andrei Warkentin The Pi GPU decouples requested resolution from actual physical resolution and can perform scaling of virtual resolutions. This enables platform users to do

[edk2-devel] [edk2-platforms PATCH 1/1] Platforms/RPi3: DisplayDxe virtual resolution improvements

2019-09-27 Thread Pete Batard
creen to be used at 800x600 resolution, instead of forcing 640x480 as the only usable resolution. Signed-off-by: Pete Batard --- Platform/RaspberryPi/RPi3/Drivers/ConfigDxe/ConfigDxe.c | 9 +-- Platform/RaspberryPi/RPi3/Drivers/ConfigDxe/ConfigDxe.inf| 2 +- Platform/RaspberryPi/RPi3/Dr

Re: [edk2-devel] [edk2-platforms PATCH 1/1] Platforms/RPi3: DisplayDxe virtual resolution improvements

2019-09-30 Thread Pete Batard
Hi Leif, On 2019.09.29 00:05, Leif Lindholm wrote: On Fri, Sep 27, 2019 at 10:20:15AM +0100, Pete Batard wrote: From: Andrei Warkentin The Pi GPU decouples requested resolution from actual physical resolution and can perform scaling of virtual resolutions. This enables platform users to do

[edk2-devel] [edk2-platforms][PATCH 1/1] Platform/RPi: Prevent buffer over-read when the command line is empty

2019-11-04 Thread Pete Batard
From: Andrei Warkentin It is possible for the command line to be empty (Cmd->TagHead.TagValueSize = 0), in which case the code should not attempt to read the value at CommandLine[-1]. Signed-off-by: Pete Batard --- Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 3 ++- 1 f

[edk2-devel] [edk2-non-osi][PATCH 1/1] Platforms/RPi: Fix logo black level

2019-11-04 Thread Pete Batard
The existing logo bmp had its black level set to 7 instead of 0, which produces a poor image quality on some LCDs. This patch fixes that. Signed-off-by: Pete Batard --- Platform/RaspberryPi/Drivers/LogoDxe/Logo.bmp | Bin 185398 -> 185398 bytes 1 file changed, 0 insertions(+), 0 deleti

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platform/RPi: Prevent buffer over-read when the command line is empty

2019-11-07 Thread Pete Batard
t arguments" work for you? Or if you prefer "(external) boot parameters" should be applicable too. Regards, /Pete / Leif On Mon, Nov 04, 2019 at 04:06:17PM +, Pete Batard wrote: From: Andrei Warkentin It is possible for the command line to be empty (Cmd->TagHea

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platform/RPi: Prevent buffer over-read when the command line is empty

2019-11-07 Thread Pete Batard
On 2019.11.07 17:27, Leif Lindholm wrote: On Thu, Nov 07, 2019 at 05:05:20PM +, Pete Batard wrote: Hi Leif, On 2019.11.07 16:21, Leif Lindholm wrote: Patch looks good, but the term "command line" is a bit confusing. I assume we're talking about whatever way parameters are passe

[edk2-devel] [edk2-platforms][PATCH 6/8] Platform/RPi: Replace Mailbox and Watchdog addresses with PCDs

2019-11-14 Thread Pete Batard
From: Samer El-Haj-Mahmoud Set BCM2836_WDOG_BASE_ADDRESS and BCM2836_MBOX_BASE_ADDRESS to using PCDs instead of hard-coded addresses. This is needed in preparation for adding Raspberry Pi 4 support. Signed-off-by: Pete Batard --- Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.inf

[edk2-devel] [edk2-platforms][PATCH 5/8] Platform/RPi: Clean up and improve early memory init

2019-11-14 Thread Pete Batard
also fix SoC register space that should have been marked as reserved but wasn't until now and remove the unreferenced mSystemMemoryEnd extern in MemoryInitPeiLib.c. Signed-off-by: Pete Batard --- Platform/RaspberryPi/Include/Library/RPiMem.h | 26 +++ Platform/RaspberryPi

[edk2-devel] [edk2-platforms][PATCH 4/8] Platform/RPi: Read more variables from VideoCore during early init

2019-11-14 Thread Pete Batard
unused variables such as mGPUMemoryBase and mGPUMemoryLength. Signed-off-by: Pete Batard --- Platform/RaspberryPi/Include/IndustryStandard/RpiMbox.h | 1 + Platform/RaspberryPi/Library/PlatformLib/AArch64/RaspberryPiHelper.S | 75 ++-- Platform/RaspberryPi/Library

[edk2-devel] [edk2-platforms][PATCH 7/8] Platform/RPi: Replace MMCHS1BASE define with a PCD

2019-11-14 Thread Pete Batard
From: Samer El-Haj-Mahmoud Replace MMCHS1BASE with PcdMmcHs1BaseAddress. This is needed in preparation for adding Raspberry Pi 4 support Signed-off-by: Pete Batard --- Platform/RaspberryPi/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.inf | 1 + Platform/RaspberryPi/RPi3/RPi3.dsc

[edk2-devel] [edk2-platforms][PATCH 8/8] Platform/RPi: Replace DW2_USB_BASE_ADDRESS define with a PCD

2019-11-14 Thread Pete Batard
From: Samer El-Haj-Mahmoud Replace DW2_USB_BASE_ADDRESS with PcdDw2UsbBaseAddress. This is needed in preparation for adding Raspberry Pi 4 support. Signed-off-by: Pete Batard --- Platform/RaspberryPi/Drivers/DwUsbHostDxe/DwUsbHostDxe.inf | 1 + Platform/RaspberryPi/Drivers/DwUsbHostDxe

[edk2-devel] [edk2-platforms][PATCH 0/8] Platform/RPi: Early Raspberry Pi 4 groundwork

2019-11-14 Thread Pete Batard
support for the new Bcm2711 SoC in Silicon. Some cleanup of the memory init is also applied to make that part more generic as well as improve long term maintainability. Regards, /Pete Pete Batard (3): Silicon/Broadcom: Add Bcm2711 header Platform/RPi: Read more variables from VideoCore

[edk2-devel] [edk2-platforms][PATCH 1/8] Platform/RPi: Add model family detection

2019-11-14 Thread Pete Batard
for the Pi 4 and should also be easier to maintain than if using individual model detection. Also add a missing entry for the "Raspberry Pi Compute Module 3+" in RpiFirmwareGetModelName (). Signed-off-by: Pete Batard --- Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmware

[edk2-devel] [edk2-platforms][PATCH 2/8] Platform/RPi: Replace Bcm283x SoC base register address with a PCD

2019-11-14 Thread Pete Batard
From: Samer El-Haj-Mahmoud Define BCM2836_SOC_REGISTERS from PcdBcm283xRegistersAddress. This is needed in preparation for adding Raspberry Pi 4 support, since the two Pi's have a different base addresses for the Bcm283x specific registers. Signed-off-by: Pete Batard --- Platform/RaspberryPi

[edk2-devel] [edk2-platforms][PATCH 3/8] Silicon/Broadcom: Add Bcm2711 header

2019-11-14 Thread Pete Batard
for the new registers for now (set from a PCD as is the case for Bcm283x) but which should get populated further as we add support for the Raspberry Pi 4. Signed-off-by: Pete Batard --- Silicon/Broadcom/Bcm27xx/Bcm27xx.dec| 22 Silicon/Broadcom/Bcm27xx

Re: [edk2-devel] [edk2-platforms][PATCH 1/8] Platform/RPi: Add model family detection

2019-11-14 Thread Pete Batard
Hi Michael, On 2019.11.14 16:36, Michael Brown wrote: On 14/11/2019 16:07, Pete Batard wrote: +typedef +EFI_STATUS +(EFIAPI *GET_MODEL_FAMILY) ( +  UINT32 *ModelFamily +  ); +   typedef   EFI_STATUS   (EFIAPI *GET_FIRMWARE_REVISION) ( @@ -143,6 +150,7 @@ typedef struct {     GET_MODEL

Re: [edk2-devel] [edk2-platforms][PATCH 6/8] Platform/RPi: Replace Mailbox and Watchdog addresses with PCDs

2019-11-18 Thread Pete Batard
Hi Philippe, On 2019.11.18 11:13, Philippe Mathieu-Daudé wrote: Hi Pete, Samer, On 11/14/19 5:07 PM, Pete Batard wrote: From: Samer El-Haj-Mahmoud Set BCM2836_WDOG_BASE_ADDRESS and BCM2836_MBOX_BASE_ADDRESS to using PCDs instead of hard-coded addresses. This is needed in preparation

Re: [edk2-devel] [edk2-platforms][PATCH 5/8] Platform/RPi: Clean up and improve early memory init

2019-11-18 Thread Pete Batard
Hi Leif, On 2019.11.18 17:20, Leif Lindholm wrote: On Thu, Nov 14, 2019 at 04:07:37PM +, Pete Batard wrote: This patch improves memory initialization for the Raspberry Pi Platform by: Using VideoCore mailbox data to reserve only the regions that are actually mapped. Especially, besides

Re: [edk2-devel] [edk2-platforms][PATCH 5/8] Platform/RPi: Clean up and improve early memory init

2019-11-18 Thread Pete Batard
On 2019.11.18 17:38, Leif Lindholm wrote: On Mon, Nov 18, 2019 at 05:34:25PM +, Pete Batard wrote: Hi Leif, On 2019.11.18 17:20, Leif Lindholm wrote: On Thu, Nov 14, 2019 at 04:07:37PM +, Pete Batard wrote: This patch improves memory initialization for the Raspberry Pi Platform

Re: [edk2-devel] [edk2-platforms][PATCH 1/8] Platform/RPi: Add model family detection

2019-11-18 Thread Pete Batard
On 2019.11.18 17:51, Leif Lindholm wrote: On Thu, Nov 14, 2019 at 04:07:33PM +, Pete Batard wrote: From: Samer El-Haj-Mahmoud Add GetModelFamily to RASPBERRY_PI_FIRMWARE_PROTOCOL. This uses the board revision to return a numeric value representing the RPi family (1=RPi, 2=RPi2, 3=RPi3

Re: [edk2-devel] [edk2-platforms][PATCH 1/8] Platform/RPi: Add model family detection

2019-11-18 Thread Pete Batard
On 2019.11.18 18:05, Leif Lindholm wrote: On Mon, Nov 18, 2019 at 05:58:05PM +, Pete Batard wrote: On 2019.11.18 17:51, Leif Lindholm wrote: On Thu, Nov 14, 2019 at 04:07:33PM +, Pete Batard wrote: From: Samer El-Haj-Mahmoud Add GetModelFamily to RASPBERRY_PI_FIRMWARE_PROTOCOL

Re: [edk2-devel] [edk2-platforms][PATCH 1/8] Platform/RPi: Add model family detection

2019-11-21 Thread Pete Batard
stly be a re-hashing of what I have already tried to point out. Therefore, with the clarification above having been made, I am planning to leave the matter at that. Regards, /Pete On 2019.11.21 09:04, Laszlo Ersek wrote: On 11/21/19 09:55, Laszlo Ersek wrote: On 11/20/19 22:50, Pete Batard w

[edk2-devel] [edk2-platforms][PATCH v2 4/4] Platform/RPi4: Build the PCIe and xHCI drivers into the firmware

2019-12-13 Thread Pete Batard
PcdDmaDeviceLimit to 3 GB - 1 in NonCoherentIoMmuDxe. Note that this patch does not provide xHCI ACPI support because the required Xhci.asl table will be provided in a later commit. Signed-off-by: Pete Batard --- Platform/RaspberryPi/RPi4/RPi4.dsc | 29 +++- Platform

[edk2-devel] [edk2-platforms][PATCH v2 3/4] Silicon/Bcm27xx: Add PCIe host bridge config library

2019-12-13 Thread Pete Batard
From: Jeremy Linton Enables the instantiation of the PCI host bridge. Signed-off-by: Pete Batard --- Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostBridgeLib.c | 193 Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib

[edk2-devel] [edk2-platforms][PATCH v2 2/4] Silicon/Bcm27xx: Add segment library to handle nonstandard ECAM

2019-12-13 Thread Pete Batard
that into the CFG_INDEX register before ECAM data can then be read/written at CFG_DATA. We also ensure that read/write accesses are serialized through the use of a lock, as some of the library calls cannot run concurrently. Signed-off-by: Pete Batard --- Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciSegmentLib

[edk2-devel] [edk2-platforms][PATCH v2 0/4] Platform/RPi4: Add PCIe and xHCI support

2019-12-13 Thread Pete Batard
Changes from v1 (https://edk2.groups.io/g/devel/message/52160 - 52164): * Ensure that read/write accesses are serialized in PciSegmentLib. * Flesh out commit messages. * Minor comments and code updates for whitespaces & capitalization. Jeremy Linton (4): Silicon/Bcm27xx: Add PCIe constants to

[edk2-devel] [edk2-platforms][PATCH v2 1/4] Silicon/Bcm27xx: Add PCIe constants to Bcm2711.h

2019-12-13 Thread Pete Batard
From: Jeremy Linton This populates all of the define's we need for PCIe accesses. Four new PCDs are also introduced for the register and MMIO platform constants. Signed-off-by: Pete Batard --- Silicon/Broadcom/Bcm27xx/Bcm27xx.dec| 4 ++ Silicon/Broadcom/Bcm27xx

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/4] Platform/RPi4: Add PCIe and xHCI support

2019-12-13 Thread Pete Batard
On 2019.12.13 17:40, Ard Biesheuvel wrote: On Fri, 13 Dec 2019 at 18:07, Pete Batard wrote: Changes from v1 (https://edk2.groups.io/g/devel/message/52160 - 52164): * Ensure that read/write accesses are serialized in PciSegmentLib. * Flesh out commit messages. * Minor comments and code

[edk2-devel] [edk2-non-osi][PATCH 1/2] Platforms/RPi4: Add Device Tree

2019-12-11 Thread Pete Batard
/raspberrypi/firmware/tree/master/boot Signed-off-by: Pete Batard --- Platform/RaspberryPi/RPi4/DeviceTree/License.txt | 340 Platform/RaspberryPi/RPi4/DeviceTree/Readme.md | 13 + Platform/RaspberryPi/RPi4/DeviceTree/bcm2711-rpi-4-b.dtb | Bin 0 -> 40697 bytes

[edk2-devel] [edk2-non-osi][PATCH 2/2] Platforms/RPi4: Add Trusted Firmware binaries

2019-12-11 Thread Pete Batard
. Signed-off-by: Pete Batard --- Platform/RaspberryPi/RPi4/TrustedFirmware/License.txt | 26 Platform/RaspberryPi/RPi4/TrustedFirmware/Readme.md | 12 + Platform/RaspberryPi/RPi4/TrustedFirmware/bl31_miniuart.bin | Bin 0 -> 41072 bytes Platf

[edk2-devel] [edk2-non-osi][PATCH 0/2] Add prerequisite binary files for RPi4 platform

2019-12-11 Thread Pete Batard
This series of patches adds the binaries we need available to introduce Raspberry Pi 4 support. Similar to the Pi 3, we must have TF-A and Device Tree binaries we can embed. Pete Batard (2): Platforms/RPi4: Add Device Tree Platforms/RPi4: Add Trusted Firmware binaries Platform/RaspberryPi

[edk2-devel] [edk2-platforms][PATCH 1/5] Platform/RPi: Fix overlap of SoC registers and RAM

2019-12-11 Thread Pete Batard
From: Ard Biesheuvel Having RAM and SoC register regions overlap is problematic for MMIO, since, at the very least, we don't want these regions to be declared as cacheable. Signed-off-by: Pete Batard --- Platform/RaspberryPi/Library/PlatformLib/RaspberryPiMem.c | 36 +--- 1

[edk2-devel] [edk2-platforms][PATCH 2/5] Platform/RPi: Don't describe MMIO regions as memory

2019-12-11 Thread Pete Batard
belong in the UEFI memory map to begin with, omit them entirely. Signed-off-by: Pete Batard --- Platform/RaspberryPi/Include/Library/RPiMem.h| 7 --- Platform/RaspberryPi/Library/MemoryInitPeiLib/MemoryInitPeiLib.c | 10 ++ Platform/RaspberryPi/Library/PlatformLib

[edk2-devel] [edk2-platforms][PATCH 0/5] Add initial Raspberry Pi 4 platform

2019-12-11 Thread Pete Batard
This series adds basic support to build the Raspberry Pi 4 platform. It requires the earlier series, that add binary files for the platform, to have been applied to edk2-non-osi. For the introduction of the platform, USB support is not yet enabled which means that user I/O has to be carried out

[edk2-devel] [edk2-platforms][PATCH 5/5] Platform/RPi4: Add base platform files

2019-12-11 Thread Pete Batard
between PL011 and miniUART for serial. Details on how to use the resulting firmware, and especially how to configure the media for boot, are provided in the Readme. Signed-off-by: Pete Batard --- Platform/RaspberryPi/RPi4/RPi4.dsc | 637 Platform/RaspberryPi/RPi4/RPi4.fdf

[edk2-devel] [edk2-platforms][PATCH 3/5] Platform/RPi4: Add initial ACPI tables

2019-12-11 Thread Pete Batard
From: Samer El-Haj-Mahmoud For this initial commit, we duplicate the RPi3 ones. Signed-off-by: Pete Batard --- Platform/RaspberryPi/RPi4/AcpiTables/AcpiTables.h | 76 +++ Platform/RaspberryPi/RPi4/AcpiTables/AcpiTables.inf | 40 ++ Platform/RaspberryPi/RPi4/AcpiTables/Csrt.aslc | 326

[edk2-devel] [edk2-platforms][PATCH 4/5] Platform/RPi4: Update ACPI tables for the new platform

2019-12-11 Thread Pete Batard
added after ACPI 5.1, we can simply use that version to keep Linux happy. Signed-off-by: Pete Batard --- Platform/RaspberryPi/RPi4/AcpiTables/AcpiTables.h | 26 - Platform/RaspberryPi/RPi4/AcpiTables/AcpiTables.inf | 12 ++- Platform/RaspberryPi/RPi4/AcpiTables/Csrt.aslc | 25

[edk2-devel] [edk2-platforms][PATCH 0/4] Platform/RPi4: Add PCIe and xHCI support

2019-12-12 Thread Pete Batard
The following patch series adds xHCI support for the Broadcom 2711 SoC used on the Raspberry Pi 4 by: * Adding the relevant constants to the Silicon header files * Adding the segment library required to handle the nonstandrd ECAM that the SoC uses. Basically, in the Bcm2711, root port is the

[edk2-devel] [edk2-platforms][PATCH 2/4] Silicon/Bcm27xx: Add segment library to handle nonstandard ECAM

2019-12-12 Thread Pete Batard
From: Jeremy Linton Signed-off-by: Pete Batard --- Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciSegmentLib/PciSegmentLib.c | 1432 Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciSegmentLib/PciSegmentLib.inf | 34 + 2 files changed, 1466 insertions(+) diff --git a/Silicon

[edk2-devel] [edk2-platforms][PATCH 1/4] Silicon/Bcm27xx: Add PCIe constants to Bcm2711.h

2019-12-12 Thread Pete Batard
From: Jeremy Linton Signed-off-by: Pete Batard --- Silicon/Broadcom/Bcm27xx/Bcm27xx.dec| 4 ++ Silicon/Broadcom/Bcm27xx/Include/IndustryStandard/Bcm2711.h | 71 2 files changed, 75 insertions(+) diff --git a/Silicon/Broadcom/Bcm27xx/Bcm27xx.dec

[edk2-devel] [edk2-platforms][PATCH 4/4] Platform/RPi4: Build the PCIe and xHCI drivers into the firmware

2019-12-12 Thread Pete Batard
PcdDmaDeviceLimit to 3 GB - 1 in NonCoherentIoMmuDxe. Note that this patch does not provide xHCI ACPI support because the required Xhci.asl table will be provided in a later commit. Signed-off-by: Pete Batard --- Platform/RaspberryPi/RPi4/RPi4.dsc | 29 +++- Platform

[edk2-devel] [edk2-platforms][PATCH 3/4] Silicon/Bcm27xx: Add PCIe host bridge config library

2019-12-12 Thread Pete Batard
From: Jeremy Linton Signed-off-by: Pete Batard --- Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostBridgeLib.c | 193 Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostBridgeLib.inf | 51 + Silicon

Re: [edk2-devel] [edk2-non-osi][PATCH 2/2] Platforms/RPi4: Add Trusted Firmware binaries

2019-12-11 Thread Pete Batard
Hi Leif, On 2019.12.11 14:14, Leif Lindholm wrote: On Wed, Dec 11, 2019 at 11:24:00 +, Pete Batard wrote: Similar to what is the case with the Raspberry Pi 3, the Raspberry Pi 4 UEFI firmware requires the provision of a Trusted Firmware binary (TF-A). The binary is built for a dtb base

[edk2-devel] [edk2-platforms][PATCH 1/1] Platform/RPi: Inhibit serial output for all runtime drivers

2019-12-11 Thread Pete Batard
altogether. Signed-off-by: Pete Batard --- Platform/RaspberryPi/RPi3/RPi3.dsc | 3 ++- Platform/RaspberryPi/RPi4/RPi4.dsc | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc index 945baa5021f8..2368b04f40a4 100644

[edk2-devel] [edk2][PATCH 1/1] MdePkg/Include: Add DCC and BCM2835 SPCR UART types

2019-12-10 Thread Pete Batard
to SerialPortConsoleRedirectionTable.h too. Note that we followed the same idiosyncrasies as DebugPort2Table for naming these new macros. Signed-off-by: Pete Batard --- MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MdePkg/Include

[edk2-devel] [edk2-platforms][PATCH v2 0/1] Platform/RPi3: Add TFTP command to UEFI Shell

2019-10-18 Thread Pete Batard
Previous version had '!ifdef $(INCLUDE_TFTP_COMMAND)' in the .fdf whereas it was supposed to be '!if $(INCLUDE_TFTP_COMMAND) == TRUE'. This v2 fixes that. Pete Batard (1): Platform/RPi3: Add TFTP command to UEFI Shell Platform/RaspberryPi/RPi3/RPi3.dsc | 8 Platform/RaspberryPi/RPi3

[edk2-devel] [edk2-platforms][PATCH v2 1/1] Platform/RPi3: Add TFTP command to UEFI Shell

2019-10-18 Thread Pete Batard
TFTP support, which is enabled by default, can be disabled by setting INCLUDE_TFTP_COMMAND to FALSE. Signed-off-by: Pete Batard --- Platform/RaspberryPi/RPi3/RPi3.dsc | 8 Platform/RaspberryPi/RPi3/RPi3.fdf | 3 +++ 2 files changed, 11 insertions(+) diff --git a/Platform/RaspberryPi

  1   2   3   4   5   >