Thanks. Pushed at c2eab535c6790b8db5e9039e3d8886980b390389.
Regards,
Jian
> -Original Message-
> From: Gao, Liming
> Sent: Friday, May 17, 2019 9:12 AM
> To: Wang, Jian J ; devel@edk2.groups.io
> Cc: Kinney, Michael D ; Ye, Ting
>
> Subject: RE: [PATCH] CryptoPkg
> Cc: Wang, Jian J ; Ye, Ting ; Ard
> Biesheuvel ; Leif Lindholm
>
> Subject: Re: [edk2-devel] [PATCH v4 0/7] CryptoPkg: Upgrade OpenSSL to 1.1.1b
>
> Hi,
>
> (+ Ard and Leif)
>
> On 05/16/19 09:54, Xiaoyu lu wrote:
> > This series is also available
Ard,
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Tuesday, May 28, 2019 2:11 PM
> To: edk2-devel-groups-io ; Gao, Liming
>
> Cc: Laszlo Ersek ; Wang, Jian J ;
> Leif Lindholm ; Kinney, Michael D
>
> Subject: Re:
ups.io
> Cc: Lu, XiaoyuX ; Wang, Jian J ;
> Ye, Ting ; Laszlo Ersek
> Subject: [edk2-devel] [PATCH v5 0/9] Crypto: Upgrade OpenSSL to 1.1.1b
>
> This series is also avaiable at:
> https://github.com/xiaoyuxlu/edk2/commits/bz_1089_upgrade_to_openssl_1_
> 1_1b_v5
>
> Cha
Reviewed-by: Jian J Wang
> -Original Message-
> From: Lu, XiaoyuX
> Sent: Monday, June 03, 2019 5:53 PM
> To: devel@edk2.groups.io
> Cc: Lu, XiaoyuX ; Wang, Jian J ;
> Ye, Ting
> Subject: [PATCH v1 1/1] CryptoPkg: Fix build problem with XCODE
>
> REF: htt
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1878
This issue is specific to VS2017 which tries to resolve symbol referenced
by a symbol not really referenced eventually.
ossl_init_load_crypto_strings
-> err_load_crypto_strings_int (not really referenced)
-> ERR_load_OSSL_STORE_strings
There's a fix for build failure.
*[edk2-devel] [PATCH] CryptoPkg/OpensslLib: fix VS2017 build failure
Regards,
Jian
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Michael D Kinney
> Sent: Wednesday, June 05, 2019 4:29 AM
> To: Gao, Liming
2019 9:52 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Ye, Ting
> Subject: [edk2-devel] Build error in CryptoPkg on FreeBSD
>
> I know it's not an officially supported platform, but a recent update
> has broken building CryptoPkg under FreeBSD. I've tried building both
> Armada80
Xiaoyu,
Two small issues below. With them fixed,
Reviewed-by: Jian J Wang
> -Original Message-
> From: Lu, XiaoyuX
> Sent: Thursday, May 30, 2019 4:24 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J
> Subject: [PATCH v1 1/1] CryptoPkg/BaseCryptLib: Wrap Ope
https://bugzilla.tianocore.org/show_bug.cgi?id=1617
Cc: Chao Zhang
Cc: Jiewen Yao
Cc: "Hernandez Beltran, Jorge"
Cc: Harry Han
Jian J Wang (3):
SecurityPkg: add definitions for OBB verification
SecurityPkg/FvReportPei: implement a common FV verifier and reporter
SecurityPkg: add
https://bugzilla.tianocore.org/show_bug.cgi?id=1617
This driver implements a common checker, verifier and reporter which is
independent of hardware based root-of-trust.
Usually the hardware based root-of-trust will not verify all BIOS but
part of it. For example, Boot Guard will only verify IBB
https://bugzilla.tianocore.org/show_bug.cgi?id=1617
Cc: Chao Zhang
Cc: Jiewen Yao
Cc: "Hernandez Beltran, Jorge"
Cc: Harry Han
Signed-off-by: Jian J Wang
---
SecurityPkg/SecurityPkg.dsc | 5 +
1 file changed, 5 insertions(+)
diff --git a/SecurityPkg/SecurityPkg.dsc
https://bugzilla.tianocore.org/show_bug.cgi?id=1617
gEdkiiPeiFirmwareVolumeInfoStoredHashFvPpiGuid should be installed by
platform to pass FV hash information to the common FV verify/report
driver, in which the hash value will be calculated again based on the
information fed in and then verified.
Pushed at f0718d1d6b47745a4249f4006807a45f2245dba1
Regards,
Jian
> -Original Message-
> From: Lu, XiaoyuX
> Sent: Friday, May 31, 2019 4:13 PM
> To: devel@edk2.groups.io
> Cc: Lu, XiaoyuX ; Wang, Jian J
> Subject: [PATCH v2 1/1] CryptoPkg/BaseCryptLib: Wrap Ope
Reviewed-by: Jian J Wang
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Imran
> Desai
> Sent: Wednesday, May 29, 2019 4:41 AM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH v2 4/5] SecurityPkg: set SM3 bit in TPM 2.0 hash
> mask
Imran,
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Imran
> Desai
> Sent: Wednesday, May 29, 2019 4:41 AM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH v2 2/5] SecurityPkg: introduce the SM3 digest
> algorithm
>
>
> BZ:
Hi Imran,
You're using non-existing api in this patch series. The openssl upgrading
patch (BZ1089) won't provide them as well. Please wait for another patch.
Xiaoyu is working on it.
Regards,
Jian
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf
For this patch series,
Reviewed-by: Jian J Wang
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Xiaoyu Lu
> Sent: Wednesday, May 29, 2019 6:40 PM
> To: devel@edk2.groups.io
> Cc: Lu, XiaoyuX ; Wang, Jian J ;
> Ye
gt; Biesheuvel ; Wang, Jian J ;
> Ye, Ting ; Lu, XiaoyuX
> Subject: [PATCH] CryptoPkg CLANG35: add -std=c99 to dodge OpenSSL C
> atomics issue
>
> Commit c51f8bae7cabe ("CryptoPkg: Fix possible build problem with
> Clang") added -std=c99 to the compiler command lin
CryptoPkg\Library\Include\CrtLibSupport.h maps str interfaces to
edk2 PrintLib interfaces but related module inf file don't claim the
use of it. This will cause unresolved symbol issue with VS2017 build
which has enabled strict symbol check. This patch resolves the problem
by adding PrintLib
Laszlo,
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Wednesday, June 05, 2019 7:00 PM
> To: devel@edk2.groups.io; Wang, Jian J
> Cc: Bi, Dandan ; Lu, XiaoyuX
> Subject: Re: [edk2-devel] [PATCH]
11:12 PM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Laszlo Ersek
> ; Gao, Liming ; Wang, Jian J
> ; Leif Lindholm ; Kinney,
> Michael D
> Subject: [PATCH 0/3] update ArmSoftFloatLib to latest upstream version
>
> Currently, our move to OpenSSL 1.1.1b is being blocked by an iss
Jiewen,
See my comments below.
> -Original Message-
> From: Yao, Jiewen
> Sent: Friday, June 14, 2019 6:41 PM
> To: Wang, Jian J ; devel@edk2.groups.io
> Cc: Zhang, Chao B ; Hernandez Beltran, Jorge
> ; Han, Harry
> Subject: RE: [PATCH v2 0/3] Common OBB verificatio
https://bugzilla.tianocore.org/show_bug.cgi?id=1617
Cc: Chao Zhang
Cc: Jiewen Yao
Signed-off-by: Jian J Wang
---
SecurityPkg/SecurityPkg.dsc | 5 +
1 file changed, 5 insertions(+)
diff --git a/SecurityPkg/SecurityPkg.dsc b/SecurityPkg/SecurityPkg.dsc
index a2ee0528f0..4451bd1271 100644
> v3: update per Jiewen's comments
> - remove HASHED_FV_MAX_NUMBER
> - update _EDKII_PEI_FIRMWARE_VOLUME_INFO_STORED_HASH_FV_PPI to
> be more flexible
> - update HASHED_FV_INFO to use UINT64 for Base and Length
https://bugzilla.tianocore.org/show_bug.cgi?id=1617
>V3: update per Jiewen's comments
>V2: fix parameter description error found by ECC
https://bugzilla.tianocore.org/show_bug.cgi?id=1617
Cc: Chao Zhang
Cc: Jiewen Yao
Cc: "Hernandez Beltran, Jorge"
Cc: Harry Han
Jian J Wang (3):
SecurityPkg: add definitions for OBB verification
>v3:
> - shrink mHashAlgInfo and add FindHashAlgInfo() to find matched algorithm
> - add ASSERT for illegal use cases
> - add DEBUG print for skipped FV
> - update code to use new definition of HASHED_FV_INFO and
>_EDKII_PEI_FIRMWARE_VOLUME_INFO_STORED_HASH_FV_PPI
> - some small code
Laszlo,
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Tuesday, June 25, 2019 3:54 AM
> To: Wang, Jian J ; devel@edk2.groups.io;
> dw...@infradead.org; Lu, XiaoyuX
> Cc: Ye, Ting ; Richard Levitte
Reviewed-by: Jian J Wang
> -Original Message-
> From: Gao, Zhichao
> Sent: Monday, June 17, 2019 3:54 PM
> To: Ni, Ray ; devel@edk2.groups.io; Yao, Jiewen
> ; Zhang, Shenglei
> Cc: Bret Barkelew ; Zhang, Chao B
> ; Wang, Jian J ; Gao, Liming
> ; Sean Brogan ;
019 10:40 AM
> To: devel@edk2.groups.io
> Cc: Bret Barkelew ; Wang, Jian J
> ; Ye, Ting ; Gao, Liming
> ; Sean Brogan ; Michael
> Turner
> Subject: [edk2-devel] [PATCH] CryptoPkg: Add lacking instances for build only
>
> From: Bret Barkelew
>
> REF: https://bugzilla.t
Forgot to mention test:
1. Unit test and security test based on HBFA test framework
2. System test on three real platforms
Regards,
Jian
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Wang,
> Jian J
> Sent: Friday, June 14,
ca Cran
>
> Cc: Wang, Jian J
> Subject: Re: [edk2-devel] [PATCH 1/1] CryptoPkg/OpensslLib: disable autoload-
> config for OpenSSL
>
> Hi,
>
> On 06/19/19 09:22, Xiaoyu Lu wrote:
> > This problem was found by Rebecca Cran .
> > REF: https://edk2.groups.io/g/deve
Reviewed-by: Jian J Wang
> -Original Message-
> From: Lu, XiaoyuX
> Sent: Wednesday, June 19, 2019 3:21 PM
> To: devel@edk2.groups.io
> Cc: Lu, XiaoyuX ; Wang, Jian J
> Subject: [PATCH 1/1] CryptoPkg/OpensslLib: Fix CR/LF issue
>
> Re-run process_files.py to ge
Reviewed-by: Jian J Wang
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Xiaoyu Lu
> Sent: Wednesday, June 19, 2019 3:19 PM
> To: devel@edk2.groups.io
> Cc: Lu, XiaoyuX ; Laszlo Ersek ;
> Wang, Jian J ; Ye, Ting
&
>V4: change FV_HASH_FLAG_BOOT_MODE definition
>V3: update per Jiewen's comments
>V2: fix parameter description error found by ECC
https://bugzilla.tianocore.org/show_bug.cgi?id=1617
Cc: Chao Zhang
Cc: Jiewen Yao
Cc: "Hernandez Beltran, Jorge"
Cc: Harry Han
Jian J Wang (3):
SecurityPkg:
>v3:
> - shrink mHashAlgInfo and add FindHashAlgInfo() to find matched algorithm
> - add ASSERT for illegal use cases
> - add DEBUG print for skipped FV
> - update code to use new definition of HASHED_FV_INFO and
>_EDKII_PEI_FIRMWARE_VOLUME_INFO_STORED_HASH_FV_PPI
> - some small code
https://bugzilla.tianocore.org/show_bug.cgi?id=1617
Cc: Chao Zhang
Cc: Jiewen Yao
Cc: "Hernandez Beltran, Jorge"
Cc: Harry Han
Signed-off-by: Jian J Wang
---
SecurityPkg/SecurityPkg.dsc | 5 +
1 file changed, 5 insertions(+)
diff --git a/SecurityPkg/SecurityPkg.dsc
> v4: change FV_HASH_FLAG_BOOT_MODE to align with
> HASHED_FV_FLAG_SKIP_BOOT_MODE
> v3: update per Jiewen's comments
> - remove HASHED_FV_MAX_NUMBER
> - update _EDKII_PEI_FIRMWARE_VOLUME_INFO_STORED_HASH_FV_PPI to
> be more flexible
> - update HASHED_FV_INFO to use UINT64 for Base
Hi David,
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of David
> Woodhouse
> Sent: Friday, June 21, 2019 6:34 AM
> To: devel@edk2.groups.io; ler...@redhat.com; Lu, XiaoyuX
>
> Cc: Wang, Jian J ; Ye, Ting ;
> Richar
Pushed at 90e8f13d51278791e9534fc736a5319f9b4f9f0a
Regards,
Jian
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Wang,
> Jian J
> Sent: Thursday, June 20, 2019 8:35 AM
> To: Lu, XiaoyuX ; devel@edk2.groups.io
> Subjec
Pushed at b86fbe1f980102eee3e55eed92ac91937aee638e
Regards,
Jian
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Xiaoyu Lu
> Sent: Thursday, June 20, 2019 1:55 PM
> To: devel@edk2.groups.io; Laszlo Ersek ; Wang, Jian J
>
>V2: fix parameter description error found by ECC
https://bugzilla.tianocore.org/show_bug.cgi?id=1617
Cc: Chao Zhang
Cc: Jiewen Yao
Cc: "Hernandez Beltran, Jorge"
Cc: Harry Han
Jian J Wang (3):
SecurityPkg: add definitions for OBB verification
SecurityPkg/FvReportPei: implement a common
https://bugzilla.tianocore.org/show_bug.cgi?id=1617
Cc: Chao Zhang
Cc: Jiewen Yao
Signed-off-by: Jian J Wang
---
SecurityPkg/SecurityPkg.dsc | 5 +
1 file changed, 5 insertions(+)
diff --git a/SecurityPkg/SecurityPkg.dsc b/SecurityPkg/SecurityPkg.dsc
index a2ee0528f0..4451bd1271 100644
https://bugzilla.tianocore.org/show_bug.cgi?id=1617
gEdkiiPeiFirmwareVolumeInfoStoredHashFvPpiGuid should be installed by
platform to pass FV hash information to the common FV verify/report
driver, in which the hash value will be calculated again based on the
information fed in and then verified.
Laszlo,
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, May 09, 2019 10:02 PM
> To: devel@edk2.groups.io; Lu, XiaoyuX
> Cc: Wang, Jian J ; Ye, Ting
> Subject: Re: [edk2-devel] [PATCH v2 6/6] CryptoPkg/BaseCryptLib: Make
> H
Laszlo,
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Tuesday, May 14, 2019 12:46 AM
> To: devel@edk2.groups.io; Wang, Jian J
> Cc: Zeng, Star ; Dong, Eric ; Ni,
> Ray
> Subject: Re: [edk2-d
Push@ cf574f0a1838665498e43e9c029d8c1211cbbfa3
Regards,
Jian
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Wang,
> Jian J
> Sent: Tuesday, May 14, 2019 11:14 AM
> To: devel@edk2.groups.io; ler...@redhat.com
> Cc: Zeng,
Laszlo,
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Tuesday, May 14, 2019 12:15 AM
> To: devel@edk2.groups.io; Wang, Jian J ; Lu, XiaoyuX
>
> Cc: Ye, Ting
> Subject: Re: [edk2-devel] [PATCH v2 5/6] CryptoPkg: Upgrade OpenSSL to 1.
Ard,
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ard
> Biesheuvel
> Sent: Tuesday, May 21, 2019 9:39 PM
> To: Laszlo Ersek
> Cc: Wang, Jian J ; devel@edk2.groups.io; Lu, XiaoyuX
> ; Ye, Ting ; Leif Lindholm
> ; Ga
Ard,
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ard
> Biesheuvel
> Sent: Friday, May 17, 2019 11:06 PM
> To: Laszlo Ersek
> Cc: Wang, Jian J ; devel@edk2.groups.io; Lu, XiaoyuX
> ; Ye, Ting ; Leif Lindholm
> ; Ga
From: Star Zeng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1136
CVE: CVE-2018-12182
Customer met system hang-up during serial port loopback test in OS.
It is a corner case happened with one CPU core doing "out dx,al" and
another CPU core(s) doing "rep outs dx,byte ptr [rsi]".
Detailed
rsek
> Sent: Friday, May 10, 2019 1:30 AM
> To: devel@edk2.groups.io; Lu, XiaoyuX
> Cc: Wang, Jian J ; Ye, Ting
> Subject: Re: [edk2-devel] [PATCH v2 5/6] CryptoPkg: Upgrade OpenSSL to 1.1.1b
>
> On 05/09/19 19:15, Laszlo Ersek wrote:
>
> > How about the following:
>
Reviewed-by: Jian J Wang
> -Original Message-
> From: Joe Richey [mailto:joeric...@google.com]
> Sent: Friday, May 10, 2019 5:37 PM
> To: devel@edk2.groups.io
> Cc: Zhang, Chao B ; Yao, Jiewen
> ; Wang, Jian J
> Subject: [PATCH v3 1/3] SecurityPkg: Remove double \
For CryptoPkg, MdeModulePkg,
Reviewed-by: Jian J Wang
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Michael D Kinney
> Sent: Thursday, April 04, 2019 7:42 AM
> To: devel@edk2.groups.io; Kinney, Michael D
> Subject: [edk2-devel] [edk2]
For SecurityPkg,
Reviewed-by: Jian J Wang
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Michael D Kinney
> Sent: Thursday, April 04, 2019 7:42 AM
> To: devel@edk2.groups.io; Kinney, Michael D
> Subject: [edk2-devel] [edk2] [PATCH V3]
ent is for discussion only. Once the
process is finalized, it will be moved to official edk2 wiki page.
https://github.com/jwang36/tianocore.github.io/wiki/Proposal-of-security-issue-process
Any opinions and suggestions are welcomed.
Regards,
Wang, Jian J
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Lin
Laszlo,
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Friday, April 12, 2019 8:52 PM
> To: Wang, Jian J
> Cc: devel@edk2.groups.io; Zimmer, Vincent ;
> Cetola, Stephano ; Gao, Liming
>
&g
.
Jian
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Tuesday, April 16, 2019 1:04 AM
> To: Wang, Jian J ; devel@edk2.groups.io
> Cc: Zimmer, Vincent ; Cetola, Stephano
> ; Gao, Liming
> Subjec
Zhichao,
Thanks for update. Reviewed-by: Jian J Wang
Jian
> -Original Message-
> From: Gao, Zhichao
> Sent: Wednesday, April 17, 2019 1:57 PM
> To: Gao, Zhichao ; Yao, Jiewen
> ; devel@edk2.groups.io
> Cc: Ye, Ting ; Michael Turner
> ; Bret Barkelew
> ; Gao,
Groups.Io
> Sent: Sunday, April 21, 2019 1:18 AM
> To: devel@edk2.groups.io; ard.biesheu...@linaro.org
> Cc: Ye, Ting ; Gang Wei ; Wang, Jian
> J
> Subject: Re: [edk2-devel] [PATCH] CryptoPkg: add issetugid declaration to fix
> openssl build on FreeBSD
>
> On 2019-
Reviewed-by: Jian J Wang
> -Original Message-
> From: Ye, Ting
> Sent: Tuesday, April 23, 2019 10:18 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Ye, Ting
> Subject: FW: [PATCH] Change package maintainer and reviewer of CryptoPkg.
>
> Fwd to new EDKII
Laszlo,
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Tuesday, April 30, 2019 2:31 AM
> To: devel@edk2.groups.io; Lu, XiaoyuX
> Cc: Wang, Jian J ; Ye, Ting
> Subject: Re: [edk2-devel] [PATCH 3/3] CryptoPkg/BaseCryptLib: updata
> HMA
M
> To: Wang, Jian J ; devel@edk2.groups.io; Lu, XiaoyuX
>
> Cc: Ye, Ting
> Subject: Re: [edk2-devel] [PATCH 3/3] CryptoPkg/BaseCryptLib: updata
> HMAC_ctx size
>
> On 04/30/19 03:16, Wang, Jian J wrote:
> > Laszlo,
> >
> >
> >> -Original Me
Ard,
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ard
> Biesheuvel
> Sent: Tuesday, May 21, 2019 5:02 PM
> To: Wang, Jian J
> Cc: devel@edk2.groups.io; Laszlo Ersek ; Lu, XiaoyuX
> ; Ye, Ting ; Leif Lindholm
> ; Ga
Hi Ard,
Any comments?
Regards,
Jian
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Wang,
> Jian J
> Sent: Monday, May 20, 2019 9:41 AM
> To: devel@edk2.groups.io; ard.biesheu...@linaro.org; Laszlo Ersek
>
> Cc: Lu, Xiao
Laszlo,
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Tuesday, May 21, 2019 8:24 PM
> To: Wang, Jian J ; devel@edk2.groups.io;
> ard.biesheu...@linaro.org
> Cc: Lu, XiaoyuX ; Ye, Ting ; Leif
>
Laszlo,
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Tuesday, May 14, 2019 6:59 PM
> To: Wang, Jian J ; devel@edk2.groups.io; Lu, XiaoyuX
>
> Cc: Ye, Ting
> Subject: Re: [edk2-devel]
Yes, please wait for v4 version of this patch series.
Regards,
Jian
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Tuesday, May 14, 2019 8:06 PM
> To: devel@edk2.groups.io; g...@suse.com
> Cc: Lu, XiaoyuX ; Wang, Jian J ;
> Ye, Ting
&g
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1805
CryptRandItc.c is only for IPF arch, which has not been supported any
more in edk2. And no module actually reference this file. This patch
just removes it from tree.
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Ting Ye
Signed-off-by: Jian J
Pushed at a7c7d21ffa9ad14b418e728a882df0a9b8815bf6
Regards,
Jian
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Wang, Jian J
> Sent: Wednesday, July 03, 2019 10:55 AM
> To: devel@edk2.groups.io; Desai, Imran
> Subjec
Hi Laszlo,
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Friday, July 05, 2019 12:05 AM
> To: edk2-devel-groups-io ; Desai, Imran
>
> Cc: Ard Biesheuvel ; Zhang, Chao B
> ; Wang, Jian J ; Yao,
&
Hi Laszlo,
Very sorry for the mistake. I'm totally responsible for it.
Regards,
Jian
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, July 04, 2019 4:38 AM
> To: Desai, Imran ; Wang, Jian J
>
> Cc: devel@edk2.groups.io; Justen
Reviewed-by: Jian J Wang
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zhang, Chao B
> Sent: Friday, July 05, 2019 12:46 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J
> Subject: [edk2-devel] [Patch] Maintainers.tx
UND;
+ }
Regards,
Jian
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Wang,
> Jian J
> Sent: Wednesday, June 26, 2019 1:34 PM
> To: Yao, Jiewen ; devel@edk2.groups.io
> Cc: Zhang, Chao B ; Hernandez Beltran, Jorge
> ; Han, Harry
>
Laszlo,
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Wednesday, June 26, 2019 8:46 PM
> To: devel@edk2.groups.io; Wang, Jian J ;
> dw...@infradead.org; Lu, XiaoyuX
> Cc: Ye, Ting ; Richard L
Reviewed-by: Jian J Wang
> -Original Message-
> From: Zhang, Shenglei
> Sent: Thursday, June 20, 2019 9:31 AM
> To: devel@edk2.groups.io
> Cc: Zhang, Chao B ; Yao, Jiewen
> ; Wang, Jian J
> Subject: [PATCH] SecurityPkg/DxeDeferImageLoadLib: Remove
> DxeDeferImage
Zhichao,
Understood now. Thanks for the information.
Regards,
Jian
> -Original Message-
> From: Gao, Zhichao
> Sent: Thursday, July 11, 2019 8:21 AM
> To: Wang, Jian J ; devel@edk2.groups.io
> Cc: Sean Brogan ; Wu, Hao A
> ; Ni, Ray ; Zeng, Star
> ; Gao, Limi
Mike,
> -Original Message-
> From: Kinney, Michael D
> Sent: Thursday, July 11, 2019 1:28 AM
> To: Leif Lindholm ; Kinney, Michael D
>
> Cc: Wang, Jian J ; devel@edk2.groups.io; Gao,
> Liming
> Subject: RE: [ PATCH v2 1/2] Readme.md: add submodule pol
Liming,
> -Original Message-
> From: Gao, Liming
> Sent: Wednesday, July 10, 2019 3:44 PM
> To: devel@edk2.groups.io; Wang, Jian J
> Cc: Leif Lindholm ; Kinney, Michael D
>
> Subject: RE: [edk2-devel] [ PATCH v2 1/2] Readme.md: add submodule
> policy and
Hi Zhichao,
One common comment: please update copy right year.
See another comment at the almost the end of the email.
> -Original Message-
> From: Gao, Zhichao
> Sent: Tuesday, July 09, 2019 4:40 PM
> To: devel@edk2.groups.io
> Cc: Sean Brogan ; Wang, Jian J
> ; W
Leif,
I'll try push first (not sure I have write access right). If I can't, please do
it
for me.
Regards,
Jian
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Leif Lindholm
> Sent: Tuesday, July 09, 2019 5:28 PM
> To: Wan
https://bugzilla.tianocore.org/show_bug.cgi?id=1910
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Liming Gao
Jian J Wang (2):
Readme.md: add submodule policy and clone commands
CryptoPkg/OpensslLib: remove clone commands
.../Library/OpensslLib/OpenSSL-HOWTO.txt | 18 ++
https://bugzilla.tianocore.org/show_bug.cgi?id=1910
A section 'Submodules' is added to clarify the submodule policy
in edk2 repo. Git commands are also added to show the correct
way to clone submodule repos, in which '--recursive' is removed
because it's not needed but recommended in other
https://bugzilla.tianocore.org/show_bug.cgi?id=1910
edk2/Readme.md has added a section to explain the correct clone
commands for submodules. Detailed steps in the OpenSSL-HOWTO.txt
are removed to avoid any inconsistency.
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by:
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1910
'--recursive' in cloning edk2 repo might cause failure on machine
behind proxy. It's not actually necessary for edk2. This patch removed
it from git command. A separate command
$ git submodule update --init
is added to retrieve repo
Hi Imran,
Usually we send the whole series of patches even only one of them is updated.
It's
hard to find old ones. I'm not going to ask you to re-send whole patch series
this time.
But please follow the convention for any future patches.
For this patch series,
Reviewed-by: Jian J Wang
>
Thanks Jiewen. I'll add it with a few code style corrections.
Anyone else has any comments?
Regards,
Jian
> -Original Message-
> From: Yao, Jiewen
> Sent: Tuesday, June 25, 2019 10:09 PM
> To: Wang, Jian J ; devel@edk2.groups.io
> Cc: Zhang, Chao B ; Hernandez Beltran
Thanks, Chao. You're right your way is better. I'll update it.
Regards,
Jian
From: Zhang, Chao B
Sent: Wednesday, June 26, 2019 3:29 PM
To: Wang, Jian J ; Yao, Jiewen ;
devel@edk2.groups.io
Cc: Hernandez Beltran, Jorge ; Han, Harry
Subject: RE: [PATCH v4 0/3] Common OBB verification feature
Reviewed-by: Jian J Wang
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zhang, Shenglei
> Sent: Monday, July 01, 2019 10:33 AM
> To: devel@edk2.groups.io
> Cc: Zhang, Chao B ; Yao, Jiewen
> ; Wang, Jian J
> Subj
Reviewed-by: Jian J Wang
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Michael D Kinney
> Sent: Saturday, June 29, 2019 4:19 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Wu, Hao A
> ; Ni, Ray ; Zeng,
https://bugzilla.tianocore.org/show_bug.cgi?id=1910
edk2/Readme.md has added a section to explain the correct clone
commands for submodules. Detailed steps in the OpenSSL-HOWTO.txt
are removed to avoid any inconsistency.
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by:
>v3 change
> [1/2] a. change wording about submodule per Liming's comment.
>b. add more steps to do submodule update per Mike's comment.
>c. add commands for update of submodule
> [2/2] no changes.
https://bugzilla.tianocore.org/show_bug.cgi?id=1910
Cc: Leif Lindholm
Cc:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1910
A section 'Submodules' is added to clarify the submodule policy
in edk2 repo. Git commands are also added to show the correct
way to clone submodule repos, in which '--recursive' is removed
because it's not needed but recommended in other
Sorry for the late update for this patch series. Please find v2 review at
https://edk2.groups.io/g/devel/topic/32413655#43457
Regards,
Jian
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Wang, Jian J
> Sent: Wednesday, August 1
Reviewed-by: Jian J Wang
> -Original Message-
> From: Gao, Zhichao
> Sent: Tuesday, July 30, 2019 9:48 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Ye, Ting
> Subject: [PATCH] CryptoPkg/BaseCryptLib: Use cmp-operator for non-
> Boolean compar
Reviewed-by: Jian J Wang
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Liming Gao
> Sent: Saturday, August 10, 2019 10:10 PM
> To: devel@edk2.groups.io
> Cc: Mike Turner ; Wang, Jian J
> ; Wu, Hao A ; Bi, Danda
Pushed at 2556350d1b..5ab96088ae
Regards,
Jian
> -Original Message-
> From: Gao, Liming
> Sent: Thursday, August 15, 2019 8:33 AM
> To: Wang, Jian J ; devel@edk2.groups.io
> Cc: Leif Lindholm ; Kinney, Michael D
>
> Subject: RE: [PATCH v3 0/2] Add edk2 submo
Shenglei,
I remember the edk2 coding style allows prefix 'p' (optional) to represent a
pointer variable.
Regards,
Jian
> -Original Message-
> From: Zhang, Shenglei
> Sent: Thursday, August 15, 2019 4:49 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Ye, Ting
> S
Reviewed-by: Jian J Wang
> -Original Message-
> From: Zhang, Shenglei
> Sent: Tuesday, August 13, 2019 4:50 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Ye, Ting
> Subject: [PATCH 1/1] CryptoPkg/OpensslLib: Add missing header files in INF
> file
>
>
Pushed at 8906f076de35b222a7d62bcf6ed1a4a2498a5791
Regards,
Jian
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Wang, Jian J
> Sent: Thursday, August 15, 2019 4:59 PM
> To: Zhang, Shenglei ; devel@edk2.groups.io
> Cc: Y
1 - 100 of 484 matches
Mail list logo
