Reviewed-by: Jiaxin Wu
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Liming Gao
> Sent: Wednesday, May 15, 2019 8:02 PM
> To: devel@edk2.groups.io
> Cc: Fu, Siyuan ; Wu, Jiaxin
> Subject: [edk2-devel] [Patch
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=960
CVE: CVE-2019-14553
The new data type named "EfiTlsVerifyHost" and the
EFI_TLS_VERIFY_HOST_FLAG are supported in TLS protocol.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Wu Jiaxin
Reviewed-by: Ye Ting
dle attack.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Wu Jiaxin
Reviewed-by: Ye Ting
Reviewed-by: Long Qin
Reviewed-by: Fu Siyuan
Acked-by: Laszlo Ersek
---
MdePkg/Include/Protocol/Tls.h | 68 +--
1 file changed, 57 insertions(+), 11
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=960
CVE: CVE-2019-14553
Set the HostName by consuming TLS protocol to enable the host name
check so as to avoid the potential Man-In-The-Middle attack.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Wu Jiaxin
Reviewed
yHost" and
the EFI_TLS_VERIFY_HOST_FLAG for the TLS protocol consumer (HTTP) to
enable the host name check so as to avoid the potential
Man-In-The-Middle attack.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Wu Jiaxin
Reviewed-by: Ye Ting
Reviewed-by: Long Qin
Revie
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=960
CVE: CVE-2019-14553
In the patch, we add the new API "TlsSetVerifyHost" for the TLS
protocol to set the specified host name that need to be verified.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Wu Jiaxin
Reviewed-by: Jiaxin Wu
Thanks,
Jiaxin
> -Original Message-
> From: Rabeda, Maciej
> Sent: Wednesday, November 6, 2019 1:07 AM
> To: devel@edk2.groups.io
> Cc: Wu, Jiaxin ; Fu, Siyuan
> Subject: [PATCH v1 1/1] Maintainers.txt: Adding new NetworkPkg reviewer.
>
Reviewed-by: Jiaxin Wu
Thanks,
Jiaxin
> -Original Message-
> From: Maciej Rabeda
> Sent: Wednesday, December 11, 2019 5:54 PM
> To: devel@edk2.groups.io
> Cc: Wu, Jiaxin ; Fu, Siyuan
> Subject: [PATCH v2] Maintainers.txt: Update email address and role
>
> C
Sure, already create the new PR & push label to edk2 master.
Thanks,
Jiaxin
> -Original Message-
> From: Rabeda, Maciej
> Sent: Tuesday, December 17, 2019 6:07 AM
> To: devel@edk2.groups.io; Wu, Jiaxin
> Subject: Re: [edk2-devel] [PATCH v2] Maintainers.txt: U
on?
Please correct me if anything wrong.
Thanks,
Jiaxin
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Laszlo
> Ersek
> Sent: Wednesday, October 16, 2019 7:09 AM
> To: edk2-devel-groups-io
> Cc: Bret Barkelew ; David Woodhouse
> ; Wang, Jian J ; Wu, Jiax
Reviewed-by: Jiaxin Wu
> -Original Message-
> From: Fu, Siyuan
> Sent: Tuesday, October 29, 2019 9:41 AM
> To: devel@edk2.groups.io
> Cc: Wu, Jiaxin
> Subject: [Patch] NetworkPkg/SnpDxe: Use PcdGetBool() instead of
> FixedPcdGetBool in Snp.c
>
> This patch
k2-devel-groups-io
> Cc: David Woodhouse ; Wang, Jian J
> ; Wu, Jiaxin ; Sivaraman
> Nainar ; Lu, XiaoyuX
> Subject: [edk2-devel] [PATCH v2 0/8] support server identity validation in
> HTTPS Boot (CVE-2019-14553)
>
> Repo: https://github.com/lersek/edk2.git
> Branch:
> > Hm.
> >
> > If you're porting a whole standard C library to EDK2 then I suppose it
> > makes sense to build up all this infrastructure for it.
> >
> > But in this case when it's only the single inet_pton() function that
> > you need, perhaps it makes more sense to 'port' that one function to
>
Reviewed-by: Jiaxin Wu
> -Original Message-
> From: Zhang, Shenglei
> Sent: Thursday, November 14, 2019 7:47 PM
> To: devel@edk2.groups.io
> Cc: Zhang, Shenglei ; Wu, Jiaxin
> ; Fu, Siyuan ; Rabeda, Maciej
>
> Subject: [PATCH 2/3] NetworkPkg/NetworkPkg.
Sent: Tuesday, November 19, 2019 12:02 PM
To: Rabeda, Maciej ; devel@edk2.groups.io; Wu, Jiaxin
Subject: Re: [edk2-devel] Which is the proper edk2 package the EFI REST
Structure DXE driver should stay with?
Hi Maciej,
EFI REST Structure driver is designed as a generic and centralized driver
Reviewed-by: Jiaxin Wu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Maciej
> Rabeda
> Sent: Thursday, November 28, 2019 10:46 PM
> To: devel@edk2.groups.io
> Cc: Wu, Jiaxin ; Fu, Siyuan
> Subject: [edk2-devel] [PATCH v1 1/1] NetworkPkg:
; devel@edk2.groups.io; Wang, Jian J
> ; Wu, Jiaxin ; Bret Barkelew
>
> Subject: Re: [edk2-devel] [PATCH v1 0/4] Support HTTPS HostName
> validation feature(CVE-2019-14553)
>
> On Tue, 2019-10-01 at 01:21 +0200, Laszlo Ersek wrote:
> > On 09/29/19 08:09, Wang, Jian J wrote:
Hi Laszlo,
Thanks the comments.
Best Regards!
Jiaxin
> -Original Message-
> From: Laszlo Ersek
> Sent: Wednesday, October 9, 2019 11:55 PM
> To: devel@edk2.groups.io; Wang, Jian J ; Wu, Jiaxin
> ; David Woodhouse ; Bret
> Barkelew
> Subject: Re: [edk2-devel] [
>
> I have not tested this, but I started looking when there was a message
> on the edk2 list from someone who was reporting that it didn't work for
> IPv6 URIs, IIRC.
>
> You are using SSL_set1_host(), and I believe you're just passing in the
> bare hostname part of the URI, be it "1.2.3.4" or
here.
Thanks,
Jiaxin
> -Original Message-
> From: Laszlo Ersek
> Sent: Friday, October 11, 2019 2:04 AM
> To: David Woodhouse ; Wu, Jiaxin
> ; devel@edk2.groups.io; Wang, Jian J
> ; Bret Barkelew
> Cc: Richard Levitte
> Subject: Re: [edk2-devel] [PATCH v1 0
, December 20, 2019 12:16 PM
To: devel@edk2.groups.io; Wu, Jiaxin ; Fu, Siyuan
Cc: Madhan B. Santharam ; Arun Subramanian B
; Arun Sura Soundara Pandian
; Bhuvaneshwari M R
Subject: RE: reg: HTTPS Certificate Update
Hello Jiaxin / Siyuan:
Would you please feedback on this.
-Siva
From
help the technical review/support.
If no objection, just do that:).
Thanks,
Jiaxin
> -Original Message-
> From: Maciej Rabeda
> Sent: Saturday, December 7, 2019 12:29 AM
> To: devel@edk2.groups.io
> Cc: Wu, Jiaxin ; Fu, Siyuan
> Subject: [PATCH] Maintainers.txt: Upd
Change Jiaxin Wu from Maintainer to Reviewer.
Cc: Maciej Rabeda
Cc: Siyuan Fu
Signed-off-by: Jiaxin Wu
---
Maintainers.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index ca9da28925..00b46a4884 100644
--- a/Maintainers.txt
+++
Thanks liming, already corrected in V2.
> -Original Message-
> From: Gao, Liming
> Sent: Monday, February 17, 2020 10:27 PM
> To: devel@edk2.groups.io; ler...@redhat.com; Wu, Jiaxin
>
> Cc: Fu, Siyuan ; Maciej Rabeda
> ; Armour, Nicholas
>
> Subject:
Hi Laszlo,
Thanks the comments. I have updated the patch to v2.
BZ link is https://bugzilla.tianocore.org/show_bug.cgi?id=1610. According
comment 7, the CVE number is CVE-2019-14559 (share with BZ2031).
I guess they are produced by the same test environment. So, they are sharing
the same CVE
V2: correct the commit message & add BZ number.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1610
This patch is to check the received package length to make sure the package
has a valid length field.
Cc: Fu Siyuan
Cc: Maciej Rabeda
Signed-off-by: Wu Jiaxin
---
NetworkPkg/Ip
v3: correct the coding style.
v2: correct the commit message & add BZ number.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1610
This patch is to check the received package length to make sure the package
has a valid length field.
Cc: Fu Siyuan
Cc: Maciej Rabeda
Signed-off-by: Wu Ji
Siyuan & Maciej,
Could you give me Reviewed-by tag for this patch?
Thanks in advance.
Jiaxin
> -Original Message-
> From: Wu, Jiaxin
> Sent: Thursday, February 6, 2020 1:56 PM
> To: devel@edk2.groups.io
> Cc: Maciej Rabeda ; Fu, Siyuan
> ; Wu, Jiaxin
Sorry, please ignore this patch, I will correct the commit log later.
Thanks,
Jiaxin
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Wu,
> Jiaxin
> Sent: Monday, February 17, 2020 3:36 PM
> To: devel@edk2.groups.io
> Cc: Fu, Siyuan ; Wu, Jiaxin
>
This patch is to check the received package length to make sure the package
has a valid length field.
Cc: Fu Siyuan
Cc：Maciej Rabeda
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Wu Jiaxin
Reviewed-by: Siyuan Fu
---
NetworkPkg/Ip4Dxe/Ip4Input.c | 46
This patch is to check the received package length to make sure the package
has a valid length field.
Cc: Fu Siyuan
Cc: Maciej Rabeda
Signed-off-by: Wu Jiaxin
Reviewed-by: Siyuan Fu
---
NetworkPkg/Ip4Dxe/Ip4Input.c | 46 +++-
1 file changed, 37
PM
To: devel@edk2.groups.io; Wu, Jiaxin ; ler...@redhat.com
Cc: Madhan B. Santharam ; Arun Subramanian B
; Bhuvaneshwari M R ;
Ramesh R. ; Srini Narayana ; Sivaraman Nainar
; Fu, Siyuan
Subject: RE: reg: Host Name Validation with Wild Card Certificate
Hello Jiaxin:
Would you please provide
Reviewed-by: Jiaxin Wu
> -Original Message-
> From: Maciej Rabeda
> Sent: Thursday, April 2, 2020 5:15 PM
> To: devel@edk2.groups.io
> Cc: Wu, Jiaxin ; Fu, Siyuan ;
> Laszlo Ersek
> Subject: [PATCH v2] NetworkPkg/Ip6Dxe: Fix ASSERT logic in
> Ip6ProcessRo
Reviewed-by: Jiaxin Wu
> -Original Message-
> From: michael.kuba...@outlook.com
> Sent: Saturday, March 28, 2020 5:56 AM
> To: devel@edk2.groups.io
> Cc: Laszlo Ersek ; Fu, Siyuan ;
> Maciej Rabeda ; Wu, Jiaxin
>
> Subject: [PATCH v3 3/3] Revert "Net
Reviewed-by: Wu Jiaxin
Thanks,
Jiaxin
> -Original Message-
> From: Abner Chang
> Sent: Monday, September 28, 2020 2:30 PM
> To: devel@edk2.groups.io
> Cc: abner.ch...@hpe.com; Maciej Rabeda ;
> Wu, Jiaxin ; Fu, Siyuan ; Nickle
> Wang
> Subject: [P
Hi Laszlo,
Appreciate your feedback! Thank you very much.
Jiaxin
> -Original Message-
> From: Laszlo Ersek
> Sent: Saturday, July 25, 2020 12:02 AM
> To: Wu, Jiaxin
> Cc: devel@edk2.groups.io
> Subject: Re: [edk2-devel] [PATCH 00/16] OvmfPkg: support VCPU hotplug
>
Hi Laszlo,
Looks OVMF supports the CPU hotplug with those series patches.
Could you provide some guide how to enable the OVMF CPU hotplug verification?
Is there any general work flow introduction how it works? For example, how to
do the hot add CPU initialization (e.g. Register setting /
Reviewed-by: Jiaxin Wu
> -Original Message-
> From: Bi, Dandan
> Sent: Sunday, March 28, 2021 8:02 PM
> To: devel@edk2.groups.io
> Cc: Maciej Rabeda ; Wu, Jiaxin
> ; Fu, Siyuan
> Subject: [patch V4 16/29] NetworkPkg: Consume MdeLibs.dsc.inc for
> RegisterF
https://bugzilla.tianocore.org/show_bug.cgi?id=3284
This patch is to support Extended Control Register(XCR) Read
and Write.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Jiaxin Wu
---
MdePkg/Include/Library/BaseLib.h | 46 ++-
https://bugzilla.tianocore.org/show_bug.cgi?id=3284
This patch is to support XSETBV instruction so as to support
Extended Control Register(XCR) write.
Extended Control Register(XCR) read has already been supported
by below commit to support XGETBV instruction:
.
Thanks,
Jiaxin
> -Original Message-
> From: Wu, Jiaxin
> Sent: Wednesday, March 31, 2021 12:21 PM
> To: Yao, Jiewen ; devel@edk2.groups.io;
> gaolim...@byosoft.com.cn
> Cc: Kinney, Michael D ; Liu, Zhiguang
> ; Zhang, Hongbin1
> Subject: RE: [edk2-devel] [PATCH v1]
Hi Liming and Jiewen,
Could you help review the patch?
Thanks,
Jiaxin
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Wu,
> Jiaxin
> Sent: Wednesday, March 31, 2021 3:54 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Liming Gao
>
*v2: refine the coding format.
https://bugzilla.tianocore.org/show_bug.cgi?id=3284
This patch is to support XSETBV instruction so as to support
Extended Control Register(XCR) write.
Extended Control Register(XCR) read has already been supported
by below commit to support XGETBV instruction:
Hi liming,
Could you help push the patch since I don't have the privilege to set the push
label?
Thanks,
Jiaxin
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of
> gaoliming
> Sent: Friday, April 2, 2021 2:24 PM
> To: Wu, Jiaxin ; devel@edk2.groups.
Got it! Thanks Mike. /Jiaxin
> -Original Message-
> From: Kinney, Michael D
> Sent: Tuesday, April 6, 2021 10:11 AM
> To: Wu, Jiaxin ; devel@edk2.groups.io;
> gaolim...@byosoft.com.cn; Kinney, Michael D
> Cc: Liu, Zhiguang ; Ni, Ray ; Yao,
> Jiewen ; Zhang, Hong
No problem, thanks Mike, let's wait your feedback.
Thanks,
Jiaxin
> -Original Message-
> From: Kinney, Michael D
> Sent: Tuesday, April 6, 2021 6:47 AM
> To: Wu, Jiaxin ; devel@edk2.groups.io;
> gaolim...@byosoft.com.cn; Kinney, Michael D
> Cc: Liu, Zhiguang ; Ni, R
Thanks the comments, I will refine the patch according the feedback.
> -Original Message-
> From: Yao, Jiewen
> Sent: Wednesday, March 31, 2021 10:20 AM
> To: devel@edk2.groups.io; gaolim...@byosoft.com.cn; Wu, Jiaxin
>
> Cc: Kinney, Michael D ; Liu, Zhiguang
&
2021 9:51 AM
> To: devel@edk2.groups.io; Wu, Jiaxin
> Cc: Kinney, Michael D ; Liu, Zhiguang
> ; Zhang, Hongbin1
> Subject: 回复: [edk2-devel] [PATCH v1] MdePkg: Support Extended Control
> Register(XCR) Read and Write.
>
> Where is X64 implementation for this new API?
>
https://bugzilla.tianocore.org/show_bug.cgi?id=3284
This patch is to support Extended Control Register(XCR) Read
and Write.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Zhang Hongbin1
Signed-off-by: Jiaxin Wu
---
MdePkg/Include/Library/BaseLib.h | 46
https://bugzilla.tianocore.org/show_bug.cgi?id=3240
This patch is to support standalone MM Driver Unload capability
by providing _DriverUnloadHandler() function.
Change-Id: I26cdbfccb7052685c464d6394e472c7579b7b67e
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Siyuan Fu
Hi Liming,
We internal verified the new added unload logic, works well.
Thanks,
Jiaxin
> -Original Message-
> From: gaoliming
> Sent: Thursday, March 4, 2021 10:21 AM
> To: devel@edk2.groups.io; Wu, Jiaxin
> Cc: Kinney, Michael D ; Liu, Zhiguang
> ; Fu, Siyuan
&g
Hi Mike & Zhiguang & Liming,
Could you help review this patch?
Thanks,
Jiaxin
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Wu,
> Jiaxin
> Sent: Monday, March 1, 2021 3:44 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Liming
Reviewed-by: Wu Jiaxin
From: Anbazhagan, Baraneedharan
Sent: Thursday, November 25, 2021 9:28 AM
To: devel@edk2.groups.io
Cc: maciej.rab...@linux.intel.com; Wu, Jiaxin ; Fu, Siyuan
Subject: RE: NetworkPkg: Fix invalid pointer for DNS response token on error
Ref: https
It's good to me change the default the verify flag.
Reviewed-by: Jiaxin Wu
Thanks,
Jiaxin
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Vineel
> Kovvuri
> Sent: Friday, October 15, 2021 8:55 AM
> To: Rabeda, Maciej ; Yao, Jiewen
> ; jp...@microsoft.com;
>
Reviewed-by: Jiaxin Wu
Thanks,
Jiaxin
> -Original Message-
> From: Luo, Heng
> Sent: Tuesday, July 20, 2021 10:18 AM
> To: devel@edk2.groups.io
> Cc: Maciej Rabeda ; Wu, Jiaxin
> ; Fu, Siyuan
> Subject: [Patch V2] NetworkPkg: Add HTTP Additional Event Notifica
For the below EDKII_HTTP_CALLBACK_EVENT definition:
All event is to retrieve the event Status, so the comments should be made
clearly and align with code returned status, for example,
> + /// Retrieve the host address, EventStatus:
There might be the misunderstanding you want the host
Reviewed-by: Jiaxin Wu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of
> gaoliming
> Sent: Friday, January 28, 2022 5:14 PM
> To: devel@edk2.groups.io
> Cc: Maciej Rabeda ; Wu, Jiaxin
> ; Fu, Siyuan
> Subject: [edk2-devel] [PATCH 2/2] Net
There is the SmmCpuSyncLib Library class define the SMM CPU sync
flow, which is aligned with existing SMM CPU driver sync behavior.
This patch is to consume SmmCpuSyncLib instance directly.
With this change, SMM CPU Sync flow/logic can be customized
with different implementation no matter for any
After review, there are unnecessary steps for BSP and AP sync for SMM
exit. This patch is to reduce one round BSP and AP sync so as to improve
SMI performance:
BSP: WaitForAllAPs <-- AP: ReleaseBsp
BSP: ReleaseAllAPs --> AP: WaitForBsp
Change-Id: Ic33f42f3daa7ff1847e524d0c3d9cd4fcdefa61b
Cc: Eric
Intel is planning to provide different SMM CPU Sync implementation
along with some specific registers to improve the SMI performance,
hence need SmmCpuSyncLib Library for Intel.
This patch is to:
1.Adds SmmCpuSyncLib Library class in UefiCpuPkg.dec.
2.Adds SmmCpuSyncLib.h function declaration
Justen
Cc: Guo Dong
Cc: Sean Rhodes
Cc: James Lu
Cc: Gua Guo
Signed-off-by: Jiaxin Wu
Jiaxin Wu (7):
UefiCpuPkg/PiSmmCpuDxeSmm: Optimize Semaphore Sync between BSP and AP
UefiCpuPkg/PiSmmCpuDxeSmm: Reduce times of BSP and AP Sync for SMM
Exit
UefiCpuPkg: Adds SmmCpuSyncLib library
This patch is to define 3 new functions (WaitForBsp & ReleaseBsp &
ReleaseOneAp) used for the semaphore sync between BSP & AP. With the
change, BSP and AP Sync flow will be easy understand as below:
BSP: ReleaseAllAPs or ReleaseOneAp --> AP: WaitForBsp
BSP: WaitForAllAPs <-- AP:
Implements SmmCpuSyncLib Library class. The instance follows the
existing SMM CPU driver (PiSmmCpuDxeSmm) sync implementation:
1.Abstract Counter and Run semaphores into SmmCpuSyncCtx.
2.Abstract CPU arrival count operation to
SmmCpuSyncGetArrivedCpuCount(), SmmCpuSyncCheckInCpu(),
The SmmCpuSyncLib instance is included in UefiCpuLibs.dsc.inc.
This patch is to specify SmmCpuSyncLib instance in OvmfPkg by
using "!include UefiCpuPkg/UefiCpuLibs.dsc.inc".
Change-Id: I2ab1737425e26a7bfc4f564b3b7f15ca5c2268fb
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Eric Dong
The SmmCpuSyncLib instance is included in UefiCpuLibs.dsc.inc.
This patch is to specify SmmCpuSyncLib instance in UefiPayloadPkg
by using "!include UefiCpuPkg/UefiCpuLibs.dsc.inc".
Change-Id: Ib303a9cdf260ac1ffc146e5f2e68834dec00ff25
Cc: Guo Dong
Cc: Sean Rhodes
Cc: James Lu
Cc: Gua Guo
Cc:
Shadow stack will stop update after CET disable (DisableCet in
DisableReadOnlyPageWriteProtect), but normal smi stack will be
continue updated with the function return and enter
(DisableReadOnlyPageWriteProtect & EnableReadOnlyPageWriteProtect),
thus leading stack mismatch after CET re-enabled
Hi Laszlo,
Thanks the feedback.
>
> Is this somehow related to
>
> [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Clear CR4.CET before
> restoring MSR IA32_S_CET
>
> at
>
> https://edk2.groups.io/g/devel/message/110605
>
> ?
>
> I'm not familiar with control flow integrity, but both
Hi Laszlo,
Thanks comments.
>
> I have two comments:
>
>
> (1) both the pre-patch code and the post-patch code have several
> instances of the following pattern:
>
> Boolean = (Expression != 0) ? TRUE : FALSE;
>
> This is an anti-pattern. It should only be:
>
> Boolean = Expression !=
Shadow stack will stop update after CET disable (DisableCet in
DisableReadOnlyPageWriteProtect), but normal smi stack will be
continue updated with the function return and enter
(DisableReadOnlyPageWriteProtect & EnableReadOnlyPageWriteProtect),
thus leading stack mismatch after CET re-enabled
Processor extended information is filled when
CPU_V2_EXTENDED_TOPOLOGY is set in parameter ProcessorNumber
from GetProcessorInfo() (See commit: 1fadd18d).
This filed value is retrieved from CPUID leaf 1FH, which is
a preferred superset to leaf 0BH.
Since Intel recommends first use the CPUID leaf
Root cause:
1. Before DisableReadonlyPageWriteProtect() is called, the return
address (#1) is pushed in shadow stack.
2. CET is disabled.
3. DisableReadonlyPageWriteProtect() returns to #1.
4. Page table is modified.
5. EnableReadonlyPageWriteProtect() is called, but the return
address (#2) is not
Hi Ray & Laszlo,
Any more comments to this?
Thanks,
Jiaxin
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Wu,
> Jiaxin
> Sent: Tuesday, November 7, 2023 9:25 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Zeng, Star
> ; Gerd
Thanks Laszlo, much appreciate all comments. I will check one by one for fix in
next version. /Jiaxin
> -Original Message-
> From: Laszlo Ersek
> Sent: Tuesday, November 7, 2023 7:01 PM
> To: devel@edk2.groups.io; Wu, Jiaxin
> Cc: Dong, Eric ; Ni, Ray ; Zeng, Star
&g
Ersek
> Sent: Wednesday, November 8, 2023 2:57 AM
> To: devel@edk2.groups.io; Wu, Jiaxin
> Cc: Dong, Eric ; Ni, Ray ; Zeng, Star
> ; Gerd Hoffmann ; Kumar, Rahul R
>
> Subject: Re: [edk2-devel] [PATCH v4] UefiCpuPkg/PiSmmCpuDxeSmm: Fix CP
> Exception when CET enable
>
Thanks Laszlo, all fixed in version 3.
> -Original Message-
> From: Laszlo Ersek
> Sent: Sunday, November 5, 2023 7:01 PM
> To: Wu, Jiaxin ; devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Zeng, Star
> ; Gerd Hoffmann ; Kumar, Rahul R
>
> Subject: R
Shadow stack will stop update after CET disable (DisableCet in
DisableReadOnlyPageWriteProtect), but normal smi stack will be
continue updated with the function return and enter
(DisableReadOnlyPageWriteProtect & EnableReadOnlyPageWriteProtect),
thus leading stack mismatch after CET re-enabled
lure.
I will refine the commit log to include your great suggestion. Thank you very
much!
Jiaxin
From: Ni, Ray
Sent: Monday, November 6, 2023 5:41 PM
To: Wu, Jiaxin ; devel@edk2.groups.io
Cc: Dong, Eric ; Zeng, Star ; Gerd
Hoffmann ; Kumar, Rahul R ; Laszlo
Ersek
Subject: Re: [PATCH v3] Ue
After review, there are unnecessary steps for BSP and AP sync for exit.
This patch is to reduce one round BSP and AP sync for exit so as to
improve SMM performance:
WaitForAllAPs <- ReleaseBsp
ReleaseAllAPs -> WaitForBsp
Cc: Eric Dong
Cc: Ray Ni
Cc: Zeng Star
Cc: Rahul Kumar
Cc: Gerd Hoffmann
The series patches are to optimize semaphore sync between BSP
and AP:
Patch 1: Define 3 functions (WaitForBsp & ReleaseBsp & ReleaseOneAp)
specific for BSP & AP sync, which will make the flow easy to
understand.
Patch 2: Reduce one round BSP and AP sync for exit so as to
improve SMM performance
This patch is to:
1. Define 2 new functions (WaitForBsp & ReleaseBsp) used
for the semaphore sync between BSP & AP.
2. Add ReleaseOneAp(), used for BSP to release one AP.
With the change, BSP & AP Sync flow will be easy understand:
BSP to Release All APs ---> AP to Wait BSP
ReleaseAllAPs ()
+Mike for this review.
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Wu,
> Jiaxin
> Sent: Wednesday, August 9, 2023 5:04 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Zeng, Star
> ; Kumar, Rahul R ; Gerd
> Hoffmann
> Subj
Thank you, Mike, the PR (https://github.com/tianocore/edk2/pull/4867) has been
synced & updated with reviewed by tag, and we can merge once pass the CI check.
> -Original Message-
> From: Kinney, Michael D
> Sent: Friday, November 10, 2023 8:25 AM
> To: Wu, Jiaxi
nal Message-----
> From: Wu, Jiaxin
> Sent: Wednesday, November 8, 2023 9:17 AM
> To: Laszlo Ersek ; devel@edk2.groups.io; Gao, Liming
> ; Kinney, Michael D
>
> Cc: Dong, Eric ; Ni, Ray ; Zeng, Star
> ; Gerd Hoffmann ; Kumar, Rahul R
>
> Subject: RE: [edk2-devel] [PATCH
Hi Laszlo,
> >
> > The patch looks OK to me, but:
> >
> > - I would like to test it with CPU hotplug (later, likely under v2), and
> >
Sure, I can wait the update from you.
> > - I think this should be two patches.
> >
> > First, the SmmAddProcessor() function should be extended just to
> >
nal Message-
> From: Ni, Ray
> Sent: Tuesday, June 28, 2022 5:17 PM
> To: Wu, Jiaxin ; devel@edk2.groups.io
> Cc: Dong, Eric
> Subject: RE: [PATCH v1] UefiCpuPkg: Add PCD to control SMRR enable &
> SmmFeatureControl support
>
> > - //
> > - // Check CPUID
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3962
Two SMM variables (mSmrrSupported & mSmmFeatureControlSupported) are global
variables, they control whether the SMRR and SMM Feature Control MSR will
be restored respectively.
To avoid the TOCTOU, add PCD to control SMRR & SmmFeatureControl
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3962
Two SMM variables (mSmrrSupported & mSmmFeatureControlSupported) are global
variables, they control whether the SMRR and SMM Feature Control MSR will
be restored respectively.
To avoid the TOCTOU, dynamic check SMRR enable &
Drop this patch replaced by new patch set "[edk2-devel] [PATCH v1] UefiCpuPkg:
Dynamic check SMRR enable & SmmFeatureControl capability" since it's totally
different solution for fix.
> -Original Message-
> From: Wu, Jiaxin
> Sent: Wednesday, June 29, 2022 9:38 A
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3962
Two SMM variables (mSmrrSupported & mSmmFeatureControlSupported) are global
variables, they control whether the SMRR and SMM Feature Control MSR will
be restored respectively.
To avoid the TOCTOU, add PCD to control SMRR & SmmFeatureControl
Due to the SMI latency impact for IA-32 processor, I will drop this change &
replace with the PCD check. I will resend the new patch for review.
Thanks,
Jiaxin
> -Original Message-
> From: Wu, Jiaxin
> Sent: Monday, July 18, 2022 3:32 PM
> To: Kinney, Michael D ; deve
optimization case or it
must be optimized away condition checks?
Thanks,
Jiaxin
> -Original Message-
> From: Kinney, Michael D
> Sent: Monday, July 18, 2022 8:13 AM
> To: devel@edk2.groups.io; Wu, Jiaxin ; Kinney, Michael
> D
> Cc: Dong, Eric ; Ni, Ray
> Subject: RE: [
Reviewed-by: Jiaxin Wu
> -Original Message-
> From: Chao Li
> Sent: Thursday, September 8, 2022 12:48 PM
> To: devel@edk2.groups.io
> Cc: Maciej Rabeda ; Wu, Jiaxin
> ; Siyuan Fu
> Subject: [PATCH v1 05/34] NetworkPkg: Add LOONGARCH64 architecture for
> EDK2
Reviewed-by: Jiaxin Wu
> -Original Message-
> From: Chao Li
> Sent: Wednesday, September 14, 2022 5:36 PM
> To: devel@edk2.groups.io
> Cc: Maciej Rabeda ; Wu, Jiaxin
> ; Siyuan Fu
> Subject: [PATCH v2 06/34] NetworkPkg/HttpBootDxe: Add LOONGARCH64
> architectu
Reviewed-by: Jiaxin Wu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Ni, Ray
> Sent: Saturday, October 8, 2022 2:34 PM
> To: Li, Zhihao ; devel@edk2.groups.io
> Cc: Dong, Eric
> Subject: Re: [edk2-devel] [PATCH v1 1/1] UefiCpuPkg: Reset a parameter
> when BSP Exit in
Hi Zachary,
Insert all my comments as below.
Besides: where defined this protocol (EFI_WIFI_PROFILE_SYNC_PROTOCOL)? I didn't
find in the UEFI spec, in such a case, could we named it as
EDKII_WIFI_PROFILE_SYNC_PROTOCOL? please add more description about the
protocol usage.
Thanks,
Jiaxin
>
One comment as below, Others good to me.
Reviewed-by: Wu Jiaxin
> + @param[in, out] WcmProfile WiFi Connection Manager profile
> structure
> + @param[in, out] MacAddress MAC address from AMT saved to NiC
> MAC address
> +
> + @retval EFI_SUCCESS
Mainly changes as below:
1. Add Smm Base HOB, which is used to store the information of
Smm Relocated SmBase array for each Processors;
2. Combine 2 SMIs (gcSmmInitTemplate & gcSmiHandlerTemplate) into one
(gcSmiHandlerTemplate), the new SMI handler needs to run to 2 paths: one
to
Below serial patches are to support the SMM Relocated SmBase handling.
To achieve, new hob interface is procuded, and will be consumed by SMM
CPU driver & SmmCpuFeaturesLib to do SmBase initialization:
The Smm Base HOB is used to store the relocated SmBase in
array for each Processors. If
The Smm Base HOB is used to store the relocated SmBase in
array for each Processors. If gSmmBaseHobGuid produced,
indicate SmBase for each Processors have been relocated.
The SmBase address in hob can be guaranteed the SMRAM state
save areas for all processors do not overlap.
Cc: Eric Dong
Cc:
SMM CPU driver will retrieve the SMBASE addresses from SMM Base Hob
and installs the SMI handler at [SMBASE+8000h] for each processor
instead of relocating SMM Base addresses from SMRAM again.
With SMM Base Hob, SMM CPU driver does not need the RSM instruction
to reload the SMBASE register with
1 - 100 of 409 matches
Mail list logo
