Re: [edk2-devel] [PATCH v4 0/7] CryptoPkg: Upgrade OpenSSL to 1.1.1b

2019-05-17 Thread Xiaoyu Lu
lo Ersek Sent: Friday, May 17, 2019 2:26 AM To: devel@edk2.groups.io; Lu, XiaoyuX Cc: Wang, Jian J ; Ye, Ting ; Ard Biesheuvel ; Leif Lindholm Subject: Re: [edk2-devel] [PATCH v4 0/7] CryptoPkg: Upgrade OpenSSL to 1.1.1b Hi, (+ Ard and Leif) On 05/16/19 09:54, Xiaoyu lu wrote: > This ser

Re: [edk2-devel] [PATCH v4 6/7] CryptoPkg: Upgrade OpenSSL to 1.1.1b

2019-05-17 Thread Xiaoyu Lu
hat do you think? Thanks, Xiaoyu -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Friday, May 17, 2019 12:32 AM To: devel@edk2.groups.io; Lu, XiaoyuX ; Wang, Jian J Cc: Ye, Ting Subject: Re: [edk2-devel] [PATCH v4 6/7] CryptoPkg: Upgrade OpenSSL to

[edk2-devel] [PATCH v1 1/1] CryptoPkg: Fix build problem with XCODE

2019-06-03 Thread Xiaoyu Lu
Signed-off-by: Xiaoyu Lu --- CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf| 2 ++ CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 2 ++ CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf | 2 ++ CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 2 +- CryptoPkg/Library/OpensslLib

[edk2-devel] [PATCH 1/1] FmpDevicePkg: Add TimerLib to DSC file

2019-06-03 Thread Xiaoyu Lu
Signed-off-by: Xiaoyu Lu --- FmpDevicePkg/FmpDevicePkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/FmpDevicePkg/FmpDevicePkg.dsc b/FmpDevicePkg/FmpDevicePkg.dsc index 3b40bf8e9cdc..c9513135cbd2 100644 --- a/FmpDevicePkg/FmpDevicePkg.dsc +++ b/FmpDevicePkg/FmpDevicePkg.dsc @@ -49,6 +49,7

Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg/IntrinsicLib: Fix CLANG38 IA32 build problem

2019-06-05 Thread Xiaoyu Lu
d problem > > Xiaoyu: > > >-Original Message- > >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > >Xiaoyu Lu > >Sent: Wednesday, June 05, 2019 1:25 PM > >To: devel@edk2.groups.io > >Cc: Lu, XiaoyuX ; Bi, Dandan > ; > >Wang,

Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg/IntrinsicLib: Fix CLANG38 IA32 build problem

2019-06-05 Thread Xiaoyu Lu
Message- > > > > > From: Gao, Liming > > > > > Sent: Wednesday, June 5, 2019 1:57 PM > > > > > To: devel@edk2.groups.io; Lu, XiaoyuX > > > > > Cc: Bi, Dandan ; Wang, Jian J > > > > > > > > Subje

Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg/IntrinsicLib: Fix CLANG38 IA32 build problem

2019-06-05 Thread Xiaoyu Lu
i, Dandan ; Wang, Jian J > > > > Subject: RE: [edk2-devel] [PATCH v1 1/1] CryptoPkg/IntrinsicLib: Fix > > > CLANG38 IA32 build problem > > > > > > Xiaoyu: > > > > > > >-Original Message- > > > >From: devel@edk2.groups.io [mailto:deve

[edk2-devel] [PATCH v1 1/1] CryptoPkg/IntrinsicLib: Fix CLANG38 IA32 build problem

2019-06-04 Thread Xiaoyu Lu
)) to informs the compiler that symbol should be retained in the object file, even if it may be unreferenced. Cc: Jian J Wang Cc: Dandan Bi Signed-off-by: Xiaoyu Lu --- CryptoPkg/Library/IntrinsicLib/CopyMem.c | 13 + 1 file changed, 13 insertions(+) diff --git a/CryptoPkg/Library

[edk2-devel] [PATCH v2 1/1] CryptoPkg/BaseCryptLib: Wrap OpenSSL SM3 algorithm

2019-05-31 Thread Xiaoyu Lu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1861 1. Implement OpenSSL SM3 wrapped functions in CryptSm3.c file. 2. Add wrapped SM3 functions declaration to BaseCryptLib.h file. 3. Add CryptSm3.c to each module information file. Cc: Jian J Wang Signed-off-by: Xiaoyu Lu Reviewed-by: Jian

[edk2-devel] [PATCH v1 1/1] CryptoPkg/BaseCryptLib: Wrap OpenSSL SM3 algorithm

2019-05-30 Thread Xiaoyu Lu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1861 1. Implement OpenSSL SM3 wrapped functions in CryptSm3.c file. 2. Add wrapped SM3 functions declaration to BaseCryptLib.h file. 3. Add CryptSm3.c to each module information file. Cc: Jian J Wang Signed-off-by: Xiaoyu Lu --- CryptoPkg

[edk2-devel] [PATCH v5 3/9] CryptoPkg/IntrinsicLib: Fix possible unresolved external symbol issue

2019-05-29 Thread Xiaoyu Lu
symbol __ftol2 This patch add _ftol2 function for the compiler intrinsic. Cc: Jian J Wang Cc: Ting Ye Signed-off-by: Xiaoyu Lu Tested-by: Gary Lin --- CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf | 4 +++- CryptoPkg/Library/IntrinsicLib/Ia32/MathFtol.c | 22 ++ 2 files

[edk2-devel] [PATCH v5 5/9] CryptoPkg/OpensslLib: Fix cross-build problem for AARCH64

2019-05-29 Thread Xiaoyu Lu
From: Laszlo Ersek BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 Thanks Laszlo Ersek . Ref: https://edk2.groups.io/g/devel/message/40375 Cc: Jian J Wang Cc: Ting Ye Signed-off-by: Xiaoyu Lu Reviewed-by: Laszlo Ersek --- CryptoPkg/Library/Include/sys/syscall.h | 11 +++ 1

[edk2-devel] [PATCH v5 6/9] CryptoPkg: Fix possible build problem with Clang

2019-05-29 Thread Xiaoyu Lu
Cc: Jian J Wang Signed-off-by: Xiaoyu Lu --- CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf| 2 ++ CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 2 ++ CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf | 2 ++ CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 2 ++ CryptoPkg

[edk2-devel] [PATCH v5 4/9] CryptoPkg/OpensslLib: Prepare for upgrading OpenSSL

2019-05-29 Thread Xiaoyu Lu
environments by default. But this is only for OpenSSL compilation, no matter how the default options change. Cc: Jian J Wang Cc: Ting Ye Signed-off-by: Xiaoyu Lu Reviewed-by: Laszlo Ersek Tested-by: Gary Lin --- CryptoPkg/Library/OpensslLib/OpensslLib.inf | 16 ++-- CryptoPkg

[edk2-devel] [PATCH v5 0/9] Crypto: Upgrade OpenSSL to 1.1.1b

2019-05-29 Thread Xiaoyu Lu
Cc: Jian J Wang Cc: Ting Ye Cc: Laszlo Ersek Laszlo Ersek (1): CryptoPkg/OpensslLib: Fix cross-build problem for AARCH64 Xiaoyu Lu (8): CryptoPkg/OpensslLib: Modify process_files.pl for upgrading OpenSSL CryptoPkg/OpensslLib: Exclude unnecessary files in process_files.pl CryptoPkg/Intrin

[edk2-devel] [PATCH v5 8/9] CryptoPkg: Upgrade OpenSSL to 1.1.1b

2019-05-29 Thread Xiaoyu Lu
Here's a discussion about this. Ref: https://github.com/openssl/openssl/issues/8904 Cc: Jian J Wang Cc: Ting Ye Signed-off-by: Xiaoyu Lu Reviewed-by: Laszlo Ersek Tested-by: Gary Lin --- CryptoPkg/Library/OpensslLib/OpensslLib.inf | 60 +++ CryptoPkg/Libr

[edk2-devel] [PATCH v5 2/9] CryptoPkg/OpensslLib: Exclude unnecessary files in process_files.pl

2019-05-29 Thread Xiaoyu Lu
the STORE module(crypto/store/*). But UEFI don't use them. So exclude these files. Functions in crypto/rand/randfile.c OpenSSL and edk2 don't call them. And it requires more crt runtime support. So exclude it. Cc: Jian J Wang Cc: Ting Ye Signed-off-by: Xiaoyu Lu Reviewed-by: Laszlo Ersek Tested

[edk2-devel] [PATCH v5 9/9] CryptoPkg/BaseCryptLib: Make HMAC_CTX size backward compatible

2019-05-29 Thread Xiaoyu Lu
*GetContextSize). Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1792 But for compatiblility, temporarily change these definition of HMAC_*_CTX_SIZE. Cc: Jian J Wang Cc: Ting Ye Signed-off-by: Xiaoyu Lu Reviewed-by: Laszlo Ersek Tested-by: Gary Lin --- CryptoPkg/Library/BaseCryptLib/Hmac

[edk2-devel] [PATCH v5 7/9] CryptoPkg/OpensslLib: Add functions for upgrading OpenSSL1_1_1b

2019-05-29 Thread Xiaoyu Lu
add a new file(ossl_store.c) to implement ossl_store_cleanup_int function. Cc: Jian J Wang Cc: Ting Ye Signed-off-by: Xiaoyu Lu Tested-by: Gary Lin --- CryptoPkg/Library/OpensslLib/rand_pool_noise.h | 29 ++ CryptoPkg/Library/OpensslLib/ossl_store.c | 17 ++ CryptoPkg/Library

[edk2-devel] [PATCH v5 1/9] CryptoPkg/OpensslLib: Modify process_files.pl for upgrading OpenSSL

2019-05-29 Thread Xiaoyu Lu
(50eaac9f3337667259de725451f201e784599687) only support seeding NONE for UEFI(rand_unix.c line 93). This OpenSSL change was introduced in commit 8389ec4b4950 ("Add --with-rand-seed", 2017-07-22). So add --with-rand-seed=none to process_files.pl. Cc: Jian J Wang Cc: Ting Ye Signed-off-

Re: [edk2-devel] [PATCH 0/3] update ArmSoftFloatLib to latest upstream version

2019-05-27 Thread Xiaoyu Lu
f64_to_uint32 -0.1: 0 looks fine for me. I also did CryptoPkg tests with OpenSSL_1_1_1b, it works too. Tested-by: Xiaoyu Lu > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Ard Biesheuvel > Sent: Saturday, May 25, 2019 5:33 AM > T

Re: [edk2-devel] Problems using HTTPS boot: Http->Request can't find TLS Service Binding Protocol

2019-06-18 Thread Xiaoyu Lu
Hi bcran, I test this in my own environment, It works well. The edk2 commit id : f03859ea6c8fddeaa3a5cc3d9a3461 Build command: build -p ~/code/edk2/OvmfPkg/OvmfPkgX64.dsc -a X64 -t GCC5 -D NETWORK_TLS_ENABLE -D NETWORK_HTTP_BOOT_ENABLE DHCP server:

[edk2-devel] [PATCH v1 1/1] CryptoPkg/OpensslLib: Exclude err_all.c in process_files.py

2019-06-19 Thread Xiaoyu Lu
-by: Xiaoyu Lu --- CryptoPkg/Library/OpensslLib/process_files.pl | 1 + 1 file changed, 1 insertion(+) diff --git a/CryptoPkg/Library/OpensslLib/process_files.pl b/CryptoPkg/Library/OpensslLib/process_files.pl index e277108f0734..2783ff54f95a 100755 --- a/CryptoPkg/Library/OpensslLib/process_files.pl

[edk2-devel] [PATCH 1/1] CryptoPkg/OpensslLib: disable autoload-config for OpenSSL

2019-06-19 Thread Xiaoyu Lu
, So disable it. Re-run process_files.py to generate OpensslLib[Crypto].inf files. Cc: Jian J Wang Signed-off-by: Xiaoyu Lu --- CryptoPkg/Library/Include/openssl/opensslconf.h | 3 +++ CryptoPkg/Library/OpensslLib/process_files.pl | 1 + 2 files changed, 4 insertions(+) diff --git a/CryptoPkg

[edk2-devel] [PATCH 1/1] CryptoPkg/OpensslLib: Fix CR/LF issue

2019-06-19 Thread Xiaoyu Lu
Re-run process_files.py to generate OpensslLib[Crypto].inf. CryptoPkg/Library/Include/openssl/opensslconf.h is coped from OpenSSL, So keep the CR/LF style like OpenSSL source file. Cc: Jian J Wang Signed-off-by: Xiaoyu Lu --- CryptoPkg/Library/Include/openssl/opensslconf.h | 80

[edk2-devel] [PATCH v2 1/1] CryptoPkg/OpensslLib: disable autoload-config for OpenSSL

2019-06-19 Thread Xiaoyu Lu
OPENSSL_INIT_NO_LOAD_CONFIG flag. we don't use this feature, So disable it. Re-run process_files.py to generate OpensslLib[Crypto].inf files. Cc: Jian J Wang Cc: Laszlo Ersek Signed-off-by: Xiaoyu Lu Reviewed-by: Rebecca Cran Reviewed-by: Jian J Wang --- CryptoPkg/Library/Include/openssl

Re: [edk2-devel] Problems using HTTPS boot: Http->Request can't find TLS Service Binding Protocol

2019-06-19 Thread Xiaoyu Lu
Hi bcran, > -Original Message- > From: Rebecca Cran [mailto:rebe...@bluestop.org] > Sent: Wednesday, June 19, 2019 5:27 AM > To: Lu, XiaoyuX ; devel@edk2.groups.io > Cc: Wang, Jian J ; Laszlo Ersek > Subject: Re: [edk2-devel] Problems using HTTPS boot: Http->Request can't > find TLS

[edk2-devel] [PATCH v2 0/6] CryptoPkg: Upgrade OpenSSL to 1.1.1b

2019-05-09 Thread Xiaoyu lu
. (6) CryptoPkg/BaseCryptLib: Make HMAC_CTX size backward compatible Note: Will be remove next update. *** BLURB HERE *** Xiaoyu Lu (3): CryptoPkg/IntrinsicLib: Fix possible unresolved external symbol issue CryptoPkg: Upgrade OpenSSL to 1.1.1b CryptoPkg/BaseCryptLib: Make HMAC_CTX size

[edk2-devel] [PATCH v3 5/6] CryptoPkg: Upgrade OpenSSL to 1.1.1b

2019-05-13 Thread Xiaoyu lu
From: Xiaoyu Lu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 Update OpenSSL submodule to OpenSSL_1_1_1b OpenSSL_1_1_1b(50eaac9f3337667259de725451f201e784599687) Run process_files.pl script to regenerate OpensslLib[Crypto].inf and opensslconf.h Remove -DNO_SYSLOG from

[edk2-devel] [PATCH v3 0/6] CryptoPkg: Upgrade OpenSSL to 1.1.1b

2019-05-13 Thread Xiaoyu lu
/openssl/openssl/pull/4338 Cc: Jian J Wang Cc: Ting Ye Xiaoyu Lu (3): CryptoPkg/IntrinsicLib: Fix possible unresolved external symbol issue CryptoPkg: Upgrade OpenSSL to 1.1.1b CryptoPkg/BaseCryptLib: Make HMAC_CTX size backward compatible Xiaoyu lu (3): CryptoPkg/OpensslLib: Modify

[edk2-devel] [PATCH v3 2/6] CryptoPkg/OpensslLib: Exclude unnecessary files in process_files.pl

2019-05-13 Thread Xiaoyu lu
the STORE module(crypto/store/*). But UEFI don't use them. So exclude these files. Functions in crypto/rand/randfile.c OpenSSL and edk2 don't call them. And it requires more crt runtime support. So exclude it. Cc: Jian J Wang Cc: Ting Ye Signed-off-by: Xiaoyu Lu --- CryptoPkg/Library/OpensslLib

[edk2-devel] [PATCH v3 4/6] CryptoPkg/OpensslLib: Prepare for upgrading OpenSSL

2019-05-13 Thread Xiaoyu lu
environments by default. But this is only for OpenSSL compilation, no matter how the default options change. Due to --with-rand-seed=none, We need to provide a placeholder header file CryptoPkg/Library/Include/sys/syscall.h. Cc: Jian J Wang Cc: Ting Ye Signed-off-by: Xiaoyu Lu --- CryptoPkg/Library

[edk2-devel] [PATCH v3 1/6] CryptoPkg/OpensslLib: Modify process_files.pl for upgrading OpenSSL

2019-05-13 Thread Xiaoyu lu
(50eaac9f3337667259de725451f201e784599687) only support seeding NONE for UEFI(rand_unix.c line 93). This OpenSSL change was introduced in commit 8389ec4b4950 ("Add --with-rand-seed", 2017-07-22). So add --with-rand-seed=none to process_files.pl. Cc: Jian J Wang Cc: Ting Ye Signed-off-

[edk2-devel] [PATCH v3 6/6] CryptoPkg/BaseCryptLib: Make HMAC_CTX size backward compatible

2019-05-13 Thread Xiaoyu lu
From: Xiaoyu Lu Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 OpenSSL internally redefines the size of HMAC_CTX at crypto/hmac/hmac_lcl.h(OpenSSL commit e0810e35). Ref: https://github.com/openssl/openssl/pull/4338 We should not use it directly and should remove relevant

Re: [edk2-devel] [PATCH 2/3] CryptoPkg: Upgrade openssl to 1.1.1b

2019-05-13 Thread Xiaoyu lu
0% well-intended. If my comment still felt offensive, I apologize; it wasn't my intent. Thanks Laszlo > > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, April 30, 2019 2:02 AM > To: devel@edk2.groups.io; Lu, XiaoyuX > Cc: Wang, Jian

Re: [edk2-devel] [PATCH v3 0/6] CryptoPkg: Upgrade OpenSSL to 1.1.1b

2019-05-14 Thread Xiaoyu lu
14, 2019 8:06 PM > > To: devel@edk2.groups.io; g...@suse.com > > Cc: Lu, XiaoyuX ; Wang, Jian J > > ; Ye, Ting > > Subject: Re: [edk2-devel] [PATCH v3 0/6] CryptoPkg: Upgrade OpenSSL > > to 1.1.1b > > > > On 05/14/19 08:16, Gary Lin wrote: > > > On Mon,

Re: [edk2-devel] [PATCH v3 0/6] CryptoPkg: Upgrade OpenSSL to 1.1.1b

2019-05-15 Thread Xiaoyu lu
uX ; Wang, Jian J >>> ; Ye, Ting >>> Subject: Re: [edk2-devel] [PATCH v3 0/6] CryptoPkg: Upgrade OpenSSL >>> to 1.1.1b >>> >>> On 05/14/19 08:16, Gary Lin wrote: >>>> On Mon, May 13, 2019 at 09:24:39PM +0200, Laszlo Ersek wrote: >>>>

Re: [edk2-devel] [Patch V3] OpensslLib: Missing local header files in [Sources] section of .INFs

2019-05-22 Thread Xiaoyu Lu
Hi Christian, (1) We use OpenSSL configure script disabled some OpenSSL feature. But I saw you include all .h files from OpenSSL(only excluded some). Even some header files we don't need (In openssl/crypto/). Can you rule them out? I found OpenSSl use configdata.pm to store

Re: [edk2-devel] [PATCH v4 0/7] CryptoPkg: Upgrade OpenSSL to 1.1.1b

2019-05-18 Thread Xiaoyu Lu
essage- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Laszlo Ersek > Sent: Friday, May 17, 2019 2:26 AM > To: devel@edk2.groups.io; Lu, XiaoyuX > Cc: Wang, Jian J ; Ye, Ting > ; Ard Biesheuvel ; Leif > Lindholm > Subject: Re: [edk2-devel

Re: [edk2-devel] [PATCH v2 2/6] CryptoPkg/OpensslLib: Exclude unnecessary files in process_files.pl

2019-05-10 Thread Xiaoyu lu
c: Wang, Jian J ; Ye, Ting Subject: Re: [edk2-devel] [PATCH v2 2/6] CryptoPkg/OpensslLib: Exclude unnecessary files in process_files.pl On 05/09/19 07:23, Xiaoyu lu wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 > > When running process_files.py to configu

Re: [edk2-devel] [PATCH v2 5/6] CryptoPkg: Upgrade OpenSSL to 1.1.1b

2019-05-10 Thread Xiaoyu lu
-devel] [PATCH v2 5/6] CryptoPkg: Upgrade OpenSSL to 1.1.1b Hi Xiaoyu, On 05/09/19 07:23, Xiaoyu lu wrote: > From: Xiaoyu Lu > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 > > Update OpenSSL submodule to OpenSSL_1_1_1b > OpenSSL_1_1_1b(50eaac9f3337667259de725451

[edk2-devel] [PATCH 0/3] CryptoPkg: Upgrade OpenSSL to 1_1_1b

2019-04-29 Thread Xiaoyu lu
and Nt32Pkg. And also tested BaseCryptLib on various platform. It works well. Next we will enable SMx algorithm and TSL1.3 for uefi. Cc: Jian J Wang Cc: Ting Ye Xiaoyu Lu (3): CryptoPkg/IntrinsicLib: add ftol2 function CryptoPkg: Upgrade openssl to 1.1.1b CryptoPkg/BaseCryptLib: updata

[edk2-devel] [PATCH 2/3] CryptoPkg: Upgrade openssl to 1.1.1b

2019-04-29 Thread Xiaoyu lu
From: Xiaoyu Lu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 * update openssl submodule to OpenSSL_1_1_1b * run process_files.pl script to regenerate OpensslLib[Crypto].inf * remove NO_SYSLOG from OpensslLib[Crypto].inf * add -DOPENSSL_RAND_SEED_NONE to OpensslLib[Crypto].inf * add

[edk2-devel] [PATCH 1/3] CryptoPkg/IntrinsicLib: add ftol2 function

2019-04-29 Thread Xiaoyu lu
From: Xiaoyu Lu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 MSFT build support for building OpenSSL_1_1_1b add _ftol2 function Cc: Jian J Wang Cc: Ting Ye Signed-off-by: Xiaoyu Lu --- CryptoPkg/Library/IntrinsicLib/Ia32/MathFtol.c | 22 ++ CryptoPkg

[edk2-devel] [PATCH 3/3] CryptoPkg/BaseCryptLib: updata HMAC_ctx size

2019-04-29 Thread Xiaoyu lu
From: Xiaoyu Lu Openssl internally redefines the size of HMAC_CTX, but there is no external definition. So add an additional nubmer. Cc: Jian J Wang Cc: Ting Ye Signed-off-by: Xiaoyu Lu --- CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacMd5.c| 11 ++- CryptoPkg/Library

Re: [edk2-devel] [PATCH 2/3] CryptoPkg: Upgrade openssl to 1.1.1b

2019-04-30 Thread Xiaoyu lu
...@redhat.com] Sent: Tuesday, April 30, 2019 2:02 AM To: devel@edk2.groups.io; Lu, XiaoyuX Cc: Wang, Jian J ; Ye, Ting Subject: Re: [edk2-devel] [PATCH 2/3] CryptoPkg: Upgrade openssl to 1.1.1b Preliminary comments: On 04/29/19 10:15, Xiaoyu lu wrote: > From: Xiaoyu Lu > > R

[edk2-devel] [PATCH v2 3/6] CryptoPkg/IntrinsicLib: Fix possible unresolved external symbol issue

2019-05-08 Thread Xiaoyu lu
From: Xiaoyu Lu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 This is for the upcoming upgrade to OpenSSL_1_1_1b Compiler optimization(Visual Studio) may automatically use _ftol2 instead of some type conversion. For example: OpensslLib.lib(drbg_lib.obj) : error LNK2001

[edk2-devel] [PATCH v2 5/6] CryptoPkg: Upgrade OpenSSL to 1.1.1b

2019-05-08 Thread Xiaoyu lu
From: Xiaoyu Lu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 Update OpenSSL submodule to OpenSSL_1_1_1b OpenSSL_1_1_1b(50eaac9f3337667259de725451f201e784599687) Run process_files.pl script to regenerate OpensslLib[Crypto].inf and opensslconf.h Remove NO_SYSLOG from OpensslLib

[edk2-devel] [PATCH v2 1/6] CryptoPkg/OpensslLib: Modify process_files.pl for upgrading OpenSSL

2019-05-08 Thread Xiaoyu lu
(50eaac9f3337667259de725451f201e784599687) only support seeding NONE for UEFI(rand_unix.c line 93). So add --with-rand-seed=none to process_files.pl. Cc: Jian J Wang Cc: Ting Ye Signed-off-by: Xiaoyu Lu --- CryptoPkg/Library/OpensslLib/process_files.pl | 5 - 1 file changed, 4 insertions

[edk2-devel] [PATCH v2 4/6] CryptoPkg/OpensslLib: Prepare for upgrading OpenSSL

2019-05-08 Thread Xiaoyu lu
environments by default. But this is only for OpenSSL compilation, no matter how the default options change. Cc: Jian J Wang Cc: Ting Ye Signed-off-by: Xiaoyu Lu --- CryptoPkg/Library/OpensslLib/OpensslLib.inf | 16 ++-- CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 16

[edk2-devel] [PATCH v2 6/6] CryptoPkg/BaseCryptLib: Make HMAC_CTX size backward compatible

2019-05-08 Thread Xiaoyu lu
From: Xiaoyu Lu Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 OpenSSL internally redefines the size of HMAC_CTX at crypto/hmac/hmac_lcl.h(OpenSSL commit e0810e35). We should not use it directly and should remove relevant functions(Hmac*GetContextSize). But for compatiblility

[edk2-devel] [PATCH v2 2/6] CryptoPkg/OpensslLib: Exclude unnecessary files in process_files.pl

2019-05-08 Thread Xiaoyu lu
them. So exclude these files. This file, crypto/rand/randfile.c, have been modified between OpenSSL_1_1_0j(74f2d9c1ec5f5) and OpenSSL_1_1_1b(50eaac9f33376672). It requires more crt runtime support. But UEFI don't use it. So exclude the file. Cc: Jian J Wang Cc: Ting Ye Signed-off-by: Xiaoyu Lu

Re: [edk2-devel] [PATCH v4 6/7] CryptoPkg: Upgrade OpenSSL to 1.1.1b

2019-05-18 Thread Xiaoyu Lu
Sorry, no idea. Thanks Laszlo > > Thanks, > Xiaoyu > > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, May 17, 2019 12:32 AM > To: devel@edk2.groups.io; Lu, XiaoyuX ; Wang, > Jian J > Cc: Ye, Ting > Subject: Re: [edk2-dev

Re: [edk2-devel] [PATCH v4 0/7] CryptoPkg: Upgrade OpenSSL to 1.1.1b

2019-05-18 Thread Xiaoyu Lu
.groups.io; Lu, XiaoyuX Cc: Laszlo Ersek ; Wang, Jian J ; Ye, Ting Subject: Re: [edk2-devel] [PATCH v4 0/7] CryptoPkg: Upgrade OpenSSL to 1.1.1b On Thu, May 16, 2019 at 03:54:51AM -0400, Xiaoyu lu wrote: > This series is also available at: > https://github.com/xiaoyuxlu/edk

[edk2-devel] [PATCH v4 4/7] CryptoPkg/OpensslLib: Prepare for upgrading OpenSSL

2019-05-16 Thread Xiaoyu lu
environments by default. But this is only for OpenSSL compilation, no matter how the default options change. Cc: Jian J Wang Cc: Ting Ye Signed-off-by: Xiaoyu Lu Reviewed-by: Laszlo Ersek --- CryptoPkg/Library/OpensslLib/OpensslLib.inf | 16 ++-- CryptoPkg/Library/OpensslLib

[edk2-devel] [PATCH v4 0/7] CryptoPkg: Upgrade OpenSSL to 1.1.1b

2019-05-16 Thread Xiaoyu lu
H64 Xiaoyu Lu (6): CryptoPkg/OpensslLib: Modify process_files.pl for upgrading OpenSSL CryptoPkg/OpensslLib: Exclude unnecessary files in process_files.pl CryptoPkg/IntrinsicLib: Fix possible unresolved external symbol issue CryptoPkg/OpensslLib: Prepare for upgrading OpenSSL CryptoPkg: Upgr

[edk2-devel] [PATCH v4 2/7] CryptoPkg/OpensslLib: Exclude unnecessary files in process_files.pl

2019-05-16 Thread Xiaoyu lu
the STORE module(crypto/store/*). But UEFI don't use them. So exclude these files. Functions in crypto/rand/randfile.c OpenSSL and edk2 don't call them. And it requires more crt runtime support. So exclude it. Cc: Jian J Wang Cc: Ting Ye Signed-off-by: Xiaoyu Lu --- CryptoPkg/Library/OpensslLib

[edk2-devel] [PATCH v4 5/7] CryptoPkg/OpensslLib: Fix cross-build problem for AARCH64

2019-05-16 Thread Xiaoyu lu
From: Laszlo Ersek BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 Thanks Laszlo Ersek . Ref: https://edk2.groups.io/g/devel/message/40375 Cc: Jian J Wang Cc: Ting Ye Signed-off-by: Xiaoyu Lu --- CryptoPkg/Library/Include/sys/syscall.h | 11 +++ 1 file changed, 11

[edk2-devel] [PATCH v4 6/7] CryptoPkg: Upgrade OpenSSL to 1.1.1b

2019-05-16 Thread Xiaoyu lu
o CrtLibSupport.h. Here's a discussion about this. Ref: https://github.com/openssl/openssl/issues/8904 Cc: Jian J Wang Cc: Ting Ye Signed-off-by: Xiaoyu Lu --- CryptoPkg/Library/OpensslLib/OpensslLib.inf| 60 +++- CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 51 +++- C

[edk2-devel] [PATCH v4 1/7] CryptoPkg/OpensslLib: Modify process_files.pl for upgrading OpenSSL

2019-05-16 Thread Xiaoyu lu
(50eaac9f3337667259de725451f201e784599687) only support seeding NONE for UEFI(rand_unix.c line 93). This OpenSSL change was introduced in commit 8389ec4b4950 ("Add --with-rand-seed", 2017-07-22). So add --with-rand-seed=none to process_files.pl. Cc: Jian J Wang Cc: Ting Ye Signed-off-

[edk2-devel] [PATCH v4 3/7] CryptoPkg/IntrinsicLib: Fix possible unresolved external symbol issue

2019-05-16 Thread Xiaoyu lu
symbol __ftol2 This patch add _ftol2 function for the compiler intrinsic. Cc: Jian J Wang Cc: Ting Ye Signed-off-by: Xiaoyu Lu --- CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf | 4 +++- CryptoPkg/Library/IntrinsicLib/Ia32/MathFtol.c | 22 ++ 2 files changed, 25 insertions

[edk2-devel] [PATCH v4 7/7] CryptoPkg/BaseCryptLib: Make HMAC_CTX size backward compatible

2019-05-16 Thread Xiaoyu lu
*GetContextSize). Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1792 But for compatiblility, temporarily change these definition of HMAC_*_CTX_SIZE. Cc: Jian J Wang Cc: Ting Ye Signed-off-by: Xiaoyu Lu Reviewed-by: Laszlo Ersek --- CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacMd5.c| 8

Re: [edk2-devel] [PATCH v2 2/6] CryptoPkg/OpensslLib: Exclude unnecessary files in process_files.pl

2019-05-14 Thread Xiaoyu lu
lLib: Exclude unnecessary files in process_files.pl On 05/10/19 10:51, Xiaoyu lu wrote: > Hi, Laszlo: > > Thank you for your time. > > I try the method you mentioned. > >> (1) Therefore, the right thing to do here is to add "no-store" to the above &

Re: [edk2-devel] [PATCH v3 0/6] CryptoPkg: Upgrade OpenSSL to 1.1.1b

2019-05-14 Thread Xiaoyu lu
] CryptoPkg: Upgrade OpenSSL to 1.1.1b On 05/13/19 21:24, Laszlo Ersek wrote: > On 05/13/19 15:25, Xiaoyu lu wrote: >> (1) CryptoPkg/OpensslLib: Modify process_files.pl for upgrading >> OpenSSL OpenSSL only support seeding NONE for UEFI(rand_unix.c line >> 93). So add

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Add HOST_APPLICATION module type.

2019-07-03 Thread Xiaoyu Lu
g ; Yao, Jiewen > >Subject: [PATCH v1 1/1] BaseTools: Add HOST_APPLICATION module type. > > > >From: Jiewen Yao > > > >It can be used to indicate a module can be build to run > >as OS application and run in OS environment. > > > >Cc: Bob Feng > >C

[edk2-devel] [edk2-BuildSpecification PATCH] Document: Support HOST_APPLICATION ModuleType

2019-07-03 Thread Xiaoyu Lu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1952 INF spec add a new MODULE_TYPE HOST_APPLICATION, it indicate those modules that can run directly in OS environment. So BUILD spec also need be updated to support HOST_APPLICATION build. Cc: Liming Gao Cc: Jiewen Yao Signed-off-by: Xiaoyu

[edk2-devel] [edk2-InfSpecification PATCH] Document: Add new MODULE_TYPE HOST_APPLICATION

2019-07-03 Thread Xiaoyu Lu
. But there is no explicit MODULE_TYPE to indicate those modules. Difference: USER_DEFINED can be anyting, exe, bin, acpi table, etc. HOST_APPLICATION identify it is exe file. Add HOST_APPLICATION module type so it's easier to identify. Cc: Liming Gao Cc: Jiewen Yao Signed-off-by: Xiaoyu Lu

[edk2-devel] [edk2-InfSpecification PATCH v2] Document: Add new MODULE_TYPE HOST_APPLICATION

2019-07-05 Thread Xiaoyu Lu
. But there is no explicit MODULE_TYPE to indicate those modules. Difference: USER_DEFINED can be anyting, execuatable file, bin, acpi table, etc. HOST_APPLICATION identify it is a executable file. Add HOST_APPLICATION module type so it's easier to identify. Cc: Liming Gao Cc: Jiewen Yao Signed-off-by: Xiaoyu

Re: [edk2-devel] [edk2-InfSpecification PATCH] Document: Add new MODULE_TYPE HOST_APPLICATION

2019-07-04 Thread Xiaoyu Lu
> > > > > > >Background: > > > >Host-based Firmware Analyzer (HBFA) is a opensouce tools enables > > > advanced > > > >testing of UEFI and UEFI PI drivers in developer's OS environment. It > > > >will generate OS application whic

[edk2-devel] [edk2-DscSpecification PATCH v1] DSC document: Support HOST_APPLICATION ModuleType

2019-07-10 Thread Xiaoyu Lu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1952 INF spec add a new MODULE_TYPE HOST_APPLICATION, so this SPEC also need be updated to support this type. Cc: Liming Gao Cc: Jiewen Yao Signed-off-by: Xiaoyu Lu --- 1_introduction/12_terms.md | 6

[edk2-devel] [edk2-DecSpecification PATCH v1] DEC document: Add HOST_APPLICATION ModuleType

2019-07-09 Thread Xiaoyu Lu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1952 INF spec add a new ModuleType HOST_APPLICATION. DEC spec also need to be updated. Cc: Liming Gao Cc: Jiewen Yao Signed-off-by: Xiaoyu Lu --- 1_introduction/12_terms.md | 5

[edk2-devel] [PATCH v1 1/1] BaseTools: Add HOST_APPLICATION module type.

2019-07-01 Thread Xiaoyu Lu
From: Jiewen Yao It can be used to indicate a module can be build to run as OS application and run in OS environment. Cc: Bob Feng Cc: Liming Gao Cc: Jiewen Yao Signed-off-by: Xiaoyu Lu --- BaseTools/Conf/build_rule.template| 2 +- BaseTools/Source/Python/AutoGen/AutoGen.py

[edk2-devel][staging/edk2-host-test] Announce to create edk2-host-test branch in edk2-staging.

2019-07-01 Thread Xiaoyu Lu
I have created a branch in my fork edk2-staging (https://github.com/xiaoyuxlu/edk2-staging/tree/edk2-host-test). Edk2-host-test is separated from https://github.com/tianocore/edk2-staging/tree/HBFA. You can refer this for detail:

Re: [edk2-devel][staging/edk2-host-test] Announce to create edk2-host-test branch in edk2-staging.

2019-07-08 Thread Xiaoyu Lu
-staging/tree/edk2-host-test-not-related-to-edk2) Thanks, Xiaoyu. From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Xiaoyu Lu Sent: Monday, July 1, 2019 11:31 PM To: devel@edk2.groups.io Cc: Yao, Jiewen ; Gao, Liming ; Kinney, Michael D ; Wu, Chris Subject: [edk2-devel][staging

Re: [edk2-devel] [PATCH] Change package reviewer of CryptoPkg.

2019-09-16 Thread Xiaoyu Lu
Reviewed-by: Xiaoyu Lu > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ye, > Ting > Sent: Tuesday, September 17, 2019 8:44 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Ye, Ting > Subject: [edk2-devel] [PATCH] Ch

Re: [edk2-devel] [PATCH v3 0/2] Remove deprecated code in BaseCryptLib

2020-01-18 Thread Xiaoyu Lu
Hi Jian, The date of copyright info should be update to 2020 in each changed file. with these changed: Reviewed-by: Xiaoyu Lu Thanks. > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Wang, Jian J > Sent: Thursday, January 1

Re: [edk2-devel] [PATCH v2] CryptoPkg/Pkcs7: Extend support for other OID types

2020-04-09 Thread Xiaoyu Lu
org/show_bug.cgi?id=2539 > > Microsoft signtool supports creation of attached P7's with any OID payload > via the "/p7co" parameter. It is necessary to check the data before get > the string. > > Cc: Jian J Wang > Cc: Xiaoyu Lu > Signed-off-by: Guomin Jiang &

Re: [edk2-devel] [PATCH v2 1/2] CryptoPkg/BaseCryptLibOnProtocolPpi: Add missing comments

2020-03-27 Thread Xiaoyu Lu
Reviewed-by: Xiaoyu Lu > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > GuoMinJ > Sent: Thursday, March 5, 2020 2:41 PM > To: devel@edk2.groups.io > Cc: GuoMinJ ; Wang, Jian J > ; Lu, XiaoyuX > Subject: [edk2-devel]

Re: [edk2-devel] [PATCH v2 2/2] CryptoPkg/BaseHashApiLib: Rename BaseHashApiLib by HashApiLib

2020-03-27 Thread Xiaoyu Lu
Reviewed-by: Xiaoyu Lu > -Original Message- > From: GuoMinJ [mailto:newexplor...@gmail.com] > Sent: Thursday, March 5, 2020 2:41 PM > To: devel@edk2.groups.io > Cc: GuoMinJ ; Wang, Jian J > ; Lu, XiaoyuX > Subject: [PATCH v2 2/2] CryptoPkg/BaseHashApiLib:

Re: [edk2-devel] [PATCH V6 12/13] CryptoPkg/opensslconf.h: Covert the file ending to dos format

2020-05-17 Thread Xiaoyu Lu
cgi?id=1898 > > Convert file ending of the crypto created openssl config file - > opensslconf.h from '\n' to '\r\n' to make align the line ending and > pass the patch check. > > Cc: Jian J Wang > Cc: Xiaoyu Lu > Cc: Siyuan Fu > Cc: Michael D Kinney > Cc: Jiewen Yao > Cc: L

Re: [edk2-devel] [edk2/master PATCH RISC-V CI Code Changes v1 05/11] CryptoPkg: Add RISC-V architecture for EDK2 CI.

2020-03-17 Thread Xiaoyu Lu
Reviewed-by: Xiaoyu Lu > -Original Message- > From: Abner Chang [mailto:abner.ch...@hpe.com] > Sent: Friday, March 6, 2020 1:36 PM > To: devel@edk2.groups.io > Cc: abner.ch...@hpe.com; Daniel Schaefer ; > Wang, Jian J ; Lu, XiaoyuX ; > Leif Lindholm ; Gilbert C

[edk2-devel] [PATCH] CryptoPkg/BaseCryptLib: Enabled CryptSha512 for Smm drivers.

2021-05-31 Thread Xiaoyu Lu
From: Shengfengx Xue in SmmCryptLib.inf, change CryptSha512NULL.c to CryptSha512.c. Signed-off-by: Shengfengx Xue --- CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf

[edk2-devel] [PATCH v1 1/1] Maintainers.txt: Update email address

2022-02-07 Thread Xiaoyu Lu
Update Email address for Xiaoyu Lu. CC: Jiewen Yao CC: Jian J Wang Signed-off-by: Xiaoyu Lu --- Maintainers.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Maintainers.txt b/Maintainers.txt index 4c5d3111c2ec..b845943a2a5d 100644 --- a/Maintainers.txt +++ b

[edk2-devel] [PATCH v1 1/1] Maintainers.txt: Update email address

2022-02-07 Thread Xiaoyu Lu
Update Email address for Xiaoyu Lu. CC: Jiewen Yao CC: Jian J Wang Signed-off-by: Xiaoyu Lu --- Maintainers.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Maintainers.txt b/Maintainers.txt index 4c5d3111c2ec..b845943a2a5d 100644 --- a/Maintainers.txt +++ b

Re: [edk2-devel] [PATCH EDK2 v1 1/1] CryptoPkg/BaseCryptLib:Remove redundant init

2022-09-15 Thread Xiaoyu Lu
Reviewed-by: Xiaoyu Lu -Original Message- From: Wenyi Xie Sent: Thursday, September 15, 2022 5:26 PM To: devel@edk2.groups.io; Yao, Jiewen ; Wang, Jian J ; Lu, Xiaoyu1 ; Jiang, Guomin Cc: songdongku...@huawei.com; xiewen...@huawei.com Subject: [PATCH EDK2 v1 1/1] CryptoPkg