provide feedback via
gitbook.com.
Changes from v1 to v2:
Removed the link to Gitbook in Readme.md.
Rebecca Cran (2):
Readme.md: convert links from Gitbook to Github Pages
Readme.md: Update the Gitbook documentation section
Readme.md | 124 +---
1 file changed, 55 insertions
pts/SetupGit.py"
for the repo please?
It makes several additions to .git/config, including:
[format]
coverLetter = True
numbered = True
signoff = False
[sendemail]
chainreplyto = False
thread = True
transferEncoding = 8bit
to = devel@edk2.gr
': 'transferEncoding', 'value':
'8bit'},
+ {'section': 'alias', 'option': 'fp', 'value': 'format-patch
-M --stat=1000 --stat-graph-width=20'},^M
]
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102568
Pushed as
https://github.com/tianocore/edk2/commit/2bb693894920e634153275bea60278a9f192a8ef
--
Rebecca Cran
On 4/5/23 11:15 AM, Rebecca Cran wrote:
Reviewed-by: Rebecca Cran
On 3/30/23 3:48 AM, Patrick Rudolph wrote:
The clang toolchain might default to fPIE/fPIC, which prevents
lld
Reviewed-by: Rebecca Cran
On 3/30/23 3:48 AM, Patrick Rudolph wrote:
The clang toolchain might default to fPIE/fPIC, which prevents
lld from linking the objects into a binary.
Specify -fno-pie -fno-pic as done on GCC to fix linking.
Test:
Building the Universal Payload using the command
Sorry for the delay. I've just sent my reviewed-by.
On 4/4/23 3:46 AM, Ard Biesheuvel wrote:
Thanks all
Ray, any comments on this version? Thanks.
Liming, Rebecca, any comments on the BaseTools changes?
On Tue, 4 Apr 2023 at 09:57, Marvin Häuser wrote:
FWIW, Reviewed-by: Marvin Häuser
Reviewed-by: Rebecca Cran
--
Rebecca Cran
On 4/3/23 8:29 AM, Ard Biesheuvel wrote:
We rely on PIE executables to get the codegen that is suitable for
PE/COFF conversion where the resulting executables can be loaded
anywhere in the address space.
However, ELF linkers may default
Update the antlr makefile to remove the explicit setting of CC to either
clang or gcc. This causes it to use /usr/bin/cc or whatever the user has
set $(CC) to.
This removes the last dependency on gcc for BaseTools.
Signed-off-by: Rebecca Cran
---
BaseTools/Source/C/VfrCompile/Pccts/antlr
Bump the version of edk2-basetools in pip-requirements.txt to 0.1.43.
This version contains the update to generate makefiles with both
CFLAGS and BUILD_CFLAGS.
Signed-off-by: Rebecca Cran
---
pip-requirements.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pip
Thanks, deprecating it for a while makes a lot of sense. We can consider
removing it in 6-12 months maybe?
--
Rebecca Cran
On 4/4/2023 12:29 PM, Kinney, Michael D wrote:
Add GCC and leave GCC5 for now and give time for all downstream
consumers to accommodate the name change.
At a later
builds on GCC _6_ and newer, since we don't
specify -std=c++11. Which makes this discussion even more ridiculous IMO.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102517): https://edk2.groups.io/g/devel/message
I've already added changes to the patch series to fix EDK2 CI to use the
new name. Fortunately there aren't many places that need updated.
Downstream scripts should be trivial to change: just do a find/replace
for GCC5.
--
Rebecca Cran
On 4/4/23 11:45 AM, Kinney, Michael D wrote
On 4/4/23 10:32 AM, Leif Lindholm wrote:
On Tue, Apr 04, 2023 at 16:57:18 +0100, Pedro Falcato wrote:
On Tue, Apr 4, 2023 at 4:49 PM Rebecca Cran wrote:
Okay. I'll rework the patch series to only delete GCC48 and keep GCC49
and GCC5.
Please rename them? There's no point in keeping
Okay. I'll rework the patch series to only delete GCC48 and keep GCC49
and GCC5.
--
Rebecca Cran
On 4/3/23 7:31 PM, gaoliming wrote:
Rebecca:
There are more discussion on GCC49 tool chain. So, I think it is the safe
way to keep GCC49 and GCC5 now. We can make the changes for other tool
On 4/4/23 1:22 AM, Ard Biesheuvel wrote:
On Mon, 3 Apr 2023 at 22:33, Rebecca Cran wrote:
As part of my work on the toolchain definitions, I've come across a
situation where ld.lld fails to align sections correctly, due to it
being invoked via clang with the '-n' option, which causes GenFw
CC_FLAGS2 also needs to be set when running on Windows, otherwise the
wrong line is added and nmake fails when building using Visual Studio.
Signed-off-by: Rebecca Cran
---
edk2basetools/Workspace/DscBuildData.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/edk2basetools/Workspace
Bump the version of edk2-basetools in pip-requirements.txt to 0.1.42.
This version contains the update to generate makefiles with both
CFLAGS and BUILD_CFLAGS.
Signed-off-by: Rebecca Cran
---
pip-requirements.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pip
On 4/3/23 2:58 PM, Marvin Häuser wrote:
That last part is actually not ignoring the use-case, that *is* our use-case.
The terminology again is very OS-oriented, it’s important to know that
generally OSes will fail to load binaries that are aligned less than the
platform page size, as they
should we just use
CONSTANT(MAXPAGESIZE) and ignore how it's normally used to specify the
maximum allowable page size for an executable?
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102440): https://edk2.groups.io/g/dev
I wonder if it might be possible to get the total time to be under 10
minutes by adding more agents?
--
Rebecca Cran
On 4/3/23 1:42 PM, Kinney, Michael D wrote:
Rebecca,
I have a test PR running that splits up CodeQL analysis
and builds to attempt to balance the execution times.
https
Mike, Liming:
Could you review/approve this v2 patch please?
Thanks.
Rebecca Cran
On 3/31/23 7:48 AM, Rebecca Cran wrote:
In order to support building BaseTools using non-default compilers, a
change is being made in the edk2 BaseTools directory to remove the
'BUILD_' prefix to CC, CXX
=85605=logs=c0929384-5a08-5c0f-b36d-6f51b6b81732=f12d60be-1b97-57a4-b1ea-5aae2f026d4f)
It shows two tasks taking 13 minutes each.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102404): https://edk2.groups.io/g
On 4/3/23 7:44 AM, Pedro Falcato wrote:
On Mon, Apr 3, 2023 at 1:27 PM Rebecca Cran wrote:
In terms of CI coverage, I'd like to have both gcc 6 and gcc 12 running
GCC and GCCNOLTO builds: we've already broken gcc 5 compatibility by
introducing GoogleTest (which uses nullptr), so by doing
-larger-runners),
but I'm wondering if we might want to scale using something like Azure
or EC2 (https://github.com/machulav/ec2-github-runner) instead, if the
costs aren't going to be prohibitive?
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent
a known broken toolchain
around.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102391): https://edk2.groups.io/g/devel/message/102391
Mute This Topic: https://groups.io/mt/97919856/21656
Group Owner: devel+ow...@edk2
ts to keep it, let's make all the other changes
(deleting VS 2008-2013, CLANG35, CLANG38 etc.) and keep GCCNOLTO and GCC
for now. If nobody fixes the problems with GCCNOLTO, maybe we can
revisit dropping it in a few months?
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You r
uild end time: 09:38:34, Apr.02 2023
Build total time: 00:00:14
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102361): https://edk2.groups.io/g/devel/message/102361
Mute This Topic: https://groups.io/mt/97919856/2165
11th September 2018, and so it will be
considered EOL on 11th September 2023. It will no longer be receiving
publicly available security fixes after that date."
--
Rebecca Cran
On 3/16/23 10:28 PM, Li, Yi wrote:
Please check the patch series if interested.
PR: https://github.com/tian
This isn't a problem with _this_ patch, but just a note that ReadMe.rst
is outdated because it mentions Ubuntu_GCC5, ArmVirtPkg_Ubuntu_GCC5 etc.
while it looks like we've been using Fedora images for a while.
--
Rebecca Cran
On 3/14/23 9:21 AM, Oliver Steffen wrote:
Switch to the new
I've been wondering, is it possible to increase the parallelism or add
more resources to the CI runner pool?
--
Rebecca Cran
On 3/31/23 12:22 PM, Ni, Ray wrote:
The random test cases just run for too long that may cause timeout
in CI test.
Disable them for now.
Signed-off-by: Ray Ni
Andrew and Rebecca. I don’t know anyone else who might still be using
XCODE5. Any objections to dropping it? If so, any plans to pick up my proposed
changes instead?
I've only been using XCODE5 to test if it still works. I do all of my
development work on Linux or FreeBSD.
--
Rebecca Cran
Changes in v2:
Generate Makefiles with both BUILD_CFLAGS and CFLAGS for compatibility
until everyone's moved to a version of edk2 that expects CFLAGS.
Rebecca Cran (1):
Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change
edk2basetools/Workspace/DscBuildData.py | 6 +-
1 file
Makefiles with both BUILD_CFLAGS and
CFLAGS for compatibility until everyone is using a version of
edk2 that expects CFLAGS.
Signed-off-by: Rebecca Cran
---
edk2basetools/Workspace/DscBuildData.py | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/edk2basetools/Workspace
Good idea. I'll send out a v2 patch with that change.
On 3/30/23 2:09 PM, Kinney, Michael D wrote:
Rebecca,
In order to avoid issues with the order or timing or merges, could
CFLAGS be added in one set of patches and then later remove BUILD_CLAGS
in a second set of patches?
Mike
Makefiles with CFLAGS instead of
BUILD_CFLAGS.
Signed-off-by: Rebecca Cran
---
edk2basetools/Workspace/DscBuildData.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/edk2basetools/Workspace/DscBuildData.py
b/edk2basetools/Workspace/DscBuildData.py
index ff5662f35702
Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change
This should be merged at the same time as the edk2 patch that supports
passing CC and CXX to make when building BaseTools.
Rebecca Cran (1):
Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change
edk2basetools/Workspace
and an M1 MacBook Pro.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102197): https://edk2.groups.io/g/devel/message/102197
Mute This Topic: https://groups.io/mt/97947477/21656
Group Owner: devel+ow...@edk2.groups.io
Update Maintainers.txt for BaseTools: move Bob Feng from being a
maintainer to reviewer, and add myself (Rebecca Cran) as a new
maintainer.
Signed-off-by: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
---
Maintainers.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
ss -f") that lld is indeed getting invoked, and that the
resulting binaries run fine using qemu-system-arm and qemu-system-aarch64.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102111): https://edk2.groups.io/g/dev
mented in tools_def.template (and
updated at times)
We need a minimum of GCC 6 to run CI because
UnitTestFrameworkPkg/Library/GoogleTestLib uses nullptr that GCC 5
doesn't support, so the GCC5 name is wrong anyway.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this
For a while I've been irritated at having to open a web browser to check
the status of CI tasks for my GitHub PRs.
Fortunately I mentioned on the UEFI Talkbox channel about wanting to
write a tool that uses the GitHub API to query the status, and JoeyV
pointed out that the 'gh' tool
that could be interesting as well.
I agree, it's not ideal. My knowledge of linker issues is relatively
limited at the moment, which is why I decided not to use LLD when I saw
it was failing.
I can spend some time learning about it and send out a v3 with LLD
enabled for ARM.
--
Rebecca Cran
Signed-off-by: Rebecca Cran
---
UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc | 4 +-
IntelFsp2Pkg/Tools/Tests/QemuFspPkg.dsc | 12 +-
CryptoPkg/Library/OpensslLib/OpensslLib.inf | 2 +-
CryptoPkg/Library/OpensslLib
Bump tools_def.txt VERSION to 3.0 for the deletion of VS2008-VS2013,
CLANG35, CLANG38, GCC48, GCC49 and the renaming of GCC5 to GCC.
Signed-off-by: Rebecca Cran
---
BaseTools/Conf/tools_def.template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/BaseTools/Conf
Signed-off-by: Rebecca Cran
---
BaseTools/Conf/tools_def.template | 4
1 file changed, 4 deletions(-)
diff --git a/BaseTools/Conf/tools_def.template
b/BaseTools/Conf/tools_def.template
index 3a60fe9b5965..fc1cda24bedf 100755
--- a/BaseTools/Conf/tools_def.template
+++ b/BaseTools/Conf
be merged in future with the single
version using `lea`.
Signed-off-by: Rebecca Cran
---
OvmfPkg/OvmfPkgX64.dsc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc
index 00f7005fca40..c30f4f6db832 100644
--- a/OvmfPkg/OvmfPkgX64.dsc
Since Visual Studio versions older than VS2015 are no longer supported,
remove mention of them from edksetup.bat.
Signed-off-by: Rebecca Cran
Reviewed-by: Oliver Smith-Denny
---
edksetup.bat | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/edksetup.bat b/edksetup.bat
-off-by: Rebecca Cran
Reviewed-by: Oliver Smith-Denny
---
BaseTools/Conf/tools_def.template | 98
1 file changed, 98 deletions(-)
diff --git a/BaseTools/Conf/tools_def.template
b/BaseTools/Conf/tools_def.template
index 7cf1617b6f71..831733ceeae0 100755
--- a/BaseTools/Conf
Remove the unused IPHONE_TOOLS and SOURCERY_CYGWIN_TOOLS definitions
from Conf/tools_def.template.
Signed-off-by: Rebecca Cran
Reviewed-by: Oliver Smith-Denny
---
BaseTools/Conf/tools_def.template | 4
1 file changed, 4 deletions(-)
diff --git a/BaseTools/Conf/tools_def.template
b
Since Visual Studio versions older than VS2015 are no longer supported,
remove mention of them from MdePkg.
Signed-off-by: Rebecca Cran
Reviewed-by: Oliver Smith-Denny
---
MdePkg/Include/Ia32/ProcessorBind.h | 8 ++--
MdePkg/Include/X64/ProcessorBind.h | 8 ++--
2 files changed, 4
Remove remnants of Visual Studio 2008-2013 support from
Conf/tools_def.txt and various batch scripts.
Signed-off-by: Rebecca Cran
Reviewed-by: Oliver Smith-Denny
---
BaseTools/Conf/tools_def.template | 12
BaseTools/Scripts/SetVisualStudio.bat | 22 +--
BaseTools/Scripts
With recent changes, Visual Studio versions older than VS2015 are
unable to build EDK2 code.
To avoid confusion, remove VS2008, 2010, 2012 and 2013 toolchain
definitions from Conf/tools_def.template, leaving only versions that can
be used to successfully build firmware.
Signed-off-by: Rebecca
being 16.0.0, versions 3.5 and 3.9 are
obsolete and can be removed.
Signed-off-by: Rebecca Cran
---
BaseTools/Conf/tools_def.template | 453
1 file changed, 171 insertions(+), 282 deletions(-)
diff --git a/BaseTools/Conf/tools_def.template
b/BaseTools/Conf/tools_def.template
With the removal of CLANG35 and CLANG38 and the update of the CLANGDWARF
toolchain definition in Conf/tools_def.txt update the compiler flags in
BaseCryptLib and OpensslLib.
Signed-off-by: Rebecca Cran
Reviewed-by: Oliver Smith-Denny
---
CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
Replace the static struct initialization with a call to ZeroMem to avoid
generating a call to memset in certain build configurations.
Signed-off-by: Rebecca Cran
Reviewed-by: Gerd Hoffmann
Reviewed-by: Oliver Smith-Denny
---
OvmfPkg/Library/PlatformInitLib/MemDetect.c | 4 +++-
1 file changed
with the new GCC
definitions.
- Bumped VERSION from 2.00 to 3.00 to inform users that they should
updated their Conf/tools_def.txt.
Rebecca Cran (13):
OvmfPkg: Replace static struct initialization with ZeroMem call
CryptoPkg: Add CLANGDWARF and remove CLANG35 and CLANG38 compiler
flags
https://github.com/tianocore/edk2-basetools/pull/55 .
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102037): https://edk2.groups.io/g/devel/message/102037
Mute This Topic: https://groups.io/mt/97909658/21656
Group Owner
/containers/pull/69 .
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102036): https://edk2.groups.io/g/devel/message/102036
Mute This Topic: https://groups.io/mt/97902121/21656
Group Owner: devel+ow...@edk2.groups.io
Reviewed-by: Rebecca Cran
On 3/9/23 12:43 PM, Kun Qin wrote:
From: Sean Brogan
Create SECURITY.md security policy for tianocore edk2 leveraging CVD and
the Github Private Vulnerability Reporting process.
Co-authored-by: Sean Brogan
Signed-off-by: Kun Qin
---
SECURITY.md | 33
The CONTRIBUTING.md file in https://github.com/tianocore/containers says
that GitHub Pull Requests are used for contributions.
I was wondering if that's correct, or if patches should be sent to this
mailing list instead (or in addition)?
Thanks.
Rebecca Cran
installed?
--
Rebecca Cran
On 3/22/23 4:46 PM, Guo, Gua wrote:
For "where clang"
For full build log based on
About Fail full log and Pass full log
> git clone https://github.com/bcran/edk2.git --recursive
> git checkout clangdwarf
> edksetup Rebuild
> py -3 UefiPayloa
Reviewed-by: Rebecca Cran
On 3/24/23 4:30 PM, Michael Kubacki wrote:
From: Michael Kubacki
Purdue Compiler Construction Tool Set (PCCTS) source code was copied/
pasted into BaseTools/Source/C/VfrCompile/Pccts/.
The code contains tab characters instead of spaces.
PatchCheck.py gives
scBuildData.py which is
still setting BUILD_CFLAGS instead of CFLAGS., and it's that copy that
the stuart tools use.
I'm not sure how we should coordinate changes between the two repos,
since it's a breaking change.
--
Rebecca Cran
On 3/23/23 10:57 PM, gaoliming wrote:
Rebecca:
I create P
ou update your patch with my
"os.path.basename(self.filename).lower() == 'makefile' " change please?
--
Rebecca Cran
On 3/24/23 2:52 PM, Rebecca Cran wrote:
I sent out a patch to fix this same issue earlier today!
I took a slightly different approach: see "[edk2-devel
I sent out a patch to fix this same issue earlier today!
I took a slightly different approach: see "[edk2-devel] [PATCH v2 1/1]
BaseTools/Scripts/PatchCheck.py: Improve check for Makefiles"
diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck.py
index
er-case 'M':
./BaseTools/Source/C/VfrCompile/Pccts/support/genmk/makefile
./BaseTools/Source/C/VfrCompile/Pccts/support/rexpr/makefile
./BaseTools/Source/C/VfrCompile/Pccts/antlr/makefile
./BaseTools/Source/C/VfrCompile/Pccts/dlg/makefile
I've sent out a v2 revision.
--
Re
e
are some Makefiles named 'makefile' instead of 'Makefile'.
Signed-off-by: Rebecca Cran
---
BaseTools/Scripts/PatchCheck.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck.py
index fcdabfc8acea..241467f10
Pull Request: https://github.com/tianocore/edk2/pull/4176
Branch: https://github.com/bcran/edk2/tree/patchcheck_makefiles
On 3/24/23 10:32 AM, Rebecca Cran wrote:
When checking for Makefiles, in addition to Makefile and GNUmakefile,
also check for *.makefile: this allows {header,footer,app
When checking for Makefiles, in addition to Makefile and GNUmakefile,
also check for *.makefile: this allows {header,footer,app,lib}.makefile
in BaseTools/Source/C/Makefiles to be detected and avoid having
PatchCheck.py complain about tab characters.
Signed-off-by: Rebecca Cran
---
BaseTools
Hi Liming,
Could you review this patch please?
I've dropped the 3rd patch which was running Uncrustify over the code,
so this is the only one left before I can merge the series.
Thanks.
Rebecca Cran
On 2/24/23 5:54 PM, Rebecca Cran wrote:
Replace the duplicate __PcdSet prototype
The linker problems I was seeing were unrelated to those Patrick's patch
fixed.
I just applied Patrick's changes on top of my CLANGDWARF patches and
OvmfPkgIa32.dsc builds fine.
--
Rebecca Cran
On 3/17/23 2:35 PM, Rebecca Cran wrote:
Building with "build -p OvmfPkg/OvmfPkgX64.dsc -
Sorry, I didn't realize there were people still using older builds of VS
2015.
--
Rebecca Cran
On 3/22/23 7:43 PM, Huang, Yanbo wrote:
Hi Rebecca,
The commit message “Visual Studio versions before VS 2015 don't support
__func__” may cause confuse since some of the older release of VS2015
/ArmVirtQemu-AARCH64/RELEASE_CLANGDWARF/AARCH64/ArmVirtPkg/MemoryInitPei/MemoryInitPeim/DEBUG/MemoryInit.dll
due to its size (> 1 MB), this module requires 4 KB section alignment.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Re
I've created https://bugzilla.tianocore.org/show_bug.cgi?id=4384 .
--
Rebecca Cran
On 3/22/23 7:05 PM, gaoliming wrote:
Rebecca:
Can you submit BZ for this change? This change belongs to the feature. I
would like to add it into stable tag feature planning.
Thanks
Liming
-邮件原件
Also "where clang" please.
And could you provide more of the build output please? Perhaps on
https://pastebin.com/ ?
Thanks.
Rebecca Cran
On 3/22/23 4:07 PM, Guo, Gua wrote:
Mine are:
-Original Message-----
From: Rebecca Cran
Sent: Wednesday, March 22, 2023 9:11 PM
To
Can we not require that VS2015 Update 3 is installed?
Do people have reasons to be running older builds, or is it just that
they forget to install the updates?
--
Rebecca Cran
On 3/22/23 10:58 AM, Kinney, Michael D wrote:
Hi Rebecca,
It appears that some of the older release of VS2015 do
ais", and after, "Français".
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101589): https://edk2.groups.io/g/devel/message/101589
Mute This Topic: https://groups.io/mt/97671520/21656
Group Owner: devel+ow...@edk
source edksetup.sh
o make -C BaseTools
o python3 UefiPayloadPkg/UniversalPayloadBuild.py -t GCC5
Thanks,
Gua
-Original Message-
From: devel@edk2.groups.io On Behalf Of Rebecca
Cran
Sent: Wednesday, March 22, 2023 9:31 AM
To: devel@edk2.groups.io; Kinney, Michael D
cPeiCpuExceptionHandlerLib.inf
!else
Can you please check whether this works for you as well?
Thanks, that works here too!
Do we still need to keep CLANG35 and CLANG38 toolchains for
compatibility with the ARM toolchain? Or have things moved on so they
_can_ be removed?
--
Rebecca Cran
-=-
Remove remnants of Visual Studio 2008-2013 support from
Signed-off-by: Rebecca Cran
---
BaseTools/Conf/tools_def.template | 12
BaseTools/Scripts/SetVisualStudio.bat | 22 +--
BaseTools/Scripts/ShowEnvironment.bat | 44 --
BaseTools/get_vsvars.bat | 13
The edk2-stable202302 release was the last to support building
EFI Byte Code drivers.
Remove the definitions for Intel's EBC compiler from
Conf/tools_def.template.
Signed-off-by: Rebecca Cran
---
BaseTools/Conf/tools_def.template | 98
1 file changed, 98 deletions(-)
diff
Remove the unused IPHONE_TOOLS and SOURCERY_CYGWIN_TOOLS definitions
from Conf/tools_def.template.
Signed-off-by: Rebecca Cran
---
BaseTools/Conf/tools_def.template | 4
1 file changed, 4 deletions(-)
diff --git a/BaseTools/Conf/tools_def.template
b/BaseTools/Conf/tools_def.template
Since Visual Studio versions older than VS2015 are no longer supported,
remove mention of them from edksetup.bat.
Signed-off-by: Rebecca Cran
---
edksetup.bat | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/edksetup.bat b/edksetup.bat
index 7ad137bb3e9b..2fdf130e00e2
Since Visual Studio versions older than VS2015 are no longer supported,
remove mention of them from MdePkg.
Signed-off-by: Rebecca Cran
---
MdePkg/Include/Ia32/ProcessorBind.h | 8 ++--
MdePkg/Include/X64/ProcessorBind.h | 8 ++--
2 files changed, 4 insertions(+), 12 deletions(-)
diff
With recent changes, Visual Studio versions older than VS2015 are
unable to build EDK2 code.
To avoid confusion, remove VS2008, 2010, 2012 and 2013 toolchain
definitions from Conf/tools_def.template, leaving only versions that can
be used to successfully build firmware.
Signed-off-by: Rebecca
ionHandlerLib/OUTPUT/X64/ExceptionHandlerAsm.iii
>>> ExceptionHandlerAsm.obj:(.text+0x14) in archive
>>> edk2/Build/OvmfX64/RELEASE_CLANGDWARF/X64/UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuExceptionHandlerLib/OUTPUT/SecPeiCpuExceptionHandlerLib.lib
To avoid th
With the removal of CLANG35 and CLANG38 and the update of the CLANGDWARF
toolchain definition in Conf/tools_def.txt update the compiler flags in
BaseCryptLib and OpensslLib.
Signed-off-by: Rebecca Cran
---
CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf | 3 +--
CryptoPkg/Library
from the
various packages etc. will be done in a follow-up patch series.
- Remove unused IPHONE_TOOLS and SOURCERY_CYGWIN_TOOLS definitions.
Personal GitHub PR: https://github.com/tianocore/edk2/pull/4158
GitHub branch: https://github.com/bcran/edk2/tree/clangdwarf
Rebecca Cran (9):
OvmfPkg
Replace the static struct initialization with a call to ZeroMem to avoid
generating a call to memset in certain build configurations.
Signed-off-by: Rebecca Cran
---
OvmfPkg/Library/PlatformInitLib/MemDetect.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/OvmfPkg
first,
+ if it is invalid then PcdFirmwareVersionString is used as a fallback.
+
+ @retval VOID
**/
-CHAR16 *
-GetBiosVersion (
+VOID
+SetBiosVersion (
VOID
)
Don't use @retval on a function that doesn't return anything.
With that fixed:
Reviewed-by: Rebecca Cran
--
Rebecca Cran
Sorry, I don't think I saw a suggestion from you to not set CC - though
I may have missed emails since this patch series was sent from the email
of my former employer.
Marvin did suggest that though, so I can certainly add another patch to
the series to do that.
--
Rebecca Cran
On 3/20
nHandlerLib/OUTPUT/SecPeiCpuExceptionHandlerLib.lib
Thinking about it, it might actually be a problem with the FreeBSD
system toolchain. On Linux, I get a different set of errors about
redefining uint64_t etc.
--
Rebecca Cran
On 3/17/23 11:44 AM, Marvin Häuser wrote:
Which error precisely?
X64
I've also seen that error building X64 firmware.
Could you update those flags too, please?
--
Rebecca Cran
On 3/17/23 8:06 AM, Patrick Rudolph wrote:
The clang toolchain might default to fPIE/fPIC, which prevents
lld from linking the objects into a binary.
Specify -fno-pie -fno-pic
haven't enjoyed the GitHub UI compared to Gitlab or Phabricator, but I
can live with it without too much frustration.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101345): https://edk2.groups.io/g/devel/message
On 3/17/23 8:08 AM, Marvin Häuser wrote:
On 17. Mar 2023, at 14:44, Gerd Hoffmann wrote:
Yes, this. For active PRs this usually isn't much of a problem. But
try come back after a few months, or even a few years (see Rebecca
trying to lookup context for a 2016 commit in the archives).
I also
that the stuart tools don't support anything older
than VS2017 I'm thinking this is okay, but I want to double check before
pushing this change.
--
Rebecca Cran
On 3/14/23 2:40 PM, Kinney, Michael D wrote:
Reviewed-by: Michael D Kinney
-Original Message-
From: devel@edk2.groups.io On Behalf
On 3/17/23 6:32 AM, Marvin Häuser wrote:
On 17. Mar 2023, at 11:36, Rebecca Cran wrote:
I like that proposed workflow.
I've also been wondering if we could consider choosing a different
product for patch reviews that supports our desired workflow better,
such as Gitlab or Phorge (the new
BaseTools GnuMakefile: Update GCC Flags to the specific one with
BUILD_ prefix
On 3/17/23 4:48 AM, Rebecca Cran wrote:
Talking about mailing lists, I'm still disappointed that we lost so
much history of discussion and reviews around the project when the
edk2-devel archive at lists.01.org was deleted
been lost.
--
Rebecca Cran
On 3/17/23 3:33 AM, Gerd Hoffmann wrote:
On Thu, Mar 16, 2023 at 01:59:49PM -0600, Rebecca Cran wrote:
Is this still a requirement since Laszlo's departure from the project?
I seem to recall it was him who made it a sticking point of moving to a
GitHub PR workflow
if it was
perhaps the result of a misunderstanding.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101330): https://edk2.groups.io/g/devel/message/101330
Mute This Topic: https://groups.io/mt/97022154/21656
Group
401 - 500 of 1515 matches
Mail list logo
